1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
|
// RUN: %check_clang_tidy %s bugprone-incorrect-roundings %t
void b(int x) {}
void f1() {
float f;
double d;
long double ld;
int x;
x = (d + 0.5);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5) to integer leads to incorrect rounding; consider using lround (#include <cmath>) instead [bugprone-incorrect-roundings]
x = (d + 0.5f);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (d + 0.5L);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (f + 0.5);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (f + 0.5f);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (f + 0.5L);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (0.5 + d);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (0.5f + d);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (0.5L + d);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (0.5 + ld);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (0.5f + ld);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (0.5L + ld);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (0.5 + f);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (0.5f + f);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (0.5L + f);
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: casting (double + 0.5)
x = (int)(d + 0.5);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(d + 0.5f);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(d + 0.5L);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(ld + 0.5);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(ld + 0.5f);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(ld + 0.5L);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(f + 0.5);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(f + 0.5f);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(f + 0.5L);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(0.5 + d);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(0.5f + d);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(0.5L + d);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(0.5 + ld);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(0.5f + ld);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(0.5L + ld);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(0.5 + f);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(0.5f + f);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = (int)(0.5L + f);
// CHECK-MESSAGES: [[@LINE-1]]:12: warning: casting (double + 0.5)
x = static_cast<int>(d + 0.5);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(d + 0.5f);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(d + 0.5L);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(ld + 0.5);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(ld + 0.5f);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(ld + 0.5L);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(f + 0.5);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(f + 0.5f);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(f + 0.5L);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(0.5 + d);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(0.5f + d);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(0.5L + d);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(0.5 + ld);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(0.5f + ld);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(0.5L + ld);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(0.5 + f);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(0.5f + f);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
x = static_cast<int>(0.5L + f);
// CHECK-MESSAGES: [[@LINE-1]]:24: warning: casting (double + 0.5)
// Don't warn if constant is not 0.5.
x = (int)(d + 0.4999);
x = (int)(d + 0.4999f);
x = (int)(d + 0.4999L);
x = (int)(0.4999 + d);
x = (int)(0.4999f + d);
x = (int)(0.4999L + d);
x = (int)(d + -0.5);
x = (int)(-0.5 + d);
x = (int)(d + -0.5f);
x = (int)(-0.5f + d);
x = (int)(d + -0.5L);
x = (int)(-0.5L + d);
x = (int)(d + 0.5001);
x = (int)(d + 0.5001f);
x = (int)(d + 0.5001L);
x = (int)(0.5001 + d);
x = (int)(0.5001f + d);
x = (int)(0.5001L + d);
// Don't warn if binary operator is not directly beneath cast.
x = (int)(1 + (0.5 + f));
}
|
