1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110
|
// RUN: %check_clang_tidy -std=c++11-or-later %s bugprone-non-zero-enum-to-bool-conversion %t
namespace with::issue {
enum class EStatusC : char {
SUCCESS = 1,
FAILURE = 2,
INVALID_PARAM = 3,
UNKNOWN = 4
};
bool testEnumConversion(EStatusC value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EStatusC' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return static_cast<bool>(value);
}
enum class EStatusS : short {
SUCCESS = 1,
FAILURE = 2,
INVALID_PARAM = 3,
UNKNOWN = 4
};
bool testEnumConversion(EStatusS value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EStatusS' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return static_cast<bool>(value);
}
enum class EStatusI : int {
SUCCESS = 1,
FAILURE = 2,
INVALID_PARAM = 3,
UNKNOWN = 4
};
bool testEnumConversion(EStatusI value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EStatusI' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return static_cast<bool>(value);
}
enum class EStatus {
SUCCESS = 1,
FAILURE = 2,
INVALID_PARAM = 3,
UNKNOWN = 4
};
bool testEnumConversion(EStatus value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EStatus' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return static_cast<bool>(value);
}
namespace enum_int {
enum EResult : int {
OK = 1,
NOT_OK
};
bool testEnumConversion(const EResult& value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EResult' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return value;
}
}
namespace enum_short {
enum EResult : short {
OK = 1,
NOT_OK
};
bool testEnumConversion(const EResult& value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EResult' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return value;
}
}
namespace enum_char {
enum EResult : char {
OK = 1,
NOT_OK
};
bool testEnumConversion(const EResult& value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EResult' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return value;
}
}
namespace enum_default {
enum EResult {
OK = 1,
NOT_OK
};
bool testEnumConversion(const EResult& value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EResult' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return value;
}
}
}
|