1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
|
// RUN: %check_clang_tidy %s cppcoreguidelines-missing-std-forward %t -- -- -fno-delayed-template-parsing
// NOLINTBEGIN
namespace std {
template <typename T> struct remove_reference { using type = T; };
template <typename T> struct remove_reference<T&> { using type = T; };
template <typename T> struct remove_reference<T&&> { using type = T; };
template <typename T> using remove_reference_t = typename remove_reference<T>::type;
template <typename T> constexpr T &&forward(remove_reference_t<T> &t) noexcept;
template <typename T> constexpr T &&forward(remove_reference_t<T> &&t) noexcept;
template <typename T> constexpr remove_reference_t<T> &&move(T &&x);
} // namespace std
// NOLINTEND
struct S {
S();
S(const S&);
S(S&&) noexcept;
S& operator=(const S&);
S& operator=(S&&) noexcept;
};
template <class... Ts>
void consumes_all(Ts&&...);
namespace positive_cases {
template <class T>
void does_not_forward(T&& t) {
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: forwarding reference parameter 't' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
T other = t;
}
template <class T>
void does_not_forward_invoked(T&& t) {
// CHECK-MESSAGES: :[[@LINE-1]]:35: warning: forwarding reference parameter 't' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
T other = t();
}
template <class T>
void forwards_pairwise(T&& t) {
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: forwarding reference parameter 't' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
auto first = std::forward<T>(t.first);
auto second = std::forward<T>(t.second);
}
template <class... Ts>
void does_not_forward_pack(Ts&&... ts) {
// CHECK-MESSAGES: :[[@LINE-1]]:36: warning: forwarding reference parameter 'ts' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
consumes_all(ts...);
}
template <class T>
class AClass {
template <class U>
AClass(U&& u) : data(u) {}
// CHECK-MESSAGES: :[[@LINE-1]]:14: warning: forwarding reference parameter 'u' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
template <class U>
AClass& operator=(U&& u) { }
// CHECK-MESSAGES: :[[@LINE-1]]:25: warning: forwarding reference parameter 'u' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
template <class U>
void mixed_params(T&& t, U&& u) {
// CHECK-MESSAGES: :[[@LINE-1]]:32: warning: forwarding reference parameter 'u' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
T other1 = std::move(t);
U other2 = std::move(u);
}
T data;
};
template <class T>
void does_not_forward_in_evaluated_code(T&& t) {
// CHECK-MESSAGES: :[[@LINE-1]]:45: warning: forwarding reference parameter 't' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
using result_t = decltype(std::forward<T>(t));
unsigned len = sizeof(std::forward<T>(t));
T other = t;
}
template <class T>
void lambda_value_capture(T&& t) {
// CHECK-MESSAGES: :[[@LINE-1]]:31: warning: forwarding reference parameter 't' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
[=]() { T other = std::forward<T>(t); };
}
template <class T>
void lambda_value_reference(T&& t) {
// CHECK-MESSAGES: :[[@LINE-1]]:33: warning: forwarding reference parameter 't' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]
[&]() { T other = std::forward<T>(t); };
}
} // namespace positive_cases
namespace negative_cases {
template <class T>
void just_a_decl(T&&t);
template <class T>
void does_forward(T&& t) {
T other = std::forward<T>(t);
}
template <class... Ts>
void does_forward_pack(Ts&&... ts) {
consumes_all(std::forward<Ts>(ts)...);
}
void pass_by_value(S s) {
S other = std::move(s);
}
void lvalue_ref(S& s) {
S other = std::move(s);
}
void rvalue_ref(S&& s) {
S other = std::move(s);
}
template <class T>
void templated_rvalue_ref(std::remove_reference_t<T>&& t) {
T other = std::move(t);
}
template <class T>
class AClass {
template <class U>
AClass(U&& u) : data(std::forward<U>(u)) {}
template <class U>
AClass& operator=(U&& u) {
data = std::forward<U>(u);
}
void rvalue_ref(T&& t) {
T other = std::move(t);
}
T data;
};
} // namespace negative_cases
|
