1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
|
// RUN: %check_clang_tidy %s openmp-use-default-none %t -- -- -fopenmp=libomp -fopenmp-version=51
// RUN: %check_clang_tidy -std=c11 %s openmp-use-default-none %t -- -- -x c -fopenmp=libomp -fopenmp-version=51
//----------------------------------------------------------------------------//
// Null cases.
//----------------------------------------------------------------------------//
// 'for' directive can not have 'default' clause, no diagnostics.
void n0(const int a) {
#pragma omp for
for (int b = 0; b < a; b++)
;
}
//----------------------------------------------------------------------------//
// Single-directive positive cases.
//----------------------------------------------------------------------------//
// 'parallel' directive.
// 'parallel' directive can have 'default' clause, but said clause is not
// specified, diagnosed.
void p0_0(void) {
#pragma omp parallel
;
// CHECK-NOTES: :[[@LINE-2]]:1: warning: OpenMP directive 'parallel' does not specify 'default' clause, consider specifying 'default(none)' clause
}
// 'parallel' directive can have 'default' clause, and said clause specified,
// with 'none' kind, all good.
void p0_1(void) {
#pragma omp parallel default(none)
;
}
// 'parallel' directive can have 'default' clause, and said clause specified,
// but with 'shared' kind, which is not 'none', diagnose.
void p0_2(void) {
#pragma omp parallel default(shared)
;
// CHECK-NOTES: :[[@LINE-2]]:1: warning: OpenMP directive 'parallel' specifies 'default(shared)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-3]]:22: note: existing 'default' clause specified here
}
// 'parallel' directive can have 'default' clause, and said clause specified,
// but with 'firstprivate' kind, which is not 'none', diagnose.
void p0_3(void) {
#pragma omp parallel default(firstprivate)
;
// CHECK-NOTES: :[[@LINE-2]]:1: warning: OpenMP directive 'parallel' specifies 'default(firstprivate)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-3]]:22: note: existing 'default' clause specified here
}
// 'task' directive.
// 'task' directive can have 'default' clause, but said clause is not
// specified, diagnosed.
void p1_0(void) {
#pragma omp task
;
// CHECK-NOTES: :[[@LINE-2]]:1: warning: OpenMP directive 'task' does not specify 'default' clause, consider specifying 'default(none)' clause
}
// 'task' directive can have 'default' clause, and said clause specified,
// with 'none' kind, all good.
void p1_1(void) {
#pragma omp task default(none)
;
}
// 'task' directive can have 'default' clause, and said clause specified,
// but with 'shared' kind, which is not 'none', diagnose.
void p1_2(void) {
#pragma omp task default(shared)
;
// CHECK-NOTES: :[[@LINE-2]]:1: warning: OpenMP directive 'task' specifies 'default(shared)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-3]]:18: note: existing 'default' clause specified here
}
// 'task' directive can have 'default' clause, and said clause specified,
// but with 'firstprivate' kind, which is not 'none', diagnose.
void p1_3(void) {
#pragma omp task default(firstprivate)
;
// CHECK-NOTES: :[[@LINE-2]]:1: warning: OpenMP directive 'task' specifies 'default(firstprivate)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-3]]:18: note: existing 'default' clause specified here
}
// 'teams' directive. (has to be inside of 'target' directive)
// 'teams' directive can have 'default' clause, but said clause is not
// specified, diagnosed.
void p2_0(void) {
#pragma omp target
#pragma omp teams
;
// CHECK-NOTES: :[[@LINE-2]]:1: warning: OpenMP directive 'teams' does not specify 'default' clause, consider specifying 'default(none)' clause
}
// 'teams' directive can have 'default' clause, and said clause specified,
// with 'none' kind, all good.
void p2_1(void) {
#pragma omp target
#pragma omp teams default(none)
;
}
// 'teams' directive can have 'default' clause, and said clause specified,
// but with 'shared' kind, which is not 'none', diagnose.
void p2_2(void) {
#pragma omp target
#pragma omp teams default(shared)
;
// CHECK-NOTES: :[[@LINE-2]]:1: warning: OpenMP directive 'teams' specifies 'default(shared)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-3]]:19: note: existing 'default' clause specified here
}
// 'teams' directive can have 'default' clause, and said clause specified,
// but with 'firstprivate' kind, which is not 'none', diagnose.
void p2_3(void) {
#pragma omp target
#pragma omp teams default(firstprivate)
;
// CHECK-NOTES: :[[@LINE-2]]:1: warning: OpenMP directive 'teams' specifies 'default(firstprivate)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-3]]:19: note: existing 'default' clause specified here
}
// 'taskloop' directive.
// 'taskloop' directive can have 'default' clause, but said clause is not
// specified, diagnosed.
void p3_0(const int a) {
#pragma omp taskloop
for (int b = 0; b < a; b++)
;
// CHECK-NOTES: :[[@LINE-3]]:1: warning: OpenMP directive 'taskloop' does not specify 'default' clause, consider specifying 'default(none)' clause
}
// 'taskloop' directive can have 'default' clause, and said clause specified,
// with 'none' kind, all good.
void p3_1(const int a) {
#pragma omp taskloop default(none) shared(a)
for (int b = 0; b < a; b++)
;
}
// 'taskloop' directive can have 'default' clause, and said clause specified,
// but with 'shared' kind, which is not 'none', diagnose.
void p3_2(const int a) {
#pragma omp taskloop default(shared)
for (int b = 0; b < a; b++)
;
// CHECK-NOTES: :[[@LINE-3]]:1: warning: OpenMP directive 'taskloop' specifies 'default(shared)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-4]]:22: note: existing 'default' clause specified here
}
// 'taskloop' directive can have 'default' clause, and said clause specified,
// but with 'firstprivate' kind, which is not 'none', diagnose.
void p3_3(const int a) {
#pragma omp taskloop default(firstprivate)
for (int b = 0; b < a; b++)
;
// CHECK-NOTES: :[[@LINE-3]]:1: warning: OpenMP directive 'taskloop' specifies 'default(firstprivate)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-4]]:22: note: existing 'default' clause specified here
}
//----------------------------------------------------------------------------//
// Combined directives.
// Let's not test every single possible permutation/combination of directives,
// but just *one* combined directive. The rest will be the same.
//----------------------------------------------------------------------------//
// 'parallel' directive can have 'default' clause, but said clause is not
// specified, diagnosed.
void p4_0(const int a) {
#pragma omp parallel for
for (int b = 0; b < a; b++)
;
// CHECK-NOTES: :[[@LINE-3]]:1: warning: OpenMP directive 'parallel for' does not specify 'default' clause, consider specifying 'default(none)' clause
}
// 'parallel' directive can have 'default' clause, and said clause specified,
// with 'none' kind, all good.
void p4_1(const int a) {
#pragma omp parallel for default(none) shared(a)
for (int b = 0; b < a; b++)
;
}
// 'parallel' directive can have 'default' clause, and said clause specified,
// but with 'shared' kind, which is not 'none', diagnose.
void p4_2(const int a) {
#pragma omp parallel for default(shared)
for (int b = 0; b < a; b++)
;
// CHECK-NOTES: :[[@LINE-3]]:1: warning: OpenMP directive 'parallel for' specifies 'default(shared)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-4]]:26: note: existing 'default' clause specified here
}
// 'parallel' directive can have 'default' clause, and said clause specified,
// but with 'firstprivate' kind, which is not 'none', diagnose.
void p4_3(const int a) {
#pragma omp parallel for default(firstprivate)
for (int b = 0; b < a; b++)
;
// CHECK-NOTES: :[[@LINE-3]]:1: warning: OpenMP directive 'parallel for' specifies 'default(firstprivate)' clause, consider using 'default(none)' clause instead
// CHECK-NOTES: :[[@LINE-4]]:26: note: existing 'default' clause specified here
}
|
