1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
|
// RUN: %check_clang_tidy %s performance-avoid-endl %t
namespace std {
template <typename CharT>
class basic_ostream {
public:
template <typename T>
basic_ostream& operator<<(T);
basic_ostream& operator<<(basic_ostream<CharT>& (*)(basic_ostream<CharT>&));
};
template <typename CharT>
class basic_iostream : public basic_ostream<CharT> {};
using ostream = basic_ostream<char>;
using wostream = basic_ostream<wchar_t>;
using iostream = basic_iostream<char>;
using wiostream = basic_iostream<wchar_t>;
ostream cout;
wostream wcout;
ostream cerr;
wostream wcerr;
ostream clog;
wostream wclog;
template<typename CharT>
basic_ostream<CharT>& endl(basic_ostream<CharT>&);
} // namespace std
void good() {
std::cout << "Hello" << '\n';
std::cout << "World\n";
std::wcout << "Hello" << '\n';
std::wcout << "World\n";
std::cerr << "Hello" << '\n';
std::cerr << "World\n";
std::wcerr << "Hello" << '\n';
std::wcerr << "World\n";
std::clog << "Hello" << '\n';
std::clog << "World\n";
std::wclog << "Hello" << '\n';
std::wclog << "World\n";
}
void bad() {
std::cout << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cout << "World" << '\n';
std::wcout << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcout << "World" << '\n';
std::cerr << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cerr << "World" << '\n';
std::wcerr << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcerr << "World" << '\n';
std::clog << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::clog << "World" << '\n';
std::wclog << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wclog << "World" << '\n';
}
void bad_single_argument() {
std::cout << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:16: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cout << '\n';
std::wcout << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:17: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcout << '\n';
std::cerr << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:16: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cerr << '\n';
std::wcerr << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:17: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcerr << '\n';
std::clog << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:16: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::clog << '\n';
std::wclog << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:17: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wclog << '\n';
}
void bad_multiple() {
std::cout << "Hello" << std::endl << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-MESSAGES: :[[@LINE-2]]:51: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cout << "Hello" << '\n' << "World" << '\n';
std::wcout << "Hello" << std::endl << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-MESSAGES: :[[@LINE-2]]:52: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcout << "Hello" << '\n' << "World" << '\n';
std::cerr << "Hello" << std::endl << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-MESSAGES: :[[@LINE-2]]:51: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cerr << "Hello" << '\n' << "World" << '\n';
std::wcerr << "Hello" << std::endl << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-MESSAGES: :[[@LINE-2]]:52: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcerr << "Hello" << '\n' << "World" << '\n';
std::clog << "Hello" << std::endl << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-MESSAGES: :[[@LINE-2]]:51: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::clog << "Hello" << '\n' << "World" << '\n';
std::wclog << "Hello" << std::endl << "World" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-MESSAGES: :[[@LINE-2]]:52: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wclog << "Hello" << '\n' << "World" << '\n';
}
void bad_function_call() {
std::endl(std::cout);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cout << '\n';
std::endl(std::cout << "Hi");
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cout << "Hi" << '\n';
std::endl(std::wcout);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcout << '\n';
std::endl(std::wcout << "Hi");
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcout << "Hi" << '\n';
std::endl(std::cerr);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cerr << '\n';
std::endl(std::cerr << "Hi");
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::cerr << "Hi" << '\n';
std::endl(std::wcerr);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcerr << '\n';
std::endl(std::wcerr << "Hi");
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wcerr << "Hi" << '\n';
std::endl(std::clog);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::clog << '\n';
std::endl(std::clog << "Hi");
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::clog << "Hi" << '\n';
std::endl(std::wclog);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wclog << '\n';
std::endl(std::wclog << "Hi");
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: std::wclog << "Hi" << '\n';
}
void bad_user_stream() {
std::iostream my_iostream;
std::wiostream my_wiostream;
std::ostream my_ostream;
std::wostream my_wostream;
my_iostream << "Hi" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:26: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_iostream << "Hi" << '\n';
my_wiostream << "Hi" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_wiostream << "Hi" << '\n';
my_ostream << "Hi" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:25: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_ostream << "Hi" << '\n';
my_wostream << "Hi" << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:26: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_wostream << "Hi" << '\n';
std::endl(my_iostream);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_iostream << '\n';
std::endl(my_wiostream);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_wiostream << '\n';
std::endl(my_ostream);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_ostream << '\n';
std::endl(my_wostream);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_wostream << '\n';
}
using namespace std;
void bad_using_namespace_std() {
cout << "Hello" << endl;
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: cout << "Hello" << '\n';
endl(cout);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: cout << '\n';
}
namespace my_prefix = std;
void bad_using_user_namespace() {
my_prefix::cout << "Hello" << my_prefix::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:33: warning: do not use 'my_prefix::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_prefix::cout << "Hello" << '\n';
my_prefix::endl(my_prefix::cout);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: do not use 'my_prefix::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: my_prefix::cout << '\n';
}
struct CustomLogger {
template <typename T>
std::ostream& operator<<(T);
std::ostream& operator<<(std::ostream& (*)(std::ostream&));
};
void bad_custom_stream() {
CustomLogger logger;
logger << std::endl;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
// CHECK-FIXES: logger << '\n';
}
|
