1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
|
// RUN: %check_clang_tidy %s readability-misleading-indentation %t -- -- -fno-delayed-template-parsing
void foo1();
void foo2();
void foo3();
#define BLOCK \
if (cond1) \
foo1(); \
foo2();
void f()
{
bool cond1 = true;
bool cond2 = true;
if (cond1)
if (cond2)
foo1();
else
foo2();
// CHECK-MESSAGES: :[[@LINE-2]]:3: warning: different indentation for 'if' and corresponding 'else' [readability-misleading-indentation]
if (cond1) {
if (cond2)
foo1();
}
else
foo2();
if (cond1)
if (cond2)
foo1();
else
foo2();
if (cond2)
foo1();
foo2();
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: misleading indentation: statement is indented too deeply [readability-misleading-indentation]
// CHECK-MESSAGES: :[[@LINE-4]]:3: note: did you mean this line to be inside this 'if'
foo2(); // No redundant warning.
if (cond1)
{
foo1();
}
foo2();
if (cond1)
foo1();
foo2();
if (cond2)
if (cond1) foo1(); else foo2();
if (cond1) {
} else {
}
if (cond1) {
}
else {
}
if (cond1)
{
}
else
{
}
if (cond1)
{
}
else
{
}
if(cond1) {
}
else if (cond2) {
}
else {
}
if(cond1) {
}
else if (cond2) {
}
else {
}
// CHECK-MESSAGES: :[[@LINE-2]]:8: warning: different indentation for 'if' and corresponding 'else' [readability-misleading-indentation]
if (cond1) {
if (cond1) {
}
else if (cond2) {
}
else {
}
if (cond1) {
} else if (cond2) {
} else if (!cond2) {
} else {
}
}
else if (cond2) {
}
BLOCK
}
void g(bool x) {
if (x)
#pragma unroll
for (int k = 0; k < 1; ++k) {}
#pragma unroll
for (int k = 0; k < 1; ++k) {}
}
template<bool b>
void mustPass() {
if constexpr (b) {
foo1();
} else {
foo2();
}
}
void mustPassNonTemplate() {
constexpr unsigned Value = 1;
if constexpr (Value == 0) {
foo1();
} else if constexpr (Value == 1) {
foo2();
} else {
foo3();
}
}
template<bool b>
void mustFail() {
if constexpr (b) {
foo1();
}
else {
foo2();
// CHECK-MESSAGES: :[[@LINE-2]]:5: warning: different indentation for 'if' and corresponding 'else' [readability-misleading-indentation]
}
}
void mustFailNonTemplate() {
constexpr unsigned Value = 1;
if constexpr (Value == 0) {
foo1();
}
else {
foo2();
// CHECK-MESSAGES: :[[@LINE-2]]:5: warning: different indentation for 'if' and corresponding 'else' [readability-misleading-indentation]
}
if constexpr (Value == 0)
foo1();
else
foo2();
// CHECK-MESSAGES: :[[@LINE-2]]:5: warning: different indentation for 'if' and corresponding 'else' [readability-misleading-indentation]
}
template<bool b>
void mustFailNoInsta() {
if constexpr (b) {
foo1();
}
else {
foo2();
// CHECK-MESSAGES: :[[@LINE-2]]:5: warning: different indentation for 'if' and corresponding 'else' [readability-misleading-indentation]
}
}
template<bool b>
void mustPassNoInsta() {
if constexpr (b) {
foo1();
}
else {
foo2();
}
}
void call() {
mustPass<true>();
mustPass<false>();
mustFail<true>();
mustFail<false>();
}
|
