1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
|
// RUN: %check_clang_tidy %s readability-operators-representation %t -- -config="{CheckOptions: [\
// RUN: {key: readability-operators-representation.BinaryOperators, value: 'and;and_eq;bitand;bitor;compl;not;not_eq;or;or_eq;xor;xor_eq'}, \
// RUN: {key: readability-operators-representation.OverloadedOperators, value: 'and;and_eq;bitand;bitor;compl;not;not_eq;or;or_eq;xor;xor_eq'}]}" --
void testAllTokensToAlternative(int a, int b) {
int value = 0;
value = a||b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: '||' is a traditional token spelling, consider using an alternative token 'or' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a or b;{{$}}
value = a&&b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: '&&' is a traditional token spelling, consider using an alternative token 'and' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a and b;{{$}}
value = a | b;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: '|' is a traditional token spelling, consider using an alternative token 'bitor' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a bitor b;{{$}}
value = a & b;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: '&' is a traditional token spelling, consider using an alternative token 'bitand' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a bitand b;{{$}}
value = !a;
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: '!' is a traditional token spelling, consider using an alternative token 'not' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = not a;{{$}}
value = a^b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: '^' is a traditional token spelling, consider using an alternative token 'xor' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a xor b;{{$}}
value = ~b;
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: '~' is a traditional token spelling, consider using an alternative token 'compl' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = compl b;{{$}}
value &= b;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: '&=' is a traditional token spelling, consider using an alternative token 'and_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value and_eq b;{{$}}
value |= b;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: '|=' is a traditional token spelling, consider using an alternative token 'or_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value or_eq b;{{$}}
value = a != b;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: '!=' is a traditional token spelling, consider using an alternative token 'not_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a not_eq b;{{$}}
value ^= a;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: '^=' is a traditional token spelling, consider using an alternative token 'xor_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value xor_eq a;{{$}}
}
struct Class {
bool operator!() const;
Class operator~() const;
bool operator&&(const Class&) const;
Class operator&(const Class&) const;
bool operator||(const Class&) const;
Class operator|(const Class&) const;
Class operator^(const Class&) const;
Class& operator&=(const Class&) const;
Class& operator|=(const Class&) const;
Class& operator^=(const Class&) const;
bool operator!=(const Class&) const;
};
void testAllTokensToAlternative(Class a, Class b) {
int value = 0;
Class clval;
value = a||b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: '||' is a traditional token spelling, consider using an alternative token 'or' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a or b;{{$}}
value = a&&b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: '&&' is a traditional token spelling, consider using an alternative token 'and' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a and b;{{$}}
clval = a | b;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: '|' is a traditional token spelling, consider using an alternative token 'bitor' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval = a bitor b;{{$}}
clval = a & b;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: '&' is a traditional token spelling, consider using an alternative token 'bitand' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval = a bitand b;{{$}}
value = !a;
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: '!' is a traditional token spelling, consider using an alternative token 'not' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = not a;{{$}}
clval = a^b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: '^' is a traditional token spelling, consider using an alternative token 'xor' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval = a xor b;{{$}}
clval = ~b;
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: '~' is a traditional token spelling, consider using an alternative token 'compl' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval = compl b;{{$}}
clval &= b;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: '&=' is a traditional token spelling, consider using an alternative token 'and_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval and_eq b;{{$}}
clval |= b;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: '|=' is a traditional token spelling, consider using an alternative token 'or_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval or_eq b;{{$}}
value = a != b;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: '!=' is a traditional token spelling, consider using an alternative token 'not_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a not_eq b;{{$}}
clval ^= a;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: '^=' is a traditional token spelling, consider using an alternative token 'xor_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval xor_eq a;{{$}}
}
struct ClassO {};
ClassO& operator&=(ClassO&, const ClassO&);
ClassO& operator|=(ClassO&, const ClassO&);
ClassO& operator^=(ClassO&, const ClassO&);
bool operator!=(const ClassO&, const ClassO&);
bool operator&&(const ClassO&, const ClassO&);
bool operator||(const ClassO&, const ClassO&);
bool operator!(const ClassO&);
ClassO operator&(const ClassO&, const ClassO&);
ClassO operator|(const ClassO&, const ClassO&);
ClassO operator^(const ClassO&, const ClassO&);
ClassO operator~(const ClassO&);
void testAllTokensToAlternative(ClassO a, ClassO b) {
int value = 0;
ClassO clval;
value = a||b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: '||' is a traditional token spelling, consider using an alternative token 'or' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a or b;{{$}}
value = a&&b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: '&&' is a traditional token spelling, consider using an alternative token 'and' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a and b;{{$}}
clval = a | b;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: '|' is a traditional token spelling, consider using an alternative token 'bitor' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval = a bitor b;{{$}}
clval = a & b;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: '&' is a traditional token spelling, consider using an alternative token 'bitand' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval = a bitand b;{{$}}
value = !a;
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: '!' is a traditional token spelling, consider using an alternative token 'not' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = not a;{{$}}
clval = a^b;
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: '^' is a traditional token spelling, consider using an alternative token 'xor' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval = a xor b;{{$}}
clval = ~b;
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: '~' is a traditional token spelling, consider using an alternative token 'compl' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval = compl b;{{$}}
clval &= b;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: '&=' is a traditional token spelling, consider using an alternative token 'and_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval and_eq b;{{$}}
clval |= b;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: '|=' is a traditional token spelling, consider using an alternative token 'or_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval or_eq b;{{$}}
value = a != b;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: '!=' is a traditional token spelling, consider using an alternative token 'not_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}value = a not_eq b;{{$}}
clval ^= a;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: '^=' is a traditional token spelling, consider using an alternative token 'xor_eq' for consistency [readability-operators-representation]
// CHECK-FIXES: {{^ }}clval xor_eq a;{{$}}
}
|
