1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
|
// RUN: %check_clang_tidy -std=c++20 %s modernize-use-nullptr %t -- -- -DGCC
// RUN: %check_clang_tidy -std=c++20 %s modernize-use-nullptr %t -- -- -DCLANG
namespace std {
class strong_ordering;
// Mock how STD defined unspecified parameters for the operators below.
#ifdef CLANG
struct _CmpUnspecifiedParam {
consteval
_CmpUnspecifiedParam(int _CmpUnspecifiedParam::*) noexcept {}
};
#define UNSPECIFIED_TYPE _CmpUnspecifiedParam
#endif
#ifdef GCC
namespace __cmp_cat {
struct __unspec {
constexpr __unspec(__unspec*) noexcept { }
};
}
#define UNSPECIFIED_TYPE __cmp_cat::__unspec
#endif
struct strong_ordering {
signed char value;
friend constexpr bool operator==(strong_ordering v,
UNSPECIFIED_TYPE) noexcept {
return v.value == 0;
}
friend constexpr bool operator<(strong_ordering v,
UNSPECIFIED_TYPE) noexcept {
return v.value < 0;
}
friend constexpr bool operator>(strong_ordering v,
UNSPECIFIED_TYPE) noexcept {
return v.value > 0;
}
friend constexpr bool operator>=(strong_ordering v,
UNSPECIFIED_TYPE) noexcept {
return v.value >= 0;
}
static const strong_ordering equal, greater, less;
};
constexpr strong_ordering strong_ordering::equal = {0};
constexpr strong_ordering strong_ordering::greater = {1};
constexpr strong_ordering strong_ordering::less = {-1};
} // namespace std
class A {
int a;
public:
auto operator<=>(const A &other) const = default;
// CHECK-FIXES: auto operator<=>(const A &other) const = default;
};
void test_cxx_rewritten_binary_ops() {
A a1, a2;
bool result;
// should not change next line to (a1 nullptr a2)
result = (a1 < a2);
// CHECK-FIXES: result = (a1 < a2);
// should not change next line to (a1 nullptr a2)
result = (a1 >= a2);
// CHECK-FIXES: result = (a1 >= a2);
int *ptr = 0;
// CHECK-FIXES: int *ptr = nullptr;
result = (a1 > (ptr == 0 ? a1 : a2));
// CHECK-FIXES: result = (a1 > (ptr == nullptr ? a1 : a2));
result = (a1 > ((a1 > (ptr == 0 ? a1 : a2)) ? a1 : a2));
// CHECK-FIXES: result = (a1 > ((a1 > (ptr == nullptr ? a1 : a2)) ? a1 : a2));
}
void testValidZero() {
A a1, a2;
auto result = a1 <=> a2;
if (result < 0) {}
// CHECK-FIXES: if (result < 0) {}
}
template<class T1, class T2>
struct P {
T1 x1;
T2 x2;
friend auto operator<=>(const P&, const P&) = default;
// CHECK-FIXES: friend auto operator<=>(const P&, const P&) = default;
};
bool foo(P<int,int> x, P<int, int> y) { return x < y; }
// CHECK-FIXES: bool foo(P<int,int> x, P<int, int> y) { return x < y; }
|
