1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445
|
// RUN: %clang_analyze_cc1 -verify %s \
// RUN: -triple x86_64-linux-gnu \
// RUN: -analyzer-checker=core,unix.Stream,alpha.security.taint \
// RUN: -analyzer-checker=debug.ExprInspection
#include "Inputs/system-header-simulator-for-simple-stream.h"
#define EOF (-1)
void clang_analyzer_dump(int);
void clang_analyzer_dump_char(char);
void clang_analyzer_isTainted(int);
void clang_analyzer_warnIfReached(void);
// A stream is only tracked by StreamChecker if it results from a call to "fopen".
// Otherwise, there is no specific modelling of "fread".
void untracked_stream(FILE *fp) {
char c;
if (1 == fread(&c, 1, 1, fp)) {
char p = c; // Unknown value but not garbage and not modeled by checker.
} else {
char p = c; // Possibly indeterminate value but not modeled by checker.
}
}
void fgetc_props_taint(void) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
int c = fgetc(fp); // c is tainted.
if (c != EOF) {
clang_analyzer_isTainted(c); // expected-warning{{YES}}
}
fclose(fp);
}
}
void fread_props_taint(void) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
char buffer[10];
int c = fread(buffer, 1, 10, fp); // c is tainted.
if (c != 10) {
// If the read failed, then the number of bytes successfully read should be tainted.
clang_analyzer_isTainted(c); // expected-warning{{YES}}
}
fclose(fp);
}
}
void read_one_byte1(void) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
char c;
if (1 == fread(&c, 1, 1, fp)) {
char p = c; // Unknown value but not garbage.
clang_analyzer_isTainted(p); // expected-warning{{YES}}
} else {
char p = c; // Possibly indeterminate value but not modeled by checker.
clang_analyzer_isTainted(p); // expected-warning{{YES}}
}
fclose(fp);
}
}
void read_one_byte2(char *buffer) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
if (1 == fread(buffer, 1, 1, fp)) {
char p = buffer[0]; // Unknown value but not garbage.
clang_analyzer_isTainted(p); // expected-warning{{YES}}
} else {
char p = buffer[0]; // Possibly indeterminate value but not modeled by checker.
clang_analyzer_isTainted(p); // expected-warning{{YES}}
}
fclose(fp);
}
}
void read_one_byte3(char *buffer) {
buffer[1] = 10;
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
// buffer[1] is not mutated by fread and remains not tainted.
fread(buffer, 1, 1, fp);
char p = buffer[1];
clang_analyzer_isTainted(p); // expected-warning{{NO}}
clang_analyzer_dump(buffer[1]); // expected-warning{{10 S32b}}
fclose(fp);
}
}
void read_many_bytes(char *buffer) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
if (42 == fread(buffer, 1, 42, fp)) {
char p = buffer[0]; // Unknown value but not garbage.
clang_analyzer_isTainted(p); // expected-warning{{YES}}
} else {
char p = buffer[0]; // Possibly indeterminate value but not modeled.
clang_analyzer_isTainted(p); // expected-warning{{YES}}
}
fclose(fp);
}
}
void random_access_read1(int index) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
long c[4];
int success = 2 == fread(c + 1, sizeof(long), 2, fp);
switch (index) {
case 0:
// c[0] is not mutated by fread.
if (success) {
char p = c[0]; // expected-warning {{Assigned value is garbage or undefined}} We kept the first byte intact.
} else {
char p = c[0]; // expected-warning {{Assigned value is garbage or undefined}} We kept the first byte intact.
}
break;
case 1:
if (success) {
// Unknown value but not garbage.
clang_analyzer_isTainted(c[1]); // expected-warning {{YES}}
clang_analyzer_dump(c[1]); // expected-warning {{conj_}}
} else {
// Possibly indeterminate value but not modeled.
clang_analyzer_isTainted(c[1]); // expected-warning {{YES}}
clang_analyzer_dump(c[1]); // expected-warning {{conj_}}
}
break;
case 2:
if (success) {
long p = c[2]; // Unknown value but not garbage.
// FIXME: Taint analysis only marks the first byte of a memory region. See getPointeeOf in GenericTaintChecker.cpp.
clang_analyzer_isTainted(c[2]); // expected-warning {{NO}}
clang_analyzer_dump(c[2]); // expected-warning {{conj_}}
} else {
// Possibly indeterminate value but not modeled.
clang_analyzer_isTainted(c[2]); // expected-warning {{NO}} // FIXME: See above.
clang_analyzer_dump(c[2]); // expected-warning {{conj_}}
}
break;
case 3:
// c[3] is not mutated by fread.
if (success) {
long p = c[3]; // expected-warning {{Assigned value is garbage or undefined}}
} else {
long p = c[3]; // expected-warning {{Assigned value is garbage or undefined}}
}
break;
}
fclose(fp);
}
}
void random_access_read2(int b) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
int buffer[10];
int *ptr = buffer + 2;
if (5 == fread(ptr - 1, sizeof(int), 5, fp)) {
if (b) {
int p = buffer[1]; // Unknown value but not garbage.
clang_analyzer_isTainted(p); // expected-warning {{YES}}
clang_analyzer_dump(p); // expected-warning {{conj_}}
} else {
int p = buffer[0]; // expected-warning {{Assigned value is garbage or undefined}}
}
} else {
int p = buffer[0]; // expected-warning {{Assigned value is garbage or undefined}}
}
fclose(fp);
}
}
void random_access_read_symbolic_count(size_t count) {
// Cover a case that used to crash (symbolic count).
if (count > 2)
return;
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
long c[4];
fread(c + 1, sizeof(long), count, fp);
// c[0] and c[3] are never mutated by fread, but because "count" is a symbolic value, the checker doesn't know that.
long p = c[0];
clang_analyzer_isTainted(p); // expected-warning {{NO}}
clang_analyzer_dump(p); // expected-warning {{derived_}}
p = c[3];
clang_analyzer_isTainted(p); // expected-warning {{NO}}
clang_analyzer_dump(p); // expected-warning {{derived_}}
p = c[1];
clang_analyzer_isTainted(p); // expected-warning {{YES}}
clang_analyzer_dump(p); // expected-warning {{derived_}}
fclose(fp);
}
}
void dynamic_random_access_read(int startIndex) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
long buffer[10];
// Cannot reason about index.
size_t res = fread(buffer + startIndex, sizeof(long), 5, fp);
long *p = &buffer[startIndex];
long v = 0;
// If all 5 elements were successfully read, then all 5 elements should be tainted and considered initialized.
if (5 == res) {
// FIXME: These should be tainted.
clang_analyzer_isTainted((v = p[0])); // expected-warning {{NO}}
clang_analyzer_isTainted((v = p[1])); // expected-warning {{NO}}
clang_analyzer_isTainted((v = p[2])); // expected-warning {{NO}}
clang_analyzer_isTainted((v = p[3])); // expected-warning {{NO}}
clang_analyzer_isTainted((v = p[4])); // expected-warning {{NO}}
clang_analyzer_dump((v = p[0])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[1])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[2])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[3])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[4])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[5])); // expected-warning {{conj_}} FIXME: This should raise an uninit read.
} else if (res == 4) {
// If only the first 4 elements were successfully read,
// then only the first 4 elements should be tainted and considered initialized.
// FIXME: These should be tainted.
clang_analyzer_isTainted((v = p[0])); // expected-warning {{NO}}
clang_analyzer_isTainted((v = p[1])); // expected-warning {{NO}}
clang_analyzer_isTainted((v = p[2])); // expected-warning {{NO}}
clang_analyzer_isTainted((v = p[3])); // expected-warning {{NO}}
clang_analyzer_dump((v = p[0])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[1])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[2])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[3])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[4])); // expected-warning {{conj_}} FIXME: This should raise an uninit read.
} else {
// Neither 5, or 4 elements were successfully read, so we must have read from 0 up to 3 elements.
// FIXME: These should be tainted.
clang_analyzer_isTainted((v = p[0])); // expected-warning {{NO}}
clang_analyzer_isTainted((v = p[1])); // expected-warning {{NO}}
clang_analyzer_isTainted((v = p[2])); // expected-warning {{NO}}
clang_analyzer_dump((v = p[0])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[1])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[2])); // expected-warning {{conj_}} ok
clang_analyzer_dump((v = p[3])); // expected-warning {{conj_}} FIXME: This should raise an uninit read.
}
fclose(fp);
}
}
struct S {
int a;
long b;
};
void compound_read1(void) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
struct S s; // s.a is not touched by fread.
if (1 == fread(&s.b, sizeof(s.b), 1, fp)) {
long p = s.b;
clang_analyzer_isTainted(p); // expected-warning {{YES}}
clang_analyzer_dump(p); // expected-warning {{conj_}}
} else {
long p = s.b;
clang_analyzer_isTainted(p); // expected-warning {{YES}}
clang_analyzer_dump(p); // expected-warning {{conj_}}
}
fclose(fp);
}
}
void compound_read2(void) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
struct S s; // s.a is not touched by fread.
if (1 == fread(&s.b, sizeof(s.b), 1, fp)) {
long p = s.a; // expected-warning {{Assigned value is garbage or undefined}}
} else {
long p = s.a; // expected-warning {{Assigned value is garbage or undefined}}
}
fclose(fp);
}
}
void var_read(void) {
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
int a, b; // 'a' is not touched by fread.
if (1 == fread(&b, sizeof(b), 1, fp)) {
long p = a; // expected-warning{{Assigned value is garbage or undefined}}
} else {
long p = a; // expected-warning{{Assigned value is garbage or undefined}}
}
fclose(fp);
}
}
// When reading a lot of data, invalidating all elements is too time-consuming.
// Instead, the knowledge of the whole array is lost.
#define MaxInvalidatedElementRegion 64 // See StreamChecker::evalFreadFwrite in StreamChecker.cpp.
#define PastMaxComplexity MaxInvalidatedElementRegion + 1
void test_large_read(void) {
int buffer[PastMaxComplexity + 1];
buffer[PastMaxComplexity] = 42;
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
if (buffer[PastMaxComplexity] != 42) {
clang_analyzer_warnIfReached(); // Unreachable.
}
if (1 == fread(buffer, sizeof(int), PastMaxComplexity, fp)) {
if (buffer[PastMaxComplexity] != 42) {
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
}
}
fclose(fp);
}
}
void test_small_read(void) {
int buffer[10];
buffer[5] = 42;
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
clang_analyzer_dump(buffer[5]); // expected-warning{{42 S32b}}
if (1 == fread(buffer, sizeof(int), 5, fp)) {
clang_analyzer_dump(buffer[5]); // expected-warning{{42 S32b}}
}
fclose(fp);
}
}
void test_partial_elements_read(void) {
clang_analyzer_dump(sizeof(int)); // expected-warning {{4 S32b}}
int buffer[100];
buffer[0] = 1;
buffer[1] = 2;
buffer[2] = 3;
buffer[3] = 4;
buffer[4] = 5;
buffer[5] = 6;
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
// 3*5: 15 bytes read; which is not exactly 4 integers, but we still invalidate the first 4 ints.
if (5 == fread(buffer + 1, 3, 5, fp)) {
clang_analyzer_dump(buffer[0]); // expected-warning{{1 S32b}}
clang_analyzer_dump(buffer[1]); // expected-warning{{conj_}}
clang_analyzer_dump(buffer[2]); // expected-warning{{conj_}}
clang_analyzer_dump(buffer[3]); // expected-warning{{conj_}}
clang_analyzer_dump(buffer[4]); // expected-warning{{conj_}}
clang_analyzer_dump(buffer[5]); // expected-warning{{6 S32b}}
char *c = (char*)buffer;
clang_analyzer_dump(c[4+12]); // expected-warning{{conj_}} 16th byte of buffer, which is the beginning of the 4th 'int' in the buffer.
// FIXME: The store should have returned a partial binding for the 17th byte of the buffer, which is the 2nd byte of the previous int.
// This byte should have been initialized by the 'fread' earlier. However, the Store lies to us and says it's uninitialized.
clang_analyzer_dump(c[4+13]); // expected-warning{{1st function call argument is an uninitialized value}} should be initialized.
clang_analyzer_dump(c[4+16]); // This should be the first byte that 'fread' leaves uninitialized. This should raise the uninit read diag.
} else {
clang_analyzer_dump(buffer[0]); // expected-warning{{1 S32b}} ok
clang_analyzer_dump(buffer[1]); // expected-warning{{conj_}} ok
clang_analyzer_dump(buffer[2]); // expected-warning{{conj_}} ok
clang_analyzer_dump(buffer[3]); // expected-warning{{conj_}} ok
clang_analyzer_dump(buffer[4]); // expected-warning{{conj_}} ok, but an uninit warning would be also fine.
clang_analyzer_dump(buffer[5]); // expected-warning{{6 S32b}} ok
clang_analyzer_dump(buffer[6]); // expected-warning{{1st function call argument is an uninitialized value}} ok
}
fclose(fp);
}
}
void test_whole_elements_read(void) {
clang_analyzer_dump(sizeof(int)); // expected-warning {{4 S32b}}
int buffer[100];
buffer[0] = 1;
buffer[15] = 2;
buffer[16] = 3;
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
// 3*20: 60 bytes read; which is basically 15 integers.
if (20 == fread(buffer + 1, 3, 20, fp)) {
clang_analyzer_dump(buffer[0]); // expected-warning{{1 S32b}}
clang_analyzer_dump(buffer[15]); // expected-warning{{conj_}}
clang_analyzer_dump(buffer[16]); // expected-warning{{3 S32b}}
clang_analyzer_dump(buffer[17]); // expected-warning{{1st function call argument is an uninitialized value}}
} else {
clang_analyzer_dump(buffer[0]); // expected-warning{{1 S32b}}
clang_analyzer_dump(buffer[15]); // expected-warning{{conj_}}
clang_analyzer_dump(buffer[16]); // expected-warning{{3 S32b}}
clang_analyzer_dump(buffer[17]); // expected-warning{{1st function call argument is an uninitialized value}}
}
fclose(fp);
}
}
void test_unaligned_start_read(void) {
clang_analyzer_dump(sizeof(int)); // expected-warning {{4 S32b}}
int buffer[100];
buffer[0] = 3;
buffer[1] = 4;
buffer[2] = 5;
char *asChar = (char*)buffer;
FILE *fp = fopen("/home/test", "rb+");
if (fp) {
// We have an 'int' binding at offset 0 of value 3.
// We read 4 bytes at byte offset: 1,2,3,4.
if (4 == fread(asChar + 1, 1, 4, fp)) {
clang_analyzer_dump(buffer[0]); // expected-warning{{3 S32b}} FIXME: The int binding should have been partially overwritten by the read call. This definitely should not be 3.
clang_analyzer_dump(buffer[1]); // expected-warning{{conj_}}
clang_analyzer_dump(buffer[2]); // expected-warning{{5 S32b}}
clang_analyzer_dump_char(asChar[0]); // expected-warning{{3 S8b}} This is technically true assuming x86 (little-endian) architecture.
clang_analyzer_dump_char(asChar[1]); // expected-warning{{conj_}} 1
clang_analyzer_dump_char(asChar[2]); // expected-warning{{conj_}} 2
clang_analyzer_dump_char(asChar[3]); // expected-warning{{conj_}} 3
clang_analyzer_dump_char(asChar[4]); // expected-warning{{conj_}} 4
clang_analyzer_dump_char(asChar[5]); // expected-warning{{1st function call argument is an uninitialized value}}
} else {
clang_analyzer_dump(buffer[0]); // expected-warning{{3 S32b}} FIXME: The int binding should have been partially overwritten by the read call. This definitely should not be 3.
clang_analyzer_dump(buffer[1]); // expected-warning{{conj_}}
clang_analyzer_dump(buffer[2]); // expected-warning{{5 S32b}}
clang_analyzer_dump_char(asChar[0]); // expected-warning{{3 S8b}} This is technically true assuming x86 (little-endian) architecture.
clang_analyzer_dump_char(asChar[1]); // expected-warning{{conj_}} 1
clang_analyzer_dump_char(asChar[2]); // expected-warning{{conj_}} 2
clang_analyzer_dump_char(asChar[3]); // expected-warning{{conj_}} 3
clang_analyzer_dump_char(asChar[4]); // expected-warning{{conj_}} 4
clang_analyzer_dump_char(asChar[5]); // expected-warning{{1st function call argument is an uninitialized value}}
}
fclose(fp);
}
}
|