1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
|
// Test the -cc1 flag. There's no -fno-... option in -cc1 invocations,
// just the positive option.
// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage -verify=OFF %s
// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage -verify=ON %s \
// RUN: -fsafe-buffer-usage-suggestions
// Test driver flags. Now there's both -f... and -fno-... to worry about.
// RUN: %clang -fsyntax-only -std=c++20 -Wunsafe-buffer-usage \
// RUN: -Xclang -verify=OFF %s
// RUN: %clang -fsyntax-only -std=c++20 -Wunsafe-buffer-usage \
// RUN: -fsafe-buffer-usage-suggestions \
// RUN: -Xclang -verify=ON %s
// RUN: %clang -fsyntax-only -std=c++20 -Wunsafe-buffer-usage \
// RUN: -fno-safe-buffer-usage-suggestions \
// RUN: -Xclang -verify=OFF %s
// In case of driver flags, last flag takes precedence.
// RUN: %clang -fsyntax-only -std=c++20 -Wunsafe-buffer-usage \
// RUN: -fsafe-buffer-usage-suggestions \
// RUN: -fno-safe-buffer-usage-suggestions \
// RUN: -Xclang -verify=OFF %s
// RUN: %clang -fsyntax-only -std=c++20 -Wunsafe-buffer-usage \
// RUN: -fno-safe-buffer-usage-suggestions \
// RUN: -fsafe-buffer-usage-suggestions \
// RUN: -Xclang -verify=ON %s
// Passing through -Xclang.
// RUN: %clang -fsyntax-only -std=c++20 -Wunsafe-buffer-usage \
// RUN: -Xclang -fsafe-buffer-usage-suggestions \
// RUN: -Xclang -verify=ON %s
// -Xclang flags take precedence over driver flags.
// RUN: %clang -fsyntax-only -std=c++20 -Wunsafe-buffer-usage \
// RUN: -Xclang -fsafe-buffer-usage-suggestions \
// RUN: -fno-safe-buffer-usage-suggestions \
// RUN: -Xclang -verify=ON %s
// RUN: %clang -fsyntax-only -std=c++20 -Wunsafe-buffer-usage \
// RUN: -fno-safe-buffer-usage-suggestions \
// RUN: -Xclang -fsafe-buffer-usage-suggestions \
// RUN: -Xclang -verify=ON %s
[[clang::unsafe_buffer_usage]] void bar(int *);
void foo(int *x) { // \
// ON-warning{{'x' is an unsafe pointer used for buffer access}}
// FIXME: Better "OFF" warning?
x[5] = 10; // \
// ON-note {{used in buffer access here}} \
// OFF-warning{{unsafe buffer access}} \
// OFF-note {{pass -fsafe-buffer-usage-suggestions to receive code hardening suggestions}}
x += 5; // \
// ON-note {{used in pointer arithmetic here}} \
// OFF-warning{{unsafe pointer arithmetic}} \
// OFF-note {{pass -fsafe-buffer-usage-suggestions to receive code hardening suggestions}}
bar(x); // \
// ON-warning{{function introduces unsafe buffer manipulation}} \
// OFF-warning{{function introduces unsafe buffer manipulation}} \
// OFF-note {{pass -fsafe-buffer-usage-suggestions to receive code hardening suggestions}}
}
|
