1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
|
//===--- RedundantCastingCheck.cpp - clang-tidy ---------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "RedundantCastingCheck.h"
#include "../utils/FixItHintUtils.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/Lex/Lexer.h"
using namespace clang::ast_matchers;
namespace clang::tidy::readability {
static bool areTypesEqual(QualType S, QualType D) {
if (S == D)
return true;
const auto *TS = S->getAs<TypedefType>();
const auto *TD = D->getAs<TypedefType>();
if (TS != TD)
return false;
QualType PtrS = S->getPointeeType();
QualType PtrD = D->getPointeeType();
if (!PtrS.isNull() && !PtrD.isNull())
return areTypesEqual(PtrS, PtrD);
const DeducedType *DT = S->getContainedDeducedType();
if (DT && DT->isDeduced())
return D == DT->getDeducedType();
return false;
}
static bool areTypesEqual(QualType TypeS, QualType TypeD,
bool IgnoreTypeAliases) {
const QualType CTypeS = TypeS.getCanonicalType();
const QualType CTypeD = TypeD.getCanonicalType();
if (CTypeS != CTypeD)
return false;
return IgnoreTypeAliases || areTypesEqual(TypeS.getLocalUnqualifiedType(),
TypeD.getLocalUnqualifiedType());
}
static bool areBinaryOperatorOperandsTypesEqualToOperatorResultType(
const Expr *E, bool IgnoreTypeAliases) {
if (!E)
return true;
const Expr *WithoutImplicitAndParen = E->IgnoreParenImpCasts();
if (!WithoutImplicitAndParen)
return true;
if (const auto *B = dyn_cast<BinaryOperator>(WithoutImplicitAndParen)) {
const QualType Type = WithoutImplicitAndParen->getType();
if (Type.isNull())
return true;
const QualType NonReferenceType = Type.getNonReferenceType();
const QualType LHSType = B->getLHS()->IgnoreImplicit()->getType();
if (LHSType.isNull() || !areTypesEqual(LHSType.getNonReferenceType(),
NonReferenceType, IgnoreTypeAliases))
return false;
const QualType RHSType = B->getRHS()->IgnoreImplicit()->getType();
if (RHSType.isNull() || !areTypesEqual(RHSType.getNonReferenceType(),
NonReferenceType, IgnoreTypeAliases))
return false;
}
return true;
}
static const Decl *getSourceExprDecl(const Expr *SourceExpr) {
const Expr *CleanSourceExpr = SourceExpr->IgnoreParenImpCasts();
if (const auto *E = dyn_cast<DeclRefExpr>(CleanSourceExpr)) {
return E->getDecl();
}
if (const auto *E = dyn_cast<CallExpr>(CleanSourceExpr)) {
return E->getCalleeDecl();
}
if (const auto *E = dyn_cast<MemberExpr>(CleanSourceExpr)) {
return E->getMemberDecl();
}
return nullptr;
}
RedundantCastingCheck::RedundantCastingCheck(StringRef Name,
ClangTidyContext *Context)
: ClangTidyCheck(Name, Context),
IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)),
IgnoreTypeAliases(Options.get("IgnoreTypeAliases", false)) {}
void RedundantCastingCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "IgnoreMacros", IgnoreMacros);
Options.store(Opts, "IgnoreTypeAliases", IgnoreTypeAliases);
}
void RedundantCastingCheck::registerMatchers(MatchFinder *Finder) {
auto SimpleType = qualType(hasCanonicalType(
qualType(anyOf(builtinType(), references(builtinType()),
references(pointsTo(qualType())), pointsTo(qualType())))));
auto BitfieldMemberExpr = memberExpr(member(fieldDecl(isBitField())));
const ast_matchers::internal::VariadicDynCastAllOfMatcher<
Stmt, CXXParenListInitExpr>
cxxParenListInitExpr; // NOLINT(readability-identifier-naming)
Finder->addMatcher(
explicitCastExpr(
unless(hasCastKind(CK_ConstructorConversion)),
unless(hasCastKind(CK_UserDefinedConversion)),
unless(cxxFunctionalCastExpr(hasDestinationType(unless(SimpleType)))),
hasDestinationType(qualType().bind("dstType")),
hasSourceExpression(anyOf(
expr(unless(initListExpr()), unless(BitfieldMemberExpr),
unless(cxxParenListInitExpr()),
hasType(qualType().bind("srcType")))
.bind("source"),
initListExpr(unless(hasInit(1, expr())),
hasInit(0, expr(unless(BitfieldMemberExpr),
hasType(qualType().bind("srcType")))
.bind("source"))))))
.bind("cast"),
this);
}
void RedundantCastingCheck::check(const MatchFinder::MatchResult &Result) {
const auto *SourceExpr = Result.Nodes.getNodeAs<Expr>("source");
auto TypeD = *Result.Nodes.getNodeAs<QualType>("dstType");
if (SourceExpr->getValueKind() == VK_LValue &&
TypeD.getCanonicalType()->isRValueReferenceType())
return;
const auto TypeS =
Result.Nodes.getNodeAs<QualType>("srcType")->getNonReferenceType();
TypeD = TypeD.getNonReferenceType();
if (!areTypesEqual(TypeS, TypeD, IgnoreTypeAliases))
return;
if (!areBinaryOperatorOperandsTypesEqualToOperatorResultType(
SourceExpr, IgnoreTypeAliases))
return;
const auto *CastExpr = Result.Nodes.getNodeAs<ExplicitCastExpr>("cast");
if (IgnoreMacros &&
(CastExpr->getBeginLoc().isMacroID() ||
CastExpr->getEndLoc().isMacroID() || CastExpr->getExprLoc().isMacroID()))
return;
{
auto Diag = diag(CastExpr->getExprLoc(),
"redundant explicit casting to the same type %0 as the "
"sub-expression, remove this casting");
Diag << TypeD;
const SourceManager &SM = *Result.SourceManager;
const SourceLocation SourceExprBegin =
SM.getExpansionLoc(SourceExpr->getBeginLoc());
const SourceLocation SourceExprEnd =
SM.getExpansionLoc(SourceExpr->getEndLoc());
if (SourceExprBegin != CastExpr->getBeginLoc())
Diag << FixItHint::CreateRemoval(SourceRange(
CastExpr->getBeginLoc(), SourceExprBegin.getLocWithOffset(-1)));
const SourceLocation NextToken = Lexer::getLocForEndOfToken(
SourceExprEnd, 0U, SM, Result.Context->getLangOpts());
if (SourceExprEnd != CastExpr->getEndLoc()) {
Diag << FixItHint::CreateRemoval(
SourceRange(NextToken, CastExpr->getEndLoc()));
}
if (utils::fixit::areParensNeededForStatement(*SourceExpr)) {
Diag << FixItHint::CreateInsertion(SourceExprBegin, "(")
<< FixItHint::CreateInsertion(NextToken, ")");
}
}
const auto *SourceExprDecl = getSourceExprDecl(SourceExpr);
if (!SourceExprDecl)
return;
if (const auto *D = dyn_cast<CXXConstructorDecl>(SourceExprDecl)) {
diag(D->getLocation(),
"source type originates from the invocation of this constructor",
DiagnosticIDs::Note);
return;
}
if (const auto *D = dyn_cast<FunctionDecl>(SourceExprDecl)) {
diag(D->getLocation(),
"source type originates from the invocation of this "
"%select{function|method}0",
DiagnosticIDs::Note)
<< isa<CXXMethodDecl>(D) << D->getReturnTypeSourceRange();
return;
}
if (const auto *D = dyn_cast<FieldDecl>(SourceExprDecl)) {
diag(D->getLocation(),
"source type originates from referencing this member",
DiagnosticIDs::Note)
<< SourceRange(D->getTypeSpecStartLoc(), D->getTypeSpecEndLoc());
return;
}
if (const auto *D = dyn_cast<ParmVarDecl>(SourceExprDecl)) {
diag(D->getLocation(),
"source type originates from referencing this parameter",
DiagnosticIDs::Note)
<< SourceRange(D->getTypeSpecStartLoc(), D->getTypeSpecEndLoc());
return;
}
if (const auto *D = dyn_cast<VarDecl>(SourceExprDecl)) {
diag(D->getLocation(),
"source type originates from referencing this variable",
DiagnosticIDs::Note)
<< SourceRange(D->getTypeSpecStartLoc(), D->getTypeSpecEndLoc());
return;
}
if (const auto *D = dyn_cast<EnumConstantDecl>(SourceExprDecl)) {
diag(D->getLocation(),
"source type originates from referencing this enum constant",
DiagnosticIDs::Note);
return;
}
if (const auto *D = dyn_cast<BindingDecl>(SourceExprDecl)) {
diag(D->getLocation(),
"source type originates from referencing this bound variable",
DiagnosticIDs::Note);
return;
}
if (const auto *D = dyn_cast<NonTypeTemplateParmDecl>(SourceExprDecl)) {
diag(D->getLocation(),
"source type originates from referencing this non-type template "
"parameter",
DiagnosticIDs::Note);
return;
}
}
} // namespace clang::tidy::readability
|