1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
|
//===--- FixItHintUtils.cpp - clang-tidy-----------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "FixItHintUtils.h"
#include "LexerUtils.h"
#include "clang/AST/ASTContext.h"
#include "clang/AST/ExprCXX.h"
#include "clang/AST/Type.h"
#include "clang/Sema/DeclSpec.h"
#include "clang/Tooling/FixIt.h"
#include <optional>
namespace clang::tidy::utils::fixit {
FixItHint changeVarDeclToReference(const VarDecl &Var, ASTContext &Context) {
SourceLocation AmpLocation = Var.getLocation();
auto Token = utils::lexer::getPreviousToken(
AmpLocation, Context.getSourceManager(), Context.getLangOpts());
if (!Token.is(tok::unknown))
AmpLocation = Lexer::getLocForEndOfToken(Token.getLocation(), 0,
Context.getSourceManager(),
Context.getLangOpts());
return FixItHint::CreateInsertion(AmpLocation, "&");
}
static bool isValueType(const Type *T) {
return !(isa<PointerType>(T) || isa<ReferenceType>(T) || isa<ArrayType>(T) ||
isa<MemberPointerType>(T) || isa<ObjCObjectPointerType>(T));
}
static bool isValueType(QualType QT) { return isValueType(QT.getTypePtr()); }
static bool isMemberOrFunctionPointer(QualType QT) {
return (QT->isPointerType() && QT->isFunctionPointerType()) ||
isa<MemberPointerType>(QT.getTypePtr());
}
static bool locDangerous(SourceLocation S) {
return S.isInvalid() || S.isMacroID();
}
static std::optional<SourceLocation>
skipLParensBackwards(SourceLocation Start, const ASTContext &Context) {
if (locDangerous(Start))
return std::nullopt;
auto PreviousTokenLParen = [&Start, &Context]() {
Token T;
T = lexer::getPreviousToken(Start, Context.getSourceManager(),
Context.getLangOpts());
return T.is(tok::l_paren);
};
while (Start.isValid() && PreviousTokenLParen())
Start = lexer::findPreviousTokenStart(Start, Context.getSourceManager(),
Context.getLangOpts());
if (locDangerous(Start))
return std::nullopt;
return Start;
}
static std::optional<FixItHint> fixIfNotDangerous(SourceLocation Loc,
StringRef Text) {
if (locDangerous(Loc))
return std::nullopt;
return FixItHint::CreateInsertion(Loc, Text);
}
// Build a string that can be emitted as FixIt with either a space in before
// or after the qualifier, either ' const' or 'const '.
static std::string buildQualifier(Qualifiers::TQ Qualifier,
bool WhitespaceBefore = false) {
if (WhitespaceBefore)
return (llvm::Twine(' ') + Qualifiers::fromCVRMask(Qualifier).getAsString())
.str();
return (llvm::Twine(Qualifiers::fromCVRMask(Qualifier).getAsString()) + " ")
.str();
}
static std::optional<FixItHint> changeValue(const VarDecl &Var,
Qualifiers::TQ Qualifier,
QualifierTarget QualTarget,
QualifierPolicy QualPolicy,
const ASTContext &Context) {
switch (QualPolicy) {
case QualifierPolicy::Left:
return fixIfNotDangerous(Var.getTypeSpecStartLoc(),
buildQualifier(Qualifier));
case QualifierPolicy::Right:
std::optional<SourceLocation> IgnoredParens =
skipLParensBackwards(Var.getLocation(), Context);
if (IgnoredParens)
return fixIfNotDangerous(*IgnoredParens, buildQualifier(Qualifier));
return std::nullopt;
}
llvm_unreachable("Unknown QualifierPolicy enum");
}
static std::optional<FixItHint> changePointerItself(const VarDecl &Var,
Qualifiers::TQ Qualifier,
const ASTContext &Context) {
if (locDangerous(Var.getLocation()))
return std::nullopt;
std::optional<SourceLocation> IgnoredParens =
skipLParensBackwards(Var.getLocation(), Context);
if (IgnoredParens)
return fixIfNotDangerous(*IgnoredParens, buildQualifier(Qualifier));
return std::nullopt;
}
static std::optional<FixItHint>
changePointer(const VarDecl &Var, Qualifiers::TQ Qualifier, const Type *Pointee,
QualifierTarget QualTarget, QualifierPolicy QualPolicy,
const ASTContext &Context) {
// The pointer itself shall be marked as `const`. This is always to the right
// of the '*' or in front of the identifier.
if (QualTarget == QualifierTarget::Value)
return changePointerItself(Var, Qualifier, Context);
// Mark the pointee `const` that is a normal value (`int* p = nullptr;`).
if (QualTarget == QualifierTarget::Pointee && isValueType(Pointee)) {
// Adding the `const` on the left side is just the beginning of the type
// specification. (`const int* p = nullptr;`)
if (QualPolicy == QualifierPolicy::Left)
return fixIfNotDangerous(Var.getTypeSpecStartLoc(),
buildQualifier(Qualifier));
// Adding the `const` on the right side of the value type requires finding
// the `*` token and placing the `const` left of it.
// (`int const* p = nullptr;`)
if (QualPolicy == QualifierPolicy::Right) {
SourceLocation BeforeStar = lexer::findPreviousTokenKind(
Var.getLocation(), Context.getSourceManager(), Context.getLangOpts(),
tok::star);
if (locDangerous(BeforeStar))
return std::nullopt;
std::optional<SourceLocation> IgnoredParens =
skipLParensBackwards(BeforeStar, Context);
if (IgnoredParens)
return fixIfNotDangerous(*IgnoredParens,
buildQualifier(Qualifier, true));
return std::nullopt;
}
}
if (QualTarget == QualifierTarget::Pointee && Pointee->isPointerType()) {
// Adding the `const` to the pointee if the pointee is a pointer
// is the same as 'QualPolicy == Right && isValueType(Pointee)'.
// The `const` must be left of the last `*` token.
// (`int * const* p = nullptr;`)
SourceLocation BeforeStar = lexer::findPreviousTokenKind(
Var.getLocation(), Context.getSourceManager(), Context.getLangOpts(),
tok::star);
return fixIfNotDangerous(BeforeStar, buildQualifier(Qualifier, true));
}
return std::nullopt;
}
static std::optional<FixItHint>
changeReferencee(const VarDecl &Var, Qualifiers::TQ Qualifier, QualType Pointee,
QualifierTarget QualTarget, QualifierPolicy QualPolicy,
const ASTContext &Context) {
if (QualPolicy == QualifierPolicy::Left && isValueType(Pointee))
return fixIfNotDangerous(Var.getTypeSpecStartLoc(),
buildQualifier(Qualifier));
SourceLocation BeforeRef = lexer::findPreviousAnyTokenKind(
Var.getLocation(), Context.getSourceManager(), Context.getLangOpts(),
tok::amp, tok::ampamp);
std::optional<SourceLocation> IgnoredParens =
skipLParensBackwards(BeforeRef, Context);
if (IgnoredParens)
return fixIfNotDangerous(*IgnoredParens, buildQualifier(Qualifier, true));
return std::nullopt;
}
std::optional<FixItHint> addQualifierToVarDecl(const VarDecl &Var,
const ASTContext &Context,
Qualifiers::TQ Qualifier,
QualifierTarget QualTarget,
QualifierPolicy QualPolicy) {
assert((QualPolicy == QualifierPolicy::Left ||
QualPolicy == QualifierPolicy::Right) &&
"Unexpected Insertion Policy");
assert((QualTarget == QualifierTarget::Pointee ||
QualTarget == QualifierTarget::Value) &&
"Unexpected Target");
QualType ParenStrippedType = Var.getType().IgnoreParens();
if (isValueType(ParenStrippedType))
return changeValue(Var, Qualifier, QualTarget, QualPolicy, Context);
if (ParenStrippedType->isReferenceType())
return changeReferencee(Var, Qualifier, Var.getType()->getPointeeType(),
QualTarget, QualPolicy, Context);
if (isMemberOrFunctionPointer(ParenStrippedType))
return changePointerItself(Var, Qualifier, Context);
if (ParenStrippedType->isPointerType())
return changePointer(Var, Qualifier,
ParenStrippedType->getPointeeType().getTypePtr(),
QualTarget, QualPolicy, Context);
if (ParenStrippedType->isArrayType()) {
const Type *AT = ParenStrippedType->getBaseElementTypeUnsafe();
assert(AT && "Did not retrieve array element type for an array.");
if (isValueType(AT))
return changeValue(Var, Qualifier, QualTarget, QualPolicy, Context);
if (AT->isPointerType())
return changePointer(Var, Qualifier, AT->getPointeeType().getTypePtr(),
QualTarget, QualPolicy, Context);
}
return std::nullopt;
}
bool areParensNeededForStatement(const Stmt &Node) {
if (isa<ParenExpr>(&Node))
return false;
if (isa<clang::BinaryOperator>(&Node) || isa<UnaryOperator>(&Node))
return true;
if (isa<clang::ConditionalOperator>(&Node) ||
isa<BinaryConditionalOperator>(&Node))
return true;
if (const auto *Op = dyn_cast<CXXOperatorCallExpr>(&Node)) {
switch (Op->getOperator()) {
case OO_PlusPlus:
[[fallthrough]];
case OO_MinusMinus:
return Op->getNumArgs() != 2;
case OO_Call:
[[fallthrough]];
case OO_Subscript:
[[fallthrough]];
case OO_Arrow:
return false;
default:
return true;
};
}
if (isa<CStyleCastExpr>(&Node))
return true;
return false;
}
// Return true if expr needs to be put in parens when it is an argument of a
// prefix unary operator, e.g. when it is a binary or ternary operator
// syntactically.
static bool needParensAfterUnaryOperator(const Expr &ExprNode) {
if (isa<clang::BinaryOperator>(&ExprNode) ||
isa<clang::ConditionalOperator>(&ExprNode)) {
return true;
}
if (const auto *Op = dyn_cast<CXXOperatorCallExpr>(&ExprNode)) {
return Op->getNumArgs() == 2 && Op->getOperator() != OO_PlusPlus &&
Op->getOperator() != OO_MinusMinus && Op->getOperator() != OO_Call &&
Op->getOperator() != OO_Subscript;
}
return false;
}
// Format a pointer to an expression: prefix with '*' but simplify
// when it already begins with '&'. Return empty string on failure.
std::string formatDereference(const Expr &ExprNode, const ASTContext &Context) {
if (const auto *Op = dyn_cast<clang::UnaryOperator>(&ExprNode)) {
if (Op->getOpcode() == UO_AddrOf) {
// Strip leading '&'.
return std::string(
tooling::fixit::getText(*Op->getSubExpr()->IgnoreParens(), Context));
}
}
StringRef Text = tooling::fixit::getText(ExprNode, Context);
if (Text.empty())
return {};
// Remove remaining '->' from overloaded operator call
Text.consume_back("->");
// Add leading '*'.
if (needParensAfterUnaryOperator(ExprNode)) {
return (llvm::Twine("*(") + Text + ")").str();
}
return (llvm::Twine("*") + Text).str();
}
} // namespace clang::tidy::utils::fixit
|