1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238
|
//=== CXXDeleteChecker.cpp -------------------------------------*- C++ -*--===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// This file defines the following new checkers for C++ delete expressions:
//
// * DeleteWithNonVirtualDtorChecker
// Defines a checker for the OOP52-CPP CERT rule: Do not delete a
// polymorphic object without a virtual destructor.
//
// Diagnostic flags -Wnon-virtual-dtor and -Wdelete-non-virtual-dtor
// report if an object with a virtual function but a non-virtual
// destructor exists or is deleted, respectively.
//
// This check exceeds them by comparing the dynamic and static types of
// the object at the point of destruction and only warns if it happens
// through a pointer to a base type without a virtual destructor. The
// check places a note at the last point where the conversion from
// derived to base happened.
//
// * CXXArrayDeleteChecker
// Defines a checker for the EXP51-CPP CERT rule: Do not delete an array
// through a pointer of the incorrect type.
//
//===----------------------------------------------------------------------===//
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
#include "clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h"
#include "clang/StaticAnalyzer/Core/Checker.h"
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/DynamicType.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
using namespace clang;
using namespace ento;
namespace {
class CXXDeleteChecker : public Checker<check::PreStmt<CXXDeleteExpr>> {
protected:
class PtrCastVisitor : public BugReporterVisitor {
public:
void Profile(llvm::FoldingSetNodeID &ID) const override {
static int X = 0;
ID.AddPointer(&X);
}
PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
BugReporterContext &BRC,
PathSensitiveBugReport &BR) override;
};
virtual void
checkTypedDeleteExpr(const CXXDeleteExpr *DE, CheckerContext &C,
const TypedValueRegion *BaseClassRegion,
const SymbolicRegion *DerivedClassRegion) const = 0;
public:
void checkPreStmt(const CXXDeleteExpr *DE, CheckerContext &C) const;
};
class DeleteWithNonVirtualDtorChecker : public CXXDeleteChecker {
const BugType BT{
this, "Destruction of a polymorphic object with no virtual destructor"};
void
checkTypedDeleteExpr(const CXXDeleteExpr *DE, CheckerContext &C,
const TypedValueRegion *BaseClassRegion,
const SymbolicRegion *DerivedClassRegion) const override;
};
class CXXArrayDeleteChecker : public CXXDeleteChecker {
const BugType BT{this,
"Deleting an array of polymorphic objects is undefined"};
void
checkTypedDeleteExpr(const CXXDeleteExpr *DE, CheckerContext &C,
const TypedValueRegion *BaseClassRegion,
const SymbolicRegion *DerivedClassRegion) const override;
};
} // namespace
void CXXDeleteChecker::checkPreStmt(const CXXDeleteExpr *DE,
CheckerContext &C) const {
const Expr *DeletedObj = DE->getArgument();
const MemRegion *MR = C.getSVal(DeletedObj).getAsRegion();
if (!MR)
return;
OverloadedOperatorKind DeleteKind =
DE->getOperatorDelete()->getOverloadedOperator();
if (DeleteKind != OO_Delete && DeleteKind != OO_Array_Delete)
return;
const auto *BaseClassRegion = MR->getAs<TypedValueRegion>();
const auto *DerivedClassRegion = MR->getBaseRegion()->getAs<SymbolicRegion>();
if (!BaseClassRegion || !DerivedClassRegion)
return;
checkTypedDeleteExpr(DE, C, BaseClassRegion, DerivedClassRegion);
}
void DeleteWithNonVirtualDtorChecker::checkTypedDeleteExpr(
const CXXDeleteExpr *DE, CheckerContext &C,
const TypedValueRegion *BaseClassRegion,
const SymbolicRegion *DerivedClassRegion) const {
const auto *BaseClass = BaseClassRegion->getValueType()->getAsCXXRecordDecl();
const auto *DerivedClass =
DerivedClassRegion->getSymbol()->getType()->getPointeeCXXRecordDecl();
if (!BaseClass || !DerivedClass)
return;
if (!BaseClass->hasDefinition() || !DerivedClass->hasDefinition())
return;
if (BaseClass->getDestructor()->isVirtual())
return;
if (!DerivedClass->isDerivedFrom(BaseClass))
return;
ExplodedNode *N = C.generateNonFatalErrorNode();
if (!N)
return;
auto R = std::make_unique<PathSensitiveBugReport>(BT, BT.getDescription(), N);
// Mark region of problematic base class for later use in the BugVisitor.
R->markInteresting(BaseClassRegion);
R->addVisitor<PtrCastVisitor>();
C.emitReport(std::move(R));
}
void CXXArrayDeleteChecker::checkTypedDeleteExpr(
const CXXDeleteExpr *DE, CheckerContext &C,
const TypedValueRegion *BaseClassRegion,
const SymbolicRegion *DerivedClassRegion) const {
const auto *BaseClass = BaseClassRegion->getValueType()->getAsCXXRecordDecl();
const auto *DerivedClass =
DerivedClassRegion->getSymbol()->getType()->getPointeeCXXRecordDecl();
if (!BaseClass || !DerivedClass)
return;
if (!BaseClass->hasDefinition() || !DerivedClass->hasDefinition())
return;
if (DE->getOperatorDelete()->getOverloadedOperator() != OO_Array_Delete)
return;
if (!DerivedClass->isDerivedFrom(BaseClass))
return;
ExplodedNode *N = C.generateNonFatalErrorNode();
if (!N)
return;
SmallString<256> Buf;
llvm::raw_svector_ostream OS(Buf);
QualType SourceType = BaseClassRegion->getValueType();
QualType TargetType =
DerivedClassRegion->getSymbol()->getType()->getPointeeType();
OS << "Deleting an array of '" << TargetType.getAsString()
<< "' objects as their base class '"
<< SourceType.getAsString(C.getASTContext().getPrintingPolicy())
<< "' is undefined";
auto R = std::make_unique<PathSensitiveBugReport>(BT, OS.str(), N);
// Mark region of problematic base class for later use in the BugVisitor.
R->markInteresting(BaseClassRegion);
R->addVisitor<PtrCastVisitor>();
C.emitReport(std::move(R));
}
PathDiagnosticPieceRef
CXXDeleteChecker::PtrCastVisitor::VisitNode(const ExplodedNode *N,
BugReporterContext &BRC,
PathSensitiveBugReport &BR) {
const Stmt *S = N->getStmtForDiagnostics();
if (!S)
return nullptr;
const auto *CastE = dyn_cast<CastExpr>(S);
if (!CastE)
return nullptr;
// FIXME: This way of getting base types does not support reference types.
QualType SourceType = CastE->getSubExpr()->getType()->getPointeeType();
QualType TargetType = CastE->getType()->getPointeeType();
if (SourceType.isNull() || TargetType.isNull() || SourceType == TargetType)
return nullptr;
// Region associated with the current cast expression.
const MemRegion *M = N->getSVal(CastE).getAsRegion();
if (!M)
return nullptr;
// Check if target region was marked as problematic previously.
if (!BR.isInteresting(M))
return nullptr;
SmallString<256> Buf;
llvm::raw_svector_ostream OS(Buf);
OS << "Casting from '" << SourceType.getAsString() << "' to '"
<< TargetType.getAsString() << "' here";
PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
N->getLocationContext());
return std::make_shared<PathDiagnosticEventPiece>(Pos, OS.str(),
/*addPosRange=*/true);
}
void ento::registerArrayDeleteChecker(CheckerManager &mgr) {
mgr.registerChecker<CXXArrayDeleteChecker>();
}
bool ento::shouldRegisterArrayDeleteChecker(const CheckerManager &mgr) {
return true;
}
void ento::registerDeleteWithNonVirtualDtorChecker(CheckerManager &mgr) {
mgr.registerChecker<DeleteWithNonVirtualDtorChecker>();
}
bool ento::shouldRegisterDeleteWithNonVirtualDtorChecker(
const CheckerManager &mgr) {
return true;
}
|