1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
// RUN: %check_clang_tidy -std=c++98-or-later %s bugprone-non-zero-enum-to-bool-conversion %t -- \
// RUN: -config="{CheckOptions: {bugprone-non-zero-enum-to-bool-conversion.EnumIgnoreList: '::without::issue::IgnoredEnum;IgnoredSecondEnum'}}"
namespace with::issue {
typedef enum EStatus {
SUCCESS = 1,
FAILURE = 2,
INVALID_PARAM = 3,
UNKNOWN = 4
} Status;
bool testEnumConversion(EStatus value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EStatus' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return value;
}
bool testTypedefConversion(Status value) {
// CHECK-MESSAGES: :[[@LINE+1]]:10: warning: conversion of 'EStatus' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return value;
}
bool testExplicitConversion(EStatus value) {
// CHECK-MESSAGES: :[[@LINE+1]]:28: warning: conversion of 'EStatus' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return static_cast<bool>(value);
}
bool testInIfConversion(EStatus value) {
// CHECK-MESSAGES: :[[@LINE+1]]:7: warning: conversion of 'EStatus' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
if (value) {
return false;
}
return true;
}
bool testWithNegation(EStatus value) {
// CHECK-MESSAGES: :[[@LINE+1]]:14: warning: conversion of 'EStatus' into 'bool' will always return 'true', enum doesn't have a zero-value enumerator [bugprone-non-zero-enum-to-bool-conversion]
return not value;
}
}
namespace without::issue {
enum StatusWithZero {
UNK = 0,
OK = 1,
NOT_OK = 2
};
bool testEnumConversion(StatusWithZero value) {
return value;
}
enum WithDefault {
Value0,
Value1
};
bool testEnumConversion(WithDefault value) {
return value;
}
enum WithNegative : int {
Nen2 = -2,
Nen1,
Nen0
};
bool testEnumConversion(WithNegative value) {
return value;
}
enum EStatus {
SUCCESS = 1,
FAILURE,
INVALID_PARAM,
UNKNOWN
};
bool explicitCompare(EStatus value) {
return value == SUCCESS;
}
bool explicitBitUsage1(EStatus value) {
return (value & SUCCESS);
}
bool explicitBitUsage2(EStatus value) {
return (value | SUCCESS);
}
bool testEnumeratorCompare() {
return SUCCESS;
}
enum IgnoredEnum {
IGNORED_VALUE_1 = 1,
IGNORED_VALUE_2
};
enum IgnoredSecondEnum {
IGNORED_SECOND_VALUE_1 = 1,
IGNORED_SECOND_VALUE_2
};
bool testIgnored(IgnoredEnum value) {
return value;
}
bool testIgnored(IgnoredSecondEnum value) {
return value;
}
enum CustomOperatorEnum {
E0 = 0x1,
E1 = 0x2,
E2 = 0x4
};
CustomOperatorEnum operator&(CustomOperatorEnum a, CustomOperatorEnum b) { return static_cast<CustomOperatorEnum>(a & b); }
void testCustomOperator(CustomOperatorEnum e) {
if (e & E1) {}
if ((e & E1)) {}
if (!(e & E1)) {}
}
}
|
