File: avoid-nested-conditional-operator.cpp

package info (click to toggle)
llvm-toolchain-20 1%3A20.1.8-1~exp1
  • links: PTS, VCS
  • area: main
  • in suites: experimental
  • size: 2,111,388 kB
  • sloc: cpp: 7,438,767; ansic: 1,393,871; asm: 1,012,926; python: 241,728; f90: 86,635; objc: 75,411; lisp: 42,144; pascal: 17,286; sh: 10,027; ml: 5,082; perl: 4,730; awk: 3,523; makefile: 3,349; javascript: 2,251; xml: 892; fortran: 672
file content (24 lines) | stat: -rw-r--r-- 1,710 bytes parent folder | download | duplicates (12)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
// RUN: %check_clang_tidy %s readability-avoid-nested-conditional-operator %t

int NestInConditional = (true ? true : false) ? 1 : 2;
// CHECK-MESSAGES: :[[@LINE-1]]:26: warning: conditional operator is used as sub-expression of parent conditional operator, refrain from using nested conditional operators
// CHECK-MESSAGES: :[[@LINE-2]]:25: note: parent conditional operator here

int NestInTrue = true ? (true ? 1 : 2) : 2;
// CHECK-MESSAGES: :[[@LINE-1]]:26: warning: conditional operator is used as sub-expression of parent conditional operator, refrain from using nested conditional operators
// CHECK-MESSAGES: :[[@LINE-2]]:18: note: parent conditional operator here

int NestInFalse = true ? 1 : true ? 1 : 2;
// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: conditional operator is used as sub-expression of parent conditional operator, refrain from using nested conditional operators
// CHECK-MESSAGES: :[[@LINE-2]]:19: note: parent conditional operator here
int NestInFalse2 = true ? 1 : (true ? 1 : 2);
// CHECK-MESSAGES: :[[@LINE-1]]:32: warning: conditional operator is used as sub-expression of parent conditional operator, refrain from using nested conditional operators
// CHECK-MESSAGES: :[[@LINE-2]]:20: note: parent conditional operator here

int NestWithParensis = true ? 1 : ((((true ? 1 : 2))));
// CHECK-MESSAGES: :[[@LINE-1]]:39: warning: conditional operator is used as sub-expression of parent conditional operator, refrain from using nested conditional operators
// CHECK-MESSAGES: :[[@LINE-2]]:24: note: parent conditional operator here

#define CONDITIONAL_EXPR (true ? 1 : 2)
// not diag for macro since it will not reduce readability
int NestWithMacro = true ? CONDITIONAL_EXPR : 2;