1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
|
// RUN: %check_clang_tidy %s readability-implicit-bool-conversion %t \
// RUN: -config='{CheckOptions: \
// RUN: {readability-implicit-bool-conversion.AllowIntegerConditions: true, \
// RUN: readability-implicit-bool-conversion.AllowPointerConditions: true}}'
template<typename T>
void functionTaking(T);
int functionReturningInt();
int* functionReturningPointer();
struct Struct {
int member;
unsigned bitfield : 1;
bool boolfield : 1;
};
void regularImplicitConversionIntegerToBoolIsNotIgnored() {
int integer = 0;
functionTaking<bool>(integer);
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
// CHECK-FIXES: functionTaking<bool>(integer != 0);
}
void implicitConversionIntegerToBoolInConditionalsIsAllowed() {
Struct s = {};
if (s.member) {}
if (!s.member) {}
if (s.bitfield) {}
if (!s.bitfield) {}
if (s.boolfield == true) {}
if (s.boolfield != true) {}
if (functionReturningInt()) {}
if (!functionReturningInt()) {}
if (functionReturningInt() && functionReturningPointer()) {}
if (!functionReturningInt() && !functionReturningPointer()) {}
for (; functionReturningInt(); ) {}
for (; functionReturningPointer(); ) {}
for (; functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer()); ) {}
while (functionReturningInt()) {}
while (functionReturningPointer()) {}
while (functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer())) {}
do {} while (functionReturningInt());
do {} while (functionReturningPointer());
do {} while (functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer()));
int value1 = functionReturningInt() ? 1 : 2;
int value2 = !functionReturningInt() ? 1 : 2;
int value3 = (functionReturningInt() && functionReturningPointer() || !functionReturningInt()) ? 1 : 2;
int value4 = functionReturningInt() ?: value3;
int *p1 = functionReturningPointer() ?: &value3;
}
void regularImplicitConversionPointerToBoolIsNotIgnored() {
int* pointer = nullptr;
functionTaking<bool>(pointer);
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit conversion 'int *' -> 'bool'
// CHECK-FIXES: functionTaking<bool>(pointer != nullptr);
int Struct::* memberPointer = &Struct::member;
functionTaking<bool>(memberPointer);
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit conversion 'int Struct::*' -> 'bool'
// CHECK-FIXES: functionTaking<bool>(memberPointer != nullptr);
}
void implicitConversionPointerToBoolInConditionalsIsAllowed() {
if (functionReturningPointer()) {}
if (not functionReturningPointer()) {}
int value1 = functionReturningPointer() ? 1 : 2;
int value2 = (not functionReturningPointer()) ? 1 : 2;
int Struct::* memberPointer = &Struct::member;
if (memberPointer) {}
if (memberPointer) {}
int value3 = memberPointer ? 1 : 2;
int value4 = (not memberPointer) ? 1 : 2;
}
|
