1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
|
// RUN: %clang_analyze_cc1 -analyzer-checker=webkit.RefCntblBaseVirtualDtor -verify %s
#include "mock-types.h"
namespace Detail {
template<typename Out, typename... In>
class CallableWrapperBase {
public:
virtual ~CallableWrapperBase() { }
virtual Out call(In...) = 0;
};
template<typename, typename, typename...> class CallableWrapper;
template<typename CallableType, typename Out, typename... In>
class CallableWrapper : public CallableWrapperBase<Out, In...> {
public:
explicit CallableWrapper(CallableType&& callable)
: m_callable(WTFMove(callable)) { }
CallableWrapper(const CallableWrapper&) = delete;
CallableWrapper& operator=(const CallableWrapper&) = delete;
Out call(In... in) final;
private:
CallableType m_callable;
};
} // namespace Detail
template<typename> class Function;
template<typename Out, typename... In> Function<Out(In...)> adopt(Detail::CallableWrapperBase<Out, In...>*);
template <typename Out, typename... In>
class Function<Out(In...)> {
public:
using Impl = Detail::CallableWrapperBase<Out, In...>;
Function() = default;
template<typename FunctionType>
Function(FunctionType f);
Out operator()(In... in) const;
explicit operator bool() const { return !!m_callableWrapper; }
private:
enum AdoptTag { Adopt };
Function(Impl* impl, AdoptTag)
: m_callableWrapper(impl)
{
}
friend Function adopt<Out, In...>(Impl*);
Impl* m_callableWrapper;
};
template<typename Out, typename... In> Function<Out(In...)> adopt(Detail::CallableWrapperBase<Out, In...>* impl)
{
return Function<Out(In...)>(impl, Function<Out(In...)>::Adopt);
}
enum class DestructionThread : unsigned char { Any, Main, MainRunLoop };
void ensureOnMainThread(Function<void()>&&); // Sync if called on main thread, async otherwise.
void ensureOnMainRunLoop(Function<void()>&&); // Sync if called on main run loop, async otherwise.
class ThreadSafeRefCountedBase {
public:
ThreadSafeRefCountedBase() = default;
void ref() const
{
++m_refCount;
}
bool hasOneRef() const
{
return refCount() == 1;
}
unsigned refCount() const
{
return m_refCount;
}
protected:
bool derefBase() const
{
if (!--m_refCount) {
m_refCount = 1;
return true;
}
return false;
}
private:
mutable unsigned m_refCount { 1 };
};
template<class T, DestructionThread destructionThread = DestructionThread::Any> class ThreadSafeRefCounted : public ThreadSafeRefCountedBase {
public:
void deref() const
{
if (!derefBase())
return;
if constexpr (destructionThread == DestructionThread::Any) {
delete static_cast<const T*>(this);
} else if constexpr (destructionThread == DestructionThread::Main) {
ensureOnMainThread([this] {
delete static_cast<const T*>(this);
});
} else if constexpr (destructionThread == DestructionThread::MainRunLoop) {
auto deleteThis = [this] {
delete static_cast<const T*>(this);
};
ensureOnMainThread(deleteThis);
}
}
protected:
ThreadSafeRefCounted() = default;
};
class FancyRefCountedClass final : public ThreadSafeRefCounted<FancyRefCountedClass, DestructionThread::Main> {
public:
static Ref<FancyRefCountedClass> create()
{
return adoptRef(*new FancyRefCountedClass());
}
virtual ~FancyRefCountedClass();
private:
FancyRefCountedClass();
};
template<class T, DestructionThread destructionThread = DestructionThread::Any> class BadThreadSafeRefCounted : public ThreadSafeRefCountedBase {
public:
void deref() const
{
if (!derefBase())
return;
[this] {
delete static_cast<const T*>(this);
};
}
protected:
BadThreadSafeRefCounted() = default;
};
class FancyRefCountedClass2 final : public ThreadSafeRefCounted<FancyRefCountedClass, DestructionThread::Main> {
// expected-warning@-1{{Class 'ThreadSafeRefCounted<FancyRefCountedClass, DestructionThread::Main>' is used as a base of class 'FancyRefCountedClass2' but doesn't have virtual destructor}}
public:
static Ref<FancyRefCountedClass2> create()
{
return adoptRef(*new FancyRefCountedClass2());
}
virtual ~FancyRefCountedClass2();
private:
FancyRefCountedClass2();
};
template<class T, DestructionThread destructionThread = DestructionThread::Any> class NestedThreadSafeRefCounted : public ThreadSafeRefCountedBase {
public:
void deref() const
{
if (!derefBase())
return;
ensureOnMainRunLoop([&] {
auto destroyThis = [&] {
delete static_cast<const T*>(this);
};
destroyThis();
});
}
protected:
NestedThreadSafeRefCounted() = default;
};
class FancyRefCountedClass3 final : public NestedThreadSafeRefCounted<FancyRefCountedClass3, DestructionThread::Main> {
public:
static Ref<FancyRefCountedClass3> create()
{
return adoptRef(*new FancyRefCountedClass3());
}
virtual ~FancyRefCountedClass3();
private:
FancyRefCountedClass3();
};
template<class T, DestructionThread destructionThread = DestructionThread::Any> class BadNestedThreadSafeRefCounted : public ThreadSafeRefCountedBase {
public:
void deref() const
{
if (!derefBase())
return;
ensureOnMainThread([&] {
auto destroyThis = [&] {
delete static_cast<const T*>(this);
};
});
}
protected:
BadNestedThreadSafeRefCounted() = default;
};
class FancyRefCountedClass4 final : public BadNestedThreadSafeRefCounted<FancyRefCountedClass4, DestructionThread::Main> {
// expected-warning@-1{{Class 'BadNestedThreadSafeRefCounted<FancyRefCountedClass4, DestructionThread::Main>' is used as a base of class 'FancyRefCountedClass4' but doesn't have virtual destructor}}
public:
static Ref<FancyRefCountedClass4> create()
{
return adoptRef(*new FancyRefCountedClass4());
}
virtual ~FancyRefCountedClass4();
private:
FancyRefCountedClass4();
};
class FancyRefCountedClass5 final : public ThreadSafeRefCounted<FancyRefCountedClass5, DestructionThread::MainRunLoop> {
public:
static Ref<FancyRefCountedClass5> create()
{
return adoptRef(*new FancyRefCountedClass5());
}
virtual ~FancyRefCountedClass5();
private:
FancyRefCountedClass5();
};
|
