1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273
|
// RUN: %clang_cc1 -verify -fblocks -fsyntax-only -Wformat-nonliteral -Wformat-signedness -isystem %S/Inputs %s
// RUN: %clang_cc1 -verify -fblocks -fsyntax-only -Wformat-nonliteral -Wformat-signedness -isystem %S/Inputs -fno-signed-char %s
#include <stdarg.h>
__attribute__((format_matches(printf, -1, "%s"))) // expected-error{{'format_matches' attribute parameter 2 is out of bounds}}
int test_out_of_bounds(void);
__attribute__((format_matches(printf, 0, "%s"))) // expected-error{{'format_matches' attribute parameter 2 is out of bounds}}
int test_out_of_bounds(void);
__attribute__((format_matches(printf, 1, "%s"))) // expected-error{{'format_matches' attribute parameter 2 is out of bounds}}
int test_out_of_bounds(void);
__attribute__((format_matches(printf, 1, "%s"))) // expected-error{{format argument not a string type}}
int test_out_of_bounds_int(int x);
// MARK: -
// Calling printf with a format from format_matches(printf) diagnoses with
// that format string
__attribute__((format(printf, 1, 2)))
int printf(const char *fmt, ...);
__attribute__((format(printf, 1, 0)))
int vprintf(const char *fmt, va_list);
__attribute__((format_matches(printf, 1, "%s %1.5s")))
void format_str_str0(const char *fmt) {
printf(fmt, "hello", "world");
}
__attribute__((format_matches(printf, 1, "%s" "%1.5s")))
void format_str_str1(const char *fmt) {
printf(fmt, "hello", "world");
}
__attribute__((format_matches(printf, 1, ("%s" "%1.5s") + 5))) // expected-error{{format string is not a string literal}}
void format_str_str2(const char *fmt);
__attribute__((format_matches(printf, 1, "%s %g"))) // expected-note{{format string is defined here}}
void format_str_double_warn(const char *fmt) {
printf(fmt, "hello", "world"); // expected-warning{{format specifies type 'double' but the argument has type 'char *'}}
}
__attribute__((format_matches(printf, 1, "%s %g")))
void vformat(const char *fmt, ...) {
va_list ap;
va_start(ap, fmt);
vprintf(fmt, ap); // XXX: ideally this would be a diagnostic
va_end(ap);
}
// MARK: -
// Calling a function with format_matches diagnoses for incompatible formats.
void cvt_percent(const char *c) __attribute__((format_matches(printf, 1, "%%"))); // expected-note 2{{comparing with this format string}}
void cvt_at(const char *c) __attribute__((format_matches(NSString, 1, "%@"))); // \
expected-note{{comparing with this specifier}} \
expected-note 3{{comparing with this format string}}
void cvt_c(const char *c) __attribute__((format_matches(printf, 1, "%c"))); // expected-note{{comparing with this specifier}}
void cvt_u(const char *c) __attribute__((format_matches(printf, 1, "%u"))); // expected-note 2{{comparing with this specifier}}
void cvt_hhi(const char *c) __attribute__((format_matches(printf, 1, "%hhi"))); // expected-note 3{{comparing with this specifier}}
void cvt_i(const char *c) __attribute__((format_matches(printf, 1, "%i"))); // expected-note 5{{comparing with this specifier}}
void cvt_p(const char *c) __attribute__((format_matches(printf, 1, "%p")));
void cvt_s(const char *c) __attribute__((format_matches(printf, 1, "%s"))); // expected-note{{comparing with this specifier}}
void cvt_n(const char *c) __attribute__((format_matches(printf, 1, "%n"))); // expected-note{{comparing with this specifier}}
void test_compatibility(void) {
cvt_c("%i");
const char *const fmt_i = "%i";
cvt_c(fmt_i);
cvt_i("%c");
cvt_c("%u"); // expected-warning{{signedness of format specifier 'u' is incompatible with 'c'}}
cvt_u("%c"); // expected-warning{{signedness of format specifier 'c' is incompatible with 'u'}}
const char *const fmt_c = "%c"; // expected-note{{format string is defined here}}
cvt_u(fmt_c); // expected-warning{{signedness of format specifier 'c' is incompatible with 'u'}}
cvt_i("%hi"); // expected-warning{{format specifier 'hi' is incompatible with 'i'}}
cvt_i("%hhi"); // expected-warning{{format specifier 'hhi' is incompatible with 'i'}}
cvt_i("%lli"); // expected-warning{{format specifier 'lli' is incompatible with 'i'}}
cvt_i("%p"); // expected-warning{{format specifier 'p' is incompatible with 'i'}}
cvt_hhi("%hhi");
cvt_hhi("%hi"); // expected-warning{{format specifier 'hi' is incompatible with 'hhi'}}
cvt_hhi("%i"); // expected-warning{{format specifier 'i' is incompatible with 'hhi'}}
cvt_hhi("%li"); // expected-warning{{format specifier 'li' is incompatible with 'hhi'}}
cvt_n("%s"); // expected-warning{{format specifier 's' is incompatible with 'n'}}
cvt_s("%hhn"); // expected-warning{{format specifier 'hhn' is incompatible with 's'}}
cvt_p("%@"); // expected-warning{{invalid conversion specifier '@'}}
cvt_at("%p"); // expected-warning{{format specifier 'p' is incompatible with '@'}}
cvt_percent("hello");
cvt_percent("%c"); // expected-warning{{more specifiers in format string than expected}}
const char *const too_many = "%c"; // expected-note{{format string is defined here}}
cvt_percent(too_many); // expected-warning{{more specifiers in format string than expected}}
}
void test_too_few_args(void) {
cvt_at("a"); // expected-warning{{fewer specifiers in format string than expected}}
cvt_at("%@ %@"); // expected-warning{{more specifiers in format string than expected}}
const char *const too_few = "a"; // expected-note{{format string is defined here}}
cvt_at(too_few); // expected-warning{{fewer specifiers in format string than expected}}
}
void cvt_several(const char *c) __attribute__((format_matches(printf, 1, "%f %i %s"))); // expected-note{{comparing with this specifier}}
void test_moving_args_around(void) {
cvt_several("%1g %-d %1.5s");
cvt_several("%3$s %1$g %2$i");
cvt_several("%f %*s"); // expected-warning{{format argument is an indirect field width, but it should be a value}}
}
void cvt_freebsd_D(const char *c) __attribute__((format_matches(freebsd_kprintf, 1, "%D"))); // expected-note{{comparing with this specifier}}
void test_freebsd_specifiers(void) {
cvt_freebsd_D("%D");
cvt_freebsd_D("%b");
cvt_freebsd_D("%s %i"); // expected-warning{{format argument is a value, but it should be an auxiliary value}}
}
// passing the wrong kind of string literal
void takes_printf_string(const char *fmt) __attribute__((format_matches(printf, 1, "%s")));
__attribute__((format_matches(freebsd_kprintf, 1, "%s"))) // expected-note{{format string is defined here}}
void takes_freebsd_kprintf_string(const char *fmt) {
takes_printf_string(fmt); // expected-warning{{passing 'freebsd_kprintf' format string where 'printf' format string is expected}}
const char *const fmt2 = fmt;
takes_printf_string(fmt2); // expected-warning{{passing 'freebsd_kprintf' format string where 'printf' format string is expected}}
}
__attribute__((format_matches(printf, 1, "%s"))) // expected-note{{comparing with this specifier}}
__attribute__((format_matches(os_log, 2, "%i"))) // expected-note{{comparing with this specifier}}
void test_recv_multiple_format_strings(const char *fmt1, const char *fmt2);
__attribute__((format_matches(printf, 1, "%s")))
__attribute__((format_matches(os_log, 2, "%i")))
void test_multiple_format_strings(const char *fmt1, const char *fmt2) {
test_recv_multiple_format_strings("%s", "%i");
test_recv_multiple_format_strings("%s", "%s"); // expected-warning{{format specifier 's' is incompatible with 'i'}}
test_recv_multiple_format_strings("%i", "%i"); // expected-warning{{format specifier 'i' is incompatible with 's'}}
test_recv_multiple_format_strings(fmt1, fmt2);
test_recv_multiple_format_strings("%.5s", fmt2);
test_recv_multiple_format_strings(fmt1, "%04d");
test_recv_multiple_format_strings("%s", fmt1); // expected-warning{{passing 'printf' format string where 'os_log' format string is expected}}
test_recv_multiple_format_strings(fmt2, "%d"); // expected-warning{{passing 'os_log' format string where 'printf' format string is expected}}
test_recv_multiple_format_strings(fmt2, fmt1); // \
expected-warning{{passing 'printf' format string where 'os_log' format string is expected}} \
expected-warning{{passing 'os_log' format string where 'printf' format string is expected}}
}
__attribute__((format_matches(os_log, 1, "%{public}s"))) // expected-note 4{{comparing with this specifier}}
void call_oslog_public(const char *fmt);
__attribute__((format_matches(os_log, 1, "%{sensitive}s"))) // expected-note 2{{comparing with this specifier}}
void call_oslog_sensitive(const char *fmt);
__attribute__((format_matches(os_log, 1, "%{private}s"))) // expected-note 2{{comparing with this specifier}}
void call_oslog_private(const char *fmt);
void test_oslog(void) {
call_oslog_public("%{public}s");
call_oslog_public("%{private}s"); // expected-warning{{argument sensitivity is private, but it should be public}}
call_oslog_public("%{sensitive}s"); // expected-warning{{argument sensitivity is sensitive, but it should be public}}
call_oslog_sensitive("%{public}s"); // expected-warning{{argument sensitivity is public, but it should be sensitive}}
call_oslog_sensitive("%{private}s"); // expected-warning{{argument sensitivity is private, but it should be sensitive}}
call_oslog_sensitive("%{sensitive}s");
call_oslog_private("%{public}s"); // expected-warning{{argument sensitivity is public, but it should be private}}
call_oslog_private("%{private}s");
call_oslog_private("%{sensitive}s"); // expected-warning{{argument sensitivity is sensitive, but it should be private}}
// expected-warning@+2{{argument sensitivity is private, but it should be public}}
// expected-warning@+1{{format specifier 'i' is incompatible with 's'}}
call_oslog_public("%{private}i");
}
// MARK: -
void accept_value(const char *f) __attribute__((format_matches(freebsd_kprintf, 1, "%s%i%i"))); // \
expected-note 3{{comparing with this specifier}} \
expected-note 3{{format string is defined here}}
void accept_indirect_field_width(const char *f) __attribute__((format_matches(freebsd_kprintf, 1, "%s%*i"))); // \
expected-note 3{{comparing with this specifier}} \
expected-note 3{{format string is defined here}}
void accept_indirect_field_precision(const char *f) __attribute__((format_matches(freebsd_kprintf, 1, "%s%.*i"))); // \
expected-note 3{{comparing with this specifier}} \
expected-note 3{{format string is defined here}}
void accept_aux_value(const char *f) __attribute__((format_matches(freebsd_kprintf, 1, "%D%i"))); // \
expected-note 3{{comparing with this specifier}} \
expected-note 3{{format string is defined here}}
void accept_value(const char *f) {
accept_indirect_field_width(f); // expected-warning{{format argument is a value, but it should be an indirect field width}}
accept_indirect_field_precision(f); // expected-warning{{format argument is a value, but it should be an indirect precision}}
accept_aux_value(f); // expected-warning{{format argument is a value, but it should be an auxiliary value}}
}
void accept_indirect_field_width(const char *f) {
accept_value(f); // expected-warning{{format argument is an indirect field width, but it should be a value}}
accept_indirect_field_precision(f); // expected-warning{{format argument is an indirect field width, but it should be an indirect precision}}
accept_aux_value(f); // expected-warning{{format argument is an indirect field width, but it should be an auxiliary value}}
}
void accept_indirect_field_precision(const char *f) {
accept_value(f); // expected-warning{{format argument is an indirect precision, but it should be a value}}
accept_indirect_field_width(f); // expected-warning{{format argument is an indirect precision, but it should be an indirect field width}}
accept_aux_value(f); // expected-warning{{format argument is an indirect precision, but it should be an auxiliary value}}
}
void accept_aux_value(const char *f) {
accept_value(f); // expected-warning{{format argument is an auxiliary value, but it should be a value}}
accept_indirect_field_width(f); // expected-warning{{format argument is an auxiliary value, but it should be an indirect field width}}
accept_indirect_field_precision(f); // expected-warning{{format argument is an auxiliary value, but it should be an indirect precision}}
}
// MARK: - Merging format attributes
__attribute__((format_matches(printf, 1, "%i")))
__attribute__((format_matches(printf, 1, "%d")))
void test_merge_self(const char *f);
__attribute__((format_matches(printf, 1, "%i"))) // expected-note{{comparing with this specifier}}
__attribute__((format_matches(printf, 1, "%s"))) // expected-warning{{format specifier 's' is incompatible with 'i'}}
void test_merge_self_warn(const char *f);
__attribute__((format_matches(printf, 1, "%i")))
void test_merge_redecl(const char *f);
__attribute__((format_matches(printf, 1, "%d")))
void test_merge_redecl(const char *f);
// XXX: ideally the warning and note would be swapped, but this is entirely
// reliant on which decl clang considers to be the "true one", and it might
// upset something else more important if we tried to change it.
__attribute__((format_matches(printf, 1, "%i"))) // expected-warning{{format specifier 'i' is incompatible with 's'}}
void test_merge_redecl_warn(const char *f);
__attribute__((format_matches(printf, 1, "%s"))) // expected-note{{comparing with this specifier}}
void test_merge_redecl_warn(const char *f);
// MARK: -
// Positional madness
__attribute__((format_matches(printf, 1, "%1$s %1$d"))) // \
expected-warning{{format specifier 'd' is incompatible with 's'}} \
expected-note{{comparing with this specifier}}
void test_positional_incompatible(const char *f);
void call_positional_incompatible(void) {
// expect the attribute was dropped and that there is no diagnostic here
test_positional_incompatible("%d %d %d %d %d");
}
void test_many_i(void) {
cvt_i("%1$d %1$i");
cvt_i("%1$d %1$s"); // expected-warning{{format specifier 's' is incompatible with 'i'}}
}
__attribute__((format_matches(printf, 1, "%*d %*d"))) // expected-note{{comparing with this specifier}}
void accept_modifiers(const char *f);
void test_modifiers(void) {
accept_modifiers("%2$*1$d %4$*3$d");
accept_modifiers("%2$*3$d %4$*3$d"); // expected-warning{{format argument modifies specifier at position 2, but it should modify specifier at position 4}}
}
|