1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
|
#include "ClangTidyTest.h"
#include "google/ExplicitConstructorCheck.h"
#include "gtest/gtest.h"
namespace clang {
namespace tidy {
namespace test {
#define EXPECT_NO_CHANGES(Check, Code) \
EXPECT_EQ(Code, runCheckOnCode<Check>(Code))
TEST(ExplicitConstructorCheckTest, SingleArgumentConstructorsOnly) {
EXPECT_NO_CHANGES(ExplicitConstructorCheck, "class C { C(); };");
EXPECT_NO_CHANGES(ExplicitConstructorCheck, "class C { C(int i, int j); };");
EXPECT_NO_CHANGES(ExplicitConstructorCheck, "class C { C(const C&); };");
EXPECT_NO_CHANGES(ExplicitConstructorCheck, "class C { C(C&&); };");
EXPECT_NO_CHANGES(ExplicitConstructorCheck,
"class C { C(const C&) = delete; };");
EXPECT_NO_CHANGES(ExplicitConstructorCheck,
"class C { C(int) = delete; };");
}
TEST(ExplicitConstructorCheckTest, Basic) {
EXPECT_EQ("class C { explicit C(int i); };",
runCheckOnCode<ExplicitConstructorCheck>("class C { C(int i); };"));
}
TEST(ExplicitConstructorCheckTest, DefaultParameters) {
EXPECT_EQ("class C { explicit C(int i, int j = 0); };",
runCheckOnCode<ExplicitConstructorCheck>(
"class C { C(int i, int j = 0); };"));
}
TEST(ExplicitConstructorCheckTest, OutOfLineDefinitions) {
EXPECT_EQ("class C { explicit C(int i); }; C::C(int i) {}",
runCheckOnCode<ExplicitConstructorCheck>(
"class C { C(int i); }; C::C(int i) {}"));
}
TEST(ExplicitConstructorCheckTest, RemoveExplicit) {
EXPECT_EQ("class A { A(const A&); };\n"
"class B { /*asdf*/ B(B&&); };\n"
"class C { /*asdf*/ C(const C&, int i = 0); };",
runCheckOnCode<ExplicitConstructorCheck>(
"class A { explicit A(const A&); };\n"
"class B { explicit /*asdf*/ B(B&&); };\n"
"class C { explicit/*asdf*/ C(const C&, int i = 0); };"));
}
TEST(ExplicitConstructorCheckTest, RemoveExplicitWithMacros) {
EXPECT_EQ(
"#define A(T) class T##Bar { explicit T##Bar(const T##Bar &b) {} };\n"
"A(Foo);",
runCheckOnCode<ExplicitConstructorCheck>(
"#define A(T) class T##Bar { explicit T##Bar(const T##Bar &b) {} };\n"
"A(Foo);"));
}
} // namespace test
} // namespace tidy
} // namespace clang
|
