1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
|
// RUN: %check_clang_tidy %s readability-implicit-bool-cast %t \
// RUN: -config='{CheckOptions: \
// RUN: [{key: readability-implicit-bool-cast.AllowConditionalIntegerCasts, value: 1}, \
// RUN: {key: readability-implicit-bool-cast.AllowConditionalPointerCasts, value: 1}]}' \
// RUN: -- -std=c++11
template<typename T>
void functionTaking(T);
int functionReturningInt();
int* functionReturningPointer();
struct Struct {
int member;
};
void regularImplicitCastIntegerToBoolIsNotIgnored() {
int integer = 0;
functionTaking<bool>(integer);
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit cast 'int' -> bool [readability-implicit-bool-cast]
// CHECK-FIXES: functionTaking<bool>(integer != 0);
}
void implicitCastIntegerToBoolInConditionalsIsAllowed() {
if (functionReturningInt()) {}
if (!functionReturningInt()) {}
int value1 = functionReturningInt() ? 1 : 2;
int value2 = ! functionReturningInt() ? 1 : 2;
}
void regularImplicitCastPointerToBoolIsNotIgnored() {
int* pointer = nullptr;
functionTaking<bool>(pointer);
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit cast 'int *' -> bool
// CHECK-FIXES: functionTaking<bool>(pointer != nullptr);
int Struct::* memberPointer = &Struct::member;
functionTaking<bool>(memberPointer);
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit cast 'int struct Struct::*' -> bool
// CHECK-FIXES: functionTaking<bool>(memberPointer != nullptr);
}
void implicitCastPointerToBoolInConditionalsIsAllowed() {
if (functionReturningPointer()) {}
if (not functionReturningPointer()) {}
int value1 = functionReturningPointer() ? 1 : 2;
int value2 = (not functionReturningPointer()) ? 1 : 2;
int Struct::* memberPointer = &Struct::member;
if (memberPointer) {}
if (memberPointer) {}
int value3 = memberPointer ? 1 : 2;
int value4 = (not memberPointer) ? 1 : 2;
}
|
