File: google-runtime-member-string-references.rst

package info (click to toggle)
llvm-toolchain-6.0 1%3A6.0.1-10
  • links: PTS, VCS
  • area: main
  • in suites: buster
  • size: 598,080 kB
  • sloc: cpp: 3,046,253; ansic: 595,057; asm: 271,965; python: 128,926; objc: 106,554; sh: 21,906; lisp: 10,191; pascal: 6,094; ml: 5,544; perl: 5,265; makefile: 2,227; cs: 2,027; xml: 686; php: 212; csh: 117
file content (25 lines) | stat: -rw-r--r-- 757 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
.. title:: clang-tidy - google-runtime-member-string-references

google-runtime-member-string-references
=======================================

Finds members of type ``const string&``.

const string reference members are generally considered unsafe as they can be
created from a temporary quite easily.

.. code-block:: c++

  struct S {
    S(const string &Str) : Str(Str) {}
    const string &Str;
  };
  S instance("string");

In the constructor call a string temporary is created from ``const char *`` and
destroyed immediately after the call. This leaves around a dangling reference.

This check emit warnings for both ``std::string`` and ``::string`` const
reference members.

Corresponding cpplint.py check name: `runtime/member_string_reference`.