1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
|
// RUN: %check_clang_tidy %s readability-redundant-function-ptr-dereference %t
void f(int i);
void positive() {
void (*p)(int) = f;
(**p)(1);
// CHECK-MESSAGES: :[[@LINE-1]]:4: warning: redundant repeated dereference of function pointer [readability-redundant-function-ptr-dereference]
// CHECK-FIXES: (*p)(1);
(*****p)(2);
// CHECK-MESSAGES: :[[@LINE-1]]:4: warning: redundant repeated
// CHECK-MESSAGES: :[[@LINE-2]]:5: warning: redundant repeated
// CHECK-MESSAGES: :[[@LINE-3]]:6: warning: redundant repeated
// CHECK-MESSAGES: :[[@LINE-4]]:7: warning: redundant repeated
// CHECK-FIXES: (*p)(2);
}
template<typename T>
void invoke(const T& fn) {
fn(0); // 1
(*fn)(0); // 2
// CHECK-MESSAGES: :[[@LINE-1]]:4: warning: redundant repeated
// CHECK-FIXES: fn(0); // 1
// CHECK-FIXES: (fn)(0); // 2
// FIXME: Remove unnecessary parentheses.
}
void f1(int);
void f2(double);
void f3(char);
void instantiate() {
invoke(f1);
invoke(f2);
invoke(f3);
invoke([](unsigned) {});
}
void negative() {
void (*q)(int) = &f;
q(1);
(*q)(2);
}
|
