1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
|
//===--- DurationDivisionCheck.cpp - clang-tidy----------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "DurationDivisionCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
namespace clang {
namespace tidy {
namespace abseil {
using namespace clang::ast_matchers;
void DurationDivisionCheck::registerMatchers(MatchFinder *finder) {
if (!getLangOpts().CPlusPlus)
return;
const auto DurationExpr =
expr(hasType(cxxRecordDecl(hasName("::absl::Duration"))));
finder->addMatcher(
implicitCastExpr(
hasSourceExpression(ignoringParenCasts(
cxxOperatorCallExpr(hasOverloadedOperatorName("/"),
hasArgument(0, DurationExpr),
hasArgument(1, DurationExpr))
.bind("OpCall"))),
hasImplicitDestinationType(qualType(unless(isInteger()))),
unless(hasParent(cxxStaticCastExpr())),
unless(hasParent(cStyleCastExpr())),
unless(isInTemplateInstantiation())),
this);
}
void DurationDivisionCheck::check(const MatchFinder::MatchResult &result) {
const auto *OpCall = result.Nodes.getNodeAs<CXXOperatorCallExpr>("OpCall");
diag(OpCall->getOperatorLoc(),
"operator/ on absl::Duration objects performs integer division; "
"did you mean to use FDivDuration()?")
<< FixItHint::CreateInsertion(OpCall->getBeginLoc(),
"absl::FDivDuration(")
<< FixItHint::CreateReplacement(
SourceRange(OpCall->getOperatorLoc(), OpCall->getOperatorLoc()),
", ")
<< FixItHint::CreateInsertion(
Lexer::getLocForEndOfToken(
result.SourceManager->getSpellingLoc(OpCall->getEndLoc()), 0,
*result.SourceManager, result.Context->getLangOpts()),
")");
}
} // namespace abseil
} // namespace tidy
} // namespace clang
|
