1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
|
//===--- UsingNamespaceDirectiveCheck.cpp - clang-tidy ----------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "UsingNamespaceDirectiveCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/ASTMatchers/ASTMatchers.h"
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace google {
namespace build {
void UsingNamespaceDirectiveCheck::registerMatchers(
ast_matchers::MatchFinder *Finder) {
// Only register the matchers for C++; the functionality currently does not
// provide any benefit to other languages, despite being benign.
if (getLangOpts().CPlusPlus)
Finder->addMatcher(usingDirectiveDecl().bind("usingNamespace"), this);
}
void UsingNamespaceDirectiveCheck::check(
const MatchFinder::MatchResult &Result) {
const auto *U = Result.Nodes.getNodeAs<UsingDirectiveDecl>("usingNamespace");
SourceLocation Loc = U->getBeginLoc();
if (U->isImplicit() || !Loc.isValid())
return;
// Do not warn if namespace is a std namespace with user-defined literals. The
// user-defined literals can only be used with a using directive.
if (isStdLiteralsNamespace(U->getNominatedNamespace()))
return;
diag(Loc, "do not use namespace using-directives; "
"use using-declarations instead");
// TODO: We could suggest a list of using directives replacing the using
// namespace directive.
}
bool UsingNamespaceDirectiveCheck::isStdLiteralsNamespace(
const NamespaceDecl *NS) {
if (!NS->getName().endswith("literals"))
return false;
const auto *Parent = dyn_cast_or_null<NamespaceDecl>(NS->getParent());
if (!Parent)
return false;
if (Parent->isStdNamespace())
return true;
return Parent->getName() == "literals" && Parent->getParent() &&
Parent->getParent()->isStdNamespace();
}
} // namespace build
} // namespace google
} // namespace tidy
} // namespace clang
|
