1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310
|
// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage \
// RUN: -fsafe-buffer-usage-suggestions -verify %s
[[clang::unsafe_buffer_usage]]
void deprecatedFunction3();
void deprecatedFunction4(int z);
void someFunction();
[[clang::unsafe_buffer_usage]]
void overloading(int* x);
void overloading(char c[]);
void overloading(int* x, int size);
[[clang::unsafe_buffer_usage]]
void deprecatedFunction4(int z);
void caller(int z, int* x, int size, char c[]) {
deprecatedFunction3(); // expected-warning{{function introduces unsafe buffer manipulation}}
deprecatedFunction4(z); // expected-warning{{function introduces unsafe buffer manipulation}}
someFunction();
overloading(x); // expected-warning{{function introduces unsafe buffer manipulation}}
overloading(x, size);
overloading(c);
}
[[clang::unsafe_buffer_usage]]
void overloading(char c[]);
// Test variadics
[[clang::unsafe_buffer_usage]]
void testVariadics(int *ptr, ...);
template<typename T, typename... Args>
[[clang::unsafe_buffer_usage]]
T adder(T first, Args... args);
template <typename T>
void foo(T t) {}
template<>
[[clang::unsafe_buffer_usage]]
void foo<int *>(int *t) {}
void caller1(int *p, int *q) {
testVariadics(p, q); // expected-warning{{function introduces unsafe buffer manipulation}}
adder(p, q); // expected-warning{{function introduces unsafe buffer manipulation}}
int x;
foo(x);
foo(&x); // expected-warning{{function introduces unsafe buffer manipulation}}
}
// Test virtual functions
class BaseClass {
public:
[[clang::unsafe_buffer_usage]]
virtual void func() {}
virtual void func1() {}
};
class DerivedClass : public BaseClass {
public:
void func() {}
[[clang::unsafe_buffer_usage]]
void func1() {}
};
void testInheritance() {
DerivedClass DC;
DC.func();
DC.func1(); // expected-warning{{function introduces unsafe buffer manipulation}}
BaseClass *BC;
BC->func(); // expected-warning{{function introduces unsafe buffer manipulation}}
BC->func1();
BC = &DC;
BC->func(); // expected-warning{{function introduces unsafe buffer manipulation}}
BC->func1();
}
class UnsafeMembers {
public:
UnsafeMembers() {}
[[clang::unsafe_buffer_usage]]
UnsafeMembers(int) {}
[[clang::unsafe_buffer_usage]]
explicit operator int() { return 0; }
[[clang::unsafe_buffer_usage]]
void Method() {}
[[clang::unsafe_buffer_usage]]
void operator()() {}
[[clang::unsafe_buffer_usage]]
int operator+(UnsafeMembers) { return 0; }
};
template <class... Vs>
int testFoldExpression(Vs&&... v) {
return (... + v); // expected-warning{{function introduces unsafe buffer manipulation}}
}
struct HoldsUnsafeMembers {
HoldsUnsafeMembers()
: FromCtor(3), // expected-warning{{function introduces unsafe buffer manipulation}}
FromCtor2{3} // expected-warning{{function introduces unsafe buffer manipulation}}
{}
[[clang::unsafe_buffer_usage]]
HoldsUnsafeMembers(int i)
: FromCtor(i),
FromCtor2{i} {}
HoldsUnsafeMembers(float f)
: HoldsUnsafeMembers(0) {} // expected-warning{{function introduces unsafe buffer manipulation}}
UnsafeMembers FromCtor;
UnsafeMembers FromCtor2;
UnsafeMembers FromField{3}; // expected-warning {{function introduces unsafe buffer manipulation}}
};
struct SubclassUnsafeMembers : public UnsafeMembers {
SubclassUnsafeMembers()
: UnsafeMembers(3) // expected-warning{{function introduces unsafe buffer manipulation}}
{}
[[clang::unsafe_buffer_usage]]
SubclassUnsafeMembers(int i)
: UnsafeMembers(i){}
};
// https://github.com/llvm/llvm-project/issues/80482
void testClassMembers() {
UnsafeMembers(3); // expected-warning{{function introduces unsafe buffer manipulation}}
(void)static_cast<int>(UnsafeMembers()); // expected-warning{{function introduces unsafe buffer manipulation}}
UnsafeMembers().Method(); // expected-warning{{function introduces unsafe buffer manipulation}}
UnsafeMembers()(); // expected-warning{{function introduces unsafe buffer manipulation}}
testFoldExpression(UnsafeMembers(), UnsafeMembers());
HoldsUnsafeMembers();
HoldsUnsafeMembers(3); // expected-warning{{function introduces unsafe buffer manipulation}}
SubclassUnsafeMembers();
SubclassUnsafeMembers(3); // expected-warning{{function introduces unsafe buffer manipulation}}
}
// Not an aggregate, so its constructor is not implicit code and will be
// visited/checked for warnings.
struct NotCalledHoldsUnsafeMembers {
NotCalledHoldsUnsafeMembers()
: FromCtor(3), // expected-warning{{function introduces unsafe buffer manipulation}}
FromCtor2{3} // expected-warning{{function introduces unsafe buffer manipulation}}
{}
UnsafeMembers FromCtor;
UnsafeMembers FromCtor2;
UnsafeMembers FromField{3}; // expected-warning{{function introduces unsafe buffer manipulation}}
};
// An aggregate, so its constructor is implicit code. Since it's not called, it
// is never generated.
struct AggregateUnused {
UnsafeMembers f1;
// While this field would trigger the warning during initialization, since
// it's unused, there's no code generated that does the initialization, so
// no warning.
UnsafeMembers f2{3};
};
struct AggregateExplicitlyInitializedSafe {
UnsafeMembers f1;
// The warning is not fired as the field is always explicltly initialized
// elsewhere. This initializer is never used.
UnsafeMembers f2{3};
};
void testAggregateExplicitlyInitializedSafe() {
AggregateExplicitlyInitializedSafe A{
.f2 = UnsafeMembers(), // A safe constructor.
};
}
struct AggregateExplicitlyInitializedUnsafe {
UnsafeMembers f1;
// The warning is not fired as the field is always explicltly initialized
// elsewhere. This initializer is never used.
UnsafeMembers f2{3};
};
void testAggregateExplicitlyInitializedUnsafe() {
AggregateExplicitlyInitializedUnsafe A{
.f2 = UnsafeMembers(3), // expected-warning{{function introduces unsafe buffer manipulation}}
};
}
struct AggregateViaAggregateInit {
UnsafeMembers f1;
// FIXME: A construction of this class does initialize the field through
// this initializer, so it should warn. Ideally it should also point to
// where the site of the construction is in testAggregateViaAggregateInit().
UnsafeMembers f2{3};
};
void testAggregateViaAggregateInit() {
AggregateViaAggregateInit A{};
};
struct AggregateViaValueInit {
UnsafeMembers f1;
// FIXME: A construction of this class does initialize the field through
// this initializer, so it should warn. Ideally it should also point to
// where the site of the construction is in testAggregateViaValueInit().
UnsafeMembers f2{3};
};
void testAggregateViaValueInit() {
auto A = AggregateViaValueInit();
};
struct AggregateViaDefaultInit {
UnsafeMembers f1;
// FIXME: A construction of this class does initialize the field through
// this initializer, so it should warn. Ideally it should also point to
// where the site of the construction is in testAggregateViaValueInit().
UnsafeMembers f2{3};
};
void testAggregateViaDefaultInit() {
AggregateViaDefaultInit A;
};
struct A {
int arr[2];
[[clang::unsafe_buffer_usage]]
int *ptr;
};
namespace std{
template <typename T> class span {
T *elements;
public:
constexpr span(T *, unsigned){}
template<class Begin, class End>
constexpr span(Begin first, End last){}
constexpr T* data() const noexcept {
return elements;
}
};
}
[[clang::unsafe_buffer_usage]]
void check_no_warnings(unsigned idx) {
int *arr = new int[20];
int k = arr[idx]; // no-warning
std::span<int> sp = {arr, 20}; // no-warning
A *ptr = reinterpret_cast<A*> (sp.data()); // no-warning
A a;
a.ptr = arr; // no-warning
}
[[clang::unsafe_buffer_usage]]
void check_no_warning_variadic(unsigned idx, int arr[20], ...) {
int k = arr[idx]; // no-warning
std::span<int> sp = {arr, 20}; // no-warning
A *ptr = reinterpret_cast<A*> (sp.data()); // no-warning
A a;
a.ptr = arr; // no-warning
}
template<typename T>
[[clang::unsafe_buffer_usage]]
void check_no_warnings_template(unsigned idx, T* arr) {
int k = arr[idx]; // no-warning
std::span<int> sp = {arr, 20}; // no-warning
A *ptr = reinterpret_cast<A*> (sp.data()); // no-warning
A a;
a.ptr = arr; // no-warning
}
void invoke_methods() {
int array[20];
check_no_warnings(30); //expected-warning{{function introduces unsafe buffer manipulation}}
check_no_warning_variadic(15, array); //expected-warning{{function introduces unsafe buffer manipulation}}
check_no_warnings_template(10, array); //expected-warning{{function introduces unsafe buffer manipulation}}
}
|