1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
|
// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s
#include "mock-types.h"
namespace std {
}
namespace call_args_const_refptr_member {
class Foo {
public:
Foo();
void bar();
private:
const RefPtr<RefCountable> m_obj1;
RefPtr<RefCountable> m_obj2;
};
void Foo::bar() {
m_obj1->method();
m_obj2->method();
// expected-warning@-1{{Call argument for 'this' parameter is uncounted and unsafe}}
}
} // namespace call_args_const_refptr_member
namespace call_args_const_ref_member {
class Foo {
public:
Foo();
void bar();
RefCountable& obj1() const { return m_obj1; }
private:
const Ref<RefCountable> m_obj1;
Ref<RefCountable> m_obj2;
};
void Foo::bar() {
m_obj1->method();
m_obj2->method();
// expected-warning@-1{{Call argument for 'this' parameter is uncounted and unsafe}}
obj1().method();
}
} // namespace call_args_const_ref_member
namespace call_args_const_unique_ptr {
class Foo {
public:
Foo();
void bar();
RefCountable& ensureObj3() {
if (!m_obj3)
const_cast<std::unique_ptr<RefCountable>&>(m_obj3) = RefCountable::makeUnique();
return *m_obj3;
}
RefCountable& badEnsureObj4() {
if (!m_obj4)
const_cast<std::unique_ptr<RefCountable>&>(m_obj4) = RefCountable::makeUnique();
if (auto* next = m_obj4->next())
return *next;
return *m_obj4;
}
RefCountable* ensureObj5() {
if (!m_obj5)
const_cast<std::unique_ptr<RefCountable>&>(m_obj5) = RefCountable::makeUnique();
if (m_obj5->next())
return nullptr;
return m_obj5.get();
}
private:
const std::unique_ptr<RefCountable> m_obj1;
std::unique_ptr<RefCountable> m_obj2;
const std::unique_ptr<RefCountable> m_obj3;
const std::unique_ptr<RefCountable> m_obj4;
const std::unique_ptr<RefCountable> m_obj5;
};
void Foo::bar() {
m_obj1->method();
m_obj2->method();
// expected-warning@-1{{Call argument for 'this' parameter is uncounted and unsafe}}
ensureObj3().method();
badEnsureObj4().method();
// expected-warning@-1{{Call argument for 'this' parameter is uncounted and unsafe}}
ensureObj5()->method();
}
} // namespace call_args_const_unique_ptr
namespace call_args_const_unique_ref {
class Foo {
public:
Foo();
void bar();
RefCountable& obj1() { return m_obj1; }
private:
const UniqueRef<RefCountable> m_obj1;
UniqueRef<RefCountable> m_obj2;
};
void Foo::bar() {
m_obj1->method();
m_obj2->method();
// expected-warning@-1{{Call argument for 'this' parameter is uncounted and unsafe}}
obj1().method();
}
} // namespace call_args_const_unique_ref
|
