1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668
|
// UNSUPPORTED: target={{.*}}-zos{{.*}}, target={{.*}}-aix{{.*}}
// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UnretainedCallArgsChecker -verify %s
#include "objc-mock-types.h"
SomeObj *provide();
void consume_obj(SomeObj*);
CFMutableArrayRef provide_cf();
void consume_cf(CFMutableArrayRef);
dispatch_queue_t provide_dispatch();
void consume_dispatch(dispatch_queue_t);
CGImageRef provideImage();
NSString *stringForImage(CGImageRef);
void some_function();
namespace simple {
void foo() {
consume_obj(provide());
// expected-warning@-1{{Call argument is unretained and unsafe}}
consume_cf(provide_cf());
// expected-warning@-1{{Call argument is unretained and unsafe}}
consume_dispatch(provide_dispatch());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
// Test that the checker works with [[clang::suppress]].
void foo_suppressed() {
[[clang::suppress]] consume_obj(provide()); // no-warning
[[clang::suppress]] consume_cf(provide_cf()); // no-warning
}
}
namespace multi_arg {
void consume_retainable(int, SomeObj* foo, CFMutableArrayRef bar, dispatch_queue_t baz, bool);
void foo() {
consume_retainable(42, provide(), provide_cf(), provide_dispatch(), true);
// expected-warning@-1{{Call argument for parameter 'foo' is unretained and unsafe}}
// expected-warning@-2{{Call argument for parameter 'bar' is unretained and unsafe}}
// expected-warning@-3{{Call argument for parameter 'baz' is unretained and unsafe}}
}
void consume_retainable(SomeObj* foo, ...);
void bar() {
consume_retainable(provide(), 1, provide_cf(), RetainPtr<CFMutableArrayRef> { provide_cf() }.get(), provide_dispatch());
// expected-warning@-1{{Call argument for parameter 'foo' is unretained and unsafe}}
// expected-warning@-2{{Call argument is unretained and unsafe}}
// expected-warning@-3{{Call argument is unretained and unsafe}}
consume_retainable(RetainPtr<SomeObj> { provide() }.get(), 1, RetainPtr<CFMutableArrayRef> { provide_cf() }.get());
}
}
namespace retained {
RetainPtr<SomeObj> provide_obj();
RetainPtr<CFMutableArrayRef> provide_cf();
OSObjectPtr<dispatch_queue_t> provide_dispatch();
void foo() {
consume_obj(provide_obj().get()); // no warning
consume_cf(provide_cf().get()); // no warning
consume_dispatch(provide_dispatch().get()); // no warning
}
}
namespace methods {
struct Consumer {
void consume_obj(SomeObj* ptr);
void consume_cf(CFMutableArrayRef ref);
void consume_dispatch(dispatch_queue_t ptr);
};
void foo() {
Consumer c;
c.consume_obj(provide());
// expected-warning@-1{{Call argument for parameter 'ptr' is unretained and unsafe}}
c.consume_cf(provide_cf());
// expected-warning@-1{{Call argument for parameter 'ref' is unretained and unsafe}}
c.consume_dispatch(provide_dispatch());
// expected-warning@-1{{Call argument for parameter 'ptr' is unretained and unsafe}}
}
void foo2() {
struct Consumer {
void consume(SomeObj*) { some_function(); }
void whatever() {
consume(provide());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
void consume_cf(CFMutableArrayRef) { some_function(); }
void something() {
consume_cf(provide_cf());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
void consume_dispatch(dispatch_queue_t) { some_function(); }
void anything() {
consume_dispatch(provide_dispatch());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
};
}
void foo3() {
struct Consumer {
void consume(SomeObj*) { some_function(); }
void whatever() {
this->consume(provide());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
void consume_cf(CFMutableArrayRef) { some_function(); }
void something() {
this->consume_cf(provide_cf());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
void consume_dispatch(dispatch_queue_t) { some_function(); }
void anything() {
this->consume_dispatch(provide_dispatch());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
};
}
}
namespace casts {
void foo() {
consume_obj(provide());
// expected-warning@-1{{Call argument is unretained and unsafe}}
consume_obj(static_cast<OtherObj*>(provide()));
// expected-warning@-1{{Call argument is unretained and unsafe}}
consume_obj(reinterpret_cast<OtherObj*>(provide()));
// expected-warning@-1{{Call argument is unretained and unsafe}}
consume_obj(downcast<OtherObj>(provide()));
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
}
namespace null_ptr {
void foo_ref() {
consume_obj(nullptr);
consume_obj(0);
consume_cf(nullptr);
consume_cf(0);
consume_dispatch(nullptr);
consume_dispatch(0);
}
}
namespace retain_ptr_lookalike {
struct Decoy {
SomeObj* get();
};
void foo() {
Decoy D;
consume_obj(D.get());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
struct Decoy2 {
CFMutableArrayRef get();
};
void bar() {
Decoy2 D;
consume_cf(D.get());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
}
namespace param_formarding_function {
void consume_more_obj(OtherObj*);
void consume_more_cf(CFMutableArrayRef);
void consume_more_dispatch(dispatch_queue_t);
namespace objc {
void foo(SomeObj* param) {
consume_more_obj(downcast<OtherObj>(param));
}
}
namespace cf {
void foo(CFMutableArrayRef param) {
consume_more_cf(param);
}
}
}
namespace param_formarding_lambda {
auto consume_more_obj = [](OtherObj*) { some_function(); };
auto consume_more_cf = [](CFMutableArrayRef) { some_function(); };
auto consume_more_dispatch = [](dispatch_queue_t) { some_function(); };
namespace objc {
void foo(SomeObj* param) {
consume_more_obj(downcast<OtherObj>(param));
}
}
namespace cf {
void foo(CFMutableArrayRef param) {
consume_more_cf(param);
}
}
namespace os_obj {
void foo(dispatch_queue_t param) {
consume_more_dispatch(param);
}
}
}
namespace param_forwarding_method {
struct Consumer {
void consume_obj(SomeObj*);
static void consume_obj_s(SomeObj*);
void consume_cf(CFMutableArrayRef);
static void consume_cf_s(CFMutableArrayRef);
void consume_dispatch(dispatch_queue_t);
static void consume_dispatch_s(dispatch_queue_t);
};
void bar(Consumer* consumer, SomeObj* param) {
consumer->consume_obj(param);
}
void foo(SomeObj* param) {
Consumer::consume_obj_s(param);
}
void baz(Consumer* consumer, CFMutableArrayRef param) {
consumer->consume_cf(param);
Consumer::consume_cf_s(param);
}
void baz(Consumer* consumer, dispatch_queue_t param) {
consumer->consume_dispatch(param);
Consumer::consume_dispatch_s(param);
}
}
namespace default_arg {
SomeObj* global;
CFMutableArrayRef global_cf;
dispatch_queue_t global_dispatch;
void function_with_default_arg1(SomeObj* param = global);
// expected-warning@-1{{Call argument for parameter 'param' is unretained and unsafe}}
void function_with_default_arg2(CFMutableArrayRef param = global_cf);
// expected-warning@-1{{Call argument for parameter 'param' is unretained and unsafe}}
void function_with_default_arg3(dispatch_queue_t param = global_dispatch);
// expected-warning@-1{{Call argument for parameter 'param' is unretained and unsafe}}
void foo() {
function_with_default_arg1();
function_with_default_arg2();
function_with_default_arg3();
}
}
namespace cxx_member_func {
RetainPtr<SomeObj> protectedProvide();
RetainPtr<CFMutableArrayRef> protectedProvideCF();
void foo() {
[provide() doWork];
// expected-warning@-1{{Receiver is unretained and unsafe}}
[protectedProvide().get() doWork];
CFArrayAppendValue(provide_cf(), nullptr);
// expected-warning@-1{{Call argument for parameter 'theArray' is unretained and unsafe}}
CFArrayAppendValue(protectedProvideCF(), nullptr);
};
void bar() {
[downcast<OtherObj>(protectedProvide().get()) doMoreWork:downcast<OtherObj>(provide())];
// expected-warning@-1{{Call argument for parameter 'other' is unretained and unsafe}}
[protectedProvide().get() doWork];
};
}
namespace cxx_member_operator_call {
// The hidden this-pointer argument without a corresponding parameter caused couple bugs in parameter <-> argument attribution.
struct Foo {
Foo& operator+(SomeObj* bad);
friend Foo& operator-(Foo& lhs, SomeObj* bad);
void operator()(SomeObj* bad);
Foo& operator<<(dispatch_queue_t bad);
};
SomeObj* global;
dispatch_queue_t global_dispatch;
void foo() {
Foo f;
f + global;
// expected-warning@-1{{Call argument for parameter 'bad' is unretained and unsafe}}
f - global;
// expected-warning@-1{{Call argument for parameter 'bad' is unretained and unsafe}}
f(global);
// expected-warning@-1{{Call argument for parameter 'bad' is unretained and unsafe}}
f << global_dispatch;
// expected-warning@-1{{Call argument for parameter 'bad' is unretained and unsafe}}
}
}
namespace cxx_assignment_op {
SomeObj* provide();
void foo() {
RetainPtr<SomeObj> ptr;
ptr = provide();
OSObjectPtr<dispatch_queue_t> objPtr;
objPtr = provide_dispatch();
}
}
namespace call_with_ptr_on_ref {
RetainPtr<SomeObj> provideProtected();
RetainPtr<CFMutableArrayRef> provideProtectedCF();
OSObjectPtr<dispatch_queue_t> provideProtectedDispatch();
void bar(SomeObj* bad);
void bar_cf(CFMutableArrayRef bad);
void bar_dispatch(dispatch_queue_t);
bool baz();
void foo(bool v) {
bar(v ? nullptr : provideProtected().get());
bar(baz() ? provideProtected().get() : nullptr);
bar(v ? provide() : provideProtected().get());
// expected-warning@-1{{Call argument for parameter 'bad' is unretained and unsafe}}
bar(v ? provideProtected().get() : provide());
// expected-warning@-1{{Call argument for parameter 'bad' is unretained and unsafe}}
bar_cf(v ? nullptr : provideProtectedCF().get());
bar_cf(baz() ? provideProtectedCF().get() : nullptr);
bar_cf(v ? provide_cf() : provideProtectedCF().get());
// expected-warning@-1{{Call argument for parameter 'bad' is unretained and unsafe}}
bar_cf(v ? provideProtectedCF().get() : provide_cf());
// expected-warning@-1{{Call argument for parameter 'bad' is unretained and unsafe}}
bar_dispatch(v ? nullptr : provideProtectedDispatch().get());
bar_dispatch(baz() ? provideProtectedDispatch().get() : nullptr);
bar_dispatch(v ? provide_dispatch() : provideProtectedDispatch().get());
// expected-warning@-1{{Call argument is unretained and unsafe}}
bar_dispatch(v ? provideProtectedDispatch().get() : provide_dispatch());
// expected-warning@-1{{Call argument is unretained and unsafe}}
}
}
namespace call_with_explicit_temporary_obj {
void foo() {
[RetainPtr<SomeObj>(provide()).get() doWork];
CFArrayAppendValue(RetainPtr<CFMutableArrayRef> { provide_cf() }.get(), nullptr);
}
template <typename T>
void bar() {
[RetainPtr<SomeObj>(provide()).get() doWork];
CFArrayAppendValue(RetainPtr<CFMutableArrayRef> { provide_cf() }.get(), nullptr);
}
void baz() {
bar<int>();
}
void os_ptr() {
consume_dispatch(OSObjectPtr { provide_dispatch() }.get());
}
}
namespace call_with_adopt_ref {
void foo() {
[adoptNS(provide()).get() doWork];
CFArrayAppendValue(adoptCF(provide_cf()).get(), nullptr);
consume_dispatch(adoptOSObject(provide_dispatch()).get());
}
}
#define YES __objc_yes
#define NO 0
namespace call_with_cf_constant {
void bar(const NSArray *);
void baz(const NSDictionary *);
void boo(NSNumber *);
void boo(CFTypeRef);
struct Details {
int value;
};
void foo(Details* details) {
CFArrayCreateMutable(kCFAllocatorDefault, 10);
bar(@[@"hello"]);
baz(@{@"hello": @3});
boo(@YES);
boo(@NO);
boo(@(details->value));
}
}
namespace call_with_cf_string {
void bar(CFStringRef);
void foo() {
bar(CFSTR("hello"));
}
}
namespace call_with_ns_string {
void bar(NSString *);
void foo() {
bar(@"world");
}
}
namespace bridge_cast_arg {
void bar(NSString *);
void baz(NSString *);
extern const CFStringRef kCFBundleNameKey;
NSObject *foo(CFStringRef arg) {
bar((NSString *)bridge_cast((CFTypeRef)arg));
auto dict = @{
@"hello": @1,
};
return dict[(__bridge NSString *)kCFBundleNameKey];
}
}
namespace alloc_init_pair {
void foo() {
auto obj = adoptNS([[SomeObj alloc] init]);
[obj doWork];
}
}
namespace alloc_class {
bool foo(NSObject *obj) {
return [obj isKindOfClass:SomeObj.class] && [obj isKindOfClass:NSClassFromString(@"SomeObj")];
}
bool bar(NSObject *obj) {
return [obj isKindOfClass:[SomeObj class]];
}
bool baz(NSObject *obj) {
return [obj isKindOfClass:[SomeObj superclass]];
}
}
namespace ptr_conversion {
SomeObj *provide_obj();
void dobjc(SomeObj* obj) {
[dynamic_objc_cast<OtherObj>(obj) doMoreWork:nil];
}
void cobjc(SomeObj* obj) {
[checked_objc_cast<OtherObj>(obj) doMoreWork:nil];
}
unsigned dcf(CFTypeRef obj) {
return CFArrayGetCount(dynamic_cf_cast<CFArrayRef>(obj));
}
unsigned ccf(CFTypeRef obj) {
return CFArrayGetCount(checked_cf_cast<CFArrayRef>(obj));
}
void some_function(id);
void idcf(CFTypeRef obj) {
some_function(bridge_id_cast(obj));
}
} // ptr_conversion
namespace const_global {
extern NSString * const SomeConstant;
extern CFDictionaryRef const SomeDictionary;
extern dispatch_queue_t const SomeDispatch;
void doWork(NSString *str, CFDictionaryRef dict, dispatch_queue_t dispatch);
void use_const_global() {
doWork(SomeConstant, SomeDictionary, SomeDispatch);
}
NSString *provide_str();
CFDictionaryRef provide_dict();
void use_const_local() {
doWork(provide_str(), provide_dict(), provide_dispatch());
// expected-warning@-1{{Call argument for parameter 'str' is unretained and unsafe}}
// expected-warning@-2{{Call argument for parameter 'dict' is unretained and unsafe}}
// expected-warning@-3{{Call argument for parameter 'dispatch' is unretained and unsafe}}
}
} // namespace const_global
namespace var_decl_ref_singleton {
static Class initSomeObject() { return nil; }
static Class (*getSomeObjectClassSingleton)() = initSomeObject;
bool foo(NSString *obj) {
return [obj isKindOfClass:getSomeObjectClassSingleton()];
}
class Bar {
public:
Class someObject();
static Class staticSomeObject();
};
typedef Class (Bar::*SomeObjectSingleton)();
bool bar(NSObject *obj, Bar *bar, SomeObjectSingleton someObjSingleton) {
return [obj isKindOfClass:(bar->*someObjSingleton)()];
// expected-warning@-1{{Call argument for parameter 'aClass' is unretained and unsafe}}
}
bool baz(NSObject *obj) {
Class (*someObjectSingleton)() = Bar::staticSomeObject;
return [obj isKindOfClass:someObjectSingleton()];
}
} // namespace var_decl_ref_singleton
namespace ns_retained_return_value {
NSString *provideNS() NS_RETURNS_RETAINED;
CFDictionaryRef provideCF() CF_RETURNS_RETAINED;
dispatch_queue_t provideDispatch() NS_RETURNS_RETAINED;
void consumeNS(NSString *);
void consumeCF(CFDictionaryRef);
void consumeDispatch(dispatch_queue_t);
void foo() {
consumeNS(provideNS());
consumeCF(provideCF());
consumeDispatch(provideDispatch());
}
struct Base {
NSString *provideStr() NS_RETURNS_RETAINED;
};
struct Derived : Base {
void consumeStr(NSString *);
void foo() {
consumeStr(provideStr());
}
};
} // namespace ns_retained_return_value
namespace autoreleased {
NSString *provideAutoreleased() __attribute__((ns_returns_autoreleased));
void consume(NSString *);
void foo() {
consume(provideAutoreleased());
}
} // autoreleased
namespace sel_string {
void consumeStr(NSString *);
void consumeSel(SEL);
void consumeClass(Class);
void consumeProtocol(Protocol *);
void foo() {
consumeStr(NSStringFromSelector(@selector(mutableCopy)));
consumeSel(NSSelectorFromString(@"mutableCopy"));
consumeStr(NSStringFromClass(NSNumber.class));
consumeClass(NSClassFromString(@"NSNumber"));
consumeStr(NSStringFromProtocol(@protocol(NSCopying)));
consumeProtocol(NSProtocolFromString(@"NSCopying"));
}
} // namespace sel_string
namespace template_function {
class Base {
public:
virtual ~Base() = default;
void send(dispatch_queue_t) const;
void ref() const;
void deref() const;
};
template<typename Traits>
class Derived : public Base {
public:
virtual ~Derived() = default;
void send(typename Traits::MessageType) const;
virtual OSObjectPtr<dispatch_queue_t> msg(typename Traits::MessageType) const = 0;
};
template<typename Traits>
void Derived<Traits>::send(typename Traits::MessageType messageType) const
{
OSObjectPtr dictionary = msg(messageType);
Base::send(dictionary.get());
}
} // namespace template_function
@interface TestObject : NSObject
- (void)doWork:(NSString *)msg, ...;
- (void)doWorkOnSelf;
- (SomeObj *)getSomeObj;
@end
@implementation TestObject
- (void)doWork:(NSString *)msg, ... {
some_function();
}
- (void)doWorkOnSelf {
[self doWork:nil];
[self doWork:@"hello", provide(), provide_cf(), provide_dispatch()];
// expected-warning@-1{{Call argument is unretained and unsafe}}
// expected-warning@-2{{Call argument is unretained and unsafe}}
// expected-warning@-3{{Call argument is unretained and unsafe}}
[self doWork:@"hello", RetainPtr<SomeObj> { provide() }.get(), RetainPtr<CFMutableArrayRef> { provide_cf() }.get(), OSObjectPtr { provide_dispatch() }.get()];
[self doWork:__null];
[self doWork:nil];
[NSApp run];
}
- (SomeObj *)getSomeObj {
return RetainPtr<SomeObj *>(provide()).autorelease();
}
- (void)doWorkOnSomeObj {
[[self getSomeObj] doWork];
}
- (CGImageRef)createImage {
return provideImage();
}
- (NSString *)convertImage {
RetainPtr<CGImageRef> image = [self createImage];
return stringForImage(image.get());
}
@end
|