1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302
|
Won't get to upstream
--- a/src/core/init.c
+++ b/src/core/init.c
@@ -175,6 +175,9 @@
#if ((LWIP_SOCKET || LWIP_NETCONN) && (NO_SYS==1))
#error "If you want to use Sequential API, you have to define NO_SYS=0 in your lwipopts.h"
#endif
+#if (LWIP_SOCKET_OPEN_COUNT && LWIP_SOCKET_SELECT)
+#error "If you want to use LWIP_SOCKET_OPEN_COUNT, you must define LWIP_SOCKET_SELECT=0 in your lwipopts.h"
+#endif
#if (LWIP_PPP_API && (NO_SYS==1))
#error "If you want to use PPP API, you have to define NO_SYS=0 in your lwipopts.h"
#endif
--- a/src/include/lwip/opt.h
+++ b/src/include/lwip/opt.h
@@ -1989,6 +1989,15 @@
#endif
/**
+ * LWIP_SOCKET_OPEN_COUNT==1: Number of sockets is not limited to MEMP_NUM_NETCONN.
+ * When enabled, sockets are allocated in the heap and the amount of sockets is
+ * only limited by the heap size. Handle with care regarding execution speed.
+ */
+#if !defined LWIP_SOCKET_OPEN_COUNT || defined __DOXYGEN__
+#define LWIP_SOCKET_OPEN_COUNT 0
+#endif
+
+/**
* LWIP_TCP_KEEPALIVE==1: Enable TCP_KEEPIDLE, TCP_KEEPINTVL and TCP_KEEPCNT
* options processing. Note that TCP_KEEPIDLE and TCP_KEEPINTVL have to be set
* in seconds. (does not require sockets.c, and will affect tcp.c)
--- a/src/api/sockets.c
+++ b/src/api/sockets.c
@@ -256,8 +256,13 @@
static void lwip_socket_drop_registered_mld6_memberships(int s);
#endif /* LWIP_IPV6_MLD */
+#if LWIP_SOCKET_OPEN_COUNT
+/** The global linked list of available sockets */
+static struct lwip_sock *sockets = NULL;
+#else /* LWIP_SOCKET_OPEN_COUNT */
/** The global array of available sockets */
static struct lwip_sock sockets[NUM_SOCKETS];
+#endif /* LWIP_SOCKET_OPEN_COUNT */
#if LWIP_SOCKET_SELECT || LWIP_SOCKET_POLL
#if LWIP_TCPIP_CORE_LOCKING
@@ -406,16 +411,47 @@
#define done_socket(sock)
#endif /* LWIP_NETCONN_FULLDUPLEX */
+/* Translate a socket 'int' into a pointer (doesn't check the validity of the index) */
+static struct lwip_sock *
+translate_socket(int s)
+{
+#if LWIP_SOCKET_OPEN_COUNT
+ struct lwip_sock *sock;
+
+ /*
+ * We need to protect the integrity of the list itself,
+ * since elements may be dynamically inserted or deleted.
+ */
+ SYS_ARCH_DECL_PROTECT(lev);
+ SYS_ARCH_PROTECT(lev);
+ for(sock = sockets; sock != NULL; sock = sock->next) {
+ if(sock->count == s) {
+ break;
+ }
+ }
+ SYS_ARCH_UNPROTECT(lev);
+ return sock;
+#else /* LWIP_SOCKET_OPEN_COUNT */
+ return &sockets[s];
+#endif /* LWIP_SOCKET_OPEN_COUNT */
+}
+
/* Translate a socket 'int' into a pointer (only fails if the index is invalid) */
static struct lwip_sock *
tryget_socket_unconn_nouse(int fd)
{
int s = fd - LWIP_SOCKET_OFFSET;
- if ((s < 0) || (s >= NUM_SOCKETS)) {
+
+ if ((s < 0)
+#if !LWIP_SOCKET_OPEN_COUNT
+ || (s >= NUM_SOCKETS)
+#endif /* !LWIP_SOCKET_OPEN_COUNT */
+ ) {
LWIP_DEBUGF(SOCKETS_DEBUG, ("tryget_socket_unconn(%d): invalid\n", fd));
return NULL;
}
- return &sockets[s];
+
+ return translate_socket(s);
}
struct lwip_sock *
@@ -480,8 +516,11 @@
{
struct lwip_sock *sock = tryget_socket(fd);
if (!sock) {
- if ((fd < LWIP_SOCKET_OFFSET) || (fd >= (LWIP_SOCKET_OFFSET + NUM_SOCKETS))) {
- LWIP_DEBUGF(SOCKETS_DEBUG, ("get_socket(%d): invalid\n", fd));
+ if ((fd < LWIP_SOCKET_OFFSET)
+#if !LWIP_SOCKET_OPEN_COUNT
+ || (fd >= (LWIP_SOCKET_OFFSET + NUM_SOCKETS))
+#endif /* !LWIP_SOCKET_OPEN_COUNT */
+ ) { LWIP_DEBUGF(SOCKETS_DEBUG, ("get_socket(%d): invalid\n", fd));
}
set_errno(EBADF);
return NULL;
@@ -501,40 +540,87 @@
alloc_socket(struct netconn *newconn, int accepted)
{
int i;
+ struct lwip_sock *newsock = NULL;
+#if LWIP_SOCKET_OPEN_COUNT
+ struct lwip_sock **it;
+#endif /* LWIP_SOCKET_OPEN_COUNT */
+
SYS_ARCH_DECL_PROTECT(lev);
LWIP_UNUSED_ARG(accepted);
+#if LWIP_SOCKET_OPEN_COUNT
+ newsock = (struct lwip_sock*)mem_calloc(1, sizeof(struct lwip_sock));
+ if(!newsock) {
+ /* No free memory */
+ return -1;
+ }
+
+ it = &sockets;
+ i = 0;
+ /* Protect socket list */
+ SYS_ARCH_PROTECT(lev);
+ while(*it) {
+ if((*it)->count != i) {
+ /* There's a gap in the list, fill it */
+ break;
+ }
+ i++;
+ it = &(*it)->next;
+ }
+ /* Add the new socket in the first gap found or in the end */
+ newsock->count = i;
+ newsock->next = (*it);
+ (*it) = newsock;
+ newsock->conn = newconn;
+#else /* LWIP_SOCKET_OPEN_COUNT */
/* allocate a new socket identifier */
for (i = 0; i < NUM_SOCKETS; ++i) {
/* Protect socket array */
SYS_ARCH_PROTECT(lev);
- if (!sockets[i].conn) {
+ newsock = &sockets[i];
+ if (!newsock->conn) {
#if LWIP_NETCONN_FULLDUPLEX
- if (sockets[i].fd_used) {
+ if (newsock->fd_used) {
SYS_ARCH_UNPROTECT(lev);
continue;
}
- sockets[i].fd_used = 1;
- sockets[i].fd_free_pending = 0;
-#endif
- sockets[i].conn = newconn;
- /* The socket is not yet known to anyone, so no need to protect
- after having marked it as used. */
- SYS_ARCH_UNPROTECT(lev);
- sockets[i].lastdata.pbuf = NULL;
-#if LWIP_SOCKET_SELECT || LWIP_SOCKET_POLL
- LWIP_ASSERT("sockets[i].select_waiting == 0", sockets[i].select_waiting == 0);
- sockets[i].rcvevent = 0;
- /* TCP sendbuf is empty, but the socket is not yet writable until connected
- * (unless it has been created by accept()). */
- sockets[i].sendevent = (NETCONNTYPE_GROUP(newconn->type) == NETCONN_TCP ? (accepted != 0) : 1);
- sockets[i].errevent = 0;
-#endif /* LWIP_SOCKET_SELECT || LWIP_SOCKET_POLL */
- return i + LWIP_SOCKET_OFFSET;
+#endif /* LWIP_NETCONN_FULLDUPLEX */
+ newsock->conn = newconn;
+ break;
}
SYS_ARCH_UNPROTECT(lev);
}
- return -1;
+
+ if(!newsock->conn) {
+ /* No free sockets available */
+ SYS_ARCH_UNPROTECT(lev);
+ return -1;
+ }
+#endif /* LWIP_SOCKET_OPEN_COUNT */
+
+#if LWIP_NETCONN_FULLDUPLEX
+ newsock->fd_used = 1;
+ newsock->fd_free_pending = 0;
+#endif /* LWIP_NETCONN_FULLDUPLEX */
+
+ /* The socket is not yet known to anyone, so no need to protect
+ after having marked it as used. */
+ SYS_ARCH_UNPROTECT(lev);
+ newsock->lastdata.pbuf = NULL;
+#if LWIP_SOCKET_SELECT || LWIP_SOCKET_POLL
+ LWIP_ASSERT("newsock->select_waiting == 0", newsock->select_waiting == 0);
+ newsock->rcvevent = 0;
+ /* TCP sendbuf is empty, but the socket is not yet writable until connected
+ * (unless it has been created by accept()). */
+ newsock->sendevent = (NETCONNTYPE_GROUP(newconn->type) == NETCONN_TCP ? (accepted != 0) : 1);
+ newsock->errevent = 0;
+#endif /* LWIP_SOCKET_SELECT || LWIP_SOCKET_POLL */
+
+#if LWIP_SOCKET_OPEN_COUNT
+ return newsock->count + LWIP_SOCKET_OFFSET;
+#else /* LWIP_SOCKET_OPEN_COUNT */
+ return i + LWIP_SOCKET_OFFSET;
+#endif /* LWIP_SOCKET_OPEN_COUNT */
}
/** Free a socket (under lock)
@@ -548,6 +634,10 @@
free_socket_locked(struct lwip_sock *sock, int is_tcp, struct netconn **conn,
union lwip_sock_lastdata *lastdata)
{
+#if LWIP_SOCKET_OPEN_COUNT
+ struct lwip_sock **it = &sockets;
+#endif /* LWIP_SOCKET_OPEN_COUNT */
+
#if LWIP_NETCONN_FULLDUPLEX
LWIP_ASSERT("sock->fd_used > 0", sock->fd_used > 0);
sock->fd_used--;
@@ -560,9 +650,18 @@
#endif /* LWIP_NETCONN_FULLDUPLEX */
*lastdata = sock->lastdata;
- sock->lastdata.pbuf = NULL;
*conn = sock->conn;
sock->conn = NULL;
+
+#if LWIP_SOCKET_OPEN_COUNT
+ while(*it != sock) it = &(*it)->next;
+ *it = (*it)->next;
+ mem_free(sock);
+#else /* LWIP_SOCKET_OPEN_COUNT */
+ sock->lastdata.pbuf = NULL;
+ sock->conn = NULL;
+#endif /* LWIP_SOCKET_OPEN_COUNT */
+
return 1;
}
@@ -657,9 +756,14 @@
done_socket(sock);
return -1;
}
+
+#if !LWIP_SOCKET_OPEN_COUNT
LWIP_ASSERT("invalid socket index", (newsock >= LWIP_SOCKET_OFFSET) && (newsock < NUM_SOCKETS + LWIP_SOCKET_OFFSET));
- nsock = &sockets[newsock - LWIP_SOCKET_OFFSET];
+#else /* !LWIP_SOCKET_OPEN_COUNT */
+ LWIP_ASSERT("invalid socket index", (newsock >= LWIP_SOCKET_OFFSET));
+#endif /* !LWIP_SOCKET_OPEN_COUNT */
+ nsock = translate_socket(newsock - LWIP_SOCKET_OFFSET);
/* See event_callback: If data comes in right away after an accept, even
* though the server task might not have created a new socket yet.
* In that case, newconn->socket is counted down (newconn->socket--),
@@ -1735,7 +1839,7 @@
return -1;
}
conn->socket = i;
- done_socket(&sockets[i - LWIP_SOCKET_OFFSET]);
+ done_socket(translate_socket(i - LWIP_SOCKET_OFFSET));
LWIP_DEBUGF(SOCKETS_DEBUG, ("%d\n", i));
set_errno(0);
return i;
--- a/src/include/lwip/priv/sockets_priv.h
+++ b/src/include/lwip/priv/sockets_priv.h
@@ -65,6 +65,12 @@
/** Contains all internal pointers and states used for a socket */
struct lwip_sock {
+#if LWIP_SOCKET_OPEN_COUNT
+ /** Next element in the linked list */
+ struct lwip_sock *next;
+ /** Socket number*/
+ int count;
+#endif /* LWIP_SOCKET_OPEN_COUNT */
/** sockets currently are built on netconns, each socket has one netconn */
struct netconn *conn;
/** data that was left from the previous read */
--- a/port/include/lwipopts.h
+++ b/port/include/lwipopts.h
@@ -27,6 +27,8 @@
#define LWIP_COMPAT_SOCKETS 0
#define LWIP_SOCKET_OFFSET 1
#define LWIP_POLL 1
+#define LWIP_SOCKET_OPEN_COUNT 1
+#define LWIP_SOCKET_SELECT 0
/* User posix socket headers */
#define LWIP_SOCKET_EXTERNAL_HEADERS 1
|