1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112 6113 6114 6115 6116 6117 6118 6119 6120 6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152 6153 6154 6155 6156 6157 6158 6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179 6180 6181 6182 6183 6184 6185 6186 6187 6188 6189 6190 6191 6192 6193 6194 6195 6196 6197 6198 6199 6200 6201 6202 6203 6204 6205 6206 6207 6208 6209 6210 6211 6212 6213 6214 6215 6216 6217 6218 6219 6220 6221 6222 6223 6224 6225 6226 6227 6228 6229 6230 6231 6232 6233 6234 6235 6236 6237 6238 6239 6240 6241 6242 6243 6244 6245 6246 6247 6248 6249 6250 6251 6252 6253 6254 6255 6256 6257 6258 6259 6260 6261 6262 6263 6264 6265 6266 6267 6268 6269 6270 6271 6272 6273 6274 6275 6276 6277 6278 6279 6280 6281 6282 6283 6284 6285 6286 6287 6288 6289 6290 6291 6292 6293 6294 6295 6296 6297 6298 6299 6300 6301 6302 6303 6304 6305 6306 6307 6308 6309 6310 6311 6312 6313 6314 6315 6316 6317 6318 6319 6320 6321 6322 6323 6324 6325 6326 6327 6328 6329 6330 6331 6332 6333 6334 6335 6336 6337 6338 6339 6340 6341 6342 6343 6344 6345 6346 6347 6348 6349 6350 6351 6352 6353 6354 6355 6356 6357 6358 6359 6360 6361 6362 6363 6364 6365 6366 6367 6368 6369 6370 6371 6372 6373 6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441 6442 6443 6444 6445 6446 6447 6448 6449 6450 6451 6452 6453 6454 6455 6456 6457 6458 6459 6460 6461 6462 6463 6464 6465 6466 6467 6468 6469 6470 6471 6472 6473 6474 6475 6476 6477 6478 6479 6480 6481 6482 6483 6484 6485 6486 6487 6488 6489 6490 6491 6492 6493 6494 6495 6496 6497 6498 6499 6500 6501 6502 6503 6504 6505 6506 6507 6508 6509 6510 6511 6512 6513 6514 6515 6516 6517 6518 6519 6520 6521 6522 6523 6524 6525 6526 6527 6528 6529 6530 6531 6532 6533 6534 6535 6536 6537 6538 6539 6540 6541 6542 6543 6544 6545 6546 6547 6548 6549 6550 6551 6552 6553 6554 6555 6556 6557 6558 6559 6560 6561 6562 6563 6564 6565 6566 6567 6568 6569 6570 6571 6572 6573 6574 6575 6576 6577 6578 6579 6580 6581 6582 6583 6584 6585 6586 6587 6588 6589 6590 6591 6592 6593 6594 6595 6596 6597 6598 6599 6600 6601 6602 6603 6604 6605 6606 6607 6608 6609 6610 6611 6612 6613 6614 6615 6616 6617 6618 6619 6620 6621 6622 6623 6624 6625 6626 6627 6628 6629 6630 6631 6632 6633 6634 6635 6636 6637 6638 6639 6640 6641 6642 6643 6644 6645 6646 6647 6648 6649 6650 6651 6652 6653 6654 6655 6656 6657 6658 6659 6660 6661 6662 6663 6664 6665 6666 6667 6668 6669 6670 6671 6672 6673 6674 6675 6676 6677 6678 6679 6680 6681 6682 6683 6684 6685 6686 6687 6688 6689 6690 6691 6692 6693 6694 6695 6696 6697 6698 6699 6700 6701 6702 6703 6704 6705 6706 6707 6708 6709 6710 6711 6712 6713 6714 6715 6716 6717 6718 6719 6720 6721 6722 6723 6724 6725 6726 6727 6728 6729 6730 6731 6732 6733 6734 6735 6736 6737 6738 6739 6740 6741 6742 6743 6744 6745 6746 6747 6748 6749 6750 6751 6752 6753 6754 6755 6756 6757 6758 6759 6760 6761 6762 6763 6764 6765 6766 6767 6768 6769 6770 6771 6772 6773 6774 6775 6776 6777 6778 6779 6780 6781 6782 6783 6784 6785 6786 6787 6788 6789 6790 6791 6792 6793 6794 6795 6796 6797 6798 6799 6800 6801 6802 6803 6804 6805 6806 6807 6808 6809 6810 6811 6812 6813 6814 6815 6816 6817 6818 6819 6820 6821 6822 6823 6824 6825 6826 6827 6828 6829 6830 6831 6832 6833 6834 6835 6836 6837 6838 6839 6840 6841 6842 6843 6844 6845 6846 6847 6848 6849 6850 6851 6852 6853 6854 6855 6856 6857 6858 6859 6860 6861 6862 6863 6864 6865 6866 6867 6868 6869 6870 6871 6872 6873 6874 6875 6876 6877 6878 6879 6880 6881 6882 6883 6884 6885 6886 6887 6888 6889 6890 6891 6892 6893 6894 6895 6896 6897 6898 6899 6900 6901 6902 6903 6904 6905 6906 6907 6908 6909 6910 6911 6912 6913 6914 6915 6916 6917 6918 6919 6920 6921 6922 6923 6924 6925 6926 6927 6928 6929 6930 6931 6932 6933 6934 6935 6936 6937 6938 6939 6940 6941 6942 6943 6944 6945 6946 6947 6948 6949 6950 6951 6952 6953 6954 6955 6956 6957 6958 6959 6960 6961 6962 6963 6964 6965 6966 6967 6968 6969 6970 6971 6972 6973 6974 6975 6976 6977 6978 6979 6980 6981 6982 6983 6984 6985 6986 6987 6988 6989 6990 6991 6992 6993 6994 6995 6996 6997 6998 6999 7000 7001 7002 7003 7004 7005 7006 7007 7008 7009 7010 7011 7012 7013 7014 7015 7016 7017 7018 7019 7020 7021 7022 7023 7024 7025 7026 7027 7028 7029 7030 7031 7032 7033 7034 7035 7036 7037 7038 7039 7040 7041 7042 7043 7044 7045 7046 7047 7048 7049 7050 7051 7052 7053 7054 7055 7056 7057 7058 7059 7060 7061 7062 7063 7064 7065 7066 7067 7068 7069 7070 7071 7072 7073 7074 7075 7076 7077 7078 7079 7080 7081 7082 7083 7084 7085 7086 7087 7088 7089 7090 7091 7092 7093 7094 7095 7096 7097 7098 7099 7100 7101 7102 7103 7104 7105 7106 7107 7108 7109 7110 7111 7112 7113 7114 7115 7116 7117 7118 7119 7120 7121 7122 7123 7124 7125 7126 7127 7128 7129 7130 7131 7132 7133 7134 7135 7136 7137 7138 7139 7140 7141 7142 7143 7144 7145 7146 7147 7148 7149 7150 7151 7152 7153 7154 7155 7156 7157 7158 7159 7160 7161 7162 7163 7164 7165 7166 7167 7168 7169 7170 7171 7172 7173 7174 7175 7176 7177 7178 7179 7180 7181 7182 7183 7184 7185 7186 7187 7188 7189 7190 7191 7192 7193 7194 7195 7196 7197 7198 7199 7200 7201 7202 7203 7204 7205 7206 7207 7208 7209 7210 7211 7212 7213 7214 7215 7216 7217 7218 7219 7220 7221 7222 7223 7224 7225 7226 7227 7228 7229 7230 7231 7232 7233 7234 7235 7236 7237 7238 7239 7240 7241 7242 7243 7244 7245 7246 7247 7248 7249 7250 7251 7252 7253 7254 7255 7256 7257 7258 7259 7260 7261 7262 7263 7264 7265 7266 7267 7268 7269 7270 7271 7272 7273 7274 7275 7276 7277 7278 7279 7280 7281 7282 7283 7284 7285 7286 7287 7288 7289 7290 7291 7292 7293 7294 7295 7296 7297 7298 7299 7300 7301 7302 7303 7304 7305 7306 7307 7308 7309 7310 7311 7312 7313 7314 7315 7316 7317 7318 7319 7320 7321 7322 7323 7324 7325 7326 7327 7328 7329 7330 7331 7332 7333 7334 7335 7336 7337 7338 7339 7340 7341 7342 7343 7344 7345 7346 7347 7348 7349 7350 7351 7352 7353 7354 7355 7356 7357 7358 7359 7360 7361 7362 7363 7364 7365 7366 7367 7368 7369 7370 7371 7372 7373 7374 7375 7376 7377 7378 7379 7380 7381 7382 7383 7384 7385 7386 7387 7388 7389 7390 7391 7392 7393 7394 7395 7396 7397 7398 7399 7400 7401 7402 7403 7404 7405 7406 7407 7408 7409 7410 7411 7412 7413 7414 7415 7416 7417 7418 7419 7420 7421 7422 7423 7424 7425 7426 7427 7428 7429 7430 7431 7432 7433 7434 7435 7436 7437 7438 7439 7440 7441 7442 7443 7444 7445 7446 7447 7448 7449 7450 7451 7452 7453 7454 7455 7456 7457 7458 7459 7460 7461 7462 7463 7464 7465 7466 7467 7468 7469 7470 7471 7472 7473 7474 7475 7476 7477 7478 7479 7480 7481 7482 7483 7484 7485 7486 7487 7488 7489 7490 7491 7492 7493 7494 7495 7496 7497 7498 7499 7500 7501 7502 7503 7504 7505 7506 7507 7508 7509 7510 7511 7512 7513 7514 7515 7516 7517 7518 7519 7520 7521 7522 7523 7524 7525 7526 7527 7528 7529 7530 7531 7532 7533 7534 7535 7536 7537 7538 7539 7540 7541 7542 7543 7544 7545 7546 7547 7548 7549 7550 7551 7552 7553 7554 7555 7556 7557 7558 7559 7560 7561 7562 7563 7564 7565 7566 7567 7568 7569 7570 7571 7572 7573 7574 7575 7576 7577 7578 7579 7580 7581 7582 7583 7584 7585 7586 7587 7588 7589 7590 7591 7592 7593 7594 7595 7596 7597 7598 7599 7600 7601 7602 7603 7604 7605 7606 7607 7608 7609 7610 7611 7612 7613 7614 7615 7616 7617 7618 7619 7620 7621 7622 7623 7624 7625 7626 7627 7628 7629 7630 7631 7632 7633 7634 7635 7636 7637 7638 7639 7640 7641 7642 7643 7644 7645 7646 7647 7648 7649 7650 7651 7652 7653 7654 7655 7656 7657 7658 7659 7660 7661 7662 7663 7664 7665 7666 7667 7668 7669 7670 7671 7672 7673 7674 7675 7676 7677 7678 7679 7680 7681 7682 7683 7684 7685 7686 7687 7688 7689 7690 7691 7692 7693 7694 7695 7696 7697 7698 7699 7700 7701 7702 7703 7704 7705 7706 7707 7708 7709 7710 7711 7712 7713 7714 7715 7716 7717 7718 7719 7720 7721 7722 7723 7724 7725 7726 7727 7728 7729 7730 7731 7732 7733 7734 7735 7736 7737 7738 7739 7740 7741 7742 7743 7744 7745 7746 7747 7748 7749 7750 7751 7752 7753 7754 7755 7756 7757 7758 7759 7760 7761 7762 7763 7764 7765 7766 7767 7768 7769 7770 7771 7772 7773 7774 7775 7776 7777 7778 7779 7780 7781 7782 7783 7784 7785 7786 7787 7788 7789 7790 7791 7792 7793 7794 7795 7796 7797 7798 7799 7800 7801 7802 7803 7804 7805 7806 7807 7808 7809 7810 7811 7812 7813 7814 7815 7816 7817 7818 7819 7820 7821 7822 7823 7824 7825 7826 7827 7828 7829 7830 7831 7832 7833 7834 7835 7836 7837 7838 7839 7840 7841 7842 7843 7844 7845 7846 7847 7848 7849 7850 7851 7852 7853 7854 7855 7856 7857 7858 7859 7860 7861 7862 7863 7864 7865 7866 7867 7868 7869 7870 7871 7872 7873 7874 7875 7876 7877 7878 7879 7880 7881 7882 7883 7884 7885 7886 7887 7888 7889 7890 7891 7892 7893 7894 7895 7896 7897 7898 7899 7900 7901 7902 7903 7904 7905 7906 7907 7908 7909 7910 7911 7912 7913 7914 7915 7916 7917 7918 7919 7920 7921 7922 7923 7924 7925 7926 7927 7928 7929 7930 7931 7932 7933 7934 7935 7936 7937 7938 7939 7940 7941 7942 7943 7944 7945 7946 7947 7948 7949 7950 7951 7952 7953 7954 7955 7956 7957 7958 7959 7960 7961 7962 7963 7964 7965 7966 7967 7968 7969 7970 7971 7972 7973 7974 7975 7976 7977 7978 7979 7980 7981 7982 7983 7984 7985 7986 7987 7988 7989 7990 7991 7992 7993 7994 7995 7996 7997 7998 7999 8000 8001 8002 8003 8004 8005 8006 8007 8008 8009 8010 8011 8012 8013 8014 8015 8016 8017 8018 8019 8020 8021 8022 8023 8024 8025 8026 8027 8028 8029 8030 8031 8032 8033 8034 8035 8036 8037 8038 8039 8040 8041 8042 8043 8044 8045 8046 8047 8048 8049 8050 8051 8052 8053 8054 8055 8056 8057 8058 8059 8060 8061 8062 8063 8064 8065 8066 8067 8068 8069 8070 8071 8072 8073 8074 8075 8076 8077 8078 8079 8080 8081 8082 8083 8084 8085 8086 8087 8088 8089 8090 8091 8092 8093 8094 8095 8096 8097 8098 8099 8100 8101 8102 8103 8104 8105 8106 8107 8108 8109 8110 8111 8112 8113 8114 8115 8116 8117 8118 8119 8120 8121 8122 8123 8124 8125 8126 8127 8128 8129 8130 8131 8132 8133 8134 8135 8136 8137 8138 8139 8140 8141 8142 8143 8144 8145 8146 8147 8148 8149 8150 8151 8152 8153 8154 8155 8156 8157 8158 8159 8160 8161 8162 8163 8164 8165 8166 8167 8168 8169 8170 8171 8172 8173 8174 8175 8176 8177 8178 8179 8180 8181 8182 8183 8184 8185 8186 8187 8188 8189 8190 8191 8192 8193 8194 8195 8196 8197 8198 8199 8200 8201 8202 8203 8204 8205 8206 8207 8208 8209 8210 8211 8212 8213 8214 8215 8216 8217 8218 8219 8220 8221 8222 8223 8224 8225 8226 8227 8228 8229 8230 8231 8232 8233 8234 8235 8236 8237 8238 8239 8240 8241 8242 8243 8244 8245 8246 8247 8248 8249 8250 8251 8252 8253 8254 8255 8256 8257 8258 8259 8260 8261 8262 8263 8264 8265 8266 8267 8268 8269 8270 8271 8272 8273 8274 8275 8276 8277 8278 8279 8280 8281 8282 8283 8284 8285 8286 8287 8288 8289 8290 8291 8292 8293 8294 8295 8296 8297 8298 8299 8300 8301 8302 8303 8304 8305 8306 8307 8308 8309 8310 8311 8312 8313 8314 8315 8316 8317 8318 8319 8320 8321 8322 8323 8324 8325 8326 8327 8328 8329 8330 8331 8332 8333 8334 8335 8336 8337 8338 8339 8340 8341 8342 8343 8344 8345 8346 8347 8348 8349 8350 8351 8352 8353 8354 8355 8356 8357 8358 8359 8360 8361 8362 8363 8364 8365 8366 8367 8368 8369 8370 8371 8372 8373 8374 8375 8376 8377 8378 8379 8380 8381 8382 8383 8384 8385 8386 8387 8388 8389 8390 8391 8392 8393 8394 8395 8396 8397 8398 8399 8400 8401 8402 8403 8404 8405 8406 8407 8408 8409 8410 8411 8412 8413 8414 8415 8416 8417 8418 8419 8420 8421 8422 8423 8424 8425 8426 8427 8428 8429 8430 8431 8432 8433 8434 8435 8436 8437 8438 8439 8440 8441 8442 8443 8444 8445 8446 8447 8448 8449 8450 8451 8452 8453 8454 8455 8456 8457 8458 8459 8460 8461 8462 8463 8464 8465 8466 8467 8468 8469 8470 8471 8472 8473 8474 8475 8476 8477 8478 8479 8480 8481 8482 8483 8484 8485 8486 8487 8488 8489 8490 8491 8492 8493 8494 8495 8496 8497 8498 8499 8500 8501 8502 8503 8504 8505 8506 8507 8508 8509 8510 8511 8512 8513 8514 8515 8516 8517 8518 8519 8520 8521 8522 8523 8524 8525 8526 8527 8528 8529 8530 8531 8532 8533 8534 8535 8536 8537 8538 8539 8540 8541 8542 8543 8544 8545 8546 8547 8548 8549 8550 8551 8552 8553 8554 8555 8556 8557 8558 8559 8560 8561 8562 8563 8564 8565 8566 8567 8568 8569 8570 8571 8572 8573 8574 8575 8576 8577 8578 8579 8580 8581 8582 8583 8584 8585 8586 8587 8588 8589 8590 8591 8592 8593 8594 8595 8596 8597 8598 8599 8600 8601 8602 8603 8604 8605 8606 8607 8608 8609 8610 8611 8612 8613 8614 8615 8616 8617 8618 8619 8620 8621 8622 8623 8624 8625 8626 8627 8628 8629 8630 8631 8632 8633 8634 8635 8636 8637 8638 8639 8640 8641 8642 8643 8644 8645 8646 8647 8648 8649 8650 8651 8652 8653 8654 8655 8656 8657 8658 8659 8660 8661 8662 8663 8664 8665 8666 8667 8668 8669 8670 8671 8672 8673 8674 8675 8676 8677 8678 8679 8680 8681 8682 8683 8684 8685 8686 8687 8688 8689 8690 8691 8692 8693 8694 8695 8696 8697 8698 8699 8700 8701 8702 8703 8704 8705 8706 8707 8708 8709 8710 8711 8712 8713 8714 8715 8716 8717 8718 8719 8720 8721 8722 8723 8724 8725 8726 8727 8728 8729 8730 8731 8732 8733 8734 8735 8736 8737 8738 8739 8740 8741 8742 8743 8744 8745 8746 8747 8748 8749 8750 8751 8752 8753 8754 8755 8756 8757 8758 8759 8760 8761 8762 8763 8764 8765 8766 8767 8768 8769 8770 8771 8772 8773 8774 8775 8776 8777 8778 8779 8780 8781 8782 8783 8784 8785 8786 8787 8788 8789 8790 8791 8792 8793 8794 8795 8796 8797 8798 8799 8800 8801 8802 8803 8804 8805 8806 8807 8808 8809 8810 8811 8812 8813 8814 8815 8816 8817 8818 8819 8820 8821 8822 8823 8824 8825 8826 8827 8828 8829 8830 8831 8832 8833 8834 8835 8836 8837 8838 8839 8840 8841 8842 8843 8844 8845 8846 8847 8848 8849 8850 8851 8852 8853 8854 8855 8856 8857 8858 8859 8860 8861 8862 8863 8864 8865 8866 8867 8868 8869 8870 8871 8872 8873 8874 8875 8876 8877 8878 8879 8880 8881 8882 8883 8884 8885 8886 8887 8888 8889 8890 8891 8892 8893 8894 8895 8896 8897 8898 8899 8900 8901 8902 8903 8904 8905 8906 8907 8908 8909 8910 8911 8912 8913 8914 8915 8916 8917 8918 8919 8920 8921 8922 8923 8924 8925 8926 8927 8928 8929 8930 8931 8932 8933 8934 8935 8936 8937 8938 8939 8940 8941 8942 8943 8944 8945 8946 8947 8948 8949 8950 8951 8952 8953 8954 8955 8956 8957 8958 8959 8960 8961 8962 8963 8964 8965 8966 8967 8968 8969 8970 8971 8972 8973 8974 8975 8976 8977 8978 8979 8980 8981 8982 8983 8984 8985 8986 8987 8988 8989 8990 8991 8992 8993 8994 8995 8996 8997 8998 8999 9000 9001 9002 9003 9004 9005 9006 9007 9008 9009 9010 9011 9012 9013 9014 9015 9016 9017 9018 9019 9020 9021 9022 9023 9024 9025 9026 9027 9028 9029 9030 9031 9032 9033 9034 9035 9036 9037 9038 9039 9040 9041 9042 9043 9044 9045 9046 9047 9048 9049 9050 9051 9052 9053 9054 9055 9056 9057 9058 9059 9060 9061 9062 9063 9064 9065 9066 9067 9068 9069 9070 9071 9072 9073 9074 9075 9076 9077 9078 9079 9080 9081 9082 9083 9084 9085 9086 9087 9088 9089 9090 9091 9092 9093 9094 9095 9096 9097 9098 9099 9100 9101 9102 9103 9104 9105 9106 9107 9108 9109 9110 9111 9112 9113 9114 9115 9116 9117 9118 9119 9120 9121 9122 9123 9124 9125 9126 9127 9128 9129 9130 9131 9132 9133 9134 9135 9136 9137 9138 9139 9140 9141 9142 9143 9144 9145 9146 9147 9148 9149 9150 9151 9152 9153 9154 9155 9156 9157 9158 9159 9160 9161 9162 9163 9164 9165 9166 9167 9168 9169 9170 9171 9172 9173 9174 9175 9176 9177 9178 9179 9180 9181 9182 9183 9184 9185 9186 9187 9188 9189 9190 9191 9192 9193 9194 9195 9196 9197 9198 9199 9200 9201 9202 9203 9204 9205 9206 9207 9208 9209 9210 9211 9212 9213 9214 9215 9216 9217 9218 9219 9220 9221 9222 9223 9224 9225 9226 9227 9228 9229 9230 9231 9232 9233 9234 9235 9236 9237 9238 9239 9240 9241 9242 9243 9244 9245 9246 9247 9248 9249 9250 9251 9252 9253 9254 9255 9256 9257 9258 9259 9260 9261 9262 9263 9264 9265 9266 9267 9268 9269 9270 9271 9272 9273 9274 9275 9276 9277 9278 9279 9280 9281 9282 9283 9284 9285 9286 9287 9288 9289 9290 9291 9292 9293 9294 9295 9296 9297 9298 9299 9300 9301 9302 9303 9304 9305 9306 9307 9308 9309 9310 9311 9312 9313 9314 9315 9316 9317 9318 9319 9320 9321 9322 9323 9324 9325 9326 9327 9328 9329 9330 9331 9332 9333 9334 9335 9336 9337 9338 9339 9340 9341 9342 9343 9344 9345 9346 9347 9348 9349 9350 9351 9352 9353 9354 9355 9356 9357 9358 9359 9360 9361 9362 9363 9364 9365 9366 9367 9368 9369 9370 9371 9372 9373 9374 9375 9376 9377 9378 9379 9380 9381 9382 9383 9384 9385 9386 9387 9388 9389 9390 9391 9392 9393 9394 9395 9396 9397 9398 9399 9400 9401 9402 9403 9404 9405 9406 9407 9408 9409 9410 9411 9412 9413 9414 9415 9416 9417 9418 9419 9420 9421 9422 9423 9424 9425 9426 9427 9428 9429 9430 9431 9432 9433 9434 9435 9436 9437 9438 9439 9440 9441 9442 9443 9444 9445 9446 9447 9448 9449 9450 9451 9452 9453 9454 9455 9456 9457 9458 9459 9460 9461 9462 9463 9464 9465 9466 9467 9468 9469 9470 9471 9472 9473 9474 9475 9476 9477 9478 9479 9480 9481 9482 9483 9484 9485 9486 9487 9488 9489 9490 9491 9492 9493 9494 9495 9496 9497 9498 9499 9500 9501 9502 9503 9504 9505 9506 9507 9508 9509 9510 9511 9512 9513 9514 9515 9516 9517 9518 9519 9520 9521 9522 9523 9524 9525 9526 9527 9528 9529 9530 9531 9532 9533 9534 9535 9536 9537 9538 9539 9540 9541 9542 9543 9544 9545 9546 9547 9548 9549 9550 9551 9552 9553 9554 9555 9556 9557 9558 9559 9560 9561 9562 9563 9564 9565 9566 9567 9568 9569 9570 9571 9572 9573 9574 9575 9576 9577 9578 9579 9580 9581 9582 9583 9584 9585 9586 9587 9588 9589 9590 9591 9592 9593 9594 9595 9596 9597 9598 9599 9600 9601 9602 9603 9604 9605 9606 9607 9608 9609 9610 9611 9612 9613 9614 9615 9616 9617 9618 9619 9620 9621 9622 9623 9624 9625 9626 9627 9628 9629 9630 9631 9632 9633 9634 9635 9636 9637 9638 9639 9640 9641 9642 9643 9644 9645 9646 9647 9648 9649 9650 9651 9652 9653 9654 9655 9656 9657 9658 9659 9660 9661 9662 9663 9664 9665 9666 9667 9668 9669 9670 9671 9672 9673 9674 9675 9676 9677 9678 9679 9680 9681 9682 9683 9684 9685 9686 9687 9688 9689 9690 9691 9692 9693 9694 9695 9696 9697 9698 9699 9700 9701 9702 9703 9704 9705 9706 9707 9708 9709 9710 9711 9712 9713 9714 9715 9716 9717 9718 9719 9720 9721 9722 9723 9724 9725 9726 9727 9728 9729 9730 9731 9732 9733 9734 9735 9736 9737 9738 9739 9740 9741 9742 9743 9744 9745 9746 9747 9748 9749 9750 9751 9752 9753 9754 9755 9756 9757 9758 9759 9760 9761 9762 9763 9764 9765 9766 9767 9768 9769 9770 9771 9772 9773 9774 9775 9776 9777 9778 9779 9780 9781 9782 9783 9784 9785 9786 9787 9788 9789 9790 9791 9792 9793 9794 9795 9796 9797 9798 9799 9800 9801 9802 9803 9804 9805 9806 9807 9808 9809 9810 9811 9812 9813 9814 9815 9816 9817 9818 9819 9820 9821 9822 9823 9824 9825 9826 9827 9828 9829 9830 9831 9832 9833 9834 9835 9836 9837 9838 9839 9840 9841 9842 9843 9844 9845 9846 9847 9848 9849 9850 9851 9852 9853 9854 9855 9856 9857 9858 9859 9860 9861 9862 9863 9864 9865 9866 9867 9868 9869 9870 9871 9872 9873 9874 9875 9876 9877 9878 9879 9880 9881 9882 9883 9884 9885 9886 9887 9888 9889 9890 9891 9892 9893 9894 9895 9896 9897 9898 9899 9900 9901 9902 9903 9904 9905 9906 9907 9908 9909 9910 9911 9912 9913 9914 9915 9916 9917 9918 9919 9920 9921 9922 9923 9924 9925 9926 9927 9928 9929 9930 9931 9932 9933 9934 9935 9936 9937 9938 9939 9940 9941 9942 9943 9944 9945 9946 9947 9948 9949 9950 9951 9952 9953 9954 9955 9956 9957 9958 9959 9960 9961 9962 9963 9964 9965 9966 9967 9968 9969 9970 9971 9972 9973 9974 9975 9976 9977 9978 9979 9980 9981 9982 9983 9984 9985 9986 9987 9988 9989 9990 9991 9992 9993 9994 9995 9996 9997 9998 9999 10000 10001 10002 10003 10004 10005 10006 10007 10008 10009 10010 10011 10012 10013 10014 10015 10016 10017 10018 10019 10020 10021 10022 10023 10024 10025 10026 10027 10028 10029 10030 10031 10032 10033 10034 10035 10036 10037 10038 10039 10040 10041 10042 10043 10044 10045 10046 10047 10048 10049 10050 10051 10052 10053 10054 10055 10056 10057 10058 10059 10060 10061 10062 10063 10064 10065 10066 10067 10068 10069 10070 10071 10072 10073 10074 10075 10076 10077 10078 10079 10080 10081 10082 10083 10084 10085 10086 10087 10088 10089 10090 10091 10092 10093 10094 10095 10096 10097 10098 10099 10100 10101 10102 10103 10104 10105 10106 10107 10108 10109 10110 10111 10112 10113 10114 10115 10116 10117 10118 10119 10120 10121 10122 10123 10124 10125 10126 10127 10128 10129 10130 10131 10132 10133 10134 10135 10136 10137 10138 10139 10140 10141 10142 10143 10144 10145 10146 10147 10148 10149 10150 10151 10152 10153 10154 10155 10156 10157 10158 10159 10160 10161 10162 10163 10164 10165 10166 10167 10168 10169 10170 10171 10172 10173 10174 10175 10176 10177 10178 10179 10180 10181 10182 10183 10184 10185 10186 10187 10188 10189 10190 10191 10192 10193 10194 10195 10196 10197 10198 10199 10200 10201 10202 10203 10204 10205 10206 10207 10208 10209 10210 10211 10212 10213 10214 10215 10216 10217 10218 10219 10220 10221 10222 10223 10224 10225 10226 10227 10228 10229 10230 10231 10232 10233 10234 10235 10236 10237 10238 10239 10240 10241 10242 10243 10244 10245 10246 10247 10248 10249 10250 10251 10252 10253 10254 10255 10256 10257 10258 10259 10260 10261 10262 10263 10264 10265 10266 10267 10268 10269 10270 10271 10272 10273 10274 10275 10276 10277 10278 10279 10280 10281 10282 10283 10284 10285 10286 10287 10288 10289 10290 10291 10292 10293 10294 10295 10296 10297 10298 10299 10300 10301 10302 10303 10304 10305 10306 10307 10308 10309 10310 10311 10312 10313 10314 10315 10316 10317 10318 10319 10320 10321 10322 10323 10324 10325 10326 10327 10328 10329 10330 10331 10332 10333 10334 10335 10336 10337 10338 10339 10340 10341 10342 10343 10344 10345 10346 10347 10348 10349 10350 10351 10352 10353 10354 10355 10356 10357 10358 10359 10360 10361 10362 10363 10364 10365 10366 10367 10368 10369 10370 10371 10372 10373 10374 10375 10376 10377 10378 10379 10380 10381 10382 10383 10384 10385 10386 10387 10388 10389 10390 10391 10392 10393 10394 10395 10396 10397 10398 10399 10400 10401 10402 10403 10404 10405 10406 10407 10408 10409 10410 10411 10412 10413 10414 10415 10416 10417 10418 10419 10420 10421 10422 10423 10424 10425 10426 10427 10428 10429 10430 10431 10432 10433 10434 10435 10436 10437 10438 10439 10440 10441 10442 10443 10444 10445 10446 10447 10448 10449 10450 10451 10452 10453 10454 10455 10456 10457 10458 10459 10460 10461 10462 10463 10464 10465 10466 10467 10468 10469 10470 10471 10472 10473 10474 10475 10476 10477 10478 10479 10480 10481 10482 10483 10484 10485 10486 10487 10488 10489 10490 10491 10492 10493 10494 10495 10496 10497 10498 10499 10500 10501 10502 10503 10504 10505 10506 10507 10508 10509 10510 10511 10512 10513 10514 10515 10516 10517 10518 10519 10520 10521 10522 10523 10524 10525 10526 10527 10528 10529 10530 10531 10532 10533 10534 10535 10536 10537 10538 10539 10540 10541 10542 10543 10544 10545 10546 10547 10548 10549 10550 10551 10552 10553 10554 10555 10556 10557 10558 10559 10560 10561 10562 10563 10564 10565 10566 10567 10568 10569 10570 10571 10572 10573 10574 10575 10576 10577 10578 10579 10580 10581 10582 10583 10584 10585 10586 10587 10588 10589 10590 10591 10592 10593 10594 10595 10596 10597 10598 10599 10600 10601 10602 10603 10604 10605 10606 10607 10608 10609 10610 10611 10612 10613 10614 10615 10616 10617 10618 10619 10620 10621 10622 10623 10624 10625 10626 10627 10628 10629 10630 10631 10632 10633 10634 10635 10636 10637 10638 10639 10640 10641 10642 10643 10644 10645 10646 10647 10648 10649 10650 10651 10652 10653 10654 10655 10656 10657 10658 10659 10660 10661 10662 10663 10664 10665 10666 10667 10668 10669 10670 10671 10672 10673 10674 10675 10676 10677 10678 10679 10680 10681 10682 10683 10684 10685 10686 10687 10688 10689 10690 10691 10692 10693 10694 10695 10696 10697 10698 10699 10700 10701 10702 10703 10704 10705 10706 10707 10708 10709 10710 10711 10712 10713 10714 10715 10716 10717 10718 10719 10720 10721 10722 10723 10724 10725 10726 10727 10728 10729 10730 10731 10732 10733 10734 10735 10736 10737 10738 10739 10740 10741 10742 10743 10744 10745 10746 10747 10748 10749 10750 10751 10752 10753 10754 10755 10756 10757 10758 10759 10760 10761 10762 10763 10764 10765 10766 10767 10768 10769 10770 10771 10772 10773 10774 10775 10776 10777 10778 10779 10780 10781 10782 10783 10784 10785 10786 10787 10788 10789 10790 10791 10792 10793 10794 10795 10796 10797 10798 10799 10800 10801 10802 10803 10804 10805 10806 10807 10808 10809 10810 10811 10812 10813 10814 10815 10816 10817 10818 10819 10820 10821 10822 10823 10824 10825 10826 10827 10828 10829 10830 10831 10832 10833 10834 10835 10836 10837 10838 10839 10840 10841 10842 10843 10844 10845 10846 10847 10848 10849 10850 10851 10852 10853 10854 10855 10856 10857 10858 10859 10860 10861 10862 10863 10864 10865 10866 10867 10868 10869 10870 10871 10872 10873 10874 10875 10876 10877 10878 10879 10880 10881 10882 10883 10884 10885 10886 10887 10888 10889 10890 10891 10892 10893 10894 10895 10896 10897 10898 10899 10900 10901 10902 10903 10904 10905 10906 10907 10908 10909 10910 10911 10912 10913 10914 10915 10916 10917 10918 10919 10920 10921 10922 10923 10924 10925 10926 10927 10928 10929 10930 10931 10932 10933 10934 10935 10936 10937 10938 10939 10940 10941 10942 10943 10944 10945 10946 10947 10948 10949 10950 10951 10952 10953 10954 10955 10956 10957 10958 10959 10960 10961 10962 10963 10964 10965 10966 10967 10968 10969 10970 10971 10972 10973 10974 10975 10976 10977 10978 10979 10980 10981 10982 10983 10984 10985 10986 10987 10988 10989 10990 10991 10992 10993 10994 10995 10996 10997 10998 10999 11000 11001 11002 11003 11004 11005 11006 11007 11008 11009 11010 11011 11012 11013 11014 11015 11016 11017 11018 11019 11020 11021 11022 11023 11024 11025 11026 11027 11028 11029 11030 11031 11032 11033 11034 11035 11036 11037 11038 11039 11040 11041 11042 11043 11044 11045 11046 11047 11048 11049 11050 11051 11052 11053 11054 11055 11056 11057 11058 11059 11060 11061 11062 11063 11064 11065 11066 11067 11068 11069 11070 11071 11072 11073 11074 11075 11076 11077 11078 11079 11080 11081 11082 11083 11084 11085 11086 11087 11088 11089 11090 11091 11092 11093 11094 11095 11096 11097 11098 11099 11100 11101 11102 11103 11104 11105 11106 11107 11108 11109 11110 11111 11112 11113 11114 11115 11116 11117 11118 11119 11120 11121 11122 11123 11124 11125 11126 11127 11128 11129 11130 11131 11132 11133 11134 11135 11136 11137 11138 11139 11140 11141 11142 11143 11144 11145 11146 11147 11148 11149 11150 11151 11152 11153 11154 11155 11156 11157 11158 11159 11160 11161 11162 11163 11164 11165 11166 11167 11168 11169 11170 11171 11172 11173 11174 11175 11176 11177 11178 11179 11180 11181 11182 11183 11184 11185 11186 11187 11188 11189 11190 11191 11192 11193 11194 11195 11196 11197 11198 11199 11200 11201 11202 11203 11204 11205 11206 11207 11208 11209 11210 11211 11212 11213 11214 11215 11216 11217 11218 11219 11220 11221 11222 11223 11224 11225 11226 11227 11228 11229 11230 11231 11232 11233 11234 11235 11236 11237 11238 11239 11240 11241 11242 11243 11244 11245 11246 11247 11248 11249 11250 11251 11252 11253 11254 11255 11256 11257 11258 11259 11260 11261 11262 11263 11264 11265 11266 11267 11268 11269 11270 11271 11272 11273 11274 11275 11276 11277 11278 11279 11280 11281 11282 11283 11284 11285 11286 11287 11288 11289 11290 11291 11292 11293 11294 11295 11296 11297 11298 11299 11300 11301 11302 11303 11304 11305 11306 11307 11308 11309 11310 11311 11312 11313 11314 11315 11316 11317 11318 11319 11320 11321 11322 11323 11324 11325 11326 11327 11328 11329 11330 11331 11332 11333 11334 11335 11336 11337 11338 11339 11340 11341 11342 11343 11344 11345 11346 11347 11348 11349 11350 11351 11352 11353 11354 11355 11356 11357 11358 11359 11360 11361 11362 11363 11364 11365 11366 11367 11368 11369 11370 11371 11372 11373 11374 11375 11376 11377 11378 11379 11380 11381 11382 11383 11384 11385 11386 11387 11388 11389 11390 11391 11392 11393 11394 11395 11396 11397 11398 11399 11400 11401 11402 11403 11404 11405 11406 11407 11408 11409 11410 11411 11412 11413 11414 11415 11416 11417 11418 11419 11420 11421 11422 11423 11424 11425 11426 11427 11428 11429 11430 11431 11432 11433 11434 11435 11436 11437 11438 11439 11440 11441 11442 11443 11444 11445 11446 11447 11448 11449 11450 11451 11452 11453 11454 11455 11456 11457 11458 11459 11460 11461 11462 11463 11464 11465 11466 11467 11468 11469 11470 11471 11472 11473 11474 11475 11476 11477 11478 11479 11480 11481 11482 11483 11484 11485 11486 11487 11488 11489 11490 11491 11492 11493 11494 11495 11496 11497 11498 11499 11500 11501 11502 11503 11504 11505 11506 11507 11508 11509 11510 11511 11512 11513 11514 11515 11516 11517 11518 11519 11520 11521 11522 11523 11524 11525 11526 11527 11528 11529 11530 11531 11532 11533 11534 11535 11536 11537 11538 11539 11540 11541 11542 11543 11544 11545 11546 11547 11548 11549 11550 11551 11552 11553 11554 11555 11556 11557 11558 11559 11560 11561 11562 11563 11564 11565 11566 11567 11568 11569 11570 11571 11572 11573 11574 11575 11576 11577 11578 11579 11580 11581 11582 11583 11584 11585 11586 11587 11588 11589 11590 11591 11592 11593 11594 11595 11596 11597 11598 11599 11600 11601 11602 11603 11604 11605 11606 11607 11608 11609 11610 11611 11612 11613 11614 11615 11616 11617 11618 11619 11620 11621 11622 11623 11624 11625 11626 11627 11628 11629 11630 11631 11632 11633 11634 11635 11636 11637 11638 11639 11640 11641 11642 11643 11644 11645 11646 11647 11648 11649 11650 11651 11652 11653 11654 11655 11656 11657 11658 11659 11660 11661 11662 11663 11664 11665 11666 11667 11668 11669 11670 11671 11672 11673 11674 11675 11676 11677 11678 11679 11680 11681 11682 11683 11684 11685 11686 11687 11688 11689 11690 11691 11692 11693 11694 11695 11696 11697 11698 11699 11700 11701 11702 11703 11704 11705 11706 11707 11708 11709 11710 11711 11712 11713 11714 11715 11716 11717 11718 11719 11720 11721 11722 11723 11724 11725 11726 11727 11728 11729 11730 11731 11732 11733 11734 11735 11736 11737 11738 11739 11740 11741 11742 11743 11744 11745 11746 11747 11748 11749 11750 11751 11752 11753 11754 11755 11756 11757 11758 11759 11760 11761 11762 11763 11764 11765 11766 11767 11768 11769 11770 11771 11772 11773 11774 11775 11776 11777 11778 11779 11780 11781 11782 11783 11784 11785 11786 11787 11788 11789 11790 11791 11792 11793 11794 11795 11796 11797 11798 11799 11800 11801 11802 11803 11804 11805 11806 11807 11808 11809 11810 11811 11812 11813 11814 11815 11816 11817 11818 11819 11820 11821 11822 11823 11824 11825 11826 11827 11828 11829 11830 11831 11832 11833 11834 11835 11836 11837 11838 11839 11840 11841 11842 11843 11844 11845 11846 11847 11848 11849 11850 11851 11852 11853 11854 11855 11856 11857 11858 11859 11860 11861 11862 11863 11864 11865 11866 11867 11868 11869 11870 11871 11872 11873 11874 11875 11876 11877 11878 11879 11880 11881 11882 11883 11884 11885 11886 11887 11888 11889 11890 11891 11892 11893 11894 11895 11896 11897 11898 11899 11900 11901 11902 11903 11904 11905 11906 11907 11908 11909 11910 11911 11912 11913 11914 11915 11916 11917 11918 11919 11920 11921 11922 11923 11924 11925 11926 11927 11928 11929 11930 11931 11932 11933 11934 11935 11936 11937 11938 11939 11940 11941 11942 11943 11944 11945 11946 11947 11948 11949 11950 11951 11952 11953 11954 11955 11956 11957 11958 11959 11960 11961 11962 11963 11964 11965 11966 11967 11968 11969 11970 11971 11972 11973 11974 11975 11976 11977 11978 11979 11980 11981 11982 11983 11984 11985 11986 11987 11988 11989 11990 11991 11992 11993 11994 11995 11996 11997 11998 11999 12000 12001 12002 12003 12004 12005 12006 12007 12008 12009 12010 12011 12012 12013 12014 12015 12016 12017 12018 12019 12020 12021 12022 12023 12024 12025 12026 12027 12028 12029 12030 12031 12032 12033 12034 12035 12036 12037 12038 12039 12040 12041 12042 12043 12044 12045 12046 12047 12048 12049 12050 12051 12052 12053 12054 12055 12056 12057 12058 12059 12060 12061 12062 12063 12064 12065 12066 12067 12068 12069 12070 12071 12072 12073 12074 12075 12076 12077 12078 12079 12080 12081 12082 12083 12084 12085 12086 12087 12088 12089 12090 12091 12092 12093 12094 12095 12096 12097 12098 12099 12100 12101 12102 12103 12104 12105 12106 12107 12108 12109 12110 12111 12112 12113 12114 12115 12116 12117 12118 12119 12120 12121 12122 12123 12124 12125 12126 12127 12128 12129 12130 12131 12132 12133 12134 12135 12136 12137 12138 12139 12140 12141 12142 12143 12144 12145 12146 12147 12148 12149 12150 12151 12152 12153 12154 12155 12156 12157 12158 12159 12160 12161 12162 12163 12164 12165 12166 12167 12168 12169 12170 12171 12172 12173 12174 12175 12176 12177 12178 12179 12180 12181 12182 12183 12184 12185 12186 12187 12188 12189 12190 12191 12192 12193 12194 12195 12196 12197 12198 12199 12200 12201 12202 12203 12204 12205 12206 12207 12208 12209 12210 12211 12212 12213 12214 12215 12216 12217 12218 12219 12220 12221 12222 12223 12224 12225 12226 12227 12228 12229 12230 12231 12232 12233 12234 12235 12236 12237 12238 12239 12240 12241 12242 12243 12244 12245 12246 12247 12248 12249 12250 12251 12252 12253 12254 12255 12256 12257 12258 12259 12260 12261 12262 12263 12264 12265 12266 12267 12268 12269 12270 12271 12272 12273 12274 12275 12276 12277 12278 12279 12280 12281 12282 12283 12284 12285 12286 12287 12288 12289 12290 12291 12292 12293 12294 12295 12296 12297 12298 12299 12300 12301 12302 12303 12304 12305 12306 12307 12308 12309 12310 12311 12312 12313 12314 12315 12316 12317 12318 12319 12320 12321 12322 12323 12324 12325 12326 12327 12328 12329 12330 12331 12332 12333 12334 12335 12336 12337 12338 12339 12340 12341 12342 12343 12344 12345 12346 12347 12348 12349 12350 12351 12352 12353 12354 12355 12356 12357 12358 12359 12360 12361 12362 12363 12364 12365 12366 12367 12368 12369 12370 12371 12372 12373 12374 12375 12376 12377 12378 12379 12380 12381 12382 12383 12384 12385 12386 12387 12388 12389 12390 12391 12392 12393 12394 12395 12396 12397 12398 12399 12400 12401 12402 12403 12404 12405 12406 12407 12408 12409 12410 12411 12412 12413 12414 12415 12416 12417 12418 12419 12420 12421 12422 12423 12424 12425 12426 12427 12428 12429 12430 12431 12432 12433 12434 12435 12436 12437 12438 12439 12440 12441 12442 12443 12444 12445 12446 12447 12448 12449 12450 12451 12452 12453 12454 12455 12456 12457 12458 12459 12460 12461 12462 12463 12464 12465 12466 12467 12468 12469 12470 12471 12472 12473 12474 12475 12476 12477 12478 12479 12480 12481 12482 12483 12484 12485 12486 12487 12488 12489 12490 12491 12492 12493 12494 12495 12496 12497 12498 12499 12500 12501 12502 12503 12504 12505 12506 12507 12508 12509 12510 12511 12512 12513 12514 12515 12516 12517 12518 12519 12520 12521 12522 12523 12524 12525 12526 12527 12528 12529 12530 12531 12532 12533 12534 12535 12536 12537 12538 12539 12540 12541 12542 12543 12544 12545 12546 12547 12548 12549 12550 12551 12552 12553 12554 12555 12556 12557 12558 12559 12560 12561 12562 12563 12564 12565 12566 12567 12568 12569 12570 12571 12572 12573 12574 12575 12576 12577 12578 12579 12580 12581 12582 12583 12584 12585 12586 12587 12588 12589 12590 12591 12592 12593 12594 12595 12596 12597 12598 12599 12600 12601 12602 12603 12604 12605 12606 12607 12608 12609 12610 12611 12612 12613 12614 12615 12616 12617 12618 12619 12620 12621 12622 12623 12624 12625 12626 12627 12628 12629 12630 12631 12632 12633 12634 12635 12636 12637 12638 12639 12640 12641 12642 12643 12644 12645 12646 12647 12648 12649 12650 12651 12652 12653 12654 12655 12656 12657 12658 12659 12660 12661 12662 12663 12664 12665 12666 12667 12668 12669 12670 12671 12672 12673 12674 12675 12676 12677 12678 12679 12680 12681 12682 12683 12684 12685 12686 12687 12688 12689 12690 12691 12692 12693 12694 12695 12696 12697 12698 12699 12700 12701 12702 12703 12704 12705 12706 12707 12708 12709 12710 12711 12712 12713 12714 12715 12716 12717 12718 12719 12720 12721 12722 12723 12724 12725 12726 12727 12728 12729 12730 12731 12732 12733 12734 12735 12736 12737 12738 12739 12740 12741 12742 12743 12744 12745 12746 12747 12748 12749 12750 12751 12752 12753 12754 12755 12756 12757 12758 12759 12760 12761 12762 12763 12764 12765 12766 12767 12768 12769 12770 12771 12772 12773 12774 12775 12776 12777 12778 12779 12780 12781 12782 12783 12784 12785 12786 12787 12788 12789 12790 12791 12792 12793 12794 12795 12796 12797 12798 12799 12800 12801 12802 12803 12804 12805 12806 12807 12808 12809 12810 12811 12812 12813 12814 12815 12816 12817 12818 12819 12820 12821 12822 12823 12824 12825 12826 12827 12828 12829 12830 12831 12832 12833 12834 12835 12836 12837 12838 12839 12840 12841 12842 12843 12844 12845 12846 12847 12848 12849 12850 12851 12852 12853 12854 12855 12856 12857 12858 12859 12860 12861 12862 12863 12864 12865 12866 12867 12868 12869 12870 12871 12872 12873 12874 12875 12876 12877 12878 12879 12880 12881 12882 12883 12884 12885 12886 12887 12888 12889 12890 12891 12892 12893 12894 12895 12896 12897 12898 12899 12900 12901 12902 12903 12904 12905 12906 12907 12908 12909 12910 12911 12912 12913 12914 12915 12916 12917 12918 12919 12920 12921 12922 12923 12924 12925 12926 12927 12928 12929 12930 12931 12932 12933 12934 12935 12936 12937 12938 12939 12940 12941 12942 12943 12944 12945 12946 12947 12948 12949 12950 12951 12952 12953 12954 12955 12956 12957 12958 12959 12960 12961 12962 12963 12964 12965 12966 12967 12968 12969 12970 12971 12972 12973 12974 12975 12976 12977 12978 12979 12980 12981 12982 12983 12984 12985 12986 12987 12988 12989 12990 12991 12992 12993 12994 12995 12996 12997 12998 12999 13000 13001 13002 13003 13004 13005 13006 13007 13008 13009 13010 13011 13012 13013 13014 13015 13016 13017 13018 13019 13020 13021 13022 13023 13024 13025 13026 13027
|
2003-08-30 Per Cederqvist <ceder@ceder.dyndns.org>
* Release 2.1.2.
2003-08-29 Per Cederqvist <ceder@ceder.dyndns.org>
Spelling fixes.
* doc/Protocol-A.texi: Spelling errors fixed.
Makefile fix.
* doc/Makefile.am (DISTCLEANFILES): Added protocol-a-current.txt,
protocol-a-recommended.txt and protocol-a-full.txt.
Release administrativa.
* configure.in: Set version 2.1.2.
* versions (SERVER-VERSION): Set to 2.1.2.
(SERVER-COMPAT-VERSION): Set to 20102.
* doc/Protocol-A.texi (PROTOEDITION): Set to 11.1.
(VERSION): Set to 2.1.2.
(Document Edition History): Added an entry for 11.1. Added
missing "Distributed with" line for 11.0.
(Top): Say that this was "first distributed with" a certain
lyskomd release, not that it "corresponds to" a release. This
way, the text is more accurate if a bug-fix release of lyskomd is
made without updating the Protocol-A.texi file.
* NEWS: Updated for the 2.1.2 release.
* README: Mention that the bug 1121 fix will write stuff to the
log. Update the year in the copyright notice.
* scripts/lyskomd-copyrights: The top-level README file has a
copyright statement, so don't forget to update that file. Don't
update the generated machine-readable grammars. Don't update the
data files for bug-1121.exp.
Don't allow the garb thread to be starved. Tune the garb
parameters. (Bug 1129).
* src/server/text-garb.c (garb_callback): Always run the garb, so
that it cannot be completely starved.
* src/server/server-config.c (parameters): Changed "Garb busy
postponement" from 20 to 50 milliseconds. Changed "Garb timeout"
from 100 to 0 milliseconds.
* src/include/kom-types.h (Text_stat): Remove swedish in a comment.
* doc/lyskomd.texi (Parameters): Updated "Garb busy postponement"
and "Garb timeout".
* src/server/testsuite/lyskomd.0/37.exp: Updated the expected
timeouts for the garb tuning.
Document the garb. (Bug 194).
* doc/Protocol-A.texi (Garb): New chapter.
Check for a potential memory leak when killing a client.
(Bug 149).
* src/server/internal-connections.c (kill_client): Check that no
aux_item_list remains.
Don't produce overlapping ranges in the read-ranges part of a
membership. (Bug 1121). Make lyskomd fix the errors introduced
by bug 1121.
* src/server/membership.c (insert_loc_no): Handle the case where
adjoining ranges exists properly instead of producing overlapping
ranges.
* src/server/ram-parse.c (fparse_read_range_0): Handle the errors
introduced by bug 1121. Log an error message if any damage was
repaired.
* src/server/testsuite/config/unix.exp (lyskomd_start): New
argument: db_messages.
(dbck_run): New argument: extra_lines.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
bug-1121.exp, bug-1121.data and bug-1121.texts.
* src/server/testsuite/lyskomd.0/bug-1121.exp: Test for bug 1121:
mark-as-read mishandles read texts in some circumstances. Also
test that lyskomd can repair the problems introduced by this bug.
* src/server/testsuite/lyskomd.0/bug-1121.texts: New file.
* src/server/testsuite/lyskomd.0/bug-1121.data: New file.
2003-08-28 Per Cederqvist <ceder@ceder.dyndns.org>
Reduce the noise in the log.
* src/server/connections.c (read_from_connection): Don't report
ETIMEDOUT errors, as they seem to be quite common.
Generate two now forms of extracted grammars. Publish them on the
web. Mention them in Protocol-A.texi.
* doc/Protocol-A.texi (Extracted grammar): New appendix that
discusses the extracted files.
* doc/Makefile.am (update-www): Depend on protocol-a-full.txt, so
that checkargs.py is run first. Copy the generated grammars to
the web dir.
(protocol-a-full.txt): New target.
* doc/checkargs.py: Generate protocol-a-recommended.txt and
protocol-a-current.txt.
(prot_a_type.__init__): Initialize __recommended to 0.
(prot_a_type.use): New argument: recommended. All callers
updated. Set the __recommended flag once a recommended request or
async uses this type.
(prot_a_builtin.use_recurse): Ditto.
(prot_a_type.recommended): New method.
(lexer.__parse_type): Replaced the protover arguemnt with a
request object. All callers updated.
(lexer.__parse_request_arg): Ditto.
(generate_stable_output): New argument: filename,
only_recommended.
(generate_summary_output): New function.
* doc/constructs.expected: Updated.
2003-08-28 Kent Engstrm <kent@lysator.liu.se>
Add support for the "html" alternative of mx-refuse-import.
* run-support/aux-items.conf: Update validation regexp. Also
set the unique flag to false.
* doc/Protocol-A.texi (Aux-Item Types): Document "html".
* doc/constructs.expected: Add @code{html}.
2003-08-28 Per Cederqvist <ceder@ceder.dyndns.org>
Don't crash if a person has read more than 65535 texts after the
first unread.
* src/server/ram-parse.c (fparse_read_range_0): Use int, not
short, in case a person has read many texts after the first unread
text.
Complete the renaming of aux.h.
* scripts/lyskomd-copyrights: src/server/aux.h has been renamed to
src/server/aux-no.h.
Fix several minor errors in Protocol-A.texi.
* doc/Protocol-A.texi (Protocol Requests): The status codes for
who-is-on-ident and get-session-info-ident were "r" but should
have been "O".
(login-old): Added info about when this request became obsolete in
the section.
(get-person-stat-old): Ditto.
(lookup-name): Ditto.
(get-conf-stat-older): Ditto.
(mark-text-old): Ditto.
(who-is-on-old): Ditto.
(broadcast): Ditto.
(get-session-info): Ditto.
(re-lookup-person): Ditto.
(re-lookup-conf): Ditto.
(lookup-person): Ditto.
(lookup-conf): Ditto.
(query-read-texts-10): Ditto.
(get-membership-10): Ditto.
(set-connection-time-format): Fixed typo in the @section heading.
(Asynchronous Messages): The status codes for async-new-text-old
was "r" but should have been "O".
(async-new-text-old): Added async number to the @section heading.
(async-i-am-off): Ditto.
(async-i-am-on-obsolete): Ditto.
(async-new-name): Ditto.
(async-i-am-on): Ditto.
(async-sync-db): Ditto.
(async-leave-conf): Ditto.
(async-login): Ditto.
(async-broadcast): Ditto.
(async-rejected-connection): Ditto.
(async-send-message): Ditto.
(async-logout): Ditto.
(async-deleted-text): Ditto.
(async-new-text): Ditto.
(async-new-recipient): Ditto.
(async-sub-recipient): Ditto.
(async-new-membership): Ditto.
(async-new-user-area): Ditto.
(async-new-presentation): Ditto.
(async-new-motd): Ditto.
(async-text-aux-changed): Ditto.
Generate a stable machine-readable file with the syntax of
Protocol A.
* doc/checkargs.py (defined_request_names): New variable.
(defined_request_names): New variable.
(defined_async_names): New variable.
(set_values): New variable.
(tt): New variable.
(tr): New variable.
(rt): New variable.
(rr): New variable.
(at): New variable.
(ar): New variable.
(has_suffix): New function.
(remove_suffix): New function.
(prot_a_type.__init__): Initialize __protover.
(prot_a_type.line_no): Renamed from line().
(prot_a_type.use): New argument: protover. All callers
and derived methods updated.
(prot_a_builtin.use_recurse): Ditto.
(prot_a_type.protover): New method.
(prot_a_simple.base_type): New method.
(prot_a_simple.array): New method.
(prot_a_alternate.type_a): New method.
(prot_a_alternate.type_b): New method.
(prot_a_struct.fields): New method.
(prot_a_bitstring.add_field): Store the bits in the order they are
defined.
(prot_a_bitstring.bits): New method.
(prot_a_selection.fields): New method.
(prot_a_enumeration_of.base_type): New method.
(prot_a_msg): New class.
(prot_a_request): New class.
(prot_a_async): New class.
(menu): New class.
(reader.menu_re): New constant.
(reader.getc_eofok): If a menu line for a request or async message
is found, store the information.
(reader.menu): New method.
(lexer.section_re): New method.
(lexer.__init__): __implemented_conftypes and
__implemented_privbits both maps to None, not a random number.
(lexer.run): If __toplevel_at() returns a non-None value, return
it.
(lexer.__toplevel_at): Return the result of the called "toplevel_"
method instead of always returning None.
(lexer.toplevel_set): New method.
(lexer.toplevel_section): New method.
(lexer.toplevel_findex): Store information about the request in a
prot_a_request instance. Check the corresponding @section heading
and @menu item.
(lexer.toplevel_amindex): Ditto for asyncs.
(lexer.__parse_async): New API.
(lexer.toplevel_bye): Generate stable names. Return the error
flag instead of calling sys.exit().
(lexer.__parse_request): New API.
(lexer.__parse_type): New argument: protover.
(lexer.__parse_request_arg): Ditto. Return the parsed info.
(lexer.__bad_arg): Fixed minor typo.
(lexer.generate_stable_names): New method.
(generate_stable_output): New function.
2003-08-26 Per Cederqvist <ceder@ceder.dyndns.org>
* Release 2.1.1.
2003-08-25 Per Cederqvist <ceder@ceder.dyndns.org>
Release administrativa.
* versions (SERVER-VERSION): Set to 2.1.1.
(SERVER-COMPAT-VERSION): Set to 20101.
* configure.in: Set version 2.1.1.
* NEWS: Updated for the 2.1.1 release.
Fix the installation instructions.
* README: Tell the admin to run "komrunning start" if upgrading.
Create var/lyskomd/exportdb during install. (Bug 1119).
* run-support/Makefile.am (install-data-local): Create
var/lyskomd/exportdb.
Rename aux.h to aux-no.h. (Bug 1116).
* src/server/Makefile.am (aux-no.h): New name for former "aux.h".
The name "aux.h" isn't legal on the operating systems Cygwin runs
on top of. All references to aux.h in this file updated.
* src/server/.cvsignore: aux.h has been renamed aux-no.h.
* src/server/aux-items.c: Ditto.
* src/server/text.c: Ditto.
Added some missing auxiliary files to the distribution.
* src/libraries/adns/Makefile.am (EXTRA_DIST): Added changelog.
* src/libraries/adns/client/Makefile.am (EXTRA_DIST): Added
.cvsignore.
* src/libraries/adns/src/Makefile.am: Ditto.
* src/libraries/liboop/Makefile.am: Ditto.
Added test cases for write errors.
* src/server/testsuite/lyskomd.0/49.exp: New file, that tests
client disconnect immediately before a write().
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
49.exp.
* src/include/services.h (server_sleep): New debug request.
* src/server/fncdef.txt: Added the debug call server_sleep.
* src/server/debug.c (server_sleep): New request.
Testsuite cleanup.
* src/server/testsuite/lyskomd.0/bug-52.exp: Fixed typo in
never-executed code.
* src/server/testsuite/lyskomd.0/47.exp: Fixed a typo in a
comment.
2003-08-24 Per Cederqvist <ceder@ceder.dyndns.org>
* Release 2.1.0.
2003-08-23 Per Cederqvist <ceder@lysator.liu.se>
Fixes for the web publication of Protocol A.
* doc/Makefile.am (protocol-a.info): Updated the rule to what
automake-1.7.6 would have generated. Don't generate the info file
in $(srcdir).
2003-08-23 Per Cederqvist <ceder@ceder.dyndns.org>
Set the release date.
* HACKING: Mention that the release date should be set.
* NEWS: Set the release date to tomorrow.
* doc/Protocol-A.texi (Document Edition History): Set the release
date to tomorrow.
Update copyright headers.
* <all files>: update the year in the copyright notice.
* scripts/lyskomd-copyrights: Ignore public domain files:
doc/kom-style.el
scripts/warnings.sed
Ignore tiny files:
scripts/definepath
scripts/unprefix
src/server/timewrap.h
Ignore generated files:
src/server/paths.h
doc/version.texi
Ignore user-supplied files:
src/server/testsuite/config/localcfg.exp
Ignore binaries:
src/server/testsuite/get-time-often
src/server/testsuite/test-sigjmp
src/server/testsuite/timeval-overflow
Ignore temporary files:
src/server/testsuite/lyskomd.0/aux-items-35.conf
src/server/testsuite/lyskomd.0/aux-items-46.conf
src/server/testsuite/lyskomd.0/aux-items-bad.conf
Ignore run-support/savecore-lyskom, not
run-support/savecore.
Don't claim copyright on a collection of compiler error messages.
* scripts/warnings.sed: Placed in the public domain.
Make all requests that takes a BOOL argument return bad-bool if
something besides 0 or 1 is sent by the client.
* doc/Protocol-A.texi (get-membership-old): Added error code
bad-bool.
(login): Ditto.
(re-z-lookup): Ditto.
(lookup-z-name): Ditto.
(who-is-on-dynamic): Ditto.
(get-membership-10): Ditto.
(query-read-texts): Ditto.
(get-membership): Ditto.
(set-connection-time-format): Ditto.
(Error Codes): Document error code bad-bool.
(Protocol Version History): Mention bad-bool.
(Document Edition History): Mention bad-bool.
* NEWS: Added info about bad-bool.
* src/include/kom-errno.h (enum kom_err): Added KOM_BAD_BOOL.
* src/server/manipulate.h (CHK_BOOL): New macro.
* src/server/session.c (login): Call CHK_BOOL for invisible.
(who_is_on_dynamic): Call CHK_BOOL for want_visible and
want_invisible.
(set_connection_time_format): Call CHK_BOOL for use_utc. Don't
use KOM_INDEX_OUT_OF_RANGE for that error.
* src/server/regex-match.c (re_z_lookup): Call CHK_BOOL for
want_persons and want_confs.
* src/server/person.c (query_read_texts): Call CHK_BOOL for
want_read_ranges.
* src/server/membership.c (get_membership_old): Call CHK_BOOL for
want_read_texts.
(get_membership_10): Ditto.
(get_membership): Call CHK_BOOL for want_read_ranges.
* src/server/conference.c (lookup_z_name): Call CHK_BOOL for
want_persons and want_confs.
* src/server/testsuite/lyskomd.0/01.exp: Expect bad-bool, not
index-out-of-range, from set-connection-time-format(2).
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
* src/server/testsuite/lyskomd.0/48.exp: New file: Test the
bad-bool error code.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
48.exp.
Make statement-like macros more robust.
* src/server/manipulate.h (CHK_CONNECTION): Use the "do ... while
(0)" construct to make this macro expand to exactly one statement.
(CHK_LOGIN): Ditto.
(CONF_ZERO): Ditto.
(CHK_EXIST): Ditto.
(GET_P_STAT): Ditto.
(VOID_GET_P_STAT): Ditto.
(GET_C_STAT): Ditto.
(VOID_GET_C_STAT): Ditto.
(GET_T_STAT): Ditto.
(VOID_GET_T_STAT): Ditto.
"make distcheck" lint.
* src/server/testsuite/lyskomd.0/Makefile.am (MOSTLYCLEANFILES):
Added aux-items-35.conf and aux-items-46.conf.
* doc/Makefile.am (MOSTLYCLEANFILES): Added Protocol-A.dvi.
* src/server/testsuite/lyskomd.0/35.exp: Store the temporary
aux-item file in lyskomd.0/aux-items-35.conf, instead of
35-aux.conf, just like other test files already do.
* src/server/testsuite/.cvsignore: Don't ignore 35-aux.conf.
* src/server/testsuite/lyskomd.0/.cvsignore: Ignore aux-items-35.conf.
* src/server/testsuite/lyskomd.0/46.exp: Remove the temporary file
before copying files to it, to avoid permission problems if the
files in the source tree has read-only permissions.
Updated the copyright-updating scripts.
* scripts/update-copyright: Updated copyright heading.
* scripts/lyskomd-copyrights: Updated copyright heading. Don't
update copyright headers of adns or liboop.
Update version numbers.
* HACKING: Updated where version numbers are found.
* configure.in: Set version 2.1.0.
* versions (PROTOCOL-A-LEVEL): 11.
(SERVER-VERSION): 2.1.0.
(SERVER-COMPAT-VERSION): 20100.
* doc/Protocol-A.texi (PROTOEDITION): Set to 11.0.
(PROTOVER): Set to 11.
(VERSION): Set to 2.1.0.
(Client-Server Dialog): Talk about "version 10 or newer", not
only "version 10".
Release administrativa.
* NEWS: Updated for the 2.1.0 release.
* HACKING: Mention that our automake patch is obsolete.
* README: Some minor errors fixed. Ask the reader to vote for the
bugs he considers important.
Update the protocol and document history of Protocol A.
* doc/Protocol-A.texi (Future changes): Don't mention bugs that
are closed. Mention that the list of included bugs is
incomplete.
(Protocol Version History): Document version 11.
(Document Edition History): Document edition 11.0.
* doc/constructs.expected: Updated.
Revert the Xenofarm automount workaround.
* src/server/connections.c (dump_connections): Revert the
automount workaround attempt. It didn't work, and it also
introduced an endless loop.
2003-08-22 Per Cederqvist <ceder@ceder.dyndns.org>
Keep track of clients that are beind killed, and don't re-add them
to the kill list. (Bug 1100).
* src/server/internal-connections.h (get_conn_by_number): Document
that it returns NULL if the session doesn't exist.
* src/server/internal-connections.c (init_connection): Set the new
kill_status field of Connection instead of the old kill_pending
field.
(new_client): Ditto.
(check_conn_exists): Dead code removed.
(get_conn_by_number): Don't crash if no connections exist. It
isn't abnormal if the supplied connection number doesn't exist, so
remove code inside NDEFENSIVE_CHECKS that assumed it was.
Whitespace fixes.
* src/server/connections.h (enum kill_state): New enum.
(Connection): Replaced the "Bool kill_pending" field with a "enum
kill_stat kill_status" field.
* src/server/connections.c (check_kill_flg): Use the new
kill_status field of Connection instead of the old kill_pending
field.
(read_from_connection): Ditto.
(add_to_kill_list): Ditto. Don't add the client if it is dying.
Update var/lyskomd.clients when the handshake completes by a DNS
response.
* src/server/connections.c (dns_resolution): If the DNS resolution
completed the handshake, dump out the connections again to reflect
that fact.
Test for bug 1100.
* src/server/testsuite/lyskomd.0/47.exp: New file: Test client
disconnect while logged in and receiving async-logout.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
47.exp.
Xenofarm automount workaround.
* src/server/connections.c (dump_connections): If the rename of
the file fails with ENOENT, retry it a few times before giving
up. This is an attempt to work around an automount problem on the
Xenofarm at Lysator.
Fixed an error in the new function l2gi_prev().
* src/server/local-to-global.c (l2gi_prev): Don't read memory
before the start of an array.
Make dump_connections() static.
* src/server/internal-connections.h (dump_connections): Removed.
* src/server/connections.c (dump_connections): Now static.
New requests: local-to-global-reverse and
map-created-texts-reverse. (Bug 1092).
* doc/Protocol-A.texi (Mapping Local to Global Text Numbers):
Renamed the field "later-texts-exists" in "Text-Mapping" to
"more-texts-exists", so that it is useful for the new requests
defined below. Updated the descriptions of some fields for the
same purpose.
(local-to-global): Added a link to local-to-global-reverse.
(map-created-texts): Added a link to map-created-texts-reverse.
(set-connection-time-format): Added a missing protocol number.
(local-to-global-reverse): New request.
(map-created-texts-reverse): New request.
* src/server/fncdef.txt: Added local_to_global_reverse and
map_created_texts_reverse.
* src/include/services.h (map_created_texts_reverse): New
request.
(local_to_global_reverse): New request.
* src/server/text.c (local_to_global_reverse): New function.
* src/server/person.c (map_created_texts_reverse): New request.
* src/include/kom-types.h (Text_mapping_reverse): New struct.
* src/server/prot-a.c (prot_a_reply): Handle
rt_text_mapping_reverse.
* src/server/prot-a-output.h, src/server/prot-a-output.c
(prot_a_output_text_mapping_reverse): New function.
* src/server/connections.h (enum res_type): Added
rt_text_mapping_reverse.
(union result_holder): Added text_mapping_reverse.
* src/server/testsuite/renumber.el
(renumber-lyskom-send-simple-expect-indented): New function.
* src/server/testsuite/lyskomd.0/00.exp: Added test cases for
local-to-global-reverse and map-created-texts-reverse.
* src/server/testsuite/lyskomd.0/01.exp: Ditto.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
Added support for reverse local-to-global iterators.
* src/include/kom-types.h (L2g_reverse_iterator): New struct.
* src/server/local-to-global.h (l2gi_searchsome_reverse): New
function.
(l2gi_prev): New function.
* src/server/Makefile.am (check-l2g): New target.
* src/server/local-to-global.c (find_block_index_key_reverse): New
static function.
(l2gi_searchsome_reverse): New function.
(l2gi_prev): New function.
* src/server/testsuite/test-l2g.c (main): Handle command "b", for
testing backwards iterators. ("r", "R", and "I" were all taken).
* src/server/testsuite/l2g.0/07.exp: Added test cases for reverse
iterators.
* src/server/testsuite/l2g.0/10.exp: Ditto.
* src/server/testsuite/l2g.0/11.exp: Ditto.
2003-08-20 Per Cederqvist <ceder@ceder.dyndns.org>
Code cleanup. (Bug 1097).
* src/server/aux-items.c (find_linked_aux_item_list): Removed all
traces of PERS_OBJECT_TYPE.
(mark_linked_object_as_changed): Ditto.
* src/include/kom-types.h (enum object_type): Removed all traces
of PERS_OBJECT_TYPE. Don't explicitly specify the values of the
constants, since they don't matter.
Fix output of linefeed in Protocol A examples. (Bug 376).
* doc/Protocol-A.texi (Connecting to the Server): Say "linefeed",
not "newline" or "line feed".
(create-text): Ditto.
(Reformattable Text (text/x-kom-basic)): Ditto.
(The User Area): Ditto.
(Text formatting): Ditto.
(Protocol Version History): Ditto.
(get-text): Use "@bullet{}" to represent linefeed characters
inside hollerith strings.
(create-text-old): Ditto.
(create-anonymous-text-old): Ditto.
* doc/constructs.expected: Updated.
Return the error code long-array instead of a protocol error if
a too long array is sent to mark-as-read. (Bug 836). Get rid of
c_local_text_no_p -- use Number_list instead.
* src/server/fncdef.txt (mark_as_read): Changed the argument from
"num num c_local_text_no_p" to the more modern "num num_list".
* src/include/services.h (mark_as_read): Changed the arguments
"int no_of_text; const Local_text_no *text_arr" into a single more
modern-style Number_list argument.
* src/server/membership.c (mark_as_read): Changed the arguments
"int no_of_text; const Local_text_no *text_arr" into a single more
modern-style Number_list argument. Return KOM_LONG_ARRAY if the
array is too long. Simplified the code.
(set_read_ranges): Call CHK_CONNECTION before checking the
supplied read_ranges.
* src/server/prot-a.c (prot_a_init): Removed
handling of c_local_text_no_p.
(prot_a_destruct): Ditto.
* src/server/prot-a-parse-arg-c.awk: Removed
handling of c_local_text_no_p.
* src/server/internal-connections.c (init_connection): Removed
handling of c_local_text_no_p.
(kill_client): Ditto. But do check for left-over data in
num_list.
* src/server/connections.h (Connection): Removed
c_local_text_no_p.
* src/server/connections.c (free_parsed): Removed handling of
c_local_text_no_p.
* src/server/call-switch.awk: Removed handling of
c_local_text_no_p.
* src/server/testsuite/lyskomd.0/29.exp: Don't expect bug 836.
Send mail using sendmail, to avoid malformed mails. (Bug 185).
Make the path to sendmail configurable. Make it possible to turn
off mail delivery completely.
* configure.in: Search for a sendmail binary.
* doc/lyskomd.texi (Parameters): Document "sendmail path".
* src/server/param.h (struct kom_par): Added sendmail_path.
* src/server/server-config.c (parameters): Added "sendmail path".
(read_configuration): Handle it.
* src/server/updateLysKOM.c (checkstatus): Send mail by opening a
pipe to "sendmail -t". That is more portable than pipeing a
message into "mail". Turn off mail delivery completely if
"sendmail path" is set to ":".
* src/server/Makefile.am (paths.h): Write SENDMAIL_PATH.
Test suite: Don't forget to distribute aux-items-bad.conf.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
aux-items-bad.conf.
Fix text_read_access() so that it uses the privileges of the
supplied connection, and never uses active_connection. (Bug 178).
Fixing this also required me to remove the ability to specify an
faq-text for a freshly created person on a session where nobody is
logged on; this could be considered a security fix.
* src/server/text.c (person_text_read_access): Removed. Integrate
the functionality inteo text_read_access.
(text_read_access): Use the supplied Connection for all checks.
Don't use active_connection, ENA, ACTPERS or ACT_P. Fail and log
an error message if the Connection is NULL. Use is_supervisor()
instead of is_supervisor_2().
* src/server/manipulate.h (is_supervisor_2): Removed.
(person_text_read_access): Removed.
* src/server/conference.c (is_supervisor_2): Removed.
* src/server/aux-items.c (aux_item_validate_existing_text): Don't
allow access to texts if you are not logged in. This change means
that create-person cannot accept aux-items with the
existing-readable-text validator if nobody is logged in. I think
this is more reasonable than the number of special cases in the
code that were needed to support the old functionality.
* src/server/testsuite/lyskomd.0/40.exp: Don't expect bug 178.
* src/server/testsuite/lyskomd.0/41.exp: Don't expect bug 178.
* src/server/testsuite/lyskomd.0/03.exp: Don't expect to be able
to create a person with an faq-text. Add the faq-text using a
modify-conf-info request instead. Test that creation of a new
person with a faq-text item really fails.
Keep track of the connection that is creating an aux-item, so that
ENA_C() and text_read_access() can be used. Get rid of broken
concept "owner", and introduced "subordinate" instead. (Bug 334).
Some other aux-item-related code cleanup.
* src/server/aux-items.h (Aux_item_validation_data): Removed
item_creator, object_creator and owner_check. Added
creating_conn and subordinate. Placed add_to_list,
start_looking_at and object_type inside #if 0..#endif, since they
are not currently used.
(aux_inherit_items):Removed arguments target_creator, creating
and object_type. Added argument subordinate. Changed type of
arguments object_no and object, since we know that they are a
Text_no and Text_stat, respectively.
(check_delete_aux_item_list): Renamed the "owner" argument
"subordinate".
(text_stat_check_add_aux_item): Removed the item_creator and
creating arguments. Added the creating_conn argument.
(conf_stat_check_add_aux_item_list): Ditto.
(system_check_add_aux_item_list): Ditto.
(conf_stat_check_add_aux_item): Declaration for undefined and
unused function removed.
(conf_stat_add_aux_item): Ditto.
* src/server/aux-items.c (aux_item_validate): Return Success, not
Bool. All callers updated.
(aux_item_add_perm): Removed the arguments item_creator,
object_creator and owner_check. Added the arguments creating_conn
and subordinate. All callers updated. Simplified the code. Use
is_supervisor() instead of is_strictly_supervisor() where
appropriate. Use the supplied connection instead of checking that
ACTPERS is the item_creator. Adjusted for the new contents of
Aux_item_validation_data.
(aux_inherit_items): Removed arguments target_creator, creating
and object_type. Added argument subordinate. Changed type of
arguments object_no and object, since we know that they are a
Text_no and Text_stat, respectively.
(filter_aux_item_list): Assert that the viewer_conn argument is
non-NULL.
(check_delete_aux_item_list): Renamed the "owner" argument
"subordinate".
(text_stat_check_add_aux_item_list): Removed the item_creator and
creating arguments. Added the creating_conn argument, and assert
it is non-NULL.
(conf_stat_check_add_aux_item_list): Replaced the "creator"
argument with "creating_conn". Argument assertions added.
(system_check_add_aux_item_list): Ditto.
(aux_item_validate_existing_text): Changed return type from Bool
to Success. Use person_text_read_access() only when necessary,
and add a comment explaining why it might happen.
* src/server/text.c (create_text_add_aux): Adjusted to new API of
aux_inherit_items().
(do_create_text): Adjusted to new API of
text_stat_check_add_aux_item_list().
(modify_text_info): Ditto.
* src/server/person.c (create_person_generic): Adjusted to new API
of conf_stat_check_add_aux_item_list().
* src/server/manipulate.h (text_read_access): Docstring updated.
(person_text_read_access): Docstring added.
* src/server/conference.c (do_create_conf): New argument:
creating_connection. All callers updated.
(modify_conf_info): Adjusted to new API of
check_delete_aux_item_list() and
conf_stat_check_add_aux_item_list().
* src/server/admin.c (modify_system_info): Adjusted to new API of
system_check_add_aux_item_list().
* src/server/testsuite/lyskomd.0/24.exp: Use good_bad_expect
instead of a "if {0}" construct. Don't expect it to fail. Fixed
a broken test outcome.
Added code to diagnose Success vs. Bool mixups.
* HACKING (Release generation): Use TYPE_CHECK_COMPILATION for
increased quality assurance.
* src/include/misc-types.h (TYPE_CHECK_COMPILATION): New
compilation switch.
(SUCCESS_AS_PTR): Ditto.
(Bool): Provide a pointer-based non-working implementation, that
can be used for compile-time checks, but not for running code.
(Success): Provide a pointer-based implementation. Switch to
using it, at least for now; this might give us good warnings from
the compilers.
* src/server/misc-types.c: New file. Implementation of the types
in misc-type.h.
* src/server/Makefile.am (libcheck_a_SOURCES): Added
misc-types.c.
(lyskomd_SOURCES): Ditto.
(komrunning_SOURCES): Ditto.
(updateLysKOM_SOURCES): Ditto.
(dbck_SOURCES): Ditto.
(splitkomdb_SOURCES): Ditto.
* src/server/testsuite/Makefile.am (test_l2g_LDADD): libcheck.a
must be linked twice.
(get_time_often_LDADD): Ditto.
Make etags find our documentation.
* Makefile.am (AM_ETAGSFLAGS): Use --declarations, so that the
tags command finds the documentation.
Include an Emacs indentation style for our code.
* doc/kom-style.el ("KOM"): New C style for c-add-style. This
sets up proper indentation for Emacs.
* doc/Makefile.am (EXTRA_DIST): Added kom-style.el.
Added more hacking documentation.
* doc/lyskomd.texi (The Database): Mention that untranslated
Swedish text exists.
(local-to-global): Ditto.
(Modifying Stored Types): Mention that dbck needs to be updated.
(Coding conventions): New section.
Document that send async-deleted-text, async-new-text,
async-new-text-old, async-new-recipient and async-sub-recipient
are sent to recipients of text linked to the relevant text.
The functionality was added 2003-01-13. (Bug 59).
* doc/Protocol-A.texi (Aux-Item Inheritance): Added a missing
parenthesis.
(async-new-text-old): Document that recipients of linked texts
also gets this message.
(async-deleted-text): Ditto.
(async-new-text): Ditto.
(async-new-recipient): Ditto.
(async-sub-recipient): Ditto.
2003-08-19 Per Cederqvist <ceder@ceder.dyndns.org>
Test permissons for setting the canonical-name aux-item.
* src/server/testsuite/lyskomd.0/45.exp: Test that only an enabled
admin can set a canonical-name aux-item on the system.
Improve aux-item documentation.
* doc/Protocol-A.texi (About Aux-Items): Reduce the amount of text
talking about aux-items on persons.
(Aux-Item Inheritance): New node.
* doc/lyskomd.texi (Aux-Item Definition File): Document that
author-only and supervisor-only has no effect on items placed on
the system.
Speed up the test suite slightly.
* src/server/testsuite/lyskomd.0/gen-19.py (DEBUG): Turn it off.
Improve documentation on set-connection-time-format, and make it
recommended.
* doc/Protocol-A.texi (Common Types): Mention that times can be
expressed in UTC if the set-connection-time-format request has
been used.
(get-last-text): Ditto.
(set-connection-time-format): Change the status from experimental
to recommended.
* doc/constructs.expected: Updated.
Fixed a crash in setup_timer().
* src/libraries/libmisc/timeval-util.c (setup_timer): Fixed a
fence error that triggered an assertion with a probability of one
in a million.
Warn about using SIGWINCH to read a new aux-item file. If there
is a syntax error, the server will abort.
* doc/lyskomd.texi (Parameters): Warn about Bug 1095.
(Signals): Ditto.
Test parsing of broken aux-items at runtime.
* src/server/testsuite/lyskomd.0/46.exp: New file: Test parsing a
broken aux-item file as a result of SIGWINCH.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
46.exp.
* src/server/testsuite/config/unix.exp (lyskomd_death): New
reason: "restart_kom".
* src/server/testsuite/lyskomd.0/aux-items-bad.conf: New file with
syntax errors.
2003-08-18 Per Cederqvist <ceder@ceder.dyndns.org>
Write test case for aux-item inheritance.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
45.exp.
* src/server/testsuite/lyskomd.0/45.exp: New file: Test aux-item
inheritance.
2003-08-17 Per Cederqvist <ceder@ceder.dyndns.org>
Simplified the statistics code. Don't crash if the time moves
backwards, but log a nice error message including how much the
time moved.
* src/server/connections.c (set_time): Log how much the time moves
backwards when it moves backwards.
* src/server/stats.h (check_all_stats): Removed.
* src/server/stats.c: Don't attempt to keep a running average.
Rounding errors are far too common. Recompute it whenever it is
requested instead. This results in simpler code as well.
(dump_stats): Removed.
(update_one_stat): Check if the time moves backward, to avoid
triggering an assertion.
(is_nonzero): Removed.
(check_all_stats): Removed.
* src/server/ramkomd.c (main): Removed calls to check_all_stats().
Simplify handling of the sent_by misc-info. Allow the supervisor
of the author and sender to modify or remove a recipient (Bug 966,
Bug 181 and Bug 1089). Don't allow a text to be both a footnote
and a comment of the same text at the same time (Bug 1090). Code
cleanup.
* doc/Protocol-A.texi (add-comment): Added error codes
already-comment and already-footnote.
(add-footnote): Added error codes already-comment.
* src/server/text.c (find_textlink): New static function.
(is_supervisor_of_sender): New static function.
(is_sender): Removed.
(is_comm_sender): Removed.
(is_comment_to): Removed.
(recp_sent_by): Removed.
(is_footnote_to): Removed.
(sender): Removed.
(do_add_footnote): New arguments: the Text_stat objects. All
callers updated.
(do_add_comment): Ditto.
(do_add_recipient): The text_s argument may no longer be NULL.
All callers updated.
(skip_recp): New simplified API.
(filter_secret_info): Use is_supervisor_of_sender() instead of
recp_sent_by(). Use the new API of is_supervisor().
(person_text_read_access): Use is_supervisor_2() instead of
is_supervisor() until bug 178 is fixed.
(create_text_add_miscs): New argument: new_stat. Pass it to
do_add_footnote(), do_add_comment() and do_add_recipient() for a
slight performance gain. All callers updated.
(delete_text): Use new API of is_supervisor().
(add_recipient): Allow the supervisor of the author to modify the
recipient (fixes bug 966). Allow the supervisor of the sender to
modify the recipient (fixes bug 181).
(sub_recipient): Use the new API of is_supervisor(). Allow the
supervisor of the sender to remove the recipient (fixes bug
1089).
(check_add_textlink): New helper function with the common parts of
add_comment() and add_footnote(). Don't allow a text to be both a
footnote and a comment of the same text at the same time (fixes
bug 1090).
(add_comment): Move code to check_add_textlink().
(sub_comment): Use find_textlink() instead of is_comment_to().
Use new API of is_supervisor(). Allow the supervisor of the
sender to remove the comment link.
(add_footnote): Use check_add_textlink() to simplify the code.
(sub_footnote): Use find_textlink() instead of is_footnote_to().
Use new API of is_supervisor().
* src/server/session.c (login_old): Use new API of
is_supervisor(). Simplify and reindent code.
(login): Ditto.
(disconnect): Ditto.
* src/server/person.c (set_passwd): Use new API of
is_supervisor(). Simplify and reindent code.
* src/server/membership.c (access_perm_helper): Use new API of
is_supervisor(). Simplify and reindent code.
(sub_member): Ditto.
(add_member_common): Ditto.
(do_get_members): Ditto.
* src/server/conference.c (is_supervisor): Replaced the Pers_no
and Person arguments with a Connection argument.
(is_supervisor_2): New function, with the old API of
is_supervisor().
(set_permitted_submitters): Use new API of is_supervisor().
(set_super_conf): Ditto.
* src/server/aux-items.c (filter_aux_item_list): Use new API of
is_supervisor().
(check_delete_aux_item_list): Ditto.
* src/server/manipulate.h (is_supervisor): Replaced the Pers_no
and Person arguments with a Connection argument.
(is_supervisor_2): New function, with the old API of
is_supervisor(). This is only used in one place, and will be
removed when bug 178 is fixed.
* src/server/testsuite/lyskomd.0/44.exp: Bugs 966, 181, 1089 and
1090 are now fixed.
* src/server/testsuite/lyskomd.0/14.exp: Bug 181 is now fixed.
Added test cases for bug 1090.
* src/server/testsuite/lyskomd.0/44.exp: Added test cases for bug
1090.
* src/server/testsuite/config/unix.exp (good_bad_expect): Handle
the case where the bad result contains only a success indicator
and a refno (such as "=1032").
Allow recipients to be converted in a few more cases.
* doc/Protocol-A.texi (add-recipient): The permission-denied error
code is given if you are not supervisor of the author, recipient
or sender. The condition used to be more restrictive.
Test suite fixes.
* src/server/testsuite/lyskomd.0/14.exp: Simplified the code by
using good_bad_expect.
* src/server/testsuite/lyskomd.0/41.exp: Fixed typo in a comment.
Added test cases for bug 181, bug 966 and bug 1089.
* src/server/testsuite/lyskomd.0/44.exp: New file, that tests
conversion of recipients from one type to another.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
44.exp.
Fixed dist error introduced yesterday.
* scripts/Makefile.am (EXTRA_DIST): Dont forget to distribute the
$(noinst_SCRIPTS).
2003-08-16 Per Cederqvist <ceder@ceder.dyndns.org>
Send and receive times in UTC, if the clients requests it.
(Bug 957).
* doc/Protocol-A.texi (set-connection-time-format): New request.
* src/include/services.h (set_connection_time_format): New
request.
* src/server/connections.h (Connection): Added use_utc.
* src/server/fncdef.txt: Added set_connection_time_format.
* src/server/text.c (get_last_text): Handle use_utc.
* src/server/session.c (set_connection_time_format): New
function.
* src/server/prot-a-output.c (prot_a_output_time): Handle use_utc.
* src/server/internal-connections.c (init_connection): Initialize
use_utc.
(new_client): Ditto.
* src/server/prot-a-parse.c (prot_a_parse_misc_info): This code
used to convert the broken-down time to a time_t using mktime().
The value was never used. Instead of introducing a portability
problem using by calling timelocal(), we now simply store a 0 in
the time field of rec_time and sent_at misc-infos.
* src/server/testsuite/lyskomd.0/01.exp: Test
set_connection_time_format.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
Installation fixes.
* README: Fixed minor error in upgrade instructions.
* run-support/Makefile.am (install-data-local): Create var/run,
which will hold the pid file.
New async: async-text-aux-changed. (Bug 910).
* doc/Protocol-A.texi (Client-Specific Aux-Item Types): Reserve
10200-10299 for private test use. Refer to Bugzilla.
(async-text-aux-changed): New async message.
* src/server/async.h (enum async): Added ay_text_aux_changed.
* src/server/prot-a-send-async.h, src/server/prot-a-send-async.c
(prot_a_async_text_aux_changed): New function.
* src/server/send-async.c, src/server/send-async.h
(async_text_aux_changed): New function.
* src/server/session.c (accept_async): Handle ay_text_aux_changed.
* src/server/text.c (send_async_text_aux_changed): New function.
(modify_text_info): Call it.
* src/server/testsuite/lyskomd.0/03.exp: Handle
async-text-aux-changed.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
43.exp.
* src/server/testsuite/lyskomd.0/43.exp: New file. Test
async-text-aux-changed.
Code cleanup.
* src/server/aux-items.c: Fixed indentation of bool operators.
(commit_aux_item_list_internal): Removed a redundant "continue".
(delete_aux_item_list): Fixed cut-n-paste errors in comments.
(aux_item_list_add_items): Simplified the code.
* src/server/prot-a-parse.c (prot_a_parse_misc_info_list): Fixed
a cut-n-paste error: wrong function name in log message.
* src/server/testsuite/lyskomd.0/00.exp: Removed the "test"
argument to one of the simple_expect, to help diagnose problems
where 127.0.0.1 isn't properly resolved.
The man-pages will stay.
* HACKING: It is good to have man-pages that refer to the real
documentation, so don't remove them. (Bug 77).
Refer to Bugzilla, not email. (Bug 724).
* All files: Change the phrase "Please mail bug reports to
bug-lyskom@lysator.liu.se." to "Please report bugs at
http://bugzilla.lysator.liu.se/."
Make config files refer to their documentation.
* run-support/aux-items.conf: Added a reference to the
documentation.
* run-support/config: Added a reference to the documentation.
Use better file names, so that lyskomd can be installed in /usr or
/usr/local. (Bug 66 and Bug 132).
* NEWS: Documented all changed path names.
* README: Removed the warning not to use /usr/local as the
prefix. Document how an upgrade should be made. Document what
needs to be done when upgrading from pre-2.1.0 to 2.1.0. The
binaries are now in "sbin", not "bin".
* Makefile.am (SUBDIRS): Moved scripts before doc.
* src/server/server-config.c (assign_path): New define for
assign_string.
(unassign_path): New define for unassign_string.
(parameters): Use assign_path and unassign_path for all path
parameters, to make them easier to find. Use default values from
paths.h instead of hardcoding the defaults in the file. A lot of
values have changed; see the summary in the NEWS file.
(CONFIG_FILE): Removed. This is now a define in paths.h.
(compiled_config_file): New constant.
(get_default_config_file_name): Use compiled_config_file instead
of CONFIG_FILE.
(free_default_config_file_name): Ditto.
* src/server/connections.h: Updated a comment.
* src/server/Makefile.am (MOSTLYCLEANFILES): Added paths.h.
(AM_CPPFLAGS): Removed the DEFAULT_PREFIX define. Use paths.h
instead.
(sbin_PROGRAMS): Was: bin_PROGRAMS.
(BUILT_SOURCES): Added paths.h.
(.gdbinit): Removed redundant "-f" option to $(RM).
(DEFP): New constant.
(paths.h): New target.
(server-config.o): Added explicit dependency on paths.h.
* scripts/unprefix: New script.
* scripts/definepath: New script.
* scripts/common.make (dbdir): Moved here from
db-crypt/db/Makefile.am.
(exportdir): New constant.
* scripts/Makefile.am (noinst_SCRIPTS): Added unprefix and
definepath. Moved lyskomd-copyrights and update-copyright here
from EXTRA_DIST.
* run-support/config: Mention that this is installed as
lyskomd.conf.
* run-support/Makefile.am (sbin_SCRIPTS): Renamed savecore to
savecore-lyskom, to avoid confusion with the /usr/bin/savecore
program on Solaris.
(MOSTLYCLEANFILES): Track the change.
(savecore-lyskom): Track the change.
(install-data-local): Install the config file as lyskomd.conf, not
config. Create the lyskomd.cores directory.
(uninstall-local): Track the name change of lyskomd.conf.
* src/server/testsuite/config/unix.exp (lyskomd_start): Use the
old path names, so that we don't have to update the entire test
suite.
* doc/lyskomd.texi: Updated the default paths to the new world
order.
* db-crypt/db/Makefile.am (dbdir): Moved to common.make.
Added man pages that refer to the Texinfo documentation for all
installed programs. Made the man pages static.
* doc/man/splitkomdb.8: New file.
* doc/man/savecore-lyskom.8: New file.
* doc/man/lyskomd.8: Removed the version number.
* doc/man/updateLysKOM.8: Removed the version number.
* doc/man/Makefile.am (man_MANS): Added savecore-lyskom.8 and
splitkomdb.8.
2003-08-15 Per Cederqvist <ceder@ceder.dyndns.org>
Distribution fix.
* mkmi: Always regenerate scripts/depcomp.
Xenofarm fix.
* src/server/testsuite/lyskomd.0/person-cov.exp: Added "DNS log
threshold: 3600" to support a certain slow Xenofarm computer.
Calculate the file name of the configuration file in a single
place. Related code cleanup.
* src/server/updateLysKOM.c (main): Use
get_default_config_file_name() to find the config file.
* src/server/splitkomdb.c (main): Ditto.
* src/server/komrunning.c (main): Ditto.
* src/server/dbck.c (main): Ditto.
* src/server/ramkomd.c (main): Ditto. Don't set read_config_file
-- nothing used the value.
* src/server/server-config.c (read_config_file): Variable removed.
(CONFIG_FILE): Now static.
(default_config): New static variable.
(get_default_config_file_name): New function.
(free_default_config_file_name): New function.
(DEFAULT_DBASE_DIR): Removed.
* src/server/param.h (read_config_file): Variable removed.
* src/include/kom-config.h (DEFAULT_DBASE_DIR): Removed.
(CONFIG_FILE): Removed.
(get_default_config_file_name): New function.
(free_default_config_file_name): New function.
Handle scheduling of different weights. The scheduling priority
must still be 0.
* doc/lyskomd.texi (Parameters): Document "Default priority", "Max
priority", "Default weight" and "Max weight".
* src/server/connections.h (Connection): New field: schedule.
* src/server/server-config.c (parameters): Added "Default
priority", "Max priority", "Default weight" and "Max weight".
(require_less_eq): New static function.
(read_configuration): Check the new parameters. For now,
max_priority must be set to 0, since connections.c can only handle
a single priority.
* src/server/param.h (struct kom_par): New fields:
default_priority, max_priority, default_weight, max_weight.
* src/server/internal-connections.c (init_connection): Initialize
the schedule.
* src/server/connections.c (login_request): Set the priority and
weight from param.default_priority and param.default_weight.
(adjust_penalty): Use the weight to reduce the penalty.
(get_scheduling): Return the actual scheduling information from
the connection.
(set_scheduling): Check the priority and weight against
param.max_priority and param.max_weight. Allow the user to change
them, as long as it is done within those limits. Store the new
values in the connection. Note: the current implementation cannot
handle more than one priority. The check for that is made in
server-config.c.
* src/server/testsuite/get-time-often.c (longopts): Added
--priority and --weight.
(main): Handle the new options.
* src/server/testsuite/lyskomd.0/01.exp: The new default weight is
20. The new maximum weight is 100.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
2003-08-14 Per Cederqvist <ceder@ceder.dyndns.org>
Added the set-scheduling and get-scheduling requests. The current
implementation only supports priority==0 and weight==1.
* doc/Protocol-A.texi (Session Information): Added Scheduling-Info.
(get-scheduling): New request.
(set-scheduling): New request.
(Error Codes): Added priority-denied, weight-denied and
weight-zero.
* src/server/prot-a.c (prot_a_reply): Handle rt_scheduling_info.
* src/server/prot-a-output.h, src/server/prot-a-output.c
(prot_a_output_scheduling_info): New function.
* src/server/fncdef.txt: Added get_scheduling and set_scheduling.
* src/server/connections.h (enum res_type): Added
rt_scheduling_info.
(union result_holder): Added scheduling_info.
* src/server/connections.c (get_scheduling): New request.
(may_change_scheduling): New static function.
(set_scheduling): New request.
* src/include/services.h (set_scheduling): New request.
(get_scheduling): New request.
* src/include/kom-types.h (Scheduling_info): New struct.
* src/include/kom-errno.h (enum kom_err): Added
KOM_PRIORITY_DENIED, KOM_WEIGHT_DENIED and KOM_WEIGHT_ZERO.
* src/server/testsuite/lyskomd.0/01.exp: Test get-scheduling and
set-scheduling.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
Test suite improvement.
* src/server/testsuite/Makefile.am
(../../libraries/adns/client/adnshost): New target.
(site.exp): Depend on adnshost, so that "make check" works even if
"make check" has not been run in the adns directory.
Minor doc fixes.
* doc/lyskomd.texi (Parameters): Document the default value of
"Low penalty". Removed some text that was left behind a
cut-n-paste operation.
(Adding a New Protocol Request): Added a CHK_CONNECTION call to
the example.
Changed status of set-keep-commented from experimental to
recommended.
* doc/Protocol-A.texi (Protocol Requests): Changed the status of
set-keep-commented from experimental to recommended.
(set-keep-commented): Ditto.
Clarify the description of get-stats-description and get-stats.
* doc/Protocol-A.texi (get-stats-description): State that this
always returns the same during a session, so clients can cache
this value aggressively.
(get-stats): Elaborate on the access-denied error code.
2003-08-13 Per Cederqvist <ceder@ceder.dyndns.org>
Use AM_PATH_PYTHON to find the Python interpreter. (Bug 329).
* configure.in: Use AM_PATH_PYTHON.
(HAVE_PYTHON): New automake conditional.
* HACKING: Use Automake 1.7.6 with a patch for better Python
handling.
* doc/Makefile.am (check-doc): Only perform the tests if
HAVE_PYTHON is set. Use $(PYTHON) instead of python. Print a
warning if HAVE_PYTHON isn't set.
* src/server/testsuite/Makefile.am (check-lyskomd): Only perform
the tests if HAVE_PYTHON is set. Use $(PYTHON) instead of python.
Print a warning if HAVE_PYTHON isn't set.
(check-leaks): Ditto.
(site.exp): Set python to the Python interpreter found by
configure.
* src/server/testsuite/lyskomd.0/Makefile.am ($(srcdir)/15.exp):
Use $(PYTHON) instead of python. Use the HAVE_PYTHON Automake
conditional.
($(srcdir)/19.exp): Ditto.
* src/server/testsuite/config/unix.exp (obtain_lock): Use $python
from site.exp instead of hardcoding "python".
(client_start): Ditto.
(client_start_fail): Ditto.
* scripts/xenofarm.sh: Removed tests for python. We should get a
warning message from "make check" if python is missing, but it
should still succeed.
Testsuite improvement.
* src/server/testsuite/lyskomd.0/37.exp: Added "DNS log threshold"
entries so that a slow DNS server won't interfere with this test.
Protocol-A.texi was incompatible with the texinfo.tex supplied
with Automake 1.7.6.
* doc/Protocol-A.texi (\tensltt): Define this command using TeX
syntax, and add a \global. I have only a vague idea what this
does, but it seems to work with texinfo.tex 2003-05-04.08.
Create scripts/common.make, and include it from all LysKOM
Makefile.am files. Move the RM setting to it. (Bug 851).
* scripts/common.make: New file, which contains makefile fragments
that all makefiles should include.
(RM): Moved this variable to this file.
* db-crypt/db/Makefile.am: Include common.make instead of setting
RM.
* doc/Makefile.am: Ditto.
* run-support/Makefile.am: Ditto.
* src/libraries/libeintr/Makefile.am: Ditto.
* src/server/testsuite/Makefile.am: Ditto.
* src/server/testsuite/lyskomd.0/Makefile.am: Ditto.
* Makefile.am: Include common.make.
* db-crypt/Makefile.am: Ditto.
* scripts/Makefile.am: Ditto.
* src/Makefile.am: Ditto.
* src/include/Makefile.am: Ditto.
* src/include/server/Makefile.am: Ditto.
* src/libraries/Makefile.am: Ditto.
* src/libraries/libansi/Makefile.am: Ditto.
* src/libraries/libcommon/Makefile.am: Ditto.
* src/libraries/libmisc/Makefile.am: Ditto.
* src/server/Makefile.am: Ditto.
* src/server/testsuite/config/Makefile.am: Ditto.
* doc/man/Makefile.am: Ditto.
Automake lint.
* configure.in: Use new-style call to AM_INIT_AUTOMAKE.
Implement find-next-conf-no and find-previous-conf-no.
(Bug 123).
* doc/Protocol-A.texi (Server Information): Refer to
find-previous-conf-no.
(find-next-conf-no): New request.
(find-previous-conf-no): New request.
* src/server/fncdef.txt: Added find_next_conf_no and
find_previous_conf_no.
* src/include/services.h, src/server/conference.c
(find_next_conf_no): New function.
(find_previous_conf_no): New function.
* src/server/testsuite/lyskomd.0/01.exp: Test find_next_conf_no
and find_previous_conf_no.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
* src/server/testsuite/lyskomd.0/41.exp: Ditto.
The test suite failed on really really slow computers.
* src/server/testsuite/config/unix.exp (lyskomd_start): Increase
the "Connect timeout" and "Login timeout" to 1 day, unless the
test specifies them. I suspect that the "Connect timeout"
interfered with a test on one of the slower members of the
Xenofarm.
* src/server/testsuite/lyskomd.0/38.exp: Fixed a race condition:
if the client was killed at the wrong time, the test would crash.
* src/server/testsuite/lyskomd.0/37.exp: Pass a $base_config to
lyskomd_start in the other place as well. The fix made on
2003-08-07 was incomplete.
Implement first-unused-conf-no and first-unused-text-no.
(Bug 121).
* doc/Protocol-A.texi (first-unused-conf-no): New request.
(first-unused-text-no): New request.
(Server Information): Refer to the new requests instead of
inferior ways to get the same information.
* src/include/services.h (first_unused_conf_no): New function.
(first_unused_text_no): New function.
* src/server/text.c (first_unused_text_no): New function.
* src/server/simple-cache.c (query_next_conf_no): New function.
* src/server/prot-a.c (prot_a_reply): Handle rt_conf_no.
* src/server/prot-a-output.h, src/server/prot-a-output.c
(prot_a_output_conf_no): New function.
* src/server/fncdef.txt: Added first_unused_conf_no and
first_unused_text_no.
* src/server/connections.h (enum res_type): Aded rt_conf_no.
(union result_holder): Added conf_no.
* src/server/conference.c (first_unused_conf_no): New function.
* src/server/cache.h (query_next_conf_no): New function.
* src/server/testsuite/lyskomd.0/01.exp: Test
114:first-unused-conf-no and 115:first-unused-text-no.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
* src/server/testsuite/lyskomd.0/41.exp: Ditto.
Makefile improvements that might help portability to
CYGWIN_NT-5.0.
* src/server/testsuite/Makefile.am (AM_CPPFLAGS): Added ../../..,
so that config.h is properly found.
* src/server/Makefile.am (aux.h): Don't append to a non-existing
file; use ">" instead of ">>" to create it.
2003-08-12 Per Cederqvist <ceder@ceder.dyndns.org>
Implement and use has_access() to simplify code. (Bug 723).
* src/server/manipulate.h, src/server/membership.c (has_access):
New function. This is a simple wrapper around access_perm that
simplifies the code.
* src/server/membership.c (filter_conf_no): Use has_access()
instead of access_perm() to simplify code.
(sub_member): Ditto.
(add_member_common): Ditto.
* src/server/text.c (filter_secret_info): Ditto.
(add_recipient): Ditto.
(sub_recipient): Ditto.
* src/server/send-async.c (async_new_name): Ditto.
(async_new_user_area): Ditto.
* src/server/regex-match.c (lookup_regexp): Ditto.
* src/server/person.c (do_query_read_texts): Ditto.
* src/server/conference.c (set_conf_errno): Ditto.
(lookup_name): Ditto.
(lookup_z_name): Ditto.
(do_lookup): Ditto.
(send_async_new_presentation): Ditto.
(send_async_new_motd): Ditto.
(modify_conf_info): Ditto.
* src/server/admin.c (send_message): Ditto.
* doc/lyskomd.texi (Adding a New Protocol Request): Fixed broken
code example. Use has_access() instead of access_perm().
lyskomd is now officially shut down via SIGTERM. (SIGHUP still
works, and SIGINT also shuts it down.) (Bug 808).
* doc/lyskomd.texi (Parameters): lyskomd is now officially shut
down by SIGTERM, not SIGHUP.
(Signals): Ditto. However, SIGHUP and SIGINT also works.
(Administration): Recommend SIGTERM, not SIGHUP.
(Bugs): Removed entry about terminating on SIGINT and SIGTERM.
* src/server/testsuite/config/unix.exp (lyskomd_death): The reason
"signal" now means SIGTERM. Also handle "sighup" and "sigint".
* src/server/updateLysKOM.c (checkstatus): Use SIGTERM, not
SIGHUP.
* src/server/sigflags.h: Updated a comment: SIGTERM is now the
official way to shut down lyskomd.
* src/server/ramkomd.c (server_init): Handle SIGTERM and SIGINT
the same way as SIGHUP: shut down.
(main): Ditto.
(sighandler_term): New name for former sighandler_hup. Log proper
message depending on which signal was used to shut down the
server.
* src/server/komrunning.c (shutdown_lyskom): Use SIGTERM, not
SIGHUP, to shut down lyskomd.
* src/server/connections.c: Updated a comment: SIGTERM is now the
official way to shut down lyskomd.
* src/server/testsuite/lyskomd.0/31.exp: Test to shut down the
server by both SIGTERM, SIGHUP and SIGINT.
* src/server/testsuite/lyskomd.0/07.exp: Use TERM instead of HUP
to shut down lyskomd.
* src/server/testsuite/lyskomd.0/11.exp: Ditto.
* src/server/testsuite/lyskomd.0/30.exp: Ditto.
* src/server/testsuite/lyskomd.0/37.exp: Ditto.
* src/server/testsuite/lyskomd.0/38.exp: Ditto.
* src/server/testsuite/lyskomd.0/39.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-48.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-52.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-810.exp: Ditto.
The same text can no longer be FAQ for the same conference twice.
(Bug 572).
* run-support/aux-items.conf (faq-conf): Added unique-data, so
that the same text cannot be faq for a conference more than once.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
bug-572.exp.
* src/server/testsuite/lyskomd.0/bug-572.exp: New file. Test that
the same text cannot be FAQ for the same conference more than
once.
Added support for aux-items that must contain a unique piece of
data.
* doc/lyskomd.texi (Aux-Item Definition File): Document
unique-data.
* src/server/aux-items.h (struct Aux_item_definition_s): Added
unique_data.
* src/server/aux-items.c (empty_aux_item_definition): Added
unique-data.
(simple_aux_item): Ditto.
(aux_item_add_perm): If aux_item_check_unique sets kom_errno,
don't override it.
(aux_item_check_unique): Check for unique_data violations.
* src/server/aux-item-def-parse.y (assign): Handle unique-data.
(parse_aux_item_definitions): Handle unique-data in the debug code
that prints the parsed aux-item.
"./configure && make install" no longer fails. (Bug 856).
* src/server/Makefile.am (connections.o): Add an explicit
dependency on prot-a-parse-arg.h so that "./configure&&make
install" works.
* HACKING: Before a release, a "./configure&&make install" check
should be made.
Test suite fix.
* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: Re-updated
expected leak count. Since the leak due to bug 689 is now
suppressed, it only shows up among the suppressions.
The get-boottime-info implementation caused compilation errors
unless DEBUG_CALLS was defined.
* src/server/simple-cache.c: services.h and manipulate.h are
always needed.
Added get-boottime-info. (Bug 6).
* src/server/testsuite/lyskomd.0/03.exp,
src/server/testsuite/lyskomd.0/01.exp: Test get-boottime-info.
* src/server/stats.h, src/server/stats.c (read_stat_value): New
function.
* src/server/simple-cache.c (boottime_info): New static variable.
(init_cache): Initialize boottime_info.
(get_boottime_info): New request.
* src/server/prot-a.c (prot_a_reply): Handle
rt_static_server_info.
* src/server/prot-a-output.h, src/server/prot-a-output.c
(prot_a_output_static_server_info): New function.
* src/server/fncdef.txt: Added get_boottime_info.
* src/server/connections.h (enum res_type): Added
rt_static_server_info.
(union result_holder): Added static_server_info.
* src/include/services.h (get_boottime_info): New request.
* src/include/kom-types.h (Static_server_info): New type.
* doc/constructs.expected: Updated.
* doc/Protocol-A.texi (Server Information): Document
Static-Server-Info.
(get-boottime-info): New request.
Measure the number of existing conferences and persons.
* src/server/testsuite/lyskomd.0/03.exp,
src/server/testsuite/lyskomd.0/01.exp: Test STAT_CONFS and
STAT_PERSONS.
* src/server/stats.h (enum stat_type): Added STAT_CONFS and
STAT_PERSONS.
* src/server/stats.c (name): Handle STAT_CONFS and STAT_PERSONS.
* src/server/simple-cache.c (init_cache): Update STAT_CONFS and
STAT_PERSONS.
* src/server/person.c (do_delete_pers): Update STAT_PERSONS.
(create_person_generic): Update STAT_PERSONS and STAT_CONFS.
* src/server/conference.c (do_delete_conf): Update STAT_CONFS.
(do_create_conf): Ditto.
* doc/Protocol-A.texi (Measured Properties): Added "confs" and
"persons".
2003-08-11 Per Cederqvist <ceder@ceder.dyndns.org>
Testsuite fixes.
* src/server/testsuite/lyskomd.0/41.exp: Code cleanup.
* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: Updated
expected suppressed leak count.
Test handling of the keep-commented field and its interaction with
the garb. Added the debug request backdate_comment_link. (Bug 902).
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
42.exp.
* src/server/testsuite/lyskomd.0/42.exp: New file. Test
keep-commented handling.
* src/server/fncdef.txt: Added backdate_comment_link.
* src/server/debug.c (backdate_comment_link): New debug request.
* src/include/services.h (backdate_comment_link): New debug
request.
Comments and footnotes now protect the parent text from being
garbed until the comment is keep_commented days old. (Bug 902).
* src/include/kom-types.h (Small_conf): Added keep_commented.
* src/server/cache.h (cached_get_keep_commented): New function.
* src/server/text-garb.c (saved_by_recipient): Code cleanup.
(find_comment_limit_and_age): New static function.
(saved_by_keep_commented): New static function.
(saved): Call saved_by_keep_commented.
* src/server/simple-cache.c (mark_conference_as_changed): Copy
the keep_commented field to the small_conf.
(setup_small_conf): Ditto.
(init_small_conf): Initialize keep_commented.
(cached_get_keep_commented): New function.
* src/server/dbck-cache.c (cached_get_keep_commented): New
function.
Code cleanup.
* src/server/conference.c: Fixed a cut-n-paste comment error.
Add a valgrind suppression.
* src/server/testsuite/lyskomd.supp: Added a suppression for a
known leak in regex_compile().
Reorganized text-garb.c for readability.
* src/server/text-garb.c (day_to_sec): New constant.
(default_save): New constant.
(saved_by_aux): New static helper function.
(saved_by_recipient): Ditto.
(saved_by_comment): Ditto.
(saved): Ditto.
(garb_text): Use the saved() function to simplify code.
2003-08-10 Per Cederqvist <ceder@ceder.dyndns.org>
Use valgrind-20030725. Use leak suppression to ignore harmless
leaks we cannot fix. (Bug 974).
* scripts/warnings.sed: Adjusted a line number.
* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: Updated for
valgrind-20030725.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: The possible
leaks are now suppressed.
* src/server/testsuite/config/unix.exp (check_valgrind): The
expected_leaks argument should now include the number of
suppressed memory leaks. Ignore up to 25 suppressed leaks. Don't
ignore any reachable leaks.
* src/server/testsuite/lyskomd.supp: Updated for
valgrind-20030725. Add suppressions of known harmless memory
leaks.
2003-08-08 Per Cederqvist <ceder@ceder.dyndns.org>
Implement async-new-motd. (Bug 906).
* doc/Protocol-A.texi (async-new-motd): New async message.
* src/server/async.h (enum async): Added ay_new_motd.
* src/server/session.c (accept_async): Handle ay_new_motd.
* src/server/send-async.h, src/server/send-async.c
(async_new_motd): New function.
* src/server/prot-a-send-async.h, src/server/prot-a-send-async.c
(prot_a_async_new_motd): New function.
* src/server/conference.c (send_async_new_motd): New function.
(do_set_etc_motd): Call it. Clean up variable names.
* src/server/testsuite/lyskomd.0/conference-cov.exp: Track change
in error message from do_set_etc_motd.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
41.exp.
* src/server/testsuite/lyskomd.0/41.exp: Test async-new-motd.
* src/server/testsuite/lyskomd.0/03.exp: Handle ay-new-motd.
* src/server/testsuite/lyskomd.0/40.exp: Fixed a broken comment.
Implement async-new-presentation. (Bug 904).
* src/server/session.c (accept_async): Handle ay_new_presentation.
* src/server/send-async.h, src/server/send-async.c
(async_new_presentation): New function.
* src/server/prot-a-send-async.h, src/server/prot-a-send-async.c
(prot_a_async_new_presentation): New function.
* src/server/conference.c (send_async_new_presentation): New
function.
(do_set_presentation): Call it. Clean up variable names, and
remember the text statuses of the old and new presentation so they
can be passed to send_async_new_presentation(). Include the text
number of the old presentation in the error message that is
printed if the old presentation lacks a mark.
* src/server/testsuite/config/unix.exp (client_good_bad_expect):
New proc.
(client_extracting_expect): New proc.
* src/server/testsuite/lyskomd.0/03.exp: Handle
async-new-presentation.
* src/server/testsuite/lyskomd.0/40.exp: async-new-presentation is
now implemented. Expect bug 178.
* src/server/testsuite/lyskomd.0/conference-cov.exp: Track change
in error message from do_set_presentation.
Document async-new-presentation and write a test suite for it.
(Bug 904).
* doc/Protocol-A.texi (async-presentation-changed): New async.
* src/server/async.h (enum async): Added ay_new_presentation.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
40.exp.
* src/server/testsuite/lyskomd.0/40.exp: Test async-new-presentation.
* src/server/testsuite/config/unix.exp (client_expect): New proc.
2003-08-07 Per Cederqvist <ceder@ceder.dyndns.org>
The test suite failed on really really slow computers.
* src/server/testsuite/lyskomd.0/37.exp: Pass a $base_config to
lyskomd_start, since we don't want lyskomd_start to modifiy the
compiled-in default of "Sync interval".
* src/server/testsuite/config/unix.exp (lyskomd_start): Set the
"Sync interval" to 1 day, so that it doesn't interfere with the
tests. Added a colon to the strings that extra_config is checked
against, so that parameters that are prefixes of other parameters
are handled correctly.
Stats improvements.
* src/server/stats.c: The "updates" field now counts incremental
updates of avenrun.
(update_history): Adjusted.
(update_one_stat): Adjusted.
(check_one_stat): Adjusted.
Make it easier to change the file descriptor reserved for
valgrind. Don't use a file descriptor that interferes with the
test suite.
* src/server/testsuite/config/unix.exp (PROTECTED_FDS): Added a
comment that refers to ../Makefile.am. Check that valgrind_fd is
set properly.
(lyskomd_host): This is now set in site.exp, not here.
(l2g_start): Use valgrind_fd instead of hardcoding the value.
(spawn_lyskomd): Ditto.
(dbck_run): Ditto.
* src/server/testsuite/Makefile.am (VALGRIND_FD): New constant,
set to 21. Added a comment that refers to PROTECTED_FDS in
unix.exp.
(site.exp): Set lyskomd_host to whatever 127.0.0.1 resolves to,
or 127.0.0.1 if it cannot be looked up at all. Set valgrind_fd to
the constant defined in VALGRIND_FD.
(valgrind.wrap): Use VALGRIND_FD, instead of hardcoding the value
in two places. Changed the valgrind file descriptor to 21, which
is currently the highest reserved file descriptor.
(check_DATA): Was: noinst_DATA. site.exp should not be built
until adnshost is built, and the other stuff in noinst_DATA was
also not needed until check time.
Don't log simple reverse lookup errors for localhost, since they
interfere with the test suite and are fairly common and harmless.
* src/server/connections.c (dns_resolution): Don't log errors if
the lookup of localhost fails due to "nxdomain" or "inconsistent".
The AIX 4.2 and 4.3 builds have failed the tests for max open
clients since we enabled ADNS. Attempt to fix. But can they
really have an extra overhead of 8-9 file descriptors?
* src/include/kom-config.h (PROTECTED_FDS): Account for the two
file descriptors used by ADNS.
* src/server/testsuite/config/unix.exp: Ditto.
Send async-rejected-connection even to sessions where the reverse
DNS lookup hasn't completed yet.
* src/server/internal-connections.c (handshake_ok): Actually
ignore the dns_done field when told to do so.
2003-08-06 Per Cederqvist <ceder@ceder.dyndns.org>
Don't crash if shut down with a pending reverse DNS lookup.
* src/server/connections.c (dns_resolution): Don't re-enable idle
check during shutdown. Simplify code.
(toploop): Simplify code by using enable_idle_check().
Test suite: Obtain the name "localhost" using adns.
* src/server/testsuite/config/unix.exp (lyskomd_host): Use
adnshost to set it, so that it is set the same way as when lyskomd
is running.
Compile the adnshost program during "make check".
* src/libraries/adns/Makefile.am (SUBDIRS): Added client.
* src/libraries/adns/configure.in: Generate client/Makefile.
* src/libraries/adns/client/Makefile.am: New file. Compile
adnshost as part of the "make check" phase.
* src/libraries/adns/client/Makefile.in: Removed.
Document undocumented TeX code. (Bug 195).
* doc/Protocol-A.texi: Document some TeX code.
Fix the "make check" target in liboop.
* src/libraries/liboop/test-oop.c (get_name): Adjusted the call to
oop_adns_submit.
Use ADNS, so that IPv4 reverse DNS lookups are non-blocking.
Since ADNS does not yet support IPv6, reverse lookups of IPv6
addresses are still blocking. (Bug 627).
* src/server/prot-a.c (prot_a_parse_packet): Skip whitespace when
blocking the client waiting for a DNS reply.
* src/server/connections.c (parse_unparsed): Return immediately if
the session became blocked by DNS.
(dns_resolution): Schedule an idle check, as a client may have
become unblocked. Don't call isc_enable() here. Instead, add the
session to the run-queue. There may be pending input in the input
buffer. Handle ADNS errors.
(login_request): Check the return value of isc_resolve_remote().
(read_from_connection): Return if the session is blocked by DNS.
* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: After the
adns integration, we need to ignore 25 unreachable blocks.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: After the
adns integration, we need to ignore 25 unreachable blocks.
* src/server/testsuite/config/unix.exp (check_valgrind): After the
adns integration, we need to ignore 25 unreachable blocks.
Added the ability to do reverse queries to the oop adns adapter.
* src/libraries/liboop/oop-adns.h, src/libraries/liboop/adns.c
(oop_adns_submit): New argument: errcode.
(oop_adns_submit_reverse): New function.
2003-08-05 Per Cederqvist <ceder@ceder.dyndns.org>
Update testsuite: clients that hasn't completed the handshake
should be invisible.
* src/server/testsuite/lyskomd.0/connections-cov.exp:
Disconnecting a client that hasn't declared a protocol yet now
should fail.
"make clean" fix.
* src/server/testsuite/Makefile.am (MOSTLYCLEANFILES): Added
memory-usage-*.log.
Use a callback-based API for DNS lookup, in preparation for ADNS
integration. Block clients, and make them invisible for all other
clients, until the DNS lookup has completed.
* doc/lyskomd.texi (Files): Document the handshake_ok field of
connections.txt.
(Function Templates for send-async.c): Include a call to
handshake_ok() in prototype code.
(Traversing Connections): Ditto.
* src/server/session.c: All users of the hostname updated to get
it from the isc_scb.
(who_is_on): Removed dead code.
(who_is_on_ident): Ditto.
(who_is_on_dynamic): Removed dead code. Don't include sessions
until the handshake is completed.
(get_session_info): Don't include sessions until the handshake is
completed.
(get_static_session_info): Don't include sessions until the
handshake is completed.
(get_session_info_ident): Ditto.
(disconnect): Don't include sessions until the handshake is
completed.
(get_client_name): Ditto.
(get_client_version): Ditto.
* src/server/send-async.c (async_new_text_old): Use handshake_ok()
to check if it is OK to send the message to the client. As a
result, the message will not be sent until the DNS lookup has
completed.
(async_new_text): Ditto.
(async_i_am_on): Ditto.
(async_logout): Ditto.
(async_new_name): Ditto.
(async_forced_leave_conf): Ditto.
(async_login): Ditto.
(async_deleted_text): Ditto.
(async_new_recipient): Ditto.
(async_sub_recipient): Ditto.
(async_new_membership): Ditto.
(async_new_user_area): Ditto.
(async_garb_ended): Ditto.
(async_sync_db): Ditto, but ignore the DNS lookup.
(async_rejected_connection): Ditto.
* src/server/prot-a.c (prot_a_parse_packet): Disable the session
after the initial handshake if the dns resolution hasn't completed
yet.
* src/server/membership.c (send_async_new_membership): Indentation
fixed.
* src/server/internal-connections.h (enum ignored_conditions): New
enum.
(handshake_ok): New function.
* src/server/internal-connections.c (init_connection): Updated to
initialize all fields. Several were forgotten.
(kill_client): Clear the remote_ip.
(handshake_ok): New function.
* src/server/connections.h (Connection): Removed the hostname
field, since that is now stored as isc_session->remote. Added
dns_done, blocked_by_dns, and remote_ip.
* src/server/connections.c (dump_connections): Include a flag that
tells if the session has completed the handshake or not.
(dns_resolution): New function.
(get_host_name): Removed.
(login_request): Reorganized the code to use the new
callback-driven API of ISC host lookups.
* src/server/admin.c (shutdown_kom): Get the host name from the
isc_scb, now that the information is no longer stored in the
connection.
* src/libraries/libmisc/timeval-util.h,
src/libraries/libmisc/timeval-util.c (timeval_diff_d): New
function.
The session_start field of a Connection was used both to record
the connect time and the login/logout time. As a result, the
connection-time of a Static-Session-Info was not actually static.
Fixed by keeping track of the connect time and the login/logout
time separately.
* src/server/connections.h (Connection): Replaced the
session_start field with connect_time and login_time. All users
updated.
* src/server/session.c: (login_old): Set login_time, not connect_time.
(login): Ditto.
(logout): Use login_time, not connect_time.
(get_session_info): Use connect_time, not login_time, as the
connection_time.
(get_static_session_info): Use connect_time, not login_time, as the
connection_time.
(get_session_info_ident): Ditto.
* src/server/internal-connections.c (new_client): Set both
connect_time and login_time.
* src/server/connections.c (handle_accept_event): Call set_time(),
so that the connect_time is set correctly.
2003-08-04 Per Cederqvist <ceder@ceder.dyndns.org>
Don't leave whitespace in the input buffers.
* src/server/prot-a.c (prot_a_parse_packet): Delete leading and
trailing whitespace, to avoid having it linger in the input
buffer.
* src/server/prot-a-parse.h, src/server/prot-a-parse.c
(prot_a_parse_skip_whitespace): New function.
Code cleanup.
* src/server/isc-parse.c (parse_nonwhite_char): Use WHITESPACE
instead of hardcoding the string.
Xenofarm: warnings from <float.h>.
* scripts/warnings.sed: Ignore warnings from lenin.
Track the simplified API of ISC callback functions.
* src/server/ramkomd.c (handle_accept_event): Added a forward
declaration using the isc_accept_callback typedef.
* src/server/connections.h (handle_accept_event): Adjusted to the
new API of ISC callback functions.
* src/server/connections.c (write_err_cb): Adjusted to the new API
of ISC callback functions.
(stale_cb): Ditto.
(idle_cb): Ditto.
(login_request): Ditto.
(data_available_callback): Ditto.
(handle_accept_event): Ditto.
Slow DNS servers could interfere with the test suite.
* src/server/testsuite/config/unix.exp (lyskomd_start): Set the
"DNS log threshold" to one hour, to avoid that it interferes with
the test suite.
2003-08-03 Per Cederqvist <ceder@ceder.dyndns.org>
Track some minor cleanup of ISC. (Bug 916).
* src/server/ramkomd.c (server_init): Use the address stored in
listen_client->laddr instead of calling isc_getladdress().
* src/server/testsuite/lyskomd.supp: Removed a suppressions for
calling accept() with NULL pointers. ISC no longer does that.
Plug a memory leak in a test program.
* src/server/testsuite/get-time-often.c (tcp_connect): Plugged a
memory leak.
The idle timeouts interfered with some tests on slow computers.
Fix.
* src/server/testsuite/lyskomd.0/29.exp (startup): Set the idle
timeouts to 6 hours, to make sure that they do not interfere with
the test.
Bug fixes for the idle client disconnect.
* src/server/server-config.c (parameters): Changed "Connect
timeout" to 30 seconds. Changed "Login timout" to 30 minutes.
(read_configuration): Don't require the various idle timeouts to
be longer than the stale timeout.
* doc/lyskomd.texi (Parameters): Updated the description of the
idle timeouts.
* src/server/testsuite/lyskomd.0/39.exp: Extended: test each
timeout by itself. Removed the test that "Stale timeout" should
be less than the idle timeouts, since that is no longer required.
* src/server/testsuite/lyskomd.0/37.exp: Updated the expected
values for "Connect timeout" and "Login timeout", and fixed the
expected default suffix of "Active timeout".
Bug fixes for get-stats. (Bug 1072).
* src/server/stats.c (update_one_stat): The accumulator was not
updated in a proper way.
(update_stat): Update the ascending and descending values even
when the delta is 0, so that they are updated when the get-stats
request is issued.
2003-08-02 Per Cederqvist <ceder@ceder.dyndns.org>
Disconnect idle clients after a few days. (Bug 11).
* doc/lyskomd.texi (Parameters): Document "Connect timeout",
"Login timeout" and "Active timeout".
* src/server/server-config.c (parameters): Added "Connect timeout",
"Login timeout" and "Active timeout".
(require_less): New static function.
(read_configuration): Check that "Stale timeout" is smaller than
the three new timeouts.
* src/server/param.h (struct param): Added connect_timeout,
login_timeout and active_timeout.
* src/server/session.c (login_old): Set the idle timeout to
param.active_timeout.
(login): Ditto.
(logout): Set the idle timeout to param.login_timeout.
* src/server/ramkomd.c (server_init): Set the default idle timeout
to param.connect_timeout.
* src/server/prot-a.c (prot_a_parse_packet): Set the idle timeout
to param.login_timeout once the handshake is done.
* src/server/connections.c (idle_cb): New static function.
(login_request): Pass idle_cb() to isc_set_read_callback().
* src/server/testsuite/lyskomd.0/37.exp: Expect the new timeval
settings: "Connect timeout", "Login timeout" and "Active timeout".
* src/server/testsuite/lyskomd.0/39.exp: New file, with tests for
idle client disconnect.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
39.exp.
Fixed a race condition in the test suite.
* src/server/testsuite/config/unix.exp (client_start_fail): Don't
add an expect_always handler for eof. In some tests two or more
clients are supposed to die "at once", and this would lead to a
race condition.
(get_time_client_start): Ditto.
Test suite framework improvement.
* src/server/testsuite/config/unix.exp (extracting_expect): Report
the value that was found in the "pass" message. This may help
debugging.
Test suite: Made the "stalled client" test more robust.
* src/server/testsuite/lyskomd.0/38.exp: Set the sync interval to
1 day, to avoid spurious save async messages on slow hosts. Don't
change the timeout. Keep waiting as long as the server processes
new requests, even if it is so slow that it takes a long while for
the output queue to start filling up.
(req_rate): New proc.
* src/server/testsuite/lyskomd.0/38.exp: Made the test for a
stalled client more robust.
(monitor_progress): Shut down the client if a timeout occurs.
(send_queue_size): New proc.
* src/server/testsuite/get-time-often.c (reading_from_server): New
variable.
(request_limit): New variable.
(start_writing): New static function.
(start_reading): Ditto.
(stop_reading): Ditto.
(read_stdin): New command: start-reading.
(read_server): If do_write_only, just return OOP_HALT when eof,
EPIPE or ECONNRESET on the server is seen--don't print anything.
Print a message if more than request_limit replies are received.
(write_server): Made a log message unique.
(main): Use start_reading(), start_writing() and stop_reading() to
simplify the code. Don't do a final write; different Unixes
handles this in various strange ways, and we don't want to test
*them*.
Test suite fix.
* src/server/testsuite/lyskomd.0/38.exp: Use a small message size
and transmit queue.
Make the packet sizes and output queue parameters configurable.
* doc/lyskomd.texi (Parameters): Document "Max client message
size", "Max client transmit queue messages" and "Max client
transmit queue bytes".
* src/server/server-config.c (parameters): Renamed "Max client
transmit queue" to "Max client transmit queue messages". Added
"Max client message size" and "Max client transmit queue bytes".
* src/server/ramkomd.c (server_init): Call isc_cfg_queue_size().
Actually *use* param.maxqueuedsize and param.maxdequeuelen.
* src/server/param.h (struct param): Added maxmsgsize and
maxqueuedsize_bytes.
2003-08-01 Per Cederqvist <ceder@ceder.dyndns.org>
get-stats should never return a negative number.
* src/server/stats.c (check_one_stat): Fix the value if it has
become negative, even if the error isn't large enough to fix.
2003-08-01 Per Cederqvist <ceder@lysator.liu.se>
Fix struct timeval overflow problems on Linux/Alpha.
* src/libraries/libmisc/timeval-util.h,
src/libraries/libmisc/timeval-util.c (timeval_ctor): Changed type
of the sec argument from int to time_t.
* src/server/testsuite/lyskomd.0/37.exp: Handle the %g format now
created by timeval-overflow.
* src/server/testsuite/timeval-overflow.c (main): Use %g instead
of %f to print the numbers, to avoid overflow problems in the %f
representation.
2003-08-01 Per Cederqvist <ceder@ceder.dyndns.org>
More fixes to the test of stalled clients.
* src/server/testsuite/get-time-often.c (main): Actually retry
after a EAGAIN, EWOULDBLOCK or EINTR result from the final write.
Retry if it succeeds as well -- the server may just be slow
closing the socket.
Collect statistics of the read and write queues.
* doc/Protocol-A.texi (Measured Properties): Document
send-queue-bytes and recv-queue-bytes.
* src/server/stats.h (enum stat_type): Added STAT_SEND_QUEUE and
STAT_RECV_QUEUE.
* src/server/stats.c (name): Handle STAT_SEND_QUEUE and
STAT_RECV_QUEUE.
* src/server/ramkomd.c (write_queue_change_callback): New static
function. Update STAT_SEND_QUEUE.
(server_init): Register write_queue_change_callback with isc.
* src/server/internal-connections.c (kill_client): Update
STAT_RECV_QUEUE.
* src/server/connections.c (read_from_connection): Update
STAT_RECV_QUEUE.
* src/server/testsuite/lyskomd.0/01.exp: Test send-queue-bytes and
recv-queue-bytes.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
* src/server/testsuite/lyskomd.0/38.exp: Ditto.
Bug fix.
* src/server/connections.c (toploop): Cancel the timer for
check_kill_flag if needed during shutdown.
Don't be too efficient... (Back out part of the "ignore clients"
patch.)
* src/server/connections.c (read_from_connection): Revert part of
last change: flush the output even if the client is disconnecting.
We want it to have a chance see the reply to the disconnect or
shutdown request.
Test suite fix.
* src/server/testsuite/lyskomd.0/38.exp: Increased the timeout
for stalled client detection even further.
Fixed a memory leak during shutdown. Ignore clients that are
being killed more efficiently.
* src/server/connections.h (Connection): New field: kill_pending.
* src/server/internal-connections.c (init_connection): Initialize
kill_pending.
(new_client): Ditto.
* src/server/connections.c (add_to_kill_list): Check and update
kill_pending.
(check_kill_flg): Ditto.
(read_from_connection): Ignore connections with a pending kill.
(toploop): Call check_kill_flg() during shutdown if any kill is
pending, so that the kill list is freed.
Test suite fixes.
* src/server/testsuite/lyskomd.0/37.exp: Handle "Stale timeout".
* src/server/testsuite/lyskomd.0/38.exp: Use --write-only without
the --time-abort. Use the new "shutdown" command of
get-time-client. Allow the server half a minute to fill the
output queue for the --write-only test.
* src/server/testsuite/config/unix.exp (client_start_fail): Don't
call wait from expect_always code. It would wait on the wrong
process.
(client_start_fail): Ditto.
(get_time_client_start): Ditto.
* src/server/testsuite/get-time-often.c (read_stdin): Implement
the commands "ping" and "shutdown".
(write_server): Don't return OOP_HALT just because the socket to
the server is reset, but stop writing in that case.
(main): Allow --write-only without --time-abort. Retry the final
write up to 3 times if it fails with EPIPE, ECONNRESET or EINTR.
(main): Write more than a single byte in the final write.
Xenofarm: ignore more warnings.
* scripts/warnings.sed: Allow line numbers in floating point
comparison warnings from mathinline.h to differ.
Disconnect stale clients.
* doc/lyskomd.texi (Parameters): Document "Stale timeout".
* src/server/server-config.c (parameters): Added "Stale timeout".
* src/server/ramkomd.c (server_init): Configure the stale timeout
of ISC.
* src/server/param.h (struct kom_par): Added stale_timeout.
* src/server/connections.c (stale_cb): New static function.
(login_request): Pass stale_cb to isc_set_read_callback().
(setup_timer): Moved to timeval-util.h, and added a return value.
All callers updated to check it.
* src/server/testsuite/lyskomd.0/38.exp: Set the "Stale timeout"
to 10 seconds, so that we can test disconnection of a stalled
client in a reasonable time. Don't expect that test to fail.
* src/server/testsuite/get-time-often.c (abort_pending): New
static variable.
(do_write_only): Now global static, not a local variable in main.
(setup_timer): Removed. Use the one from libmisc instead.
(write_server): Handle ECONNRESET, EPIPE and end-of-file when only
writing.
(arm_timer): Check return value of setup_timer.
(end_it): Clear abort_pending.
(main): Set abort_pending if we are about to abort. Cancel the
timer if the top loop returns before the abort timer fires.
Treat ECONNRESET the same way as EPIPE.
Moved setup_timer() to libmisc.
* src/server/connections.h: (setup_timer): Moved to
timeval-util.h, and added a return value. All callers updated to
check it.
* src/libraries/libmisc/timeval-util.h,
src/libraries/libmisc/timeval-util.c (setup_timer): New function.
* src/libraries/libmisc/Makefile.am (AM_CPPFLAGS): Search liboop.
* src/server/text-garb.c (garb_callback): Check return value of
setup_timer.
2003-07-31 Per Cederqvist <ceder@ceder.dyndns.org>
Xenofarm tweak for asmodean.
* scripts/xenofarm.sh: Close file descriptor 21 on asmodean.
Don't access internal structures of isc.
* src/server/connections.c (add_to_kill_list): Use the new
isc_getoopsource() function instead of accessing the internals of
the isc_mcb structure.
(data_available_callback): Ditto.
Don't report expected rounding errors (near zero).
* src/server/stats.c (struct avg_status): New field: max_seen.
(dump_stats): Print the max_seen field.
(init_stats): Initialize it.
(update_history): Update it.
(check_one_stat): Take max_seen into account when deciding if a
message should be logged or not. Reset max_seen if a new value is
stored.
Test suite fix.
* src/server/testsuite/lyskomd.0/38.exp: Handle the "Resource
temporarily unavailable" error properly.
Xenofarm: ignore more warnings.
* scripts/warnings.sed: Ignore warnings from mathinline.h on
Linux.
Port to HP-UX 11.0.
* src/server/Makefile.am (lyskomd_LDADD): Add -lm, which is needed
for fpclassify on HP-UX 11.0.
Test handling of write-only clients. They should be disconnected
after a timeout, but that isn't implemented yet.
* src/server/testsuite/lyskomd.0/38.exp: Test handling of a
write-only client. It should be disconnected after a while.
* src/server/testsuite/config/unix.exp (get_time_client_start):
Replaced the "mode" argument with an "args" argument, that is a
list of arguments to pass to get-time-often.
* src/server/testsuite/get-time-often.c (main): Implement
--write-only.
Don't round stats too often.
* src/server/stats.c (check_one_stat): Fixed the logic that
determines if we need to fix a rounding error. Report the values
using %g instead of %f.
(is_nonzero): New static function.
(check_one_stat): Don't report very small rounding errors when the
correct value is 0.
Port to Solaris 2.4, which lacks snprintf.
* configure.in: Check for snprintf.
* src/server/prot-a-output.c (prot_a_output_float): Fall back to
using sprintf if snprintf isn't available.
Fix "pack" warnings in Xenofarm.
* scripts/xenofarm.sh: When searching for a program, put the
program in a subshell, so that we can reliably divert the "program
not found" error message to stdout. Use "find ... -print" instead
of "find ... -ls", since -ls is a GNU extension.
Xenofarm: ignore more warnings.
* scripts/warnings.sed: Ignore some Solars warnings.
Solaris stores ar in /usr/ccs/bin.
* src/libraries/adns/configure.in: Use the same check for the
``ar'' program that lyskom-server uses.
Fix Xenofarm error.
* scripts/xenofarm.sh: The log file from the "pack" task should be
named "packwarn.txt", not "sherr.txt".
2003-07-30 Per Cederqvist <ceder@ceder.dyndns.org>
Fixed link error in test suite.
* src/server/testsuite/Makefile.am (get_time_often_LDADD): Added
libcheck.a, to get getopt_long().
Improve test suite for busy clients.
* src/server/Makefile.am (libcheck_a_SOURCES): Added getopt.c and
getopt1.c.
* src/server/testsuite/lyskomd.0/38.exp: Test two simultaneous
get-time-client clients.
(slow): Removed.
(fast): Removed.
(monitor_progress): New proc.
* src/server/testsuite/get-time-often.c (last_progress_status):
New variable.
(parse_async): Fixed off-by-one parse error. Report parse errors
more verbosely.
(report_progress): New function. Report progress, but print
nothing unless we have received a new reply from the server since
the last time we were called.
(longopts): New constant.
(main): Use getopt_long to parse the arguments. Enable progress
report. Fixed a broken printf format string.
Don't crash if a client with queued request closes the
connection. Improve handling of busy clients.
* src/server/connections.c (write_err_cb): Increase the penalty,
so we don't process anything more from this client.
(read_from_connection): isc_disable() can fail. Handle that
case.
(check_idle_callback): Make sure the same connection is never
processed more than once during a call to this function.
2003-07-30 Per Cederqvist <ceder@lysator.liu.se>
The statistics was broken on platforms where sizeof(int) !=
sizeof(long).
* src/server/stats.c (dump_stats): Updated to cope with the
introduction of enum value_type.
(ind): Changed sign of the "offset" argument, since it is a bad
idea to store a negative number in an "unsigned int". All callers
updated.
(update_one_stat): Fixed the call to check_stat when DEBUG_STATS
is true.
(check_one_stat): If a rounding error occurs, log which enum
value_type that is responsible.
2003-07-28 Per Cederqvist <ceder@ceder.dyndns.org>
Fixed printf argument type.
* src/server/testsuite/get-time-often.c (main): The argument to a
"*" printf format string modifier should be an int, not an
ssize_t.
Revert last change to text-garb.c. Fixed the libisc API instead.
* src/server/text-garb.c: Don't include <sys/socket.h>. isc.h no
longer uses socklen_t in the exported API.
Increase timeout during the stress test.
* src/server/testsuite/lyskomd.0/38.exp: Use a very long timeout,
but only for a short while. Use client id 1, to avoid having to
clients with id 0 if the first one doesn't die.
(fast): New proc.
(slow): New proc.
Collect info about leaked memory even when valgrind isn't in use.
* src/server/testsuite/config/unix.exp (memix): New variable.
(check_memory_usage): Save the memroy-usage file if it indicates a
leak.
Don't log failure to write to a client that has closed the socket.
* src/server/connections.c (write_err_cb): Don't log EPIPE errors.
Include <sys/socket.h> before isc.h.
* src/server/text-garb.c: Include <sys/socket.h>, since isc.h now
needs it due to its use of socklen_t.
Added the beginnings of a stress test. This is work in progress,
but it already seems to expose a server bug...
* src/server/testsuite/lyskomd.0/38.exp: New test.
* src/server/testsuite/config/unix.exp (client_death): Removed
unneeded global statements for clientport, nl and deep_any.
(get_time_client_start): New proc.
(get_time_client_death): New proc.
(talk_to): Handle get_time_client.
* src/server/testsuite/get-time-often.c: New program, that
generates a *lot* of get-time requests.
* src/server/testsuite/Makefile.am (check_PROGRAMS): Added
get-time-often.
(get_time_often_SOURCES): New variable.
(get_time_often_LDADD): New variable.
(AM_CPPFLAGS): Make "oop.h" accessible.
(.gdbinit): Added oop and isc directories.
(EXTRA_DIST): Added 38.exp.
2003-07-27 Per Cederqvist <ceder@ceder.dyndns.org>
Measure statistics for the number of existing texts.
* doc/Protocol-A.texi (Measured Properties): Document "texts".
* src/server/stats.h (enum stat_type): Added STAT_TEXTS.
* src/server/stats.c (name): Handle STAT_TEXTS.
* src/server/text.c (do_delete_text): Update STAT_TEXTS.
(do_create_text): Ditto.
* src/server/simple-cache.c (init_cache): Call update_stat
with STAT_TEXTS to updated the number of existing texts.
* src/server/ramkomd.c (main): Moved the call to init_stats
earlier, so that we can count the existing texts while reading the
database.
* src/server/testsuite/lyskomd.0/01.exp: Check the "texts" stat.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
Fix a potential denial-of-service scenario.
* src/server/connections.c (login_request): Give the new client
maximum penalty to start with. It has to be connected a while to
earn the right to do anything.
Code cleanup.
* src/server/simple-cache.c (init_cache): Use a new local
variable, "record", to count the records in the database file.
Don't reuse the "ic" variable for that purpose.
2003-07-25 Per Cederqvist <ceder@ceder.dyndns.org>
Fixed "make check" for the documentation.
* doc/constructs.expected: Added @code{printf("%g", val);}.
* doc/checkargs.py (lexer.__init__): Added builtin type FLOAT.
(lexer.pushback): Pushback @cite.
* doc/Protocol-A.texi (Statistics): Fixed markup so that
checkargs.py likes it.
Changed 112=get_stats so that it returns average, ascent rate and
descent rate for each measured value. Return the values as FLOAT,
not a fixed-point value stored in an INT32.
* src/server/testsuite/lyskomd.0/01.exp: Updated for the new look
of get-stats and the new members of enum stat_type.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
* src/server/testsuite/config/unix.exp (any_float): New constant.
* src/server/stats.h (enum stat_type): Removed STAT_FIRST_EVENT,
STAT_PROCESSED_CALLS, STAT_PROCESSED_DNS, STAT_PROCESSED_IDENT,
STAT_RUN_QUEUE_ENTER, STAT_RUN_QUEUE_LEAVE. Added STAT_REQUESTS.
* src/server/stats.c (enum value_type): New enum.
(status): Added a new dimension: the type of the value (average,
ascending rate, or descending rate.
(copy): Ditto.
(init_stats): Handle the new dimension.
(update_one_stat): New static function, that updates a single
dimension.
(update_stat): Update the proper dimensions.
(check_one_stat): New static function, that checks a single
dimension.
(check_stat): Check all dimensions.
(name): Removed STAT_PROCESSED_CALLS, STAT_PROCESSED_DNS,
STAT_PROCESSED_IDENT, STAT_RUN_QUEUE_ENTER, STAT_RUN_QUEUE_LEAVE.
Added STAT_REQUESTS.
(get_stats): Now returns a Stats_list. Don't multiply the result
by 100.
* src/server/prot-a.c (prot_a_reply): Handle rt_stats_list.
* src/server/prot-a-output.h (prot_a_output_stats_list): New
function.
* src/server/prot-a-output.c (prot_a_output_float): New static
function.
(prot_a_output_stats): Ditto.
(prot_a_output_stats_list): New function.
* src/server/fncdef.txt: Changed return type of get_stats to
Stats_list.
* src/server/connections.h (enum res_type): Added rt_stats_list.
(union result_holder): Added stats_list.
* src/server/connections.c (queue_add): Don't update
STAT_RUN_QUEUE_ENTER.
(queue_remove): Don't update STAT_RUN_QUEUE_LEAVE.
(parse_unparsed): Update STAT_REQUESTS instead of
STAT_PROCESSED_CALLS.
(get_host_name): Don't update STAT_PROCESSED_DNS.
* src/include/services.h (get_stats): Changed return type to
Stats_list.
* src/include/kom-types.h (Stats): New struct.
(Stats_list): New struct.
* doc/Protocol-A.texi (Simple Data Types): New datatype: FLOAT.
(Statistics): Added the "Stats" data type.
Updated the description of the "when" field of
"Stats-Description".
(get-stats): Return an array of Stats, not INT32.
(Measured Properties): There are no longer two kinds of values.
2003-07-24 Per Cederqvist <ceder@ceder.dyndns.org>
Implement 111=get_stats_description and 112=get_stats.
* src/server/stats.h (check_all_stats): New name for former
check_stat.
* src/server/stats.c (check_stat): Only check a single
statistics. Now static.
(check_all_stats): New name for former check_stat. All callers
updated.
(name): New static function.
(get_stats_description): New protocol request.
(get_stats): New protocol request.
* doc/lyskomd.texi (Parameters): Documented "Statistic name
length".
* src/server/server-config.c (parameters): Added "Statistic name
length".
* src/server/ramkomd.c (main): Use check_all_stats instead of
check_stat.
* src/server/prot-a.c (prot_a_reply): Handle rt_stats_description.
* src/server/prot-a-output.h, src/server/prot-a-output.c
(prot_a_output_stats_description): New function.
* src/server/param.h (struct kom_par): Added stat_name_len.
* src/server/fncdef.txt: Added 111=get_stats_description and
112=get_stats.
* src/server/connections.h (enum res_type): Added
rt_stats_description.
(union result_holder): Added stats_description.
* src/include/services.h (get_stats_description): New request.
(get_stats): New request.
* src/include/kom-types.h (Stats_description): New data type.
* src/include/kom-errno.h (enum kom_err): Added
KOM_UNDEFINED_MEASUREMENT.
* doc/constructs.expected: Added @code{when} and @samp{X-}.
* doc/Protocol-A.texi (Statistics): New section.
(get-stats-description): New request.
(get-stats): New request.
(Error Codes): Documented undefined-measurement.
(Measured Properties): New chapter.
* src/server/testsuite/lyskomd.0/01.exp: Test
get-stats-description and get-stats.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
Collect more statistics.
* src/server/rfc931.c (get_real_username): Update the
STAT_IDENT_QUEUE and STAT_PROCESSED_IDENT statistics.
* src/server/stats.h (enum stat_type): Added STAT_DNS_QUEUE,
STAT_IDENT_QUEUE, STAT_PROCESSED_DNS and STAT_PROCESSED_IDENT.
* src/server/connections.c (logout_client): Update the
STAT_CLIENTS statistics.
(login_request): Ditto.
(get_host_name): Update the STAT_DNS_QUEUE and STAT_PROCESSED_DNS
statistics.
2003-07-23 Per Cederqvist <ceder@ceder.dyndns.org>
Fixed the overflow checking of timeval configuration parameters.
* src/server/conf-file.c (assign_timeval): The logic for detecting
overflow was wrong.
Code cleanup.
* src/server/aux-item-def-parse.y: Don't include <string.h>
twice.
Gather statistics on the run queue length and the number of
processed requests.
* src/server/Makefile.am (lyskomd_SOURCES): Added stats.h and
stats.c.
* src/server/stats.h, src/server/stats.c: New file, that collects
some statistical information about the operation of the server.
* src/server/ramkomd.c (main): Initialize the statistics
subsystem, and check the integrity of it during shutdown.
* src/server/connections.c (queue_add): Update statistics.
(queue_remove): Ditto.
(parse_unparsed): Ditto.
2003-07-22 Per Cederqvist <ceder@ceder.dyndns.org>
Don't redefine LIST_INIT on FreeBSD 4.8.
* src/libraries/adns/src/dlist.h (ADNS_LIST_INIT, ADNS_LINK_INIT)
(ADNS_LIST_UNLINK_PART, ADNS_LIST_LINK_TAIL_PART, ADNS_LIST_UNLINK)
(ADNS_LIST_LINK_TAIL): Appended the "ADNS_" prefix to make the
macro names more unique. LIST_INIT is already defined in
/usr/include/sys/queue.h:291 on FreeBSD 4.8. All users updated.
Added overflow checking of timeval configuration parameters, and
test cases for the error checking.
* src/server/conf-file.c (assign_timeval): Added overflow checking.
* src/server/testsuite/lyskomd.0/37.exp: Check for overflow, bad
suffixes, and negative values for time parameters.
* src/server/testsuite/timeval-overflow.c: New program that
creates a broken lyskomd config file with timeval overflows.
* src/server/testsuite/Makefile.am (check_PROGRAMS): Added
timeval-overflow.
(timeval_overflow_SOURCES): New target.
(check-lyskomd): Depend on timeval-overflow.
2003-07-18 Per Cederqvist <ceder@ceder.dyndns.org>
Find the included adns.h from liboop.
* src/libraries/liboop/Makefile.am (AM_CPPFLAGS): Added -I option
for adns.
Fix enum mis-match detected by the AIX 5.1 compiler.
* src/libraries/adns/src/parse.c (adns__parse_domain): The flags
argument should be a parsedomain_flags, not adns_queryflags. I
think.
Port adns to FreeBSD (and many others).
* src/libraries/adns/configure.in: Include <sys/types.h> before
<sys/select.h>.
Xenofarm improvements.
* scripts/xenofarm.sh: Save config.log and config.h from the adns
library.
Link lyskom-server against adns.
* configure.in: Added src/libraries/adns to AC_CONFIG_SUBDIRS.
* mkmi: Recreate configure and Makefile.in in adns.
* src/libraries/Makefile.am (SUBDIRS): Added adns.
* src/libraries/liboop/configure.ac: Unconditionally define
HAVE_ADNS.
* src/libraries/liboop/Makefile.am (liboop_a_SOURCES): Added
adns.c.
(test_oop_LDADD): Added libadns.a.
* src/server/Makefile.am (AM_CPPFLAGS): Include adns files.
(lyskomd_LDADD): Link with libadns.a.
Removed adns files that are generated by autoconf or automake.
* src/libraries/adns/Makefile.in: Removed.
* src/libraries/adns/acconfig.h: Removed.
* src/libraries/adns/aclocal.m4: Removed.
* src/libraries/adns/configure: Removed.
* src/libraries/adns/src/Makefile.in: Removed.
* src/libraries/adns/src/config.h.in: Removed.
* src/libraries/adns/src/.cvsignore: Added more files to ignore.
* src/libraries/adns/.cvsignore: Added more files to ignore.
Use Automake in adns for better integration with lyskoms-server.
Only re-implement what we need (no shared libraries, no programs,
no testsuite...)
* src/libraries/adns/configure.in: Updated for automake-1.5.1 and
autoconf-2.57. Removed DPKG_CACHED_TRY_COMPILE. Removed all
dynamic linking support. Removed support for client programs.
Use AC_C_INLINE instead of a hand-coded test for the same thing.
Add AH_VERBATIM for config.h. Only output Makefile and
src/Makefile.
* src/libraries/adns/acinclude.m4: New name for former
aclocal.m4.
* src/libraries/adns/Makefile.am: New Makefile template, which
compiles (and distributes) only the parts of adns that are needed
by the LysKOM server.
* src/libraries/adns/src/Makefile.am: Ditto.
* src/libraries/adns/settings.make.in: Removed. Use automake
instead.
Import adns-1.0.
* src/libraries/adns/README: Mention where the lyskom-server
ChangeLog can be found. Mention that only parts of the full adns
distribution is included here.
* src/libraries/adns/changelog: Ditto.
* src/libraries/adns: Imported adns-1.0.
2003-07-16 Per Cederqvist <ceder@ceder.dyndns.org>
Xenofarm: ignore more warnings.
* scripts/xenofarm.sh (makewarn): Remove spurious warnings from
fonda.roxen.com.
* scripts/warnings.sed: More updates.
Fixed all calls to isspace().
* src/server/conf-file.c (assign_timeval): Fixed the type of the
argument to isspace().
<malloc.h> is obsolete and produces a warning on FreeBSD 4.8.
Avoid including it.
* src/server/aux-item-def-parse.y: Include <stdlib.h> instead of
<malloc.h>.
* src/server/admin.c: Don't needlessly include <malloc.h>.
* src/server/debug.c: Include <malloc.h> only if we really need
it; we must be configured with --with-debug-calls and mallinfo()
must be found.
Second attempt to get rid of warnings about bzero().
* src/libraries/liboop/configure.ac: Check for <strings.h>.
* src/libraries/liboop/adns.c: Include <strings.h> to get rid of a
warning on AIX 4.3.
* src/libraries/liboop/glib.c: Ditto.
* src/libraries/liboop/select.c: Ditto.
* src/libraries/liboop/sys.c: Ditto.
* scripts/warnings.sed: More updates.
2003-07-15 Per Cederqvist <ceder@ceder.dyndns.org>
Fix some portability issues in liboop.
* src/libraries/liboop/read.c: Undefine MIN before defining it.
* src/libraries/liboop/configure.ac: Check for <string.h>.
* src/libraries/liboop/adns.c: Include <string.h> to get rid of a
warning on AIX 4.3.
* src/libraries/liboop/glib.c: Ditto.
* src/libraries/liboop/select.c: Ditto.
* src/libraries/liboop/sys.c: Ditto.
Update the warnings filter.
* scripts/warnings.sed: Updated.
Reduce the number of false warnings from Xenofarm.
* scripts/xenofarm.sh: Don't produce output on stderr when
checking for the existence of certain programs.
Liboop integration.
* AUTHORS: Add info about liboop.
Build warnings in Xenofarm were broken. Added a warning if the
xenofarm script produces any output to stderr.
* scripts/warnings.sed: Added a missing "d".
* scripts/xenofarm.sh: Store the stderr output generated during
the build in a separate file. Introduce a final "pack" task that
will result in a warning if any output to stderr exists. Enable
core files. Recognize core files even when the file name includes
a pid. Store the config.log file from liboop.
2003-07-14 Per Cederqvist <ceder@ceder.dyndns.org>
Fixed a recently introduced typo.
* src/server/connections.c (queue_remove): Fixed a typo that
caused a broken pointer structure on the queue of pending clients.
Improve liboop error checking.
* src/libraries/liboop/signal.c (add_flag): New static function,
that checks the return values from fcntl properly.
(oop_signal_new): Use add_flag() to simplify code. Fail (return
NULL) if any of the fcntl calls on the new pipe fails.
Increase PROTECTED_FDS, since liboop uses internal file
descriptors.
* src/include/kom-config.h (PROTECTED_FDS): Increased from 12 to
20. Document that liboop uses a couple of file descriptors, and
that this setting is also present in unix.exp.
* src/server/testsuite/config/unix.exp (PROTECTED_FDS): New
constant.
* src/server/testsuite/lyskomd.0/07.exp: Use PROTECTED_FDS.
* src/server/testsuite/lyskomd.0/connections-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/prot-a-send-async-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/send-async-cov.exp: Ditto.
Flush the output less often. This fixes the non-controversial
parts of bug 107.
* src/server/prot-a.c (prot_a_reply): Don't call isc_flush()
here. Doing so was redundant.
* src/server/connections.c (parse_unparsed): Return true if
anything was sent back to the client. Don't call isc_flush().
(read_from_connection): Call isc_flush() once if parse_unparsed()
returned true at least once.
* src/server/prot-a-send-async.c (async_trailer): Added a
comment about the controversial parts of bug 107.
2003-07-13 Per Cederqvist <ceder@ceder.dyndns.org>
Don't call select() with a very large timeout. This could
possibly fix bug 1065.
* src/libraries/liboop/sys.c (oop_sys_run): Clamp the value of the
tv_sec field of the select timeout argument to 3600 seconds, to
check if very large values is the reason that FreeBSD returns
EINVAL here. (Bug 1065).
Reverted the change of 1999-04-03: go_and_die is now a Bool once
again. It is no longer manipulated from a signal handler.
* src/server/admin.c (shutdown_kom): Use TRUE instead of 1 as
value of go_and_die.
* src/server/connections.c (go_and_die): Now a Bool, once again.
* src/server/ramkomd.c (sighandler_hup): Use TRUE instead of 1 as
value of go_and_die.
* src/server/sigflags.h (go_and_die): Now a Bool, once again.
Terminate at once if go_and_die becomes set while the queue of
pending requests is processed.
* src/server/connections.c (check_idle_callback): Break out of the
loop and return OOP_HALT if go_and_die is true.
Header file cleanup.
* src/server/sigflags.h (intr_syscalls_on_intr): Removed.
(restart_syscalls_on_intr): Removed.
(do_statistics): Removed.
2003-07-13 Per Cederqvist <ceder@lysator.liu.se>
Actually distribute all test cases...
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
37.exp.
2003-07-13 Per Cederqvist <ceder@ceder.dyndns.org>
Tweak testsuite timeouts.
* src/server/testsuite/config/unix.exp (timeout): Increase the
timeout 2 more seconds.
Move garb timers around so that the debug request start_garb() can
actually start the garb. Fixes breakage in lyskomd.0/09.exp.
* src/server/text-garb.h (garb_text): This function is now
static.
(start_garb_thread): New function.
(stop_garb_thread): New function.
* src/server/text-garb.c (garb_timer): New static variable.
(garb_timer_running): Ditto.
(garb_text): Added static qualifier.
(garb_callback): Moved here from connections.c. Some minor
modifications made to make it compiler in its new environment.
(start_garb_thread): New function.
(stop_garb_thread): New function.
(start_garb): Restart the garb "thread".
* src/server/connections.h (set_time): Now exported.
(setup_timer): Ditto.
(server_idle): New function.
* src/server/connections.c (set_time): No longer static.
(setup_timer): Ditto.
(garb_callback): Moved to text-garb.c.
(saver_callback): The source argument is actually used.
(toploop): Moved the garb timer to text-garb.c.
(server_idle): New function.
Use the liboop signal adapter; avoid using siglongjmp from signal
handlers. Ignore signals during shutdown.
* src/server/ramkomd.c (kom_signal_adapter): New static variable.
(server_init): Use oop_signal_new, since I don't trust the way
liboop uses siglongjmp to break out of a signal handler. Ignore
the signals before registering them with liboop, to get a proper
behaviour on shutdown.
(main): Adjusted to use the signal adapter.
Fix errors in ths liboop signal adapter.
* src/libraries/liboop/signal.c (use_sa_restart): New static
variable.
(sig_on_signal): Add SA_RESTART if appropriate.
(oop_signal_new): Don't just blindly set FD_CLOEXEC and
O_NONBLOCK. Read the old settings first.
(oop_signal_use_sa_restart): New function.
* src/libraries/liboop/oop.h (oop_signal_use_sa_restart): New
function.
Updated documentation for the configuration file for "timeval"
parameters and penalty points/client scheduling.
* doc/lyskomd.texi (Parameter Types): Document "timeval".
(Parameters): Updated the documentation for "timeval" parameters
and the parameters relating to penalty points.
Added test cases for parsing of timeval values.
* src/include/services.h (dump_cfg_timevals): New debug request.
* src/server/fncdef.txt: Added 1006=dump_cfg_timevals.
* src/server/server-config.c (dump_timeval): New static function.
(dump_cfg_timevals): New request.
* src/server/testsuite/lyskomd.0/37.exp: New file: Test the
parsing of "timeval" entries in the configuration file.
Improved timeval parsing.
* src/server/conf-file.c (assign_timeval): Skip whitespace between
the number and the suffix. Round the tv_usec field properly.
Improve config file checking.
* src/server/server-config.c (read_configuration): Give an error
message if low_penalty isn't lower than max_penalty.
Fixed more compilation errors.
* src/server/simple-cache.c (cache_sync_finish): Added a missing
parenthesis.
* src/server/aux-item-def-parse.y: Include timewrap.h, since
connections.h now needs it.
* src/server/debug.c: Ditto.
* src/server/standalone.c: Ditto.
Added more liboop assertions.
* src/libraries/liboop/sys.c (oop_sys_run): Added a few assertions
to try to figure out why select still returns EINVAL sometimes.
Fixed compilation error when compiled for coverage measurements.
* src/server/simple-cache.c (cache_sync_finish): Adjusted to new
API of sync_part().
Include <time.h> and <sys/time.h> in a proper way.
* src/server/Makefile.am (lyskomd_SOURCES): Added timewrap.h.
* src/server/timewrap.h: New include file; a wrapper around
<time.h> and <sys/time.h>. All files that needs to include either
file now does so via this wrapper.
2003-07-12 Per Cederqvist <ceder@ceder.dyndns.org>
Code cleanup.
* src/server/server-config.c: (parameters): Added default_suffix
initializers for all parameters. Break overly long lines.
All configuration parameters that are time periods can now have an
optional suffix such as "hours" appended. Store them as a struct
timeval, not as an int, so that the bulk of the code doesn't have
to take the unit into account.
* src/server/param.h (struct kom_par): Changed the type of the
following fields from int to struct timeval:
garb_busy_postponement, garbtimeout, synctimeout, garb_interval,
sync_interval, sync_retry_interval.
* src/server/server-config.c: (parameters): Changed the assigner
of "Garb busy postponement", "Garb timeout", "Sync timeout", "Garb
interval", "Sync interval" and "Sync retry interval" from int to
timeval, and added appropriate default suffixes to those
configuration parameters.
* src/server/conf-file.h (struct parameter): New field:
default_suffix.
(assign_timeval): New assigner.
* src/server/conf-file.c (struct suffix_conversion): New struct.
(suffix_table): New table.
(assign_timeval): New assigner.
Use "struct timeval" instead of a number of milliseconds or
seconds in several places. This fixes a number of potential and
actual overflows.
* src/server/connections.h (Connection): Change the type of the
session_start and active_time fields from time_t to struct
timeval.
* src/server/server-time.h (current_time): Now a struct timeval,
not a time_t.
* src/server/disk-end-of-atomic.c, src/server/end-of-atomic.h
(end_of_atomic): Now returns a struct timeval, not a long.
* src/server/cache.h (sync_part): Now returns a struct timeval.
* src/server/text.c (add_text_in_conf): Extract the
seconds from the current_time.
(create_text_add_miscs): Ditto.
(do_create_text): Ditto.
(add_recipient): Ditto.
(add_comment): Ditto.
(add_footnote): Ditto.
* src/server/text-garb.c (garb_text): Extract the seconds from the
current_time.
* src/server/simple-cache.c (sync_output_header): Extract the
seconds from the current_time.
(sync_part): Return a struct timeval instead of a long. Use
struct timeval instead of a time_t. Use timeval_remaining() to
simplify the code.
(init_cache): Use a struct timeval instead of time_t.
(cache_sync_all): Adjusted to new API of sync_part().
* src/server/session.c (leave_conf): Extract the seconds from the
current_time.
(login_old): Ditto.
(login): Ditto.
(get_static_session_info): Ditto.
(get_time): Ditto.
(logout): Ditto. Use timeval_diff_sec instead of ldifftime.
(who_is_on_dynamic): Use timeval_diff_sec instead of ldifftime.
(get_session_info): Ditto.
(get_session_info_ident): Ditto.
* src/server/send-async.c (async_rejected_connection): Use struct
timeval instead of time_t.
* src/server/ramkomd.c (current_time): Now a struct timeval, not
a time_t.
(main): Adjusted for the new type of current_time.
* src/server/person.c (create_person_generic): Extract the seconds
from the current_time.
* src/server/membership.c (do_add_rec_time): Extract the seconds
from the current_time.
(do_add_member): Ditto.
* src/server/internal-connections.c (init_connection): Use struct
timeval instead of time_t.
* src/server/connections.c (set_time): Use struct timeval instead
of time_t.
(dump_statistics): Ditto.
(saver_callback): Ditto.
(setup_timer): Replaced the milliseconds argument with a struct
timeval argument.
(garb_callback): Simplified the code.
* src/server/conference.c (do_create_conf): Extract the seconds
from the current_time.
* src/server/aux-items.c (prepare_aux_item): Extract the seconds
from the current_time.
Added utility functions for struct timeval.
* src/libraries/libmisc/Makefile.am (libmisc_a_SOURCES): Added
timeval-util.h and timeval-util.c.
* src/libraries/libmisc/timeval-util.h,
* src/libraries/libmisc/timeval-util.c: New files.
(timeval_subtract): New static function.
(timeval_nonzero): New function.
(timeval_zero): Ditto.
(timeval_ctor): Ditto.
(timeval_remaining): Ditto.
(timeval_greater): Ditto.
(timeval_less): Ditto.
(timeval_diff_sec): Ditto.
Don't store garbage in struct timevals passed to liboop.
* src/server/connections.c (setup_timer): Fixed an error that
caused the tv_usec field to be out-of-range.
2003-07-12 Per Cederqvist <ceder@lysator.liu.se>
Make liboop refuse bad timestamps early on.
* src/libraries/liboop/sys.c (sys_on_time): Trigger an assertion
if a broken tv_usec is entered.
Make gdb find the liboop sources.
* src/server/Makefile.am (.gdbinit): Added liboop.
2003-07-12 Per Cederqvist <ceder@ceder.dyndns.org>
Attempt to fix a bug that caused the testsuite to hang.
* src/server/testsuite/config/unix.exp (kill_client): Fixed broken
logic that caused the "looking for stray output" never to emit a
pass message. Look for eof on the client.
Update valgrind suppressions.
* src/server/testsuite/lyskomd.supp: Track the name change of
isc_tcp_accept_fn() to isc_tcp_accept().
Reduce the number of log messages.
* src/server/connections.c (add_to_kill_list): Don't write a log
message when the connection is already present on the kill list.
With the liboop callbacks that can happen and is not an error.
(write_err_cb): Don't log an error for ECONNRESET.
Fixed compilation errors.
* src/server/connections.c (read_from_connection): Removed
left-over debug code.
(enable_idle_check): Ditto.
(check_idle_callback): Ditto.
* src/libraries/liboop/www.c (reg): Don't use //-style comments.
(unreg): Ditto.
Fixed liboop compilation errors introduced by me.
* src/libraries/liboop/sys.c (sys_on_time): Moved the assert
statement to after all variable declarations.
(sys_on_signal): Ditto.
Make it easier to run all the tests that don't require dejagnu.
* src/server/testsuite/Makefile.am (check-nondejagnu): New target.
(check-dejagnu): New target.
(check): Depend on check-dejagnu and check-nondejagnu, and move
all dependencies to one of those targets.
Add scheduling of clients, so that one client cannot starve other
clients for resources. (Bug 102).
* src/server/server-config.c (parameters): Added "Penalty per
call", "Penalty per read", "Max penalty" and "Low penalty".
* src/server/testsuite/lyskomd.0/conf-file-cov.exp: Check the
parameter "Garb timeout" instead of "Idle timeout", since the
latter no longer exists.
* src/server/param.h (struct kom_par): Removed timeout. Added
garb_busy_postponement, penalty_per_call, penalty_per_read,
max_penalty and low_penalty.
* src/server/internal-connections.c (init_connection):
Initialize penalty, penalty_generation, queue_next, queue_prev,
on_queue.
(kill_client): Assert that on_queue is false.
* src/server/connections.h (Connection): New fields: penalty,
penalty_generation, queue_prev, queue_next, on_queue.
(handle_accept_event): New function.
* src/server/connections.c (penalty_generation): New static variable.
(work_done): Ditto.
(is_idle): Ditto.
(queue_first): Ditto.
(queue_last): Ditto.
(queue_add): New static function.
(queue_remove): Ditto.
(logout_client): Remove the client from the queue of pending
clients.
(parse_unparsed): Add penalty points for finished calls and
protocol errors. Don't delete the parsed part of unparsed.
(adjust_penalty): New static function.
(enable_idle_check): Ditto.
(check_idle_callback): Ditto.
Run the database save, garb, and check for killed clients from
three separate liboop timer callbacks.
* src/server/connections.c (kill_pending): New static variable.
(add_to_kill_list): Add an oop timer event callback to
check_kill_flg when a client is added to the kill list.
(check_kill_flg): Changed API: this is now an oop timer callback
function.
(garb_callback): New static function.
(saver_callback): Ditto.
* src/server/text-garb.c (last_start): Static variable removed.
(garb_text): Expect the caller to wait long enough when the garb
shouldn't be running. Return true when the garb is completed,
instead of when the garb shouldn't be running.
* src/server/cache.h (sync_part): Return the number of seconds to
wait instead of a Bool.
* src/server/simple-cache.c (sync_part): Return the number of
seconds to wait instead of a Bool. All callers updated.
* src/server/server-config.c (parameters): Removed "Idle timeout".
Added "Garb busy postponement"
* src/server/end-of-atomic.h (end_of_atomic): Removed the
idle argument.
* src/server/disk-end-of-atomic.c (end_of_atomic): Removed the
idle argument. Don't call the garb. Adjusted to the new API of
sync_part().
Use liboop for signal dispatching.
* src/server/ramkomd.c (sighandler_usr1): Now an liboop signal
callback, not a real signal handler. Do the real work here.
(sighandler_winch): Ditto.
(sighandler_hup): Now an liboop signal callback, not a real signal
handler.
(sighandler_quit): Ditto.
(sighandler_usr2): Ditto.
(setup_sighandlers): Removed.
(restart_syscalls_on_intr): Removed.
(intr_syscalls_on_intr): Removed.
* src/server/param.h (reread_param): Variable removed.
* src/server/server-config.c (reread_param): Removed.
* src/server/connections.c (do_statistics): Variable removed.
Use liboop. (Bug 106).
* src/server/Makefile.am (AM_CPPFLAGS): Added an -I flag for
liboop.
(lyskomd_SOURCES): Added oop-malloc.h and oop-malloc.c.
(lyskomd_LDADD): Link against liboop.a.
* src/server/oop-malloc.c, src/server/oop-malloc.h
(oop_malloc_wrapper): New function.
(oop_free_wrapper): New function.
(oop_realloc_wrapper): New function.
(dump_oop_alloc_counts): New function.
* src/server/ramkomd.c (listen_client): Static variable removed.
(server_init): Initialize liboop. Adjusted to the new isc API:s.
(main): Clean up liboop structures on shutdown.
* src/server/rfc931.h: Adjusted to new libisc API.
* src/server/rfc931.c: Include liboop.h.
* src/server/prot-a.c: Include oop.h.
* src/server/prot-a-send-async.c: Include oop.h.
* src/server/prot-a-parse.c: Include oop.h.
* src/server/prot-a-parse-arg-c.awk: Include oop.h.
* src/server/prot-a-output.c: Include oop.h.
* src/server/isc-interface.h (kom_server_oop_src): New global
variable.
* src/server/connections.c (kom_server_oop_src): New variable.
(set_time): New static function.
(parse_message): Function removed.
(logout_request): Function removed.
(parse_forgotten): Ditto.
(message_request): Ditto.
(write_err_cb): New static function.
(read_from_connection): Ditto.
(setup_timer): Ditto.
(data_available_callback): Ditto.
(handle_accept_event): New function.
(login_request): Take an isc_scb as argument instead of an isc
event. Add read and write error callback functions for the new
client.
(toploop): Rewritten to use liboop.
Code cleanup.
* src/server/internal-connections.c (init_connection): Added
static const qualifiers to the default_want_async variable.
Renamed a few constants that have nothing to do with ISC.
* src/server/isc-parse.h (KOM_PROTOCOL_ERR): New name for former
ISC_PROTOCOL_ERR. All users updated.
(KOM_MSG_INCOMPLETE): New name for former ISC_MSG_INCOMPLETE. All
users updated.
(KOM_LOGOUT): New name for former ISC_LOGOUT. All users updated.
* src/server/isc-parse.c (parse_char): Use KOM_MSG_INCOMPLETE
instead of ISC_MSG_INCOMPLETE.
Make it possible to read an unsigned int from the config file.
* src/server/conf-file.h (assign_uint): New function.
(union param_value): Unused union removed.
* src/server/conf-file.c (assign_uint): New function.
Add SA_RESTART support to liboop. (This has been sent to the
liboop maintainer.) (Fixes bug 845).
* src/libraries/liboop/oop.h (oop_sys_use_sa_restart): New
function.
* src/libraries/liboop/sys.c (sys_sig_owner): Added static
qualifier.
(use_sa_restart): New static variable.
(sys_on_fd): Require the callback to be non-NULL.
(sys_on_time): Ditto.
(sys_on_signal): Ditto.
(sys_on_signal): Use SA_RESTART if use_sa_restart is true.
(oop_sys_use_sa_restart): New function.
Add a few utility string functions.
* src/libraries/libmisc/s-string.h,
src/libraries/libmisc/s-string.c (s_trim_left): New function.
(s_reserve): New function.
(s_reserve_done): New function.
2003-07-10 Per Cederqvist <ceder@ceder.dyndns.org>
Solaris stores ar in /usr/ccs/bin.
* src/libraries/liboop/configure.ac: Use the same check for the
``ar'' program that lyskom-server uses.
libisc will soon depend on liboop.
* src/libraries/Makefile.am (SUBDIRS): Compile liboop before
libisc-new, since isc is about to use liboop.
2003-07-09 Per Cederqvist <ceder@ceder.dyndns.org>
Link-time fix for liboop test program.
* src/libraries/liboop/Makefile.am (test_oop_LDADD): Link against
liboop.a, not -loop, to ensure that we get the local copy.
Build liboop (but don't use it yet).
* configure.in: Added src/libraries/liboop to AC_CONFIG_SUBDIRS.
* mkmi: Recreate configure and Makefile.in in liboop.
* src/libraries/Makefile.am (SUBDIRS): Added liboop.
Using libtool isn't worth the effort for our copy of liboop.
Don't include adapters for things we are never going to use.
* src/libraries/liboop/configure.ac: Removed checks for readline,
glib, Tcl and libwww, since they are not used by lyskom-server.
(AM_PROG_LIBTOOL): Removed.
(PROG_LDCONFIG): Don't set it.
(no_wacky_libs): Don't set it.
(AC_PROG_RANLIB): Added.
* src/libraries/liboop/Makefile.am (noinst_LIBRARIES): Added.
(liboop_a_SOURCES): New name for former liboop_la_SOURCES.
(noinst_HEADERS): New name for former include_HEADERS.
(lib_LTLIBRARIES): Removed.
(liboop_la_LDFLAGS): Removed.
(liboop_adns_la_LDFLAGS): Removed.
(liboop_adns_la_LIBADD): Removed.
(liboop_adns_la_SOURCES): Removed.
(liboop_glib_la_LDFLAGS): Removed.
(liboop_glib_la_LIBADD): Removed.
(liboop_glib_la_SOURCES): Removed.
(liboop_tcl_la_LDFLAGS): Removed.
(liboop_tcl_la_LIBADD): Removed.
(liboop_tcl_la_SOURCES): Removed.
(liboop_www_la_LDFLAGS): Removed.
(liboop_www_la_LIBADD): Removed.
(liboop_www_la_SOURCES): Removed.
(liboop_rl_la_LDFLAGS): Removed.
(liboop_rl_la_LIBADD): Removed.
(liboop_rl_la_SOURCES): Removed.
(check_PROGRAMS): New name for former noinst_PROGRAMS.
(test_oop_LDADD): Removed $(lib_LTLIBRARIES) and added -loop.
(install-exec-local): Removed. There is no need to run ldconfig.
Removed liboop files that are generated by autoconf or automake.
* src/libraries/liboop/aclocal.m4: Removed.
* src/libraries/liboop/Makefile.in: Removed.
* src/libraries/liboop/configure: Removed.
* src/libraries/liboop/install-sh: Removed.
* src/libraries/liboop/missing: Removed.
* src/libraries/liboop/mkinstalldirs: Removed.
Import liboop-0.9.
* src/libraries/liboop/README: File created.
* src/libraries/liboop/*: Import version 0.9 of liboop to the
lyskom-server repository.
Liboop calls siglongjmp from a signal handler. Check if that is
really portable.
* scripts/xenofarm.sh: Run the test-sigjmp program as a separate
task.
* src/server/testsuite/Makefile.am (check_PROGRAMS): Added
test-sigjmp.
(test_sigjmp_SOURCES): New variable.
(test_sigjmp_LDADD): New variable.
(check-test-sigjmp): New target.
* src/server/testsuite/test-sigjmp.c: New test program. Verify
that select can be broken by a siglongjmp call from a signal
handler.
2003-07-03 Per Cederqvist <ceder@ceder.dyndns.org>
Turn on the -Wfloat-equal gcc warning.
* configure.in: Added -Wfloat-equal to CFLAGS.
Update the test suite for the denial-of-service fix.
* src/server/testsuite/lyskomd.0/01.exp: Expect the get-last-text,
find-next-text-no and find-previous-text-no requests to fail when
the user isn't logged in.
2003-05-09 Per Cederqvist <ceder@ingate.com>
Require that the user is logged in before allowing him to do
get-last-text, find-next-text-no or find-previous-text-no. This
fixes a denial-of-service attack reported by Calle Dybedahl.
* src/server/text.c (get_last_text): Require the user to be logged
in.
(find_next_text_no): Ditto.
(find_previous_text_no): Ditto.
* doc/Protocol-A.texi (get-last-text): This request now requires
that the user is logged in.
(find-next-text-no): Ditto.
(find-previous-text-no): Ditto.
2003-03-23 Per Cederqvist <ceder@ceder.dyndns.org>
Don't copy zero-length arrays. (Bug 1005).
* src/server/memory.c (copy_membership): Don't allocate a copy of
read_ranges if read_ranges is NULL.
Test for bug 1005.
* src/server/testsuite/lyskomd.0/36.exp: New file that triggers an
assertion.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
36.exp.
Don't copy zero-length arrays.
* src/server/membership.c (read_ranges_precondition): Don't
allocate a copy of read_ranges if read_ranges is NULL.
Code cleanup.
* src/server/prot-a-output.c (prot_a_output_read_texts): Coding
standards issue: compare the pointer read_ranges against NULL, not
0.
2003-03-15 Per Cederqvist <ceder@ceder.dyndns.org>
Remove the "magic" field of Connection. Valgrind provides a
better and less intrusive way to find memory allocation errors.
* src/server/connections.h (CONN_MAGIC_ALLOC): Removed.
(CONN_MAGIC_FREE): Removed.
(Connection): Removed the magic field.
* src/server/internal-connections.c (init_connection): Don't set
the magic field.
(new_client): Ditto.
(kill_client): Ditto.
* src/server/connections.c (logout_client): Don't check the magic
field.
Allow test suite configuration (such as the timeout) to be
overridden in localcfg.exp.
* src/server/testsuite/config/unix.exp: Source config/localcfg.exp
if it exists.
* src/server/testsuite/config/.cvsignore: Ignore localcfg.exp.
2003-03-08 Per Cederqvist <ceder@ceder.dyndns.org>
Port 4894 is official.
* doc/Protocol-A.texi (Connecting to the Server): Mention that
port 4894 is registered with IANA.
2003-02-09 Per Cederqvist <ceder@ceder.dyndns.org>
Minor makefile fix.
* src/libraries/libeintr/Makefile.am (eintr.h $(funcs)): Use
$(AWK) and not @AWK@.
2003-02-08 Per Cederqvist <ceder@ceder.dyndns.org>
Port to FreeBSD 4.7.
* doc/Makefile.am (check-doc): Make sed pattern more portable by
not using "[---a-z0-9]". FreeBSD 4.7 said "RE error: invalid
character range".
2003-01-18 Per Cederqvist <ceder@ceder.dyndns.org>
Xenofarm: use TZ=GMT to work around buggy dwim_time().
* scripts/xenofarm.sh (log): Set TZ to GMT, and LC_ALL to C,
before calling date. The Pike function Calendar.ISO.dwim_time
does very buggy things when a time zone it doesn't understand is
encountered, so force everybody to use the well-known GMT time
zone.
Disable the test suite on taylor.
* scripts/xenofarm.sh: Don't run the test suite on taylor.
Runtest is broken there.
Xenofarm: move warning filtering to a separate file.
* scripts/xenofarm.sh: Moved large sed script to warnings.sed.
* scripts/warnings.sed: New file. This sed script removes all
false warnings. New coding standard rule: each (group of) removed
warning(s) should be preceded by a comment that gives an example
of where the warning occurs. I'm starting with an almost empty
file, and will add back the filters and collect info on from where
they originate.
* scripts/Makefile.am (EXTRA_DIST): Distribute warnings.sed.
2003-01-17 Per Cederqvist <ceder@ceder.dyndns.org>
Complete testing of async-deleted-text et c. (Bug 59).
* src/server/testsuite/.cvsignore: Ignore 35-aux.conf.
* src/server/testsuite/lyskomd.0/35.exp: Test case completed.
2003-01-17 Per Cederqvist <ceder@ingate.com>
Xenofarm warnings.
* scripts/xenofarm.sh: Ignore glibc-2.1.2/gcc-2.95.2 warnings.
2003-01-17 Per Cederqvist <ceder@ceder.dyndns.org>
Fixed cut-n-paste error.
* src/server/text.c (report_bad_aux): Don't declare variables in
the middle of a function!
Minor testsuite fixes.
* src/server/testsuite/lyskomd.0/30.exp: Specify a long sync
interval, to avoid spurious async-sync-db messages.
* src/server/testsuite/config/unix.exp (epoch_time): New constant.
* src/server/testsuite/lyskomd.0/05.exp: Use epoch_time. This
test used to fail when run west of London.
Continue testing async-deleted-text et c. Fix bugs found.
(Bug 59).
* src/server/text.c (report_bad_aux): New static function.
(is_member_in_linked_recpt): New argument: tno. All callers
updated. For now, do nothing special with cross-reference; until
but 23 is fixed that would be pointless. Report bad aux-items
with report_bad_aux. Added missing breaks.
(interested_party): New argument: tno. All callers updated.
* src/server/testsuite/lyskomd.0/35.exp: Commit of work in
progress. Still needs more work.
Stricter checking on aux-item cross-reference.
* run-support/aux-items.conf (cross-reference): If anything
follows the reference, it must begin with a space.
Typos fixed.
* src/libraries/libmisc/s-string.h: Fixed typo in a comment.
* README: Typo fixed.
2003-01-14 Per Cederqvist <ceder@ceder.dyndns.org>
Start testing async-deleted-text et c. (Bug 59).
* src/server/testsuite/lyskomd.0/35.exp: New file. Test sending
of async-deleted-text, async-new-text, async-new-text-old,
async-add-recipient and async-sub-recipient to recipients of texts
that are linked to the text. Needs more work.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
35.exp.
2003-01-13 Per Cederqvist <ceder@ingate.com>
Xenofarm tweaking.
* scripts/xenofarm.sh: Remove installedfiles.txt if it is empty.
Use mv instead of cp to move files into the result package, to
preserve time stamps. Create corefiles.txt if any core files are
found.
Cut-n-paste error introduced in last commit fixed.
* src/server/text.c (is_member_in_linked_recpt): Fixed cut-n-paste
error.
2003-01-13 Per Cederqvist <ceder@ceder.dyndns.org>
Send async-deleted-text, async-new-text, async-new-text-old,
async-add-recipient and async-sub-recipient to recipients of text
linked to the relevant text. (Bug 59).
* src/server/text.c (is_member_in): New static function.
(is_member_in_recpt): Use is_member_in to simplify code.
(is_member_in_recpt_of): New static function.
(is_member_in_linked_recpt): New static function.
(interested_party): New static function. This also considers if
the potential message recipient is a member of a recipient of a
text that is linked to the text, via a misc-info or a aux-item.
(send_async_sub_recipient): Use interested_party to determine if
the asynchronous message should be sent.
(send_async_deleted_text): Ditto.
(send_async_new_text_old): Ditto.
(send_async_new_text): Ditto.
(send_async_add_recipient): Ditto.
(text_read_access): Added const qualifiers.
* src/server/manipulate.h (text_read_access): Added const
qualifiers.
(person_text_read_access): Ditto.
Port to DejaGnu 1.2.
* scripts/xenofarm.sh: DejaGnu 1.2 doesn't understand --version,
so use "runtest -V" instead when detecting runtest.
2003-01-12 Per Cederqvist <ceder@ceder.dyndns.org>
Fix too restrictive validation on content-type.
* run-support/aux-items.conf (content-type): Allow anything
after a semicolon.
Implemented passive-message-invert. (Bug 827).
* doc/Protocol-A.texi (Membership Information): Renamed the
reserved1 bit of Membership-Type to passive-message-invert.
Document it.
(async-send-message): Mention that the passive and
passive-message-invert bits of the Membership-Type influences if
messages are sent or not.
(send-message): Mention passive and passive-message-invert.
Mention async-send-message.
(Error Codes): Don't say "group message".
* src/include/kom-types.h (Membership_type): Renamed reserved1 to
passive_message_invert.
* src/server/admin.c (send_message): Handle
passive_message_invert.
* src/server/ram-parse.c (fparse_membership_type): Handle
passive_message_invert.
* src/server/ram-output.c (foutput_membership_type): Handle
passive_message_invert.
* src/server/prot-a-parse.c (prot_a_parse_membership_type): Handle
passive_message_invert.
* src/server/prot-a-output.c (prot_a_output_membership_type):
Handle passive_message_invert.
* src/server/person.c (create_person_generic): Handle
passive_message_invert.
* src/server/memory.c (init_membership_type): Handle
passive_message_invert.
* src/server/membership.c (set_membership_type_bits): Handle
passive_message_invert.
* src/server/dbck.c (check_membership): Handle
passive_message_invert.
* src/server/testsuite/lyskomd.0/34.exp: New file. Test the
passive-message-invert bit of Membership-Type.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
34.exp.
Made aux-items.conf more strict. (Bug 451).
* run-support/aux-items.conf (content-type): Don't allow more than
one "/".
(no-comment): This must be unique and contain no data.
(personal-comment): Ditto.
(request-confirmation): Ditto.
(read-confirm): This must contain no data.
(redirect): Clear inherit, secret and hide-creator.
(mx-author): Clear inherit, secret, hide-creator and dont-garb.
(mx-from): Ditto.
(mx-reply-to): Ditto.
(mx-message-id): Ditto.
(mx-in-reply-to): Ditto.
(mx-misc): Ditto.
(mx-allow-filter): Ditto.
(mx-reject-forward): Ditto.
(mx-to): Clear inherit and dont-garb.
(mx-cc): Ditto.
(canonical-name): Ditto.
(mx-date): Clear hide-creator, secret and dont-garb.
(notify-comments): Clear inherit, hide-creator and dont-garb.
(recommended-conf): Clear inherit and dont-garb.
(allowed-content-type): Clear inherit and dont-garb. Require a
priority number before the content type, and don't allow more than
one "/" or " ".
(mx-list-name): Set owner-delete. Clear dont-garb and inherit.
(mx-refuse-import): Set unique. Clear dont-garb and inherit.
(mx-mime-misc): Set unique.
(mx-envelope-sender): Set unique.
* src/server/testsuite/lyskomd.0/20.exp: Adjusted for the new,
stricter aux-items.conf.
* src/server/testsuite/lyskomd.0/03.exp: Adjusted for the new,
stricter aux-items.conf.
2003-01-10 Per Cederqvist <ceder@ceder.dyndns.org>
Document undocumented files. (Bug 852).
* doc/lyskomd.texi (Parameters): Documented the default values of
"Connection status file" and "Connection status temp file".
(Files): Documented db/number.txt and etc/connections.txt.
Use mark_person_as_changed properly in mark_as_read. (Bug 877).
* src/server/membership.c (mark_as_read): The list of read texts
is part of the person, so use mark_person_as_changed, not
mark_conference_as_changed. (Bug 877).
(mark_as_unread): FIXME comment removed.
(set_read_ranges): Ditto.
Write a test case for bug 877.
* src/server/testsuite/lyskomd.0/bug-877.exp: New file.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
bug-877.exp.
* src/server/simple-cache.c: All these changes are only in effect
if DEBUG_CALLS is defined:
Include services.h and manipulate.h.
(block_after_pre_sync): New static variable.
(save_one_conf): Return immediately if block_after_pre_sync is
true.
(cache_sync_all): Crash if block_after_pre_sync is true.
(cache_sync_start): New request.
(cache_sync_finish): New request.
* src/server/fncdef.txt (cache_sync_start): New DEBUG_CALLS
request.
(cache_sync_finish): Ditto.
* src/include/services.h (cache_sync_start): New DEBUG_CALLS
request.
(cache_sync_finish): Ditto.
Code cleanup.
* src/server/connections.c (kill_list): Now static.
(kill_list_size): Now static.
2003-01-07 Per Cederqvist <ceder@lysator.liu.se>
Port to IRIX64, where "unsigned long" isn't large enough to avoid
alignment problems.
* src/server/ram-smalloc.c: Include <inttypes.h> or <stdint.h>.
(union overhead): New union. Use two of these instead of two
unsigned ints as the overhead at the front of a malloced block.
This ensures we get the alignment that we need.
(smalloc): Updated to use union overhead. Some useless casts
removed.
(sfree): Ditto.
(srealloc): Ditto.
* configure.in: Check for <stdint.h>, intptr_t, intmax_t and
size_t.
2003-01-07 Per Cederqvist <ceder@ingate.com>
Xenofarm cleanup.
* scripts/xenofarm.sh: Don't create .pass-, .warn- and .fail
files. The information is present in mainlog.txt, and the
Xenofarm scripts no longer need them.
Upgrade to valgrind-1.9.2.
* src/server/testsuite/lyskomd.supp: Valgrind 1.9.2 detects the
isc_tcp_accept_fn in the calltrace, so we have to update the
suppressions for bug 916.
2003-01-07 Per Cederqvist <ceder@ceder.dyndns.org>
Note a bug.
* src/server/text.c (add_recipient): FIXME comment added.
2003-01-06 Per Cederqvist <ceder@lysator.liu.se>
Change to Xenofarm log file format version 2.
* scripts/xenofarm.sh (logstart, logpass, logfail, logwarn): New
functions.
(dotask): New argument: warnfunc. All callers updated. Convert
to Xenofarm log format version 2.
(cfgwarn, makewarn, ckprgwarn): New functions that hunt for
warnings. Extracted from the top level.
(Top Level): Removed special-caseing for taylor.
2003-01-06 Per Cederqvist <ceder@ceder.dyndns.org>
Xenofarm tweaking.
* scripts/xenofarm.sh: Use sed -e instead of multiple grep -v.
This should scale better.
Implemented async-new-user-area. (Bug 7).
* doc/Protocol-A.texi (async-new-user-area): New async message.
* src/server/async.h (enum async): Added ay_new_user_area.
* src/server/person.c (do_set_user_area): Renamed a few local
variables. Call async_new_user_area when the user area changes.
* src/server/session.c (accept_async): Handle ay_new_user_area.
* src/server/send-async.h, src/server/send-async.c
(async_new_user_area): New function.
* src/server/prot-a-send-async.h, src/server/prot-a-send-async.c
(prot_a_async_new_user_area): New function.
* src/server/person.c (do_set_user_area): Indentation fixes.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
33.exp.
* src/server/testsuite/lyskomd.0/33.exp: New file: test
async-new-user-area.
* src/server/testsuite/lyskomd.0/03.exp: Expect asynchronous
message 19 to exist.
Improve the description on how to add an async message.
* doc/lyskomd.texi (Adding Asynchronous Messages): Mention
sesion.c, 03.exp and that new test cases should be written.
Test deletion of a person that is logged in on another session.
* src/server/testsuite/lyskomd.0/32.exp: New file. Test deletion
of a person that is logged in on another session.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
32.exp.
Don't state that async-leave-conf is sent when the person is
deleted.
* doc/Protocol-A.texi (async-leave-conf): This is not sent when
the person is deleted, so don't say that it is.
Update the testsuite for the new semantics of "Max conferences".
* src/server/testsuite/lyskomd.0/person-cov.exp: Lower "Max
conferences" from 18 to 17, to compensate for the bugfix of
2003-01-04.
* src/server/testsuite/lyskomd.0/conference-cov.exp: Lower "Max
conferences" from 20 to 19, to compensate for the bugfix of
2003-01-04.
2003-01-04 Per Cederqvist <ceder@ceder.dyndns.org>
Make it easier to reduce the DejaGnu timeout.
* src/server/testsuite/config/unix.exp: Moved the setting of
timeout around so that people with a fast machine can reduce the
timeout simply by removing a has sign.
Document what happens when a text, person or conference cannot be
created because of the "Max texts"/"Max conferences" parameters.
* doc/Protocol-A.texi (create-person-old): Document the error code
index-out-of-range.
(create-person): Ditto.
(create-conf-old): Ditto.
(create-conf): Ditto.
(create-text-old): Ditto.
(create-text): Document what error-status is set to when
index-out-of-range is returned.
The "Max texts" and "Max conferences" parameters was off by one.
* src/server/server-config.c (read_configuration): Increase
param.max_text and param.max_conf. This fixes an off-by-one error
in the documentation and parameter naming.
Test the "Max texts" and "Max conferences" parameters.
* src/server/testsuite/lyskomd.0/31.exp: Test the "Max texts" and
"Max conferences" parameters.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
31.exp.
The error code anonymous-rejected was not documented under
create-text.
* doc/Protocol-A.texi (create-text). Document the error code
anonymous-rejected.
2002-12-30 Per Cederqvist <ceder@ceder.dyndns.org>
Port to autoconf 2.57.
* configure.in: Require autoconf 2.57. Use AC_CONFIG_HEADERS
instead of AM_CONFIG_HEADER.
Update copyright headers.
* <all files>: update the year in the copyright notice.
* scripts/lyskomd-copyrights: Added bug-52.data and bug-52.texts
to the list of files that should not have a copyright header.
Clarify the faq-text item in aux-items.conf.
* run-support/aux-items.conf (faq-text): Changed the regexp
validation to explicitly forbid linking to text number 0.
Minor doc fix.
* doc/Protocol-A.texi (add-footnote): The description for the
error code index-out-of-range was wrong.
Autoconf: better check for "attribute unused" support.
* configure.in: Use CMOD_C_WORKING_ATTRIBUTE_UNUSED instead of
CMOD_C_ATTRIBUTE_UNUSED.
* acinclude.m4 (CMOD_C_ATTRIBUTE_UNUSED): Removed.
(CMOD_C_WORKING_ATTRIBUTE_UNUSED): New defun.
2002-11-28 Per Cederqvist <ceder@ceder.dyndns.org>
Added IPv6 support, coded by Thorild Seln
<thorild@Update.UU.SE>. (Bug 563).
* configure.in: Added --enable-ipv6 switch.
* AUTHORS: Added Thorild Seln.
Stop mark-as-read from leaking info about secret conferences.
(Bug 48).
* src/server/membership.c (mark_as_read): Don't leak info about
secret conferences.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
bug-48.exp.
* src/server/testsuite/lyskomd.0/bug-48.exp: New file.
Removed redundant dbck runs from the test suite.
* src/server/testsuite/lyskomd.0/bug-52.exp (stop): Removed a
redundant call to dbck_run.
Update documentation.
* doc/lyskomd.texi (Adding New Input Types): Test for client
disconnect during parsing.
* doc/Protocol-A.texi (set-read-ranges): Added error code
conference-zero.
2002-11-27 Per Cederqvist <ceder@ceder.dyndns.org>
Test set-read-ranges. (Bug 54).
* src/server/testsuite/lyskomd.0/30.exp: Test set-read-ranges.
* src/server/testsuite/lyskomd.0/29.exp: Added test cases for
client disconnect while parsing a read_range_list.
Test mark-as-unread. (Bug 53).
* src/server/testsuite/lyskomd.0/30.exp: Test mark-as-unread.
2002-11-26 Per Cederqvist <ceder@ceder.dyndns.org>
Use valgrind-1.1.0 instead of valgrind-1.0.0.
* src/server/testsuite/lyskomd.supp: Adjusted to valgrind-1.1.0.
Added suppressions for bug 916.
Fixed a broken log message.
* src/server/membership.c (read_ranges_postcondition): Added a
missing newline in the log message.
Plugged a memory leak in mark-as-unread.
* src/server/membership.c (remove_loc_no): srealloc() or sfree()
the read_ranges if we remove a range.
Test mark-as-unread and set-read-ranges a little.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
30.exp.
* src/server/testsuite/lyskomd.0/30.exp: New file. Test
mark-as-unread and set-read-ranges. This is not complete yet.
2002-11-25 Per Cederqvist <ceder@ceder.dyndns.org>
Upgraded for autoconf-2.56 and automake-1.7.1.
* HACKING: Updated version numbers of autoconf and automake.
* src/server/Makefile.am (AM_YFLAGS): Set AM_YFLAGS instead of
YFLAGS. The latter is reserved for the user.
* doc/Protocol-A.texi: Use @c instead of @ignore..@end ignore
inside the @copying command, since @ignore..@end ignore no longer
works there with the texinfo.tex supplied with automake-1.7.1.
* configure.in: Upgraded for autoconf-2.56 and automake-1.7.1:
Use AC_COMPILE_IFELSE instead of AC_TRY_COMPILE. Use
AC_LANG_PROGRAM. Use AC_LINK_IFELSE instead of AC_TRY_LINK. Use
AC_RUN_IFELSE instead of AC_TRY_RUN.
2002-11-25 Per Cederqvist <ceder@ingate.com>
Bug 93 has been split into several bugs. Update the FIXME
comments that refered to bug 93.
* src/server/text.c (modify_text_info): Update FIXME comment.
* src/server/person.c (create_person): Update FIXME comment.
* src/server/connections.c (logout_client): Update FIXME comment.
* src/server/conference.c (do_delete_conf): Update FIXME comment.
(set_etc_motd): Ditto.
(modify_conf_info): Ditto.
* src/server/admin.c (set_motd_of_lyskom): Update FIXME comment.
2002-11-15 Per Cederqvist <ceder@ceder.dyndns.org>
Minor doc fixes.
* doc/Protocol-A.texi (mark-as-read): Added markup.
(set-unread): Ditto.
(get-membership): This was introduced in protocol version 11, not
10.
Added new requests 109=mark-as-unread and 110=set-read-ranges.
* doc/Protocol-A.texi (mark-as-unread): New request.
(set-read-ranges): New request.
(Error Codes): Added invalid-range and invalid-range-list.
* src/include/services.h (mark_as_unread): New request.
(set_read_ranges): New request.
* src/server/fncdef.txt: Added mark_as_unread and
set_read_ranges.
* src/server/membership.c (remove_loc_no): New static function.
(read_ranges_precondition): New static function.
(read_ranges_postcondition): New static function.
(mark_as_read): Extracted debug code to read_ranges_precondition
and read_ranges_postcondition.
(mark_as_unread): New function.
(check_range_list): New static function.
(set_read_ranges): New function.
* src/server/testsuite/lyskomd.0/01.exp: Test 109=mark-as-unread
and 110=set-read-ranges.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
Added parsing of "ARRAY Read-Range", aka read_range_list, needed
by request 110=set-read-ranges.
* doc/lyskomd.texi (Parameters): Document "Max read_ranges per
call".
* src/server/param.h (struct kom_par): Added max_read_ranges.
* src/server/server-config.c (parameters): Added "Max read_ranges
per call".
* src/server/prot-a.c (prot_a_destruct): Free read_range_list.
* src/server/prot-a-parse.h (prot_a_parse_read_range_list): New
function.
* src/server/prot-a-parse.c (prot_a_parse_read_range): New static
function.
(prot_a_parse_read_range_list): New function.
* src/server/prot-a-parse-arg-c.awk: Handle read_range_list.
* src/server/internal-connections.c (init_connection): Initialize
read_range_list.
* src/server/connections.h (Connection): Added read_range_list.
* src/server/connections.c (free_parsed): Free read_range_list.
* src/server/call-switch.awk: Handle read_range_list.
* src/include/kom-types.h (struct read_range_list): New struct.
* src/include/kom-errno.h (enum kom_err): Added KOM_INVALID_RANGE
and KOM_INVALID_RANGE_LIST.
2002-11-14 Per Cederqvist <ceder@ceder.dyndns.org>
Release administrativa.
* HACKING: Publish the NEWS file on the web when doing a release.
Test 107=query-read-texts and 108=get-membership even
more. (Bug 590).
* src/server/testsuite/lyskomd.0/bug-37.exp: Test
107=query-read-texts and 108=get-membership.
* src/server/testsuite/lyskomd.0/bug-37-2.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-37-3.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.
2002-11-13 Per Cederqvist <ceder@ceder.dyndns.org>
Release administrativa.
* HACKING: Make sure no closed bugs are left on the TODO list.
Test 107=query-read-texts and 108=get-membership.
* src/server/testsuite/lyskomd.0/bug-52.exp: Fixed a couple of
errors in the range-based test cases.
(checkit): Test 107=query-read-texts and 108=get-membership.
(checktrunc): New proc. Use it a few times to check that the new
requests can truncate the ranges of read texts.
* src/server/testsuite/lyskomd.0/03.exp: Be prepared that
query-read-texts-old now adjusts the read ranges. Test
107=query-read-texts and 108=get-membership. Renumber.
* src/server/testsuite/lyskomd.0/01.exp: Test 107=query-read-texts
and 108=get-membership. Renumber.
Implement 107=query-read-texts and 108=get-membership.
* src/server/prot-a.c (prot_a_reply): Handle rt_membership and
rt_membership_list.
* src/server/prot-a-output.h, src/server/prot-a-output.c
(prot_a_output_membership): New function.
(prot_a_output_membership_list): New function.
* src/server/person.c (do_query_read_texts): New arguments:
want_read_ranges and max_ranges. All callers updated. Call
adjust_read() if want_read_ranges is true.
(query_read_texts): New function.
* src/server/membership.c (copy_public_confs): New arguments:
keep_read and max_ranges. All callers updated.
(adjust_read): Now has external linkage. Changed return type from
void to Bool; return true if the membership was modified.
(do_get_membership): New arguments: keep_ranges and max_ranges.
Renamed the want_read_texts argument to want_read_ranges. All
callers updated.
(get_membership): New function.
* src/server/manipulate.h (adjust_read): Now has external
linkage.
* src/server/fncdef.txt: Added query_read_texts and
get_membership.
* src/server/connections.h (Connection): Added num4.
(enum res_type): Added rt_membership and rt_membership_list.
(union result_holder): Added membership and membership_list.
* src/include/services.h (get_membership): New function.
(query_read_texts): New function.
Documented new range-based requests get-membership and
query-read-texts. Renamed the old versions by adding a "-10"
suffix.
* doc/constructs.expected: Removed references to bug 52.
* doc/Protocol-A.texi (Membership and Reading): Talk about
read-ranges, not last-text-read and read-texts.
(Person Status Types): Mention read-ranges.
(Membership Information): Mention that obsolete versions of
Membership exists.
(Membership Information): Renamed Membership to Membership-10, and
added new Membership and Read-Range types.
(Protocol Requests): Flag 98=query-read-texts-10 and
99=get-membership-10 as obsolete. Added 107=query-read-texts and
108=get-membership.
(sub-member): Changed get-membership to get-membership-old, since
that is was the example uses. Added markup.
(mark-as-read): Changed query-read-texts to query-read-texts-old,
since that is what the example uses. Added markup.
(set-unread): Ditto.
(set-last-read): Ditto.
(query-read-texts-10): New name for former request
query-read-texts. Mark it as obsolete and refer to the new
query-read-texts request. Changed return type to Membership-10.
(get-membership-10): New name for former request
get-membership. Mark it as obsolete and refer to the new
get-membership request. Changed return type to ARRAY
Membership-10.
(query-read-texts): New request.
(get-membership): New request.
(Membership visibility): Added get-membership-10 and
query-read-texts-10.
(What do I have unread): Added markup.
(Future changes): Removed references to bug 52.
(Document Edition History): Tracked the renaming of
query-read-texts-10 and get-membership-10.
2002-11-12 Per Cederqvist <ceder@ceder.dyndns.org>
Added a "_10" suffix to type Membership and all derived types and
functions, in preparation of writing range-based replacements.
* src/server/fncdef.txt: Renamed functions:
query_read_texts -> query_read_texts_10
get_membership -> get_membership_10
Renamed types:
membership -> membership_10
membership_list -> membership_list_10
* src/include/services.h: Renamed functions:
query_read_texts -> query_read_texts_10
get_membership -> get_membership_10
* src/server/connections.h (enum res_type): Renamed:
rt_membership -> rt_membership_10
rt_membership_list -> rt_membership_list_10
(union result_holder): Renamed:
membership -> membership_10
membership_list -> membership_list_10
* src/server/prot-a.c (prot_a_reply): Use membership_old instead
of membership where appropriate. Track rename of *membership* to
*membership*_10.
* src/server/person.c (query_read_texts_10): Renamed from
query_read_texts.
* src/server/membership.c (get_membership_10): Renamed from
get_membership.
* src/server/prot-a-output.h, src/server/prot-a-output.c
(prot_a_output_membership_10): Renamed from
prot_a_output_membership.
(prot_a_output_membership_list_10): Renamed from
prot_a_output_membership_list.
Allow types in Protocol A to end in a number suffix.
* doc/checkargs.py (lexer.__bad_type): Allow types that ends in a
number, such as "Membership-10".
Testsuite: work on even slower computers.
* src/server/testsuite/config/unix.exp (timeout): Increase the
timeout even further.
Log message fixed.
* src/server/ram-parse.c (fparse_read_range_0): Fixed wrong
function name in a log message.
Ignore gcov-generated files in libeintr.
* src/libraries/libeintr/.cvsignore: Ignore *.bb, *.bbg and
*.da.
Doc typo fixed.
* doc/lyskomd.texi (Modifying Output Types): Typo fixed.
Fixed all known bugs in the range-based read-texts implementation.
* src/server/ram-parse.c (fparse_read_range_0): Don't forget the
first interval that is created based on last-text-read.
* src/server/membership.c (adjust_read): Aim at setting first_read
of the first range to 1, even if that is lower than the first
currently existing text in the conference. Make the code that
tries to extend ranges towards higher numbers more efficient -- no
loop is needed, since l2g_next_key can be used. Removed some dead
code.
* src/server/testsuite/lyskomd.0/bug-52.exp (start): Use serial
number 999 instead of 1000 to ease debugging.
2002-11-11 Per Cederqvist <ceder@ceder.dyndns.org>
Finish the test-suite for range-based representation. This
reveals at least two errors in the implementation.
* src/server/testsuite/lyskomd.0/bug-52.exp: Renumber and extend.
(do_restart): Set to 1.
(check_unread_confs): New proc. Use it several times.
2002-11-10 Kent Engstrm <kent@lysator.liu.se>
Add support for the mx-refuse-import aux item.
* run-support/aux-items.conf: Add mx-refuse-import [35].
* doc/Protocol-A.texi (Aux-Item Types): Ditto.
* doc/constructs.expected: Add @code{all}, @code{spam}.
* src/server/testsuite/lyskomd.0/01.exp: Fix to accept the
added aux item.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
* src/server/testsuite/lyskomd.0/18.exp: Ditto.
Add information about dependence on texinfo version.
* HACKING: Add entry about texinfo.
2002-11-10 Per Cederqvist <ceder@lysator.liu.se>
Make do_get_members() look nicer.
* src/server/membership.c (do_get_members): Minor code cleanup and
indentation fixes. Use init_member() to set all fields, and then
explicitly set (only) the secret bit.
2002-11-09 Per Cederqvist <ceder@ceder.dyndns.org>
Even more tests for the range-based representation.
* src/server/testsuite/lyskomd.0/bug-52.exp: Expand the test suite
and prepare it for range-based information commands.
(lazy_expand): New variable.
(mark_as_read_atomic): New variable.
(do_restart): New variable. This is currently set to 0 to hide
known errors...
(restart): New proc.
(checkit): New argument: ranges.
Added more tests of the range-based representation for read
texts.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
bug-52.data, bug-52.texts and bug-52.exp.
* src/server/testsuite/lyskomd.0/bug-52.exp: New file.
* src/server/testsuite/lyskomd.0/bug-52.data: New file.
* src/server/testsuite/lyskomd.0/bug-52.texts: New file.
* src/server/testsuite/config/unix.exp (unpack_db): New proc.
(lyskomd_start): New args: confs, texts and nogarb.
2002-11-06 Per Cederqvist <ceder@ceder.dyndns.org>
Use a range-based representation in core for the texts a user has
read. The external representation is not yet affected. (Bug 52).
* src/include/kom-types.h (struct read_range): New struct.
(Membership): Removed fields last_text_read, no_of_read and
read_texts. Added fields no_of_read_ranges, read_ranges and
skip_read_texts.
* src/server/ram-parse.c (fparse_read_range_0): New static
function that handles the new range-based representation of
memberships.
(fparse_membership_2): Use it.
(fparse_membership_0): Use it.
(fparse_membership_list_0): Handle the new range-based
representation of memberships.
(fparse_membership_list_2): Ditto.
* src/server/ram-output.c (foutput_read_ranges_0): New static
function that handles the new range-based representation of
memberships.
(foutput_membership_0): Use it.
(foutput_membership_2): Use it.
* src/server/prot-a-output.c (prot_a_output_read_texts): New
static function that handles the new range-based representation of
memberships.
(prot_a_output_membership_old): Use it.
* src/server/person.c (do_query_read_texts): Handle new
range-based representation of memberships.
* src/server/memory.c (clear_membership): Handle new
range-based representation of memberships.
(copy_membership): Ditto.
(init_membership): Ditto.
* src/server/membership.c (copy_public_confs): Handle new
range-based representation of memberships.
(adjust_read): Ditto.
(insert_loc_no): Ditto.
(do_add_member): Ditto.
(do_sub_member): Ditto.
(check_membership): Ditto.
(mark_as_read): Ditto.
(do_get_membership): Ditto.
(get_unread_confs): Ditto.
(set_unread): Ditto.
(set_last_read): Ditto.
(last_text_read): New static inline function.
* src/server/dbck.c (check_membership): Handle range-based
representation of memberships.
Xenofarm warnings.
* scripts/xenofarm.sh: Ignore warnings about reduced hard ulimit.
2002-11-05 Per Cederqvist <ceder@ceder.dyndns.org>
Spell-check Protocol-A.texi.
* HACKING: Spell-check Protocol-A.texi when a release is made.
* doc/Protocol-A.texi: A few spelling errors fixed.
Testsuite: timeout handling was broken.
* src/server/testsuite/config/unix.exp (fix_expect_after): Don't
unconditionally add a timeout pattern. Contrary to my belief, a
timeout pattern seems to refer to a specific spawn id. If we add
it here when there are no spawned processes, the timeout will
refer to stdin, and this will cause expect to detect eof on stdin
when run from Xenofarm. Instead, everything that spawns a process
must add timeout patterns to the expect_active variable.
(l2g_start): Add a timeout pattern to expect_active.
(lyskomd_start): Ditto.
(lyskomd_start_fail): Ditto.
(client_start): Ditto.
(client_start_fail): Ditto.
Test suite fixes.
* src/server/testsuite/config/unix.exp (dbck_run): Added missing
"global spawn_id".
* src/server/testsuite/lyskomd.0/12.exp: After dbck_run has
finished, we must re-specify which client we want to talk to.
The test suite didn't stop listening to lyskomd when it died.
* src/server/testsuite/config/unix.exp (lyskomd_death): Don't
listen to the lyskomd spawn id once it has died.
(kill_lyskomd): Ditto.
* src/server/testsuite/lyskomd.0/11.exp: Match all output.
Somehow this test didn't fail even though there were unmatched
output from lyskomd. Strange.
Never reuse text or conference numbers. (Bug 810).
* doc/lyskomd.texi (Parameters): New parameters: "Number file:"
and "Number temp file:".
* src/server/param.h (struct kom_par): Added numberfile_name and
numberfile_tmp_name.
* src/server/server-config.c (parameters): Added "Number file" and
"Number temp file".
(read_configuration): Handle them.
* src/server/simple-cache.c (highest_conf_no): Explicitly
initialize to 0.
(highest_text_no): Ditto.
(write_number_file): New static function.
(read_number_file): Ditto.
(cached_create_conf): Call write_number_file, and return
KOM_TEMPFAIL if it fails.
(cached_create_text): Ditto.
(init_cache): Don't set highest_conf_no and highest_text_no. They
are only used during the save phase. Call read_number_file.
* db-crypt/db/number.txt: New file.
* db-crypt/db/Makefile.am (EXTRA_DIST): Added number.txt.
(install-data-local): Install number.txt.
(uninstall-local): Remove number.txt. Don't remove anything if
number.txt is altered.
* src/server/testsuite/config/unix.exp (lyskomd_start): New
optional arguments: log_messages, init_db and want_stale. Copy
number.txt. Don't copy the database if init_db is 0. Expect a
log message about a removal of a stale lock file if want_stale is
1. Expect log_messages after the startup messages but before the
garb messages.
(lyskomd_fail_start): Copy number.txt.
* src/server/testsuite/lyskomd.0/bug-810.exp: Expect messages
about lost texts and conferences in the log. Don't expect any
failures.
2002-11-04 Per Cederqvist <ceder@ceder.dyndns.org>
Write test case for bug 810: retain text, person and conference
numbers after a crash.
* src/server/testsuite/config/unix.exp (kill_lyskomd): New proc.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
bug-810.exp.
* src/server/testsuite/lyskomd.0/bug-810.exp: Test that text,
person and conference number are never reused, not even when the
server crashes.
2002-11-04 Per Cederqvist <ceder@ingate.com>
Xenofarm: ignore warnings from assignment of SIG_IGN.
* scripts/xenofarm.sh: Updated list of warnings to ignore.
* src/server/ramkomd.c (set_handler_sig_ign): New function.
(server_init): Use it.
(go_daemon): Use it. This reduces the number of warnings on some
platforms.
2002-11-04 Per Cederqvist <ceder@ceder.dyndns.org>
Fixed a grammar error.
* doc/Protocol-A.texi (Document Edition History): Fixed grammar
error. Reported by Hans Persson.
Fixed typo.
* src/server/ram-smalloc.c: Fixed a typo in a comment.
Release administrativa that missed the deadline.
* README: Recommend the "-C" option of "./configure".
* HACKING: Updated with stuff found while performing the 2.0.7
release.
2002-11-03 Per Cederqvist <ceder@lysator.liu.se>
* Release 2.0.7.
2002-11-02 Per Cederqvist <ceder@ceder.dyndns.org>
Disable the extended tests for the release.
* src/server/testsuite/lyskomd.0/gen-19.py (EXTENDED): Reset to 0.
* src/server/testsuite/lyskomd.0/gen-15.py (EXTENDED): Reset to 0.
Not all makes sets RM, so do it manually in all Makefile.am.
* src/libraries/libeintr/Makefile.am (RM): Set it.
* run-support/Makefile.am (RM): Set it.
* db-crypt/db/Makefile.am (RM): Set it.
A few files lacked a copyright header.
* src/server/testsuite/lyskomd.0/summarize.sh: Added copyright
header.
* src/server/testsuite/bignum.c: Added copyright header.
* src/libraries/libeintr/gen-wrapper.awk: Added copyright header.
* src/libraries/libeintr/eintr.h.pre: Added copyright header.
Update the copyright updater.
* scripts/lyskomd-copyrights: Ignore generated files in libeintr
and the testsuite.
Run extended tests on the Xenofarm.
* src/server/testsuite/lyskomd.0/gen-19.py (EXTENDED): Set to 1.
* src/server/testsuite/lyskomd.0/gen-15.py (EXTENDED): Set to 1.
Fix the distribution.
* src/libraries/libeintr/Makefile.am (nodist_libeintr_a_SOURCES):
Added the nodist_ prefix, to avoid distributing these generated
files.
(MOSTLYCLEANFILES): Added the generated files.
Release administrativa.
* scripts/lyskomd-copyrights: Updated the copyright statement.
* README: Updated version numbers for TCL and expect. Updated
copyright statement.
* NEWS: Updated.
* HACKING: We actually use Python 2.1 for the release generation,
not 2.2.1. Extract the release from the Xenofarm build package.
* doc/Protocol-A.texi (Document Edition History): Updated with all
made changes.
Fixed a few minor problems with Protocol-A.texi.
* doc/Protocol-A.texi(Some Client-specific Aux-Item Types): New
name for the appendix formerly known as "Client-specific Aux-Item
Types". Another node of that name already exists!
(LysKOM Content Types): Fixed a typo.
(Membership visibility): Fixed typos.
(Order of misc-info groups): Fixed a typo.
2002-11-01 Per Cederqvist <ceder@ceder.dyndns.org>
The timeout of the test suite was too low.
* src/server/testsuite/config/unix.exp (timeout): Increase the
timeout further. Hal apparently needs it.
2002-10-31 Per Cederqvist <ceder@ceder.dyndns.org>
NFS-mounted databases may fail. Warn the administrator.
* README: Added a warning that NFS-mounted databases may fail due
to EINTR.
Added a library of wrapper functions that checks for EINTR.
* configure.in: Generate src/libraries/libeintr/Makefile.
* src/libraries/Makefile.am (SUBDIRS): Added libeintr.
* src/libraries/libeintr/gen-wrapper.awk: New file. Generate
simple wrappers that check for EINTR.
* src/libraries/libeintr/funcs.txt: New file. Use wrappers for
fopen, fclose and rename.
* src/libraries/libeintr/eintr.h.pre: New file.
* src/libraries/libeintr/Makefile.am: New file.
Use the libeintr wrappers instead of fopen, fclose and rename.
* src/server/Makefile.am (AM_CPPFLAGS): Added libeintr.
(lyskomd_LDADD): Ditto.
(dbck_LDADD): Ditto.
(LDADD): Ditto.
* src/server/updateLysKOM.c (main): Use i_fopen instead of fopen.
Don't forget to close the status file.
* src/server/splitkomdb.c (copy_file, copy_db_file): Use i_fopen
and i_fclose instead of fopen and fclose.
* src/server/simple-cache.c (is_clean, get_version, post_sync)
(save_one_text, sync_part, init_cache, free_all_cache): Use
i_fopen and i_fclose instead of fopen and fclose.
(pre_sync): Ditto, and i_rename instead of rename.
* src/server/ramkomd.c (save_pid, dump_exit_statistics): Use
i_fopen and i_fclose instead of fopen and fclose.
* src/server/ram-smalloc.c (trace_alloc_file): Use f_fopen
intstead of fopen.
* src/server/pidfile.c (read_pid_file): Use i_fopen and i_fclose
instead of fopen and fclose.
* src/server/komrunning.c (create_status): Use i_fopen and
i_fclose instead of fopen and fclose.
* src/server/dbck.c (garb_text_file): Use i_rename instead of
rename. Check the return value.
* src/server/dbck-cache.c (get_version, is_clean, cache_sync_all)
(cache_open_new_text_file, init_cache): Use i_fopen, i_fclose and
i_rename instead of fopen, fclose and rename.
* src/server/connections.c (dump_statistics): Use i_fopen and
i_fclose instead of fopen and fclose.
(dump_connections): Ditto, and i_rename instead of rename.
* src/server/conf-file.c (read_config): Use i_fopen and i_fclose
instead of fopen and fclose.
* src/server/aux-item-def-parse.y (parse_aux_item_definitions):
Use i_fopen and i_fclose instead of fopen and fclose.
2002-10-28 Per Cederqvist <ceder@ingate.com>
Check if rename really sets errno to EINTR.
* src/server/connections.c (dump_connections): Set errno to 0
before the rename that strangely returns with EINTR during the
Xenofarm tests.
* NEWS: Updated.
2002-10-28 Per Cederqvist <ceder@ceder.dyndns.org>
Make dump_connections more robust.
* src/server/connections.c (dump_connections): Call fflush() and
ferror(). This might help track down spurious errors from the
rename that I don't understand.
Release administrativa.
* HACKING: Mention "make distcheck".
Test suite cleanup.
* scripts/xenofarm.sh: Removed the "eintr" task.
2002-10-28 Per Cederqvist <ceder@lysator.liu.se>
Port to AIX 4.2: limit the number of open file descriptors
properly.
* src/server/connections.c (toploop) [!USING_RLIMIT_NOFILE]: Fixed
a off-by-one error.
Fixed compile error on systems lacking SA_RESTART.
* src/server/ramkomd.c (setup_sighandlers): Added a missing
semicolon.
2002-10-27 Per Cederqvist <ceder@ceder.dyndns.org>
Testsuite fixes. Don't use __FILE__ in log messages, as it isn't
very useful, and makes the test suite more complex.
* src/server/testsuite/lyskomd.0/connections-cov.exp: Don't expect
the "connections.c" file name in the log message, as that broke
when doing an srcdir build.
* src/server/text.c (is_member_in_recpt): Don't use __FILE__.
(do_sub_recpt): Ditto.
(check_double_subm): Ditto.
(check_double_comm): Ditto. Fix the function name in a log
message.
* src/server/memory.c (clear_text_stat): Don't use __FILE__. Fix
the function name in a log message.
* src/server/connections.c (dump_statistics): Don't use __FILE__.
Don't require bison/yacc when compiling. (Bug 843).
* src/server/Makefile.am: The explicit dependencies added
2002-10-21 to fix "make clean; make check" was broken: the ".c"
extension was used instead of ".o" in several cases. This
resulted in bison being run on the client.
Consider FD_SETSIZE.
* src/server/ramkomd.c (initialize): Don't allow the number of
open files to be larger than FD_SETSIZE.
* src/server/testsuite/testfd.c (find_limits): Report FD_SETSIZE.
2002-10-27 Per Cederqvist <ceder@lysator.liu.se>
Testsuite fixes.
* src/server/testsuite/lyskomd.0/11.exp: Fixed a race condition in
the test.
* src/server/testsuite/config/unix.exp (obtain_lock): Search for
locksuite.py in $srcdir.
(lyskomd_start): Removed unused global declaration of srcdir.
(lyskomd_fail_start): Ditto.
(client_death): Ditto.
2002-10-27 Per Cederqvist <ceder@ceder.dyndns.org>
Port to AIX 4.2: limit the number of open file descriptors in a
more portable way.
* src/include/kom-config.h (PROTECTED_FDS): Added parenthesis
around the number.
(MAX_NO_OF_CONNECTIONS): Removed.
(USING_RLIMIT_NOFILE): Define if we have a good setrlimit.
(fd_ceiling): New variable.
* src/server/server-config.c (MAX_NO_OF_CONNECTIONS): Removed.
(fd_ceiling): New variable.
* src/server/connections.c (toploop): Transform ISC_EVENT_LOGIN to
ISC_EVENT_LOGIN_UNRELOCATED if the file descriptor is above
fd_ceiling. This can only happen if USING_RLIMIT_NOFILE is
undefined, so ifdef out this code.
* src/server/ramkomd.c (go_daemon): Close everything below
fd_ceiling instead of using MAX_NO_OF_CONNECTIONS + PROTECTED_FDS.
(initialize): Use getrlimit/setrlimit if USING_RLIMIT_NOFILE is
defined. Check that getrlimit after setrlimit returns a sane
value. Don't use sysconf(_SC_OPEN_MAX), since getrlimit provides
a better value. Set fd_ceiling instead of MAX_NO_OF_CONNECTIONS.
Make it possible to lower the ceiling even when we don't have a
working setrlimit. Removed the final sanity checks; the world
ain't sane.
* src/server/testsuite/testfd.c (main): Adjusted logic for error
checks to be similar to the code now used. In particular, don't
test sysconf(_SC_OPEN_MAX), and don't test getrlimit if
HAVE_BROKEN_NOFILE.
2002-10-26 Per Cederqvist <ceder@lysator.liu.se>
Prepare for more portable handling of the number of file
descriptors used.
* configure.in: Define HAVE_BROKEN_NOFILE if
setrlimit(RLIMIT_NOFILE) fails.
2002-10-26 Per Cederqvist <ceder@ceder.dyndns.org>
Update the testsuite so that it doesn't fail because of
SA_RESTART/select() on HP-UX.
* src/server/testsuite/Makefile.am (check-test-select): Pass
--no-sa-restart to test-select, so that we test the code the way
we actually use it.
* src/server/testsuite/test-select.c (main): New argument:
--no-sa-restart. Don't use SA_RESTART if given.
Port to HP-UX: Use SA_RESTART except while calling select().
* src/server/sigflags.h (restart_syscalls_on_intr): New function.
(intr_syscalls_on_intr): New function.
* src/server/ramkomd.c (setup_sighandlers): New function. Use
SA_RESTART if the "restartable" argument is true.
(restart_syscalls_on_intr): New function.
(intr_syscalls_on_intr): New function.
(main): Move signal handler setup to setup_sighandlers().
* src/server/connections.c (toploop): Call intr_syscalls_on_intr()
before calling isc_getnextevent, and restart_syscalls_on_intr()
immediately after its return.
2002-10-26 Per Cederqvist <ceder@lysator.liu.se>
Port to SunOS 4.1.1_U1 that lacks SA_RESTART.
* src/server/testsuite/test-select.c (main): Call link_ansi().
Only set SA_RESTART if it is available.
* src/server/testsuite/Makefile.am (test_select_LDADD): New
variable.
2002-10-26 Per Cederqvist <ceder@ceder.dyndns.org>
Use SA_RESTART.
* src/server/ramkomd.c (main): Use SA_RESTART, even though it
potentially will cause lyskomd to block in select() instead of
responding promptly to signals.
Check that SA_RESTART can interrupt select().
* src/server/testsuite/test-select.c: Test if select() can be
interrupted by a signal even when SA_RESTART is specified.
* src/server/testsuite/Makefile.am (check_PROGRAMS): Added
test-select.
(test_select_SOURCES): New variable.
(check): Added check-test-select.
(check-test-select): New target.
* scripts/xenofarm.sh: Added eintr test, to check the
select/SA_RESTART in a separate task.
Fixed a race condition in the test suite.
* src/server/testsuite/tcpconnect.py: Flush stdout more often.
Give feedback on "#supsend socket" and "#resume socket" to avoid a
race condition.
* src/server/testsuite/config/unix.exp (kill_client): Include the
client number in the test name when testing for stray output.
This makes it easier to see which client that misbehaves.
(suspend_client): Expect a response from the client.
(resume_client): Ditto.
2002-10-25 Per Cederqvist <ceder@ceder.dyndns.org>
The test suite now test for buffer overflow in the proper way.
(Bug 844).
* src/server/testsuite/config/unix.exp (l2g_start): Test for
"full_buffer". An old expect document has fooled us to test for
"buffer_full" instead; that doesn't work.
(simple_expect): Ditto.
(good_bad_expect): Ditto.
(extracting_expect): Ditto.
(unanchored_expect): Ditto.
(lyskomd_start): Ditto.
(lyskomd_fail_start): Ditto.
(client_start): Ditto.
(client_start_fail): Ditto.
The test suite failed when configured with --with-debug-calls.
* src/server/testsuite/config/unix.exp (lyskomd_fail_start):
Handle --with-debug-calls compilations.
* src/server/testsuite/lyskomd.0/09.exp: Handle --with-debug-calls
compilations.
* src/server/testsuite/lyskomd.0/admin-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/conference-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/person-cov.exp: Ditto.
Improve a few log messages.
* src/server/person.c (do_set_user_area): Improve the "Old
user_area X unmarked" message.
* src/server/conference.c (do_set_presentation): Improve the "Old
presentation not marked" message.
(do_set_etc_motd): Improve the "New motd has X marks" and "Old
motd not marked" messages.
* src/server/admin.c (set_motd_of_lyskom): The "Old motd not
marked" message used the wrong function name.
Log the reason why the connection status file cannot be renamed.
(Bug 841).
* src/server/connections.c (dump_connections): Emit
strerror(errno) when file operations fails.
2002-10-23 Per Cederqvist <ceder@ceder.dyndns.org>
Plugged a memory leak. (Bug 816).
* src/server/prot-a.c (prot_a_destruct): Clear dummy_aux_item, to
plug a memory leak. To trigger this leak, you had to send an
oversized aux-item-list, that contained an oversized string in the
last part of the oversized array, and disconnect while sending the
last part of the string.
Test client disconnect more thoroughly. (Bug 63).
* src/server/testsuite/lyskomd.0/29.exp: Several more test cases
added. We now trigger bug 816.
(startup): Reduce "Max aux_item length" and "Max links per text".
Test suite fixes.
* src/server/testsuite/lyskomd.0/03.exp: Wait for a third tick.
This test failed on computers that were too fast, due to the
script waiting too short a time.
* src/server/testsuite/config/unix.exp (lyskomd_start): Added a
missing dot that caused --with-debug-calls tests to fail.
Clients should offer to add the letterbox of the author if he
isn't a member of any of the recipients.
* doc/Protocol-A.texi (Recipients of comments): Added a
description of what to do when the author of a new comment isn't a
member of any of the recipients.
Added option "-f" (stay in foreground) to lyskomd. "-d" no longer
implies "stay in foreground".
* src/server/ramkomd.c (foreground): New static variable.
(go_daemon): Stay in foreground if given -f, not -d.
(initialize): Prompt the operator for confirmation when given -f,
not -d.
(main): Ditto. Handle -f: stay in foreground.
* doc/lyskomd.texi (Invoking lyskomd): Documented the new -f
option.
Let the test suite check all output from lyskomd.
* src/server/testsuite/config/unix.exp (maxint): Unused constant
removed.
(lyskomd_expect): New proc.
(spawn_lyskomd): Use -f, not -d.
(lyskomd_start): Check all output from lyskomd.
(lyskomd_fail_start): Ditto.
(lyskomd_death): New argument: reason. Check all output from
lyskomd.
(talk_to): Set current_talk_what and current_talk_nr, so that
lyskomd_expect can restore the old settings. Set proper
line_leader for lyskomd.
* src/server/testsuite/lyskomd.0/03.exp: Check all output from
lyskomd.
* src/server/testsuite/lyskomd.0/05.exp: Ditto.
* src/server/testsuite/lyskomd.0/06.exp: Ditto.
* src/server/testsuite/lyskomd.0/24.exp: Ditto.
* src/server/testsuite/lyskomd.0/25.exp: Ditto.
* src/server/testsuite/lyskomd.0/27.exp: Ditto.
* src/server/testsuite/lyskomd.0/admin-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-349.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-37-2.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-37-3.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-37.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-612.exp: Ditto.
* src/server/testsuite/lyskomd.0/conf-file-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/conference-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/connections-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/gen-15.py: Ditto.
* src/server/testsuite/lyskomd.0/gen-19.py: Ditto.
* src/server/testsuite/lyskomd.0/membership-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/person-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/send-async-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/session-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/text-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/11.exp: Use the -f argument of
lyskomd, not -d. Pass the reason argument to lyskomd_death.
* src/server/testsuite/lyskomd.0/07.exp: Pass the reason argument
to lyskomd_death.
Test suite cleanup.
* src/server/testsuite/lyskomd.0/29.exp: Removed spurious newline
from the log file.
Fixed a race condition in the test suite. (Bug 692).
* src/server/testsuite/lyskomd.0/18.exp: Check all output from
lyskomd. Closes bug 692.
* src/server/ramkomd.c (sighandler_winch): Moved log message to
toploop().
* src/server/connections.c (toploop): Log a message when SIGWINCH
has been processed and the aux definitions reloaded.
Fixed a false log message about a memory leak. (Half of Bug 816).
* src/server/prot-a.c (prot_a_destruct): Set c_local_text_no_p to
NULL after freeing it, to avoid logging "kill_client(): unexpected
local_text_no remains." when a client disconnects while sending a
c_local_text_no_p array.
Clean up the output from lyskomd.
* src/server/conf-file.c (configure_line): Don't add blank lines
to the log.
* src/server/aux-items.c (aux_item_validate): Added a trailing dot
to a log message.
* src/server/aux-item-def-parse.y: Fixed typo in a log message.
2002-10-21 Per Cederqvist <ceder@ceder.dyndns.org>
Don't crash if a client sends the length of an aux-item list and
disconnects before sending the "{". Fixed similar code for other
arrays.
* src/server/prot-a-parse.c (prot_a_parse_num_list): Don't set
res->length until res->data is allocated.
(prot_a_parse_misc_info_list): Ditto.
(prot_a_parse_aux_item_list): Ditto. Without this fix, a client
can cause a crash by sending the length of the list, and
disconnect before sending the "{".
(prot_a_parse_string): Add an additional comment explaining why a
client_len field should be added (bug 162).
Fix testsuite.
* src/server/testsuite/lyskomd.0/29.exp: Expect bug 836:
mark-text-as-read gives a protocol error response instead of the
error code long-array when an overly long array is sent to the
server.
"make clean; make check" failed.
* src/server/Makefile.am: Added explicit dependencies so that
"make clean; make check" no longer fails.
Added missing semicolon i bison file.
* src/server/aux-item-def-parse.y (action): Inserted a missing
semicolon.
Fixed a testsuite bug.
* src/server/testsuite/lyskomd.0/prot-a-send-async-cov.exp: Use
client_death instead of kill_client after receiving the "%% No
connections left" message.
* src/server/testsuite/lyskomd.0/send-async-cov.exp: Ditto.
2002-10-20 Per Cederqvist <ceder@ceder.dyndns.org>
Test client disconnect while while the client has sent partial
requests.
* src/server/testsuite/lyskomd.0/29.exp: New file: test for client
disconnect.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
29.exp.
Testsuite: check for unexpected data sent to clients immediately
before they are killed.
* src/server/testsuite/config/unix.exp (kill_client): Look for
stray output before killing the client.
Testsuite framework: make it possible to send incomplete lines to
the server.
* src/server/testsuite/tcpconnect.py: Added support for sending
incomplete lines to the server via the "#nocr" instruction.
2002-10-18 Per Cederqvist <ceder@ceder.dyndns.org>
Minor doc improvement.
* doc/Protocol-A.texi (Auxiliary Information): Added a reference
to Aux-Item Types.
2002-10-17 Per Cederqvist <ceder@ceder.dyndns.org>
Fixed a broken lookup-z-name example.
* doc/Protocol-A.texi (lookup-z-name): "T C" doesn't match "Trains
(-) Discussion", so remove it from the result. Reported by Hans
Persson.
2002-10-16 Per Cederqvist <ceder@ceder.dyndns.org>
Fixed a typo.
* doc/Protocol-A.texi (Membership Information): Fixed typo:
"added-by", not "added-byp".
2002-10-15 Per Cederqvist <ceder@ceder.dyndns.org>
Better logging of leaks during client disconnect.
* src/server/internal-connections.c (kill_client): Log left-overs
from misc_info_list and local_text_no separately.
2002-10-14 Per Cederqvist <ceder@ceder.dyndns.org>
Port testfd.c to SunOS 5.4.
* src/server/testsuite/testfd.c (find_limits): The code failed to
compile unless HAVE_GETDTABLESIZE. Flush stdout before writing
something to stderr.
(main): Flush stdout before writing something to stderr.
2002-10-13 Per Cederqvist <ceder@ceder.dyndns.org>
Gather more info about file descriptor usage.
* src/server/testsuite/testfd.c: Lower the limit using setrlimit
and test the limits afterwards as well. Report an error if the
assumptions made by lyskomd do not hold.
2002-10-12 Per Cederqvist <ceder@ceder.dyndns.org>
File descriptor counting on AIX is apparently wrong. Collect some
information from the farm.
* scripts/xenofarm.sh: Run check-testfd as a separate task, so
that the info can be easily collected.
* src/server/testsuite/Makefile.am (check_PROGRAMS): Added testfd.
(testfd_SOURCES): New variable.
(check): Added check-testfd.
(check-testfd): New target.
* src/server/testsuite/testfd.c: New test program.
Handle a failure mode that seems to occur.
* src/server/testsuite/lyskomd.0/11.exp: Handle one case of early
lyskomd death.
Improve testsuite lock handling.
* src/server/testsuite/locksuite.py (try_symlink): Break stale
lock files.
2002-10-11 Per Cederqvist <ceder@ceder.dyndns.org>
Removed obsolete Xenofarm compatibility cruft.
* scripts/xenofarm.sh: Removed old Xenofarm compatibility stuff,
including the --compat argument and the ability to give the
compiler to use as an argument. Added the --make argument.
2002-10-09 Per Cederqvist <ceder@ceder.dyndns.org>
Use AM_CPPFLAGS instead of the obsolete variable INCLUDES.
* src/server/testsuite/Makefile.am (AM_CPPFLAGS): New name for
former INCLUDES.
* src/server/Makefile.am: (AM_CPPFLAGS): New name for former
INCLUDES.
* src/libraries/libmisc/Makefile.am (AM_CPPFLAGS): New name for
former INCLUDES.
* src/libraries/libcommon/Makefile.am (AM_CPPFLAGS): New name for
former INCLUDES.
* src/libraries/libansi/Makefile.am (AM_CPPFLAGS): New name for
former INCLUDES.
2002-10-07 Per Cederqvist <ceder@ceder.dyndns.org>
Xenofarm builds could get stuck forever on a stale lock file.
* src/server/testsuite/config/unix.exp (obtain_lock): This failed
to break stale locks if the host name contained for instance a
dot. So this failed if a FQDN name is used.
2002-10-06 Per Cederqvist <ceder@ceder.dyndns.org>
Fix the doc fix.
* doc/lyskomd.texi (Template for ram-parse.c): Break a too long
line.
2002-10-06 Daniel Andersson <daniel@ds.hj.se>
Doc fix. (Bug 814).
* doc/lyskomd.texi (Template for ram-output.c): Corrections to
function names etc.
(Template for ram-parse.c): Ditto.
2002-10-06 Per Cederqvist <ceder@ceder.dyndns.org>
Xenofarm cleanup.
* scripts/xenofarm.sh: Removed special cases for aristocat,
moghedien and lysator. Path setup et c is better handled in the
configuration files of the corresponding computer.
Fix configure tests for <sys/resource.h> and rlim_t.
* configure.in: When checking for rlim_t in <sys/resource.h>, and
when checking for <sys/resource.h> itself, include <time.h> and
<sys/time.h> in the proper way. Both these tests were made too
early.
2002-10-05 Per Cederqvist <ceder@ceder.dyndns.org>
Update Xenofarm configuration of asmodean and moghedien.
* scripts/xenofarm.sh: asmodean is no longer used by Xenofarm.
moghedien needs runtest, but not a special makeinfo. Also,
"uname -n" doesn't return a FQDN there.
Send a broadcast message when the server fails to save the
database. (Bug 813).
* src/server/simple-cache.c (sync_part): Send a broadcast message
to everyone if the save failed. Patch from Daniel Andersson,
slightly edited.
Get rid of some compiler warnings about conversions between char
and unsigned char.
* src/include/kom-config.h, src/server/server-config.c
(WHITESPACE): Changed type from const unsigned char* to const
char* to remove some compiler warnings.
* src/libraries/libmisc/s-string.h,
src/libraries/libmisc/s-string.c (s_usr_strcmp): Changed type of
collat_tab argument from char to unsigned char.
(s_usr_strhead): Ditto.
* src/libraries/libcommon/parser.h,
src/libraries/libcommon/parser.c (match): Changed type of
collat_tab argument from char to unsigned char.
(parse): Ditto.
* src/server/regex-match.c (lookup_regexp): Cast the "pattern"
argument of re_compile_pattern to char* to get rid of a warning.
(lookup_regexp): Cast the "string" argument of re_search to char*
to get rid of a warning.
* src/server/aux-items.c (aux_item_definition_cache_regexp):
Don't set the translate field of the pattern buffer to
DEFAULT_COLLAT_TAB. That causes a warning. The field is anyhow
set to NULL on the next line, as it should be.
(aux_item_validate): Cast the "string" argument of re_search to
char* to get rid of a warning.
2002-10-04 Per Cederqvist <ceder@ceder.dyndns.org>
Xenofarm refinements.
* scripts/xenofarm.sh: Remove makewarn.txt and ckprgwarn.txt if
they are empty. Create ckprgfail.txt and cause the ckprg steg to
fail if the string "error" is found in the output (case
insensitive).
Change s_free() to s_clear() in comments in s-string.h.
* src/libraries/libmisc/s-string.h: Two comments mentioned
s_free(), but the actual name of the function is s_clear().
Fixed the comments.
2002-10-02 Per Cederqvist <ceder@ingate.com>
Watch for runtest problems.
* scripts/xenofarm.sh: Added "error" to the list of strings that
should cause ckprg to flag a warning.
Remove warnings about unused libraries from the test suite.
* src/server/testsuite/test-l2g.c (main): Call link_ansi().
* src/server/testsuite/Makefile.am (test_l2g_LDADD): Removed
$(LDADD). Added libmisc.a, liblyskom-server.a and libansi.a.
(LDADD): Removed. The bignum program doesn't need any of this,
and test-l2g only needs parts of it.
(INCLUDES): Added libansi.
2002-10-02 Per Cederqvist <ceder@ceder.dyndns.org>
Port to the ecc compiler.
* acinclude.m4 (CMOD_C_ATTRIBUTE_UNUSED): Improve the test, by
checking that __attribute__((unused)) is accepted in a function
declaration. The ecc compiler on Linux/ia64 seems to accept it
and give a warning when used on a local variable, but chokes on
it when used in a function declaration.
* scripts/xenofarm.sh: Ignore a warning created by
__attribute__((format)) when compiling with ecc.
Get more info from Xenofarm builds.
* scripts/xenofarm.sh: Retrieve config.log and
src/libraries/libisc-new/config.log.
2002-10-01 Per Cederqvist <ceder@ceder.dyndns.org>
Doc fix.
* doc/man/dbck.8: Refer to lyskomd.info, not dbck.info.
2002-09-28 Per Cederqvist <ceder@ceder.dyndns.org>
Xenofarm warning handling.
* scripts/xenofarm.sh: Fixed a warning regexp.
2002-09-19 Per Cederqvist <ceder@ceder.dyndns.org>
Get rid of a warning. Xenofarm warning handling.
* src/server/conference.c (do_lookup): Introduce a new variable
letterflag to get rid of a compiler warning from gcc-2.7.2.2 on
AIX.
* scripts/xenofarm.sh: Check for warnings during configure and
ckprg. Ignore a few more warnings during make.
2002-09-10 Per Cederqvist <ceder@ceder.dyndns.org>
Remove warnings about unused libraries.
* src/server/updateLysKOM.c (main): Call link_ansi().
* src/server/splitkomdb.c (main): Call link_ansi().
* src/server/ramkomd.c (main): Call link_ansi().
* src/server/komrunning.c (main): Call link_ansi().
* src/server/dbck.c (main): Call link_ansi().
* src/server/Makefile.am (INCLUDES): Added libansi.
(lyskomd_LDADD): New variable.
(dbck_LDADD): New variable.
(LDADD): Removed several libraries that the other programs don't
use.
* src/libraries/libansi/empty.c (link_ansi): New function.
(neveruse): Removed.
* src/libraries/libansi/Makefile.am (libansi_a_SOURCES): Added
linkansi.h.
* src/libraries/libansi/linkansi.h: New file.
(link_ansi): New function.
Ignore a warning from <vnode.h>.
* scripts/xenofarm.sh: Ignore a harmless warning from
/usr/include/sys/vnode.h.
2002-09-09 Per Cederqvist <ceder@ingate.com>
Port to SunOS 4.1.1_U1 which lacks rlim_t.
* configure.in: Check for rlim_t.
* src/server/ramkomd.c [!HAVE_RLIM_T]: typedef rlim_t to int.
No wonder locksuite.py failed: it wasn't distributed!
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
locksuite.py. Sorted the lines.
Xenofarm went amok on some computers, where locksuite.py fails.
* src/server/testsuite/config/unix.exp (obtain_lock): Don't loop
forever if we get an unexpected eof from locksuite.py.
2002-09-09 Per Cederqvist <ceder@ceder.dyndns.org>
Lock the test suite so that only one run at a time is performed.
* src/server/testsuite/config/unix.exp (lock_count): New variable.
(obtain_lock): New proc.
(release_lock): New proc.
(l2g_start): Get the lock.
(l2g_stop): Release it.
(lyskomd_start): Get the lock.
(lyskomd_fail_start): Get and release the lock.
(lyskomd_death): Release it.
(client_start_fail): Get and release the lock
* src/server/testsuite/lyskomd.0/11.exp: Release the lock.
2002-09-08 Per Cederqvist <ceder@ceder.dyndns.org>
Prepare for locking the test suite.
* src/server/testsuite/config/unix.exp (clientport): Comment updated.
* src/server/testsuite/locksuite.py: New file. This is a basic
building block for preventing simultaneous test runs on the same
computer or in the same directory.
Get rid of some compiler warnings.
* src/include/kom-types.h (Info): Change highest_aux_no from long
to unsigned long, since that is what aux_item_list_add_items()
wants it to be.
* configure.in: Check for crypt only if crypt isn't found in libc.
More Xenofarm improvements.
* scripts/xenofarm.sh: Include config.h in the result package.
Ignore warnings about duplicate volatile. These are due to AIX
apparently including volatile in sig_atomic_t.
2002-09-07 Per Cederqvist <ceder@ceder.dyndns.org>
Better support for building multiple configurations under Xenofarm.
* scripts/xenofarm.sh: Implement --cfg option. Removed special
setup for moria.
Tweak types and add a few casts to get rid of several gcc warnings.
* src/server/splitkomdb.c (copy_file): Changed type of sz from int
to size_t to get rid of compiler warnings.
* src/server/simple-cache.c (init_cache): Replaced "i" with "ic"
and "it" to get rid of warnings when the wrong type was used.
* src/server/ramkomd.c (initialize): Added casts to remove warnings.
* src/server/ram-parse.c (fparse_aux_item_link): Added cast to
remove warning.
* src/server/prot-a.c (prot_a_parse_packet): Added cast to remove
warning.
* src/server/local-to-global.h (l2g_set_block_size): Comment
updated.
* src/server/local-to-global.c (l2g_append): Added cast to remove
warning.
(l2g_expensive_set): Ditto.
(l2g_expensive_set): Ditto.
* src/server/dbck.c (motd_of_lyskom): Now a Text_no, not int.
(main): Use atol, not atoi, when setting motd_of_lyskom.
* src/server/dbck-cache.c (next_free_num): Change type to
Conf_no. Added static qualifier.
(cache_sync_all): Replaced the local variable "i" with "ic" and
"it", for loops over conferences and texts.
(init_cache): Changed type of "i" to unsigned long. Changed type of
motd_of_lyskom to Text_no.
* src/server/connections.h, src/server/connections.c
(num_fnc_defs): Change type to int.
Make Xenofarm ignore a few warnings in code that we didn't write.
* scripts/xenofarm.sh: Ignore warnings from aux-item-def-scan.c
about defined stuff that isn't used. This is an auto-generated
file, and we can't help that it includes a few unused labels and
functions. Ignore warning from getopt about a function
declaration that isn't a prototype. Ignore cast warnings in
<bits/socket.h>.
2002-09-04 Per Cederqvist <ceder@ceder.dyndns.org>
Fix bugs in last commit.
* scripts/xenofarm.sh: More portable handling of "(W)".
Process all options, not just the first.
2002-09-03 Per Cederqvist <ceder@ceder.dyndns.org>
Xenofarm improves. Adapt.
* scripts/xenofarm.sh: Handle the --compat option. Handle
compilers that flag warnings with the string "(W)".
2002-08-25 Per Cederqvist <ceder@ceder.dyndns.org>
Create Xenofarm warning indications.
* scripts/xenofarm.sh: Check for warnings during the build.
2002-08-24 Per Cederqvist <ceder@ceder.dyndns.org>
* NEWS: Updated.
2002-08-23 Per Cederqvist <ceder@ceder.dyndns.org>
Remove false xenofarm failures.
* scripts/xenofarm.sh: Run without optimization and with an old
version of gcc, to make valgrind more happy.
Port to Solaris 2.4.
* src/server/connections.c (login_request): Don't use snprintf.
It's not portable.
2002-08-22 Per Cederqvist <ceder@ceder.dyndns.org>
Compile with more than one compiler on Xenofarm.
* scripts/xenofarm.sh: Take an optional argument: the name of the
compiler to use. Include it in machineid.txt, and pass it to the
configure script.
Solaris 2.4 porting.
* src/libraries/libmisc/s-collat-tabs.c,
src/libraries/libmisc/s-collat-tabs.h:
(swedish_collate_tab, english_collate_tab): Use unsigned char, not
signed char, to get rid of a warning from SparcWorks 5.1 under
Solaris 2.4.
The info about elisp-client-specific aux-items is informative
only. (Bug 726).
* doc/Protocol-A.texi (Aux-Item Types): Moved
elisp-client-read-faq [10000] and
elisp-client-rejected-recommendation [10001] to an appendix.
(Client-specific Aux-Item Types): New appendix.
(Document Edition History): Fixed broken @xref usage.
* doc/Makefile.am (check-doc): Handle the "Client-specific
Aux-Item Types" appendix.
2002-08-20 Per Cederqvist <ceder@ceder.dyndns.org>
Release administrativa.
* doc/Protocol-A.texi (Order of misc-info groups): Fix typo.
(Document Edition History): Updated edition 10.7 according to the
NEWS file from 2002-08-17.
* NEWS: "common block", not "common area".
2002-08-20 Per Cederqvist <ceder@ingate.com>
Document how lines in a text are separated. Document the order of
misc-info groups.
* doc/Protocol-A.texi (create-text): Say "Misc-Info items", not
"misc-items".
(LysKOM Content Types): There should be no linefeed after the last
line.
(Reformattable Text (text/x-kom-basic)): Ditto.
(Order of misc-info groups): New node.
The test suite failed on certain slow machines.
* src/server/testsuite/config/unix.exp: Increase the timeout.
2002-08-20 Per Cederqvist <ceder@ceder.dyndns.org>
Code cleanup.
* src/server/testsuite/config/unix.exp (lyskomd_start): Removed an
unused global declaration.
The test suite failed on 64-bit platforms.
* src/server/testsuite/bignum.c: New program.
* src/server/testsuite/Makefile.am (check_PROGRAMS): Added bignum.
(bignum_SOURCES): New variable.
(check-lyskomd): Depend on bignum.
* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Use bignum
to find a suitable big number.
Don't include <sys/time.h> when it isn't available.
* src/server/connections.c: Fix include guards for <time.h> and
<sys/time.h>.
* src/server/ramkomd.c: Ditto.
Xenofarm tweaks.
* scripts/xenofarm.sh: Store error message from "import socket" in
the proper log file. Run valgrind on moria.
2002-08-19 Per Cederqvist <ceder@ceder.dyndns.org>
Increase test suite portability.
* src/server/testsuite/lyskomd.0/18.exp (copy_aux): Don't use
"file copy", since that isn't portable to old TCL versions.
Fixed test suite typos.
* src/server/testsuite/config/unix.exp (l2g_start): Fixed typo:
";wait" should not be part of the fail string.
(lyskomd_fail_start): Ditto.
(client_start): Ditto.
(client_start_fail): Ditto.
Xenofarm refinements.
* scripts/xenofarm.sh: Don't bother running the tests of python
cannot import socket.
2002-08-18 Per Cederqvist <ceder@ceder.dyndns.org>
Increase test suite portability.
* src/server/testsuite/lyskomd.0/18.exp (copy_aux): Don't use
"file delete", since that isn't portable to old TCL versions.
Make the Xenofarm result pages more readable.
* scripts/xenofarm.sh: Shorten the header names.
Break out "dvi" and "pdf" from Xenofarm task "checkdoc".
* scripts/xenofarm.sh: Make check-doc, pdf and dvi separately,
instead of using the "make check" target of the doc subdirectory.
Don't attempt to "make pdf" unless we find pdftex.
Don't attempt to "make dvi" unless we find texi2dvi and tex.
2002-08-17 Per Cederqvist <ceder@ceder.dyndns.org>
Don't require "grep -f" and "tac" to check the documentation.
* doc/filterlines.py: New file, that we can use instead of the
non-portable "grep -v -f ...".
* doc/tac.py: New file, that replaces the "tac" program.
* doc/Makefile.am (check-doc): Use filterlines.py instead of "grep
-v -f ...". Adjust the contents of several temporary files
accordingly: they now contains lines to ignore, not regexp
patterns to ignore. Use tac.py instead of tac; not everybody has
GNU textutils installed.
(EXTRA_DIST): Added filterlines.py and tac.py.
* scripts/xenofarm.sh (checkdocok): "grep -f" and tac are no
longer required to "make check" in the doc subdirectory.
Xenofarm refinements.
* scripts/xenofarm.sh: Attempt to identify the version of the C
compiler and the makeinfo program.
Flag automatically generated files.
* src/server/testsuite/lyskomd.0/gen-15.py: Insert a warning in
the output that the result is automatically generated.
* src/server/testsuite/lyskomd.0/gen-19.py: Ditto.
* src/server/Makefile.am (aux.h): Se the mode of this generated
file to 444, to avoid accidental edits.
Portability fix.
* configure.in: Use "test x && test y" instead of "test x -a y",
since the -a option is less portable than the "&&" construct.
Update copyright headers.
* <all files>: update the year in the copyright notice.
* scripts/lyskomd-copyrights: Updated the list of files to ignore.
* src/server/testsuite/renumber.el: Copyright header added.
Xenofarm integration.
* scripts/xenofarm.sh: New file. This version was taken from
revision 1.9 of projects/lyskom-server/source-transform.sh in the
xenofarm CVS module, and a copyright header and some initial
comments were added.
* scripts/Makefile.am (EXTRA_DIST): Added xenofarm.sh.
* Makefile.am (ident-cc): New target.
* doc/Makefile.am (ident-makeinfo): New target.
Release administrativa.
* HACKING: Mention gpg, the paths of the FTP an WWW servers, a few
web pages, and Freshmeat.
* NEWS: Updated for the upcoming 2.0.7 release. This is only a
first draft and needs more work.
2002-08-16 Per Cederqvist <ceder@ceder.dyndns.org>
Portability fixes.
* doc/Makefile.am (check-doc): Use "diff -c" instead of "diff -u"
for increased portability.
* HACKING: Use bison 1.35. Bison 1.28 produces a file that fails
on AIX.
Fix Texinfo error.
* doc/Makefile.am (protocol-a.texi): Use '@"a', not '@"a{}', when
substituting IAM.
* doc/Protocol-A.texi (IAM): Use '@"a', not '@"a{}'.
* doc/constructs.expected: @"a{} is no longer used.
"make check" / Python 1.5 compatibility fixes.
* doc/checkargs.py (lexer.__init__): Use string.split for Python
1.5 compatibility.
(number_suffixed): Don't use "".startswith.
(isalpha): New function. Use it instead of "".isalpha.
(isdigit): New function. Use it instead of "".isdigit.
(isupper): New function. Use it instead of "".isupper.
(islower): New function. Use it instead of "".islower.
(isspace): New function. Use it instead of "".isspace.
(prot_a_bitstring.check_implemented): Old Python versions cannot
loop over a dictionary; add an explicit call to the .keys()
method.
(lexer.__init__): Use string.strip instead of "".strip.
Dump info about existing sessions to a file specified by
"Connection status file:". (Bug 706).
* src/server/connections.h (Connection): Added the "peer" field.
* src/server/connections.c (dump_connections): New function.
(check_kill_flg): Call dump_connections if any connection was
killed.
(login_request): Set the "peer" field.
* src/server/internal-connections.h (dump_connections): New
function.
* src/server/internal-connections.c (kill_client): Free the "peer"
field.
* src/server/server-config.c (parameters): Added "Connection
status file" and "Connection status temp file".
(read_configuration): Handle them.
* src/server/param.h (struct kom_par): Added
connection_status_file and connection_status_file_tmp.
* doc/lyskomd.texi (Parameters): New parameters: "Connection
status file:" and "Connection status temp file:".
2002-08-15 Per Cederqvist <ceder@ceder.dyndns.org>
"make check" may now work with Python 1.5.
* doc/checkargs.py (prot_a_type.use): Don't use +=.
(reader.getc_eofok): Ditto.
(lexer.toplevel_rarg): Ditto.
(lexer.toplevel_aarg): Ditto.
"make check" should no longer require gawk.
* doc/Makefile.am (.texi.notab): Use $(AWK), not gawk. At least
some other awk implementations supports this script.
2002-08-14 Per Cederqvist <ceder@ceder.dyndns.org>
Makefile bug fixed.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Fixed
a makefile syntax error.
2002-08-13 Per Cederqvist <ceder@ceder.dyndns.org>
* HACKING: Updated version number of automake.
Mention Xenofarm.
2002-08-11 Per Cederqvist <ceder@ceder.dyndns.org>
Distribution cleanup.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
21.exp, 22.exp, 23.exp, 24.exp, 25.exp, 26.exp, 27.exp, 28.exp,
bug-145.exp, bug-225.exp, bug-349.exp, bug-37-2.exp, bug-37-3.exp,
bug-37-4.exp, bug-37.exp, bug-38.exp, bug-598-2.exp, bug-598.exp,
bug-612.exp and bug-84.exp.
* doc/Makefile.am (MOSTLYCLEANFILES): Added TeX temp file
regarding protocol-a.texi, and protocol-a.texi.
(DISTCLEANFILES): Added Protocol-A.pdf.
(Protocol-A.dvi): Fix the TEXINPUTS setting so that a VPATH
compile works.
(Protocol-A.pdf): Ditto.
Update version numbers.
* configure.in: Set version 2.0.7.
* versions (SERVER-VERSION): 2.0.7.
(SERVER-COMPAT-VERSION): 20007.
* doc/Protocol-A.texi (PROTOEDITION): Set to 10.7.
(VERSION): Set to 2.0.7.
Document "language" in the common area. (Bug 124).
Fix grammar of common area.
* doc/Protocol-A.texi (The User Area): The description of the
common block grammar contained many errors. State that everything
is encoded as HOLLERITHs, and that they in turn contain
datatypes. Removed "list" and "elems"; added "string-list".
Added the "language" setting.
* doc/constructs.expected: Updated.
* doc/checkargs.py (lexer.toplevel_copying): Ignore.
(lexer.toplevel_quotation): Ignore
(lexer.toplevel_insertcopying): Ignore.
Make it possible to disable DNS lookups. Log DNS lookups that
takes too long. (Bug 627).
* src/server/server-config.c (parameters): Removed "Y2K
Compatibility". Added "Use DNS" and "DNS log threshold".
* doc/lyskomd.texi (Parameter Types): Document "double".
(Parameters): New parameters: "Use DNS:" and "DNS log
threshold:".
* src/server/param.h (struct kom_par): Added use_dns and
dns_log_threshold. Removed y2k_compat.
* src/server/connections.c (get_host_name): New function.
(login_request): Use get_host_name.
(logout_request): Ditto.
* src/server/conf-file.h, src/server/conf-file.c (assign_double):
New function.
2002-08-10 Per Cederqvist <ceder@ceder.dyndns.org>
Fix documentation of privilege bits create-conf and create-pers.
(Bug 688).
* doc/Protocol-A.texi (Security): create-conf and create-pers are
normally not assigned. Added a footnote that says that they are
normally not needed, either.
* src/server/testsuite/lyskomd.0/27.exp: Removed references to bug
688.
Check for ar. (Bug 523).
* configure.in: Check for ar. Look in $PATH:/usr/ccs/bin, and
stop with an error if no ar can be found.
Avoid duplicating the license in Protocol-A.texi. (Bug 441).
* doc/Protocol-A.texi: Use the new @copying and @insertcopying
commands, to avoid repeating the copyright information.
(About this document): New node, that makes the copyright
information visible in Info and HTML.
Fix the parser so that negative numbers are rejected. Don't
pretend that the protocol base will ever be anything but ten.
(Bug 225).
* src/libraries/libmisc/s-string.h: (s_strtol): Removed the base
argument.
* src/libraries/libmisc/s-string.c (char2digit): Removed the base
argument. Simplified the code. This should be faster now.
(s_strtol): Removed the base argument. Don't allow leading '+'
or '-' signs. This simplifies the code.
* src/server/prot-a-parse.c (prot_a_parse_long): Removed the
base argument of s_strtol.
(prot_a_parse_string): Ditto.
* src/server/aux-items.c (aux_item_trigger_mark_text): Removed the
base argument of s_strtol.
(aux_item_trigger_unmark_text): Ditto.
(aux_item_trigger_mirror_faq): Ditto.
(aux_item_validate_existing_text): Ditto.
* src/include/kom-config.h (PROTOCOL_NUMBER_BASE): Removed.
* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Updated,
now that the parser no longer accepts negative numbers.
* src/server/testsuite/lyskomd.0/bug-225.exp: Test bug 225.
Fix references to dbck documentation. (Bug 386).
* doc/lyskomd.texi (Parameters): Don't refer to dbck.info, since
that document is now part of lyskomd.texi.
(Administration): Ditto.
Fix error codes for query-read-texts, query-read-texts-old and
sub-member. (Bug 161, Bug 703, Bug 43 and Bug 612).
* src/server/person.c: "kom-errno.h" must now be included
before "manipulate.h".
(do_query_read_texts): Fix error code computations. Previously,
ENA(admin,4) was needed. Now, ENA(admin,2) or ENA(wheel,8) is
enough. (Bug 161 & Bug 703).
* src/server/membership.c (enum memb_visibility): Moved to
manipulate.h.
(membership_visible): No longer static.
(sub_member): Improve error code computations. (Bug 612 & Bug 43).
* src/server/manipulate.h (enum memb_visibility): Moved here from
membership.c.
(membership_visible): Now exported from membership.c.
(set_conf_errno): New function.
* src/server/conference.c: "kom-errno.h" must now be included
before "manipulate.h".
(set_conf_errno): New function.
* src/server/admin.c: "kom-errno.h" must now be included before
"manipulate.h".
* src/server/aux-items.c: Ditto.
* src/server/dbck.c: Ditto.
* src/server/send-async.c: Ditto.
* src/server/server-config.c: Ditto.
* src/server/session.c: Ditto.
* src/server/standalone.c: Ditto.
* src/server/text.c: Ditto.
* src/server/testsuite/lyskomd.0/27.exp: Bug 703 is fixed.
* src/server/testsuite/lyskomd.0/bug-37-4.exp: Bug 703 is fixed.
* src/server/testsuite/lyskomd.0/bug-612.exp: Test cases for bug
612.
* doc/Protocol-A.texi (sub-member): Document the value of
error-status for permission-denied errors.
get-membership and get-membership-old didn't always honor
unread-is-secret. (Bug 607). (Bug 608).
* src/server/membership.c (copy_public_confs): New argument:
pers_no. Caller updated. Use membership_visible to simplify code
and fix bugs 607 and 607.
* src/server/testsuite/lyskomd.0/bug-37-3.exp: Bug 607 and bug 608
are now fixed.
* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.
get-members and get-members-old leaks secret persons (Bug 705).
* src/server/membership.c (membership_visible): New arguments:
is_supervisor_of_member, is_supervisor_of_conf. Callers updated.
Avoid calling access_perm if possible. Grant full access if
ENA(admin,2) or ENA(wheel,8), as do_get_members did.
(do_get_members): Use membership_visible to simplify code, and fix
bug 705.
* src/server/testsuite/lyskomd.0/bug-37.exp: Bug 705 fixed.
Minor doc fix.
* doc/Protocol-A.texi (Membership visibility): Markup fixed.
* doc/constructs.expected: Updated.
Fix membership visibility for get-unread-confs. (Bug 597).
* src/server/membership.c (enum memb_visibility): New enum.
(check_unread): New static function.
(membership_visible): New static function, that fully implements
the membership visibility rules that were documented 2002-08-07.
(get_unread_confs): Use membership_visible to simplify the code
and use the correct membership visibility rules. Various code
cleanup.
* src/server/testsuite/lyskomd.0/bug-37-2.exp: get-unread-confs is
now better. Bug 597 fixed.
* src/server/testsuite/lyskomd.0/bug-37.exp: get-unread-confs now
fails in a different, and better, way for secret persons.
* src/server/testsuite/lyskomd.0/27.exp: query-read-texts-old,
query-read-texts and get-unread-confs should not censor the secret
conference, since the viewer is supervisor of the member.
2002-08-08 Per Cederqvist <ceder@ceder.dyndns.org>
Comment added.
* src/server/membership.c (sub_member): Added comments for bug
612.
Code cleanup: remove global define of SMALLOC_MAGIC_ALLOC and
SMALLOC_MAGIC_FREE. (Bug 562).
* src/server/ram-smalloc.c (SMALLOC_MAGIC_ALLOC): Moved here from
smalloc.h. Only define if USE_MALLOC_GUARDS is true.
(SMALLOC_MAGIC_FREE): Ditto.
* src/include/server/smalloc.h (SMALLOC_MAGIC_ALLOC): Moved to
ram-smalloc.c.
(SMALLOC_MAGIC_FREE): Ditto.
Test membership visibility in get-members-old and get-members.
* src/server/testsuite/lyskomd.0/bug-37.exp: Test get-members-old
and get-members.
* src/server/testsuite/lyskomd.0/bug-37-2.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-37-3.exp: Ditto.
* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.
2002-08-07 Per Cederqvist <ceder@ceder.dyndns.org>
Documented membership visibility. (Bug 693).
* doc/Protocol-A.texi (Membership visibility): New chapter.
* src/server/testsuite/lyskomd.0/bug-37-3.exp: Updated for new
membership visibility rules.
* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.
2002-08-06 Per Cederqvist <ceder@ceder.dyndns.org>
Fix some "make maintainer-clean" lossage.
* src/server/Makefile.am (aux-item-def-scan.o): Added an explicit
dependency on aux-item-def-parse.h.
* Makefile.am (DISTCLEANFILES): Added config.cache.
2002-08-02 Per Cederqvist <ceder@ceder.dyndns.org>
More valgrind integration.
* src/server/testsuite/config/unix.exp (check_valgrind): Remove
boring valgrind logfiles.
2002-08-02 David Byers <david.byers@swipnet.se>
Add missing test cases for bug 84.
* src/server/testsuite/config/prot-a.exp (kom_delete_text): New
function. Use to delete a text from the test suite.
* src/server/testsuite/lyskomd.0/bug-84.exp: Added missing test
cases for bug 84 and one xfail for bug 690.
2002-08-02 Per Cederqvist <ceder@ceder.dyndns.org>
Work around a race condition in the test suite.
* src/server/testsuite/lyskomd.0/18.exp: Sleep six seconds to work
around a race condition (Bug 692).
Suppress errors from regex.c. Handle simultaneous runs of lyskomd
and dbck.
* src/server/testsuite/lyskomd.supp: New file for valgrind. This
contains a suppression for bug 691.
* src/server/testsuite/config/unix.exp (l2g_start): Pass a log
file name to the valgrind wrapper.
(dbck_run): Ditto.
(spawn_lyskomd): New argument: log file name. All callers
updated. Use the lyskomd.supp valgrind suppressions file. Pass
--show-reachable=yes and a log file name to valgrind.
(check_valgrind): New arguments: logfile, need_leaks and
need_errs. All callers updated.
* src/server/testsuite/Makefile.am (valgrind.wrap): Expect the log
file name as the first argument.
(EXTRA_DIST): Added lyskomd.supp.
Make it possible to run lyskomd without malloc guard areas.
* configure.in: Added --disable-malloc-guards. This is useful
when combined with --with-valgrind, but should not be used in a
production setting.
* src/server/ram-smalloc.c: Document our guard areas, and make
them optional.
(OVERHEAD): New macro, that computes a size including the guard
area overhead. Two versions, depending on if USE_MALLOC_GUARDS is
defined or not.
(smalloc): Reindent. Test USE_MALLOC_GUARDS.
(sfree): Test USE_MALLOC_GUARDS.
(srealloc): Test USE_MALLOC_GUARDS.
Fixed a read past the end of a buffer.
* src/libraries/libmisc/s-string.c (s_strtol): When a string
containing only whitespace was passed to s_strtol, s_strtol would
attempt to read the sign ('+' or '-') past the end of the string.
Fix the l2g test cases.
* src/server/testsuite/l2g.0/00.exp: Destroy all structures before
exit, so that the leak check of valgrind works properly.
* src/server/testsuite/l2g.0/01.exp: Ditto.
* src/server/testsuite/l2g.0/02.exp: Ditto.
* src/server/testsuite/l2g.0/03.exp: Ditto.
* src/server/testsuite/l2g.0/04.exp: Ditto.
* src/server/testsuite/l2g.0/05.exp: Ditto.
* src/server/testsuite/l2g.0/06.exp: Ditto.
* src/server/testsuite/l2g.0/07.exp: Ditto.
* src/server/testsuite/l2g.0/08.exp: Ditto.
* src/server/testsuite/l2g.0/09.exp: Ditto.
* src/server/testsuite/l2g.0/10.exp: Ditto.
Valgrind refinements.
* src/server/testsuite/config/unix.exp (spawn_lyskomd): Use
valgrind.wrap.
(l2g_start): Use valgrind.
(l2g_stop): Check valgrind output.
(lyskomd_fail_start): Use valgrind.
(check_valgrind): Ensure that the memory report is seen.
(dbck_run): Use valgrind.
* src/server/testsuite/Makefile.am (valgrind.wrap): New target.
Since valgrind can only send the log to a specified file
descriptor, and expect cannot open a specified file descriptor, we
have to use a wrapper for valgrind.
(noinst_DATA): Added
valgrind.exp.
(MOSTLYCLEANFILES): Added valgrind-*.log, valgrind.log and
valgrind.wrap.
(check-l2g): Depend on valgrind.wrap.
(check-lyskomd): Ditto.
(check-leaks): Ditto.
Plug a memory leak.
* src/server/aux-items.c (aux_item_definition_cache_regexp): Call
regfree() when a regex compilation fail, since our
re_compile_pattern may leave allocated stuff in the buffer.
Improved valgrind support.
* configure.in: Remove all remnants of the purify support, since
it was broken when we switched to automake. Added valgrind
support.
* src/server/testsuite/.cvsignore: Ignore valgrind-*.log.
* src/server/testsuite/Makefile.am (site.exp): Set valgrind.
* src/server/testsuite/config/unix.exp: Use the "valgrind"
variable from site.exp. It contains a the path name of the
valgrind binary to use.
(spawn_lyskomd): Adjust accordingly. Don't use -v.
(check_valgrind): New argument: expected_leaks.
(lyskomd_death): Pass the new optional argument "expected_leaks"
to check_valgrind.
Note a memory leak.
* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: Bug 689 is
a hard-to-fix memory leak. Mark it as an expected failure.
(shutdown): Pass info about expected leaks to lyskomd_death.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: This triggers
a hard-to-fix memory leak (Bug 689).
Shut up valgrind.
* src/server/memory.c (init_person): Clear the pwd field. This
way, we avoid writing junk to the database file, and we make
valgrind happy. The junk was never used, so this is not a
bugfix.
Test suite fix.
* src/server/testsuite/lyskomd.0/27.exp: Use idholl where
appropriate.
Fix a minor memory leak.
* src/server/aux-items.c (free_aux_item_definitions): Fixed a
memory leak. We have to call regfree() to deallocate stuff within
the compiled regular expression. This bug was found with
valgrind.
Added some valgrind support. (Bug 514).
* src/server/testsuite/config/unix.exp: Handle the VALGRIND
command line argument.
(spawn_lyskomd): New proc, that knows how to use valgrind.
(lyskomd_fail_start): Use spawn_lyskomd.
(parse_valgrind_leak): New proc.
(check_valgrind): New proc.
(lyskomd_death): Call check_valgrind.
2002-08-01 Per Cederqvist <ceder@ceder.dyndns.org>
Minor doc fix.
* doc/Protocol-A.texi (Preface): Fix markup.
* doc/constructs.expected: Updated.
2002-07-31 Per Cederqvist <ceder@ceder.dyndns.org>
Updated send-comments-to [33] so that it now allows an optional
recipient type.
* run-support/aux-items.conf: Updated send-comments-to [33].
* doc/Protocol-A.texi (Aux-Item Types): Ditto.
* src/server/testsuite/lyskomd.0/23.exp: Refer to 28.exp.
* src/server/testsuite/lyskomd.0/28.exp: Test the aux-item
send-comments-to (33) with a specified recipient type.
More membership visibility tests.
* src/server/testsuite/lyskomd.0/27.exp: Test basic visibility of
a secret conference for the supervisor of a member. Version 2.0.6
of lyskomd passes the test as written.
2002-07-22 Per Cederqvist <ceder@ceder.dyndns.org>
Fix typo in Protocol A example.
* doc/Protocol-A.texi (re-z-lookup): Fixed ref-id error in
example. Thanks to Joorin for pointing it out.
(Preface): Mention that bugs should be reported via Bugzilla.
2002-06-22 Per Cederqvist <ceder@ceder.dyndns.org>
New membership-related tests.
* doc/Protocol-A.texi (Person Status Types): Explicitly say that
the supervisor of a person bypasses the unread-is-secret bit.
* src/server/testsuite/lyskomd.0/bug-37-4.exp: New test cases.
Like bug-37.exp, but let the observer be supervisor of all
conferences, and let all memberships be secret.
* src/server/testsuite/lyskomd.0/bug-37-3.exp: New test cases.
Like bug-37.exp, but let the observer be supervisor of all
conferences.
* src/server/testsuite/lyskomd.0/bug-37-2.exp: Don't set the flg3
flag of the Personal-Flags.
Removed a comment.
* src/server/conference.c (set_conf_type): David Byers is no
longer a supporter of secret persons, so remove a comment that
states that he is.
2002-06-15 Per Cederqvist <ceder@ceder.dyndns.org>
get_unread_confs no longer censors rd-prot conferences. (Bug 596).
* src/server/membership.c (get_unread_confs): It is sufficient
that the viewer has read_protected access to a conference for it
to be returned.
* src/server/testsuite/lyskomd.0/bug-37.exp: Bug 596 is fixed.
This also causes two other tests to fail in a different way.
* src/server/testsuite/lyskomd.0/bug-37-2.exp: Adjusted to the
resolution of bug 596. This only affects how certain tests
fails.
Don't lose the array size of get-membership and
get-membership-old. (Bug 598).
* src/server/membership.c (copy_public_confs): Removed the
"copy_secret" argument. Simplify the code, and don't lose the
array size just because want_read is false.
* src/server/testsuite/lyskomd.0/bug-598.exp (want_array_size):
Don't expect failure.
Added test cases for bug 598: get-membership and
get-membership-old sometimes drops the array size.
* src/server/testsuite/lyskomd.0/bug-598.exp: New file. Test
bug 598.
* src/server/testsuite/lyskomd.0/bug-598-2.exp: A version of the
bug-598.exp test with unread-is-secret set.
Fixed minor doc error.
* doc/Protocol-A.texi (get-membership-old): Fixed error in
description of index-out-of-range.
(get-membership): Ditto.
* doc/constructs.expected: Updated.
Introduce good_bad_expect, for trapping XFAIL situations nicely.
* src/server/testsuite/config/unix.exp (good_bad_expect): New proc.
* src/server/testsuite/renumber.el
(renumber-lyskom-send-simple-expect): Handle good_bad_expect.
Write a test cases for bug 37.
* src/server/testsuite/lyskomd.0/bug-37.exp: New test case for bug
37. Bugs 593, 594, 595 and 596 were found while writing this test
case...
* src/server/testsuite/lyskomd.0/bug-37-2.exp: Like bug-37.exp,
but with all memberships being secret. Found bug 597.
Document unread-is-secret. (Bug 593).
* doc/Protocol-A.texi (Person Status Types): Added a reference to
Security, for an explanation of the privileges. Document the bits
in Personal-Flags.
(Membership Information): Document how unread-is-secret affects
some parts of Membership and Membership-Old.
Added a test case for bug 349.
* src/server/testsuite/lyskomd.0/bug-349.exp: Test case for bug
349: wrong error code from set_supervisor.
2002-06-14 Per Cederqvist <ceder@ceder.dyndns.org>
Document the Message-ID format of exported texts. (Bug 574).
* doc/Protocol-A.texi (Importing and Exporting E-Mail): Document
the Message-ID format of exported texts.
Remove autoconf-2.53 warning.
* configure.in: Use all three arguments of AC_DEFINE.
* acinclude.m4 (CMOD_C_ATTRIBUTE_UNUSED): Use all three arguments
of AC_DEFINE.
* acconfig.h: File removed.
2002-05-20 Per Cederqvist <ceder@ceder.dyndns.org>
Minor doc fix.
* doc/Protocol-A.texi (Client-Server Dialog): Don't mention
feature-disabled twice.
2002-05-07 David Byers <david.byers@swipnet.se>
* Updated message from 2002-04-11.
2002-04-14 David Byers <david.byers@swipnet.se>
* doc/Protocol-A.texi (Aux-Item Types): Documented
elisp-client-read-faq and elisp-client-rejected-recommendation.
2002-04-13 David Byers <david.byers@swipnet.se>
Test for fix of bug 145:
* src/server/testsuite/config/prot-a.exp (kom_delete_conf): New
function.
(kom_lookup_z_name): New function.
2002-04-12 David Byers <david.byers@swipnet.se>
Fix bug 145:
* src/server/conference.c (do_delete_conf): Removed lines that
cleared the name of the conference. That is done in
cached_delete_conf.
Fix bug 38:
* src/server/testsuite/lyskomd.0/bug-38.exp: New file.
* src/server/testsuite/config/prot-a.exp (kom_set_user_area): New
function.
(kom_shutdown_server): New function.
(kom_create_text_simple): New function.
(cres): The else branch which does eval actually works now. Made
ref_no global in this function.
* src/server/person.c (do_set_user_area): Copied check for read
access to new user area from get_text_stat.
Fix bug 331:
* src/server/testsuite/lyskomd.0/03.exp: Use idholl and
lyskomd_host for hostname-dependend strings.
* src/server/testsuite/lyskomd.0/16.exp: Use idholl and
lyskomd_host for hostname-dependend strings.
* src/server/testsuite/lyskomd.0/01.exp: Use idholl and
lyskomd_host for hostname-dependend strings.
* src/server/testsuite/lyskomd.0/00.exp: Use idholl and
lyskomd_host for hostname-dependend strings.
* src/server/testsuite/config/unix.exp (idholl): New function to
create hollerith with at sign and name of localhost appended.
(lyskomd_server): New variable containing the name of this host.
2002-04-11 David Byers <david.byers@swipnet.se>
* src/server/aux-items.c (aux_item_trigger_mirror_faq): Don't just
return when the object type is INFO_OBJECT_TYPE (which represents
server aux-items). Instead, create the mirror aux-item as required
by the protocol.
* configure.in: Added AC_PREREQ.
2002-04-07 Per Cederqvist <ceder@ceder.dyndns.org>
Added the world-readable aux item. (Bug 5).
* run-support/aux-items.conf: Added world-readable [34].
* src/server/text.c (person_text_read_access): Give everybody read
access to texts with a world-readable aux-item.
* doc/Protocol-A.texi (Aux-Item Types): New aux-item: world-readable.
(get-text): Mention the world-readable aux
item under the no-such-text error code.
(get-text-stat-old): Ditto.
(get-text-stat): Ditto.
* src/server/testsuite/lyskomd.0/01.exp: Handle world-readable.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
* src/server/testsuite/lyskomd.0/18.exp: Ditto
* src/server/testsuite/lyskomd.0/26.exp: Test world-readable.
2002-04-06 Per Cederqvist <ceder@ceder.dyndns.org>
Use symbolic names for aux item tags.
* src/server/aux-items.c (aux_item_trigger_mirror_faq): Use
aux_faq_for_conf from aux.h instead of a hardcoded 28.
* src/server/Makefile.am (aux.h): New target.
(MOSTLYCLEANFILES): Added aux.h.
(NODIST_GENOBJS): Added aux.h.
(BUILT_SOURCES): Added aux.h.
(version.incl): Fixed spelling error.
(version-info.c): Ditto.
2002-04-02 Per Cederqvist <ceder@ceder.dyndns.org>
Fix the documentation of no-of-created-texts (Bug 384).
* doc/Protocol-A.texi (Person Status Types): Fix the documentation
of no-of-created-texts. (Bug 384).
Clarify the description of get-person-stat-old.
* doc/Protocol-A.texi (get-person-stat-old): Don't call the
"username" field "name". Add markup for it. Clarify that the
empty string is returned; dont say that the "name is not
returned".
Automake improves.
* src/server/testsuite/Makefile.am (noinst_DATA): Removed a
comment about an Automake deficiency that is no longer there.
(Bug 208).
2002-03-29 Per Cederqvist <ceder@moria>
* Release 2.0.6.
Release administrativa.
* doc/checkargs.py: Copyright header added.
* scripts/lyskomd-copyrights: Updated.
* HACKING: Updated version numbers. Mention Bugzilla.
* configure.in: Set version 2.0.6.
* versions (SERVER-VERSION): 2.0.6.
(SERVER-COMPAT-VERSION): 20006.
* README: Updated for the 2.0.6 release.
* NEWS: Updated for the 2.0.6 release.
* doc/Protocol-A.texi (PROTOEDITION): Set to 10.6.
(VERSION): Set to 2.0.6.
(Document Edition History): Document changes in edition 10.6.
* doc/constructs.expected: Updated.
Create PDF and DVI output from the protocol specification.
* doc/Makefile.am (pdf): New target.
(html): New target.
(Protocol-A.dvi): New target.
(Protocol-A.pdf): Use texi2dvi --pdf instead of texi2pdf.
(protocol-a.texi): New target. Major hack. Expand a few of the
macros so that texinfo.tex can cope with the rest.
(protocol-a/index.html): New target.
(.texi.notab): Use automake comments instead of /bin/sh comments.
(update-www): Also depend on protocol-a/index.html, Protocol-A.dvi
and Protocol-A.pdf, and install them.
(check): Also depend on the targets pdf and dvi.
Doc fixes.
* doc/Protocol-A.texi (create-person-old): Moved a misplaced brace
to its proper place.
(get-text): State that ^J represents a newline in the example.
(create-person-old): Move punctuation outside of quotes, according
to the Texinfo style guide.
2002-03-26 Per Cederqvist <ceder@ingate.com>
Port to Cygwin.
* src/server/Makefile.am (all-recursive): Added the $(EXEEXT)
suffix to lyskomd and dbck, so that the makefile works on cygwin.
(check-recursive): Ditto.
2002-03-24 Per Cederqvist <ceder@moria>
Allow faq-text to be set on letterboxes. (Bug 423).
* run-support/aux-items.conf (faq-text): Allow it on letterboxes
as well as conferences and the server.
* doc/Protocol-A.texi (Aux-Item Types): Document that faq-text may
be set on letterboxes.
* src/server/testsuite/lyskomd.0/03.exp: Set an faq-text on the
letterbox of person 8.
2002-02-15 Per Cederqvist <ceder@moria>
Added support for the "Jubel: public" parameter, that enforces
the policy that certain texts must be created in public
conferences.
* src/server/testsuite/lyskomd.0/25.exp: Test public jubels.
* src/server/text.c (create_text_check_misc): New argument:
need_public_jubel.
(struct jubel): New field: public.
(register_jubel): New argument: public.
(ok_to_create_next_text): New result parameter: must_be_public.
(do_create_text): Check for jubels that must be public.
* src/server/standalone.c (register_jubel): New argument: public.
* src/server/server-config.c (jubel): Handle the new "public" form.
* src/server/manipulate.h (register_jubel): New argument: public.
* doc/lyskomd.texi (Parameter Types): These are standard types,
not all legal types.
(Parameters): Document the "public" forms of the Jubel parameters.
Mention that there may be several Jubel parameters.
2002-02-11 Per Cederqvist <ceder@moria>
Don't emit garbage statistics. (Bug 390).
* src/server/connections.c (dump_statistics): Don't emit
statistics for the dummy request used to skip unimplemented
requests.
Initialize the function_index field a little earlier.
* src/server/prot-a.c (prot_a_init): Initialize function_index.
* src/server/internal-connections.c (init_connection): Initialize
function_index.
Make fnc-def-init.incl look nicer. (Bug 381).
* src/server/fnc-def-init.awk: Make certain that the final entry,
that is only used to skip all arguments of requests that are not
implemented, gets a unique number.
2002-02-10 Per Cederqvist <ceder@moria>
Bugzilla affects the release procedures.
* HACKING: Mention that the version number should be added to
Bugzilla when releases are made.
2002-01-23 Per Cederqvist <ceder@ingate.com>
Added missing include statement. (Bug 385).
* src/server/log.c: Include stdlib.h.
2002-01-18 Per Cederqvist <ceder@moria>
Quote backslashes properly in Texinfo macro calls. (Bug 376).
* doc/Protocol-A.texi (create-text-old): Properly quote \n in
macro call.
(create-anonymous-text-old): Ditto.
2002-01-03 Per Cederqvist <ceder@ingate.com>
Document that ``last-login'' is also updated on logout.
* doc/Protocol-A.texi (Person Status Types): Don't forget to
mention that ``last-login'' is also updated on logout.
2002-01-01 Per Cederqvist <ceder@moria>
Check @field{} usage. (Bug 206).
* doc/checkargs.py (defined_fields): New variable.
(undefined_fields): New variable.
(prot_a_struct.add_field): Handle defined_fields and
undefined_fields.
(prot_a_bitstring.add_field): Ditto.
(lexer.toplevel_bye): Check for undefined fields.
(lexer.toplevel_field): New method.
* doc/Makefile.am (check): Removed a fixed FIXME comment.
* doc/Protocol-A.texi (Future changes): Don't use @field{} when
talking about stuff that might be a field some day in the future.
Check @priv{} usage, and that all implemented Priv-Bits are
documented, and vice versa. (Bug 207).
* doc/Makefile.am (check): Create privbits.tmp. Check @priv{}
usage.
* doc/checkargs.py (lexer.__init__): Load "privbits.tmp".
(lexer.toplevel_bye): Check Priv-Bits.
Document the ``change-name'' capability.
* doc/Protocol-A.texi (Security): Document ``change-name''.
Remove the unused and undocumented privilege bit ``extern_gw''.
* src/include/kom-types.h (Priv_bits): Renamed the unused bit
``extern_gw'' to ``flg7'', and reserve it for future use.
* src/server/ram-parse.c (fparse_priv_bits): Parse flg7
instead of extern_gw.
* src/server/ram-output.c (foutput_priv_bits): Emit flg7 instead
of extern_gw.
* src/server/prot-a-parse.c (prot_a_parse_priv_bits): Parse flg7
instead of extern_gw.
* src/server/prot-a-output.c (prot_a_output_priv_bits): Emit flg7
instead of extern_gw.
* src/server/memory.c (init_priv_bits): Initialize flg7 instead of
extern_gw.
* src/server/dbck.c (check_persons): Set Priv_bits flg7 instead of
extern_gw.
2001-12-31 Per Cederqvist <ceder@moria>
Fix documentation of error code ``client-is-crazy''.
* doc/Protocol-A.texi (Error Codes): client-is-crazy is actually
used, so don't say it isn't.
Check @errorcode usage.
* doc/Makefile.am (check): Create files for all error codes that
are implemented. Check @errorcode{} usage. (Bug 205).
Check that all implemented Conf_type bits are documented, and vice
versa.
* doc/Makefile.am (check): Don't ignore the reserved bits of
Conf_type.
* doc/checkargs.py (prot_a_bitstring.__init__): New method.
(prot_a_bitstring.add_field): Store the field, and check for
duplicates.
(prot_a_bitstring.check_implemented): New method.
(lexer.__init__): Read conftypes.tmp.
(lexer.toplevel_bye): Check Extended-Conf-Type.
(lexer.__parse_userdefined_bitstring): Be prepared that
prot_a_bitstring.add_field can return an error message.
Check that all implemented misc-infos are documented, and vice
versa.
* doc/Makefile.am (check): Create miscs-numbered.tmp based on the
contents of kom-types.h.
* doc/checkargs.py (prot_a_selection.check_implemented): New
method.
(prot_a_selection.all_names): New method.
(lexer.__init__): Check that the same number isn't used twice in
asyncs-numbered.tmp. Read miscs-numbered.tmp.
(lexer.toplevel_bye): Check that all implemented misc-infos are
documented, and vice versa.
2001-12-30 Per Cederqvist <ceder@moria>
Code cleanup. (Bug 346).
* src/server/aux-items.c (aux_item_default_definition): Removed
left-over traces of "extended aux-items", a concept that didn't
scale and was abandoned a long time ago.
Document supervisors better.
* doc/Protocol-A.texi (Conferences): State that a person is a
supervisor of himself, except for the set-supervisor call.
Fix "make check".
* doc/constructs.expected: Updated.
* doc/checkargs.py (lexer.pushback): Pushback @cindex.
Code cleanup.
* src/server/aux-items.c (conf_stat_check_add_aux_item_list):
Removed confusing comment.
2001-12-29 Per Cederqvist <ceder@moria>
Code cleanup.
* src/server/aux-items.h, src/server/aux-items.c
(prepare_aux_item): Now a static function.
(filter_aux_item_list): Comment updated.
Fixed typos.
* doc/Protocol-A.texi (Reformattable Text (text/x-kom-basic)):
Removed duplicated "as".
* src/server/aux-items.c: Fixed typo in comment.
2001-12-28 Per Cederqvist <ceder@moria>
Talk about character sets. (Bug 339).
* doc/Protocol-A.texi (Simple Data Types): Talk a little about
character sets under HOLLERITH, without saying anything definite.
Check for __attribute__((__noreturn__)) support at configuration
time instead of at compile time. (Bug 57).
* src/include/compiler.h: Removed.
* src/include/Makefile.am (noinst_HEADERS): Removed compiler.h.
* configure.in: Check for __attribute__((__noreturn__)).
* acconfig.h (HAVE_ATTRIBUTE_NORETURN): Added.
* src/server/lyskomd.h: Don't include compiler.h. Use
HAVE_ATTRIBUTE_NORETURN instead of the NORETURN symbol, that
previously was defined by compiler.h.
Don't include config.h twice.
* src/libraries/libcommon/kom-errno.c: Don't include both
<config.h> and "config.h".
Don't declare kom_errno and err_stat twice. (Bug 343).
* src/server/ramkomd.c (kom_errno): Removed, since this is already
defined in src/libraries/libcommon/kom-errno.c.
(err_stat): Ditto.
Use ``union result_holder'' instead of ``Result_holder''. (Bug 337).
* src/server/connections.h (union result_holder): Result_holder
typedef removed.
* src/server/connections.c: Use ``union result_holder'' instead of
``Result_holder''.
* src/server/prot-a.h: Ditto.
* src/server/prot-a.c: Ditto.
* doc/lyskomd.texi (Adding New Result Types): Use ``union
result_holder'' instead of ``Result_holder''.
(Modifying Output Types): Ditto.
Use ``union info_datum instead of ``Info_datum''. (Bug 337).
* src/server/manipulate.h (ADD_MISC): Use ``union info_datum
instead of ``Info_datum''.
* src/include/kom-types.h (union info_datum): Removed Info_datum
typedef.
Use ``enum kom_err'' instead of ``Kom_err''. (Bug 335).
* src/libraries/libcommon/kom-errno.c: Use ``enum kom_err''
instead of ``Kom_err''.
* src/server/aux-items.c: Ditto.
* src/server/ramkomd.c: Ditto.
* src/include/kom-errno.h (enum kom_err): Removed Kom_err typedef.
Use ``enum res_type'' instead of ``Res_type''. (Bug 335).
* src/server/connections.h (enum res_type): Removed the Res_type
typedef. The only user updated.
* doc/lyskomd.texi (Adding New Result Types): Use ``enum
res_type'' instead of ``Res_type''.
(Modifying Output Types): Ditto.
Use ``enum log_class'' instead of ``Log_class''. (Bug 335).
* src/server/logII.c (enum log_class): Removed the Log_class
enum.
(log): Use ``enum log_class'' instead of ``Log_class''.
Use ``enum log_type'' instead of ``Log_type''. (Bug 335).
* src/server/simple-cache.c (enum log_type): Removed the Log_type
typedef.
(log_access): Use ``enum log_type'' instead of ``Log_type''.
Use ``enum aux_item_validation_type'' instead of
``Aux_Item_Validation_Type''. (Bug 335).
* src/server/aux-items.h (enum aux_item_validation_type): Removed
the Aux_item_validation_type typedef. The only user updated.
Use ``enum call_header'' instead of ``Call_header''. (Bug 335).
* src/server/connections.h: Use ``enum call_header'' instead of
``Call_header''.
* src/server/prot-a.c: Ditto.
* src/server/com-h.awk: Don't create the Call_header typedef.
Use ``enum access'' instead of ``Access''. (Bug 335).
* src/server/manipulate.h: Use ``enum access'' instead of
``Access''.
(enum access): Removed ``Access'' typedef.
* src/server/conference.c: Use ``enum access'' instead of
``Access''.
* src/server/membership.c: Ditto.
* src/server/person.c: Ditto.
* src/server/text.c: Ditto.
Updated a comment.
* src/server/session.c (accept_async): Updated a comment that
talked about ``Async'' instead of ``enum async''.
Use ``enum object_type instead of ``Object_type''. (Bug 335).
* src/include/kom-types.h (enum object_type): Removed Object_type
typedef. All types that contain an enum object_type updated.
* src/server/aux-items.c: Use ``enum object_type'' instead of
``Object_type''.
* src/server/aux-items.h: Ditto.
* src/server/ram-parse.c: Ditto.
Use ``enum info_type instead of ``Info_type''. (Bug 335).
* src/include/kom-types.h (enum info_type): Removed Info_type
typedef. All types that contain an enum info_type updated.
* doc/Makefile.am (check-doc): Extract ``enum info_type'' instead
of ``Info_type'' from kom-types.h.
* src/server/text.c (do_add_recipient): Use ``enum info_type''
instead of ``Info_type''.
(send_async_sub_recipient): Ditto.
(remove_misc_item): Ditto.
(create_text_add_miscs): Ditto.
(send_async_add_recipient): Ditto.
(add_recipient): Ditto.
* src/server/send-async.h, src/server/send-async.c
(async_new_recipient): Use ``enum info_type'' instead of
``Info_type''.
(async_sub_recipient): Ditto.
* src/server/ram-parse.c (fparse_misc_info): Use ``enum info_type''
instead of ``Info_type''.
* src/server/prot-a-send-async.h, src/server/prot-a-send-async.c
(prot_a_async_new_recipient): Use ``enum info_type'' instead of
``Info_type''.
(prot_a_async_sub_recipient): Ditto.
* src/server/memory.c (clear_text_stat): Use ``enum info_type''
instead of ``Info_type''.
* src/server/manipulate.h (ADD_MISC): Use ``enum info_type''
instead of ``Info_type''.
* src/include/services.h (add_recipient): Use ``enum info_type''
instead of ``Info_type''.
Code cleanup.
* src/server/conference.c: Removed an obsolete comment.
2001-12-28 Per Cederqvist <ceder@ingate.com>
Fixed the specification of idle-time. (Bug 197).
* doc/Protocol-A.texi (Session Information): The idle-time is
affected only by the user-active request, not by any request.
Use "C" environment when sorting test output (Bug 330).
* doc/Makefile.am (check-doc): Set LANG, LC_ALL, LC_COLLATE and
LC_CTYPE to "C" when running sort and uniq.
BUG and BUGS comments converted into FIXMEs and entered into
Bugzilla. (Bug 336).
* src/server/membership.c (sub_member): Obsolete BUGS comment
removed.
* src/server/ram-parse.c: BUGS comment converted into FIXMEs and
entered into Bugzilla.
* src/server/prot-a-parse.c: BUG comment converted into FIXME and
entered into Bugzilla.
* src/server/conference.c: BUG and BUGS comments converted into
FIXMEs and entered into Bugzilla.
2001-12-22 Per Cederqvist <ceder@moria>
Use ``enum async'' instead of ``Async''. (Bug 335).
* src/server/session.c (accept_async): Use ``enum
async'' instead of ``Async''.
* src/server/prot-a-send-async.c (async_header): Use ``enum
async'' instead of ``Async''.
* src/server/internal-connections.c (init_connection): Use ``enum
async'' instead of ``Async''.
* src/server/async.h (enum async): Removed the Async typedef.
* doc/lyskomd.texi (Adding Asynchronous Messages): Use ``enum
async'' instead of a typedef.
The check for supervisor in modify_conf_info was broken.
(Bug 309).
* src/server/conference.c (modify_conf_info): Fix typo: use
conf->supervisor instead of conf->super_conf.
* src/server/testsuite/lyskomd.0/24.exp: Check for bug 309. Bug
334 was found while writing this test case; setup_xfail for it.
Fix typo in documentation.
* doc/Protocol-A.texi (modify-conf-info): Fixed typo: changed
"text" to "conference".
Be clearer about the default prefix. (Bug 306).
* doc/lyskomd.texi (Parameter Types): Be clearer about the fact
that ``Prefix:'' overrides the compile-time default.
(Parameters): Ditto. Added a footnote for the first path that
reiterates this fact.
(DBCK Files): Added a missing colon.
Document super-conf better, and simplify the rules slightly.
Document permitted-submitters slighlty more. (Bug 310).
* doc/Protocol-A.texi (Conferences): Added a reference to
``Recipients of comments'' under the explanation of rd-prot.
(Conference Status Types): Document super-conf properly. It has
two different uses.
(set-permitted-submitters): Document what it means when
``permitted-submitters'' is zero, and that that setting is the
default.
(set-super-conf): Added a reference to ``Conference Status
Types''.
(The User Area): Spelling error fixed.
(Recipients of comments): Simplified the rules for super-conf.
A setting of 0 no longer means anything. The previous meaning
wasn't implemented.
2001-12-13 Per Cederqvist <ceder@moria>
Added new aux-item send-comments-to. (Bug 308).
* run-support/aux-items.conf: Added send-comments-to [33].
* src/server/testsuite/lyskomd.0/01.exp: Handle send-comments-to.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
* src/server/testsuite/lyskomd.0/18.exp: Ditto.
* src/server/testsuite/lyskomd.0/23.exp: Test suite implemented.
Robustify test suite.
* src/server/testsuite/config/unix.exp (extracting_expect): Set
$var to the empty string even on failure, to avoid some TCL
errors.
2001-12-12 Per Cederqvist <ceder@moria>
Code cleanup.
* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Removed
trailing blank lines.
Work on test case for new aux-item send-comments-to.
* src/server/testsuite/lyskomd.0/23.exp: Check the aux-item
send-comments-to (33). This is an early commit of work in
process.
2001-11-25 Per Cederqvist <ceder@moria>
Documentation fixes.
* doc/Protocol-A.texi (Recipients of comments): Errata from Hans
Persson and Per Starbck.
2001-11-22 Per Cederqvist <ceder@moria>
Documentation clarifications.
* doc/Protocol-A.texi (Aux-Item Types): Clarify that the address
part of redirect is a conference number, not a name. Clarify the
text for send-comments-to.
2001-11-21 Per Cederqvist <ceder@moria>
Add documentation for aux-item send-comments-to.
* doc/Protocol-A.texi (Article Information): Mention bcc-recpt in
a few places where only recpt and cc-recpt was mentioned.
(Aux-Item Types): Document send-comments-to. (Bug 308).
(Recipients of comments): New subsection.
2001-11-20 Per Cederqvist <ceder@moria>
Document splitkomdb. Fix its usage message. (Bug 21).
* doc/lyskomd.texi (Parameters): Document "Backup export
directory:".
(splitkomdb): New chapter.
* src/server/splitkomdb.c (usage): Added the "-f" option to the
usage message.
2001-11-18 Per Cederqvist <ceder@moria>
Replace internal-services.h with text.h. Make sure all text in
the file is in English. (Bug 150.)
* src/server/Makefile.am (lyskomd_SOURCES): Removed
internal-services.h. Added text.h.
* src/server/text.h: New file, containing the prototype for
do_delete_text(), that was moved from internal-services.h.
* src/server/text-garb.c: Include text.h instead of
internal-services.h.
* src/server/text.c: Ditto.
* src/server/ramkomd.c: Don't include internal-services.h. It
isn't used.
* src/server/internal-services.h: File removed.
2001-11-17 Per Cederqvist <ceder@moria>
Added markup for content types. (Bug 230).
* doc/Protocol-A.texi (LysKOM Content Types): Added markup for
content types.
(Reformattable Text (text/x-kom-basic)): Ditto.
(Content type specification): Ditto.
(Document Edition History): Ditto.
* doc/constructs.expected: Updated.
Document that the elisp-client has used the wrong content type.
* doc/Protocol-A.texi (Reformattable Text (text/x-kom-basic)):
Mention that the elisp client used to enter texts as "x-kom/text"
instead of "text/x-kom-basic".
2001-11-16 Per Cederqvist <ceder@moria>
More Bugzilla references added.
* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Added
Bugzilla reference to a FIXME-style comment that wasn't marked.
2001-11-15 Per Cederqvist <ceder@moria>
Code cleanup. (Bug 166).
* src/server/session.c (accept_async): Removed redundant code.
* src/server/testsuite/lyskomd.0/03.exp: Comments added.
2001-11-13 Per Cederqvist <ceder@moria>
Change the name of the administrator in the English database.
Try to load that database from the test suite.
* db-crypt/db/lyskomd-data-en: Change "Administrator (for) LysKOM"
into "Administrator (of) LysKOM". (Bug 13).
* src/server/testsuite/lyskomd.0/22.exp: Test that the English
database is loadable.
* src/server/testsuite/config/unix.exp (lyskomd_start): New
optional argument: db_suffix.
Test suite cleanup.
* src/server/testsuite/leaks.0/leaks99.exp: Remove redundant
tests. The tests in lyskomd.0 automatically check for memory
leaks, so there is no need to rerun those the tests here. (Bug
219).
* src/server/testsuite/leaks.0/leaks00.exp: Remove obsolete
comments. (Bug 218).
Fixed bogus examples in Protocol-A.texi.
* doc/Protocol-A.texi (query-read-texts): Fixed the example. It
was missing both the "position" and "added-at" fields. (Bug 198,
reported by Kent.)
(get-membership): Ditto. (Bug 223).
* doc/constructs.expected: Updated.
2001-11-11 Per Cederqvist <ceder@moria>
Remove some uses of rcs.h that was overlooked 2001-11-04.
(Bug 140).
* src/libraries/libansi/memchr.c: Don't include rcs.h. Remove
rcsid variable.
* src/libraries/libansi/memcmp.c: Ditto.
* src/libraries/libansi/memcpy.c: Ditto.
* src/libraries/libansi/memset.c: Ditto.
* src/libraries/libansi/remove.c: Ditto.
* src/libraries/libansi/strerror.c: Ditto.
* src/libraries/libmisc/numlist.c: Ditto.
* src/libraries/libmisc/numlist2.c: Ditto.
* src/libraries/libmisc/testnumlist.c: Ditto.
Several files didn't include <config.h>. (Bug 191).
* src/libraries/libansi/empty.c: Include <config.h> if
HAVE_CONFIG_H is defined.
* src/libraries/libansi/memchr.c: Ditto.
* src/libraries/libansi/memcmp.c: Ditto.
* src/libraries/libansi/memcpy.c: Ditto.
* src/libraries/libansi/memset.c: Ditto.
* src/libraries/libansi/remove.c: Ditto.
* src/libraries/libansi/setsid.c: Ditto.
* src/libraries/libansi/strdup.c: Ditto.
* src/libraries/libansi/strerror.c: Ditto.
* src/libraries/libcommon/kom-errno.c: Ditto.
* src/libraries/libcommon/misc-parser.c: Ditto.
* src/libraries/libcommon/parser.c: Ditto.
* src/libraries/libmisc/ldifftime.c: Ditto.
* src/libraries/libmisc/numlist.c: Ditto.
* src/libraries/libmisc/numlist2.c: Ditto.
* src/libraries/libmisc/s-collat-tabs.c: Ditto.
* src/libraries/libmisc/s-string.c: Ditto.
* src/libraries/libmisc/testnumlist.c: Ditto.
* src/server/Makefile.am (version-info.c): Ditto.
More Bugzilla references added.
* src/server/testsuite/lyskomd.0/03.exp: Removed obsolete FIXME
comments.
* src/server/testsuite/lyskomd.0/06.exp: Ditto.
* configure.in: Added references to Bugzilla for all FIXME
comments.
* src/server/testsuite/l2g.0/09.exp: Ditto.
* src/server/testsuite/leaks.0/leaks00.exp: Ditto.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Ditto.
* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Ditto.
Don't build libcheck.a unless we are running the test suite.
* src/server/Makefile.am (check_LIBRARIES): This target was
formerly named noinst_LIBRARIES, but there is no reason to build
the libcheck.a library unless we are running the checks.
(all-recursive): Don't depend on libcheck.a.
2001-11-10 Per Cederqvist <ceder@moria>
More Bugzilla references added.
* src/server/testsuite/Makefile.am: Added references to Bugzilla
for all FIXME comments.
2001-11-09 Per Cederqvist <ceder@moria>
More Bugzilla references added.
* doc/Makefile.am: Added references to Bugzilla for all FIXME
comments.
2001-11-08 Per Cederqvist <ceder@moria>
More Bugzilla references added.
* doc/Protocol-A.texi: Added references to Bugzilla for all
FIXME comments.
2001-11-06 Per Cederqvist <ceder@moria>
Code cleanup: Remove all traces of logins_allowed. (Bug 151).
* src/server/session.c (login_old): Removed #if 0'd
code that referenced logins_allowed.
(login): Ditto.
* src/server/person.c (create_person_generic): Removed #if 0'd
code that referenced logins_allowed.
* src/server/internal-services.h (logins_allowed): Removed
declaration of this unused variable.
Code cleanup.
* src/server/cache-node.c (EMPTY_CACHE_NODE): Don't initialize the
"snapshot" member. (Bug 100).
* src/server/cache-node.h (cache_node): Removed the unused
"snapshot" member. (Bug 100).
2001-11-04 Per Cederqvist <ceder@moria>
Added bug tracking numbers to the expected failures in the test
suite.
* src/server/testsuite/lyskomd.0/14.exp: Added bug tracking
numbers to the setup_xfail statements.
* src/server/testsuite/lyskomd.0/20.exp: Added bug tracking
numbers to the setup_xfail statements.
Removed the unused pom.c and pom.h files. We don't have explicit
permission to distribute them under GPL.
* src/libraries/libmisc/Makefile.am (libmisc_a_SOURCES): Removed
pom.h.
* src/libraries/libmisc/pom.h: Removed.
* src/libraries/libmisc/pom.c: Removed.
Remove rcs.h and all uses of it. (Bug 140).
* src/include/Makefile.am (noinst_HEADERS): Removed rcs.h.
* src/include/rcs.h: Removed.
* src/libraries/libcommon/kom-errno.c: Ditto.
* All files: Don't include rcs.h. Remove rcsid variable.
Simplify the code by breaking out loops from do_sub_comment and
do_sub_footnote.
* src/server/text.c (remove_misc_item): New function.
(do_sub_comment): Use it to simplify code.
(do_sub_footnote): Ditto. (Bug 186).
Simplify the code by unifying do_add_recpt, do_add_cc_recpt and
do_add_bcc_recpt. (Bug 190).
* src/server/text.c (do_add_recipient): New function, that is like
do_add_recpt, but with an additional Info_type argument that
specifies what kind of recipient to add.
(do_add_recpt): Function removed.
(do_add_cc_recpt): Function removed.
(do_add_bcc_recpt): Function removed.
(create_text_add_miscs): Use do_add_recipient. Simplify code.
(add_recipient): Ditto.
Unify several fields in the Info_datum union. This makes it
possible to handle recpt, cc_recpt and bcc_recpt by the same code
in many places, resulting in the removal of approximately 300
lines of code. (Bug 139).
* src/include/kom-types.h (Info_datum): Removed cc_recipient and
bcc_recipient -- use recipient instead. Removed comment_to,
commented_in, footnote_to and footnoted_in, and added text_link
as a replacement.
* src/server/text.c (find_recipient): Adjusted to Info_datum
unification. Simplified code.
(is_member_in_recpt): Ditto.
(do_sub_recpt): Ditto.
(is_sender): Ditto.
(filter_secret_info): Ditto.
(person_text_read_access): Ditto.
(do_delete_text): Ditto.
(check_double_subm): Ditto.
(check_double_comm): Ditto.
(create_text_check_misc): Ditto.
(create_text_add_aux): Ditto.
(is_comment_to): Adjusted to Info_datum unification.
(is_footnote_to): Ditto.
(do_add_footnote): Ditto.
(do_add_comment): Ditto.
(do_add_bcc_recpt): Ditto.
(do_add_cc_recpt): Ditto.
(do_sub_comment): Ditto.
(do_sub_footnote): Ditto.
(is_comm_sender): Ditto.
(create_text_add_miscs): Ditto.
* src/server/text-garb.c (garb_text): Adjusted to Info_datum
unification. Simplified code.
* src/server/ram-parse.c (fparse_misc_info): Ditto.
* src/server/ram-output.c (foutput_misc_info): Ditto.
* src/server/prot-a-parse.c (prot_a_parse_misc_info): Ditto.
* src/server/prot-a-output.c (prot_a_output_misc_info): Ditto.
* src/server/membership.c (add_rec_time): Ditto.
* src/libraries/libcommon/misc-parser.c (parse_next_misc):
Adjusted to Info_datum unification.
* src/server/dbck.c (is_comment_to, is_commented_in)
(is_footnote_to, is_footnoted_in): Adjusted to Info_datum
unification.
(is_recipient): Adjusted to Info_datum unification. Simplified
code.
2001-11-03 Per Cederqvist <ceder@moria>
Add references to Bugzilla for all relevant FIXME comments, and
remove the others. All FIXME comments now use the same format.
* src/server/aux-items.c: Added references to Bugzilla for all
FIXME comments.
* src/server/conference.c: Ditto.
* src/server/conf-file.c: Ditto.
* src/server/dbck.c: Ditto.
* src/server/disk-end-of-atomic.c: Ditto.
* src/server/internal-connections.c: Ditto.
* src/server/internal-services.h: Ditto.
* src/server/local-to-global.c: Ditto.
* src/server/person.c: Ditto.
* src/server/prot-a-parse.c: Ditto.
* src/server/regex-match.c: Ditto.
* src/server/server-config.c: Ditto.
* src/server/simple-cache.c: Ditto.
* src/server/text-garb.c: Ditto.
* src/server/updateLysKOM.c: Ditto.
* src/server/admin.c: Removed obsolete FIXME comments.
* src/server/cache-node.c: Ditto.
* src/server/log.c: Ditto.
* src/server/session.c: Removed obsolete FIXME comments. Added
references to Bugzilla for all remaining FIXME comments.
* src/server/text.c: Ditto.
* src/libraries/libmisc/numlist.c: Use FIXME instead of "+++" to
note stuff that needs fixing. Don't enter these things into
Bugzilla, since numlist.c isn't used.
Remove unneeded casts.
* src/server/ram-parse.c (fparse_aux_item_link): Removed unneeded
cast.
* src/server/prot-a.c (prot_a_parse_packet): Removed unneeded
cast.
Log warning messages for two conditions that should never occur.
* src/server/membership.c: Added references to Bugzilla for all
FIXME comments.
(access_perm_helper): Log a warning if viewer_p == NULL.
* src/server/connections.c: Added references to Bugzilla for all
FIXME comments.
(logout_client): Log a warning message if active_connection != NULL.
2001-10-29 Per Cederqvist <ceder@moria>
* src/libraries/libansi/setsid.c (setsid): Updated a comment.
(rcsid): Removed.
2001-10-28 Per Cederqvist <ceder@moria>
Make more symbols private to aux-items.c.
* src/server/aux-items.h (aux_item_add_perm): Now static; removed
from this file.
(find_aux_item_definition): Ditto.
(find_aux_item_index): Ditto.
(find_aux_item): Ditto.
* src/server/aux-items.c (simple_aux_item): Added a cast for the
name.
(find_aux_item_definition): Added static modifier.
(find_aux_item_index): Ditto.
(aux_item_add_perm): Ditto.
(find_aux_item): Ditto.
(aux_item_trigger_mirror_faq): Ditto.
(aux_item_trigger_link_item): Ditto.
(aux_item_validate_existing_text): Ditto.
(aux_item_trigger_mark_text): Ditto.
(aux_item_trigger_unmark_text): Ditto.
Code cleanup.
* src/server/prot-a-parse.c (prot_a_parse_misc_info): Removed a
couple of unnecessary casts.
Enter "Future Changes" notes into Bugzilla.
* doc/Protocol-A.texi (Future changes): Entered all future changes
into Bugzilla. Refer to Bugzilla. (Bug 131).
* doc/constructs.expected: Updated.
Handle @w{} in Protocol-A.texi, and refine the checkargs.py.
* doc/checkargs.py (lexer.pushback): New function. Use it for @w.
Also use it, intstead of lexer.ignore, for @code, @uref,
@footnote, @email, @asis, @samp, @pxref, @var, @emph, @xref,
@badspell, @holl and @file.
(lexer.__read_arg): Handle nested braces properly.
* doc/Protocol-A.texi (Future changes): Fix markup error.
2001-10-27 Per Cederqvist <ceder@moria>
Fixed the documentation of the user area.
* doc/Protocol-A.texi (The User Area): The documented format was
not the one used by the elisp-client and kom++. Updated the
documentation to the current practice. (Bug 97).
(Future changes): Added a link to Bugzilla for one of the ideas.
The TODO list is now moved to Bugzilla @ Lysator.
* README (Contact information): Mention
http://bugzilla.lysator.liu.se/.
* doc/IDEAS: All items are now moved to Bugzilla.
* TODO: All unfixed items are now moved to Bugzilla.
* HACKING: Mention bug 77 (removal of man-pages).
2001-10-26 Per Cederqvist <ceder@moria>
Use difftime() to subtract time_t values.
* src/server/rfc931.c (get_real_username): Use difftime() instead
of '-'. (Bug 103).
* src/server/dbck-cache.c (timerdiff): The tv_usec part of the
timeval is ignore. Added a comment documenting that that is OK.
2001-10-04 Per Cederqvist <ceder@moria>
* TODO (BUGZILLA-MARKER): Start to move stuff to
http://bugzilla.lysator.liu.se/. Everything above the marker is
copied into that bug reporting system.
2001-09-30 Per Cederqvist <ceder@moria>
* Release 2.0.5.
Release administrativa.
* configure.in: Set version 2.0.5.
* versions (SERVER-VERSION): 2.0.5.
(SERVER-COMPAT-VERSION): 20005.
* NEWS: Documented 2.0.5.
* doc/Protocol-A.texi (Document Edition History): Document edition
10.5.
Doc fix.
* doc/lyskomd.texi (Aux-Item Definition File): Define what is
meant by "owner" for the owner-delete property.
Expand the test suite.
* src/server/testsuite/lyskomd.0/21.exp: Test owner-delete
handling, currently only on conferences.
Release preparations.
* README: Updated required version of Dejagnu. Say that it needs
TCL and expect, and add URL:s to them.
* HACKING: Updated required versions for automake and autoconf.
Mention Python and DejaGnu.
The validate regexp for mx-date allowed junk before and after the
time.
* run-support/aux-items.conf (mx-date): Anchor the regexp.
Reported by Per Starbck.
* src/server/testsuite/lyskomd.0/20.exp: Added tests for the
syntax of the mx-date aux-item.
2001-09-29 Per Cederqvist <ceder@moria>
Write tests for aux-items 32 and 10100-10104, and discover a minor
conference number leak.
* src/server/testsuite/lyskomd.0/20.exp: Write tests for aux-items
32 and 10100-10104.
* src/server/person.c (create_person_generic): This can leak
conference numbers. Write a comment about it.
* src/server/conference.c (do_create_conf): Ditto.
* doc/lyskomd.texi (Adding Aux-Item Types): Talk more about test
cases.
Write test cases for aux-item 31 (canonical-name), and fix a bug
in the validate regexp.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
20.exp.
* run-support/aux-items.conf (canonical-name): Added a missing "?"
to the validate regexp: the port number part should be optional.
* src/server/testsuite/lyskomd.0/20.exp: New file that is intended
to check aux-item 31, 32 and 10100-10104. Tests for aux-item 31
are written now.
Cleanup.
* src/server/testsuite/lyskomd.0/13.exp: State what this test is
about.
* src/server/testsuite/lyskomd.0/03.exp: Removed an unneeded
"sleep 2" and some disabled code that is no longer needed. Mark
where letterbox auxitems should be added.
Fix release lint.
* src/server/testsuite/lyskomd.0/Makefile.am (MOSTLYCLEANFILES):
Added aux-items-18.conf.
(EXTRA_DIST): Added regexp-match-cov.exp.
* src/server/testsuite/lyskomd.0/18.exp (copy_aux): New function.
Use built-in TCL support instead of system "cp ..." to copy
files. Remove the target file before copying a file to it, to
avoid permission problems. Use copy_aux everywhere that
aux-items-18.conf was created.
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added l2g.0/12.exp
(MOSTLYCLEANFILES): Added usage.all.
* src/server/Makefile.am (MOSTLYCLEANFILES): Added version-info.c
and prot-a-parse-arg.c.
(nodist_lyskomd_SOURCES): New target.
(nodist_dbck_SOURCES): New target.
(NODIST_PROTA): New variable. Moved prot-a-parse-arg.c from PROTA
to this variable.
(NODIST_GENOBJS): New variable. Moved version-info.c from
DISKOBJS to this variable.
(NODIST_DISKOBJS): New variable.
(NODIST_DBCK): New variable. Moved version-info.c from DBCK to
this variable.
* src/libraries/libansi/Makefile.am (MOSTLYCLEANFILES): Added
*.da, *.bb, *.gcov and *.bbg.
* run-support/Makefile.am (EXTRA_DIST): Added aux-items.conf.
(uninstall-local): Remove config, but only if it isn't modified.
* doc/Makefile.am (MOSTLYCLEANFILES): Added *.tmp.
(EXTRA_DIST): Added checkargs.py and constructs.expected.
* db-crypt/db/Makefile.am (uninstall-local): New target. Remove
lyskomd-data and lyskomd-texts, but only if they are unmodified.
2001-09-23 Per Cederqvist <ceder@moria>
* HACKING: Run extended tests as part of the release process.
Fixed a bug that caused async-new-recipient to not be sent in some
cases when passive memberships were involved.
* src/server/text.c (is_member_in_recpt): Added patch by Joel
Rosdahl so that bcc-recpt are really skipped over instead of
producing false negatives -- a later cc-recpt or recpt can now
produce a positive answer.
* src/server/testsuite/lyskomd.0/gen-19.py: New file. This is
mostly a copy of gen-15.py, but changed so that combinations of
passive and active memberships are tested.
* src/server/testsuite/lyskomd.0/Makefile.am (check_DATA): Added
19.exp.
(19.exp): New target.
(EXTRA_DIST): Added 16.exp, 17.exp, 18.exp, 19.exp and gen-19.py.
Add progress message on slow tests.
* src/server/testsuite/lyskomd.0/gen-15.py: Added some
documentation.
(simple_create_delete): Print progres messages when running
extended tests.
(simple_create_add_delete): Likewise.
Re-enable all tests.
* src/server/testsuite/lyskomd.0/01.exp: Enable some matching that
David Byers commented out yesterday. The test works for me. The
re-enabled lines are marked with a "NOTE:" comment.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
Port to DejaGnu 1.4.2/TCL 8.3/expect 5.32.2.
* src/server/testsuite/lyskomd.0/14.exp: Use "*-*-*" instead of
"*" as argument to setup_xfail, as required by DejaGnu 1.4.2.
* src/server/testsuite/config/leaks.exp (startup_leaks): Don't use
variable substitution in default arguments. It doesn't work.
Port to Python 2.1.
* src/server/testsuite/tcpconnect.py: Use string.replace instead
of regsub.gsub.
Port to autoconf 2.52/automake 1.5.
* doc/Makefile.am: Stop complaints from automake by using "##"
instead of "#" as comment leader in commands.
* configure.in: Adjusted to autoconf 2.52: AC_INIT now takes
package name and version as arguments. Use AC_CONFIG_SRCDIR. Use
AC_HELP_STRING to format help strings. Use CMOD_CHECK_CC_OPT
instead of CMOD_COMPILER_CC_ACCEPTS. Use AC_CONFIG_FILES.
* acinclude.m4 (CMOD_COMPILER_CC_ACCEPTS): Removed.
(CMOD_CHECK_CC_OPT): New macro.
2001-09-22 Per Cederqvist <ceder@lysator.liu.se>
Code cleanup.
* src/server/updateLysKOM.c (checkstatus): Use sizeof(lbuf)
instead of 80.
2001-09-22 Per Cederqvist <ceder@moria>
Document the "owner-delete" aux-item configuration parameter.
* doc/lyskomd.texi (Aux-Item Definition File): Document
owner-delete.
Back out the patch from Joel Rosdahl for now.
* src/server/text.c: Back out a patch from Joel Rosdahl that was
included in the last commit by David Byers. The patch is probably
good, but there was no changelog entry, and (more importantly) I
want to write test cases that illustrates the problem before
applying the fix.
Whitespace fixes.
* src/server/aux-items.c (check_delete_aux_item_list): Indentation
fixes.
(aux_inherit_items): Indentation fix.
2001-09-22 David Byers <davby@ida.liu.se>
Port the test suite to a modern dejagnu.
* src/server/testsuite/config/unix.exp (l2g_start): Use
exp_continue instead of continue -expect.
(lyskomd_start, lyskomd_fail_start, dbck_run): Ditto.
* src/server/testsuite/lyskomd.0/11.exp: Use exp_continue instead
of continue -expect.
Test suite fixes.
* src/server/testsuite/lyskomd.0/01.exp: Expect aux-item 31, 32
and 10100-10104 to exist.
* src/server/testsuite/lyskomd.0/03.exp: Ditto.
* src/server/testsuite/lyskomd.0/18.exp: Ditto.
Added the "owner-delete" aux-item configuration parameter.
* src/server/aux-items.c (check_delete_aux_item_list): Rewrote
check for delete permissions as multiple if-elseif statements
instead of a compound expression, 'cause the compound expression
was getting just a little bit difficult to understand.
* run-support/aux-items.conf (redirect): Set owner-delete.
(x-face): Ditto.
(pgp-public-key): Ditto.
(e-mail-address): Ditto.
(faq-text): Ditto.
(allowed-content-type): Ditto.
* src/server/text.c (modify_text_info): Added author as owner
argument to check_delete_aux_item_list.
* src/server/admin.c (modify_system_info): Added zero as owner
argument to check_delete_aux_item_list.
* src/server/aux-item-def-parse.y (assign): Added owner-delete.
* src/server/aux-items.c (empty_aux_item_definition): Added
value for owner_delete.
(simple_aux_item): Ditto.
* src/server/aux-items.h (struct Aux_item_definition_s): Added
owner_delete field after may_not_delete.
(check_delete_aux_item_list): Added owner parameter.
* src/server/aux-items.c (check_delete_aux_item_list): Add owner
parameter. Check owner_delete to see if object owner may delete
item.
* src/server/conference.c (modify_conf_info): Pass conference
supervisor to check_delete_aux_item_list.
2001-09-22 Per Cederqvist <ceder@moria>
Document that clients should allow conferences to be looked up by
number.
* doc/Protocol-A.texi (VERSION): Bugfix: set to 2.0.4, not 1.0.4.
(Client-side name expansion): New node.
2001-05-24 Per Cederqvist <ceder@moria>
* Protocol-A.texi 10.4 released.
Added new aux-items to aux-items.conf.
* run-support/aux-items.conf: Added canonical-name [31],
mx-list-name [32] mx-mime-belongs-to [10100], mx-mime-part-in
[10101], mx-mime-misc [10102], mx-envelope-sender [10103] and
mx-mime-file-name [10104].
Fix "make check".
* doc/checkargs.py (lexer.ignore): Ignore @file and @TeX.
New aux-items: canonical-name and mx-list-name. Two cross
references added.
* doc/Protocol-A.texi (Aux-Item Types): Added canonical-name [31]
and mx-list-name [32].
(Predefined Aux-Item Types): Added a cross reference to Aux-Item
Types.
(query-predefined-aux-items): Likewise.
(Document Edition History): Document edition 10.4.
2001-05-23 Per Cederqvist <ceder@moria>
Fix the update-www target in doc.
* doc/Makefile.am (protocol-a.html): New target.
(update-www): Give up on DVI and PDF. texinfo.tex is currently
too broken for my macro usage. Fix the generation of HTML and
Info for the web page.
Texinfo tweaking.
* doc/Protocol-A.texi (Preface): Rearrange conditionals so that
some duplicated text can be removed.
2001-05-20 Per Cederqvist <ceder@moria>
The documentation for the old-pwd argument to set-passwd was
wrong.
* doc/Protocol-A.texi (set-passwd): old-pwd must match the
password of the currently logged in person, not of the person
whose password is being changed.
Texinfo tweaking.
* doc/Protocol-A.texi (Top): Fix braino ("protocol" -> "request").
(get-session-info-ident): Fix TeX complaints.
(map-created-texts): Likewise.
Remove trailing @c in macro blocks. They are not needed, and they
do some harm.
(daemon): Move macro definition to avoid using @badspell before
that macro is defined.
2001-05-17 Per Cederqvist <ceder@moria>
More Protocol-A.texi tweaks.
* doc/Protocol-A.texi (Top, Concepts, The Aux-Item List)
(Fundamentals, LysKOM Data Types, Who Information)
(Protocol Requests, Asynchronous Messages, Common Commands): Menu
descriptions added.
(get-text): @badspell added in example.
(Who Information): These types are all obsolete. Almost.
(Client-Server Dialog): Mention asynchronous messages.
2001-05-13 Per Cederqvist <ceder@moria>
Spell-check Protocol-A.texi.
* doc/Makefile.am (check-doc): Ignore @holl and @badspell.
* doc/checkargs.py (lexer): Ignore @badspell, @holl and @daemon.
* doc/Protocol-A.texi: Added spell-ignore and spell-end-ignore
about several regions where spell checking doesn't make sense.
Removed rcsid line. Added ispell magic after @bye. Several
spelling errors fixed.
(daemon, badspell): New macros. Use them where appropriate.
(holl): New macro. Change all examples of Hollerith-coded strings
to use this.
(re-z-lookup): Fixed broken length of Hollerith string in the
example.
* doc/Makefile.am (check-doc): Ignore stuff after @bye.
2001-05-09 Per Cederqvist <ceder@moria>
New predefined aux-items: 10100-10104.
* doc/Protocol-A.texi (Predefined Aux-Item Types): State that
client-specific aux-items can be redefined as predefined.
(Client-Specific Aux-Item Types): Likewise.
(komimportmail Aux-Item Types): Node removed. Contents moved to
"Aux-Item Types".
(Aux-Item Types): Added mx-mime-belongs-to [10100],
mx-mime-part-in [10101], mx-mime-misc [10102],
mx-envelope-sender [10103] and mx-mime-file-name [10104].
2001-05-08 Per Cederqvist <ceder@moria>
* doc/Protocol-A.texi (Aux-Item Types): Use text/x-kom-basic
instead of x-kom/basic in the examples.
(Reformattable Text (text/x-kom-basic)): New name for former
"Reformattable Text (x-kom/basic)". Mention that the type was
previously known as x-kom/basic.
Removed a few nodes that contained no information.
* doc/Protocol-A.texi (Conference Lists (x-kom/conflist)): Empty
node removed.
(Only read the most recent N texts): Likewise.
(Review the last N by FOO to BAR): Likewise.
(Remote control): Likewise.
2001-05-05 Per Cederqvist <ceder@moria>
Update checkargs.py for todays edits of Protocol-A.texi.
* doc/checkargs.py (lexer.run): It is not OK to reach EOF.
(lexer.ignore): Ignore @display.
(lexer.toplevel_bye): Exit when reaching "bye".
(lexer.__parse_userdefined_types): Ignore @need commands.
Separate sentences with two spaces, not one, as per the Texinfo
documentation.
* doc/Protocol-A.texi: Sentences in Texinfo should end with double
spaces. Set sentence-end and sentence-end-double-space in the
local variables section, and update the entire document with lots
of scattered whitespace changes.
Split and move text in Protocol-A.texi to make the generated Info
file more useful.
* doc/Protocol-A.texi (LysKOM Data Types): Split into several
subnodes. Updated all cross references to point to the relevant
subnode.
(Protocol Notation): New node. Move text here to avoid too much
text before menus in Info and HTML output. Describe the syntax of
call headings.
(About Asynchronous Messages): New node. Move text here to avoid
too much text before menus in Info and HTML output.
Remove redundancy in the description of error messages. Fix the
wording of the error messages that may be sent during connection
establishment. Mention that the client can issue several calls at
once, and that replies are sent in order.
* doc/Protocol-A.texi (Connecting to the Server): New node,
containing the first part of the "Client-Server Dialog" node.
Added a footnote about "Protocol A" and "Protocol B". Added some
missing markup. Don't talk about what happens when a protocol
other than Protocol A is used. The error message for an
unsupported protocol is "%%LysKOM unsupported protocol.", not
"%%Unsupported protocol". The error message used when no
connections are available was lacking the trailing dot.
(Client-Server Dialog): Much text moved to "Connecting to the
Server". Mention that the client can issue several calls without
waiting for the replies, but that it must read replies when they
arrive. Mention that the replies are sent back in the proper
order, but that clients are wise not to rely on that. Renamed
error-no in the error-reply to error-code, to make the document
more coherent. Changed the type of error-code to INT32, and
removed the types Error-No and error-no. Added the "insane token
length" and "insane array size" error messages to protocol-error.
(Error Responses): Node removed. The old contents were moved into
"Client-Server Dialog" or discarded because it was redundant.
(Protocol Error Messages): New name for former "Special Errors".
Removed "%%No connections left.", since that message is only sent
during connection establishment.
(Error Codes): Refer to error-status, not error-code.
(Future changes): Talk about why giving the server freedom to
reorder the replies may be beneficial, and how it can be done
without breaking any clients.
2001-05-04 Per Cederqvist <ceder@moria>
Minor Protocol-A edits.
* doc/Protocol-A.texi (Error Codes): Introductory text added.
2001-05-03 Per Cederqvist <ceder@lysator.liu.se>
More minor Protocol-A fixes.
* doc/Protocol-A.texi (Future changes): The mark-as-unread call is
missing.
(Error Responses): New name for former "Error Codes". Moved to
inside the "Client-Server Dialog" chapter.
(Special Errors): Moved inside the "Client-Server Dialog" chapter.
(Error Codes): New name for former "Normal Errors".
2001-05-01 Per Cederqvist <ceder@moria>
Some minor Protocol-A.texi fixes.
* doc/Protocol-A.texi (mark-as-read): Typo fixed: "as" -> "at".
(create-text): Added missing @misc markup.
(Name Expansion): Removed the "Case Conversion" heading, as the
collate table is only relevant for "KOM Conventions" name
expansion. Update the information with a link to the
get-collate-table request.
(The Misc-Info List): Mention that bcc-recpt are converted to
cc-recpt only when visible.
(Client-Server Dialog): Spelling error fixed. Mention that
not-implemented works only if the client follows the strict rules
regarding whitespace in protocol requests.
(set-conf-type): Name the "four-bit conference type".
(get-conf-stat-old): This returns a Conference-Old, not a
Conference.
(Future changes): Complain about super conferences, the securty
system, and last-text-read/read-texts.
Move some stuff to appendices in Protocol-A.texi, and move some
other stuff around.
* doc/Protocol-A.texi (Concepts): New name for former
"Introduction".
(The User Area (x-kom/user-area)): Added a reference to "The User
Area".
* doc/Protocol-A.texi (Preface): New name for former "Overview".
(Notation): Section moved from "Overview" to "Fundamentals".
(Client-Server Dialog): Section moved from "Introduction" to
"Fundamentals".
(Fundamentals): New name for former chapter "Data Types".
(LysKOM Data Types): Moved from "Data Types" to a separate
chapter. All subsections moved up one level.
(Name Expansion): All subsections moved up one level -- the level
was wrong.
(Aux-Item Types, Predefined Aux-Item Types): Moved the list of
predefined aux-items to the new chapter Aux-Item Types.
* doc/checkargs.py (lexer): Ignore @appendix.
* doc/Protocol-A.texi (Document Edition History): Moved to a
separate appendix.
(Protocol Version History): Moved to a separate appendix.
(Name Expansion): Moved to a separate chapter.
(Writing Clients): Now an appendix, not a chapter.
(Importing and Exporting E-Mail): Likewise.
(Articles, LysKOM Data Types): Don't say that the misc-info list
will be removed in the future. Move such speculation to a new
appendix.
(Future changes): New appendix.
(Articles): Clarify the discussion about local and global text
numbers.
(Persons and Sessions): Make this a @section instead of a
@subsection to Conferences.
2001-05-01 Per Cederqvist <ceder@moria>
Make all types in requests and asynchronous messages clickable in
HTML. Prepend @i{Example:} to *all* request examples. Added a
missing example. Avoid @iftex constructs in the document body.
* doc/Makefile.am (check-doc): Ignore @anchor and @lt.
* doc/checkargs.py (lexer): Ignore @need, @reqexample and @anchor.
(lexer.__parse_userdefined_types): Handle @anchor.
(lexer.__parse_type): Requre @lt markup.
(lexer.__get_lt_token): New method.
(lexer.__get_token): Handle the new tokens '{' and '}'.
(lexer.__parse_userdefined_types): Expect @lt{} markup
(lexer.__parse_userdefined_struct): Likewise.
(lexer.__parse_userdefined_selection): Likewise.
(lexer.__parse_userdefined_enumeration_of): Likewise.
* doc/Protocol-A.texi (@reqexample): New macro. Use it in front
of every example of request usage. Previously, many but not all
examples were introduced by a @i{Example:} line. That line is now
included in the @reqexample macro, together with a "@need 2000"
statement.
(IAM, Pell, Kent, presconf): New values, to handle TeX/Info
incompatibilities regarding Latin-1 characters without having to
clutter the document with @iftex constructs. Removed all related
@iftex constructs in the body of the document. @ae{} can be used
in both Info and TeX mode; do so.
(set-super-conf): Missing example added.
(Simple Data Types): Add @anchor targets for all types.
(LysKOM Data Types): Likewise.
(@lt): New macro. Use it in all requests and asynchronous
messages to mark up the types.
(LysKOM Data Types): Added @lt markup around all types on the
right hand side.
2001-04-30 Per Cederqvist <ceder@moria>
Added macros @asynclink and @asyncdlink.
* doc/checkargs.py (lexer): Ignore asynclink.
(lexer.toplevel_asyncdlink): New method.
* doc/Protocol-A.texi (@asynclink, @asyncdlink): New macros. Use
them instead of @link where appropriate.
(Asynchronous Messages): Use @reqlink instead of @req.
* doc/Makefile.am (check-doc): Handle @asynclink and @asyncdlink.
Check documentation of asynchronous messages.
* doc/Makefile.am (check-doc): Create requests-numbered.tmp.
Create asyncs-numbered.tmp. Omit DEBUG_CALLS-only asynchronous
messages from "async.h".
* doc/Protocol-A.texi: Create the "am" index for asynchronous
messages. Add @amindex and @aarg markup for all asynchronous
messages, and remove the trailing semicolon in the argument list.
Merge all indices into one.
(add-member): Malformed sentence fixed.
(async-i-am-off, async-i-am-on-obsolete): Mark as obsolete, and
tell why they are no longer used.
(async-broadcast): Mark as obsolete.
(Type Index, Request Index): Removed.
(Index): Added.
* doc/checkargs.py (lexer.__init__): Initialize __amindex,
__defined_asyncs and __implemented_asyncs.
(lexer): Ignore @defcodeindex and @syncodeindex.
(lexer.toplevel_node): Check for undocumentet arguments to
asynchronous messages.
(lexer.toplevel_findex): Check for @amindex entries in @findex
nodes.
(lexer.toplevel_amindex): New method.
(lexer.__parse_async): New method.
(lexer.toplevel_aarg): Implemented.
(lexer.toplevel_bye): Check for unterminated @amindex nodes and
undocumented asynchronous messages.
* doc/checkargs.py (lexer.__init__): Read requests-numbered.tmp.
(lexer.toplevel_findex): Check that the same request name isn't
used twice.
(lexer.toplevel_bye): Check that all implemented requests are
documented.
(lexer.__parse_request): Check that the proper request number is
used, and that the request is really implemented.
Check type definitions, that all types are used, and some related
stuff. Renamed ENUMREATION_OF to ENUMERATION-OF.
* doc/Protocol-A.texi (Simple Data Types): Renamed ENUMERATION_OF
to ENUMERATION-OF. Nothing else uses "_". The only user updated.
(LysKOM Data Types): Missing semicolon added.
* doc/checkargs.py (defined_types): New variable.
(number_suffixed): New function.
(prot_a_type): New class, with several derived classes.
(reader.error): Allow the line number to be a string, such as
'*builtin*'.
(lexer.__init__): Added 'ENUMERATION-OF' to the set of builtin
aggregates. Add builtin types to defined_types.
(lexer): Ignore @dots{}.
(lexer.toplevel_bye): Check that all defined types are used.
(lexer.toplevel_tindex): Pass a list of the @tindex entries to
__parse_userdefined_types, so that that function can check that
they are all defined.
(lexer.__parse_userdefined_types): Implemented. Several helper
functions introduced.
(lexer.__parse_type): Simplified. Do some error checking and
bookkeeping. Return a tuple, so that it is easier for the caller
to see if an array was used. All callers updated.
(lexer.__bad_arg): Accept "reservedX" and "flgX" for numerical
values of X.
(lexer.__get_token): Handle the new tokens "::=", "|" and "=".
Ignore comments (introduced with "!").
2001-04-29 Per Cederqvist <ceder@moria>
Minor fixes to the protocol specification.
* doc/Protocol-A.texi: Use @dots{} instead of "...".
(Simple Data Types): Use "::=" instead of ":" in two places.
Added missing @example...@end example markup. Fixed the SELECTION
example -- the tail is not optional.
@reqdlink now works when using TeX.
* doc/Protocol-A.texi: Added a proper definition of @reqdlink for
TeX, written by David Byers. Use "@tex" instead of "@begin tex".
* doc/checkargs.py (lexer): Ignore @tex.
2001-04-28 Per Cederqvist <ceder@moria>
Check case of user-defined types.
* doc/checkargs.py (lexer.__init__): Set __builtin_types,
__builtin_aggregates, __builtin_typelike, __tindex_seen and
__types_used.
(lexer.__seen_type): New method.
(lexer.toplevel_tindex): Implement.
(lexer.__parse_userdefined_types): New method, not yet
implemented.
(lexer.__bad_type): Check that the casing rules for user-defined
types are adhered to.
* doc/Protocol-A.texi (set-pers-flags): Fixed typo.
Check @linkhere usage. Stricter parens checking.
* doc/checkargs.py (reader.check_paren_null): New name for former
check_paren_eof. All callers updated. Clear __parenstack, so
that errors are reported only once.
(lexer.__init__): Initialize __linkhere.
(lexer.toplevel_node): Check that no @linkhere or closing
parenthesis are pending.
(lexer.toplevel_reqdlink, lexer.__assert_no_linkhere)
(lexer.toplevel_linkhere): New methods.
Renamed modify_server_info to modify_system_info, to match
Protocol-A.texi.
* src/include/services.h (modify_system_info): New name for former
modify_server_info().
* src/server/admin.c: Likewise.
* src/server/fncdef.txt: Likewise.
Mark up all requests and fix all references in Protocol-A.texi.
Check for balanced parenthesis.
* doc/checkargs.py (reader.parens, reader.rev_parens): New
constants.
(reader.__init__): Initialise __parenstack, __errfound and
__quoted.
(reader.error, reader.errfound): New methods.
(reader.ungetc, reader.getc_eofok): Handle quoting and parens
nesting.
(reader.check_paren_eof): Report unbalanced parens at EOF.
(lexer.__init__): Moved __errfound to the reader class.
(lexer.run): Check for unbalanced parens at EOF.
(lexer.toplevel_reqlink): Ignore.
(lexer.toplevel_reqdlink, lexer.toplevel_linkhere): Ignore, for
now. We should check nesting et c of these.
(lexer.toplevel_unmacro): Ignore.
(lexer.error): Moved the implementation to the reader class. This
is only a wrapper.
* doc/Makefile.am (check-doc): Add @reqlink and @reqdlink to
requests-@.tmp.
* doc/constructs.expected: Added "@linkhere{}".
* doc/Protocol-A.texi: Use @reqlink and @reqdlink where
appropriate. Fix lots of malformed @ref, @xref and @pxref
usages. Also:
(@reqlink, @reqdlink, @linkhere): New markup macros.
(Document Edition History): Added missing @async markup.
(About Aux-Items): Added missing @field markup.
(Simple Data Types): Removed an unbalanced close parenthesis.
(LysKOM Data Types): Added missing @field markup. Removed an
unbalanced close parenthesis.
(lookup-name): Added a missing close parenthesis.
(get-info-old): Added a missing close parenthesis. This returns
Info-Old, not Info.
(create-anonymous-text-old): Added missing @field markup.
(login): Added missing close parenthesis.
(local-to-global): Don't use fancy mathemtical notations for
half-closed intervals. Added missing @type markup.
2001-04-23 Per Cederqvist <ceder@moria>
Don't omit stuff when formatting Protocol-A.texi as HTML.
* doc/Protocol-A.texi: Use @ifnottex instead of @ifinfo almost
everywhere that @ifinfo was used.
(re-z-lookup): Added missing spaces in the
example.
(lookup-z-name): Likewise.
(get-members): Likewise.
(Protocol Requests): Removed text about "upright text" in
the replies in the examples, since no such text exists.
2001-04-19 Per Cederqvist <ceder@moria>
Fix a couple of Protocol-A.texi errors.
* doc/Protocol-A.texi (Protocol Requests): Mention that extra
newlines sometimes are used in the examples.
(create-person): Language fix.
2001-04-18 Per Cederqvist <ceder@moria>
Fix a few more Protocol-A.texi errors.
* doc/Protocol-A.texi (get-membership-old): Use a "want-read-texts
: BOOL" argument instead of "mask : BITSTRING(want-read-texts)".
The result is the same, but using BOOL makes the prototype easier
to read. Document the argument more verbosely.
(get-membership): Do likewise.
(login): Do likewise for the "invisible" argument.
(create-anonymous-text-old): Added @misc{} markup.
* doc/constructs.expected: Updated.
Fix lots of minor errors in Protocol-A.texi. Document that the
invitation membership flag is automatically set in some
circumstances.
* doc/checkargs.py (lexer.__bad_arg): Added a missing
__unget_token to get a better error message.
* doc/Protocol-A.texi: Fix all @rarg{} arguments that used
the wrong argument name. Edit all request prototypes so that the
consistently use semicolon as an argument delimiter, not an
argument terminator. Add missing @rarg{} markup.
(Protocol Version History): Remove a
trailing space.
(get-membership-old): Use @field{read-texts} instead of
@rarg{read-texts}.
(get-created-texts): Added missing '->' token.
(create-anonymous-text): Added @misc{} markup.
(create-person): Use @priv{create-pers} instead of
@rarg{create-pers}.
(modify-system-info): Docuent items-to-delete and items-to-add.
(add-member): Document type, including the fact that the
invitation field is sometimes set automatically.
Check that @rarg{} is used correctly.
* doc/Makefile.am (check-doc): Depend on info. so that
checkargs.py is only run on a file that makeinfo can process.
Run checkargs.py on Protocol-A.texi.
* doc/checkargs.py: New file.
* doc/lyskomd.texi: Break overly long lines.
2001-04-16 Per Cederqvist <ceder@moria>
Fix comments.
* src/server/async.h: Don't refer to removed files.
* src/include/kom-types.h: Likewise.
* HACKING: There are version numbers in Protocol-A.texi as well.
Prepare Protocol-A.texi for web publication. Add and check
domain-specific markup.
* doc/Makefile.am (.texi.notab): Check that no lines are more than
79 characters long.
(update-www): New target. This is work in progress and does not
yet work.
(Protocol-A.pdf): New target.
(check): Depend on check-doc.
(check-doc): New target. This is work in progress, but it already
performs several useful sanity checks on Protocol-A.texi.
* doc/.cvsignore: Ignore *.tmp, Protocol-A.pdf, protocol-a.html,
and stamp-vti1.
* doc/constructs.expected: New file, that enumerates the expected
@-constructs in Protocol-A.texi.
* doc/Protocol-A.texi (PROTOEDITION, PROTOVER, VERSION): New
constants. Use them throughout the document instead of 10.3, 10
and 1.0.4. Bump PROTOEDITION to 10.4. Added an explicit
permission to process the texi file with TeX. Ensure that all
permission notices are equal. Print all version information on
the title page. Moved the contents to the front of the document,
and avoid printing them in the html document. Add HTML links to
Lysator and LysKOM before the first node.
(Top): Enclose this node in @ifnottext instead of @ifinfo. Refer
to the web site.
(Overview): Include all version numbers and the canonical URL for
the protocol specification here as well, but only @iftex.
(Document Edition History): New name for former node "Document
Revision History". Use the term "edition" throughout the
document. Added a not for edition 10.4.
(Predefined Aux-Item Types, create-anonymous-text-old)
(create-anonymous-text, modify-system-info): Get rid of overfull
hbox messages from TeX.
(Type Index, Request Index): Use @unnumbered instead of @chapter.
(all call nodes): Replaced "@unnumberedsubsec Error codes" with
"@subheading Error codes" so that they are not included in the
table of contents, and so that the PDF menus work better.
(Overview, Document Edition History): TeX lint.
(@req, @aux, @async, @type, @priv, @conftype, @misc, @rarg, @aarg)
(@errorcode, @field): New Texinfo macros. Use them where
appropriate.
2001-04-13 Per Cederqvist <ceder@lysator.liu.se>
Register the undocumented "rkom" user-area block.
* doc/Protocol-A.texi (set-client-version): The client names are
"registered", not "reserved".
(The User Area): Registered the "rkom" block.
2001-04-10 Per Cederqvist <ceder@cendio.se>
Protocol A: Document the hello string. Improve the recommended
algorithm for determining what a client has unread.
* doc/Protocol-A.texi (Client-Server Dialog): Document the format
of the hello string. Fix the example.
(What do I have unread): Recommend that clients use get-uconf-stat
instead of get-conf-stat.
2000-11-08 Per Cederqvist <ceder@lysator.liu.se>
Typo fixed.
* README: Fixed typo ("IP address" -> "hostname"). Reported by
Andreas Ehliar.
2000-09-06 Per Cederqvist <ceder@lysator.liu.se>
* Release 2.0.4.
Remove Y2k bug.
* src/server/prot-a-output.c (prot_a_output_time): Remove stupid
Y2k joke.q
Added missing files to the distribution.
* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
gen-15.py.
Test and document SIGWINCH (re-read aux-item.conf).
* src/server/testsuite/lyskomd.0/18.exp: New file, testing SIGWINCH.
* src/server/testsuite/lyskomd.0/04.exp: Add $srcdir to the
front of the aux-item file name when calling lyskomd_start.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Likewise.
* src/server/testsuite/leaks.0/leaks10.exp: Add $srcdir to the
front of the aux-item file name when calling startup_leaks.
* src/server/testsuite/leaks.0/leaks99.exp: Likewise.
* src/server/testsuite/config/leaks.exp (startup_leaks): Added
$srcdir to aux-item file.
* src/server/testsuite/config/unix.exp (lyskomd_start): Don't add
$srcdir to the name of the aux-item file.
(lyskomd_fail_start): Likewise.
* doc/lyskomd.texi (Parameters): aux-items.conf is reread when a
SIGWINCH is received.
(Signals): Likewise.
Document the new visibility rules for bcc-recpt.
* doc/Protocol-A.texi (The Misc-Info List): Fix the description of
the visibility of bcc-recpt.
Clarify the documentation for mark-as-read.
* doc/Protocol-A.texi (mark-as-read): State that it isn't
necessary for clients to call mark-as-read on deleted texts.
2000-09-05 Per Cederqvist <ceder@moria>
Set version numbers.
* versions (SERVER-VERSION): 2.0.4.
(SERVER-COMPAT-VERSION): 20004.
* configure.in: Set version number to 2.0.4.
* README: Updated for the 2.0.4 release.
* doc/Protocol-A.texi: This is revision 10.3.
(Document Revision History): Documented changes for 10.3.
Various cleanup.
* doc/lyskomd.texi (Overview): Remove mal-placed plug about the
cool free software company Cendio Systems.
* src/server/testsuite/lyskomd.0/gen-15.py (DEBUG): Set to 0.
Don't leak secret information when telling about the current
working conference.
* src/server/testsuite/lyskomd.0/16.exp (assert_0): No longer
excpect these tests to fail.
* src/server/session.c (who_is_on): Don't send info about
secret conferences.
(who_is_on_ident): Likewise.
(who_is_on_dynamic): Likewise.
(get_session_info): Likewise.
(get_session_info_ident): Likewise.
(who_is_on_old): Likewise.
* src/server/send-async.c (async_i_am_on): Don't send info about
secret conferences.
* src/server/membership.c (filter_conf_no): New function.
* src/server/manipulate.h (filter_conf_no): New function.
2000-09-04 Per Cederqvist <ceder@moria>
Implement the aux-items recommended-conf and allowed-content-type.
* src/server/testsuite/lyskomd.0/01.exp: Expect aux-item 29 and 30
to exist.
* src/server/testsuite/lyskomd.0/03.exp: Expect aux-item 29 and 30
to exist. Give Kelly Talisman two allowed-content-type
aux-items. Renumber.
* run-support/aux-items.conf: faq-text may be set on the server.
Added recommended-conf and allowed-content-type.
* src/server/testsuite/lyskomd.0/17.exp: New test.
* doc/Protocol-A.texi (Predefined Aux-Item Types): Added lots of
things that aux-items can be set on:
cross-reference += letterbox
redirect += letterbox
x-face += letterbox, server
alternate-name += letterbox
mx-allow-filter += letterbox
mx-reject-forward += letterbox
allowed-content-type += letterbox, server
Updated the description of the allowed-content-type aux item.
Typo fixed.
* doc/Protocol-A.texi (Protocol Requests): Typo in menu fixed.
Fix the visibility of bcc-recipients, so that the same rules are
used everywhere. Tighten the rules so that secret info cannot
leak through get-text-stat.
* src/server/testsuite/lyskomd.0/gen-15.py (text_stat): New
class. Rewrite the rest of this file to use it. Give authors
special privileges regarding bcc-recpts.
* src/server/testsuite/lyskomd.0/10.exp: Removed an obsolete
comment, since this test no longe fails.
* src/server/testsuite/config/unix.exp (lyskomd_start): The tests
now require more than 2000 texts. Give them 20000.
* src/server/text.c (send_async_sub_recipient): Use
filter_secret_info() so that the exact same visibility is used by
async-sub-recipient and get-text-stat.
(filter_secret_info): Don't allow the author of a text to see
bcc-recpt which are secret to him. Simplify the code slightly.
(send_async_add_recipient): Use filter_secret_info() so that the
exact same visibility is used by async-add-recipient and
get-text-stat.
2000-09-02 Per Cederqvist <ceder@moria>
Re-indent text.c. Add a few const qualifiers.
* src/server/text.c: Code re-indented.
(count_recipients): const qualifiers added
to some arguments. Code simplified.
(count_footn): Likewise.
(count_comment): Likewise.
(text_read_access): Code clarified.
(delete_text): Likewise.
(find_recipient): qualifiers added to some arguments.
(is_comment_to): Likewise.
(is_footnote_to): Likewise.
(submit_to): Likewise.
(is_member_in_recpt): Likewise.
(send_async_sub_recipient): Likewise.
(sender): Likewise.
(is_sender): Likewise.
(is_comm_sender): Likewise.
(check_footn): Likewise.
(check_comm): Likewise.
(locate_mark): Likewise.
(skip_recp): Likewise.
(recp_sent_by): Likewise.
(filter_secret_info): Likewise.
(send_async_deleted_text): Likewise.
(check_double_subm): Likewise.
(check_double_comm): Likewise.
(send_async_new_text_old): Likewise.
(send_async_new_text): Likewise.
(send_async_add_recipient): Likewise.
* src/server/membership.c (access_perm_helper): const qualifiers added
to some arguments.
(access_perm): Likewise.
(locate_membership): Likewise.
* src/server/dbck.c (locate_membership): const qualifiers added
to some arguments.
* src/server/conference.c (is_supervisor): const qualifiers added
to some arguments.
(is_strictly_supervisor): Likewise.
* src/server/manipulate.h: (access_perm): const qualifiers added
to some arguments.
(is_supervisor): Likewise.
(is_strictly_supervisor): Likewise.
(locate_membership): Likewise.
* src/server/aux-items.c: Lots of const qualifiers added.
* src/server/aux-items.h (Aux_item_validation_data): const
qualifiers added to the item and def members.
(aux_inherit_items): const qualifiers added to some arguments.
(aux_item_add_perm): Likewise.
(prepare_aux_item): Likewise.
(find_aux_item_definition): Likewise.
(aux_item_find_trigger): Likewise.
(aux_item_find_validator): Likewise.
(find_aux_item): Likewise.
(filter_aux_item_list): Likewise.
(delete_aux_item_list): Likewise.
(undelete_aux_item_list): Likewise.
(check_delete_aux_item_list): Likewise.
Test suite cleanup.
* src/server/testsuite/lyskomd.0/16.exp (assert_0): New proc. Use
it to simplify the code.
2000-08-28 Per Cederqvist <ceder@moria>
Secret conference numbers can apparently leak from the
get-session-info and who-is-on family of functions. Test cases
added.
* src/server/testsuite/lyskomd.0/16.exp: Added test cases for
async-i-am-on, who-is-on-old, who-is-on, get-session-info,
who-is-on-ident, get-session-info-ident and who-is-on-dynamic.
They all leak info about secret conferences.
2000-08-12 Per Cederqvist <ceder@moria>
More work on test cases for async messages 14-17.
* src/server/testsuite/lyskomd.0/gen-15.py: Test simple
create+add+delete.
2000-08-09 Per Cederqvist <ceder@moria>
Start writing test cases for async messages 14-17.
* src/server/testsuite/lyskomd.0/gen-15.py: New file. This is
very far from complete.
* src/server/testsuite/Makefile.am (SUBDIRS): Added lyskomd.0.
(EXTRA_DIST): Moved all files in lyskomd.0 to that makefile.
(check-lyskomd): Depend on check-recursive.
* configure.in: Remove -Wpointer-arith since it gives a lot of
false warnings when using glibc-2.1.3 and gcc-2.95.2. Create
src/server/testsuite/lyskomd.0/Makefile.
* src/server/testsuite/lyskomd.0/Makefile.am: New file, mostly
extracted from ../Makefile.am.
(15.exp): New target.
(check_DATA): New target. Added 15.exp.
2000-08-05 Per Cederqvist <ceder@moria>
The dummy_aux_item introduced 2000-05-09 was not properly
initialized.
* src/server/prot-a.c (prot_a_init): Initialize
dummy_aux_item.data and aux_item.data.
* src/server/internal-connections.c (init_connection): Initialize
dummy_aux_item.data.
(kill_client): Check dummy_aux_item.data and aux_item.data.
2000-08-04 Per Cederqvist <ceder@moria>
Minor documentation improvement.
* doc/lyskomd.texi (Parameters): Clarified the warning about
"Never save".
Documented the allowed-content-type aux item.
* doc/Protocol-A.texi (Predefined Aux-Item Types): Added a draft
description of the allowed-content-type aux item.
2000-05-09 David Byers <davby@ida.liu.se>
The server could crash when parsing over-long aux-item lists.
* src/server/connections.h: Added dummy_aux_item field.
* src/server/prot-a-parse.c (prot_a_parse_string):
(prot_a_parse_aux_item_list): Use dummy_aux_item in client
structure instead of an auto variable.
* src/server/connections.c (free_parsed): Clear
client->dummy_aux_item.
2000-04-28 Per Cederqvist <ceder@lysator.liu.se>
The data base was saved even when "Never save: true" was used.
* src/server/simple-cache.c (cache_sync_all): Return early if
param.never_save is set, so that the database won't be saved even
at normal server shutdown.
* doc/lyskomd.texi (Parameters): Updated the documentation for
"Never save".
2000-03-13 Per Cederqvist <ceder@biffen.cendio.se>
Large garb-nice values could be truncated.
* src/server/text-garb.c (garb_text): Avoid overflow when
converting the garb-nice value from days to seconds. (Suspected
by Anders ke Carlsson.)
1999-11-20 Per Cederqvist <ceder@lysator.liu.se>
Fixed a cut-n-paste error in the protocol spec.
* doc/Protocol-A.texi (LysKOM Data Types): bcc-recpt is of course
a Conf-No, not a Text-No. (Reported by Anders Franzn.)
1999-10-28 David Byers <davby@ida.liu.se>
* src/server/text.c (send_async_sub_recipient): Don't send
sub-recipient messages for bcc recipients to users who are not
members of the bcc recipient.
* src/server/testsuite/lyskomd.0/06.exp (shutdown_06): Added test
cases to test async messages when adding and removing BCC
recipients.
1999-10-27 David Byers <davby@ida.liu.se>
* src/server/ramkomd.c (dump_exit_statistics): Free
read_config_file
(main): Save name of configuration file in read_config_file.
Handle WINCH signal (re-read config file.)
* src/server/param.h: Added reread_param.
Added read_config_file
* src/server/server-config.c: Added reread_param.
1999-10-20 Kent Engstrm <kent@lysator.liu.se>
Documentation updates w.r.t. e-mail import.
* doc/Protocol-A.texi (Predefined Aux-Item Types): Introduced some
hints for client authors and clarified the description of some
aux-items based on experiences from writing "komimportmail";
changed definition of mx-in-reply-to to specify that is should
really be the Message-ID used for threading, regardless of which
header line that supplied it. Marked mx-allow-filter and
mx-reject-forward obsolete.
(komimportmail Aux-Item Types): new node describing
the aux-items introduced by this importer.
(Importing and Exporting E-Mail): rewrote most of the chapter,
using experience from "komimportmail". Removed text about
export, as it was rather naive.
1999-10-12 Kent Engstrm <kent@lysator.liu.se>
Documentation fix.
* doc/lyskomd.texi (Parameters): Moved cross-reference
to stop newer makeinfo versions from complaining.
1999-10-09 David Byers <davby@ida.liu.se>
* doc/Protocol-A.texi (Client-Specific Aux-Item Types): Added
komimportmail to reserved range.
* run-support/aux-items.conf: Fixed date validation regexp.
1999-08-13 David Byers <davby@ida.liu.se>
* doc/Protocol-A.texi (Predefined Aux-Item Types): Changed "of" to
"or" in documentation of content-type. The old wording was
incorrect and conveyed the wrong idea.
1999-09-19 Per Cederqvist <ceder@lysator.liu.se>
Prepare for dbck improvement.
* src/server/local-to-global.c (add_block_before): New static function.
(find_block): Return a pointer to the last block instead of a NULL
pointer if a too large local text number is supplied.
(l2g_expensive_set): Now fully implemented.
* src/server/testsuite/l2g.0/12.exp: New file, that tests
l2g_expensive_set.
* src/server/testsuite/test-l2g.c (main): Handle l2g_expensive_set.
Code cleanup.
* src/server/dbck.c (check_misc_any_recipient): New static function.
(check_misc_infos): Use it, to avoid repeating the same code
inline three times.
1999-09-18 Per Cederqvist <ceder@lysator.liu.se>
Prepare for dbck improvement.
* src/server/local-to-global.c (l2g_expensive_set): New function,
not yet completely implemented.
* src/server/local-to-global.h (l2g_expensive_set): New function.
Always install the distributed aux-items.conf.
* run-support/Makefile.am (sysconf_DATA): Added aux-items.conf.
(EXTRA_DIST): Removed aux-items.conf.
(install-data-local): Don't install aux-items.conf here.
* README: Warn that aux-items.conf is always installed.
1999-08-18 Per Cederqvist <ceder@cendio.se>
Added aux-item "recommended-conf".
* doc/Protocol-A.texi (Predefined Aux-Item Types): The last space
and descriptive text in a cross-reference are optional. Added
recommended-conf.
1999-07-25 Kent Engstrm <kent@lysator.liu.se>
Fixed inconsistent format for aux-item mx-date.
* run-support/aux-items.conf: change the validation of
aux-item mx-date to the format specified in Protocol-A.texi.
* src/server/testsuite/leaks.0/lots-aux-items.conf: Ditto.
Experience from writing a mail importer.
* doc/Protocol-A.texi: made definition of address aux-items
clearer (after a discussion in LysLysKOM), rewrote a lot of
the text on mail import.
Miscellaneous documentation fixes.
* doc/Protocol-A.texi (get-map): this request is indeed
obsolete as of version 10 of Protocol A.
1999-07-25 Per Cederqvist <ceder@lysator.liu.se>
* Release 2.0.3.
* NEWS: Document version 2.0.3.
* configure.in: Set version number to 2.0.3.
* versions (SERVER-VERSION): 2.0.3.
(SERVER-COMPAT-VERSION): 20003.
Looking up the empty name still caused a core dump.
* src/server/simple-cache.c (cached_lookup_name): Leaving
uninitialized data in the result is almost as bad as following the
NULL pointer. The result may contain fewer than no_of_match_info
entries -- and now the code attempts to handle it properly.
* src/server/testsuite/lyskomd.0/03.exp: Test for name lookup of
the empty string when a conference has been deleted.
* src/server/testsuite/config/unix.exp (lyskomd_start): Arrange to
always test for eof from lyskomd in expect_after, and fail if it
is detected.
Added missing newlines in restart_kom format strings.
* src/server/conference.c (lookup_z_name): Added a missing newline
in a restart_kom format string.
(do_create_conf): Likewise.
1999-07-24 Per Cederqvist <ceder@lysator.liu.se>
Implemented splitkomdb. This is highly experimental and not yet
documented.
* src/server/splitkomdb.c: New file.
* src/server/Makefile.am (bin_PROGRAMS): Added splitkomdb.
(splitkomdb_SOURCES): New variable.
* src/server/param.h (struct kom_par): Added backup_dir.
* src/server/server-config.c (parameters): Added "Backup export
directory".
(read_configuration): Handle param.backup_dir.
1999-07-23 Per Cederqvist <ceder@lysator.liu.se>
* Release 2.0.2.
* NEWS: Document version 2.0.2.
* configure.in: Set version number to 2.0.2.
* versions (SERVER-VERSION): 2.0.2.
(SERVER-COMPAT-VERSION): 20002.
* doc/Protocol-A.texi: This is revision 10.2.
(Document Revision History): This is revision 10.2.
Looking up the empty name caused a core dump.
* src/server/simple-cache.c (cached_lookup_name): Don't follow the
NULL pointer.
* src/server/conference.c (match_table): Don't declare it here.
1999-07-20 Per Cederqvist <ceder@lysator.liu.se>
* doc/Protocol-A.texi (Predefined Aux-Item Types): Typo fixed --
there is nothing called mx-o.
1999-07-14 Kent Engstrm <kent@lysator.liu.se>
Documentation fixes.
* doc/Protocol-A.texi (Protocol Requests): set-info sets server
information.
(set-last-read): last-read is a Local-Text-No.
(set-info): Info-Old is returned by get-info-old.
(async-logout): Not called async-async-logout.
1999-07-13 Kent Engstrm <kent@lysator.liu.se>
Documentation fixes.
* doc/Protocol-A.texi: Corrected spelling errors, etc.
(Conference Type): reserved1 is now called forbid-secret.
(lookup-z-name): use correct call in examples.
1999-07-12 Per Cederqvist <ceder@lysator.liu.se>
* Release 2.0.1.
* doc/Protocol-A.texi (Document Revision History): Release date
set to 1999-07-12.
The performance fix of 1999-07-06 introduced an extra newline in
the files. Fix.
* src/server/simple-cache.c (copy_file): Don't emit duplicate
newlines.
Remove false warnings.
* src/server/membership.c (access_perm): Fixed the logic error
that caused several false warnings to be logged.
1999-07-11 Per Cederqvist <ceder@lysator.liu.se>
Fix the documentation of add-recipient, async-new-recipient and
async-sub-recipient.
* doc/Protocol-A.texi (Simple Data Types): ENUMERATIONs can be
inherited from SELECTIONS.
(LysKOM Data Types): Define Info-Type.
(add-recipient): The recpt-type argument is an Info-Type, not a
complete Misc-Info.
(async-new-recipient): The type argument is an Info-Type, not a
complete Misc-Info.
(async-sub-recipient): Likewise.
(Document Revision History): Mention Info-Type.
Don't overwrite installations that have lyskomd-backup but no
lyskomd-data.
* db-crypt/db/Makefile.am (install-data-local): Don't install the
database if lyskomd-backup exists. Don't install it if any of the
databases exist.
Fixed a database error that caused damage to conferences.
* src/server/simple-cache.c (save_one_conf): Fixed a serious bug
introduced 1997-10-23 when the (as yet unused) FASTSAVE code was
written. Changes made to conferences could in some cases be
forgotten.
Fixed a harmless Y2k bug.
* src/server/log.c (kom_logv): Log the year 2000 as "00", not
"100".
(kom_log): (non-HAVE_VPRINTF version) Likewise.
Release preparations.
* NEWS: Added an entry for the 2.0.1 release.
* versions (SERVER-VERSION): 2.0.1.
(SERVER-COMPAT-VERSION): 20001.
* configure.in: Set version number to 2.0.1.
* README: Recommend running dbck when upgrading from 2.0.0.
Regexps are always case sensitive.
* doc/Protocol-A.texi: This is revision 10.1 of the specification.
(Overview): Protocol versions never have a suffix.
(Document Revision History): Wrote entry for 10.1.
(Name Expansion): Regexps are case sensitive.
(re-lookup-person): Tempus changed.
(re-lookup-conf): Tempus changed.
(re-z-lookup): Regexps are case sensitive.
* src/server/param.h (struct kom_par): Removed the
regex_use_collate_table field.
* src/server/regex-match.c (lookup_regexp): Never use a translate
table.
* src/server/server-config.c (parameters): Removed "Regexps use
collate table".
* doc/lyskomd.texi (Parameters): Removed "Regexps use collate
table".
* src/server/testsuite/lyskomd.0/03.exp: Don't use "Regexps use
collate table".
* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: LIkewise.
Fixed a minor bug that currently had no effects.
* src/server/person.c (create_person_generic): Added a missing
call to mark_conference_as_changed.
Fixed a buffer overrun.
* src/server/aux-items.c (aux_item_trigger_mirror_faq): Fixed a
buffer overflow.
* src/server/testsuite/lyskomd.0/14.exp: Added a few FAQ aux-item
tests.
Code cleanup.
* src/server/aux-item-def-parse.y (aux_item_def_check_trigger):
Added static qualifier.
(aux_item_def_check_validate): Likewise.
* src/include/kom-types.h (Object_type): Removed the almost unused
type PERS_OBJECT_TYPE.
* src/server/aux-items.c (find_linked_aux_item_list): Don't test
for the non-used PERS_OBJECT_TYPE object type.
(mark_linked_object_as_changed): Likewise.
1999-07-08 Per Cederqvist <ceder@lysator.liu.se>
Allow the author of a text to change the recipient type.
* src/server/text.c (add_recipient): Allow the text author to
change the recipient type.
* src/server/testsuite/lyskomd.0/14.exp: New file.
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
lyskomd.0/14.exp.
1999-07-07 Kent Engstrm <kent@artemis.hack.org>
Documentation fixes.
* doc/Protocol-A.texi: corrected some spelling errors;
changed cross-references so that new versions of makeinfo
will stop complaining; added forbid-secret to the list of
conference flags above the table.
1999-07-06 Per Cederqvist <ceder@gratia>
Remove a few performance problems.
* src/server/membership.c (access_perm_helper): New argument:
wanted_access. All callers updated. Avoid calling is_supervisor
or is_member if not needed.
(get_unread_confs): Minor performance improvement: there is no
need to call access_perm if pers_no is the logged-in person.
* src/server/simple-cache.c (copy_file): Use a static buffer
instead of allocating and releasing a buffer each time this
function is called.
Remove dead code.
* src/server/manipulate.h (IMPL): Unused macro removed.
* src/server/dbck-cache.c (IMPL): Unused macro removed.
* src/server/ram-parse.c (fparse_conference_2): Remove dead code
that depends on the long-obsolete DISKERR symbol.
(fparse_conference_0): Likewise.
(fparse_person_0): Likewise.
(fparse_person_2): Likewise.
(fparse_text_stat_2): Likewise.
(fparse_text_stat_0): Likewise.
1999-07-05 Per Cederqvist <ceder@gratia>
Speed up access_perm, is_supervisor and is_strictly_supervisor by
adding a supervisor field to Small_conf, and using it instead of a
call to GET_C_STAT. Remove the Conference argument to the above
three functions and update all callers. A few stray calls to
GET_C_STAT were eliminated in the process.
* src/include/kom-types.h (Small_conf): Added a supervisor field.
* src/server/cache.h (cached_get_conf_supervisor): New function.
* src/server/simple-cache.c (cached_get_conf_supervisor): New
function.
(mark_conference_as_changed): Copy the supervisor to the entry in
small_conf_arr.
(init_small_conf): Set supervisor.
(setup_small_conf): Set supervisor.
* src/server/manipulate.h (access_perm): Removed the victim_c
argument.
(is_supervisor): Removed the conf_c argument.
(is_strictly_supervisor): Removed the conf_c argument.
* src/server/membership.c (access_perm_helper): New name for
former plain_ol_access_perm. Get rid of call to GET_C_STAT by
calling cached_get_conf_type instead. Removed the victim_c
argument from all calls to is_supervisor.
(plain_ol_fast_access_perm): Removed.
(access_perm): Removed the victim_c argument.
(copy_public_confs): Removed the victim_c argument from all calls
to is_supervisor. Removed the victim_c argument from all calls to
access_perm.
(sub_member): Likewise.
(do_get_members): Likewise.
(get_unread_confs): Likewise.
(add_member_common): Likewise, and get rid of a call to GET_C_STAT.
(do_get_membership): Likewise, and get rid of a call to GET_C_STAT.
(set_membership_type): Likewise, and get rid of a call to GET_P_STAT.
* src/server/conference.c (do_create_conf): Call
mark_conf_as_changed before checking that ACTPERS is allowed to
create aux-items in the conference he is creating.
(is_supervisor): Removed the conf_c argument.
(is_strictly_supervisor): Removed the conf_c argument. Use
cached_conf_exists and cached_get_conf_supervisor and eliminate
one expensive call to GET_C_STAT.
(change_name): Removed the victim_c argument from all calls to
access_perm.
(delete_conf): Likewise.
(lookup_name): Likewise.
(lookup_z_name): Likewise.
(do_lookup): Likewise.
(get_conf_stat_old): Likewise.
(get_uconf_stat): Likewise.
(get_conf_stat_older): Likewise.
(set_presentation): Likewise.
(set_etc_motd): Likewise.
(set_conf_type): Likewise.
(set_garb_nice): Likewise.
(set_expire): Likewise.
(set_keep_commented): Likewise.
(modify_conf_info): Likewise.
(set_supervisor): Removed the conf_c argument from all calls to
is_strictly_supervisor and is_supervisor.
(set_permitted_submitters): Likewise.
(set_super_conf): Likewise.
* src/server/admin.c (send_message): Removed the victim_c
argument from all calls to access_perm.
* src/server/person.c (get_person_stat): Removed the victim_c
argument from all calls to access_perm. Eliminate one call to
GET_C_STAT.
(get_person_stat_old): Likewise.
(get_created_texts): Removed the victim_c argument from all calls
to access_perm.
(map_created_texts): Likewise.
(do_query_read_texts): Likewise.
(set_user_area): Likewise.
(set_pers_flags): Likewise.
(set_passwd): Removed the victim_c argument from all calls to
is_supervisor.
* src/server/regex-match.c (lookup_regexp): Removed the victim_c
argument from all calls to access_perm.
* src/server/send-async.c (async_new_name): Removed the victim_c
argument from all calls to access_perm.
* src/server/text.c (submit_to): Removed the victim_c argument
from all calls to access_perm and is_supervisor.
(send_async_sub_recipient): Likewise.
(recp_sent_by): Likewise.
(filter_secret_info): Likewise.
(person_text_read_access): Likewise.
(delete_text): Likewise.
(send_async_add_recipient): Likewise.
(add_recipient): Likewise.
(sub_recipient): Likewise.
(sub_comment): Likewise.
(sub_footnote): Likewise.
(get_map): Likewise.
(local_to_global): Likewise.
* src/server/aux-items.c (aux_item_add_perm): Removed the conf_c
argument from all calls to is_strictly_supervisor and is_supervisor.
(filter_aux_item_list): Likewise.
(check_delete_aux_item_list): Likewise.
* src/server/session.c (login_old): Removed the conf_c argument
from all calls to is_supervisor.
(login): Likewise.
(disconnect): Likewise.
1999-07-03 David Byers <davby@ida.liu.se>
* src/server/handle-malloc-dump.el (trace-run-programs): Fixed
timing problems that caused lyskomd to run before gdb was prepared
for it.
1999-07-04 Per Cederqvist <ceder@gratia>
Prepare for improving access_perm().
* src/server/membership.c (plain_ol_fast_access_perm): Assert that
viewer_conn is never NULL.
(access_perm): Log a warning if called with an unexpected
wanted_access argument.
New convenience check targets.
* src/server/Makefile.am (check-lyskomd): New target.
(check-leaks): New target.
1999-07-02 David Byers <davby@ida.liu.se>
Automatic operation of memory trace analysis:
* src/server/ram-smalloc.c: Mention automatic analysis. Update the
description on how to do it manually (MEMTRACE=file, ATTACH=yes)
* src/server/handle-malloc-dump.el: Added automatic operation in
batch mode. Just run -batch and watch the magic happen.
1999-07-02 David Byers <davby@ida.liu.se>
Some test cases for name lookup:
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added 12 and
13.exp.
* src/server/testsuite/lyskomd.0/13.exp: New file. Some name
lookup tests.
* src/server/testsuite/lyskomd.0/11.exp: Do the right thing when
traced allocations are on.
1999-07-01 David Byers <davby@ida.liu.se>
* src/server/dbck.c (main): Stole code from test-l2g.c for when
traced allocations are on.
Eliminate the need to call build_matching_info all the time:
* src/server/simple-cache.c (rebuild_matching_info_entry): New
function to rebuild a single entry in the matching info table.
(find_matching_info_index): New function.
(cached_change_name): Use rebuild_matching_info_entry insead of
build_matching_info.
* src/libraries/libcommon/parser.c (parse): Loop until we see a
zero conf-no instead of an empty name. Just skip empty names.
* src/server/cache.h (cached_no_of_existing_conferences): Removed
extern declaration of build_matching_info.
Eliminate conf_table:
* src/libraries/libcommon/parser.c: Include kom-types.h so we can
include parser.h.
* src/server/conference.c: Removed extern declaration of
conf_table. Added extern declaration of match_table.
(unique_name): Use match_table, not conf_table.
* src/server/simple-cache.c: (conf_table): Removed.
(build_matching_info): Removed conf_table.
(cached_lookup_name): Use match_table instead of conf_table.
(free_all_cache): Removed conf_table.
* src/libraries/libcommon/parser.h (Matching_info): Added conf_no
field.
1999-06-29 David Byers <davby@ida.liu.se>
* doc/Protocol-A.texi (sub-comment): Changed sub-comment from
obsolete to recommended.
1999-07-01 Per Cederqvist <ceder@lysator.liu.se>
Added the ``wanted_access'' argument to access_perm(), removed
fast_access_perm(), and updated all callers.
* src/server/manipulate.h (access_perm): New parameter:
wanted_access. Never return anything higher than it. All callers
updated.
(fast_access_perm): Removed. All callers changed to use
access_perm instead.
* src/server/membership.c: Pass the new argument wanted_access to
access_perm(). Use access_perm() instead of fast_access_perm().
(access_perm): Proof-of-concept implementation using
plain_ol_access_perm and plain_ol_fast_access_perm. This needs
lots of clever speedups.
* src/server/admin.c: Pass the new argument wanted_access to
access_perm(). Use access_perm() instead of fast_access_perm().
* src/server/conference.c: Likewise.
* src/server/person.c: Likewise.
* src/server/regex-match.c: Likewise.
* src/server/send-async.c: Likewise.
* src/server/text.c: Likewise.
Turn of async messages during shutdown.
* src/server/ramkomd.c (main): Turn of async messages during
shutdown.
* src/server/testsuite/lyskomd.0/00.exp: Dont expect any async
messages during server shutdown.
* src/server/testsuite/lyskomd.0/02.exp: Likewise.
* src/server/testsuite/lyskomd.0/03.exp: Likewise.
* src/server/testsuite/lyskomd.0/08.exp: Likewise.
1999-06-30 Per Cederqvist <ceder@lysator.liu.se>
* README: Talk a little about the config file.
Broken typo fix fixed.
* NEWS: Changed "the near feature" to "a future release".
1999-06-28 Per Cederqvist <ceder@lysator.liu.se>
Fixed a bug that causes created_texts to contain some deleted
texts.
* src/server/text.c (do_delete_text): Don't forget to call
mark_person_as_changed -- the authors' list of created texts must
be updated.
* src/server/testsuite/lyskomd.0/12.exp: Detect the above bug.
* src/server/testsuite/config/unix.exp (dbck_run): New proc.
(lyskomd_death): Call dbck_run to check the database after each
shutdown.
1999-06-27 Per Cederqvist <ceder@lysator.liu.se>
* Release 2.0.0.
Port to places such as AIX 4.2 where char is an unsigned type.
* src/server/dbck.c (main): Use an int to store the return value
from getopt_long.
* src/server/dbck-cache.c (init_cache): Use an int to store the
return value from getc.
Port the test suite to OSF 3.0.
* src/server/testsuite/config/unix.exp (stty_init): Quote the ^
character. Some shells interpret it as a pipe.
* README: Mention that Python is needed by the test suite.
Specify more of the behavior of get-unread-confs.
* doc/Protocol-A.texi (get-unread-confs): Specify the order of the
returned conference numbers.
1999-06-26 Per Cederqvist <ceder@lysator.liu.se>
Port the makefiles and test suite to FreeBSD.
* src/server/testsuite/Makefile.am (RM): Set it.
* src/server/Makefile.am (RM): Set it.
* doc/Makefile.am (RM): Set it.
* src/server/testsuite/config/unix.exp (unanchored_expect): Don't
leave an unparsed space behind when an unexpected output appears
before a prompt.
* src/server/testsuite/lyskomd.0/01.exp: Don't be confused about
the newline emitted in the collate table.
* src/server/testsuite/lyskomd.0/03.exp: Likewise.
* src/server/testsuite/config/unix.exp (stty_init): Remove
"-ocrnl" which isn't portable to FreeBSD.
Port the test suite to HP/UX.
* src/server/testsuite/config/unix.exp (stty_init): Add "-isig
erase ^- kill ^- werase ^-".
Port the test suite to non-gcc compilers.
* src/server/testsuite/test-l2g.c (MAXMAPS): Use #define instead
of "const int" so that the symbol can portably be used as an array
size.
(LINSIZE): Likewise.
(ARGS): Likewise.
1999-06-26 David Byers <davby@ida.liu.se>
* src/include/kom-types.h (Membership_type): Changed all fields
from Bool to unsigned int.
* src/server/aux-items.c: Removed support for precompiled aux
items. It was not currently used, and caused compilation errors
under HP/UX.
1999-06-26 Per Cederqvist <ceder@lysator.liu.se>
Fix coding error.
* src/server/aux-items.c (aux_item_add_perm): Don't use
find_aux_item_definition to set def if def is already set.
Remove lint found by HP/UX c89.
* src/server/ram-parse.c (fparse_aux_item_link): Missing
semicolon added.
* src/server/ram-output.c (foutput_aux_item_link): Missing
semicolon added.
(foutput_mark_list): Declare the function static in all
declarations, not only some.
* src/server/aux-items.h (aux_item_validators): This is static,
so remove it form the header file.
(aux_item_triggers): Likewise.
* src/server/aux-items.c (mark_linked_object_as_changed): Missing
semicolon added.
* src/server/session.c (create_oldstyle_username): Remove needless
casts.
(login_old): Likewise.
(login): Likewise.
* HACKING: We use bison 1.27. 1.25 had problems with alloca under
HP/UX.
1999-06-26 David Byers <davby@ida.liu.se>
Send new-membership only for new memberships.
* doc/Protocol-A.texi (async-new-membership): Remove
documentation that says this message is sent when a membership is
reprioritized.
* src/server/testsuite/lyskomd.0/06.exp (shutdown_06): Don't
expect new-membership when membership is changed.
* src/server/membership.c (add_member_common): Only send
new-membership for new memberships, not changed memberships.
1999-06-25 Per Cederqvist <ceder@lysator.liu.se>
"make check" failed if the source tree was read-only.
* src/server/testsuite/config/unix.exp (lyskomd_start): Use chmod
to make sure that the database is writable even if it is copied
from a read-only tree.
"make -j install" could fail.
* run-support/Makefile.am (install-data-local): Depend on installdirs.
* db-crypt/db/Makefile.am (install-data-local): Depend on installdirs.
Port to SunOS 4.1.1.
* src/server/aux-item-def-scan.l: Include <sys/types.h>.
* configure.in: Check for sig_atomic_t.
* acconfig.h: Added sig_atomic_t.
Release administrativa.
* scripts/lyskomd-copyrights: Don't attempt to update copyright
notices in TeX temporary files.
Documentation fixes.
* TODO: No showstoppers left.
* NEWS: Several minor modifications.
* README: Spelling errors fixed.
* doc/Protocol-A.texi (mark-text-old): Spelling error fixed.
(get-text-stat-old): Talk about bcc-recpt.
(Protocol Requests): Warn that obsolete calls perform
compatibility magic. Include the number of the protocol request
in the printed heading of the corresponding section.
(set-pers-flags): Fix sectioning error.
(get-unread-confs): Clarify that passive memberships are never
returned.
Performance fix.
* src/server/internal-connections.c: Turn off defensive checks in
this file. They cost too much CPU.
Release administrativa.
* doc/Protocol-A.texi (Document Revision History): Update the
release date for revision 10.0.
* NEWS: Sort the news.
The test suite failed when compiled outside the source directory.
* src/server/testsuite/leaks.0/leaks10.exp: startup_leaks wants a
relative path to the aux-items.conf file.
* src/server/testsuite/leaks.0/leaks99.exp: Likewise.
1999-06-24 Per Cederqvist <ceder@lysator.liu.se>
Fix messages created by dbck.
* src/server/dbck.c (garb_text_file): Don't log the message
"Ready."; the caller also logs it.
Add trailing newline in format string to kom_log in the following
functions:
* src/server/regex-match.c (lookup_regexp):
* src/server/ramkomd.c (sighandler_usr2):
* src/server/prot-a-parse.c (prot_a_parse_num_list):
(prot_a_parse_string):
(prot_a_parse_aux_item_list):
(prot_a_parse_misc_info_list):
* src/server/person.c (do_unmark_text):
(create_person_generic):
* src/server/membership.c (mark_as_read):
(set_membership_type):
* src/server/dbck.c (main):
* src/server/dbck-cache.c (cached_flush_text):
* src/server/connections.c (call_function):
(toploop):
* src/server/conference.c (do_create_conf):
* src/server/aux-items.c (find_linked_aux_item_list):
(aux_item_validate):
1999-06-24 David Byers <davby@ida.liu.se>
* src/server/aux-items.c (aux_item_validate): Do not print the
regexp that failed to compile since it is gone by this time.
1999-06-23 Per Cederqvist <ceder@lysator.liu.se>
The default language is now selectable at configure time.
* README: Mention --with-language=sv.
* configure.in: Handle --with-language=sv.
* db-crypt/db/Makefile.am (LANGUAGE_SUFFIX): New variable.
(EXTRA_DIST): Added lyskomd-data-en.
(install-data-local): Install lyskomd-data-en or lyskomd-data,
depending on LANGUAGE_SUFFIX.
* db-crypt/db/lyskomd-data-en: New file.
Remove the unused file tmp-limits.h.
* src/server/Makefile.am (lyskomd_SOURCES): Removed tmp-limits.h.
* src/server/tmp-limits.h: Unused file removed.
* NEWS: More items added. This should now be fairly complete, but
it may need restructuring.
1999-06-23 David Byers <davby@ida.liu.se>
* src/server/dbck.c (init_person_scratch): Initialize person
scratchpad entries to NULL.
1999-06-21 Per Cederqvist <ceder@lysator.liu.se>
Fix the test suite.
* src/server/testsuite/lyskomd.0/11.exp: Updated to match the log
messages currently sent by lockdb.c.
Don't send too many async-logout messages.
* src/server/connections.c (logout_client): Back out the change
made 1999-01-16; no longer send async-logout if the session is not
logged in.
* src/server/testsuite/lyskomd.0/07.exp: Don't expect async-logout
when sessions are disconnected.
* doc/Protocol-A.texi (async-logout): This message is not
necessarily sent when a session disconnects and nobody is logged
in.
1999-06-20 Per Cederqvist <ceder@lysator.liu.se>
Release fixes.
* HACKING: Added a missing call to ./configure.
* NEWS: Updated the release date.
Improve log messages regarding database locking.
* src/server/lockdb.c (lock_db): Clarify log messages.
* src/server/ramkomd.c (initialize): Write an "exiting" message
when the lock cannot be obtained.
Fix parameters "Jubel" and "Ident-authentication".
* src/server/server-config.c (parameters): Removed duplicate
"Ident-authentication".
* src/server/standalone.c (register_jubel): Don't call abort --
this gets called from dbck if the config file contains a Jubel.
1999-06-19 Per Cederqvist <ceder@lysator.liu.se>
Save 5 items (configurable) per call.
* src/server/param.h (struct kom_par): Added saved_items_per_call.
* src/server/disk-end-of-atomic.c (end_of_atomic): Handle
param.saved_items_per_call.
* doc/lyskomd.texi (Parameters): Documented "Saved items per call".
* src/server/server-config.c (parameters): Added "Saved items per
call".
(read_configuration): Check that param.saved_items_per_call is at
least 1.
1999-06-14 Per Cederqvist <ceder@cendio.se>
Track name change of 556450-2507.
* doc/lyskomd.texi (Overview): Signum Support has a new name:
Cendio Systems.
1999-06-13 Per Cederqvist <ceder@lysator.liu.se>
Allow at most 128 aux_items of at most 16384 bytes each to be
added at a single time.
* src/server/server-config.c (parameters): Added "Max aux_item
length". Changed default of "Max aux_items added per call" to
128.
* src/server/prot-a-parse.c (prot_a_parse_aux_item): Use
param.aux_len instead fo param.text_len as the limit for the
aux-item size.
* src/server/param.h (struct kom_par): Added aux_len.
* doc/lyskomd.texi (Parameters): Document "Max aux_items added per
call". Lowered the default from "Max aux_items added per call".
1999-06-13 David Byers <davby@ida.liu.se>
* src/server/testsuite/lyskomd.0/03.exp: Fix test cases for change
in aux_item_link_items below.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Fix test cases
for change in aux_item_link_items below.
* src/server/aux-items.c (aux_item_link_items): Creator of linked
aux item is now the creator of the source item. This gives the
creator of the source item power over the linked item.
1999-06-11 David Byers <davby@ida.liu.se>
* src/server/aux-items.c: Cleared up comment for
undelete_aux_item_list.
1999-06-05 David Byers <davby@ida.liu.se>
* src/server/text-garb.c: Always include setjmp.h
1999-06-05 Per Cederqvist <ceder@lysator.liu.se>
Test lock files.
* src/server/testsuite/lyskomd.0/11.exp: New file.
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
lyskomd.0/11.exp.
* src/server/Makefile.am (all-recursive check-recursive): Depend
on dbck.
* src/server/lockdb.c (lock_db): Log a message when a stale lock
is removed.
* src/server/dbck.c (main): Don't die until a character
has been read if -d is used.
* src/server/ramkomd.c (initialize): Don't die until a character
has been read if -d is used.
text-garb.c failed to compile unless --with-debug-calls was used.
* src/server/text-garb.c: Always include <setjmp.h>, since it is
needed by connections.h.
strdup() is no longer used, so a replacement function is not
needed.
* configure.in: Commented out AC_REPLACE_FUNCS(strdup).
* src/libraries/libansi/Makefile.am (EXTRA_DIST): Added strdup.c.
1999-06-05 David Byers <davby@ida.liu.se>
* regexp-match-cov.exp: New test case.
* src/server/regex-match.c (lookup_regexp): Don't use strdup to
copy the collate table.
* src/server/text.c (modify_text_info): Check for read access on
text.
* src/server/conference.c (modify_conf_info): Check for secret
confs.
1999-05-31 David Byers <davby@ida.liu.se>
* src/server/text.c (add_comment): Moved access checks to avoid
leaking information.
(add_footnote): Same here.
* src/server/membership.c (set_membership_type): Move permission
checks to avoid leaking information.
* doc/lyskomd.texi (Adding a New Protocol Request): Added notes on
CHK_CONNECTION, CHK_LOGIN and how to avoid leaking secret
information.
* src/server/text.c (add_recipient): Moved GET_X_STAT and
permission checks around to avoid leaking secret information.
* src/server/text-garb.c (start_garb): Same here.
* src/server/debug.c (get_memory_info): Call CHK_CONNECTION.
(backdate_text): Same here.
* src/server/aux-items.c (query_predefined_aux_items): Call
CHK_CONNECTION.
* src/server/admin.c (get_info_old): Call CHK_CONNECTION.
(get_version_info): Same here.
(set_info): Same here.
(set_motd_of_lyskom): Same here.
(sync_kom): Same here.
* src/server/session.c (get_time): Call CHK_CONNECTION.
(who_is_on_old): Same here.
* src/server/text.c (local_to_global): Moved CHK_CONNECTION to
very start of function.
(get_last_text): Call CHK_CONNECTION.
* src/server/person.c (set_priv_bits): Call CHK_CONNECTION.
* src/server/session.c (get_client_version): Call CHK_CONNECTION.
(get_client_name): Same here.
(get_session_info): Same here.
(get_session_info_ident): Same here.
(get_static_session_info): Same here.
1999-06-04 Per Cederqvist <ceder@lysator.liu.se>
Clean up file inclusion. Avoid including files from .h files.
Avoid underscores in dubious places.
* src/server/admin.c: Don't include <stdarg.h>.
* src/server/conf-file.c: Likewise.
* src/server/conference.c: Likewise.
* src/server/connections.c: Likewise.
* src/server/dbck-cache.c: Likewise.
* src/server/internal-connections.c: Likewise.
* src/server/membership.c: Likewise.
* src/server/memory.c: Likewise.
* src/server/person.c: Likewise.
* src/server/prot-a-parse.c: Likewise.
* src/server/ram-output.c: Likewise.
* src/server/ram-parse.c: Likewise.
* src/server/ramkomd.c: Likewise.
* src/server/regex-match.c: Likewise.
* src/server/rfc931.c: Likewise.
* src/server/send-async.c: Likewise.
* src/server/server-config.c: Likewise.
* src/server/session.c: Likewise.
* src/server/simple-cache.c: Likewise.
* src/server/text-garb.c: Likewise.
* src/server/text.c: Likewise.
* src/server/testsuite/test-l2g.c: Include "kom-types.h".
* src/server/local-to-global.h: Don't include "kom-types.h".
* src/server/log.h: Don't include <stdarg.h>. Don't declare
kom_logv. Don't use leading underscores or double underscores in
symbols we define.
* src/server/log.c (kom_logv): Now static.
* src/include/compiler.h: Don't use leading underscores or double
underscores in symbols we define.
* src/include/kom-errno.h: Likewise.
* src/include/kom-types.h: Likewise.
* src/include/misc-types.h: Likewise.
* src/include/services.h: Likewise.
Distribute new test suite files.
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
lyskomd.0/09.exp and lyskomd.0/10.exp.
Some systems lack strdup.
* configure.in: Added AC_REPLACE_FUNCS(strdup).
* src/libraries/libansi/strdup.c (strdup): Replacement implementation.
1999-05-31 Per Cederqvist <ceder@gratia>
Fixed typo in the test suite.
* src/server/testsuite/lyskomd.0/09.exp: Don't mix the timestamps
for texts 5 and 6.
1999-05-31 David Byers <davby@ida.liu.se>
* src/server/server-config.c: Removed duplicate regexps use
collate table.
* src/server/manipulate.h (CHK_LOGIN): Check for NULL
active_connection.
(ENA): Survive a NULL active_connection.
(HAVE_PRIV): Take a Person argument.
1999-05-30 David Byers <davby@ida.liu.se>
* src/server/text-garb.c (garb_text): Reset deleted_texts after
sending the debug message.
1999-05-30 David Byers <davby@ida.liu.se>
* src/server/testsuite/lyskomd.0/09.exp (1015): Data sent to
client 2 contained secret recipient. Fixed.
* src/server/testsuite/lyskomd.0/05.exp: Fixed added_by field in
Membership and Member
* src/server/testsuite/lyskomd.0/03.exp: (1349,1350, 1351, 2001,
2006): Fixed added_by field in Membership and Member
* src/server/testsuite/lyskomd.0/01.exp: (1116): Fixed added_by
field in Membership
* src/server/regex-match.c (lookup_regexp): Copy the collate table
before putting it into the pattern buffer.
* src/server/testsuite/lyskomd.0/00.exp (1038): Person 6 added
himself to his letterbox.
* src/server/membership.c (do_add_member): Take added_by as an
argument.
(add_member_common): Call do_add_member with explicit added_by.
* src/server/person.c (create_person_generic): The person adding
the mailbox membership is the same as the creator of the person.
Fixed problems related to permission checking
* src/server/membership.c (fast_access_perm): Take a connection
argument instead of a person and pers_stat combo.
(access_perm): Same here.
(copy_public_confs): Same here.
* src/server/text.c (ok_to_create_next_text): Same here.
* src/server/regex-match.c (lookup_regexp): Test for
param.regex_use_collate_table was inverted.
(lookup_regexp): Added connection argument.
* src/server/text.c (filter_secret_info): Take a connection
argument instead of viewer and viewer_p
(send_async_deleted_text): Call filter_secret_info with connection
argument.
(get_text_stat_old): Same here.
(get_text_stat): Same here.
(send_async_new_text_old): Same here.
(send_async_new_text): Same here.
(person_text_read_access): Check that active_connection is set
before attempting to use it.
(text_read_access): Take a connection as an argument.
* src/server/conference.c (get_conf_stat): Call
filter_aux_item_list with active_connection instead of ACTPERS and
ACT_P.
* src/server/admin.c (get_info): Call filter_aux_item_list with
active_connection instead of ACTPERS and ACT_P.
* src/server/session.c (leave_conf): New parameter for connection
to remove dependency on active_connection.
* src/server/internal-connections.c (get_conn_by_number):
Defensive check on active_connection. Restart server if
active_connection is unset and no session number is specified
since callers of this function expect to get something sensible
out of it.
* src/server/manipulate.h (CHK_CONNECTION): New macro. Call this
at the head of every RPC function.
* src/server/admin.c (shutdown_kom): Signal internal error if we
don't have an active connection.
1999-05-30 Per Cederqvist <ceder@lysator.liu.se>
Improve the test suite.
* src/server/testsuite/lyskomd.0/09.exp: Added async messages sent
by the garb when it deletes text 2, 4 and 6. This is untested and
may break.
1999-05-30 Per Cederqvist <ceder@gratia>
Don't send async-sub-recipient messages when texts are deleted.
* src/server/text.c (perform_subtraction): New static function,
extracted from do_sub_recpt. Only send async-sub-recipient if
the new argument want_async is true.
(do_sub_recpt): Code simplified by creation of
perform_subtraction(). New argument: want_async (see above).
(do_delete_text): Tell do_sub_recpt that we don't want any
async-sub-recipient messages.
(sub_recipient): Tell do_sub_recpt to send async-sub-recipient
messages.
* src/server/testsuite/lyskomd.0/09.exp: async-sub-recipient
messages are no longer erroneously sent. Comment out the code
that causes a core dump.
* src/server/testsuite/lyskomd.0/send-async-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/06.exp: async-sub-recipient
messages are no longer erroneously sent.
Added a test case that corresponds to the bug found 1999-05-24.
* src/server/testsuite/lyskomd.0/09.exp: This test now causes
lyskomd to dump core while garbing texts.
Async-sub-recipient was not always sent when it should be, and it
contained bogus data.
* src/server/testsuite/lyskomd.0/10.exp: Check async-sub-recipient.
* src/server/text.c (do_sub_recpt): Send async-sub-recipient
immediately before removing the recipient, so that we know where
to send it. As a side effect the type is now read from the proper
misc-info group.
(send_async_deleted_text): Use #if 0 instead of comments to
comment out code.
* src/server/testsuite/lyskomd.0/send-async-cov.exp: Handle
async-sub-recipient messages that are (probably erroneously) sent.
* src/server/testsuite/lyskomd.0/06.exp: Handle
async-sub-recipient messages that are (probably erroneously) sent.
New debug call: start-garb. New debug async: garb-ended.
* src/server/testsuite/lyskomd.0/09.exp: New tests.
* src/server/text-garb.c (last_checked): Moved to file-level
scope, so that start_garb can access it.
(last_start): Likewise.
(garb_text): Send async-garb-ended when the garb ends, but only if
DEBUG_CALLS is defined.
(start_garb): New function, only present when DEBUG_CALLS is
defined.
* src/server/session.c (accept_async): Handle ay_garb_ended if
DEBUG_CALLS is defined.
* src/server/send-async.c (async_garb_ended): New
function, only present when DEBUG_CALLS is defined.
* src/server/send-async.h: Likewise.
* src/server/prot-a-send-async.c (prot_a_async_garb_ended): New
function, only present when DEBUG_CALLS is defined.
* src/server/prot-a-send-async.h: Likewise.
* src/server/fncdef.txt: New debug call: start_garb.
* src/server/async.h (Async): New debug async: ay_garb_ended.
* src/include/services.h (start_garb): New debug call.
Cut-n-paste error in Protocol-A.texi fixed.
* doc/Protocol-A.texi (async-sub-recipient): The explanation
talked about "the new recipient".
1999-05-24 Per Cederqvist <ceder@lysator.liu.se>
Removed a newline in the log.
* src/server/simple-cache.c (init_cache): Removed an extra newline
in the log output.
Don't lose data when converting the database.
* src/server/ram-output.c (foutput_membership): Call
foutput_membership_0 for output format 1.
(foutput_membership_list): Call foutput_membership_list_0 for
output format 1.
* src/server/ram-output.c (foutput_text_list): Don't get stuck in
an eternal loop.
* src/server/dbck-cache.c (cache_sync_all): Output format 2 is
known.
* src/server/ram-parse.c (fparse_text_list): Set
first_appendable_key when reading a Local_to_global from an
old-style empty text-list.
* src/server/local-to-global.c (l2g_set_first_appendable_key): New
function.
* src/server/local-to-global.h: Likewise.
1999-05-24 David Byers <davby@ida.liu.se>
* src/server/ram-parse.c (fparse_member_list): Initialize member
structure before parsing it.
* src/server/memory.c (init_member): New function.
1999-05-24 Per Cederqvist <ceder@lysator.liu.se>
Update the distributed config file.
* run-support/config: Removed the "Mux port" line.
Update the help message of dbck.
* src/server/dbck.c (give_help): File format 2 is supported.
Port to Solaris.
* src/server/lockdb.c: Include <netdb.h>.
Fix the anti-timetravel change.
* src/server/dbck-cache.c (sync_output_header): Output the
supplied state instead of hardcoding it to DIRTY. Added a missing
const.
Added copyright header to the following files.
* src/server/testsuite/config/leaks.exp:
* src/server/testsuite/config/prot-a.exp:
* src/server/testsuite/l2g.0/00.exp:
* src/server/testsuite/l2g.0/01.exp:
* src/server/testsuite/l2g.0/02.exp:
* src/server/testsuite/l2g.0/03.exp:
* src/server/testsuite/l2g.0/04.exp:
* src/server/testsuite/l2g.0/05.exp:
* src/server/testsuite/l2g.0/06.exp:
* src/server/testsuite/l2g.0/07.exp:
* src/server/testsuite/l2g.0/08.exp:
* src/server/testsuite/l2g.0/09.exp:
* src/server/testsuite/l2g.0/10.exp:
* src/server/testsuite/l2g.0/11.exp:
* src/server/testsuite/leaks.0/leaks00.exp:
* src/server/testsuite/leaks.0/leaks01.exp:
* src/server/testsuite/leaks.0/leaks02.exp:
* src/server/testsuite/leaks.0/leaks03.exp:
* src/server/testsuite/leaks.0/leaks04.exp:
* src/server/testsuite/leaks.0/leaks05.exp:
* src/server/testsuite/leaks.0/leaks06.exp:
* src/server/testsuite/leaks.0/leaks07.exp:
* src/server/testsuite/leaks.0/leaks08.exp:
* src/server/testsuite/leaks.0/leaks09.exp:
* src/server/testsuite/leaks.0/leaks10.exp:
* src/server/testsuite/leaks.0/leaks99.exp:
* src/server/testsuite/lyskomd.0/00.exp:
* src/server/testsuite/lyskomd.0/01.exp:
* src/server/testsuite/lyskomd.0/02.exp:
* src/server/testsuite/lyskomd.0/03.exp:
* src/server/testsuite/lyskomd.0/04.exp:
* src/server/testsuite/lyskomd.0/05.exp:
* src/server/testsuite/lyskomd.0/06.exp:
* src/server/testsuite/lyskomd.0/07.exp:
* src/server/testsuite/lyskomd.0/08.exp:
* src/server/testsuite/lyskomd.0/admin-cov.exp:
* src/server/testsuite/lyskomd.0/aux-items-cov.exp:
* src/server/testsuite/lyskomd.0/aux-items.conf:
* src/server/testsuite/lyskomd.0/aux-items.cov:
* src/server/testsuite/lyskomd.0/broken-aux-items.conf:
* src/server/testsuite/lyskomd.0/cache-node-cov.exp:
* src/server/testsuite/lyskomd.0/conf-file-cov.exp:
* src/server/testsuite/lyskomd.0/conference-cov.exp:
* src/server/testsuite/lyskomd.0/connections-cov.exp:
* src/server/testsuite/lyskomd.0/disk-end-of-atomic-cov.exp:
* src/server/testsuite/lyskomd.0/membership-cov.exp:
* src/server/testsuite/lyskomd.0/null.exp:
* src/server/testsuite/lyskomd.0/person-cov.exp:
* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp:
* src/server/testsuite/lyskomd.0/prot-a-send-async-cov.exp:
* src/server/testsuite/lyskomd.0/send-async-cov.exp:
* src/server/testsuite/lyskomd.0/session-cov.exp:
* src/server/testsuite/lyskomd.0/text-cov.exp:
* src/server/testsuite/tcpconnect.py:
* src/server/testsuite/test-l2g.c:
Release administrativa.
* NEWS: Set the release date to 1999-05-31.
* configure.in: Set version number to 2.0.0.
* versions (SERVER-VERSION): 2.0.0.
(SERVER-COMPAT-VERSION): 20000.
Cleanup.
* doc/prot-A-english.txt: File removed.
* src/server/To-do: File removed.
* src/server/Makefile.am (EXTRA_DIST): Removed To-do.
Update copyright notices.
* <all files>: update the year in the copyright notice.
* scripts/update-copyright: Handle yearspans.
* scripts/lyskomd-copyrights: Updated the list of files to ignore.
Documentation fixes.
* doc/Protocol-A.texi (get-collate-table): Document what short
collate tables means.
* doc/lyskomd.texi (Administration): komrunning now takes the
arguments "start" and "stop".
* HACKING: Mention the versions of bison and flex.
* README: Updated for the release.
Work around automake bugs.
* src/server/testsuite/Makefile.am (noinst_DATA): Removed the
"nodist_" prefix, which was apparently broken.
* doc/Makefile.am (dist_noinst_DATA): Removed to work around an
automake bug. For now, the check for tabs is not performed
automatically.
1999-05-23 Per Cederqvist <ceder@lysator.liu.se>
Documentation fixes.
* doc/Protocol-A.texi (Top): Updated for release.
(What do I have unread): @code{@xref{}} and @code{@ref{}} don't
work, so don't use the construct.
--with-traced-allocations broke the test suite.
* src/server/testsuite/config/unix.exp (l2g_start): Handle
TRACED_ALLOCATIONS.
* src/server/testsuite/test-l2g.c (main): Handle
TRACED_ALLOCATIONS.
* src/server/ram-smalloc.c: Comment updated.
Update the protocol revision.
* src/server/fncdef.txt: Whitespace fix.
* doc/Protocol-A.texi: Removed all up, next and prev pointers
once again.
(Document Revision History): Specify
tomorrow as release date.
(Protocol Version History): Update the entry for protocol version
10. The status of 59=create-anonymous-text-old was changed to
Obsolete in protocol version 10, not version 9.
(Protocol Requests): Mark experimental calls with an "e".
(add-member-old): Typo fixed.
(unmark-text): This was introduced in protocol version 6, not 4.
(set-expire): Change status to Experimental.
(set-keep-commented): Change status to Experimental.
(set-pers-flags): Fix markup error.
1999-05-22 David Byers <davby@ida.liu.se>
Timestamp the saved database and refuse to start if the server
travels backwards through time:
* doc/lyskomd.texi (Version 2): Documented new header format.
* db-crypt/db/lyskomd-data: Added timestamp
* src/server/dbck-cache.c (cache_sync_all): Handle output format 2.
(sync_output_header): New function.
(cache_sync_all): Use sync_output_header to output file header.
* src/server/simple-cache.c (pre_sync): Use sync_output_header.
(sync_output_header): New function outputs file header and
timestamp.
(save_one_text): Use it.
(init_cache): Check the timestamp on the database before loading.
* src/server/connections.c (toploop): Log a warning if time starts
moving backwards.
Documentation fixes:
* doc/Protocol-A.texi (get-membership): Fixed FIXME.
* doc/lyskomd.texi: Fixed misplaced @code and @i markup.
* doc/Protocol-A.texi: Fixed misplaced @code and @samp markup.
1999-05-23 Per Cederqvist <ceder@lysator.liu.se>
Port to automake 1.4a.
* src/server/testsuite/Makefile.am (check_PROGRAMS): Don't bother
building test-l2g until "make check".
(nodist_noinst_DATA): Dont' distribute site.exp and .gdbinit.
1999-05-23 Per Cederqvist <ceder@gratia>
Disallow tabs in lyskomd.texi.
* doc/Makefile.am (dist_noinst_DATA): New target, containing
Protocol-A.notab and lyskomd.notab.
(MOSTLYCLEANFILES): Added Protocol-A.notab and lyskomd.notab.
(protocol-a.info): Remove the tab-checking code.
(SUFFIXES): Added .texi .notab.
(.texi.notab): New rule, that checks that no tabs exist in Texinfo
files.
Get rid of the file local-to-global.doc. Various fixes to
lyskomd.texi.
* doc/Makefile.am (EXTRA_DIST): Remove local-to-global.doc.
* doc/local-to-global.doc: File removed; contents moved into
lyskomd.texi.
* doc/lyskomd.texi: Removed all up, next and prev pointers
once again. Untabify. Remove trailing whitespace from lines.
(Overview): Added a missing "General" to the name of the license.
Don't talk about my private future plans.
(Installation): Refer to README.
(DBCK Bugs): don't say that dbck doesn't lock the database; it does.
(Function Templates for prot-a-send-async.c): Improve the markup.
(Configuration Options): Mention --with-traced-allocations.
(local-to-global): New node. Not yet translated.
1999-05-22 Per Cederqvist <ceder@lysator.liu.se>
Translated and updated the release instructions.
* HACKING: New file. This contains an updated translation of
SERVER-RELEASE and information about the versions of various tools
that was used to create the release.
* SERVER-RELEASE: Removed.
* Makefile.am (EXTRA_DIST): Added HACKING. Removed
SERVER-RELEASE.
1999-05-21 Per Cederqvist <ceder@lysator.liu.se>
"make dist" fixes.
* src/server/Makefile.am (lyskomd_SOURCES): Added server-time.h
* src/server/testsuite/Makefile.am (EXTRA_DIST): Changed
leaks.0/no-aux-items.exp and leaks.0/lots-aux-items.exp to
leaks.0/no-aux-items.conf and leaks.0/lots-aux-items.conf.
* doc/Makefile.am (EXTRA_DIST): Removed ADMINISTRATION and
misc_items.
Get rid of the very obsolete SERVER and CLIENT macros.
* src/server/testsuite/Makefile.am (INCLUDES): Removed -DSERVER.
* src/server/Makefile.am (INCLUDES): Removed -DSERVER.
* src/libraries/libcommon/parser.c: Don't use SERVER.
* src/libraries/libcommon/Makefile.am (INCLUDES): Removed -DSERVER.
* src/include/services.h: Don't use SERVER or CLIENT. Fix some
indentation.
(KOM_): Macro removed. All users updated.
* src/include/kom-types.h: Don't use SERVER or CLIENT. Fix some
indentation.
* configure.in: Don't define SERVER.
* acconfig.h (PROTOTYPES): Removed.
(SERVER): Removed.
(VERSION): Removed.
Remove all gcov files in "make mostlyclean".
* src/server/testsuite/Makefile.am (MOSTLYCLEANFILES): Added "*.da",
"*.bb", "*.gcov" and "*.bbg".
* src/libraries/libmisc/Makefile.am: Likewise.
* src/libraries/libcommon/Makefile.am: Likewise.
1999-05-21 David Byers <davby@ida.liu.se>
* doc/lyskomd.texi (Adding New Input Types): Document the fact
that you have to free data in prot_a_destruct as well.
* src/server/prot-a.c (prot_a_destruct): Free num_lists in the
client structure.
1999-05-21 Per Cederqvist <ceder@paragon.signum.se>
Don't lock the database when dbck is running in read-only mode.
* src/server/dbck.c (iflag): Now static.
(rflag): Now static.
(gflag): Now static.
(sflag): Now static.
(force_output): Now static.
(unset_change_name_is_error): Now static.
(dump_text_numbers): Now static.
(main): Only lock the database when dbck might want to change it.
Added a missing break statement. Mark the database as modified if
any of --pres-pres-conf, --conf-pres-conf, --motd-conf,
--motd-of-kom or --kom-news-conf is used.
1999-05-21 David Byers <davby@ida.liu.se>
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added null.exp
* doc/lyskomd.texi: Merged lyskomdb.texi into this document.
* src/server/server-config.c: Unassign the lockfile name.
* doc/Makefile.am (info_TEXINFOS): Removed deleted files.
(EXTRA_DIST): Removed deleted files from EXTRA_DIST.
* src/server/conf-file.c (unassign_string): New function.
* src/server/conf-file.h (parameter): Added a free function.
* src/server/simple-cache.c (free_all_cache): Free the
small_conf_arr.
* src/server/ramkomd.c (dump_exit_statistics): Moved remaining
frees from main to here.
1999-05-20 David Byers <davby@ida.liu.se>
* src/server/testsuite/config/unix.exp: You can now supply
MEMTRACE, ATTACH and EFENCE algorithms on the runtest command
line.
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added new leak
tests to EXTRA_DIST.
Eliminated memory leaks in aux-item definition parser
* src/server/aux-items.c (free_aux_item_definitions): Free each
individual aux item definition. Another memory leak down the
drain.
* src/server/aux-item-def-parse.y: Free the string of an ID
parameter when we see one. Another memory leak bites the dust.
* src/server/aux-items.c (aux_item_definition_cache_regexp): Plug
a really minor (constant size) memory leak.
* src/server/aux-item-def-parse.y: Use string_free to free stuff
allocated with s_crea_c_str.
* src/server/aux-items.c (aux_item_trigger_link_item): Use
string_free to free string allocated with s_crea_c_str.
(free_aux_item_definitions): Same here.
1999-05-19 David Byers <davby@ida.liu.se>
* src/server/prot-a-parse.c (prot_a_parse_aux_item_list): Clear
the dummy aux item after parsing it. Memory leak plugged.
* src/server/memory.c (clear_aux_item): New function.
(free_aux_item_list): Use it.
* src/server/prot-a-parse.c (prot_a_parse_num_list): Handle
truncation so protocol errors during truncation will not break the
server.
(prot_a_hunt_nl): Same here.
(prot_a_parse_aux_item_list): Same here.
* src/server/prot-a.c (prot_a_init): Initialize
array_parse_parsed_length
* src/server/internal-connections.c (init_connection): Initialize
array_parse_parsed_length
* src/server/connections.c (free_parsed): Initialize
array_parse_parsed_length.
* src/server/connections.h (Connection): Added
array_parse_parsed_length
* src/server/fncdef.txt: Truncate strings in set_client_version to
client_data_len.
* src/server/ramkomd.c (main): Free aux-item definitions on exit.
* src/server/aux-items.c (free_aux_item_definitions): New function
to free all data associated with aux-item defs.
* src/server/ramkomd.c (main): Free aux-item definition.
1999-05-18 David Byers <davby@ida.liu.se>
* src/server/prot-a-parse.c (prot_a_parse_aux_item_flags): Handle
variable-length bitfields.
* src/server/memory.c (init_aux_item_flags): New function.
* src/server/prot-a-parse.c (prot_a_parse_priv_bits): Handle
variable-length bitfields.
(prot_a_parse_membership_type): Same here.
(prot_a_parse_conf_type): Same here.
* src/server/memory.c (init_membership_type): New function.
* doc/Protocol-A.texi (set-client-version): Added list of known
clients.
* ChangeLog.1: Inserted doc/LOGG
* doc/LOGG: Added to ChangeLog.1
* src/server/conference.c (set_supervisor): Use
is_strictly_supervisor instead of is_supervisor.
1999-05-21 Per Cederqvist <ceder@gratia>
Lock the database file with an explicit lock file.
* src/server/dbck.c (main): Lock and unlock the database.
* src/server/ramkomd.c (init_data_base): Log the name of the lock
file.
(initialize): Lock the database before opening it.
(main): Unlock the database.
* src/server/server-config.c (parameters): Added "Lock file".
(read_configuration): Handle param.lockfile_name.
* src/server/param.h (struct kom_par): Added lockfile_name.
* src/server/Makefile.am (lyskomd_SOURCES): Added lockdb.h and
lockdb.c.
(DBCK): Likewise.
* src/server/lockdb.c, src/server/lockdb.h: New files.
(lock_db): New function.
(unlock_db): New function.
* doc/lyskomd.texi (Parameters): Document "Lock file:".
1999-05-20 Per Cederqvist <ceder@signum.se>
Clean up the framework for hunting memory leaks.
* src/server/ram-smalloc.c: Document --with-traced-allocations.
* src/server/realloc.gdb: File removed.
* src/server/malloc.gdb: File removed.
* src/server/free.gdb: File removed.
* src/server/Makefile.am (EXTRA_DIST): Removed free.gdb,
malloc.gdb and realloc.gdb.
1999-05-20 Per Cederqvist <ceder@gratia>
dbck failed to handle bcc_recpts.
* src/libraries/libcommon/misc-parser.c (parse_next_misc): Handle
bcc_recpt. Fix usage of the COMPILE_CHECKS macro.
Fix usage of the COMPILE_CHECKS macro.
* src/server/text.c (find_recipient): Fix usage of the
COMPILE_CHECKS macro.
(is_member_in_recpt): Likewise.
(do_delete_misc): Likewise.
(do_sub_recpt): Likewise.
(sender): Likewise.
(is_sender): Likewise.
(is_comm_sender): Likewise.
(skip_recp): Likewise.
(recp_sent_by): Likewise.
(filter_secret_info): Likewise.
(do_delete_text): Likewise.
(check_double_subm): Likewise.
(check_double_comm): Likewise.
(create_text_add_miscs): Likewise.
* src/server/text-garb.c (garb_text): Fix usage of the
COMPILE_CHECKS macro.
* src/server/ram-output.c (foutput_misc_info): Fix usage of the
COMPILE_CHECKS macro.
* src/server/prot-a-output.c (prot_a_output_misc_info): Fix usage
of the COMPILE_CHECKS macro.
* src/server/dbck.c (delete_misc): Fix usage of the
COMPILE_CHECKS macro.
(is_recipient): Likewise.
Code cleanup.
* src/include/kom-types.h: Removed code within #ifdef PROT_a. It
was never used, and is obsoleted by aux-items.
1999-05-19 Per Cederqvist <ceder@signum.se>
* NEWS: We document in Texinfo, not info.
1999-05-18 Per Cederqvist <ceder@gratia>
Avoid ".*" in regexps in the test suite, since they can easily
match too much.
* src/server/testsuite/lyskomd.0/06.exp: Use "$hollerith" instead
of a hard-coded regexp, to avoid parsing past newlines.
* src/server/testsuite/lyskomd.0/person-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/send-async-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/04.exp: Use "$any" instead of "."
to match any character, to avoid parsing past newlines.
* src/server/testsuite/lyskomd.0/membership-cov.exp: Likewise.
1999-05-18 Per Cederqvist <ceder@lysator.liu.se>
Increase coverage.
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
lyskomd.0/08.exp.
* src/server/testsuite/lyskomd.0/08.exp: New file.
1999-05-18 David Byers <davby@ida.liu.se>
* doc/lyskomd.texi: Merged dbck.texi and hacking.texi into
lyskomd.texi.
* src/server/testsuite/lyskomd.0/03.exp: Updated
query-predefined-aux-items result.
* src/server/testsuite/lyskomd.0/01.exp: Updated
query-predefined-aux-items result.
* src/server/aux-items.c (undelete_aux_item_list): Fixed
conference/text mixup
(delete_aux_item_list): Same here.
(undelete_aux_item_list): Save kom_errno and err_stat across call.
* src/server/aux-item-def-parse.y: Deal with disabled definitions
in a more sensible manner.
* src/server/aux-items.c (aux_item_add_perm): Check the disabled
field of the aux-item definition.
* src/server/aux-items.h: Added disabled field.
1999-05-17 David Byers <davby@ida.liu.se>
* src/server/aux-items.c (aux_item_list_add_items): New utility
function.
(system_add_aux_item_list): Use aux_item_list_add_items.
(text_stat_add_aux_item_list): Use aux_item_list_add_items.
(conf_stat_add_aux_item_list): Use aux_item_list_add_items.
1999-05-16 Per Cederqvist <ceder@lysator.liu.se>
Use a global variable to store the current time, so that it is
never changes during an atomic call, and so that we don't call
time() more than once per call.
* src/server/server-time.h: New file.
* src/server/ramkomd.c (main): Initialize current_time.
* src/server/connections.c (milli_timevaldiff): Removed.
(dump_statistics): Use current_time instead of calling time().
(toploop): Call time once per select loop instead of calling
gettimeofday twice. Simplify the computation of the timeout.
* src/server/conference.c (do_create_conf): Use current_time
instead of time().
* src/server/text.c (add_text_in_conf): Use current_time instead
of calling time().
(do_create_text): Likewise.
(add_recipient): Likewise.
(add_footnote): Likewise.
(add_comment): Likewise.
(create_text_add_miscs): Removed the now argument. All callers
updated. User current_time instead of now.
* src/server/text-garb.c (garb_text): Use current_time instead of
calling time().
* src/server/simple-cache.c (sync_part): Use current_time instead
of calling time().
(init_cache): Likewise.
* src/server/session.c (leave_conf): Use current_time instead of
calling time().
(login_old): Likewise.
(login): Likewise.
(logout): Likewise.
(who_is_on_dynamic): Likewise.
(get_session_info): Likewise.
(get_session_info_ident): Likewise.
(get_time): Likewise.
(user_active): Likewise.
* src/server/send-async.c (async_rejected_connection): Use
current_time instead of calling time().
* src/server/person.c (create_person_generic): Use
current_time instead of calling time().
* src/server/membership.c (do_add_rec_time): Use
current_time instead of calling time().
(do_add_member): Likewise.
* src/server/internal-connections.c (init_connection): Use
current_time instead of calling time().
(new_client): Likewise.
* src/server/aux-items.h: (prepare_aux_item_list): Removed the
"now" argument.
(prepare_aux_item): Likewise.
* src/server/aux-items.c (prepare_aux_item_list): Removed the
"now" argument. Use current_time instead. Call callers updated.
(prepare_aux_item): Likewise.
* src/server/admin.c (modify_server_info): Don't pass the current
time to prepare_aux_item_list.
Document updateLysKOM and komrunning. Make them accept -v/-V.
* doc/lyskomd.texi: Removed all up, next and prev pointers.
(Invoking updateLysKOM): New node.
(Invoking komrunning): New node.
* src/server/updateLysKOM.c (main): Use PACKAGE and VERSION (from
config.h) when reporting the version number.
* src/server/komrunning.c (usage): Accept -v and -V.
(main): Likewise.
The test suite now fails without having to wait for a timeout if a
wrong result with the proper ref-no is returned.
* src/server/testsuite/config/unix.exp (MEMTRACE): Default to
/dev/null.
(simple_expect): Recognize attempts to match protcol-A replies,
and fail without a timeout if the correct reference number is
returned with bogus data.
Fix "make dist".
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
lyskomd.0/07.exp, lyskomd.0/broken-aux-items.conf,
lyskomd.0/cache-node-cov.exp, lyskomd.0/conf-file-cov.exp,
lyskomd.0/conference-cov.exp, lyskomd.0/connections-cov.exp,
lyskomd.0/disk-end-of-atomic-cov.exp,
lyskomd.0/internal-connections-cov.exp,
lyskomd.0/isc-parse-cov.exp, lyskomd.0/log-cov.exp,
lyskomd.0/membership-cov.exp, lyskomd.0/memory-cov.exp,
lyskomd.0/person-cov.exp, lyskomd.0/prot-a-parse-cov.exp,
lyskomd.0/prot-a-send-async-cov.exp, lyskomd.0/send-async-cov.exp,
lyskomd.0/session-cov.exp and lyskomd.0/text-cov.exp.
* src/server/Makefile.am (komrunning_SOURCES): Added pidfile.h.
(updateLysKOM_SOURCES): Added pidfile.h.
(lyskomd_SOURCES): Added trace-alloc.h.
Fix the framework for hunting memory leaks.
* configure.in: Handle --with-traced-allocations.
* acconfig.h (TRACED_ALLOCATIONS): New define.
* src/server/trace-alloc.h: New file.
* src/server/testsuite/config/unix.exp (lyskomd_start): Handle
TRACED_ALLOCATIONS.
(lyskomd_fail_start): Likewise.
* src/server/ramkomd.c (main): Call trace_alloc_file very early
during startup if compiled with TRACED_ALLOCATIONS.
* src/server/ram-smalloc.c: Test TRACED_ALLOCATIONS instead of
DEBUG_MALLOC.
(trace_alloc_file): New function, that sets up malloc_fp.
(trace_smalloc): Write to malloc_fp.
(trace_free): Likewise.
(srealloc): Likewise.
* src/server/ram-smalloc.c: Don't test USE_GNU_MALLOC; that symbol
was removed 1998-08-09.
1999-05-16 David Byers <davby@ida.liu.se>
* src/server/aux-items.c (prepare_aux_item): Don't clear the link
field of the aux item.
(aux_inherit_items): Clear the link in the copied item before
calling add triggers.
(aux_item_link_items): New function.
(aux_item_trigger_mirror_faq): Use aux_item_link_items.
(aux_item_trigger_link_item): Use aux_item_link_items.
(aux_item_call_add_triggers): Fix the trigger data after calling
each trigger since one of them might move the aux item list in
memory.
1999-05-15 David Byers <davby@ida.liu.se>
* src/server/aux-items.c (aux_item_trigger_link_item): New
function for debugging linking aux items.
1999-05-14 Per Cederqvist <ceder@lysator.liu.se>
Fixes to the test suite.
* src/server/testsuite/lyskomd.0/connections-cov.exp: A client
dies immediately when it receives %% No connections left, so the
test case should not expect it to live longer. Renumber the
ref-nos. The nologin file exists in the build directory, not in
srcdir.
* src/server/testsuite/leaks.0/leaks02.exp: Don't forget the flags
argument to create-person.
* src/server/testsuite/lyskomd.0/conference-cov.exp: Don't attempt
to use debug calls unless debug_calls is true.
* src/server/testsuite/lyskomd.0/person-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/person-cov.exp: Look for
config/prot-a.exp in srcdir. Don't fail if the clock ticks.
* src/server/testsuite/lyskomd.0/conference-cov.exp: Look for
config/prot-a.exp in srcdir.
* src/server/testsuite/lyskomd.0/connections-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/membership-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/prot-a-send-async-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/send-async-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/session-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/text-cov.exp: Likewise.
* src/server/testsuite/config/unix.exp (timeout): Don't alter the
default value. Not every computer is fast computer.
(lyskomd_start): The aux-item config file is found relative to
$srcdir, not [pwd]. The config/lyskomd-config file is found
relative to the current working directory.
(lyskomd_fail_start): Likewise. Find the database files relative
to top_srcdir.
1999-05-14 David Byers <davby@ida.liu.se>
* src/server/text.c (do_create_text): Return long-array if there
are too many misc items.
(modify_text_info): Set err_stat to max length when returning
KOM_LONG_ARRAY.
* src/include/kom-types.h (Info_datum): Added unknown_type to
union.
* src/server/text.c (find_recipient): Add unknown_info to the
switch. Stop the server if COMPILE_CHECKS is undefined.
(is_member_in_recpt): Same here.
(do_delete_misc): Same here.
(do_sub_recpt): Same here.
(sender): Same here.
(is_sender): Same here.
(is_comm_sender): Same here.
(skip_recp): Same here.
(recp_sent_by): Same here.
(filter_secret_info): Same here.
(do_delete_text): Same here.
(check_double_subm): Same here.
(check_double_comm): Same here.
(create_text_check_misc): Return an illegal-info-typye if we see
an unknown info. Set err_stat to the index of the bad item when
returning a KOM_ILL_MISC.
(create_text_add_miscs): Same here.
* src/server/prot-a.c (prot_a_destruct): Free the misc_info_list
field of the connection.
* src/server/membership.c (add_rec_time): Handle unknown_info and
other unknown misc info types by shutting down the server.
* src/server/call-switch.awk: Add support for misc_info_list in
fncdef.txt.
* src/server/text.c (create_text_old): Changed parameter list to
use Misc_info_list instead of an integer and a Misc_info pointer.
(create_text): Same here.
(create_anonymous_text): Same here.
(create_anonymous_text_old): Same here.
* src/server/fncdef.txt: Changed all "num c_misc_info_p" to
misc_info_list.
* src/server/prot-a-parse-arg-c.awk: The aux_item type works again.
Allow misc_info_list as a type name.
* src/server/prot-a-parse.c (prot_a_parse_misc_info_list): New
function.
* src/server/prot-a.c (prot_a_init): Initialize the misc_info_list
field.
* src/server/internal-connections.c (kill_client): Use
misc_info_list field of Connection.
* src/server/connections.c (free_parsed): Clear the misc_info_list
field.
* src/include/kom-types.h (Misc_info_list): New type.
* src/server/internal-connections.c (init_connection): Initialize
hunt_parse_pos, array_hunt_depth and array_hunt_num. Initialize
misc_info_list.
* src/server/prot-a-parse.c (prot_a_hunt_array_end): New function
hunts for the end of an array.
* src/server/prot-a.c (prot_a_init): Initialize hunt_parse_pos and
array_hunt_num.
* src/include/kom-types.h (Info_type): Added unknown info type.
* src/server/prot-a-parse.c (prot_a_parse_misc_info): Parse all
misc-info types that the server knows about. Unknown types
generate a protocol error.
* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp (1021):
Expect long-array and not protocol-error.
* src/server/prot-a-parse.c (prot_a_parse_aux_item_list): Discard
the part of the list that is longer than the max rather than send
a protocol error.
1999-05-13 David Byers <davby@ida.liu.se>
* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp
(protocol_error): Removed expected failure.
* src/server/admin.c (modify_server_info): Return KOM_LONG_ARRAY
when we see a long array.
* src/server/conference.c (modify_conf_info): Return
KOM_LONG_ARRAY when we see a long array.
* src/server/text.c (modify_text_info): Return KOM_LONG_ARRAY when
we see a long array.
* src/server/prot-a-parse.c (prot_a_parse_num_list): Truncate a
parsed array to one more than the maximum length and skip all
other elements.
* src/server/aux-items.c (undelete_aux_item_list): Log if the link
type is undefined and do not attempt to undelete.
(delete_aux_item_list): Likewise.
1999-05-13 Per Cederqvist <ceder@gratia>
Distribute the leaks tests, and run them during "make check".
* src/server/testsuite/Makefile.am (EXTRA_DIST): Track the rename
of lyskomd.0/leaks*.exp -> leaks.0/leaks*.exp.
(check): Depend on check-leaks.
(check-leaks): New target.
Code cleanup/minor bugs fixed.
* src/server/testsuite/tcpconnect.py: socket.recv can raise
socket.error! Handle it as end-of-file.
* src/server/simple-cache.c (cached_conf_exists): Removed the
unused variable node.
* src/server/aux-items.c (find_linked_aux_item_list): Don't use an
uninitialized variable.
(delete_aux_item_list): Fail if the default branch is reached.
(undelete_aux_item_list): Fail if the default branch is reached.
(aux_item_trigger_mirror_faq): Test data->object for NULLness
intstead of the uninitialized variable conf_stat.
* doc/hacking.texi (Linking Pairs of Aux Items): Texinfo problem
fixed.
* doc/Protocol-A.texi (set-info): Untabify.
(accept-async): Untabify.
(query-async): Untabify.
1999-05-12 David Byers <davby@ida.liu.se>
Stuff I forgot to add below
* Renamed log to kom_log since log is a function in math.h.
* src/include/services.h (set_pers_flags): New prototype.
(create_person): Added flags parameter.
* run-support/config: Set defaults for max texts and max
conferences.
* run-support/aux-items.conf (faq-text): Removed all triggers. Set
add-trigger to link-faq, added validator.
(faq-for-conf): New item definition.
* doc/lyskomd.texi (Parameters): Added Max conferences, Max texts,
Max client data length, Nologin file. Updated some other parameter
descriptions.
(Aux-Item Definition File): Added system-only. Rewrote validate to
allow function identifiers. Added list of validator functions and
triggers.
(Files): Document /etc/nologin.
* doc/hacking.texi: Correct minor typos. Change some @code into
@file.
(Linking Pairs of Aux Items): New section.
* doc/Protocol-A.texi: Correct minor typos
(Predefined Aux-Item Types): Rephrase some
of the text. Remove statement that faq-text item marks a text.
Document faq-for-conf. Specify formate for mx-message-id.
(Simple Data Types): Removed documentation for INTEGER.
(set-etc-motd): Change too-many-marks to mark-limit
(mark-text-old): Change too-many-marks to mark-limit
(set-conf-type): Correct documentation for secret-public error.
Correct spelling in invalid-membership-type documentation.
(add-recipient): Add documentation for access-denied error
(add-comment): Define error-status in index-out-of-range.
(sub-comment): Change no-comment to not-comment.
(send-message): Complete documentation of message-not-sent error.
(create-text): Add index-out-of-range as possible error.
(create-conf): Complete doc of permission-denied error.
(create-person): Added personal-flags parameter.
(create-person): Document person-exists error.
(set-pers-flags): New call.
(Error Codes): Clarify message-not-sent and index-out-of-range.
* configure.in: Added flag --with-insure++. Define AVOID_ABORTS
when compiling with support for gcov.
* src/server/testsuite/tcpconnect.py: Added #hose socket to hose
the socket with lots of zeroes.
* src/server/testsuite/config/prot-a.exp: New functions
kom_set_permitted_submitters, kom_set_super_conf, kom_login_old,
kom_mark_text, kom_sub_recipient, kom_set_conf_type,
kom_change_conference, kom_set_priv_bits.
(kom_create_person): Send the pers_flags field.
* src/server/testsuite/config/unix.exp: Print a dot for every test
case in verbose mode.
(lyskomd_start): New parameters extra_config for additional config
file contents and base_config for basic config file contents
(defaults will not be used.) Don't print defaults for max
conferences or max texts if they are in extra_config. It is
possible to start lyskomd with arbitrary arguments.
(lyskomd_fail_start): Function to use when lyskomd is supposed to
not start properly (like lyskomd_start, but server failue is
expected.)
(client_start_fail): New function like client_start, but failure
is expected.
(kill_client): Unset expect_active and expect_always instead of
setting to the empty string.
(hose_client): New function
* src/server/testsuite/lyskomd.0/00.exp: Send pers-flags in calls
to create-person.
* src/server/testsuite/lyskomd.0/01.exp: Update expected results
in query-predefined-aux-items. Send pers-flags in call to
create-person. Add test for set-pers-flags. Add test for
nonexistent call 107.
* src/server/testsuite/lyskomd.0/02.exp: Send pers-flags in call
to create-person.
* src/server/testsuite/lyskomd.0/03.exp: Expect aux-item 28 in
query-predefined-aux-items. Send pers-flags in call to
create-person. Expect the faq-for-conf aux-item in test 1327.
Expect failure attempting to set nonexistent text as faq (test
1342.) Remove the now failed faq item in subsequent tests. Add
test for set-pers-flags.
* src/server/testsuite/lyskomd.0/04.exp: Send pers-flags in calls
to kom_create_person.
* src/server/testsuite/lyskomd.0/05.exp: Send pers-flags in calls
to kom_create_person. Be more flexible when expecting time
corresponding to time_t zero. Set garb and sync interval to
something really high to avoid spurious async messages while
running the tests.
* src/server/testsuite/lyskomd.0/06.exp: Send pers-flags in calls
to kom_create_person.
* src/server/testsuite/lyskomd.0/admin-cov.exp: More setup to
support new tests. Test that we can't send messages to secret
confs. Test that messages are filtered for passive members.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Send
pers-flags in calls to kom_create_person. Attempt to create
aux-items with broken validation regexp. Test the system-only
attribute. Test a broken aux-item config file.
* src/server/testsuite/lyskomd.0/aux-items.cov: Add an item
definition with system-only property.
* src/server/prot-a-parse.h: Added prototype for
prot_a_parse_pers_flags
* src/server/prot-a-parse.c (prot_a_parse_pers_flags): New
function to parse pers flags.
* src/server/prot-a-output.c (prot_a_output_text_mapping):
Initialize the fields of iter to avoid warnings from tools that
detect access to uninitialize memory.
* src/server/local-to-global.c: Use kom_log instead of log.
* src/server/kom-memory.c: Added prototypes for init_aux_item and
init_aux_item_link.
* src/server/aux-items.c (system_check_add_aux_item_list): Call
aux_item_add_perm with INFO_OBJECT_TYPE for the object_type
parameter.
* src/server/admin.c: Use kom_log instead of log everywhere.
(send_message): Do not permit sending group messages to secret
conferences. Set errno to KOM_MESSAGE_NOT_SENT if there are no
appropriate recipients.
* src/server/aux-item-def-parse.y: Parse validation functions in
addition to validation regexps. Use kom_log instead of log. Parse
the system-only property.
(aux_item_def_check_validate): New function.
* src/server/aux-items.c: Add the aux-item being involved item
itself to aux-item trigger data.
(aux_item_validate_existing_text): New validation function.
(aux_item_trigger_mirror_faq): New add trigger function
(aux_item_trigger_unmark_text): Modified to work for aux-items on
texts and conferences, not just conferences. Do not unmark an
unmarked text.
(aux_item_trigger_mark_text): Do not add more marks than
permitted.
(find_aux_item_index): New function to find the index of an item
with a particular number in an aux item list.
(commit_aux_item_list): Renamed to commit_aux_item_list_internal.
(commit_aux_item_list_internal): Delete linked aux items.
(commit_aux_item_list): Wrapper for commit_aux_item_list_internal.
(delete_aux_item_list): Manage deletion of linked items.
(undelete_aux_item_list): Manage undeletion of linked items.
(mark_linked_object_as_changed): New function to mark the object
containing a linked aux item as changed.
(find_linked_aux_item): New function to find the aux item that is
linked to a given aux item.
(find_linked_aux_item_list): New function to find the aux item
list containing the aux item that is linked to a given aux item.
(aux_item_validate): New function for validating aux items. Deals
with regexps and validation functions.
(aux_item_add_perm): Handle the system-only property of aux item
definitions.
1999-05-09 David Byers <davby@ida.liu.se>
* src/server/aux-items.c (prepare_aux_item): Clear the linked_item
field properly.
* src/server/memory.c (init_aux_item_link): New function.
(init_aux_item): Use init_aux_item_link
(init_aux_item): New function added earlier.
* src/server/prot-a-parse.c (prot_a_parse_aux_item): Clear the
parsed aux_item to get good defaults for fields that are not read
in the parser.
* src/server/admin.c (modify_server_info): Pass INFO_OBJECT_TYPE
to delete_aux_item_list and undelete_aux_item_list.
* src/server/aux-items.h: Changed all declarations of object_type
from short to Object_type.
* src/server/aux-items.c: Changed all declarations of object_type
from short to Object_type.
* src/server/ram-parse.c (fparse_aux_item_link): New function.
(fparse_aux_item): Parse the link as well.
* src/include/kom-types.h (Object_type): New type (moved defs from
aux-items.h)
(Aux_item_link): New type
(Aux_item): Added linked_item field.
* src/server/ram-output.c (foutput_aux_item): Output linked_item
field.
(foutput_aux_item_link): New function to output a link to another
aux item.
* src/server/aux-items.c: Added handling of item field in aux item
trigger calls.
* src/server/aux-items.h (Aux_item_trigger_data_s): Added item
field.
* src/server/aux-items.c (system_check_add_aux_item_list): Set
owner_check to TRUE in call to aux_item_add_perm so system-only
restriction works on system-info aux-item list.
* src/server/testsuite/lyskomd.0/admin-cov.exp: Added tests for
sending messages to secret confs and to conf with passive member
logged in.
* doc/Protocol-A.texi (send-message): Document that
message-not-sent is returned when there are no recipients for a
group message.
* src/server/com-h.awk: Set illegal_fnc to -1 (was cnt) since cnt
might be a legal function.
1999-05-02 Per Cederqvist <ceder@gratia>
"make check" in the top directory failed in some environments.
* src/server/testsuite/Makefile.am (check-lyskomd): Close file
descriptors 3-9 to avoid interference between file descriptors
inherithed from make, sshd et c with lyskomd.0/07.exp.
1999-05-01 Per Cederqvist <ceder@lysator.liu.se>
Use libisc-1.00.
* src/libraries/libisc-new: Replace the old contents with that of
isc-1.00. Se src/libraries/libisc-new/ChangeLog for information
about any modifications that are made to the library.
1999-04-28 Per Cederqvist <ceder@lysator.liu.se>
Remove support for the mux protocol. Don't use isc_printf.
* src/server/testsuite/lyskomd.0/07.exp: Decrease the all file
descriptors by one, now that the server no longer listens for a
mux. Test that protocol B is unsupported.
* src/server/testsuite/config/unix.exp (muxport): Removed.
(lyskomd_start): Don't set "Mux port" in the config file.
* src/server/server-config.c (parameters): Removed parameter "Mux
port".
* doc/lyskomd.texi (Parameters): Removed "Mux port".
* src/server/ramkomd.c (listen_mux): Removed.
(server_init): Remved the "mux_port" argument. Don't listen for
muxes.
(initialize): Don't pass the "mux_port" argument to server_init.
* src/server/prot-a.c (prot_a_reply): Use isc_putc, isc_putul,
isc_flush and prot_a_output_ul instead of mux_printf, mux_flush
and mux_putc.
(prot_a_parse_packet): Likewise.
* src/server/prot-a-send-async.c (async_header): Use isc_putc,
isc_putul, prot_a_output_ul and isc_flush instead of mux_printf,
mux_putc and mux_flush.
(async_trailer): Likewise.
(prot_a_async_new_text_old): Likewise.
(prot_a_async_new_text): Likewise.
(prot_a_async_logout): Likewise.
(prot_a_async_new_name): Likewise.
(prot_a_async_forced_leave_conf): Likewise.
(prot_a_async_login): Likewise.
(prot_a_async_send_message): Likewise.
(prot_a_async_deleted_text): Likewise.
(prot_a_async_new_recipient): Likewise.
(prot_a_async_sub_recipient): Likewise.
(prot_a_async_new_membership): Likewise.
* src/server/prot-a-output.h (prot_a_output_ul): New function.
* src/server/prot-a-parse.c (prot_a_get_token): Use isc_puts and
isc_flush instead of mux_printf and mux_flush.
(prot_a_parse_num_list): Likewise.
(prot_a_parse_string): Likewise.
* src/server/prot-a-output.c (prot_a_output_ul): New function.
(prot_a_output_person): Use prot_a_output_ul, isc_puts, isc_putc
and isc_write instead of mux_printf, mux_putc and mux_write.
(prot_a_output_membership_type): Likewise.
(prot_a_output_membership): Likewise.
(prot_a_output_membership_old): Likewise.
(prot_a_output_membership_list_old): Likewise.
(prot_a_output_membership_list): Likewise.
(prot_a_output_conf_list): Likewise.
(prot_a_output_conf_no_list): Likewise.
(prot_a_output_conference): Likewise.
(prot_a_output_conference_old): Likewise.
(prot_a_output_uconference): Likewise.
(prot_a_output_mark_list): Likewise.
(prot_a_output_aux_item_flags): Likewise.
(prot_a_output_aux_item): Likewise.
(prot_a_output_text_stat_old): Likewise.
(prot_a_output_aux_item_list): Likewise.
(prot_a_output_who_info_ident): Likewise.
(prot_a_output_who_info): Likewise.
(prot_a_output_who_info_list): Likewise.
(prot_a_output_who_info_ident_list): Likewise.
(prot_a_output_who_info_list_old): Likewise.
(prot_a_output_session_info): Likewise.
(prot_a_output_session_info_ident): Likewise.
(prot_a_output_info_old): Likewise.
(prot_a_output_string): Likewise.
(prot_a_output_priv_bits): Likewise.
(prot_a_output_personal_flags): Likewise.
(prot_a_output_conf_type): Likewise.
(prot_a_output_extended_conf_type): Likewise.
(prot_a_output_member_list): Likewise.
(prot_a_output_member_list_old): Likewise.
(prot_a_output_member): Likewise.
(prot_a_output_member_old): Likewise.
(prot_a_output_mark): Likewise.
(prot_a_output_misc_info): Likewise.
(prot_a_output_time): Likewise.
(prot_a_output_session_no): Likewise.
(prot_a_output_text_no): Likewise.
(prot_a_output_conf_z_info): Likewise.
(prot_a_output_conf_z_info_list): Likewise.
(prot_a_output_version_info): Likewise.
(prot_a_output_num_list): Likewise.
(prot_a_output_dynamic_session_info): Likewise.
(prot_a_output_dynamic_session_info_list): Likewise.
(prot_a_output_l2g_iterator_as_text_list): Likewise.
(prot_a_output_text_mapping): Likewise.
(prot_a_output_memory_info): Likewise.
* src/server/param.h (struct kom_par): Removed ip_mux_port,
num_ip_mux_port and num_ip_client_port.
* src/server/isc-interface.h (ISC_UDGTYPE): Use "struct
connection" instead of "struct mux".
(ISC_PRINTF_SUPPORT): Don't define it.
* src/server/internal-connections.c (init_connection): Use
isc_session instead of mux.
(kill_client): Likewise.
* src/server/connections.h (Connection): Replaced mux with isc_session.
* src/server/connections.c (logout_client): Use ISC instead of the
removed mux layer.
(parse_packet): Likewise.
(parse_unparsed): Likewise.
(login_request): Likewise. Don't handle muxes.
(logout_request): Likewise.
(message_request): Likewise.
(mux_handle_packet): Removed.
(mux_logout): Removed.
(mux_parse_unparsed): Removed.
(mux_parse_message): Removed.
(milli_timevaldiff): New name for former timevaldiff. Return the
difference in milliseconds instead of microseconds.
(toploop): Use milli_timevaldiff instead of timevaldiff. This is
a thousand times better at avoiding overflow. Use isc_puts
instead of isc_printf.
* src/server/mux.h: File removed.
* src/server/mux.c: File removed.
* src/server/mux-parse.h: File removed.
* src/server/mux-parse.c: File removed.
* src/server/Makefile.am (lyskomd_SOURCES): Removed mux-parse.h
and mux.h.
(MUX): Removed. Removed mux.c and mux-parse.c.
(GENOBJS): Removed $(MUX).
* doc/mux.proto: File removed.
* doc/Makefile.am (EXTRA_DIST): Remove mux.proto.
* configure.in: Remove enable_isc_printf -- we no longer need
isc_printf.
Fix a warning message in the testsuite.
* src/server/testsuite/lyskomd.0/admin-cov.exp: Fixed the
"unsupported" message: The configure option is named
--with-debug-calls, not --enable-debug-calls.
1999-04-25 Per Cederqvist <ceder@gratia>
Increase the block size of the l2g structure from 10 to 250.
* src/server/local-to-global.h (l2g_set_block_size): New function.
* src/server/local-to-global.c (L2G_BLOCKSIZE): Now a static int
instead of a define.
(l2g_set_block_size): New function, that can be called once to
set the block size
(l2g_init): Set the block size to 250 unless it has already been
set.
* src/server/testsuite/test-l2g.c (main): Set the block size to 10.
1999-04-23 David Byers <davby@ida.liu.se>
* src/server/standalone.c (kom_info): Initialize the
aux_item_list too.
* src/server/ramkomd.c (initialize): Use kom_log instead of log.
* src/server/local-to-global.c (l2g_read): Use kom_log instead of
log.
* src/server/text.c (text_read_access): Call
person_text_read_access to do the work.
(person_text_read_access): New function generalizes
text_read_access.
* src/server/manipulate.h: Prototype for person_text_read_access.
1999-04-21 David Byers <davby@ida.liu.se>
* src/server/aux-items.c (aux_item_find_validator): New function.
1999-04-20 Per Cederqvist <ceder@gratia>
Two file descriptors were leaked during startup.
* src/server/aux-item-def-parse.y (parse_aux_item_definitions):
Close the config file once it is read.
* src/server/conf-file.c (read_config): Close the config file once
it is read.
1999-04-19 Per Cederqvist <ceder@gratia>
New parameter: "Client host".
* doc/lyskomd.texi (Parameters): Documented "Client host".
* src/server/server-config.c (parameters): New parameter: "Client
host".
* src/server/ramkomd.c (server_init): New argument: host. Bind
the specified IP number.
(initialize): Pass param.ip_client_host to server_init.
* src/server/param.h (struct kom_par): Added ip_client_host.
1999-04-19 Per Cederqvist <ceder@lysator.liu.se>
Test the "% No connections left." message.
* src/server/testsuite/lyskomd.0/07.exp: Test what happens when
too many clients try to connect at the same time.
1999-04-18 Per Cederqvist <ceder@lysator.liu.se>
More documentation.
* doc/lyskomd.texi (Parameters): Documented "lyskomd path",
"savecore path", "Normal shutdown time", "Mail after downtime" and
"Mail until downtime".
* doc/Protocol-A.texi (Protocol Version History): Call
102=set-membership-type was omitted, and later calls were
misnumbered.
(map-created-texts): Documented.
1999-04-18 Per Cederqvist <ceder@gratia>
Removed the last hardcoded configuration from updateLysKOM.
* src/server/updateLysKOM.c (savecore): Use param.core_dir and
param.savecore_path instead of hardcoding the values.
* src/server/server-config.c (parameters): New parameter:
"savecore path".
(read_configuration): Handle param.savecore_path.
* src/server/param.h (struct kom_par): New parameter:
savecore_path.
1999-04-17 Per Cederqvist <ceder@lysator.liu.se>
updateLysKOM now reads the configuration file.
* src/server/updateLysKOM.c (usage): New function.
(checkstatus): Use parameters "Normal shutdown time", "Mail after
downtime" and "Mail until downtime" instead of
using hard-coded values. Use "mail" instead of "Mail" to send the
mail.
(main): Read the configuration file. Use parameters "Pid file",
"Status file" and "lyskomd path" instead of hard-coded values.
* src/server/server-config.c (param): Moved here from various
files.
(parameters): Added "Normal shutdown time", "Mail after downtime",
"Mail until downtime" and "lyskomd path".
(read_configuration): Handle param.lyskomd_path.
* src/server/ramkomd.c: (param): Moved to server-config.c.
* src/server/dbck.c (param): Moved to server-config.c.
* src/server/Makefile.am (READ_CONFIG): New variable.
(komrunning_SOURCES): Use READ_CONFIG to simplify code.
(updateLysKOM_SOURCES): Added READ_CONFIG.
* src/server/param.h (struct kom_par): New parameters:
lyskomd_path, normal_shutdown_time, downtime_mail_start and
downtime_mail_end.
* src/server/server-config.c (parameters): Moved a few entries
around, so that they fit under the various headings.
Fixes to komrunning.c.
* src/server/komrunning.c (param): Moved to server-config.c.
(create_status): Write the name of the user as the first line of
the status file. With luck, that is a valid email address.
Handle many simultaneous clients.
* src/server/connections.c (login_request): Don't handle the "% No
connections left" situation.
(toploop): Handle ISC_EVENT_LOGIN_UNRELOCATED by returning a "% No
connections left" message and closing the session, the way
login_request used to do.
* src/server/ramkomd.c (initialize): Warn if getrlimit and sysconf
don't agree on the number of possible open files.
1999-04-17 Per Cederqvist <ceder@gratia>
Work towards handling more than 250 simultaneous clients.
* src/server/ramkomd.c (server_init): Use isc configuration 1006
and isc session configuration 1002. Fill in fd_relocate with
PROTECTED_FDS.
1999-04-17 Per Cederqvist <ceder@lysator.liu.se>
Re-implement komrunning in C.
* src/server/standalone.c (register_jubel): Dummy implementation.
* src/server/dbck.c (register_jubel): Moved to standalone.c.
* src/server/dbck-cache.c (kom_info): Moved to standalone.c.
* src/server/komrunning.c: New file; a reimplementation of
komrunning.sh in C.
* src/server/Makefile.am (bin_PROGRAMS): Added komrunning.
(komrunning_SOURCES): New variable, which among other files
includes komrunning.c.
(updateLysKOM_SOURCES): Added pidfile.c.
(dbck_SOURCES): Added standalone.c.
* run-support/komrunning.sh: Removed.
* run-support/Makefile.am (komrunning): Target removed.
(bin_SCRIPTS): Removed komrunning.
(EXTRA_DIST): Removed komrunning.sh.
(MOSTLYCLEANFILES): Removed komrunning.
Introduce the "Status file" parameter.
* src/server/server-config.c (parameters): Added "Status file".
(read_configuration): Handle param.status_file.
* src/server/param.h (struct kom_par): Added status_file.
* doc/lyskomd.texi (Parameters): Documented "Status file".
Move pid file reading to pidfile.c.
* src/server/updateLysKOM.c (main): Use pidfile to simplify code.
* src/server/pidfile.h (read_pid_file): New function.
* src/server/pidfile.c (read_pid_file): New function.
1999-04-15 Per Cederqvist <ceder@lysator.liu.se>
Document 103=local-to-global.
* doc/Protocol-A.texi (accept-async): Added the error code
long-array.
(add-member): Added a comment.
(local-to-global): Documented.
(The User Area): Register WWW-kom.
Test suite improvement.
* src/server/testsuite/lyskomd.0/03.exp: Test calls 103 and 104.
1999-04-06 Per Cederqvist <ceder@gratia>
Yesterdays changes were incomplete.
* src/server/ramkomd.c: Include local-to-global.h.
1999-04-05 Per Cederqvist <ceder@panic.signum.se>
Explain the Text-Mapping data type.
* doc/Protocol-A.texi (LysKOM Data Types): Explain Text-Mapping.
1999-04-05 Per Cederqvist <ceder@gratia>
Change the external file format of a Local_to_global.
* src/server/testsuite/l2g.0/09.exp: Adjusted to new external
format of Local_to_global.
* db-crypt/db/lyskomd-data: Adapted to new format of
Local_to_global objects.
* src/server/local-to-global.c (l2g_read): New file format.
(put_ulong): New static function.
(l2g_write): New file format.
* src/server/testsuite/l2g.0/11.exp: Added lots of test cases for
l2g_write.
Added statistics to Local_to_global.
* src/server/ramkomd.c (dump_exit_statistics): Call dump_l2g_stats.
* src/server/local-to-global.h: Comments added and improved.
(dump_l2g_stats): New function.
* src/server/local-to-global.c (nr_constructs): New static
variable, used to gather statistics. Changed all functions to set
it where appropriate.
(nr_l2gs): Likewise.
(nr_l2gs_peak): Likewise.
(nr_destructs): Likewise.
(nr_clears): Likewise.
(nr_copies): Likewise.
(nr_joins): Likewise.
(nr_joined_blocks): Likewise.
(nr_blocks): Likewise.
(nr_blocks_peak): Likewise.
(nr_blocks_sparse): Likewise.
(nr_blocks_sparse_peak): Likewise.
(sparse_skip_cost): Likewise.
(nr_sparse_compactions): Likewise.
(nr_sparsifications): Likewise.
(l2g_destruct): Actually fill the destructed object with garbage
data, unless NDEBUG is defined.
(dump_l2g_stats): New function.
Make a lot of functions in ram-output.c static. Increase const
awareness.
* src/server/ram-output.c (foutput_person_0): Added const
qualifier to the person argument.
(foutput_person_2): Likewise.
(foutput_person): Likewise.
(foutput_conference_2): Added const qualifier to the conf_c
argument.
(foutput_aux_flags): Now static.
(foutput_aux_item): Now static.
(foutput_aux_item_list): Now static. Added const qualifier to the
aux argument.
(foutput_membership_type): Now static.
(foutput_string): Now static.
(foutput_priv_bits): Now static.
(foutput_personal_flags): Now static.
(foutput_text_list): Now static.
(foutput_mark_list): Added const qualifier to the mark_list
argument.
(foutput_mark): Now static.
(foutput_membership_list): Now static.
(foutput_time): Now static.
(foutput_member_list): Now static.
(foutput_member): Now static.
(foutput_conf_type): Now static.
(foutput_misc_info): Now static.
(foutput_ulong): Now static.
* src/server/ram-output.h: Track changes in ram-output.c.
* src/include/kom-types.h (Text_mapping): The l2g pointer is
const.
Some minor improvements to memory handling.
* src/server/memory.c (free_conference): Call l2g_destruct.
(free_person): Likewise.
* src/server/conference.c (do_delete_conf): Don't call l2g_clear,
since cache_delete_conf will do so.
Remove useless compiler warnings.
* configure.in: Don't use -Wtraditional and -Wnested-externs.
Test suite improvement.
* src/server/testsuite/config/unix.exp (lyskomd_death): Collect
etc/memory-usage in usage.all.
Test suite fix.
* src/server/testsuite/config/unix.exp (lyskomd_start): The
detection of a server compiled with --with-debug-calls was
broken.
Test Local_to_global even more.
* src/server/testsuite/l2g.0/11.exp: Increase coverage even
further. Test l2g_clear.
* src/server/local-to-global.h: Comments improved.
* src/server/local-to-global.c: Comments improved.
1999-04-05 Per Cederqvist <ceder@panic.signum.se>
Added range-begin and range-end to Text-Mapping.
* doc/Protocol-A.texi (LysKOM Data Types): Added range-begin and
range-end to Text-Mapping.
* src/server/prot-a-output.c (prot_a_output_text_mapping): Emit
range-begin and range-end.
* src/server/person.c (map_created_texts): Set result->first to
the first text number that the user requested. Don't move it
forward if the text has been deleted.
* src/server/text.c (local_to_global): Likewise.
* src/server/testsuite/lyskomd.0/00.exp: Expect range-begin and
range-end in Text-Mappings.
1999-04-04 Per Cederqvist <ceder@panic.signum.se>
Merge everything from prot-A.txt into Protocol-A.texi and remove
prot-A.txt.
* doc/prot-A.txt: Removed. Everything in it should now be present
in Protocol-A.texi.
* doc/Makefile.am (EXTRA_DIST): Removed prot-A.txt.
* doc/Protocol-A.texi: Removed all up, next and prev pointers.
Makeinfo can figure them out automatically. Fixed proper nesting
of nodes, and use @Top, so that this work. Merge everything in
prot-A.txt into this document:
(Document Revision History): This is going to be revision 10.0
which documents protocol version 10. 9.0 was distributed with
lyskomd 1.9.0. 8.0 was distributed with lyskomd 1.8.0.
(Protocol Version History): New name for former "Protocol Revision
History". Updated the information about version 9.
(Protocol Design Principles): Node removed. The "Client-Server
Dialog" node contains the same information.
(Client-Server Dialog): Specify the LysKOM port in the example.
(Simple Data Types): Moved the text about data element separator
and call terminator to "Client-Server Dialog".
(user-active): Talk more about when clients should send this.
(who-is-on-dynamic): Improved the explanation.
(get-static-session-info): State that the returned information is
immutable.
Distribute sigflags.h.
* src/server/Makefile.am (lyskomd_SOURCES): Added sigflags.h.
1999-04-03 Per Cederqvist <ceder@lysator.liu.se>
Renam do_sync_db to do_statistics. Use sig_atomic_t instead of
Bool for variables set from signal handlers.
* src/server/sigflags.h: New file, containing sig_atomic_t flags.
* src/server/ramkomd.c: Include "sigflags.h".
(sighandler_hup): Use 1 instead of TRUE as
value of go_and_die.
(sighandler_usr1): Use 1 instead of TRUE as value of
do_statistics. Use do_statistics instead of do_sync_db.
* src/server/connections.h (go_and_die): Declaration moved to
sigflags.h.
(do_sync_db): Renamed to do_statistics and moved to sigflags.h.
* src/server/connections.c (go_and_die): Now sig_atomic_t instead
of Bool.
(do_statistics): New name for former do_sync_db. New type:
sig_atomic_t instead of Bool. All users of do_sync_db updated.
(toploop): Don't call cache_sync when do_statistics is set.
* src/server/admin.c (shutdown_kom): Set go_and_die to 1, not TRUE.
Cosmetic code cleanup.
* src/server/prot-a-parse-arg-c.awk: Insert a blank line between
the system includes and the local includes.
Remove the empty function cache_sync. Rename cache_sync in dbck
to cache_sync_all.
* src/server/simple-cache.c (cache_sync): Removed.
* src/server/logII.c (log): Call cache_sync_all instead
of cache_sync.
* src/server/dbck.c (garb_text_file): Call cache_sync_all instead
of cache_sync.
(main): Likewise.
* src/server/dbck-cache.c (cache_sync_all): New name for former
cache_sync.
* src/server/cache.h (cache_sync): Function removed.
Distribution cleanup.
* src/server/Makefile.am (EXTRA_DIST): Don't distribute logII.c.
* configure.in: Create src/libraries/regex/doc/Makefile and
src/libraries/regex/test/Makefile.
Documentation fixes.
* doc/lyskomdb.texi (Version 0): next-free-num and next-text-num
are one greater than the number of existing records.
(Version 1): The same error probably exists here. Added comment
about it.
* doc/lyskomd.texi (Server Configuration File): Markup fixes.
(Parameter Types): Markup fixes.
(Parameters): Markup fixes.
(Aux-Item Definition File): Markup fixes.
(Administration): Update the discussion about updateLysKOM, dbck
and komrunning. Markup fixes.
Make all man pages obsolete. Generate the version number in
lyskomd.texi automatically. Make sure that lyskomd.texi and
dbck.texi includes everyting that was documented in the man pages.
* mkmi: Remove scripts/mdate-sh, which should be generated by
automake.
* doc/man/dbck.8: All documentation removed. Refer to
dbck.info.
* doc/man/lyskom.5: Documentation removed. Refer to lyskomdb.info.
* doc/man/updateLysKOM.8: All documentation removed. Refer to
lyskomd.info.
* doc/dbck.texi (Invoking dbck): Mention that dbck with no
argument will examine the database without modifying it.
(General Options): Document -h (aka --help).
(Format Conversion Options): Minor layout fix.
(Notes): Typos fixed.
(Files): Markup fixes.
* doc/Makefile.am: Break long lines.
* doc/man/lyskomd.8: All documentation removed. Refer to
lyskomd.info.
* doc/lyskomd.texi: Include version.texi and use @value{VERSION}
instead of hard-coding the value.
(Overview): Add Peter Eriksson to the list of signficant
contributors. ISC was a piece of very important "enabling
technology".
(Parameter Types): Mention that all files are absolute if the
begin with '/'.
(Parameters): Use @var{} instead of @i{}. Markup fixes and other
minor typo fixes. The "Log statistics" path is used when the
server receives a SIGUSR1 signal -- not a SIGHUP!
(Aux-Item Definition File): The file name was wrong. Don't use
@i{}. Document the "server" keyword. Mention that permanent
aux-items will be deleted when the object they belong to are
deleted.
(Signals): Removed a note about SIGUSR2 not working on Suns. It
should work fine there as well.
(Files): Don't use @i{}.
(Bugs): There is no detectable memory leak worth noting.
1999-04-03 Per Cederqvist <ceder@gratia>
The test cases shouldn't fail just because --with-debug-calls
wasn't enabled.
* src/server/ramkomd.c (main): Emit a warning message when
--with-debug-calls is enabled.
* src/server/testsuite/config/unix.exp (lyskomd_start): Look for
the warning message about --with-debug-calls, and set debug_calls
to a true value if it is found.
* src/server/testsuite/lyskomd.0/admin-cov.exp: Don't attempt to
use debug calls unless debug_calls is true.
1999-04-02 Per Cederqvist <ceder@panic.signum.se>
Fix "make clean".
* src/server/testsuite/Makefile.am (mostlyclean-local): Remove db
and etc.
Use automake defaults for the Lex and Yacc files, so that the
distribution works.
* src/server/Makefile.am (YFLAGS): Set it to "-d" so that we get
the .h header file.
(EXTRA_DIST): Removed aux-item-def.l and aux-item-def.y.
(MAINTAINERCLEANFILES): Removed aux-item-def.tab.h.
(lyskomd_SOURCES): Added aux-item-def-parse.y,
aux-item-def-parse.h and aux-item-def-scan.l.
(DISKOBJS): Removed aux-item-def.tab.c and aux-item-def.lex.c.
(aux-item-def.tab.c): Target removed. Rely on automake.
(aux-item-def.lex.c): Target removed. Rely on automake.
* src/server/aux-item-def-parse.y: Rename hack added. Don't
redefine yyin and yylineno, since the Lex file no longer uses
"%option prefix". Remove blank lines at end of file.
* src/server/aux-item-def-scan.l: Rename hack added. Include
aux-item-def-parse.h instead of aux-item-def.tab.h. Don't
redefine yylval and yyerror, and don't use "%option prefix" -- this
change makes it impossible to have multiple Lex scanners, but on
the other hand, it makes it possible to use automake.
* src/server/aux-item-def.l: Renamed aux-item-def-scan.l.
* src/server/aux-item-def.y: Renamed aux-item-def-parse.y.
Added some missing files to the distribution.
* doc/Makefile.am (EXTRA_DIST): Added IDEAS.
* src/include/Makefile.am (noinst_HEADERS): Added kom-config.h.
* src/server/Makefile.am (EXTRA_DIST): Added prot-a-is-legal-fnc.awk.
* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
renumber.el, l2g.0/*.exp, lyskomd.0/*.exp,
lyskomd.0/summarize.sh, lyskomd.0/aux-items.conf,
lyskomd.0/aux-items.cov and lyskomd.0/aux-items.leaks.
1999-04-02 Per Cederqvist <ceder@gratia>
Make it possible to run "make check" even when not building in
srcdir.
* src/server/testsuite/config/unix.exp: (lyskomd_start): Run the
test suite in the build directory. Look for files relative to
$srcdir or top_srcdir so that they are found properly.
(aux_item_default_conf_file): Use $top_srcdir to get a full path.
* src/server/testsuite/config/leaks.exp: Look for exp files in
$srcdir.
* src/server/testsuite/lyskomd.0/04.exp: Likewise.
* src/server/testsuite/lyskomd.0/05.exp: Likewise.
* src/server/testsuite/lyskomd.0/06.exp: Likewise.
* src/server/testsuite/lyskomd.0/admin-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks00.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks01.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks02.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks03.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks04.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks05.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks06.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks07.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks08.exp: Likewise.
* src/server/testsuite/lyskomd.0/leaks99.exp: Likewise.
Fix broken tests.
* src/server/testsuite/lyskomd.0/01.exp: The test could fail due
to bad timing. Fixed.
Makefile fixes.
* src/server/testsuite/config/Makefile.am (EXTRA_DIST): Added
leaks.exp.
(MOSTLYCLEANFILES): Added lyskomd-config.
1999-03-31 Per Cederqvist <ceder@gratia>
Fix bugs in "make dist".
* doc/Makefile.am (EXTRA_DIST): Removed Makefile.src.
Dead code removal.
* src/server/local-to-global.c (find_block_index_key): Blocks can
never be completely empty. Code simplified accordingly.
(l2g_append): Likewise.
(l2gi_next): Likewise.
* src/server/ram-parse.c (fparse_info_2): Unreachable code removed.
Increase coverage of local-to-global.c.
* src/server/testsuite/l2g.0/11.exp: New file.
1999-03-28 Per Cederqvist <ceder@link>
* TODO: Updated according to priorization made by me and David
Byers.
1999-03-28 David Byers <davby@ida.liu.se>
* src/server/simple-cache.c (cached_conf_exists): Test existance
in small_conf_arr. Don't go to disk.
(cached_delete_conf): Free the associated small_conf_stat and set
small_conf_arr[x] to NULL.
* run-support/aux-items.conf: Restrict creation of mx-author to
creation time.
1999-02-06 Per Cederqvist <ceder@gratia>
* configure.in: Fixed a syntax error introduced yesterday.
1999-02-05 Per Cederqvist <ceder@gratia>
Don't produce meaningless warnings.
* configure.in: Remove -Wshadow and -Wcast-qual since they give
too many false warnings and are of limited use.
Get rid of some warnings.
* src/include/kom-types.h (Version_info_internal): const
qualifiers added.
* src/server/Makefile.am (version-info.c): Added const qualifier
to kom_version_info.
* src/server/version-info.h (kom_version_info): Added const
qualifier.
Don't use the wrong member of a union.
* src/server/prot-a.c (prot_a_reply): Emit
res->membership_list_old, not res->membership_list, when the
return type is rt_membership_list_old.
Remove the L2g_iterator_as_text_list typedef.
* src/server/text.c (get_map): Use L2g_iterator
instead of L2g_iterator_as_text_list.
* src/server/prot-a-output.h, src/server/prot-a-output.c
(prot_a_output_l2g_iterator_as_text_list): Use L2g_iterator
instead of L2g_iterator_as_text_list.
* src/server/person.c (get_created_texts): Use L2g_iterator
instead of L2g_iterator_as_text_list.
* src/server/connections.h (Result_holder): The
l2g_iterator_as_text_list member is now of type L2g_iterator
instead of the typedef L2g_iterator_as_text_list.
* src/include/services.h (get_created_texts): Use L2g_iterator
instead of L2g_iterator_as_text_list.
(get_map): Likewise.
* src/include/kom-types.h (L2g_iterator_as_text_list): Typedef
removed.
1999-02-02 David Byers <davby@ida.liu.se>
* src/server/aux-items.h (Aux_item_validation_data): New type.
(Aux_item_validation_function): New type.
(Aux_item_validator): New type.
1999-01-28 David Byers <davby@ida.liu.se>
* src/server/prot-a-parse.c (prot_a_parse_aux_item_list): Check
array size for -1. Check allocation of result.
* src/server/person.c (mark_text): Return no-such-text if the user
is not allowed to read the text (just like get-text-stat)
(set_user_area): Return UNDEF_PERS, not UNDEF_CONF.
* src/include/kom-errno.h (enum kom_errno): Define
KOM_PERS_EXISTS.
* src/server/person.c (create_person_generic): Return
KOM_PERS_EXISTS instead of KOM_CONF_EXISTS
1999-01-27 David Byers <davby@ida.liu.se>
* src/server/conference.c (do_create_conf): Don't just DIE if we
fail to create a conference. Log a message and return an error.
* src/server/person.c (create_person_generic): Don't just DIE if
we fail to create a conference. Log a message and return an error.
* src/server/ram-output.c (foutput_conference_2): Output a space
before the l2g mapping.
(foutput_person_2): Same thing here.
1999-01-26 David Byers <davby@ida.liu.se>
* src/server/person.c (create_person_old): Add parameter in call
to create_person.
(create_person): Added flags parameter.
(create_person_generic): Set the personal flags from the
parameter.
(set_pers_flags): New function to set the personal flags of a
person.
* src/server/fncdef.txt: Added set_pers_flags and added pers_flags
argument to create_person.
1999-01-25 David Byers <davby@ida.liu.se>
* doc/hacking.texi (Parsing Bit Fields): New section.
* src/server/prot-a-parse.c (prot_a_parse_priv_bits): New
function. New model for parsing bit fields that's really tolerant
about the token length. Anything from one bit and up is cool.
* src/server/prot-a-parse.h: Added prot_a_parse_priv_bits.
* src/server/connections.h: Added pers_flags to Connection.
* src/server/internal-connections.c (init_connection): Initializer
pers_flags field.
* src/server/prot-a-parse-arg-c.awk: Added pers_flags.
* src/server/call-switch.awk: Added pers_flags.
* src/server/person.c (set_user_area): Return KOM_UNDEF_CONF if
the person is secret.
* src/server/conference.c (get_conf_stat_old): Check access with
<= none and not == none.
(get_conf_stat_older): Same here.
* src/server/person.c (get_person_stat): Check access with <= none
and not == none
(get_person_stat_old): Same here.
(get_created_texts): Same here.
(map_created_texts): Same here.
1999-01-24 David Byers <davby@ida.liu.se>
* src/server/connections.c (login_request): Use param.nologin_file
instead of hard-coded path.
* doc/lyskomd.texi (Parameters): Documented Nologin file
* src/server/server-config.c: Added "Nologin file"
* src/server/param.h: Added nologin_file.
* src/server/conference.c (legal_name): Return bad-name on attempt
to use null string.
* src/server/log.c (restart_kom): Do normal exit if AVOID_ABORTS
is defined.
* acconfig.h: Added AVOID_ABORTS
* configure.in: Define AVOID_ABORTS when the user says --with-gcov
* src/server/conf-file.c (configure_line): Complain about too many
assignments at one too many assignments, not two too many.
* src/server/simple-cache.c (sync_part): Don't save if
param.never_save is set.
* src/server/server-config.c: Compile in never_save always.
1999-01-23 David Byers <davby@ida.liu.se>
* src/server/session.c (set_client_version): Use client_data_len
as max length for client version and client name.
* doc/lyskomd.texi (Parameters): Documented max client data
length.
* src/server/param.h: Added client_data_len.
* src/server/server-config.c: Added max client data length.
* src/server/text.c (submit_to): Set err-stat to the last conf in
the chain, not zero, if we hit the top of the super-conf chain
without finding something we can write to.
(sub_recipient): Check for access to the supposed recipient before
checking if it is a recipient. This plugs two leaks of secret
information.
(add_footnote): Set err-stat to footnote when failing because of
not being author to footnote.
(check_comm): Don't set err-stat. The caller will.
1999-01-22 David Byers <davby@ida.liu.se>
* src/server/text.c (create_text_check_misc): Return no-such-text
if no read access to footnoted text. Check read access before
checking anything else to avoid leaking secret information.
* src/server/membership.c (fast_access_perm): fast_access_perm
always returned read_protected for rd_prot conferences, even if
the viewer was the supervisor. Fixed.
* src/server/text.c (text_read_access): If an open conf is a bcc
recpt, anyone can see the text.
* doc/Protocol-A.texi (add-recipient): Added error code
access-denied.
* src/server/text.c (create_text_check_misc): Don't set
kom_errno if it was set in submit_to.
(submit_to): Set kom_errno here instead of in the caller.
(add_recipient): Return KOM_ACCESS if we are not allowed to write
to the target conference.
* doc/Protocol-A.texi (Error Codes): Fxied speling error
1999-01-21 David Byers <davby@ida.liu.se>
* src/server/text.c (recp_sent_by): Fixed error message.
(do_create_text): Fixed speling erorr
* doc/lyskomd.texi (Parameters): Added documentation for max
conferences and max texts.
1999-01-19 David Byers <davby@ida.liu.se>
* src/server/text.c (do_create_text): Pass time to
create_text_add_miscs to ensure correct timestamp.
(create_text_add_miscs): Set last_written to correct
timestamp.
* src/server/conf-file.c (assign_ulong): New function.
* run-support/config: Added max_confs and max_texts to default
config file.
Remove compiled-in size limits.
* src/server/dbck-cache.c (init_cache): Dynamically allocate
pers_arr, conf_arr, text_arr and name_list.
* src/server/dbck.c: Dynamically alloc person_scratchpad in
init_person_scratchpad.
* src/server/simple-cache.c (init_cache): Allocate the
small_conf_arr.
(cached_create_conf): Use param.max_conf, not MAX_CONF
(cached_create_text): Use param.max_text, not MAX_TEXT
(init_cache): Use param.max_conf and param.max_text, not MAX_CONF
and MAX_TEXT
* src/server/aux-items.c: Moved initialization of sent_at to
prepare_aux_item_list from other functions.
* src/server/log.h: Changed names from log to kom_log to avoid
shadowing log in math.h.
1999-01-18 David Byers <davby@ida.liu.se>
* src/server/testsuite/config/unix.exp (suspend_client): New
function. Suspends reading from lyskomd.
(resume_client): New function. Resumes reading.
* src/server/testsuite/.cvsignore: Added .da, .bb, .bbg and .da
files.
* src/libraries/libansi/.cvsignore: Added .da, .bb, .bbg and .da
files.
* src/libraries/libmisc/.cvsignore: Added .da, .bb, .bbg and .da
files.
1999-01-17 David Byers <davby@ida.liu.se>
* src/server/conference.c: Don't allow change to forbid_secret if
there are secret members.
* src/server/testsuite/tcpconnect.py (fdset): Added command
#suspend socket to stop the relay from reading from the socket, to
simulate a communications failure of sorts. Added #resume socket
to reopen communications.
1999-01-16 David Byers <davby@ida.liu.se>
* src/server/debug.c: New file.
(get_memory_info): Moved here from admin.c.
* src/server/Makefile.am (ATOMS): Added debug.c
* src/server/person.c (create_person_generic): Don't autologin
unless do_auto_login is true
(create_person_old): Set do_auto_login to true in call to
create_person_generic.
(create_person): Set do_auto_login to false in call to
create_person_generic.
* src/server/connections.c (logout_client): Send async logout if
the session is not logged in.
1999-01-15 David Byers <davby@ida.liu.se>
* src/server/send-async.c (async_new_name): Send new-name only to
clients with the appropriate privileges.
* src/server/membership.c (fast_access_perm): Only check priv bits
if the viewer is ACTPERS or ACT_P
(access_perm): Ditto.
* src/server/manipulate.h (ENA_C): New macro.
* configure.in: New argument --with-optimization
* src/server/conference.c (legal_name): Set err_stat when
returning KOM_LONG_STR.
* src/server/text.c (do_create_text): Set err_stat when returning
KOM_LONG_STR.
* src/server/aux-item-def.y: Never add disabled items to the
definition list.
* src/server/admin.c (send_message): Set err_stat to
param.broadcast_len.
1999-01-14 David Byers <davby@ida.liu.se>
* src/server/connections.h: Added Memory_info to Res_type and
Result_holder to be compiled if DEBUG_CALLS is defined.
* src/server/admin.c (debug_info): New function to get memory
usage stats.
* src/server/prot-a.c (prot_a_reply): Output memory_info
* configure.in: Check for mallinfo if we do debug calls.
Substitute EFENCE=1 if we use efence.
* src/server/session.c (who_is_on): Changed for loops to while
loops to deal with new semantics of session 0 and to make the code
clearer. (who_is_on_ident): Ditto. (who_is_on_dynamic): Ditto.
(who_is_on_old): Ditto.
* src/server/internal-connections.c (get_conn_by_number): Always
interpred session 0 as the current session.
(traverse_connections): Explicit check for session_no == 0 since
change in get_conn_by_number.
* src/server/session.c (disconnect): disconnect(0) disconnects the
current session
Did some work on mail import and export (that jsk should have
taken care of. Grrrr....)
* doc/Protocol-A.texi (Predefined Aux-Item Types): Rewrote
documentation for mail import and export aux-items. Wrote a
chapter on mail import and export.
* run-support/aux-items.conf: Added aux-items for mail import and
export.
* doc/Protocol-A.texi: Removed all @codes surrounding
cross-references since texinfo chokes on them.
* doc/hacking.texi (Notes for fncdef.txt): Added notes on
fncdef.txt.
1999-01-13 David Byers <davby@ida.liu.se>
Handle #ifdef/#endif and empty lines in fncdef.txt
* src/server/fncdef.txt: Added debug_info. This call does NOTHING
at the moment. It is just a proof of concept. It will do stuff
later.
* src/server/prot-a-parse-arg-h.awk: Handle #ifdef and #endif and
empty lines.
* src/server/fnc-def-init.awk: Ditto.
* src/server/prot-a-is-legal-fnc.awk: Ditto.
* src/server/call-switch.awk: Ditto.
* src/server/prot-a-parse-arg-c.awk: Ditto.
* src/server/com-h.awk: Ditto.
* acconfig.h: Added DEBUG_CALLS
* configure.in: Added option --with-efence to link with efence.
Added option --with-debug-calls to define DEBUG_CALLS when
compiling.
Arranged things so we have to put a call number into the
fncdef.txt file. This makes call numbers more explicit. It is also
possible to have non-contiguous call numbers.
* src/server/prot-a.c (prot_a_parse_packet): Use function_index
field of connection to access parsers etc.
* src/server/connections.c: Added num_fnc_defs
* src/server/prot-a-parse-arg-h.awk: Updated for new format.
* src/server/connections.c (dump_statistics): Changed the format
of the statistics file to output function number before the call
number.
* src/server/connections.h: New field function_index
Added function field to Fnc_descriptor.
* src/server/call-switch.awk: Updated for new format in fncdef.txt
* src/server/com-h.awk: Updated for new format in fncdef.txt
* src/server/prot-a-parse-arg-c.awk: Updated for new format in
fncdef.txt.
* src/server/prot-a.c (prot_a_is_legal_fnc): Removed hard-coded
switch and replaced it with include of prot-a-is-legal-fnc.incl
* src/server/prot-a-is-legal-fnc.awk: New function.
* src/server/Makefile.am: Add rules for prot-a-is-legal-fnc.incl
1999-01-12 David Byers <davby@ida.liu.se>
* src/server/testsuite/lyskomd.0/03.exp: Updated membership tests.
* src/server/testsuite/lyskomd.0/05.exp: Updated membership tests.
* src/server/membership.c (do_get_membership): Set the position
field in the returned structure.
(locate_membership_and_position): Removed.
(locate_membership): Set the position field in the membership.
* src/server/memory.c (init_membership): Init position field.
* src/include/kom-types.h: Removed Extended_Membership. Added
position field to Membership.
* src/server/connections.h: Removed Extended_Membership.
* src/server/prot-a.c (prot_a_reply): Removed
rt_extended_membership.
* src/server/prot-a-output.c (prot_a_output_membership): Output
membership position.
1999-01-08 David Byers <davby@ida.liu.se>
* db-crypt/db/lyskomd-data: Updated database with keep_commented
field.
1999-01-07 David Byers <davby@ida.liu.se>
* src/server/person.c (create_person_generic): Initialize
keep_commented.
* src/server/memory.c (copy_conference): Copy keep_commented.
(init_conference): Initialize keep_commented.
* src/server/dbck.c (delete_misc): Moved initialization of ready
to avoid spurious compiler warning.
* src/server/text.c (do_delete_misc): Moved initialization of
ready to avoid spurious compiler warning.
* src/server/simple-cache.c: Changed sync_next to unsigned to get
rid of compiler warnings.
(save_one_conf): Output sync_next as unsigned.
(save_one_text): Ditto.
(init_cache): Move initialization of done, read_text_no and
read_conf_no to avoid spurious compiler warning.
(init_cache): Initialize c for same reason.
* src/server/cache-node.c: Added initializer for s.snapshot in
EMPTY_CACHE_NODE.
* src/server/cache-node.h: Removed saved_sirty [sic] flag from
cache_node. It wasn't used anywhere.
* src/include/rcs.h (USE): Use __typeof__ to avoid compiler
warnings. This macro only does something when __GCC__ is two or
more, in which case __typeof__ exists, so it should be safe.
* src/server/server-config.c: Added default_keep_commented to
parameters.
* src/server/param.h: Added default_keep_commented to kom_par.
* src/server/conference.c (do_create_conf): Initialize
keep_commented
* doc/lyskomd.texi (Parameters): Documented Default keep commented
nice.
* src/include/services.h: Declare set_keep_commented.
* src/server/conference.c (set_keep_commented): New function.
* src/server/fncdef.txt: Added set_keep_commented.
* src/server/prot-a-output.c (prot_a_output_conference): Output
keep_commented after nice.
* src/server/ram-parse.c (fparse_conference_2): Parse
keep_commented.
* src/include/kom-types.h: New field keep_commented.
* src/server/ram-output.c (foutput_conference_2): Output
keep_commented.
1999-01-01 Per Cederqvist <ceder@gratia>
Use NO_TIME instead of 0.
* src/server/memory.c (init_membership): Use NO_TIME instead of 0.
1998-12-31 Per Cederqvist <ceder@lysator.liu.se>
Avoid pty buffer size overflow in the test suite.
* src/server/testsuite/lyskomd.0/03.exp: Split long lines so that
at most approximately 250 bytes are sent via a pty. Many
operating systems have a limit of approximately 256 bytes per
line.
Fix test suite typo.
* src/server/testsuite/config/leaks.exp (check_usage): Fixed a
typo: it is an error if the number of strings is use change, not
if they stay the same.
Ignore some generated files.
* src/server/testsuite/.cvsignore: Ignore lyskomd.*.base,
lyskomd.*.usage and usage-base.tmp.
* .cvsignore: Ignore config.h, config.h.in, stamp-h and
stamp-h.in.
1998-12-30 David Byers <davby@ida.liu.se>
* src/server/aux-items.h: Removed ADD_AUX_ITEM macro.
* src/server/aux-items.c (aux_inherit_items): Fixed memory leak.
* src/server/ramkomd.c (free_kom_info): New function.
(main): Call it so that memory usage reported at end of session is
not dependent on the length of the aux-item list attached to
kom_info since that messes up testing for memory leaks.
* doc/lyskomd.texi: Added this file. Finished writing it too.
1998-12-29 David Byers <davby@ida.liu.se>
* src/server/testsuite/config/unix.exp (lyskomd_start): Added
optional third argument for stuff to put at the end of the config
file.
* src/server/prot-a-send-async.c (prot_a_async_new_membership):
Send the correct header.
* src/server/membership.c (add_member_common): Added calls to
send_async_new_membership.
(send_async_new_membership): Send message to the right recipients.
1998-12-28 David Byers <davby@ida.liu.se>
* src/server/membership.c (add_member_old): Don't set invitation
bit here. It is dealt with in add_member_common.
(do_change_priority): Don't change priority to zero if we are
being called from old functions. Just fake the passive bit.
(locate_membership_and_position): Return the correct position of
the membership.
1998-12-27 David Byers <davby@ida.liu.se>
* doc/Protocol-A.texi (Error Codes): Added
invalid-membership-type.
1998-12-26 David Byers <davby@ida.liu.se>
* doc/man/lyskomd.8 (value): Documented regexps use collate
table.
* src/server/param.h: Added regex_use_collate_table.
* src/server/server-config.c: Added regexps use collate table.
* src/server/regex-match.c (lookup_regexp): Set translation table
for regex according to regex_use_collate_table option.
* src/server/manipulate.h: New function declaration.
* src/server/membership.c (locate_membership_and_position): New
function.
(locate_membership): Use it.
* src/server/person.c (do_query_read_texts): New function.
(query_read_texts_old): Use it. (query_read_texts): Use it.
* src/server/prot-a-output.h(prot_a_output_extended_membership):
New function declaration.
* src/server/prot-a-output.c (prot_a_output_extended_membership):
New function.
* src/server/prot-a.c (prot_a_reply): Added
rt_extended_membership.
* src/include/kom-types.h: New type Extended_Membership.
* src/server/connections.h: Added extended_membership to
Result_holder. Added rt_extended_membership to Res_type
* src/include/services.h: Declare query_read_texts to take an
Extended_Membership
* doc/Protocol-A.texi (query-read-texts): Documented that this
function returns the position as well as the membership.
1998-12-25 David Byers <davby@ida.liu.se>
* README: Updated clients information.
* src/server/membership.c (set_membership_type): Removed F-word
from comment. Inserted F-abbreviation instead :-)
* src/server/conference.c (get_uconf_stat): Removed FIXME after
fixing fast_access_perm.
* src/server/membership.c (fast_access_perm): Set kom_errno if we
can't find the conference conf_no.
* src/server/membership.c (do_get_members): Don't filter secret
memberships if we have privilege bits set.
* doc/Protocol-A.texi (Error Codes): Fixed error in documentation
of secret-public
1998-12-24 David Byers <davby@ida.liu.se>
* src/server/aux-items.c (system_add_aux_item_list): Call add
triggers
(check_delete_aux_item_list): Return KOM_AUX_PERM if an item to
delete is mission. This is in accordance with the documentation.
* src/server/aux-items.h (INFO_OBJECT_TYPE): New constant.
1998-12-23 David Byers <davby@ida.liu.se>
* src/server/testsuite/lyskomd.0/03.exp: Updated test 1010 for
item 27.
Updated test 1017 for asyncs 16, 17 and 18
Updated test 1020 for asyncs 16, 17 and 18
Updated test 1022 for asyncs 16, 17 and 18
Updated test 1024 for asyncs 16, 17 and 18
In test 1032 updated async messages to show the bcc recpt. This is
because of the change to make bcc recpts visible to the creator
and to all when target is an open conference.
Added sleep 2 before test 1310. Otherwise test 1311 may fail since
one of the clients has not been idle for long enough (lyskomd is
OK.)
Updated test 1333 to not show deleted items
Similar in 1334, 1335 and 1339.
* src/server/testsuite/lyskomd.0/01.exp: Updated
query-predefined-aux-items test for item 27
1998-12-22 David Byers <davby@ida.liu.se>
* src/server/conf-file.c (MAXLINE): Increased line length limit to
1000 characters
1998-12-22 Per Cederqvist <ceder@gratia>
One more test.
* src/server/testsuite/lyskomd.0/03.exp: Test call 99.
1998-12-20 Per Cederqvist <ceder@gratia>
More tests.
* src/server/testsuite/lyskomd.0/03.exp: Test call 95-98.
Speed up regexp matching a little.
* src/server/regex-match.c (lookup_regexp): Attempt to allocate a
fastmap.
The invitation bit should not be set when a user himself joins a
conference.
* src/server/membership.c (add_member_old): Never set the
invitation bit when a user adds himself to a conference.
Avoid too long lines in the documentation.
* doc/Protocol-A.texi (modify-system-info): Remove whitespace to
avoid too long lines in the generated info file.
1998-12-17 David Byers <davby@ida.liu.se>
* src/server/testsuite/config/Makefile.am (lyskomd-config): Use
aux-items.conf in this directory instead of in run-support.
* src/server/text.c (modify_text_info): Call commit_aux_item_list.
* src/server/conference.c (modify_conf_info): Call
commit_auc_item_list.
* src/server/admin.c (modify_server_info): Call
commit_aux_item_list.
* src/server/aux-items.c (commit_aux_item_list): New function to
really delete aux_items.
1998-11-14 Per Cederqvist <ceder@gratia>
Fixed another uninitialized memory problem: the allow_anon,
reserved1, reserved2 and reserved3 bits of the Conf_type was not
always properly initialized.
* src/server/person.c (create_person_generic): Initialize
allow_anon, reserved1, reserved2, and reserved3.
* src/server/memory.c (init_conf_type): Initialize allow_anon,
reserved1, reserved2, and reserved3.
* src/server/prot-a-parse.c (prot_a_parse_conf_type): Let
allow_anon default to 1, not 0. We really should have a way to
let it default to unset, so that a set-conf-type that only
specifies four bits doesn't alter the remaining bits.
* src/server/testsuite/lyskomd.0/03.exp: Set allow_anon, and
expect it to be set. Test call 92-94.
1998-11-09 Per Cederqvist <ceder@gratia>
Fixed an uninitialized memory problem.
* src/server/memory.c (init_conference): Initialize highest_aux
and expire to 0.
* src/server/conference.c (do_create_conf): Initialize expire to 0.
Avoid symbols with global linkage.
* src/server/aux-items.c (aux_item_triggers): Now static.
One more test case.
* src/server/testsuite/lyskomd.0/03.exp: Test call 91.
1998-11-09 Per Cederqvist <ceder@gratia>
More test cases.
* src/server/testsuite/lyskomd.0/03.exp: Test calls 86-90.
Minor fixes to the documentation.
* doc/Protocol-A.texi (create-text): This call can never generate
the error ``anonymous-rejected''.
(create-anonymous-text): Avoid too long lines.
1998-10-22 Per Cederqvist <ceder@gratia>
More test cases.
* src/server/testsuite/config/unix.exp (extracting_expect): New proc.
* src/server/testsuite/lyskomd.0/03.exp: Test call 46-85.
* src/server/testsuite/renumber.el
(renumber-lyskom-send-simple-expect): Handle extracting_expect.
Only allow one call to set-client-version.
* src/include/kom-errno.h (KOM_CLIENT_IS_CRAZY): Old favourite
resurrected.
* src/server/session.c (set_client_version): Fail if the client
version already was set.
Allow set-info with motd_of_lyskom set to 0.
* src/server/admin.c (set_info): Allow motd_of_lyskom to be 0.
Fixed the error-status of find-previous-text-no.
* src/server/text.c (greater): Added const qualifier.
(find_previous_text_no): Fixed the returned error status.
* src/server/testsuite/lyskomd.0/01.exp: Adjusted to the error
status that is now returned by the bug-fixed find_previous_text_no.
Documentation fixes and updates.
* doc/Protocol-A.texi (send-message): Document that recipient 0
means that the message is sent to all sessions.
(get-last-text): Say that this relies on all texts being written
in chronological order.
(set-client-version): This call can only be used once per
session. It will return client-is-crazy if used twice.
(get-client-version): This was called "get-client-name".
(mark-text): Bogus example fixed.
(unmark-text): Bogus example fixed.
(lookup-z-name): The want-pers and want-confs arguments were
swapped in the function header.
(set-info): Document that lyskomd 1.9.0 erroneously returned
text-zero if MOTD was 0.
1998-10-17 Per Cederqvist <ceder@gratia>
More tests.
* src/server/testsuite/lyskomd.0/03.exp: Test call 30-45.
Fixed a memory corruption problem.
* src/server/memory.c (copy_conference): Fixed a memory corruption
problem that was introduced when Local_to_global was introduced.
(copy_person): Likewise.
(copy_text_stat): Added a const qualifier. Rewritten to decrease
the probability that the same kind of bug is introduced here, that
is, assign each field separately instead of assigning the entire
struct at once.
(copy_aux_item_list): Now static. Rewritten as above.
(coy_aux_item): Added const qualifier. Rewritten as above.
* src/server/kom-memory.h (copy-person): Added const qualifier.
(copy_text_stat): Likewise.
(copy_aux_item): Likewise.
(copy_aux_item_list): Removed (now static).
Minor fixes to the documentation.
* doc/Protocol-A.texi (Predefined Aux-Item Types): Fixed a Texinfo
syntax error.
(sync-kom): Fixed bugs in the example.
1998-10-16 Per Cederqvist <ceder@gratia>
More tests.
* src/server/testsuite/lyskomd.0/03.exp: Test call 27-29, 40.
1998-10-14 Per Cederqvist <ceder@gratia>
More test cases.
* src/server/testsuite/lyskomd.0/03.exp: Test calls 8-27, 50, 78.
* src/server/testsuite/lyskomd.0/summarize.sh: New file.
Fixed bug in mark_as_read.
* src/server/membership.c (adjust_read): Fixed a fence-post error
that was introduced when Local_to_global was introduced.
Clarify the documentation. Change the specification of
async-leave-conf.
* doc/Protocol-A.texi (delete-conf): State the mailboxes can be
removed.
(get-conf-stat-older): Document the mask argument.
(mark-text-old): Document that mark-type 0 is used to remove the
mark.
(async-leave-conf): This message is always sent to a person when
that person ceases to be a member of a conference, whatever the
reason is. The protocol specification used to say that it was
only sent when a person was forced to leave a conference. The
current wording makes more sense, and it was also the implemented
behavior, so update the specification rather than the program.
1998-10-12 David Byers <davby@anton9.ida.liu.se>
* src/libraries/libcommon/Makefile.am (INCLUDES): Added -DSERVER
as in src/server
1998-10-11 Jonas S Karlsson <jsk@lysator.liu.se>
Aux-info defined for import/export of emails.
These are preliminary. but will be improved.
* doc/Protocol-A.texi: email aux-infos x-XXX
1998-10-11 Per Cederqvist <ceder@lysator.liu.se>
Keep an extra copy of the database, just in case. Do some sanity
checking when copying file contents.
* src/server/simple-cache.c (pre_sync): Store the previous backup
file.
(copy_file): Abort if we cannot seek or read the file we copy
from. Abort if the value we read didn't end in a newline, start
with "T ", "C " or "P ", if the identity number in the data isn't
what we expected, or if it isn't followed by a space. This
change attempts to detect file damage as early as possible.
* src/server/server-config.c (parameters): Added "Backup file 2".
(read_configuration): Handle backupfile_name_2.
* src/server/ramkomd.c (init_data_base): Print backupfile_name_2.
* src/server/param.h (struct kom_par): Added backupfile_name_2.
* src/server/dbck-cache.c (cache_sync): Store the previous backup
file.
* doc/man/lyskomd.8: Added "Backup file 2".
Allow compaction of the text file even if there are errors in the
data base.
* src/server/dbck.c (main): Allow -g even if errors occured, but
only if the user confirms.
1998-10-11 Per Cederqvist <ceder@gratia>
More test cases.
* src/server/testsuite/lyskomd.0/03.exp: Test call 4-7.
1998-10-09 Per Cederqvist <ceder@signum.se>
Commit some Emacs support code for test script writers.
* src/server/testsuite/renumber.el: New file.
(renumber-lyskom-send-simple-expect): New function.
1998-10-08 Per Cederqvist <ceder@gratia>
More test cases.
* src/server/testsuite/lyskomd.0/03.exp: Test call 0, 1, 2 and 3.
* doc/Protocol-A.texi (login-old): The error-status indicates the
person number when invalid-password is returned.
1998-10-08 David Byers <davby@ida.liu.se>
* src/server/prot-a-output.c (prot_a_output_membership): Output
break_type.
* src/server/ram-output.c (foutput_membership_2): Output
break_type.
* src/server/ram-parse.c (fparse_membership_2): Parse break_type.
1998-10-07 David Byers <davby@ida.liu.se>
* src/server/text.c (recp_sent_by): New function.
(filter_secret_info): Let the sender of a bcc see a bcc and
let bccs to open conferences be visible to all.
1998-10-06 David Byers <davby@ida.liu.se>
* src/server/send-async.c (async_new_membership): New function.
(async_sub_recipient): Ditto.
(async_new_recipient): Ditto.
* src/server/prot-a-send-async.c (prot_a_async_new_membership):
New function.
(prot_a_async_sub_recipient): Ditto.
(prot_a_async_new_recipient): Ditto.
* src/server/text.c (send_async_add_recipient): New function.
(add_recipient): Send async-new-recipient
(send_async_sub_recipient): New function.
(do_sub_recpt): Send async-sub-recipient.
* src/server/membership.c (send_async_new_membership): New function.
(add_member_common): Send async-new-membership
1998-10-06 Per Cederqvist <ceder@gratia>
Document bcc-recpt. A created person is a member of his mailbox.
* doc/Protocol-A.texi (The Misc-Info List): Document blank carbon
copies.
(create-person-old): Document that the new person will be a member
of his letterbox.
(create-person): Likewise.
Clarify the documentation about accept_async and make the
implementation conform to the documentation.
* src/server/session.c (accept_async): Don't accept 1, 2, 3, 4 or
10 (which are in the interval [0..ay_dummy_last) but not used).
Complain about the first rejected async number, not the last.
* doc/Protocol-A.texi (query-async): Added a reference to the
currently preselected asynchronous messages, since the example is
valid for lyskomd 1.9 but not lyskomd 2.0.
(Asynchronous Messages): Encourage clients to use accept-async
instead of trusting the defaults. State that the obsolete calls
may be non-existing.
More test cases.
* src/server/testsuite/lyskomd.0/03.exp: New file.
* src/server/testsuite/lyskomd.0/01.exp: Use read_versions instead
of duplicating code.
* src/server/testsuite/config/unix.exp (read_versions): New
function, extracted from ../lyskomd.0/01.exp.
Makefile improvements.
* src/server/testsuite/Makefile.am (MOSTLYCLEANFILES): Added *.sum
and *.log.
(check-l2g): New name for former target l2g_check.
(check-lyskomd): New name for former target lyskomd_check.
Remove some unused code.
* src/libraries/libcommon/kom-errno.c (kom_perror): Was
unused. Removed.
* src/include/config.h (kom_errout): Was unused. Removed.
1998-10-04 David Byers <davby@ida.liu.se>
* configure.in: Output to include/config.h
* src/server/aux-items.c (delete_aux_item_list): Call undelete
triggers.
* src/server/dbck.c: Moved BUGDECL to top level.
* src/server/internal-connections.c (init_connection): Cast in
comparisons to get rid of compiler warnings.
* src/server/text-garb.c: Moved BUGDECL to top level.
* src/server/person.c: Moved BUGDECL to top level.
* src/server/conference.c: Moved BUGDECL to top level.
* src/server/membership.c (do_change_priority): Only fake the
passive flag when fake_passive is true.
* src/server/connections.c (dump_statistics): Remove compiler
warnings by casting in comparisons.
* src/include/kom-types.h: Declared fields of
Version_info_internal const to get rid of compiler warnings (plus,
it makes sense.)
* src/server/simple-cache.c (cached_get_text): Remove compiler
warnings by casting in comparisons.
* src/include/server/smalloc.h (SMALLOC_MAGIC_FREE): Declare
constants as unsigned to avoid compiler warnings.
* src/server/ram-parse.c (fparse_string): Remove compiler warnings
by casting in comparisons.
* src/server/local-to-global.c (find_block): Removed const
declarations to get rid of compiler warnings (it was cast away
anyway.)
* src/libraries/libcommon/kom-errno.c: Include kom-config
* src/server/admin.c: Conditionally include config.h
* src/server/dbck.c (check_membership): Check duplicated info
between member and membership records. Redeclared mship param
as non-const.
1998-10-04 Per Cederqvist <ceder@lysator.liu.se>
* TODO: New file.
1998-08-31 Per Cederqvist <ceder@gratia>
Added more tests and documentation.
* doc/Protocol-A.texi (get-text): Uses the text-zero error code.
(get-text-stat-old): Likewise.
(get-text-stat): Likewise.
* src/server/testsuite/lyskomd.0/02.exp: Added tests for
get-text-stat and get-text-stat-old. Check that a text wiht one
public and one secret recipient is properly filtered.
1998-08-30 Per Cederqvist <ceder@lysator.liu.se>
query-predefined-aux-items was broken.
* src/server/aux-items.c (query_predefined_aux_items): Added a
missing statement so that the next link really is followed.
Added more tests and documentation.
* src/server/testsuite/lyskomd.0/01.exp: Added tests for requests
89-104.
* doc/Protocol-A.texi (get-conf-stat): Removed a note that said
that only the old bits of the Any-Conf-Type are returned by this
call.
(Protocol Requests): 47 is obsoleted by 104.
(get-created-texts): 47 is obsoleted by 104.
(set-membership-type): Document the login-first error code.
(local-to-global): Likewise.
(map-created-texts): New node. More documentation is needed here.
1998-08-29 Per Cederqvist <ceder@lysator.liu.se>
Introduce Aux-Item-Input in the protocol spec. (It is a subset of
Aux-Item.) Don't include aux_no in it.
* src/server/testsuite/lyskomd.0/00.exp: Don't send the aux_no
field in Aux-Item-Input data.
* src/server/prot-a-parse.c (prot_a_parse_aux_item): Don't expect
the aux_no field. Leave that field as garbage.
* doc/Protocol-A.texi (LysKOM Data Types): Added Aux-Item-Input.
Removed the '<10>' indicator in the Text-Stat declaration.
(create-text): Use type Aux-Item-Input for input parameters.
(create-anonymous-text): Likewise.
(create-conf): Likewise.
(create-person): Likewise.
(modify-text-info): Likewise.
(modify-conf-info): Likewise.
(modify-system-info): Likewise.
Clean up Protocol-A.texi.
* doc/Makefile.am (protocol-a.info): Don't allow tabs in the
document.
* doc/Protocol-A.texi: Write all types as "Foo-Bar", never
"Foo-bar". Don't use tabs.
(Notation): Be explicit about how types are written.
Misc documentation fixes.
* doc/Protocol-A.texi (who-is-on-ident): Corrected the return type
to ARRAY Who-Info-Ident.
(modify-system-info): Changed the type of the times-to-delete
argument from the undefined type Number-List to ARRAY Aux-No.
(set-info): This accepts an Info-Old, not an Info.
1998-08-29 Per Cederqvist <ceder@gratia>
Fixed a memory problem in get_collate_table.
* src/server/admin.c (get_collate_table): The result contains
garbage on entry, so don't call s_clear() on it.
Added more tests and documentation.
* src/server/testsuite/lyskomd.0/01.exp: Read $top_srcdir/versions
instead of ../version.incl, so the script gets all the versions.
Added tests for requests 63-88.
* src/server/testsuite/Makefile.am (site.exp): Depends on
Makefile. Set top_srcdir, but not srcdir. (srcdir can still be
used in the test scripts, since runtest sets it when the --srcdir
option is used.)
* doc/Protocol-A.texi (LysKOM Data Types): The invisible bit is
always set for sessions where no-one is logged on.
(who-is-on-dynamic): Likewise.
(set-info): The version number was missing from the example.
(create-conf): Indentation fixes.
1998-08-28 David Kgedal <davidk@lysator.liu.se>
* doc/Protocol-A.texi: Cleaned up the call definitions. Removed
all type synonyms for ARRAY types. Conference had an extra 'type'
field.
1998-08-28 Per Cederqvist <ceder@gratia>
Added more tests and documentation.
* src/server/testsuite/lyskomd.0/01.exp: Added tests for requests
51-62.
* doc/Protocol-A.texi (LysKOM Data Types): The order of the
elements in Who-Innfo-Old was wrong. The same bug existed at
least as far back as in the prot-A.txt file that was distributed
with the 1.7.0 server. I find it better to change the
documentation than the code.
(create-person-old): Document the auto-login feature.
(who-is-on): Clarify which sessions that are returned.
(get-unread-confs): Clarify that this request may return extra
conferences. This request may not be made before you log in.
1998-08-27 Per Cederqvist <ceder@gratia>
Added more tests and documentation.
* src/server/testsuite/lyskomd.0/01.exp: Added tests for requests
42-50.
* doc/Protocol-A.texi (LysKOM Data Types): Removed Member-Old and
Member-List-Old.
(shutdown-kom): exit-val is an argument to the request, not the
result from the request.
(get-members-old): Simplified the return value to "ARRAY Pers-No"
instead of "Member-List-Old". Explicitly state that the returned
list is truncated if there are too few members of the conference.
1998-08-25 Per Cederqvist <ceder@lysator.liu.se>
The request 36=get-info was broken.
* src/server/fncdef.txt (get_info_old): Returns an info_old, not
an info.
Added more tests and documentation.
* src/server/testsuite/lyskomd.0/01.exp: Added tests for requests
32-41.
* doc/Protocol-A.texi (LysKOM Data Types): Document the
aux-item-list part of the Info structure.
(who-is-on-old): Document that the returned list contains only
sessions that are logged in visibly.
1998-08-25 Per Cederqvist <ceder@gratia>
Documentation fixes: async-login was wrong.
* doc/Protocol-A.texi (LysKOM Data Types): Added Any-Conf-Type to
the type index.
(get-text): Never fails with login-first. The no-such-text error
is used when the user isn't logged in.
(get-text-stat-old): Likewise.
(get-text-stat): Likewise.
(async-login): This async message includes a session number.
More test cases added.
* src/server/testsuite/config/unix.exp (any_num): New constant.
(lyskomd_start): Increase the timeout around the start of lyskomd,
since it can take quite a while on slow computers.
* src/server/testsuite/lyskomd.0/01.exp: Added tests of more requests.
* src/server/testsuite/lyskomd.0/02.exp: New file.
* src/server/testsuite/Makefile.am (lyskomd_check): Added a
missing quote character.
1998-08-23 Per Cederqvist <ceder@lysator.liu.se>
Fixed the documentation of 12=lookup-name.
* doc/Protocol-A.texi (LysKOM Data Types): Documented
Conf-List-Archaic.
(lookup-name): This request returns a Conf-List-Archaic, not a
Conf-No-List. Added an example.
1998-08-22 Per Cederqvist <ceder@lysator.liu.se>
Document more of the used error codes.
* doc/Protocol-A.texi (get-person-stat-old): Added error code
`login-first'.
(login): Added error code `conference-zero'.
(Error Codes): Renamed `illegal-password' to `invalid-password',
which is the name the rest of the document uses.
More test cases.
* src/server/testsuite/lyskomd.0/01.exp: New test suite.
* src/server/testsuite/config/unix.exp (lyskomd_start): Create a
fresh database before starting lyskomd.
* src/server/testsuite/Makefile.am (lyskomd_check): Don't create
the database before running the lyskomd tests.
Fixed bugs from the Local_to_global introduction.
* src/server/membership.c (adjust_read): Fixed a fencepost error
that was introduced 1998-07-26.
* src/server/ram-output.c (foutput_text_list): Handle empty text
lists properly.
* src/server/prot-a-output.c (prot_a_output_person): Handle empty
Local_to_global structures properly.
(prot_a_output_conference): Likewise.
(prot_a_output_conference_old): Likewise.
* src/server/ram-output.c (foutput_text_list): Handle empty text
lists that once was non-empty properly.
Added indices to the protocol specification.
* doc/Protocol-A.texi: Added a Request Index and a Type Index.
Eliminated a race condition in the test case.
* src/server/testsuite/config/unix.exp (lyskomd_death):
Synchronize with the lyskomd process so that it dies at a proper
time.
* src/server/ramkomd.c (main): Don't terminate until a
confirmation is read on stdin when running under DejaGnu.
Implemented map_created_texts.
* src/include/services.h (map_created_texts): New function.
* src/server/person.c (map_created_texts): New function.
* src/server/fncdef.txt: Added map_created_texts.
* src/server/prot-a.c (prot_a_is_legal_fnc): Added
call_fnc_map_created_texts.
* src/server/testsuite/lyskomd.0/00.exp: Added test cases for
map_created_texts.
1998-08-16 Per Cederqvist <ceder@lysator.liu.se>
Documented all undocumented Aux-Items.
* doc/Protocol-A.texi (Predefined Aux-Item Types): Documented
aux-items 13, 14 and 15.
1998-08-14 Per Cederqvist <ceder@signum.se>
The cache tried to free person, text and conference 0 during
server shutdown.
* src/server/simple-cache.c (free_all_cache): Don't attempt to
access Pers_no, Conf_no or Text_no 0.
(get_conf_node): Fail if the argument is less than 1.
(get_pers_node): Likewise.
(get_text_node): Likewise.
(traverse_person): Unused function; don't compile it.
* run-support/aux-items.conf (creating-software): New aux-info.
1998-08-10 Per Cederqvist <ceder@gratia>
Ported the test suite to DejaGnu 1.2.
* src/server/testsuite/config/unix.exp (lyskomd_start): Added
missing global declarations.
(l2g_start): Likewise.
1998-08-10 Per Cederqvist <ceder@signum.se>
Typo in a Makefile.am fixed.
* src/server/testsuite/config/Makefile.am (lyskomd-config): Added
a missing quote.
1998-08-09 Per Cederqvist <ceder@lysator.liu.se>
Fixed bugs in get_created_texts.
* src/server/person.c (get_created_texts): Fixed a fencepost error
and two other errors, all introduced 1998-07-26.
Test suite improvements.
* src/server/testsuite/lyskomd.0/00.exp: Added more tests. Added
tests for get-created-texts.
* src/server/testsuite/l2g.0/10.exp: New file.
* src/server/testsuite/config/unix.exp (l2g_stop): Send a quit
command to test-l2g, so that we can be sure that the test case
doesn't miss some unexpected final output from the test program.
(unanchored_expect): Fixed an error message.
* src/server/testsuite/test-l2g.c (main): Added 'q' (quit)
command.
Fixed more bugs in get_map.
* src/server/text.c (get_map): Set result.first_local_no correctly
if the map in the conference is completely empty.
* src/server/prot-a-output.c
(prot_a_output_l2g_iterator_as_text_list): Don't forget to emit
trailing zeroes in the text-list.
Document some previously undocumented behavior of get-map and
get-created-texts.
* doc/Protocol-A.texi (get-map): Document what happens when
attempting to retrieve texts before the start of the map.
(get-created-texts): Likewise.
The L2g_iterator sometimes iterated past the end of a bounded search.
* src/server/local-to-global.c (l2gi_searchsome): Set search_ended
correctly when the end is set so that the iterator will loop over
nothing, even though later texts exists.
Let automake generate the INSTALL file.
* README: Include the contents of the INSTALL file. This file
needs a major overhaul.
* mkmi: Remove INSTALL and expect automake to recreate it.
Removed GNU malloc. The integration was poor, to say the least,
and it was not generally an improvement to use GNU malloc.
* src/server/testsuite/Makefile.am: Removed references to gnumalloc.
* src/server/Makefile.am: Removed reference to gnumalloc.
* src/libraries/Makefile.am (SUBDIRS): Removed @GNUMALLOC@.
* INSTALL: Don't mention GNU malloc.
* configure.in: --with-gnu-malloc: flag removed. Don't substitute
GNUMALLOC. Don't define USE_GNU_MALLOC or USING_GNU_MALLOC.
Don't use the following that was only used because of GNU malloc:
SUNOS_LOCALTIME_BUG, getpagesize, memmove, AC_USG. Don't attempt
to create src/libraries/gnumalloc/Makefile.
* src/libraries/gnumalloc: All files in this directory removed.
Added sanity check to local_to_global.
* src/server/text.c (local_to_global): Check that the no_of_texts
argument isn't larger than 255.
1998-08-08 Per Cederqvist <ceder@lysator.liu.se>
Fixed a protocol error with async_deleted_text.
* src/server/prot-a-send-async.c (prot_a_async_deleted_text):
Fixed the size in the header. This emits 18 elements, not 16.
Minor documentation fixes.
* doc/aux-info.doc: Document dont-garb.
* doc/Protocol-A.texi: Spell checking performed. Some other minor
typos fixed. State that the aux-item read-confirm should only be
added after the user has acknowledged that he has read the text.
(accept-async): Moved some text that belonged here from the
query-async node. The error-status indicates the first offending
number, not the index of the first offending number, when
unknown-async is returnd.
Fixed bugs in get_map and local_to_global.
* src/server/text.c (get_map): Fixed a couple of fence errors.
(local_to_global): Using first_local_no==0 is an error. Fixed a
fence error.
* src/server/prot-a-output.c (prot_a_output_text_mapping): Emit
"0" or "1", not "48" or "49", as the later-texts-exists flag.
Fixed a bug that could cause much too much data to be written.
Fixed bugs and made improvements to the test cases for get_map and
local_to_global.
* src/server/testsuite/lyskomd.0/00.exp: Many bugs fixed. Several
tests added.
* src/server/testsuite/config/unix.exp (attach): New constant.
(line_leader): New variable.
(meta_line_leader): New variable.
(l2g_start): Set l2g_id, expect_active and expect_always.
(fix_expect_after): New proc.
(simple_expect): New argument: meta. Handle line leaders.
Removed tests for unexpected lines, which should now be handled
via expect_active.
(unanchored_expect): Added missing quotes.
(lyskomd_start): Handle attach. Set expect_active and
expect_always to something sane.
(client_start): Use tcpconnect.py and line leaders to make it
easier to debug the test cases. Set expect_active and
expect_always to something sane.
(talk_to): Handle l2g. Handle line leaders. Call
fix_expect_after.
(client_death): New proc.
* src/server/testsuite/tcpconnect.py: New file.
* src/server/testsuite/Makefile.am (../lyskomd): New target.
(lyskomd_check): Depend on ../lyskomd.
(site.exp): Added srcdir.
(EXTRA_DIST): Added tcpconnect.py.
* src/server/Makefile.am (all-recursive check-recursive): Depend
on lyskomd.
Read the file name of the "Aux-item definition file" from the
config file, not from the command line.
* src/server/testsuite/config/Makefile.am (lyskomd-config): Added
"Aux-item definition file".
* src/server/server-config.c (parameters): Added "Aux-item
definition file".
(AUX_DEF_FILE): Removed.
(read_configuration): Handle aux_def_file just like all the other
file names.
* src/server/ramkomd.c (initialize): Removed the aux_def_file
argument. All callers updated. Get the file of the aux_def_file
from the config file.
(main): Removed the -c and -a options. This reverts the change
from Sat Sep 13 15:07:32 1997. It is more consistent to get the
file name of the aux-def file from the config file. The -c option
was buggy anyhow.
* src/server/param.h (struct kom_par): Added aux_def_file.
* doc/man/lyskomd.8: Removed the -c and -c flags. Added "Aux-item
definition file".
* src/include/config.h (AUX_DEF_FILE): Constant removed.
Default to sending async_new_text_old and ay_leave_conf, but not
async_new_text, just as the documentation says.
* src/server/send-async.c (async_new_text_old): Use
prot_a_async_new_text_old, not prot_a_async_new_text.
* src/server/async.h (ASYNC_DEFAULT_MESSAGES): Added
ay_new_text_old instead of ay_new_text. Added ay_leave_conf.
Get rid of some compiler warnings.
* src/server/rfc931.c (get_real_username): Mark unused arguments.
* src/server/dbck-cache.c (cached_lock_person): Marked unused
arguments.
(cached_unlock_person): Likewise.
(cached_lock_conf): Likewise.
(cached_unlock_conf): Likewise.
1998-08-07 Per Cederqvist <ceder@signum.se>
Merged old uncommitted changes to prot-A.txt.
* doc/prot-A.txt: Error code 38=no-connect is no longer used.
Documented 85=get-collate-table. Typo fixes.
Facilitate testing of Local_to_global with Electric Fence.
* src/server/testsuite/config/unix.exp (efence): New constant.
(efence_blurb): New proc.
(l2g_start): Handle an efence-instrumented test program if the
global variable efence is true.
Improved the documentation on the config file.
* doc/man/lyskomd.8: Documented the values that you can pass to
bool config parameters.
1998-08-06 Per Cederqvist <ceder@lysator.liu.se>
Added the beginnings of a test suite for the complete lyskomd
binary.
* README: Talk a little about the test suite.
* src/server/testsuite/Makefile.am (l2g_check): Added --srcdir to
the runtest command line.
(lyskomd_check): New target.
* src/server/testsuite/Makefile.am (check): Added lyskomd_check.
* src/server/testsuite/lyskomd.0/00.exp: New file.
* src/server/testsuite/config/unix.exp:
(hollerith): New constant.
(maxint): New constant.
(clientport): New constant.
(muxport): New constant.
(unanchored_expect): Continue with the expect if an unexpected
line is detected.
(lyskomd_start): New proc.
(lyskomd_death): New proc.
(client_start): New proc.
(talk_to): New proc.
(holl): New proc.
* src/server/testsuite/config/Makefile.am (noinst_DATA): Added
lyskomd-config.
(lyskomd-config): New target.
Regenerate protocol-a.info automatically.
* doc/Makefile.am (protocol-a.info): Added an explicit rule
because Automake 1.3 fails to add it automatically.
1998-08-05 Per Cederqvist <ceder@lysator.liu.se>
Fixed the documentation for the local-to-global call.
* doc/Protocol-A.texi (LysKOM Data Types): Changed the name of the
type Local-To-Global_Result to Text-Mapping. All uses updated.
Implemented the local-to-global call.
* src/server/fncdef.txt: Added local_to_global.
* src/include/services.h (local_to_global): New function.
* src/include/kom-types.h (Text_mapping): New type.
* src/server/text.c (get_map): Fixed the type of the no_of_texts
argument.
(local_to_global): New function.
* src/server/prot-a.c (prot_a_reply): Handle rt_text_mapping.
(prot_a_is_legal_fnc): Handle call_fnc_local_to_global.
* src/server/prot-a-output.c (prot_a_output_text_mapping): New
function.
* src/server/prot-a-output.h: Likewise.
* src/server/connections.h (Res_type): Added rt_text_mapping.
(Result_holder): Added text_mapping.
1998-08-03 Per Cederqvist <ceder@lysator.liu.se>
Document the local-to-global call.
* doc/Protocol-A.texi (Articles): Refer to local-to-global instead
of get-map.
(LysKOM Data Types): Added subsection titled "Mapping Local to
Global Text Numbers".
(Protocol Requests): Mark get-map as obsolete, and refer to 103.
Added 103=local-to-global.
(get-map): This is superseded by local-to-global.
(accept-async): Fixed typo.
(local-to-global): New node.
1998-08-02 Per Cederqvist <ceder@lysator.liu.se>
Generate and install protocol-a.info.
* doc/Makefile.am (info_TEXINFOS): New target. Moved
Protocol-A.texi here.
(EXTRA_DIST): Moved Protocol-A.texi to info_TEXINFOS.
* mkmi: Remove scripts/texinfo.tex and expect automake to
regenerate it.
Minor syntactic documentation fixes.
* doc/Protocol-A.texi: Added @dircategory and @direntry commands.
(Protocol Requests): Added set-membership-type to the menu.
(set-membership-type): Minor typo fixed.
(Top): State that this is a draft, and that the version numbers
are wrong.
1998-07-27 Per Cederqvist <ceder@lysator.liu.se>
Fixed a pointer bug in Local_to_global.
* src/server/local-to-global.c (join_range): Fixed a bug where
a pointer that pointed to the old position of a reallocated block
was used.
1998-07-26 Per Cederqvist <ceder@lysator.liu.se>
dbck can now read database format 2.
* src/server/dbck-cache.c (init_cache): Handle database format 2.
Fix the bootstrap database.
* db-crypt/db/lyskomd-data: CONF-RECORD uses the Local_to_global
structure.
Remove all traces of the Text_list type.
* src/include/kom-types.h (Text_list): Removed.
* src/server/connections.h (Res_type): Removed rt_text_list.
(Result_holder): Removed text_list.
* src/server/prot-a-output.h (prot_a_output_text_list): Removed.
* src/server/prot-a-output.c (prot_a_output_text_list): Removed.
* src/server/prot-a.c (prot_a_reply): Don't attempt to handle
rt_text_list.
Code cleanup.
* src/server/aux-item-def.y: Fixed indentation of include statements.
* src/server/aux-item-def.lex.c: No longer kept under version
control.
Improve documentation.
* doc/server.extend: Updated.
Start using the Local_to_global structure.
* doc/lyskomd-database-format (DATABASE VERSION 2): CONF-RECORD
and PERS-RECORD uses the Local_to_global structure.
* configure.in: Added AC_C_INLINE.
* src/server/text.c (add_text_in_conf): Adjusted to the fact that
the texts member of Conference is now a l2g.
(do_sub_recpt): Likewise.
(set_loc_no): Removed.
(adjust_text_list): Removed.
(do_delete_text): Adjusted to the fact that the created_texts
member of Person is now a l2g.
(do_create_text): Likewise.
(get_map): The result argument now points to a
l2g_iterator_as_text_list instead of a Text_list. Adjusted to the
fact that the texts member of Conference is now a l2g.
* src/server/simple-cache.c (mark_conference_as_changed): Adjusted
to the fact that the texts member of Conference is now a l2g.
(setup_small_conf): Likewise.
* src/server/ram-parse.h (fparse_text_list): Removed.
* src/server/ram-parse.c (fparse_conference_2): Use l2g_read
instead of fparse_text_list.
(fparse_person_2): Likewise.
(fparse_text_list): The result argument now points to a
Local_to_global instead of a Text_list.
* src/server/ram-output.h (foutput_text_list): The text_list
argument is now a pointer to Local_to_global instead of a
Text_list.
* src/server/ram-output.c (foutput_person_0): Adjusted to new API
of foutput_text_list.
(foutput_person_2): Use l2g_write instead of foutput_text_list.
(foutput_conference_2): Likewise.
(foutput_conference_1): Adjusted to new API of foutput_text_list.
(foutput_conference_0): Likewise.
(foutput_text_list): The text_list argument is now a pointer to
Local_to_global instead of a Text_list. The generated output is
still the same.
(foutput_ulong): Eliminated a future buffer overrun. Cleaned up
the code.
* src/server/prot-a.c (prot_a_reply): Handle
rt_l2g_iterator_as_text_list.
* src/server/prot-a-output.h
(prot_a_output_l2g_iterator_as_text_list): New function.
* src/server/prot-a-output.c (prot_a_output_person): Adjusted to
the fact that the created_texts member of Person is now a l2g.
(prot_a_output_conference): Adjusted to the fact that the texts
member of Conference is now a l2g.
(prot_a_output_conference_old): Likewise.
(prot_a_output_l2g_iterator_as_text_list): New function which
emulates a Text_list.
* src/server/person.c (do_delete_pers): Adjusted to the fact that
the created_texts member of Person is now a l2g.
(get_created_texts): The return value is now an
l2g_iterator_as_text_list, not a Text_list. Adjusted to the fact
that the created_texts member of Person is now a l2g.
* src/server/memory.c (clear_text_list): Removed.
(copy_text_list): Removed.
(clear_conference): Adjusted to the fact that the texts member of
Conference is now a l2g.
(init_conference): Likewise.
(copy_conference): Likewise. Added const qualifier to the
argument.
(clear_person): Adjusted to the fact that the created_texts member
of Person is now a l2g.
(copy_person): Likewise.
(init_person): Likewise.
(init_text_list): Removed.
(copy_aux_item_list): Added const qualifier to the src argument.
* src/server/membership.c (add_rec_time): Adjusted to the fact
that the texts member of Conference is now a l2g.
(adjust_read): Likewise.
(mark_as_read): Likewise.
(check_membership): Likewise.
(set_unread): Likewise.
(set_last_read): Likewise.
* src/server/kom-memory.h (copy_conference): The argument is const.
(copy_aux_item_list): Likewise.
(init_text_list): Removed.
* src/server/fncdef.txt (get_map): Changed return type from
text_list to l2g_iterator_as_text_list.
(get_created_texts): Likewise.
* src/server/dbck.c (struct delete_list): New struct.
(delete_list_append): New static function.
(execute_deletions): New static function.
(check_misc_infos): Adjusted to the fact that the texts member of
Conference is now a l2g.
(adjust_text_list): Deleted.
(check_created_texts): The "created" argument now points to a
Local_to_global. Removed the check for "bad created_texts array"
since it can no longer be bad in that way.
(check_membership): Adjusted to the fact that the texts member of
Conference is now a l2g.
(check_texts_in_conf): The "tlist" argument now points to a
Local_to_global. Removed the check for "bad created_texts array"
since it can no longer be bad in that way.
* src/server/dbck-cache.c (cached_get_highest_local_no): Adjusted
to the fact that the texts member is now a l2g.
(cache_sync): Fixed type in some printf format strings.
* src/server/connections.h (Res_type): Added
rt_l2g_iterator_as_text_list.
(Result_holder): Added l2g_iterator_as_text_list.
* src/server/conference.c: (do_delete_conf): Adjusted to the fact
that the texts member is now a l2g.
* src/server/Makefile.am (DBCK): Added local-to-global.c.
(all-recursive, check-recursive): Require libcheck.a to be built.
* src/include/services.h (get_created_texts): Changed type of
the result to L2g_iterator_as_text_list.
(get_map): Likewise.
* src/include/kom-types.h (struct l2g_block_info): New forward
declaration.
(Local_to_global): New type.
(L2g_iterator): New type.
(L2g_iterator_as_text_list): New type.
(Conference): The texts member is now a Local_to_global, not a
Text_list.
(Person): The created_texts member is now a Local_to_global, not a
Text_list.
Fixes and improvements to the Local_to_global structure.
* src/server/local-to-global.h (L2G_BLOCKSIZE): Moved to
local-to-global.c.
(L2g_block_info): Likewise.
(Local_to_global): Likewise.
(l2g_copy): Switched placement of src and dest to match other copy
functions in the lyskomd code. Added const qualifier.
(l2g_lookup): Added const qualifier to the l2g argument.
(l2g_next_key): Likewise.
(l2g_compact): Removed.
(l2g_first_appendable_key): New function.
(l2g_delete_global_in_sorted): New function.
(l2g_dump): Switch placement of l2g and file arguments to match
other similar functions in the lyskomd code. Added const
qualifier.
(l2g_write): Likewise.
(l2g_read): Likewise.
(l2g_searchall): Added const qualifier.
(L2g_iterator): Moved to kom-types.h.
(l2gi_searchsome): Added const qualifier.
(l2gi_begin): New function.
(l2gi_end): New function.
* src/server/local-to-global.c: Include assert.h. Only include
stdlib.h if HAVE_STDLIB_H. Include stdio.h if we didn't get NULL
from stdlib.h. Inlucd lyskomd.h and server/smalloc.h.
(L2G_BLOCKSIZE): Moved here from local-to-global.h.
(struct l2g_block_info): Likewise.
(is_dense): New static function.
(is_empty): New static function.
(key_value): New static function.
(sparse_skip_deleted): New static function.
(sparse_locate_value): New static function.
(sparse_compact): New static function.
(add_block): Use srealloc instead of realloc. Don't initialize
start -- the caller is responsible for doing so.
(delete_block): Use sfree instead of free, and srealloc instead of
realloc.
(make_sparse): Don't change the value of start, since there is no
need to, and make_sparse may now be called on an empty block,
which would cause start to be set to a garbage value.
(find_block): Added a const qualifier to the return value and l2g
argument. Use key_value to simplify code.
(find_block_index_key): Added a const qualifier to the l2g
argument. Use helper functions to simplify the code. Use
sparse_skip_deleted so that the function never returns a deleted
key. Never return deleted keys in dense blocks either.
(join_range): New static function.
(join_blocks): New static function.
(l2g_init): Set first_unused to 1.
(l2g_clear): Use sfree instead of free. Set first_unused to 1.
(l2g_copy): Added const qualifier to the src argument. Simplified
code by using helper functions and relying on the fact that
calling l2g_append with a Text_no=0 is a no-op. Set first_unused
of the copy.
(l2g_append): Send a log message and do nothing if an attempt to
set a local number lower than first_unused is detected. Set
first_unused. Fixed the logic about when to add a new block, when
to compact the last block, and when to make it sparse. Simplify
code by using the helper functions.
(l2g_delete): Don't increase the zeroes counter if a zero is
deleted. Delete the entire block if it became empty. Attempt to
join this block to its neighbors. Compact the block if it was
sparse and contained too many deleted entries.
(l2g_lookup): Added const qualifier to the l2g argument. Don't
return uninitialized data. Use helper functions to simplify code
and make it slightly faster.
(l2g_next_key): Added const qualifier to the l2g argument.
(l2g_first_appendable_key): New function.
(l2g_delete_global_in_sorted): New function.
(l2g_compact): Removed.
(l2g_dump): Switch placement of l2g and file arguments to match
other similar functions in the lyskomd code. Added const
qualifier. Dump first_unused. Use helper functions to simplify
code.
(l2g_read): Switch placement of l2g and file arguments to match
other similar functions in the lyskomd code. Read first_unused.
Return a success indicator. Detect unexpected EOF conditions.
(l2g_write): Switch placement of l2g and file arguments to match
other similar functions in the lyskomd code. Write first_unused.
Use helper functions to simplify code.
(l2gi_searchall): Added const qualifier to the l2g argument.
Simplify code by calling l2gi_searchsome instead of duplicating
the code.
(l2gi_searchsome): Added const qualifier to the l2g argument.
Complain if the begin argument is less than 1. Don't forget to
initialize search_ended. Set beginval. Giving end==0 means that
the iterator should continue to the end of the set. Use helper
functions to simplify the code.
(l2gi_next): Use helper functions to simplify code. The iterator
is unlimited if endval==0.
(l2gi_begin): New function.
(l2gi_end): New function.
Improve the test suite with new tests of the Local_to_global
structure.
* src/server/testsuite/l2g.0/00.exp: The "C" command now takes the
arguments the other way around. Adjust the test case. Comments
added. Expect the "u" command to print first_unused.
* src/server/testsuite/l2g.0/02.exp: New file.
* src/server/testsuite/l2g.0/03.exp: New file.
* src/server/testsuite/l2g.0/04.exp: New file.
* src/server/testsuite/l2g.0/05.exp: New file.
* src/server/testsuite/l2g.0/06.exp: New file.
* src/server/testsuite/l2g.0/07.exp: New file.
* src/server/testsuite/l2g.0/08.exp: New file.
* src/server/testsuite/l2g.0/09.exp: New file.
* src/server/testsuite/config/unix.exp (l2g_stop): Added a wait
statement to avoid creating zombies.
(simple_expect): Added a missing space in a prompt regexp.
* src/server/testsuite/test-l2g.c (main): Removed the 'c' command
since l2g_compact no longer exists. Added the 'i' command that
tests iterators. Adjusted to the new API of l2g_dump, l2g_read
and l2g_write. Require an extra trailing newline after the
representation l2g_read expects when the 'r' command is used, and
produce a corresponding newline with the 'w' command. Renamed the
'p' command to 'w'.
1998-07-19 Per Cederqvist <ceder@lysator.liu.se>
Protocol buglets fixed.
* doc/Protocol-A.texi (Membership-Type, Session-Flags): Fixed
syntax error in the definition.
1998-07-12 Per Cederqvist <ceder@lysator.liu.se>
Build the program in the test suite.
* src/server/ramkomd.c (restart_kom): Moved to log.c.
* src/server/log.c (restart_kom): Moved here from ramkomd.c.
* src/server/Makefile.am (noinst_LIBRARIES): Added libcheck.a.
(libcheck_a_SOURCES): New library, used by the test suite.
* src/server/testsuite/Makefile.am (noinst_PROGRAMS): Added test-l2g.
(EXTRA_DIST): Removed test-l2g.c.
(test_l2g_SOURCES): Added test-l2g.c.
(test_l2g_LDADD): Added ../libcheck.a.
(../libcheck.a): New target.
Removed all old makefile template files.
* Makefile.src: Removed.
* doc/Makefile.src: Removed.
* doc/man/Makefile.src: Removed.
* run-support/Makefile.src: Removed.
* scripts/Makefile.src: Removed.
* src/Makefile.src: Removed.
* src/include/Makefile.src: Removed.
* src/include/server/Makefile.src: Removed.
* src/libraries/Makefile.src: Removed.
* src/libraries/gnumalloc/Makefile.src: Removed.
* src/libraries/libansi/Makefile.src: Removed.
* src/libraries/libcommon/Makefile.src: Removed.
* src/libraries/libisc-new/Makefile.src: Removed.
* src/libraries/libisc-new/src/Makefile.src: Removed.
* src/libraries/libmisc/Makefile.src: Removed.
* src/libraries/regex/Makefile.src: Removed.
* src/libraries/regex/doc/Makefile.src: Removed.
* src/libraries/regex/test/Makefile.src: Removed.
* src/server/Makefile.src: Removed.
* src/server/testsuite/Makefile.src: Removed.
Fixed "make dist".
* SERVER-RELEASE: Slightly updated.
* src/server/testsuite/config/Makefile.am: New file.
* src/server/testsuite/Makefile.am (SUBDIRS): Added config.
(EXTRA_DIST): Added .cvsignore and test-l2g.c.
(MOSTLYCLEANFILES): Added .gdbinit and site.exp.
* src/server/Makefile.am (EXTRA_DIST): Added .cvsignore,
ChangeLog.1, Magics, To-do, aux-item-def.l, aux-item-def.y,
call-switch.awk, com-h.awk, fnc-def-init.awk,
prot-a-parse-arg-c.awk, prot-a-parse-arg-h.awk, fncdef.txt,
free.gdb, handle-malloc-dump.el, malloc.gdb, realloc.gdb,
trace-mem.gdb and logII.c.
(MOSTLYCLEANFILES): Added .gdbinit, call-switch.incl, com.h,
fnc-def-init.incl, fncdef-no-str-limit.txt, prot-a-parse-arg.h and
version.incl.
(MAINTAINERCLEANFILES): Added aux-item-def.tab.h.
(lyskomd_SOURCES): Added admin.h, async.h, aux-items.h,
cache-node.h, cache.h, conf-file.h, connections.h,
end-of-atomic.h, exp.h, internal-connections.h,
internal-services.h, isc-interface.h, isc-malloc.h, isc-parse.h,
kom-memory.h, local-to-global.h, log.h, lyskomd.h, manipulate.h,
minmax.h, mux-parse.h, mux.h, param.h, prot-a-output.h,
prot-a-parse.h, prot-a-send-async.h, prot-a.h, ram-output.h,
ram-parse.h, rfc931.h, send-async.h, server-config.h,
string-malloc.h, text-garb.h, tmp-limits.h and version-info.h.
(dbck_SOURCES): Added dbck-cache.h and getopt.h.
* src/libraries/libmisc/Makefile.am (EXTRA_DIST): Added ChangeLog.1.
* src/libraries/libcommon/Makefile.am (EXTRA_DIST): Added ChangeLog.1.
* src/include/Makefile.am (EXTRA_DIST): Added ChangeLog.1.
* run-support/Makefile.am (EXTRA_DIST): Added .cvsignore,
komrunning.sh and savecore.sh.
* doc/man/Makefile.am (EXTRA_DIST): Added $(man_MANS).
* doc/prot-A-english.txt: Added a reference to Protocol-A.texi.
* doc/Makefile.am (EXTRA_DIST): Added Buggar.fixade, Bugrapporter,
LOGG, Protocol-A.texi, aux-info.doc, clients.assigned,
cmsltt12.mf, dbck.latexinfo, disc-cache.spec, local-to-global.doc,
lyskomd-database-format, mux.proto, prot-A-english.txt and
security-levels.txt.
* db-crypt/db/Makefile.am (EXTRA_DIST): Added .cvsignore.
* db-crypt/Makefile.am (EXTRA_DIST): Added .cvsignore.
* configure.in: Generate src/server/testsuite/config/Makefile.
* Makefile.am (EXTRA_DIST): Added ChangeLog.1, README.FSF,
SERVER-RELEASE, mkmi and versions.
Removed obsolete and unused files.
* src/server/disk-end-of-atomic.c: Don't include disk-cache.h.
* src/server/sync.c: Removed.
* src/server/disk-cache.h: Removed.
* src/server/cache.c: Removed.
* src/server/cache-database.h: Removed.
* src/server/cache-database.c: Removed.
* scripts/mkmi.m4: Removed.
* scripts/makedist.sh: Removed.
* doc/libraries: Removed
* doc/fileformat: Removed.
* doc/elisp-client.user-manual: Removed.
* doc/elisp-client.internals: Removed.
* doc/Introduktion: Removed.
Don't version-control generated files.
* src/server/aux-item-def.tab.h: No longer kept under version
control.
Removed the last traces of zmalloc.
* src/libraries/libmisc/Makefile.am (libmisc_a_SOURCES): Removed
zmalloc.h.
1998-07-11 Per Cederqvist <ceder@lysator.liu.se>
Install the sample database (unless it was already installed).
* configure.in: Generate db-crypt/db/Makefile.
* db-crypt/Makefile.am (SUBDIRS): Added db.
* db-crypt/db/Makefile.am: New file.
Fix compilation outside the source directory.
* src/server/Makefile.am (aux-item-def.tab.c): Look for
aux-item-def.y in srcdir.
1998-07-10 Per Cederqvist <ceder@lysator.liu.se>
Fix "make install".
* run-support/Makefile.am (sysconf_DATA): Added, but empty.
(EXTRA_DIST): Added config and aux-items.conf.
(komrunning): The current standard names the variable sysconfdir,
not etcdir.
(savecore): Likewise.
(install-data-local): Likewise.
Fix the configure script so that --enable-isc-printf is no longer
needed.
* configure.in: Force enable_isc_printf so that libisc contains
the proper things.
Some versions of libnsl and/or libsocket are reportedly bogus, so
don't link against them unless it is really necessary.
* configure.in: Improved checking for -lsocket and -lnsl.
1998-07-09 Per Cederqvist <ceder@lysator.liu.se>
Don't forget src/server/testsuite.
* configure.in: Don't forget src/server/testsuite.
(USING_GNU_MALLOC): An automake conditional.
* src/server/testsuite/test-l2g.c (main): Make it a proper
prototype. Avoid problems with signed chars. Fixed typo: use
l2g_write, not l2g_print.
* src/server/testsuite/Makefile.am: New file.
* src/server/Makefile.am (SUBDIRS): New variable; added testsuite.
Don't try to compile zmalloc which was removed yesterday.
* src/libraries/libmisc/Makefile.am (libmisc_a_SOURCES): Removed
zmalloc.c.
Build komrunning and savecore.
* run-support/Makefile.am: New file.
Switch to using automake.
* mkmi: Run aclocal, automake and autoconf instead of creating
Makefile.in via a m4 script.
* configure.in: Move up AC_CONFIG_AUX_DIR so that both automake
and autoconf detects it early enough. Remove explicit AC_SUBST of
several variables that automake handles automatically, or that was
used for functionality that automake provides in different ways:
CFLAGS, CPPFLAGS, LDFLAGS, DEPENDFLAGS, INCLUDE_CURRENT,
EXTRAARFLAGS, SRCTOPDIR, BUILDTOPDIR. Added call to
AM_C_PROTOTYPES. Rely on automakes ability to fix dependencies
automatically and handle ARFLAGS properly. Use
CMOD_COMPILER_CC_ACCEPTS to check for a lot of warning flags to
use. Use CMOD_C_ATTRIBUTE_UNUSED. Use AM_PROG_LEX instead of
AC_PROG_LEX. Removed check for sys/select.h, which only isc uses.
Added check for values.h. Run configure in
src/libraries/libisc-new instead of creating makefiles in that
directory. Generate db-crypt/Makefile and run-support/Makefile.
Don't version-control files that are generated by aclocal,
automake, autoconf or bison.
* Makefile.in: No longer kept under version control.
* aclocal.m4: Likewise.
* configure: Likewise.
* doc/Makefile.in: Likewise.
* doc/man/Makefile.in: Likewise.
* run-support/Makefile.in: Likewise.
* scripts/Makefile.in: Likewise.
* scripts/install-sh: Likewise.
* scripts/mkinstalldirs: Likewise.
* src/Makefile.in: Likewise.
* src/include/Makefile.in: Likewise.
* src/include/server/Makefile.in: Likewise.
* src/libraries/Makefile.in: Likewise.
* src/libraries/libansi/Makefile.in: Likewise.
* src/libraries/libcommon/Makefile.in: Likewise.
* src/libraries/libmisc/Makefile.in: Likewise.
* src/server/Makefile.in: Likewise.
* src/server/aux-item-def.tab.c: Likewise.
1998-07-08 Per Cederqvist <ceder@lysator.liu.se>
Use libisc-0.99.
* src/server/isc-interface.h: Include "isc.h" instead of
"isc-new.h".
(ISC_PRINTF_SUPPORT): Define it.
* src/libraries/libisc-new: Replace the old contents with that of
isc-0.99. Se src/libraries/libisc-new/ChangeLog for information
about any modifications that are made to the library.
Added files that automake requires.
* AUTHORS: New file.
* README-serverrelease: Renamed to README.
* README: New name for former README-serverrelease.
* acinclude.m4: New file. Contents taken from the old
aclocal.m4, but changed to match the contents of libisc.
Added new makefile templates for automake.
* Makefile.am: New file.
* db-crypt/Makefile.am: New file.
* doc/Makefile.am: New file.
* doc/man/Makefile.am: New file.
* scripts/Makefile.am: New file.
* src/Makefile.am: New file.
* src/include/Makefile.am: New file.
* src/include/server/Makefile.am: New file.
* src/libraries/Makefile.am: New file.
* src/libraries/libansi/Makefile.am: New file.
* src/libraries/libcommon/Makefile.am: New file.
* src/libraries/libmisc/Makefile.am: New file.
* src/server/Makefile.am: New file.
Code cleanup for increased portability.
* src/libraries/libmisc/pom.c: Use HAVE_VALUES_H instead of
__svr4__ and __sparc__ to protect inclusion of <values.h>.
(rcsid): Added a missing const.
Improved some variable types and fixed problems with signed
chars.
* src/server/simple-cache.c (rcsid): Added a missing const.
(next_free_num): Changed type from int to Conf_no.
(next_text_num): Changed type from int to Text_no.
(read_person): Flag unused parameters.
(read_conference): Likewise.
(read_text_stat): Likewise.
(cached_get_text_stat): Adjusted printf format according to
the next_text_num change.
(init_cache): Likewise.
(free_match_table): Renamed a parameter name to avoid
warnings from gcc.
(build_matching_info): Renamed a local variable name to avoid
warnings from gcc.
(pre_sync): Use tno_iter and cno_iter instead of i to get all
types correct.
(post_sync): Likewise.
(copy_file): Flag unused parameters.
* src/server/ram-parse.c (rcsid): Added a missing const.
(fparse_info_0): Now static.
(fparse_info_2): Likewise.
(fparse_conference_2): Likewise.
(fparse_conference_0): Likewise.
(fparse_person_0): Likewise.
(fparse_person_2): Likewise.
(fparse_text_stat_2): Likewise.
(fparse_text_stat_0): Likewise.
(fparse_conf_list): Changed type of local variable "i" from int to
unsigned long.
(fparse_text_list): Likewise.
* src/server/ram-output.c (foutput_text_list): Changed
type of local variable "i" from int to unsigned long.
(foutput_time): Renamed a parameter name to avoid
warnings from gcc.
(rcsid): Added a missing const.
* src/server/prot-a-output.c (prot_a_output_conf_list): Changed
type of local variable "i" from int to unsigned long.
(prot_a_output_text_list): Likewise.
(prot_a_output_time): Renamed local variable
names to avoid warnings from gcc.
(rcsid): Added a missing const.
* src/server/local-to-global.c (Local_text_no_iter): New
experimental typedef.
(l2g_append): Renamed i to ix and changed type to
Local_text_no_iter.
* src/server/dbck-cache.c: Include dbck-cache.h.
(rcsid): Added a missing const.
(next_text_num): Changed type from int to Text_no.
(TEXT_RANGE): Adjusted printf format for next_text_num change.
(VOID_TEXT_RANGE): Likewise.
(cache_sync): Changed type of local variable i from int to
unsigned long. Removed extern declaration of oformat.
Adjusted printf formats for next_text_num change.
(init_cache): Removed extern declaration of oformat.
Adjusted printf formats for next_text_num change.
* src/server/conference.c (do_create_conf): Now static.
(do_lookup): Changed type of local variables i and retsize to
avoid warnings. Handle overflow a little better and log warning
messages if overflow ever occurs.
(rcsid): Added a missing const.
* src/libraries/libmisc/s-string.c (s_strcmp): Changed type of
loop variable from "unsigned int" to "String_size".
(s_usr_strcmp): Likewise.
(char2digit): Added const qualifier to translate_table. Use an
int as argument to isalpha and tolower to avoid problems with
signed chars.
(rcsid): Added a missing const.
* src/server/conf-file.c (assign_text_no): Don't use isdigit
unless isascii is true. Use an int as argument to isalpha and
isdigit to avoid problems with signed chars.
(assign_conf_no): Likewise.
(assign_int): Likewise.
(rcsid): Added a missing const.
Many minor tweaks to remove annoying but harmless warnings from
gcc.
* src/server/updateLysKOM.c (checkstatus): Now static.
* src/server/text.c: Include internal-services.h.
(rcsid): Added a missing const.
(set_loc_no): Renamed a parameter name to avoid
warnings from gcc.
(find_recipient): Now static. Removed declaration of errno.
* src/server/session.c (get_time): Renamed a parameter name to avoid
warnings from gcc.
(rcsid): Added a missing const.
* src/server/server-config.c (log_param): Flag unused argument.
(param_name): Now static.
(rcsid): Added a missing const.
* src/server/rfc931.c: Include rfc931.h.
(get_real_username): Added a const qualifier to the return value.
* src/server/rfc931.h (get_real_username): Added a const qualifier
to the return value.
* src/server/ramkomd.c (rcsid): Added a missing const.
(init_data_base): Removed unused argument dir_base. All callers
updated.
(sighandler_hup): Flag unused argument.
(sighandler_quit): Likewise.
(sighandler_usr1): Likewise.
(sighandler_usr2): Likewise.
(go_daemon): Make it a function prototype.
(initialize): New static.
* src/server/mux.c: (rcsid): Added a missing const.
(UCB_printf): Specify the return type in the extern declaration.
* src/server/membership.c (do_add_member): Renamed local variable
names to avoid warnings from gcc.
(do_sub_member): Likewise.
(locate_member): Likewise.
(check_membership): Likewise.
(set_membership_type): Likewise.
(rcsid): Added a missing const.
* src/server/log.c (rcsid): Added a missing const.
(logv): Renamed local variable names to avoid warnings
from gcc.
(log): Likewise.
* src/server/internal-services.h (do_create_conf): Declaration
removed. This function is static.
* src/server/dbck.c (register_jubel): Flag unused arguments.
(locate_member): Renamed local variable names to avoid warnings
from gcc.
(check_misc_infos): Likewise.
(check_created_texts): Likewise.
(check_membership): Likewise.
(check_texts_in_conf): Likewise.
(confirm): Added const qualifier to argument question.
(check_member): Likewise.
(init_data_base): Removed the unused dbase_dir argument. All
callers updated.
* src/server/dbck-cache.h (oformat): Declaration added.
* src/server/connections.c (login_request): Added a missing const
to the realuser local variable.
(rcsid): Added a missing const.
* src/server/conf-file.h (struct parameter): Added const qualifier
to the name and default_val tags.
* src/server/aux-items.c: Include services.h.
(aux_item_definition_cache_regexp): Now static.
(initialize_aux_items): Removed declaration of
parse_aux_item_definitions.
(aux_item_call_add_triggers): Now static.
(aux_item_call_delete_triggers): Now static.
(aux_item_call_undelete_triggers): Now static.
* src/server/aux-items.h (Aux_item_definition_s): Added const
qualifier to the name tag.
(Aux_item_trigger_mapping): Likewise.
(parse_aux_item_definitions): Declaration added.
* src/server/aux-item-def.y:
(aux_item_def_typename): Added const qualifier to the return value.
(aux_item_def_check_assign): Added const qualifier to the id argument.
(aux_item_def_check_trigger): Added const qualifier to the
check_name argument.
* src/server/admin.c (shutdown_kom): Flag unused arguments.
(rcsid): Added a missing const.
* src/include/services.h: Renamed a few parameter names to avoid
warnings from gcc.
* src/server/prot-a-output.h: Likewise.
* src/server/ram-output.h: Likewise.
* src/libraries/libcommon/parser.h: Likewise.
* src/server/manipulate.h: Likewise.
* src/libraries/libcommon/kom-errno.c (rcsid): Added a missing const.
* src/libraries/libcommon/misc-parser.c: Likewise.
* src/libraries/libcommon/parser.c: Likewise.
* src/libraries/libmisc/s-collat-tabs.c: Likewise.
* src/server/cache-node.c: Likewise.
* src/server/disk-end-of-atomic.c: Likewise.
* src/server/internal-connections.c: Likewise.
* src/server/isc-malloc.c: Likewise.
* src/server/isc-parse.c: Likewise.
* src/server/memory.c: Likewise.
* src/server/mux-parse.c: Likewise.
* src/server/person.c: Likewise.
* src/server/prot-a-parse.c: Likewise.
* src/server/prot-a-send-async.c: Likewise.
* src/server/prot-a.c: Likewise.
* src/server/ram-smalloc.c: Likewise.
* src/server/regex-match.c: Likewise.
* src/server/send-async.c: Likewise.
* src/server/string-malloc.c: Likewise.
* src/server/text-garb.c: Likewise.
* src/libraries/libansi/empty.c: Likewise.
Remove some old unused files.
* src/libraries/libmisc/zmalloc.c: Unused file removed.
* src/libraries/libmisc/zmalloc.h: Unused file removed.
* src/server/kom-types.c: Empty file removed.
* scripts/Summarize-Headers: File removed.
* scripts/List-Files: File removed.
* src/libraries/libclient/.cvsignore: File removed.
* src/libraries/libclient/Makefile.in: File removed.
* src/libraries/libclient/async.c: File removed.
* src/libraries/libclient/async.h: File removed.
* src/libraries/libclient/client-Makefile.in: File removed.
* src/libraries/libclient/client-malloc.h: File removed.
* src/libraries/libclient/client.c: File removed.
* src/libraries/libclient/client.h: File removed.
* src/libraries/libclient/input.c: File removed.
* src/libraries/libclient/input.h: File removed.
* src/libraries/libclient/kom-types.c: File removed.
* src/libraries/libclient/output.c: File removed.
* src/libraries/libclient/output.h: File removed.
* src/libraries/libclient/parse.c: File removed.
* src/libraries/libclient/parse.h: File removed.
* src/libraries/libclient/send.c: File removed.
* src/libraries/libclient/send.h: File removed.
* src/libraries/libclient/services.c: File removed.
* src/libraries/libclient/services.h: File removed.
1998-07-07 Per Cederqvist <ceder@gratia>
Fixed spelling of the config file parameter "Max broadcast length".
* src/server/server-config.c (parameters): Fixed mis-spelling of
"Max broadcast length".
* doc/man/lyskomd.8: Likewise.
* doc/Protocol-A.texi: Minor errata.
* doc/security-levels.txt: Converted from swascii to latin1.
1998-06-14 David Byers <davby@ida.liu.se>
* src/server/membership.c (copy_public_confs): The supervisor of a
conference can now see secret parts of member's memberships.
(get_members): Ditto.
(set_membership_type): Don't allow secret memberships if the
conference forbids it.
(add_member): Ditto.
(add_member): Pretend that addition worked if the person is
already a secret member.
(do_get_membership): Renamed from get_membership_old.
(get_membership_old): New function.
(get_membership): Call do_get_membership
(do_get_members): Renamed from get_members.
(copy_public_confs): New argument want_passive.
* src/server/prot-a-output.c (prot_a_output_extended_conf_type):
Added output of forbid_secret.
* src/server/prot-a-parse.c (prot_a_parse_conf_type): Added parse
of forbid_secret.
* src/server/ram-parse.c (fparse_conf_type): Added parse of
forbid_secret.
* src/server/ram-output.c (foutput_conf_type_1): Added output of
forbid_secret.
* src/include/kom-types.h: Added forbid_secret conf_type.
1998-06-10 David Byers <davby@ida.liu.se>
* src/server/membership.c (sub_member): Return KOM_NOT_MEMBER for
secret memberships.
1998-06-08 David Byers <davby@ida.liu.se>
* src/server/membership.c (set_membership_type): New function.
* src/server/prot-a-output.c (prot_a_output_membership): Output
added_at.
(prot_a_output_member): Output added_at
* src/server/membership.c (do_add_member): Set added_at.
(get_members): Filter out added_at.
* src/server/memory.c (init_membership): Init added_at.
* src/server/ram-output.c (foutput_member_2): Added output of
added_at.
* src/server/ram-parse.c (fparse_member_2): Added parsing of added_at.
* src/include/kom-types.h: Added added_at to Membership och Member.
* src/server/ram-parse.c (fparse_membership_2): Added parsning of
added_at.
* src/server/ram-output.c (foutput_membership_2): Added output of
added_at.
Fri Jan 16 22:51:52 1998 David Byers <davby@litefix.ida.liu.se>
* src/include/kom-types.h (Aux_item_flags): Added dont_garb.
* src/server/text-garb.c (garb_text): Check dont_garb aux-item
flag.
Mon Sep 22 19:06:05 1997 David Byers <davby@litefix.ida.liu.se>
* src/server/cache-node.h: New flags: snapshot and synced.
Sun Sep 21 21:16:28 1997 David Byers <davby@litefix.ida.liu.se>
* src/server/memory.c (copy_text_stat): Call copy_aux_item_list.
(copy_aux_item_list): New function.
(copy_aux_item): New function.
(copy_conference): Call copy_aux_item_list.
(clear_conference): Free the aux_item_list
(init_conference): Init the aux_item_list.
(clear_text_stat): Free the aux_item_list.
(init_text_stat): Init the aux_item_list.
(init_aux_item_list): New function.
Sat Sep 13 15:07:32 1997 David Byers <davby@ida.liu.se>
* run-support/aux-items.conf: New file. This is the aux-item
definition file.
* src/server/aux-items.h: New file. Include this when using
aux-items.
* src/server/aux-items.c: New file. Implements most of the
functionality associated with aux-items.
* src/server/aux-item-def.l: New file. Implements the scanner for
the aux-item definition file parser.
* src/server/aux-item-def.y: New file. Implements the aux-item
definition file parser.
* src/server/text.c: Added support for aux-items. Set err_stat
whenever kom_errno is set.
(create_text_old): Renamed from create_text. Use do_create_text.
(create_text): New RPC function.
(create_anonymous_text): New RPC function.
(create_anonymous_text_old): Renamed from create_anonymous_text.
Use do_create_text.
(do_create_text): New function similar to old create_text, but
with aux-item support.
(count_recipients): Handle bcc-recpt.
(find_recipient): Handle bcc-recpt.
(do_add_bcc_recpt): New function to add bcc-recipient.
(do_delete_misc): Handle bcc_recpt.
(do_sub_recpt): Handle bcc_recpt.
(sender): Handle bcc_recpt.
(is_sender): Handle bcc_recpt.
(is_comm_sender): Handle bcc_recpt.
(skip_recp): Handle bcc_recpt.
(is_member_in_recpt): Handle bcc_recpt.
(filter_secret_info): Handle bcc_recpt.
(text_read_access): Handle bcc_recpt.
(do_delete_text): Handle bcc_recpt.
(check_double_subm): Handle bcc_recpt.
(check_double_comm): Handle bcc_recpt.
(create_text_check_misc): Handle bcc_recpt.
(create_text_add_miscs): Handle bcc_recpt.
(add_recipient): Handle bcc_recpt.
(filter_secret_info): Filter aux-items as well as misc-info.
(create_text_add_aux): New function.
(send_async_new_text_old): Renamed from send_async_new_text.
(send_async_new_text): New function.
(get_text_stat_old): Renamed from get_text_stat.
(get_text_stat): New RPC function.
(modify_text_info): New RPC function.
(do_delete_text): Send async deleted text.
* src/server/text-garb.c (garb_text): Handle bcc-recpt.
* src/server/simple-cache.c: Set err_stat whenever kom_errno is
set.
(cached_lookup_name): Set kom_errno to KOM_INTERNAL_ERROR is
parse() fails.
(pre_sync): Write version 2 data file.
(cached_delete_conf): Delete conference name from small_conf_arr.
(pre_sync): Use foutput_info instead of writing it here.
(init_cache): Return KOM_INTERNAL_ERROR on problems with the
files. Prettier handling of datafile versions (switch instead of
testing for one single version.) Call set_input_format to set the
input format. Use fparse_info to read info instead of parsing it
here. If we encounter an unknown key, print its offset.
* src/server/session.c: Set err_stat whenever kom_errno is set.
(accept_async): Return KOM_UNKNOWN_ASYNC if an unknown async
message is requested.
(login_old): Test wheel bit (test removed from is_supervisor.)
(login): Test wheel bit (test removed from is_supervisor.)
(disconnect): Test wheel bit (test removed from is_supervisor.)
* src/server/server-config.c (parameters): Add max_add_aux and
max_delete_aux.
(toplevel): Set AUX_DEF_FILE constant.
* src/server/send-async.h: Declare new functions in send-async.c
* src/server/send-async.c (async_new_text_old): Renamed from
async_new_text.
(async_new_text): New function to send new new-text async.
(async_send_group_message): Return KOM_MESSAGE_NOT_SENT on failure
because of no accepting recipient. Return KOM_FEATURE_DISABLED if
messages are disabled. Return INTERNAL_ERROR on an internal error.
(async_deleted_text): New function to send new deleted-text async.
* src/server/regex-match.c (lookup_regexp): Set err_stat when
kom_errno is set.
* src/server/ramkomd.c:
(initialize): Initialize aux-item definitions.
(main): Handle -a and -c options, and user-selectable aux-item
definition file.
* src/server/ram-parse.h: Declare new function in ram-parse.c
* src/server/ram-parse.c: Better support for reading different
input formats by using solution similar to that in ram-output.c.
New variable input_format controls input format.
(set_input_format): New function selects input format.
(fparse_info_0): New function.
(fparse_info_2): New function.
(fparse_info): New function.
(fparse_conference_2): New function.
(fparse_conference_0): New function.
(fparse_conference): New function.
(fparse_person_0): New function.
(fparse_person_2): New function.
(fparse_person): New function.
(fparse_text_stat_2): New function.
(fparse_text_stat_0): New function.
(fparse_text_stat): New function.
(fparse_aux_item_flags): New function to read aux-item flags.
(fparse_aux_item): New function to read an aux-item.
(fparse_aux_item_list): New function to read an aux-item-list.
(fparse_misc_info): Parse bcc-recpt.
* src/server/ram-output.h: Declare new functions in ram-output.c
* src/server/ram-output.c: Better support for writing different
output formats by using foutput_something_<version> and a switch
in foutput_something. New variable output_format selects output
format.
(set_output_format): New function to select output format.
(foutput_info_0): New function.
(foutput_info_2): New function.
(foutput_info): New function.
(foutput_person_0): New function.
(foutput_person_2): New function.
(foutput_person): New function.
(foutput_conference_2): New function.
(foutput_conference): New function.
(foutput_text_stat_0): New function.
(foutput_text_stat_2): New function.
(foutput_text_stat): New function.
(foutput_aux_flags): New function to output aux-item flags.
(foutput_aux_item): New function to output aux-items.
(foutput_aux_item_list): New function to output aux-item-lists.
(foutput_misc_info): Output bcc-recpt.
* src/server/prot-a.c (prot_a_reply): Added support for new and
renamed return types: rt_conference, rt_conference_old,
rt_text_stat, rt_text_stat_old, rt_info, rt_info_old.
(prot_a_init): Initialize aux_item_list of Connection.
(prot_a_destruct): Clear the aux_item_list in Connection.
(prot_a_is_legal_fnc): Add support for new and changed RPC calls
(see entry for fncdef.txt.)
* src/server/prot-a-send-async.h: Declare new functions in
prot-a-send-async.c
* src/server/prot-a-send-async.c (prot_a_async_new_text_old):
Renamed from prot_a_async_new_text.
(prot_a_async_new_text): New async message function.
(prot_a_async_deleted_text): New async message function.
* src/server/prot-a-parse.h: Declare new functions in
prot-a-parse.c
* src/server/prot-a-parse.c (prot_a_parse_aux_item_flags): New
function.
(prot_a_parse_aux_item): New function.
(prot_a_parse_aux_item_list): New function.
(prot_a_parse_misc_info): Parse bcc_recpt info type.
* src/server/prot-a-output.h: Declare new functions in
prot-a-output.c
* src/server/prot-a-output.c (prot_a_output_conference): New
output function.
(prot_a_output_conference_old): Renamed from old
prot_a_output_conference.
(prot_a_output_aux_item_flags): New function.
(prot_a_output_aux_item): New function.
(prot_a_output_text_stat_old): Renamed from
prot_a_output_text_stat.
(prot_a_output_aux_item_list): New function.
(prot_a_output_text_stat): New function.
(prot_a_output_info): New function.
(prot_a_output_info_old): Renamed from prot_a_output_info.
(prot_a_output_misc_info): Output bcc_recpt misc type.
* src/server/person.c: Added support for aux-items. Set err_stat
whenever kom_errno is set.
(create_person_generic): Moved all generic create_person code to
this function.
(create_person_old): Renamed from create_person, use
create_person_generic.
(create_person): New RPC function.
(set_passwd): Test wheel bit when doing is_supervisor (test
removed from is_supervisor.)
* src/server/param.h: Added max_delete_aux, max_add_aux to struct
kom_par.
* src/server/memory.c (free_aux_item_list): New function to free
all data in an Aux_item_list.
* src/server/membership.c: Set err_stat whenever kom_errno is set.
(access_perm): Test wheel bit (test removed from is_supervisor.)
(add_member): Test wheel bit (test removed from is_supervisor.)
* src/server/manipulate.h: Set err_stat whenever kom_errno is set.
Declare is_strictly_supervisor.
* src/server/kom-memory.h: Declare free_aux_item_list.
* src/server/internal-connections.c (init_connection): Clear
aux_item and aux_item_list fields of Connection. Clear
aux_item_list field of Info.
* src/server/fncdef.txt: Added comments to separate protocol
versions. New calls: get_collate_table, create_text,
create_anonymous_text, create_conf, create_person, get_text_stat,
get_conf_stat, modify_text_info, modify_conf_info, get_info,
modify_server_info, query_predefined_aux_items, set_expire.
Renamed calls: get_text_stat to get_text_stat_old,
get_conf_stat_old to get_conf_stat_older, get_conf_stat to
get_conf_stat_old, get_info to get_info_old, create_conf to
create_conf_old, create_pers to create_pers_old, create_text to
create_text_old, create_anonymous_text to
create_anonymous_text_old.
* src/server/dbck.c (check_misc_infos): Handle m_bcc_recpt.
(is_recipient): Handle bcc_recpt.
(main): Use set_output_format to select the output format.
* src/server/dbck-cache.c: Set err_stat whenever kom_errno is set.
(cache_sync): Use foutput_info instead of outputting the info
here.
(cache_sync): Call foutput_conference, not foutput_conference_old.
ram-output now takes care of selecting the correct version to
write.
(init_cache): Use fparse_info instead of reading the info here.
* src/server/connections.h: (Connection): Add aux_item_list and
aux_item.
(Res_type): Renamed return types: rt_conference to
rt_conference_old. rt_text_stat to rt_text_stat_old, rt_info to
rt_info_old. Addet rt_conference, rt_text_stat and rt_info.
(Result_holder): Added conference_old, text_stat_old and info_old.
* src/server/connections.c: Include kom-memory.h. Set err_stat
whenever kom_errno is set.
(free_parsed): Free data in aux_item and aux_item_list.
* src/server/conference.c: Added support for aux-items. Set
err_stat whenever kom_errno is set.
(is_strictly_supervisor): New function.
(is_supervisor): Use is_strictly_supervisor. Don't test the wheel
bit of ACTPERS.
(create_conf_generic): Moved generic create_conf code here.
(create_conf_old): Renamed from create_conf. Use
create_conf_generic.
(create_conf): New RPC function.
(get_conf_stat): New RPC function.
(get_conf_stat_old): Renamed from get_conf_stat
(modify_conf_info): New RPC function.
(set_expire): New RPC function.
* src/server/call-switch.awk: Parse aux_item_list.
* src/server/async.h: Added ay_new_text, ay_deleted_text. Renamed
old ay_new_text to ay_new_text_old.
* src/server/admin.c (modify_server_info): New RPC function.
(toplevel): Update initializer for kom_info.
(all): Set err_stat whenever kom_errno is set.
(get_info): New function. Old get_info is not get_info_old.
(get_collate_table): New RPC function.
* src/server/Makefile.src: Added the new files to source lists.
Rules to build aux-item-parser and scanner added.
* src/libraries/libcommon/misc-parser.h: Added m_bcc_recpt to
Misc_struct_type. Added bcc_recipient to Misc_info_group struct.
* src/include/services.h: Declared all new RPC functions and
renamed the now obsolete ones. New functions are: create_person,
create_conf, create_text, get_conf_stat, get_text_stat,
create_anonymous_text, modify_conf_info, modify_text_info,
get_info, modify_server_info, get_collate_table, set_expire,
query_predefined_aux_items
* src/include/kom-errno.h (KOM_err): Added KOM_ILL_AUX,
KOM_AUX_PERM, KOM_UNKNOWN_ASYNC, KOM_INTERNAL_ERROR,
KOM_FEATURE_DISABLED, KOM_MESSAGE_NOT_SENT.
* src/include/config.h: Added AUX_DEF_FILE.
* run-support/Makefile.src: Install aux-items.conf.
* doc/man/lyskomd.8: Documented aux-item related settings.
* doc/lyskomd-database-format: Documented data file version 2.
* doc/Protocol-A.texi: Completed all calls, asynch messages, data
structures, error codes. Documented protocol version 10.
* db-crypt/db/lyskomd-data: Updated to data file version 2.
* configure.in: Check for bison and flex (can't use the regular
YACC and LEX tests since we need bison and flex specifically.)
* INSTALL: Mention that bison and flex may be needed for
installation.
Wed Jul 23 22:40:08 1997 Per Cederqvist <ceder@gratia>
* src/server/conference.c (get_uconf_stat): Added a comment about
a bug that needs to be fixed.
Sun Jul 20 16:04:23 1997 Per Cederqvist <ceder@lysator.liu.se>
The regexp code could use the wrong collate table.
* src/server/regex-match.c (lookup_regexp): Use
DEFAULT_COLLAT_TAB, not swedish_collate_tab. (Reported by David
Byers).
Fri Jun 6 23:16:28 1997 Per Cederqvist <ceder@lysator.liu.se>
Port to AIX.
* src/server/local-to-global.c: Include stdlib.h instead of the
non-standard malloc.h.
* configure.in: Create src/server/Makefile before
src/server/testsuite/Makefile.
Sun Dec 29 15:55:44 1996 Per Cederqvist <ceder@lysator.liu.se>
* doc/prot-A.txt: 59=create-anonymous-text, 78=get-uconf-stat,
58=get-last-text and 77=set-last-read are recommended, not
experimental. Fixed bug in declaration of
Dynamic-Session-Info-List.
* src/server/Makefile.in (GENOBJS): Added local-to-global.o.
Thu Sep 12 19:14:39 1996 Inge Wallin <inge@lysator.liu.se>
* local-to-global.h: Added code for an iterator.
* local-to-global.c: Added code for an iterator.
* kom-types.h: Include some files which are used here.
Sun Sep 1 21:32:22 1996 Inge Wallin <inge@lysator.liu.se>
* (l2g_delete): Delete the block if empty.
* local-to-global.c (delete_block): New function
* local-to-global.c (l2g_destruct): Don't free blocks.
* (l2g_clear): Only free if non-NULL.
* (l2g_copy): more efficient code.
* local-to-global.h, local-to-global.c (l2g_print): Renamed to
l2g_write.
* (l2g_read, l2g_write): Now implemented.
* log.h: Include stdarg.h if possible.
Sun Aug 25 14:47:16 1996 Per Cederqvist <ceder@lysator.liu.se>
* src/server/Makefile.src (GENOBJS): Added local-to-global.o.
* src/server/local-to-global.c: New file, written by Inge Wallin.
Disconnect spamming clients:
* src/server/prot-a-parse.c (prot_a_get_token): Disconnect the
client if it attempts to send a token (other than a string) that
is longer than 1000 characters.
Delete obsolete code:
* src/libraries/libcommon/kom-errno.c (kom_perror): Removed
KOM_NO_CONNECT.
* src/include/kom-errno.h (Kom_err): Removed the unused value
KOM_NO_CONNECT.
Purify support:
* scripts/mkmi.m4 (PURIFY): New make variable.
* configure.in: New argument --with-purify enables debugging with
Purify.
* src/server/Makefile.src (lyskomd): Added $(PURIFY) in front of
the link line.
(updateLysKOM): Likewise.
(dbck): Likewise.
* src/server/local-to-global.c: Include <sys/types.h>, <time.h>
and "s-string.h".
(l2g_next_key): Don't dereference memory past the last block!
Test suite integration:
* configure.in: Generate src/server/testsuite/Makefile. Touch
src/server/testsuite/dependencies.
* src/server/testsuite/Makefile.src: New file.
* mkmi: Added src/server/testsuite/Makefile.
* src/server/testsuite/l2g.0/00.exp: New file.
* src/server/testsuite/l2g.0/01.exp: New file, containing real
data from the map of conference 603 (LysKOM; Elispklientens
buggrapporter) in LysLysKOM.
* src/server/testsuite/config/unix.exp: New file.
* src/server/testsuite/test-l2g.c: New file.
* For older changes, see ChangeLog.1, src/include/ChangeLog.1,
src/server/ChangeLog.1, src/libraries/libcommon/ChangeLog.1, and
src/libraries/libmisc/ChangeLog.1. Starting today, all changes in
those directories should be documented in this file.
Note that local changes to foreign libraries that are included in
this distribution should still be documented in a ChangeLog in
their directory, so that somebody who looks at them can see what
we have modified. As of this writing, the following ChangeLog
files fall into this category: src/libraries/gnumalloc/ChangeLog,
src/libraries/libisc-new/src/ChangeLog,
src/libraries/regex/ChangeLog and
src/libraries/regex/test/ChangeLog.
|