1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
<?php
/**
* Matomo - free/libre analytics platform
*
* @link https://matomo.org
* @license https://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*/
namespace Piwik\Updates;
use Piwik\DataAccess\ArchiveTableCreator;
use Piwik\Db;
use Piwik\Common;
use Piwik\DbHelper;
use Piwik\SettingsPiwik;
use Piwik\Updater;
use Piwik\Updater\Migration\Db as DbAlias;
use Piwik\Updater\Migration\Factory;
use Piwik\Updates as PiwikUpdates;
use Piwik\Updater\Migration\Custom as CustomMigration;
use Piwik\Plugins\Goals\Commands\CalculateConversionPages;
/**
* Update for version 5.0.0-b1
*/
class Updates_5_0_0_b1 extends PiwikUpdates
{
/**
* @var Factory
*/
private $migration;
private $tableName;
private $indexName;
private $newIndexName;
public function __construct(Factory $factory)
{
$this->migration = $factory;
$this->tableName = Common::prefixTable('log_visit');
$this->indexName = 'index_idsite_idvisitor';
$this->newIndexName = 'index_idsite_idvisitor_time';
}
public function doUpdate(Updater $updater)
{
$updater->executeMigrations(__FILE__, $this->getMigrations($updater));
}
public function getMigrations(Updater $updater)
{
$migrations = $this->getUpdateArchiveIndexMigrations();
$migrations[] = $this->migration->db->addColumns('user_token_auth', ['post_only' => "TINYINT(2) UNSIGNED NOT NULL DEFAULT '0'"]);
$migrations[] = $this->migration->db->addColumns('log_conversion', ['pageviews_before' => "SMALLINT UNSIGNED DEFAULT NULL"]);
$instanceId = SettingsPiwik::getPiwikInstanceId();
if (strpos($instanceId, '.matomo.cloud') === false && strpos($instanceId, '.innocraft.cloud') === false) {
$commandString = './console core:calculate-conversion-pages --dates=yesterday,today';
$populatePagesBefore = new CustomMigration([CalculateConversionPages::class, 'calculateYesterdayAndToday'], $commandString);
$migrations[] = $populatePagesBefore;
}
return $this->appendLogVisitTableMigrations($migrations);
}
private function getUpdateArchiveIndexMigrations()
{
$migrations = [];
$tables = ArchiveTableCreator::getTablesArchivesInstalled('numeric');
foreach ($tables as $table) {
$migrations[] = $this->migration->db->sql(sprintf('DELETE FROM `%s` WHERE ts_archived is null', $table));
$hasPrefix = strpos($table, 'archive') !== 0;
if ($hasPrefix) {
$table = Common::unprefixTable($table);
}
$migrations[] = $this->migration->db->dropIndex($table, 'index_idsite_dates_period');
$migrations[] = $this->migration->db->addIndex($table, ['idsite', 'date1', 'date2', 'period', 'name(6)'], 'index_idsite_dates_period');
}
return $migrations;
}
private function appendLogVisitTableMigrations($migrations)
{
if ($this->hasNewIndex()) {
// correct index already exists, so don't perform anything
return $migrations;
}
if ($this->hasCorrectlySetOldIndex()) {
// already existing index has the correct fields. Try renaming, but ignore syntax error thrown if rename command does not exist
$migrations[] = $this->migration->db->sql(
"ALTER TABLE `{$this->tableName}` RENAME INDEX `{$this->indexName}` TO `{$this->newIndexName}`",
[DbAlias::ERROR_CODE_SYNTAX_ERROR]
);
}
// create the new index if it does not yet exist and drop the old one
if ($this->isTableInnoDb()) {
// Only InnoDB does support descending indexes as of MySQL 8
$migrations[] = $this->migration->db->sql(
"ALTER TABLE `{$this->tableName}` ADD INDEX `{$this->newIndexName}` (`idsite`, `idvisitor`, `visit_last_action_time` DESC)",
[DbAlias::ERROR_CODE_DUPLICATE_KEY, DbAlias::ERROR_CODE_KEY_COLUMN_NOT_EXISTS]
);
} else {
$migrations[] = $this->migration->db->sql(
"ALTER TABLE `{$this->tableName}` ADD INDEX `{$this->newIndexName}` (`idsite`, `idvisitor`, `visit_last_action_time`)",
[DbAlias::ERROR_CODE_DUPLICATE_KEY, DbAlias::ERROR_CODE_KEY_COLUMN_NOT_EXISTS]
);
}
$migrations[] = $this->migration->db->dropIndex('log_visit', $this->indexName);
return $migrations;
}
private function hasCorrectlySetOldIndex(): bool
{
$sql = "SHOW INDEX FROM `{$this->tableName}` WHERE Key_name = '{$this->indexName}'";
$result = Db::fetchAll($sql);
if (empty($result)) {
// No index present
return false;
}
// Check that the $result contains all the required column names. This is required as there was a previous index
// with the same name that only consisted of two columns. We want to check this index is built with all three.
// $diff will be empty if all three columns are found, meaning that the index already exists.
$diff = array_diff(['idsite', 'idvisitor', 'visit_last_action_time'], array_column($result, 'Column_name'));
if (!$diff) {
return true;
}
return false;
}
private function hasNewIndex(): bool
{
return DbHelper::tableHasIndex($this->tableName, $this->newIndexName);
}
private function isTableInnoDb(): bool
{
$sql = "SHOW TABLE STATUS WHERE NAME='{$this->tableName}'";
$result = Db::fetchRow($sql);
return strtolower($result['Engine'] ?? '') === 'innodb';
}
}
|
