1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203
|
<?php
/**
* Matomo - free/libre analytics platform
*
* @link https://matomo.org
* @license https://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*/
namespace Piwik\Plugins\CoreAdminHome\Commands;
use Piwik\Common;
use Piwik\Container\StaticContainer;
use Piwik\DataAccess\Actions;
use Piwik\Archive\ArchiveInvalidator;
use Piwik\Date;
use Piwik\Plugin\ConsoleCommand;
use Piwik\Plugins\CoreAdminHome\Model\DuplicateActionRemover;
use Piwik\Timer;
use Piwik\Log\LoggerInterface;
/**
* Finds duplicate actions rows in log_action and removes them. Fixes references to duplicate
* actions in the log_link_visit_action table, log_conversion table, and log_conversion_item
* table.
*
* Prior to version 2.11, there was a race condition in the tracker where it was possible for
* two or more actions with the same name and type to be inserted simultaneously. This resulted
* in inaccurate data. A Piwik database with this problem can be fixed using this class.
*
* With version 2.11 and above, it is still possible for duplicate actions to be inserted, but
* ONLY if the tracker's PHP process fails suddenly right after inserting an action. This is
* very rare, and even if it does happen, report data will not be affected, but the extra
* actions can be deleted w/ this class.
*/
class FixDuplicateLogActions extends ConsoleCommand
{
/**
* Used to invalidate archives. Only used if $shouldInvalidateArchives is true.
*
* @var ArchiveInvalidator
*/
private $archiveInvalidator;
/**
* DAO used to find duplicate actions in log_action and fix references to them in other tables.
*
* @var DuplicateActionRemover
*/
private $duplicateActionRemover;
/**
* DAO used to remove actions from the log_action table.
*
* @var Actions
*/
private $actionsAccess;
/**
* @var LoggerInterface
*/
private $logger;
/**
* Constructor.
*
*/
public function __construct(
?ArchiveInvalidator $invalidator = null,
?DuplicateActionRemover $duplicateActionRemover = null,
?Actions $actionsAccess = null,
?LoggerInterface $logger = null
) {
parent::__construct();
$this->archiveInvalidator = $invalidator ?: StaticContainer::get('Piwik\Archive\ArchiveInvalidator');
$this->duplicateActionRemover = $duplicateActionRemover ?: new DuplicateActionRemover();
$this->actionsAccess = $actionsAccess ?: new Actions();
$this->logger = $logger ?: StaticContainer::get(LoggerInterface::class);
}
protected function configure()
{
$this->setName('core:fix-duplicate-log-actions');
$this->addNoValueOption('invalidate-archives', null, "If supplied, archives for logs that use duplicate actions will be invalidated."
. " On the next cron archive run, the reports for those dates will be re-processed.");
$this->setDescription('Removes duplicates in the log action table and fixes references to the duplicates in '
. 'related tables. NOTE: This action can take a long time to run!');
}
protected function doExecute(): int
{
$input = $this->getInput();
$output = $this->getOutput();
$invalidateArchives = $input->getOption('invalidate-archives');
$timer = new Timer();
$duplicateActions = $this->duplicateActionRemover->getDuplicateIdActions();
if (empty($duplicateActions)) {
$output->writeln("Found no duplicate actions.");
return self::SUCCESS;
}
$output->writeln("<info>Found " . count($duplicateActions) . " actions with duplicates.</info>");
list($numberRemoved, $allArchivesAffected) = $this->fixDuplicateActionReferences($duplicateActions);
$this->deleteDuplicatesFromLogAction($duplicateActions);
if ($invalidateArchives) {
$this->invalidateArchivesUsingActionDuplicates($allArchivesAffected);
} else {
$this->printAffectedArchives($allArchivesAffected);
}
$logActionTable = Common::prefixTable('log_action');
$this->writeSuccessMessage(array(
"Found and deleted $numberRemoved duplicate action entries in the $logActionTable table.",
"References in log_link_visit_action, log_conversion and log_conversion_item were corrected.",
$timer->__toString(),
));
return self::SUCCESS;
}
private function invalidateArchivesUsingActionDuplicates($archivesAffected)
{
$this->getOutput()->write("Invalidating archives affected by duplicates fixed...");
foreach ($archivesAffected as $archiveInfo) {
$dates = array(Date::factory($archiveInfo['server_time']));
$this->archiveInvalidator->markArchivesAsInvalidated(array($archiveInfo['idsite']), $dates, $period = false);
}
$this->getOutput()->writeln("Done.");
}
private function printAffectedArchives($allArchivesAffected)
{
$this->getOutput()->writeln("The following archives used duplicate actions and should be invalidated if you want correct reports:");
foreach ($allArchivesAffected as $archiveInfo) {
$this->getOutput()->writeln("\t[ idSite = {$archiveInfo['idsite']}, date = {$archiveInfo['server_time']} ]");
}
}
private function fixDuplicateActionReferences($duplicateActions)
{
$dupeCount = count($duplicateActions);
$numberRemoved = 0;
$allArchivesAffected = array();
foreach ($duplicateActions as $index => $dupeInfo) {
$name = $dupeInfo['name'];
$toIdAction = $dupeInfo['idaction'];
$fromIdActions = $dupeInfo['duplicateIdActions'];
$numberRemoved += count($fromIdActions);
$this->getOutput()->writeln("<info>[$index / $dupeCount]</info> Fixing duplicates for '$name'");
$this->logger->debug(" idaction = {idaction}, duplicate idactions = {duplicateIdActions}", array(
'idaction' => $toIdAction,
'duplicateIdActions' => $fromIdActions,
));
foreach (DuplicateActionRemover::$tablesWithIdActionColumns as $table) {
$archivesAffected = $this->fixDuplicateActionsInTable($table, $toIdAction, $fromIdActions);
$allArchivesAffected = array_merge($allArchivesAffected, $archivesAffected);
}
}
$allArchivesAffected = array_values(array_unique($allArchivesAffected, SORT_REGULAR));
return array($numberRemoved, $allArchivesAffected);
}
private function fixDuplicateActionsInTable($table, $toIdAction, $fromIdActions)
{
$timer = new Timer();
$archivesAffected = $this->duplicateActionRemover->getSitesAndDatesOfRowsUsingDuplicates($table, $fromIdActions);
$this->duplicateActionRemover->fixDuplicateActionsInTable($table, $toIdAction, $fromIdActions);
$this->getOutput()->writeln("\tFixed duplicates in " . Common::prefixTable($table) . ". <comment>" . $timer->__toString() . "</comment>.");
return $archivesAffected;
}
private function deleteDuplicatesFromLogAction($duplicateActions)
{
$logActionTable = Common::prefixTable('log_action');
$this->getOutput()->writeln("<info>Deleting duplicate actions from $logActionTable...</info>");
$idActions = [];
foreach ($duplicateActions as $dupeInfo) {
$idActions = array_merge($idActions, $dupeInfo['duplicateIdActions']);
}
$this->actionsAccess->delete($idActions);
}
}
|