File: CodexModuleTest.php

package info (click to toggle)
mediawiki 1%3A1.43.3%2Bdfsg-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 417,464 kB
  • sloc: php: 1,062,949; javascript: 664,290; sql: 9,714; python: 5,458; xml: 3,489; sh: 1,131; makefile: 64
file content (470 lines) | stat: -rw-r--r-- 16,151 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
<?php

namespace MediaWiki\Tests\ResourceLoader;

use InvalidArgumentException;
use MediaWiki\MainConfigNames;
use MediaWiki\ResourceLoader\CodexModule;
use RuntimeException;
use Wikimedia\TestingAccessWrapper;

/**
 * @group ResourceLoader
 * @covers \MediaWiki\ResourceLoader\CodexModule
 */
class CodexModuleTest extends ResourceLoaderTestCase {

	public const FIXTURE_PATH = 'tests/phpunit/data/resourceloader/codex';
	public const DEVMODE_FIXTURE_PATH = 'tests/phpunit/data/resourceloader/codex-devmode';

	public static function provideModuleConfig() {
		yield 'Codex subset' => [
				[
					'codexComponents' => [ 'CdxButton', 'CdxMessage', 'useModelWrapper' ],
					'codexStyleOnly' => false,
					'codexScriptOnly' => false
				],
				[
					'packageFiles' => [
						'codex.js',
						'_codex/constants.js',
						'_codex/useSlotContents2.js',
						'_codex/useWarnOnce.js',
						'_codex/useIconOnlyButton.js',
						'_codex/_plugin-vue_export-helper.js',
						'_codex/CdxButton.js',
						'_codex/useComputedDirection.js',
						'_codex/useComputedLanguage.js',
						'_codex/Icon.js',
						'_codex/CdxMessage.js',
						'_codex/useModelWrapper.js'
					],
					'styles' => [ 'modules/CdxButton.css', 'modules/CdxIcon.css', 'modules/CdxMessage.css' ]
				]
		];
		yield 'Codex subset, style only' => [
			[
				'codexComponents' => [ 'CdxButton', 'CdxMessage' ],
				'codexStyleOnly' => true,
				'codexScriptOnly' => false
			],
			[
				'packageFiles' => [],
				'styles' => [ 'modules/CdxButton.css', 'modules/CdxIcon.css', 'modules/CdxMessage.css' ]
			]
		];
		yield 'Codex subset, script only' => [
			[
				'codexComponents' => [ 'CdxButton', 'CdxMessage', 'useModelWrapper' ],
				'codexStyleOnly' => false,
				'codexScriptOnly' => true
			],
			[
				'packageFiles' => [
					'codex.js',
					'_codex/constants.js',
					'_codex/useSlotContents2.js',
					'_codex/useWarnOnce.js',
					'_codex/useIconOnlyButton.js',
					'_codex/_plugin-vue_export-helper.js',
					'_codex/CdxButton.js',
					'_codex/useComputedDirection.js',
					'_codex/useComputedLanguage.js',
					'_codex/Icon.js',
					'_codex/CdxMessage.js',
					'_codex/useModelWrapper.js'
				],
				'styles' => []
			]
		];
		yield 'Exception thrown when a chunk is requested' => [
			[
				'codexComponents' => [ 'CdxButton', 'buttonHelpers' ],
			],
			[
				'exception' => [
					'class' => InvalidArgumentException::class,
					'message' => '"buttonHelpers" is not an export of Codex and cannot be included in the "codexComponents" array.'
				]
			]
		];
		yield 'Exception thrown when a nonexistent file is requested' => [
			[
				'codexComponents' => [ 'CdxButton', 'blahblahidontexistblah' ],
			],
			[
				'exception' => [
					'class' => InvalidArgumentException::class,
					'message' => '"blahblahidontexistblah" is not an export of Codex and cannot be included in the "codexComponents" array.'
				]
			]
		];
		yield 'Exception thrown when codexComponents is empty in the module definition' => [
			[
				'codexComponents' => []
			],
			[
				'exception' => [
					'class' => InvalidArgumentException::class,
					'message' => "All 'codexComponents' properties in your module definition file " .
					'must either be omitted or be an array with at least one component name'
				]
			]
		];
		yield 'Exception thrown when codexComponents is not an array in the module definition' => [
			[
				'codexComponents' => ''
			],
			[
				'exception' => [
					'class' => InvalidArgumentException::class,
					'message' => "All 'codexComponents' properties in your module definition file " .
					'must either be omitted or be an array with at least one component name'
				]
			]
		];

		yield 'Exception thrown when the @wikimedia/codex module is required' => [
			[
				'codexComponents' => [ 'CdxButton', 'buttonHelpers' ],
				'dependencies' => [ '@wikimedia/codex' ]
			],
			[
				'exception' => [
					'class' => InvalidArgumentException::class,
					'message' => 'ResourceLoader modules using the CodexModule class cannot ' .
						"list the '@wikimedia/codex' module as a dependency. " .
						"Instead, use 'codexComponents' to require a subset of components."
				]
			]
		];

		yield 'Full library' => [
			[
				'codexFullLibrary' => true
			],
			[
				'packageFiles' => [
					'codex.js'
				],
				'styles' => [
					'codex.style.css'
				]
			]
		];

		yield 'Full library, script only' => [
			[
				'codexFullLibrary' => true,
				'codexScriptOnly' => true
			],
			[
				'packageFiles' => [
					'codex.js'
				],
				'styles' => []
			]
		];

		yield 'Full library, style only' => [
			[
				'codexFullLibrary' => true,
				'codexStyleOnly' => true
			],
			[
				'packageFiles' => [],
				'styles' => [
					'codex.style.css'
				]
			]
		];
	}

	/**
	 * @dataProvider provideModuleConfig
	 */
	public function testCodexSubset( $moduleDefinition, $expected ) {
		if ( isset( $expected['exception'] ) ) {
			$this->expectException( $expected['exception']['class'] );
			$this->expectExceptionMessage( $expected['exception']['message'] );
		}

		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};

		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );

		$packageFiles = $testModule->getPackageFiles( $context );
		$styleFiles = $testModule->getStyleFiles( $context );

		// Style-only module will not have any packageFiles.
		$packageFilenames = isset( $packageFiles ) ? array_keys( $packageFiles[ 'files' ] ) : [];
		$this->assertEquals( $expected[ 'packageFiles' ] ?? [], $packageFilenames, 'Correct packageFiles added' );

		// Script-only module will not have any styleFiles.
		$styleFilenames = [];
		if ( count( $styleFiles ) > 0 ) {
			$styleFilenames = array_map( static function ( $filepath ) use ( $testModule ) {
				return str_replace( $testModule::CODEX_DEFAULT_LIBRARY_DIR . '/', '', $filepath->getPath() );
			}, $styleFiles[ 'all' ] );
		}
		$this->assertEquals( $expected[ 'styles' ] ?? [], $styleFilenames, 'Correct styleFiles added' );
	}

	public function testMissingCodexComponentsDefinition() {
		$moduleDefinition = [
			'codexComponents' => [ 'CdxButton', 'CdxMessage' ]
		];

		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};

		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );

		$packageFiles = $testModule->getPackageFiles( $context );

		$codexPackageFileContent = $packageFiles[ 'files' ][ 'codex.js' ][ 'content' ];
		$expectedProxiedExports = '{"CdxButton":require( "./_codex/CdxButton.js" ),'
			. '"CdxMessage":require( "./_codex/CdxMessage.js" )}';

		// Components defined in the 'codexComponents' array should be proxied in the codex.js
		// package file so that missing components will throw a custom error when required.
		// By asserting what components are proxied, we are indirectly asserting that missing
		// components would throw an error when required.
		$this->assertStringContainsString( $expectedProxiedExports, $codexPackageFileContent );
	}

	public function testGetManifestFile() {
		$moduleDefinition = [ 'codexComponents' => [ 'CdxButton', 'CdxMessage' ] ];
		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};

		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );
		$testWrapper = TestingAccessWrapper::newFromObject( $testModule );

		// By default, look for a manifest file called "manifest.json"
		$this->assertEquals(
			MW_INSTALL_PATH . '/' . self::FIXTURE_PATH . '/modules/manifest.json',
			$testWrapper->getManifestFilePath( $context )
		);
	}

	public function testGetMessages() {
		$messageKeysFromFile = json_decode( file_get_contents(
			MW_INSTALL_PATH . '/' . self::FIXTURE_PATH . '/messageKeys.json'
		) );

		$moduleDefinition = [ 'codexComponents' => [ 'CdxButton', 'CdxMessage' ] ];
		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};
		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );
		$this->assertEquals(
			$messageKeysFromFile,
			$testModule->getMessages(),
			'i18n messages from messageKeys.json are added'
		);

		$moduleDefinition = [
			'codexComponents' => [ 'CdxButton', 'CdxMessage' ],
			'messages' => [ 'monday', 'tuesday' ]
		];
		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};
		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );
		$this->assertEquals(
			array_merge( [ 'monday', 'tuesday' ], $messageKeysFromFile ),
			$testModule->getMessages(),
			'i18n messages from messageKeys.json are in addition to messages in module definition'
		);

		$moduleDefinition = [
			'codexFullLibrary' => true
		];
		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};
		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );
		$this->assertEquals(
			$messageKeysFromFile,
			$testModule->getMessages(),
			'i18n messages are added for full library modules'
		);

		$moduleDefinition = [
			'codexComponents' => [ 'CdxButton', 'CdxMessage' ],
			'codexStyleOnly' => true
		];
		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};
		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );
		$this->assertEquals(
			[],
			$testModule->getMessages(),
			'i18n messages are not added for style-only modules'
		);
	}

	public function testDevMode() {
		$devDir = MW_INSTALL_PATH . '/' . self::DEVMODE_FIXTURE_PATH;
		$this->overrideConfigValues( [
			MainConfigNames::CodexDevelopmentDir => $devDir
		] );

		$moduleDefinition = [ 'codexComponents' => [ 'CdxButton', 'CdxMessage' ] ];
		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};

		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );
		$testWrapper = TestingAccessWrapper::newFromObject( $testModule );

		$this->assertEquals(
			$devDir . '/packages/codex/dist/modules/manifest.json',
			$testWrapper->getManifestFilePath( $context ),
			'Manifest path is based on dev mode path'
		);

		$packageFiles = $testModule->getPackageFiles( $context );
		$this->assertEquals(
			$devDir . '/packages/codex/dist/modules/CdxButton.js',
			$packageFiles[ 'files' ][ '_codex/CdxButton.js' ][ 'filePath' ]->getLocalPath(),
			'Package file paths are based on dev mode path'
		);

		$styleFiles = $testModule->getStyleFiles( $context );
		$this->assertEquals(
			$devDir . '/packages/codex/dist/modules/CdxButton.css',
			$styleFiles[ 'all' ][ 0 ]->getLocalPath(),
			'Style file paths are based on dev mode path'
		);

		$this->assertEquals(
			[ 'cdx-test-message-1', 'cdx-test-message-2' ],
			$testModule->getMessages(),
			'i18n message keys come from messages file in dev mode path'
		);

		$fullLibraryModuleDefinition = [ 'codexFullLibrary' => true ];
		$fullLibraryModule = new class( $fullLibraryModuleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};
		$fullLibraryModule->setConfig( $config );

		$packageFiles = $fullLibraryModule->getPackageFiles( $context );
		$this->assertEquals(
			$devDir . '/packages/codex/dist/codex.umd.cjs',
			$packageFiles[ 'files' ][ 'codex.js' ][ 'versionFilePath' ]->getLocalPath(),
			'Full library module script path is based on dev mode path'
		);

		$styleFiles = $fullLibraryModule->getStyleFiles( $context );
		$this->assertEquals(
			$devDir . '/packages/codex/dist/codex.style.css',
			$styleFiles[ 'all' ][ 0 ]->getLocalPath(),
			'Full library module style path is based on dev mode path'
		);
	}

	public function testDevModeException() {
		$badDir = MW_INSTALL_PATH . '/' . self::DEVMODE_FIXTURE_PATH . '/path/that/does/not/exist';
		$this->overrideConfigValues( [
			MainConfigNames::CodexDevelopmentDir => $badDir
		] );

		$this->expectException( RuntimeException::class );
		$this->expectExceptionMessage( 'Could not find Codex development build' );

		$moduleDefinition = [ 'codexComponents' => [ 'CdxButton', 'CdxMessage' ] ];
		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};
		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );

		$testModule->getPackageFiles( $context );
	}

	/**
	 * Test that the manifest data structure is transformed correctly.
	 * This test relies on the fixture manifest data that lives in
	 * tests/phpunit/data/resourceloader/codexModules
	 */
	public function testGetCodexFiles() {
		$moduleDefinition = [ 'codexComponents' => [ 'CdxButton', 'CdxMessage' ] ];
		$testModule = new class( $moduleDefinition ) extends CodexModule {
			public const CODEX_DEFAULT_LIBRARY_DIR = CodexModuleTest::FIXTURE_PATH;
		};

		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$testModule->setConfig( $config );
		$testWrapper = TestingAccessWrapper::newFromObject( $testModule );
		$codexFiles = $testWrapper->getCodexFiles( $context );

		// The transformed data structure should have a "files" and a "components" array.
		$this->assertIsArray( $codexFiles );
		$this->assertArrayHasKey( 'files', $codexFiles );
		$this->assertArrayHasKey( 'components', $codexFiles );

		// The "components" array should contain keys like "CdxButton"
		// with values like "CdxButton.js" (matching the names in the manifest)
		$this->assertArrayHasKey( 'CdxButton', $codexFiles[ 'components' ] );
		$this->assertEquals( 'CdxButton.js', $codexFiles[ 'components' ][ 'CdxButton' ] );

		// The "files" array should contains keys like "CdxButton.js"
		// Items in this array are themselves arrays with "styles" and "dependencies" keys.
		$this->assertArrayHasKey( 'CdxButton.js', $codexFiles[ 'files' ] );
		$this->assertArrayHasKey( 'styles', $codexFiles[ 'files' ][ 'CdxButton.js' ] );
		$this->assertArrayHasKey( 'dependencies', $codexFiles[ 'files' ][ 'CdxButton.js' ] );
	}

	public function testGetIcons() {
		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();

		$icons = CodexModule::getIcons( $context, $config, [ 'cdxIconAdd', 'cdxIconNext' ] );
		$this->assertArrayHasKey( 'cdxIconAdd', $icons );
		$this->assertArrayHasKey( 'cdxIconNext', $icons );
		$this->assertArrayNotHasKey( 'cdxIconPrevious', $icons );
	}

	public function testGetIconsInDevMode() {
		$devDir = MW_INSTALL_PATH . '/' . self::DEVMODE_FIXTURE_PATH;
		$this->overrideConfigValues( [
			MainConfigNames::CodexDevelopmentDir => $devDir
		] );

		$context = $this->getResourceLoaderContext();
		$config = $context->getResourceLoader()->getConfig();
		$icons = CodexModule::getIcons( $context, $config, [ 'cdxIconAdd', 'cdxIconNext' ] );
		$this->assertArrayHasKey( 'cdxIconAdd', $icons );
		$this->assertArrayHasKey( 'cdxIconNext', $icons );
		$this->assertArrayNotHasKey( 'cdxIconPrevious', $icons );

		$this->assertEquals( 'test add icon', $icons['cdxIconAdd'] );
		$this->assertEquals( 'test next icon', $icons['cdxIconNext'] );
	}
}