1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343
|
<?php
namespace MediaWiki\Tests\Storage;
use MediaWiki\Storage\NameTableAccessException;
use MediaWiki\Storage\NameTableStore;
use MediaWikiIntegrationTestCase;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Log\NullLogger;
use Wikimedia\ObjectCache\BagOStuff;
use Wikimedia\ObjectCache\EmptyBagOStuff;
use Wikimedia\ObjectCache\HashBagOStuff;
use Wikimedia\ObjectCache\WANObjectCache;
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\InsertQueryBuilder;
use Wikimedia\Rdbms\LoadBalancer;
use Wikimedia\Rdbms\SelectQueryBuilder;
use Wikimedia\TestingAccessWrapper;
/**
* @author Addshore
* @group Database
* @covers \MediaWiki\Storage\NameTableStore
*/
class NameTableStoreTest extends MediaWikiIntegrationTestCase {
private function populateTable( $values ) {
if ( !$values ) {
return;
}
$insertValues = [];
foreach ( $values as $name ) {
$insertValues[] = [ 'role_name' => $name ];
}
$this->getDb()->newInsertQueryBuilder()
->insertInto( 'slot_roles' )
->rows( $insertValues )
->caller( __METHOD__ )
->execute();
}
private function getHashWANObjectCache( $cacheBag ) {
return new WANObjectCache( [ 'cache' => $cacheBag ] );
}
/**
* @param IDatabase $db
* @return LoadBalancer
*/
private function getMockLoadBalancer( $db ) {
$mock = $this->createMock( LoadBalancer::class );
$mock->method( 'getConnection' )->willReturn( $db );
return $mock;
}
/**
* @param int $insertCalls
* @param int $selectCalls
* @param int $selectFieldCalls
*
* @return MockObject&IDatabase
*/
private function getProxyDb( $insertCalls, $selectCalls, $selectFieldCalls ) {
$proxiedMethods = [
'select' => $selectCalls,
'insert' => $insertCalls,
'selectField' => $selectFieldCalls,
'affectedRows' => null,
'insertId' => null,
'getSessionLagStatus' => null,
'onTransactionPreCommitOrIdle' => null,
'doAtomicSection' => null,
'begin' => null,
'rollback' => null,
'commit' => null,
];
$mock = $this->createMock( IDatabase::class );
foreach ( $proxiedMethods as $method => $count ) {
$mock->expects( is_int( $count ) ? $this->exactly( $count ) : $this->any() )
->method( $method )
->willReturnCallback( function ( ...$args ) use ( $method ) {
return $this->getDb()->$method( ...$args );
} );
}
$mock->method( 'newSelectQueryBuilder' )->willReturnCallback( static fn () => new SelectQueryBuilder( $mock ) );
$mock->method( 'newInsertQueryBuilder' )->willReturnCallback( static fn () => new InsertQueryBuilder( $mock ) );
return $mock;
}
private function getNameTableSqlStore(
BagOStuff $cacheBag,
$insertCalls,
$selectCalls,
$selectFieldCalls,
$normalizationCallback = null,
$insertCallback = null
) {
return new NameTableStore(
$this->getMockLoadBalancer(
$this->getProxyDb( $insertCalls, $selectCalls, $selectFieldCalls )
),
$this->getHashWANObjectCache( $cacheBag ),
new NullLogger(),
'slot_roles', 'role_id', 'role_name',
$normalizationCallback,
false,
$insertCallback
);
}
public static function provideGetAndAcquireId() {
return [
'no wancache, empty table' =>
[ new EmptyBagOStuff(), true, 1, [], 'foo', 1 ],
'no wancache, one matching value' =>
[ new EmptyBagOStuff(), false, 1, [ 'foo' ], 'foo', 1 ],
'no wancache, one not matching value' =>
[ new EmptyBagOStuff(), true, 1, [ 'bar' ], 'foo', 2 ],
'no wancache, multiple, one matching value' =>
[ new EmptyBagOStuff(), false, 1, [ 'foo', 'bar' ], 'bar', 2 ],
'no wancache, multiple, no matching value' =>
[ new EmptyBagOStuff(), true, 1, [ 'foo', 'bar' ], 'baz', 3 ],
'wancache, empty table' =>
[ new HashBagOStuff(), true, 1, [], 'foo', 1 ],
'wancache, one matching value' =>
[ new HashBagOStuff(), false, 1, [ 'foo' ], 'foo', 1 ],
'wancache, one not matching value' =>
[ new HashBagOStuff(), true, 1, [ 'bar' ], 'foo', 2 ],
'wancache, multiple, one matching value' =>
[ new HashBagOStuff(), false, 1, [ 'foo', 'bar' ], 'bar', 2 ],
'wancache, multiple, no matching value' =>
[ new HashBagOStuff(), true, 1, [ 'foo', 'bar' ], 'baz', 3 ],
];
}
/**
* @dataProvider provideGetAndAcquireId
* @param BagOStuff $cacheBag to use in the WANObjectCache service
* @param bool $needsInsert Does the value we are testing need to be inserted?
* @param int $selectCalls Number of times the select DB method will be called
* @param string[] $existingValues to be added to the db table
* @param string $name name to acquire
* @param int $expectedId the id we expect the name to have
*/
public function testGetAndAcquireId(
$cacheBag,
$needsInsert,
$selectCalls,
$existingValues,
$name,
$expectedId
) {
$this->populateTable( $existingValues );
$store = $this->getNameTableSqlStore( $cacheBag, (int)$needsInsert, $selectCalls, 0 );
// Some names will not initially exist
try {
$result = $store->getId( $name );
$this->assertSame( $expectedId, $result );
} catch ( NameTableAccessException $e ) {
if ( $needsInsert ) {
$this->assertTrue( true ); // Expected exception
} else {
$this->fail( 'Did not expect an exception, but got one: ' . $e->getMessage() );
}
}
// All names should return their id here
$this->assertSame( $expectedId, $store->acquireId( $name ) );
// acquireId inserted these names, so now everything should exist with getId
$this->assertSame( $expectedId, $store->getId( $name ) );
// calling getId again will also still work, and not result in more selects
$this->assertSame( $expectedId, $store->getId( $name ) );
}
public static function provideTestGetAndAcquireIdNameNormalization() {
yield [ 'A', 'a', 'strtolower' ];
yield [ 'b', 'B', 'strtoupper' ];
yield [ 'X', 'X', static fn ( $name ) => $name ];
yield [ 'ZZ', 'ZZ-a', static fn ( $name ) => "$name-a" ];
}
/**
* @dataProvider provideTestGetAndAcquireIdNameNormalization
*/
public function testGetAndAcquireIdNameNormalization(
$nameIn,
$nameOut,
$normalizationCallback
) {
$store = $this->getNameTableSqlStore(
new EmptyBagOStuff(),
1,
1,
0,
$normalizationCallback
);
$acquiredId = $store->acquireId( $nameIn );
$this->assertSame( $nameOut, $store->getName( $acquiredId ) );
}
public static function provideGetName() {
return [
[ new HashBagOStuff(), 3, 2 ],
[ new EmptyBagOStuff(), 3, 3 ],
];
}
/**
* @dataProvider provideGetName
*/
public function testGetName( BagOStuff $cacheBag, $insertCalls, $selectCalls ) {
$now = microtime( true );
$cacheBag->setMockTime( $now );
// Check for operations to in-memory cache (IMC) and persistent cache (PC)
$store = $this->getNameTableSqlStore( $cacheBag, $insertCalls, $selectCalls, 0 );
// Get 1 ID and make sure getName returns correctly
$fooId = $store->acquireId( 'foo' ); // regen PC, set IMC, update IMC, tombstone PC
$now += 0.01;
$this->assertSame( 'foo', $store->getName( $fooId ) ); // use IMC
$now += 0.01;
// Get another ID and make sure getName returns correctly
$barId = $store->acquireId( 'bar' ); // update IMC, tombstone PC
$now += 0.01;
$this->assertSame( 'bar', $store->getName( $barId ) ); // use IMC
$now += 0.01;
// Blitz the cache and make sure it still returns
TestingAccessWrapper::newFromObject( $store )->tableCache = null; // clear IMC
$this->assertSame( 'foo', $store->getName( $fooId ) ); // regen interim PC, set IMC
$this->assertSame( 'bar', $store->getName( $barId ) ); // use IMC
// Blitz the cache again and get another ID and make sure getName returns correctly
TestingAccessWrapper::newFromObject( $store )->tableCache = null; // clear IMC
$bazId = $store->acquireId( 'baz' ); // set IMC using interim PC, update IMC, tombstone PC
$now += 0.01;
$this->assertSame( 'baz', $store->getName( $bazId ) ); // uses IMC
$this->assertSame( 'baz', $store->getName( $bazId ) ); // uses IMC
}
public function testGetName_masterFallback() {
$store = $this->getNameTableSqlStore( new EmptyBagOStuff(), 1, 2, 0 );
// Insert a new name
$fooId = $store->acquireId( 'foo' );
// Empty the process cache, getCachedTable() will now return this empty array
TestingAccessWrapper::newFromObject( $store )->tableCache = [];
// getName should fallback to master, which is why we assert 2 selectCalls above
$this->assertSame( 'foo', $store->getName( $fooId ) );
}
public function testGetMap_empty() {
$this->populateTable( [] );
$store = $this->getNameTableSqlStore( new HashBagOStuff(), 0, 1, 0 );
$table = $store->getMap();
$this->assertSame( [], $table );
}
public function testGetMap_twoValues() {
$this->populateTable( [ 'foo', 'bar' ] );
$store = $this->getNameTableSqlStore( new HashBagOStuff(), 0, 1, 0 );
// We are using a cache, so 2 calls should only result in 1 select on the db
$store->getMap();
$table = $store->getMap();
$expected = [ 1 => 'foo', 2 => 'bar' ];
$this->assertSame( $expected, $table );
// Make sure the table returned is the same as the cached table
$this->assertSame( $expected, TestingAccessWrapper::newFromObject( $store )->tableCache );
}
public function testReloadMap() {
$this->populateTable( [ 'foo' ] );
$store = $this->getNameTableSqlStore( new HashBagOStuff(), 0, 2, 0 );
// force load
$this->assertCount( 1, $store->getMap() );
// add more stuff to the table, so the cache gets out of sync
$this->populateTable( [ 'bar' ] );
$expected = [ 1 => 'foo', 2 => 'bar' ];
$this->assertSame( $expected, $store->reloadMap() );
$this->assertSame( $expected, $store->getMap() );
}
public function testCacheRaceCondition() {
$wanHashBag = new HashBagOStuff();
$store1 = $this->getNameTableSqlStore( $wanHashBag, 1, 1, 0 );
$store2 = $this->getNameTableSqlStore( $wanHashBag, 1, 0, 0 );
$store3 = $this->getNameTableSqlStore( $wanHashBag, 2, 0, 2 );
// Cache the current table in the instances we will use
// This simulates multiple requests running simultaneously
$store1->getMap();
$store2->getMap();
$store3->getMap();
// Store 2 separate names using different instances
$fooId = $store1->acquireId( 'foo' );
$barId = $store2->acquireId( 'bar' );
// Each of these instances should be aware of what they have inserted
$this->assertSame( $fooId, $store1->acquireId( 'foo' ) );
$this->assertSame( $barId, $store2->acquireId( 'bar' ) );
// A new store should be able to get both of these new Ids
// Note: before there was a race condition here where acquireId( 'bar' ) would update the
// cache with data missing the 'foo' key that it was not aware of
$store4 = $this->getNameTableSqlStore( $wanHashBag, 0, 1, 0 );
$this->assertSame( $fooId, $store4->getId( 'foo' ) );
$this->assertSame( $barId, $store4->getId( 'bar' ) );
// If a store with old cached data tries to acquire these we will get the same ids.
$this->assertSame( $fooId, $store3->acquireId( 'foo' ) );
$this->assertSame( $barId, $store3->acquireId( 'bar' ) );
}
public function testGetAndAcquireIdInsertCallback() {
// Postgres does not allow to specify the SERIAL column on insert to fake an id
$this->markTestSkippedIfDbType( 'postgres' );
$store = $this->getNameTableSqlStore(
new EmptyBagOStuff(),
1,
1,
0,
null,
static function ( $insertFields ) {
$insertFields['role_id'] = 7251;
return $insertFields;
}
);
$this->assertSame( 7251, $store->acquireId( 'A' ) );
}
}
|