1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332
|
<?php
namespace MediaWiki\Tests\Api;
use MediaWiki\Block\DatabaseBlock;
use MediaWiki\MainConfigNames;
use MediaWiki\MainConfigSchema;
use MediaWiki\Title\Title;
use MediaWiki\User\User;
use TestUserRegistry;
/**
* @group API
* @group Database
* @group medium
*
* @covers MediaWiki\Api\ApiUserrights
*/
class ApiUserrightsTest extends ApiTestCase {
protected function setUp(): void {
parent::setUp();
$this->overrideConfigValues( [
MainConfigNames::AddGroups => [],
MainConfigNames::RemoveGroups => [],
] );
}
/**
* Unsets $wgGroupPermissions['bureaucrat']['userrights'], and sets
* $wgAddGroups['bureaucrat'] and $wgRemoveGroups['bureaucrat'] to the
* specified values.
*
* @param array|bool $add Groups bureaucrats should be allowed to add, true for all
* @param array|bool $remove Groups bureaucrats should be allowed to remove, true for all
*/
protected function setPermissions( $add = [], $remove = [] ) {
$this->setGroupPermissions( 'bureaucrat', 'userrights', false );
if ( $add ) {
$this->overrideConfigValue(
MainConfigNames::AddGroups,
[ 'bureaucrat' => $add ] + MainConfigSchema::getDefaultValue( MainConfigNames::AddGroups )
);
}
if ( $remove ) {
$this->overrideConfigValue(
MainConfigNames::RemoveGroups,
[ 'bureaucrat' => $remove ] + MainConfigSchema::getDefaultValue( MainConfigNames::RemoveGroups )
);
}
}
/**
* Perform an API userrights request that's expected to be successful.
*
* @param array|string $expectedGroups Group(s) that the user is expected
* to have after the API request
* @param array $params Array to pass to doApiRequestWithToken(). 'action'
* => 'userrights' is implicit. If no 'user' or 'userid' is specified,
* we add a 'user' parameter. If no 'add' or 'remove' is specified, we
* add 'add' => 'sysop'.
* @param User|null $user The user that we're modifying. The user must be
* mutable, because we're going to change its groups! null means that
* we'll make up our own user to modify, and doesn't make sense if 'user'
* or 'userid' is specified in $params.
*/
protected function doSuccessfulRightsChange(
$expectedGroups = 'sysop', array $params = [], ?User $user = null
) {
$expectedGroups = (array)$expectedGroups;
$params['action'] = 'userrights';
if ( !$user ) {
$user = $this->getMutableTestUser()->getUser();
}
$this->assertTrue( TestUserRegistry::isMutable( $user ),
'Immutable user passed to doSuccessfulRightsChange!' );
if ( !isset( $params['user'] ) && !isset( $params['userid'] ) ) {
$params['user'] = $user->getName();
}
if ( !isset( $params['add'] ) && !isset( $params['remove'] ) ) {
$params['add'] = 'sysop';
}
$res = $this->doApiRequestWithToken( $params );
$user->clearInstanceCache();
$this->getServiceContainer()->getPermissionManager()->invalidateUsersRightsCache();
$this->assertSame(
$expectedGroups, $this->getServiceContainer()->getUserGroupManager()->getUserGroups( $user )
);
$this->assertArrayNotHasKey( 'warnings', $res[0] );
}
/**
* Perform an API userrights request that's expected to fail.
*
* @param string $expectedCode Expected API error code
* @param array $params As for doSuccessfulRightsChange()
* @param User|null $user As for doSuccessfulRightsChange(). If there's no
* user who will possibly be affected (such as if an invalid username is
* provided in $params), pass null.
*/
private function doFailedRightsChange(
$expectedCode, array $params = [], ?User $user = null
) {
$params['action'] = 'userrights';
$userGroupManager = $this->getServiceContainer()->getUserGroupManager();
$this->expectApiErrorCode( $expectedCode );
if ( !$user ) {
// If 'user' or 'userid' is specified and $user was not specified,
// the user we're creating now will have nothing to do with the API
// request, but that's okay, since we're just testing that it has
// no groups.
$user = $this->getMutableTestUser()->getUser();
}
$this->assertTrue( TestUserRegistry::isMutable( $user ),
'Immutable user passed to doFailedRightsChange!' );
if ( !isset( $params['user'] ) && !isset( $params['userid'] ) ) {
$params['user'] = $user->getName();
}
if ( !isset( $params['add'] ) && !isset( $params['remove'] ) ) {
$params['add'] = 'sysop';
}
$expectedGroups = $userGroupManager->getUserGroups( $user );
try {
$this->doApiRequestWithToken( $params );
} finally {
$user->clearInstanceCache();
$this->assertSame( $expectedGroups, $userGroupManager->getUserGroups( $user ) );
}
}
public function testAdd() {
$this->doSuccessfulRightsChange();
}
public function testBlockedWithUserrights() {
$user = $this->getTestSysop()->getUser();
$block = new DatabaseBlock( [ 'address' => $user, 'by' => $user, ] );
$blockStore = $this->getServiceContainer()->getDatabaseBlockStore();
$blockStore->insertBlock( $block );
$this->doSuccessfulRightsChange();
}
public function testBlockedWithoutUserrights() {
$user = $this->getTestSysop()->getUser();
$this->setPermissions( true, true );
$block = new DatabaseBlock( [ 'address' => $user, 'by' => $user ] );
$blockStore = $this->getServiceContainer()->getDatabaseBlockStore();
$blockStore->insertBlock( $block );
$this->doFailedRightsChange( 'blocked' );
}
public function testAddMultiple() {
$this->doSuccessfulRightsChange(
[ 'bureaucrat', 'sysop' ],
[ 'add' => 'bureaucrat|sysop' ]
);
}
public function testTooFewExpiries() {
$this->doFailedRightsChange(
'toofewexpiries',
[ 'add' => 'sysop|bureaucrat|bot', 'expiry' => 'infinity|tomorrow' ]
);
}
public function testTooManyExpiries() {
$this->doFailedRightsChange(
'toofewexpiries',
[ 'add' => 'sysop|bureaucrat', 'expiry' => 'infinity|tomorrow|never' ]
);
}
public function testInvalidExpiry() {
$this->doFailedRightsChange( 'invalidexpiry', [ 'expiry' => 'yummy lollipops!' ] );
}
public function testMultipleInvalidExpiries() {
$this->doFailedRightsChange(
'invalidexpiry',
[ 'add' => 'sysop|bureaucrat', 'expiry' => 'foo|bar' ]
);
}
public function testWithTag() {
$this->getServiceContainer()->getChangeTagsStore()->defineTag( 'custom tag' );
$user = $this->getMutableTestUser()->getUser();
$this->doSuccessfulRightsChange( 'sysop', [ 'tags' => 'custom tag' ], $user );
$this->assertSame(
'custom tag',
$this->getDb()->newSelectQueryBuilder()
->select( 'ctd_name' )
->from( 'logging' )
->join( 'change_tag', null, 'ct_log_id = log_id' )
->join( 'change_tag_def', null, 'ctd_id = ct_tag_id' )
->where( [ 'log_namespace' => NS_USER, 'log_title' => strtr( $user->getName(), ' ', '_' ) ] )
->caller( __METHOD__ )->fetchField() );
}
public function testWithoutTagPermission() {
$this->getServiceContainer()->getChangeTagsStore()->defineTag( 'custom tag' );
$this->setGroupPermissions( 'user', 'applychangetags', false );
$this->doFailedRightsChange(
'tags-apply-no-permission',
[ 'tags' => 'custom tag' ]
);
}
public function testNonexistentUser() {
$this->doFailedRightsChange(
'nosuchuser',
[ 'user' => 'Nonexistent user' ]
);
}
public function testWebToken() {
$sysop = $this->getTestSysop()->getUser();
$user = $this->getMutableTestUser()->getUser();
$token = $sysop->getEditToken( $user->getName() );
$res = $this->doApiRequest( [
'action' => 'userrights',
'user' => $user->getName(),
'add' => 'sysop',
'token' => $token,
] );
$user->clearInstanceCache();
$this->assertSame( [ 'sysop' ], $this->getServiceContainer()->getUserGroupManager()->getUserGroups( $user ) );
$this->assertArrayNotHasKey( 'warnings', $res[0] );
}
/**
* Tests adding and removing various groups with various permissions.
*
* @dataProvider addAndRemoveGroupsProvider
* @param array|null $permissions [ [ $wgAddGroups, $wgRemoveGroups ] ] or null for 'userrights'
* to be set in $wgGroupPermissions
* @param array $groupsToChange [ [ groups to add ], [ groups to remove ] ]
* @param array $expectedGroups Array of expected groups
*/
public function testAddAndRemoveGroups(
?array $permissions, array $groupsToChange, array $expectedGroups
) {
if ( $permissions !== null ) {
$this->setPermissions( $permissions[0], $permissions[1] );
}
$params = [
'add' => implode( '|', $groupsToChange[0] ),
'remove' => implode( '|', $groupsToChange[1] ),
];
// We'll take a bot so we have a group to remove
$user = $this->getMutableTestUser( [ 'bot' ] )->getUser();
$this->doSuccessfulRightsChange( $expectedGroups, $params, $user );
}
public static function addAndRemoveGroupsProvider() {
return [
'Simple add' => [
[ [ 'sysop' ], [] ],
[ [ 'sysop' ], [] ],
[ 'bot', 'sysop' ]
], 'Add with only remove permission' => [
[ [], [ 'sysop' ] ],
[ [ 'sysop' ], [] ],
[ 'bot' ],
], 'Add with global remove permission' => [
[ [], true ],
[ [ 'sysop' ], [] ],
[ 'bot' ],
], 'Simple remove' => [
[ [], [ 'bot' ] ],
[ [], [ 'bot' ] ],
[],
], 'Remove with only add permission' => [
[ [ 'bot' ], [] ],
[ [], [ 'bot' ] ],
[ 'bot' ],
], 'Remove with global add permission' => [
[ true, [] ],
[ [], [ 'bot' ] ],
[ 'bot' ],
], 'Add and remove same new group' => [
null,
[ [ 'sysop' ], [ 'sysop' ] ],
// The userrights code does removals before adds, so it doesn't remove the sysop
// group here and only adds it.
[ 'bot', 'sysop' ],
], 'Add and remove same existing group' => [
null,
[ [ 'bot' ], [ 'bot' ] ],
// But here it first removes the existing group and then re-adds it.
[ 'bot' ],
],
];
}
public function testWatched() {
$user = $this->getMutableTestUser()->getUser();
$userPage = Title::makeTitle( NS_USER, $user->getName() );
$this->doSuccessfulRightsChange( 'sysop', [ 'watchuser' => true ], $user );
$this->assertTrue( $this->getServiceContainer()->getWatchlistManager()
->isWatched( $this->getTestSysop()->getUser(), $userPage ) );
}
}
|