1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510
|
<?php
use MediaWiki\Status\Status;
use PHPUnit\Framework\Constraint\IsType;
use PHPUnit\Framework\MockObject\MockObject;
use Wikimedia\Http\MultiHttpClient;
use Wikimedia\Http\TelemetryHeadersInterface;
use Wikimedia\TestingAccessWrapper;
/**
* The urls herein are not actually called, because we mock the return results.
*
* @covers \Wikimedia\Http\MultiHttpClient
*/
class MultiHttpClientTest extends MediaWikiIntegrationTestCase {
/**
* @param array $options
* @return MultiHttpClient|MockObject
*/
private function createClient( $options = [] ) {
$client = $this->getMockBuilder( MultiHttpClient::class )
->setConstructorArgs( [ $options ] )
->onlyMethods( [ 'isCurlEnabled' ] )->getMock();
$client->method( 'isCurlEnabled' )->willReturn( false );
return $client;
}
private function getHttpRequest( $statusValue, $statusCode, $headers = [] ) {
$options = [
'timeout' => 1,
'connectTimeout' => 1
];
$httpRequest = $this->getMockBuilder( MWHttpRequest::class )
->setConstructorArgs( [ '', $options ] )
->getMock();
$httpRequest->method( 'execute' )
->willReturn( Status::wrap( $statusValue ) );
$httpRequest->method( 'getResponseHeaders' )
->willReturn( $headers );
$httpRequest->method( 'getStatus' )
->willReturn( $statusCode );
return $httpRequest;
}
private function mockHttpRequestFactory( $httpRequest ) {
$factory = $this->createMock( MediaWiki\Http\HttpRequestFactory::class );
$factory->method( 'create' )
->willReturn( $httpRequest );
return $factory;
}
/**
* Test call of a single url that should succeed
*/
public function testMultiHttpClientSingleSuccess() {
// Mock success
$httpRequest = $this->getHttpRequest( StatusValue::newGood( 200 ), 200 );
$this->setService( 'HttpRequestFactory', $this->mockHttpRequestFactory( $httpRequest ) );
[ $rcode, $rdesc, /* $rhdrs */, $rbody, $rerr ] = $this->createClient()->run( [
'method' => 'GET',
'url' => "http://example.test",
] );
$this->assertSame( 200, $rcode );
}
/**
* Test call of a single url that should not exist, and therefore fail
*/
public function testMultiHttpClientSingleFailure() {
// Mock an invalid tld
$httpRequest = $this->getHttpRequest(
StatusValue::newFatal( 'http-invalid-url', 'http://www.example.test' ), 0 );
$this->setService( 'HttpRequestFactory', $this->mockHttpRequestFactory( $httpRequest ) );
[ $rcode, $rdesc, /* $rhdrs */, $rbody, $rerr ] = $this->createClient()->run( [
'method' => 'GET',
'url' => "http://www.example.test",
] );
$this->assertSame( 0, $rcode );
}
/**
* Test call of multiple urls that should all succeed
*/
public function testMultiHttpClientMultipleSuccess() {
// Mock success
$httpRequest = $this->getHttpRequest( StatusValue::newGood( 200 ), 200 );
$this->setService( 'HttpRequestFactory', $this->mockHttpRequestFactory( $httpRequest ) );
$reqs = [
[
'method' => 'GET',
'url' => 'http://example.test',
],
[
'method' => 'GET',
'url' => 'https://get.test',
],
];
$responses = $this->createClient()->runMulti( $reqs );
foreach ( $responses as $response ) {
[ $rcode, $rdesc, /* $rhdrs */, $rbody, $rerr ] = $response['response'];
$this->assertSame( 200, $rcode );
}
}
/**
* Test call of multiple urls that should all fail
*/
public function testMultiHttpClientMultipleFailure() {
// Mock page not found
$httpRequest = $this->getHttpRequest(
StatusValue::newFatal( "http-bad-status", 404, 'Not Found' ), 404 );
$this->setService( 'HttpRequestFactory', $this->mockHttpRequestFactory( $httpRequest ) );
$reqs = [
[
'method' => 'GET',
'url' => 'http://example.test/12345',
],
[
'method' => 'GET',
'url' => 'http://example.test/67890',
]
];
$responses = $this->createClient()->runMulti( $reqs );
foreach ( $responses as $response ) {
[ $rcode, $rdesc, /* $rhdrs */, $rbody, $rerr ] = $response['response'];
$this->assertSame( 404, $rcode );
}
}
/**
* Test of response header handling
*/
public function testMultiHttpClientHeaders() {
// Represenative headers for typical requests, per MWHttpRequest::getResponseHeaders()
$headers = [
'content-type' => [
'text/html; charset=utf-8',
],
'date' => [
'Wed, 18 Jul 2018 14:52:41 GMT',
],
'set-cookie' => [
'COUNTRY=NAe6; expires=Wed, 25-Jul-2018 14:52:41 GMT; path=/; domain=.example.test',
'LAST_NEWS=1531925562; expires=Thu, 18-Jul-2019 14:52:41 GMT; path=/; domain=.example.test',
]
];
// Mock success with specific headers
$httpRequest = $this->getHttpRequest( StatusValue::newGood( 200 ), 200, $headers );
$this->setService( 'HttpRequestFactory', $this->mockHttpRequestFactory( $httpRequest ) );
[ $rcode, $rdesc, $rhdrs, $rbody, $rerr ] = $this->createClient()->run( [
'method' => 'GET',
'url' => 'http://example.test',
] );
$this->assertSame( 200, $rcode );
$this->assertSameSize( $headers, $rhdrs );
foreach ( $headers as $name => $values ) {
$value = implode( ', ', $values );
$this->assertArrayHasKey( $name, $rhdrs );
$this->assertEquals( $value, $rhdrs[$name] );
}
}
public static function provideMultiHttpTimeout() {
return [
'default 10/30' => [
[],
[],
10,
30
],
'constructor override' => [
[ 'connTimeout' => 2, 'reqTimeout' => 3 ],
[],
2,
3
],
'run override' => [
[],
[ 'connTimeout' => 2, 'reqTimeout' => 3 ],
2,
3
],
'constructor max option limits default' => [
[ 'maxConnTimeout' => 2, 'maxReqTimeout' => 3 ],
[],
2,
3
],
'constructor max option limits regular constructor option' => [
[
'maxConnTimeout' => 2,
'maxReqTimeout' => 3,
'connTimeout' => 100,
'reqTimeout' => 100
],
[],
2,
3
],
'constructor max option greater than regular constructor option' => [
[
'maxConnTimeout' => 2,
'maxReqTimeout' => 3,
'connTimeout' => 1,
'reqTimeout' => 1
],
[],
1,
1
],
'constructor max option limits run option' => [
[
'maxConnTimeout' => 2,
'maxReqTimeout' => 3,
],
[
'connTimeout' => 100,
'reqTimeout' => 100
],
2,
3
],
];
}
/**
* Test of timeout parameter handling
* @dataProvider provideMultiHttpTimeout
*/
public function testMultiHttpTimeout( $createOptions, $runOptions,
$expectedConnTimeout, $expectedReqTimeout
) {
$url = 'http://www.example.test';
$httpRequest = $this->getHttpRequest( StatusValue::newGood( 200 ), 200 );
$factory = $this->createMock( MediaWiki\Http\HttpRequestFactory::class );
$factory->method( 'create' )
->with(
$url,
$this->callback(
static function ( $options ) use ( $expectedReqTimeout, $expectedConnTimeout ) {
return $options['timeout'] === $expectedReqTimeout
&& $options['connectTimeout'] === $expectedConnTimeout;
}
)
)
->willReturn( $httpRequest );
$this->setService( 'HttpRequestFactory', $factory );
$client = $this->createClient( $createOptions );
$client->run(
[ 'method' => 'GET', 'url' => $url ],
$runOptions
);
$this->addToAssertionCount( 1 );
}
public function testUseReverseProxy() {
// TODO: Cannot use TestingAccessWrapper here because it doesn't
// support pass-by-reference (T287318)
$class = new ReflectionClass( MultiHttpClient::class );
$func = $class->getMethod( 'useReverseProxy' );
$func->setAccessible( true );
$req = [
'url' => 'https://example.org/path?query=string',
];
$func->invokeArgs( new MultiHttpClient( [] ), [ &$req, 'http://localhost:1234' ] );
$this->assertSame( 'http://localhost:1234/path?query=string', $req['url'] );
$this->assertSame( 'example.org', $req['headers']['Host'] );
}
public function testNormalizeRequests() {
// TODO: Cannot use TestingAccessWrapper here because it doesn't
// support pass-by-reference (T287318)
$class = new ReflectionClass( MultiHttpClient::class );
$func = $class->getMethod( 'normalizeRequests' );
$func->setAccessible( true );
$reqs = [
[ 'GET', 'https://example.org/path?query=string' ],
[
'method' => 'GET',
'url' => 'https://example.com/path?query=another%20string',
'headers' => [
'header2' => 'value2'
]
],
];
$client = new MultiHttpClient( [
'localVirtualHosts' => [ 'example.org' ],
'localProxy' => 'http://localhost:1234',
'headers' => [
'header1' => 'value1'
]
] );
$func->invokeArgs( $client, [ &$reqs ] );
// Both requests have the default header added
$this->assertSame( 'value1', $reqs[0]['headers']['header1'] );
$this->assertSame( 'value1', $reqs[1]['headers']['header1'] );
// Only Req #1 has an additional header
$this->assertSame( 'value2', $reqs[1]['headers']['header2'] );
$this->assertArrayNotHasKey( 'header2', $reqs[0]['headers'] );
// Req #0 transformed to use reverse proxy
$this->assertSame( 'http://localhost:1234/path?query=string', $reqs[0]['url'] );
$this->assertSame( 'example.org', $reqs[0]['headers']['host'] );
$this->assertFalse( $reqs[0]['proxy'] );
// Req #1 left alone, domain doesn't match
$this->assertSame( 'https://example.com/path?query=another%20string', $reqs[1]['url'] );
}
/**
* @dataProvider provideAssembleUrl
* @param array $bits
* @param string $expected
* @throws ReflectionException
*/
public function testAssembleUrl( array $bits, string $expected ) {
$class = TestingAccessWrapper::newFromClass( MultiHttpClient::class );
$this->assertSame( $expected, $class->assembleUrl( $bits ) );
}
public static function provideAssembleUrl(): Generator {
$schemes = [
'' => [],
'http://' => [
'scheme' => 'http',
],
];
$hosts = [
'' => [],
'example.com' => [
'host' => 'example.com',
],
'example.com:123' => [
'host' => 'example.com',
'port' => 123,
],
'id@example.com' => [
'user' => 'id',
'host' => 'example.com',
],
'id@example.com:123' => [
'user' => 'id',
'host' => 'example.com',
'port' => 123,
],
'id:key@example.com' => [
'user' => 'id',
'pass' => 'key',
'host' => 'example.com',
],
'id:key@example.com:123' => [
'user' => 'id',
'pass' => 'key',
'host' => 'example.com',
'port' => 123,
],
];
foreach ( $schemes as $scheme => $schemeParts ) {
foreach ( $hosts as $host => $hostParts ) {
foreach ( [ '', '/', '/0', '/path' ] as $path ) {
foreach ( [ '', '0', 'query' ] as $query ) {
foreach ( [ '', '0', 'fragment' ] as $fragment ) {
$parts = array_merge(
$schemeParts,
$hostParts
);
$url = $scheme .
$host .
$path;
if ( $path !== '' ) {
$parts['path'] = $path;
}
if ( $query !== '' ) {
$parts['query'] = $query;
$url .= '?' . $query;
}
if ( $fragment !== '' ) {
$parts['fragment'] = $fragment;
$url .= '#' . $fragment;
}
yield [ $parts, $url ];
}
}
}
}
}
yield [
[
'scheme' => 'http',
'user' => 'id',
'pass' => 'key',
'host' => 'example.org',
'port' => 321,
'path' => '/over/there',
'query' => 'name=ferret&foo=bar',
'fragment' => 'nose',
],
'http://id:key@example.org:321/over/there?name=ferret&foo=bar#nose',
];
// Account for parse_url() on PHP >= 8 returning an empty query field for URLs ending with
// '?' such as "http://url.with.empty.query/foo?" (T268852)
yield [
[
'scheme' => 'http',
'host' => 'url.with.empty.query',
'path' => '/foo',
'query' => '',
],
'http://url.with.empty.query/foo',
];
}
public static function provideHeader() {
// Invalid
yield 'colon space' => [ false, [ 'Foo: X' => 'Y' ] ];
yield 'colon' => [ false, [ 'Foo:bar' => 'X' ] ];
yield 'two colon' => [ false, [ 'Foo:bar:baz' => 'X' ] ];
yield 'trailing colon' => [ false, [ 'Foo:' => 'Y' ] ];
yield 'leading colon' => [ false, [ ':Foo' => 'Y' ] ];
// Valid
yield 'word' => [ true, [ 'Foo' => 'X' ] ];
yield 'dash' => [ true, [ 'Foo-baz' => 'X' ] ];
}
/**
* @dataProvider provideHeader
*/
public function testNormalizeIllegalHeader( bool $valid, array $headers ) {
$class = new ReflectionClass( MultiHttpClient::class );
$func = $class->getMethod( 'getCurlHandle' );
$func->setAccessible( true );
$req = [
'method' => 'GET',
'url' => 'http://localhost:1234',
'query' => [],
'body' => '',
'headers' => $headers
];
if ( $valid ) {
$this->expectNotToPerformAssertions();
} else {
$this->expectException( Exception::class );
$this->expectExceptionMessage( 'Header name must not contain colon-space' );
}
$func->invokeArgs( new MultiHttpClient( [] ), [ &$req, [
'connTimeout' => 1,
'reqTimeout' => 1,
] ] );
// TODO: Factor out curl_multi_exec so can stub that,
// and then simply test the public runMulti() method here.
// Or move more logic to normalizeRequests and test that.
}
public function testForwardsTelemetryHeaders() {
$telemetry = $this->getMockBuilder( TelemetryHeadersInterface::class )
->getMock();
$telemetry->expects( $this->once() )
->method( 'getRequestHeaders' )
->willReturn( [ 'header1' => 'value1', 'header2' => 'value2' ] );
// TODO: Cannot use TestingAccessWrapper here because it doesn't
// support pass-by-reference (T287318)
$class = new ReflectionClass( MultiHttpClient::class );
$func = $class->getMethod( 'normalizeRequests' );
$func->setAccessible( true );
$reqs = [
[ 'GET', 'https://example.org/path?query=string' ],
];
$client = new MultiHttpClient( [
'localVirtualHosts' => [ 'example.org' ],
'localProxy' => 'http://localhost:1234',
'telemetry' => $telemetry
] );
$func->invokeArgs( $client, [ &$reqs ] );
$this->assertArrayHasKey( 'header1', $reqs[0]['headers'] );
$this->assertSame( 'value1', $reqs[0]['headers']['header1'] );
$this->assertArrayHasKey( 'header2', $reqs[0]['headers'] );
$this->assertSame( 'value2', $reqs[0]['headers']['header2'] );
}
public function testGetCurlMulti() {
$cm = TestingAccessWrapper::newFromObject( new MultiHttpClient( [] ) );
$resource = $cm->getCurlMulti( [ 'usePipelining' => true ] );
$this->assertThat(
$resource,
$this->logicalOr(
$this->isType( IsType::TYPE_RESOURCE ),
$this->isInstanceOf( 'CurlMultiHandle' )
)
);
}
}
|