1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
|
<?php
use MediaWiki\MainConfigNames;
/**
* Tests related to auto rotation.
*
* @group Media
* @group medium
*
* @covers \BitmapHandler
* @requires extension exif
*/
class ExifRotationTest extends MediaWikiMediaTestCase {
/** @var BitmapHandler */
private $handler;
protected function setUp(): void {
parent::setUp();
$this->handler = new BitmapHandler();
$this->overrideConfigValues( [
MainConfigNames::ShowEXIF => true,
MainConfigNames::EnableAutoRotation => true,
] );
}
/**
* Mark this test as creating thumbnail files.
* @inheritDoc
*/
protected function createsThumbnails() {
return true;
}
/**
* @dataProvider provideFiles
*/
public function testMetadata( $name, $type, $info ) {
if ( !$this->handler->canRotate() ) {
$this->markTestSkipped( "This test needs a rasterizer that can auto-rotate." );
}
$file = $this->dataFile( $name, $type );
$this->assertEquals( $info['width'], $file->getWidth(), "$name: width check" );
$this->assertEquals( $info['height'], $file->getHeight(), "$name: height check" );
}
/**
* Same as before, but with auto-rotation set to auto.
*
* This sets scaler to image magick, which we should detect as
* supporting rotation.
* @dataProvider provideFiles
*/
public function testMetadataAutoRotate( $name, $type, $info ) {
$this->overrideConfigValues( [
MainConfigNames::EnableAutoRotation => null,
MainConfigNames::UseImageMagick => true,
MainConfigNames::UseImageResize => true,
] );
$file = $this->dataFile( $name, $type );
$this->assertEquals( $info['width'], $file->getWidth(), "$name: width check" );
$this->assertEquals( $info['height'], $file->getHeight(), "$name: height check" );
}
/**
* @dataProvider provideFiles
*/
public function testRotationRendering( $name, $type, $info, $thumbs ) {
if ( !$this->handler->canRotate() ) {
$this->markTestSkipped( "This test needs a rasterizer that can auto-rotate." );
}
foreach ( $thumbs as $size => $out ) {
if ( preg_match( '/^(\d+)px$/', $size, $matches ) ) {
$params = [
'width' => $matches[1],
];
} elseif ( preg_match( '/^(\d+)x(\d+)px$/', $size, $matches ) ) {
$params = [
'width' => $matches[1],
'height' => $matches[2]
];
} else {
throw new InvalidArgumentException( 'bogus test data format ' . $size );
}
$file = $this->dataFile( $name, $type );
$thumb = $file->transform( $params, File::RENDER_NOW | File::RENDER_FORCE );
$this->assertEquals(
$out[0],
$thumb->getWidth(),
"$name: thumb reported width check for $size"
);
$this->assertEquals(
$out[1],
$thumb->getHeight(),
"$name: thumb reported height check for $size"
);
$gis = getimagesize( $thumb->getLocalCopyPath() );
if ( $out[0] > $info['width'] ) {
// Physical image won't be scaled bigger than the original.
$this->assertEquals( $info['width'], $gis[0], "$name: thumb actual width check for $size" );
$this->assertEquals( $info['height'], $gis[1], "$name: thumb actual height check for $size" );
} else {
$this->assertEquals( $out[0], $gis[0], "$name: thumb actual width check for $size" );
$this->assertEquals( $out[1], $gis[1], "$name: thumb actual height check for $size" );
}
}
}
public static function provideFiles() {
return [
[
'landscape-plain.jpg',
'image/jpeg',
[
'width' => 160,
'height' => 120,
],
[
'80x60px' => [ 80, 60 ],
'9999x80px' => [ 107, 80 ],
'80px' => [ 80, 60 ],
'60px' => [ 60, 45 ],
]
],
[
'portrait-rotated.jpg',
'image/jpeg',
[
'width' => 120, // as rotated
'height' => 160, // as rotated
],
[
'80x60px' => [ 45, 60 ],
'9999x80px' => [ 60, 80 ],
'80px' => [ 80, 107 ],
'60px' => [ 60, 80 ],
]
]
];
}
/**
* Same as before, but with auto-rotation disabled.
* @dataProvider provideFilesNoAutoRotate
*/
public function testMetadataNoAutoRotate( $name, $type, $info ) {
$this->overrideConfigValue( MainConfigNames::EnableAutoRotation, false );
$file = $this->dataFile( $name, $type );
$this->assertEquals( $info['width'], $file->getWidth(), "$name: width check" );
$this->assertEquals( $info['height'], $file->getHeight(), "$name: height check" );
}
/**
* Same as before, but with auto-rotation set to auto and an image scaler that doesn't support it.
* @dataProvider provideFilesNoAutoRotate
*/
public function testMetadataAutoRotateUnsupported( $name, $type, $info ) {
$this->overrideConfigValues( [
MainConfigNames::EnableAutoRotation => null,
MainConfigNames::UseImageResize => false,
] );
$file = $this->dataFile( $name, $type );
$this->assertEquals( $info['width'], $file->getWidth(), "$name: width check" );
$this->assertEquals( $info['height'], $file->getHeight(), "$name: height check" );
}
/**
* @dataProvider provideFilesNoAutoRotate
*/
public function testRotationRenderingNoAutoRotate( $name, $type, $info, $thumbs ) {
$this->overrideConfigValue( MainConfigNames::EnableAutoRotation, false );
foreach ( $thumbs as $size => $out ) {
if ( preg_match( '/^(\d+)px$/', $size, $matches ) ) {
$params = [
'width' => $matches[1],
];
} elseif ( preg_match( '/^(\d+)x(\d+)px$/', $size, $matches ) ) {
$params = [
'width' => $matches[1],
'height' => $matches[2]
];
} else {
throw new InvalidArgumentException( 'bogus test data format ' . $size );
}
$file = $this->dataFile( $name, $type );
$thumb = $file->transform( $params, File::RENDER_NOW | File::RENDER_FORCE );
if ( $thumb->isError() ) {
/** @var MediaTransformError $thumb */
$this->fail( $thumb->toText() );
}
$this->assertEquals(
$out[0],
$thumb->getWidth(),
"$name: thumb reported width check for $size"
);
$this->assertEquals(
$out[1],
$thumb->getHeight(),
"$name: thumb reported height check for $size"
);
$gis = getimagesize( $thumb->getLocalCopyPath() );
if ( $out[0] > $info['width'] ) {
// Physical image won't be scaled bigger than the original.
$this->assertEquals( $info['width'], $gis[0], "$name: thumb actual width check for $size" );
$this->assertEquals( $info['height'], $gis[1], "$name: thumb actual height check for $size" );
} else {
$this->assertEquals( $out[0], $gis[0], "$name: thumb actual width check for $size" );
$this->assertEquals( $out[1], $gis[1], "$name: thumb actual height check for $size" );
}
}
}
public static function provideFilesNoAutoRotate() {
return [
[
'landscape-plain.jpg',
'image/jpeg',
[
'width' => 160,
'height' => 120,
],
[
'80x60px' => [ 80, 60 ],
'9999x80px' => [ 107, 80 ],
'80px' => [ 80, 60 ],
'60px' => [ 60, 45 ],
]
],
[
'portrait-rotated.jpg',
'image/jpeg',
[
'width' => 160, // since not rotated
'height' => 120, // since not rotated
],
[
'80x60px' => [ 80, 60 ],
'9999x80px' => [ 107, 80 ],
'80px' => [ 80, 60 ],
'60px' => [ 60, 45 ],
]
]
];
}
private const TEST_WIDTH = 100;
private const TEST_HEIGHT = 200;
/**
* @dataProvider provideBitmapExtractPreRotationDimensions
*/
public function testBitmapExtractPreRotationDimensions( $rotation, $expected ) {
$result = $this->handler->extractPreRotationDimensions( [
'physicalWidth' => self::TEST_WIDTH,
'physicalHeight' => self::TEST_HEIGHT,
], $rotation );
$this->assertEquals( $expected, $result );
}
public static function provideBitmapExtractPreRotationDimensions() {
return [
[
0,
[ self::TEST_WIDTH, self::TEST_HEIGHT ]
],
[
90,
[ self::TEST_HEIGHT, self::TEST_WIDTH ]
],
[
180,
[ self::TEST_WIDTH, self::TEST_HEIGHT ]
],
[
270,
[ self::TEST_HEIGHT, self::TEST_WIDTH ]
],
];
}
}
|
