1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241
|
<?php
use MediaWiki\MainConfigNames;
use MediaWiki\MediaWikiServices;
use MediaWiki\Title\Title;
/**
* @covers \Skin
* @covers \SkinTemplate
* @group Skin
* @group Database
*/
class SideBarTest extends MediaWikiLangTestCase {
/** @var SkinTemplate */
private $skin;
/** @var string[][] Local cache for sidebar messages */
private $messages;
private function initMessagesHref() {
# List of default messages for the sidebar. The sidebar doesn't care at
# all whether they are full URLs, interwiki links or local titles.
$URL_messages = [
'mainpage',
'portal-url',
'currentevents-url',
'recentchanges-url',
'randompage-url',
'helppage',
];
$messageCache = MediaWikiServices::getInstance()->getMessageCache();
# We're assuming that isValidURI works as advertised: it's also
# tested separately, in tests/phpunit/includes/HttpTest.php.
foreach ( $URL_messages as $m ) {
$titleName = $messageCache->get( $m );
if ( MWHttpRequest::isValidURI( $titleName ) ) {
$this->messages[$m]['href'] = $titleName;
} else {
$title = Title::newFromText( $titleName );
$this->messages[$m]['href'] = $title->getLocalURL();
}
}
}
protected function setUp(): void {
parent::setUp();
$this->skin = new SkinTemplate();
$this->skin->getContext()->setLanguage( 'en' );
}
/** @return array */
public function provideSidebars() {
$this->initMessagesHref();
return [
// sidebar with only two titles
[
[
'Title1' => [],
'Title2' => [],
],
'* Title1
* Title2
'
],
// expand messages
[
[ 'Title' => [
[
'text' => 'Help',
'href' => $this->messages['helppage']['href'],
'id' => 'n-help',
'icon' => 'help',
'active' => null
]
] ],
'* Title
** helppage|help
'
],
// test tricky pipe - T35321 - Make sure there's a | after transforming.
[
[ 'Title' => [
# The first 2 are skipped
# Doesn't really test the url properly
# because it will vary with $wgArticlePath et al.
# ** Baz|Fred
[
'text' => 'Fred',
'href' => Title::makeTitle( NS_MAIN, 'Baz' )->getLocalURL(),
'id' => 'n-Fred',
'active' => null,
'icon' => null,
],
[
'text' => 'title-to-display',
'href' => Title::makeTitle( NS_MAIN, 'Page-to-go-to' )->getLocalURL(),
'id' => 'n-title-to-display',
'active' => null,
'icon' => null,
],
] ],
'* Title
** {{PAGENAME|Foo}}
** Bar
** Baz|Fred
** {{PLURAL:1|page-to-go-to{{int:pipe-separator/en}}title-to-display|branch not taken}}
'
],
];
}
/**
* @dataProvider provideSidebars
*/
public function testAddToSidebarPlain( $expected, $text, $message = '' ) {
$bar = [];
$this->skin->addToSidebarPlain( $bar, $text );
$this->assertEquals( $expected, $bar, $message );
}
public function testExternalUrlsRequireADescription() {
$this->overrideConfigValues( [
MainConfigNames::NoFollowLinks => true,
MainConfigNames::NoFollowDomainExceptions => [],
MainConfigNames::NoFollowNsExceptions => [],
] );
$bar = [];
$text = '* Title
** https://www.mediawiki.org/| Home
** http://valid.no.desc.org/
';
$this->skin->addToSidebarPlain( $bar, $text );
$this->assertEquals(
[ 'Title' => [
# ** https://www.mediawiki.org/| Home
[
'text' => 'Home',
'href' => 'https://www.mediawiki.org/',
'id' => 'n-Home',
'active' => null,
'icon' => null,
'rel' => 'nofollow',
],
# ** http://valid.no.desc.org/
# ... skipped since it is missing a pipe with a description
] ],
$bar
);
}
public function testProtocolRelativeExternalUrl() {
$this->overrideConfigValues( [
MainConfigNames::NoFollowLinks => true,
MainConfigNames::NoFollowDomainExceptions => [],
MainConfigNames::NoFollowNsExceptions => [],
] );
$bar = [];
$text = '* Title
** //www.mediawiki.org/| Home
';
$this->skin->addToSidebarPlain( $bar, $text );
$this->assertEquals(
[ 'Title' => [
# ** //www.mediawiki.org/| Home
[
'text' => 'Home',
'href' => '//www.mediawiki.org/', // not /wiki///www.mediawiki.org/ (T364539)
'id' => 'n-Home',
'active' => null,
'icon' => null,
'rel' => 'nofollow',
],
] ],
$bar
);
}
private function getAttribs() {
# Sidebar text we will use everytime
$text = '* Title
** https://www.mediawiki.org/| Home';
$bar = [];
$this->skin->addToSidebarPlain( $bar, $text );
return $bar['Title'][0];
}
/**
* Test our assertAttribs() helper function
* @coversNothing
*/
public function testTestAttributesAssertionHelper() {
$this->overrideConfigValues( [
MainConfigNames::NoFollowLinks => true,
MainConfigNames::NoFollowDomainExceptions => [],
MainConfigNames::NoFollowNsExceptions => [],
MainConfigNames::ExternalLinkTarget => false,
] );
$attribs = $this->getAttribs();
$this->assertArrayHasKey( 'rel', $attribs );
$this->assertEquals( 'nofollow', $attribs['rel'] );
$this->assertArrayNotHasKey( 'target', $attribs );
}
/**
* Test $wgNoFollowLinks in sidebar
*/
public function testRespectWgnofollowlinks() {
$this->overrideConfigValue( MainConfigNames::NoFollowLinks, false );
$attribs = $this->getAttribs();
$this->assertArrayNotHasKey( 'rel', $attribs,
'External URL in sidebar do not have rel=nofollow when $wgNoFollowLinks = false'
);
}
/**
* Test $wgExternaLinkTarget in sidebar
* @dataProvider dataRespectExternallinktarget
*/
public function testRespectExternallinktarget( $externalLinkTarget ) {
$this->overrideConfigValue( MainConfigNames::ExternalLinkTarget, $externalLinkTarget );
$attribs = $this->getAttribs();
$this->assertArrayHasKey( 'target', $attribs );
$this->assertEquals( $attribs['target'], $externalLinkTarget );
}
public static function dataRespectExternallinktarget() {
return [
[ '_blank' ],
[ '_self' ],
];
}
}
|