1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
|
<?php
use MediaWiki\MainConfigNames;
use MediaWiki\Request\FauxRequest;
use MediaWiki\Specials\SpecialUserRights;
use MediaWiki\Tests\User\TempUser\TempUserTestTrait;
use MediaWiki\User\UserIdentityValue;
use MediaWiki\WikiMap\WikiMap;
/**
* @group Database
* @covers \MediaWiki\Specials\SpecialUserRights
*/
class SpecialUserRightsTest extends SpecialPageTestBase {
use TempUserTestTrait;
/**
* @inheritDoc
*/
protected function newSpecialPage() {
$services = $this->getServiceContainer();
return new SpecialUserRights(
$services->getUserGroupManagerFactory(),
$services->getUserNameUtils(),
$services->getUserNamePrefixSearch(),
$services->getUserFactory(),
$services->getActorStoreFactory(),
$services->getWatchlistManager(),
$services->getTempUserConfig()
);
}
/** @dataProvider provideUserCanChangeRights */
public function testUserCanChangeRights( $targetUser, $checkIfSelf, $expectedReturnValue ) {
$objectUnderTest = $this->newSpecialPage();
$this->assertSame( $expectedReturnValue, $objectUnderTest->userCanChangeRights( $targetUser, $checkIfSelf ) );
}
public static function provideUserCanChangeRights() {
return [
'Target user not registered' => [ UserIdentityValue::newAnonymous( 'Test' ), true, false ],
];
}
public function testUserCanChangeRightsForTemporaryAccount() {
$temporaryAccount = $this->getServiceContainer()->getTempUserCreator()
->create( null, new FauxRequest() )->getUser();
$this->testUserCanChangeRights( $temporaryAccount, false, false );
}
public function testSaveUserGroups() {
$target = $this->getTestUser()->getUser();
$performer = $this->getTestSysop()->getUser();
$request = new FauxRequest(
[
'saveusergroups' => true,
'conflictcheck-originalgroups' => '',
'wpGroup-bot' => true,
'wpExpiry-bot' => 'existing',
'wpEditToken' => $performer->getEditToken( $target->getName() ),
],
true
);
$this->executeSpecialPage(
$target->getName(),
$request,
'qqx',
$performer
);
$this->assertSame( 1, $request->getSession()->get( 'specialUserrightsSaveSuccess' ) );
$this->assertSame(
[ 'bot' ],
$this->getServiceContainer()->getUserGroupManager()->getUserGroups( $target )
);
}
public function testSaveUserGroupsForTemporaryAccount() {
$target = $this->getServiceContainer()->getTempUserCreator()->create( null, new FauxRequest() )->getUser();
$performer = $this->getTestSysop()->getUser();
$request = new FauxRequest(
[
'saveusergroups' => true,
'conflictcheck-originalgroups' => '',
'wpGroup-bot' => true,
'wpExpiry-bot' => 'existing',
'wpEditToken' => $performer->getEditToken( $target->getName() ),
],
true
);
[ $html ] = $this->executeSpecialPage( $target->getName(), $request, 'qqx', $performer );
$this->assertNull( $request->getSession()->get( 'specialUserrightsSaveSuccess' ) );
$this->assertCount( 0, $this->getServiceContainer()->getUserGroupManager()->getUserGroups( $target ) );
$this->assertStringContainsString( 'userrights-no-group', $html );
}
public function testSaveUserGroups_change() {
$target = $this->getTestUser( [ 'sysop' ] )->getUser();
$performer = $this->getTestSysop()->getUser();
$request = new FauxRequest(
[
'saveusergroups' => true,
'conflictcheck-originalgroups' => 'sysop',
'wpGroup-sysop' => true,
'wpExpiry-sysop' => 'existing',
'wpGroup-bot' => true,
'wpExpiry-bot' => 'existing',
'wpEditToken' => $performer->getEditToken( $target->getName() ),
],
true
);
$this->executeSpecialPage(
$target->getName(),
$request,
'qqx',
$performer
);
$this->assertSame( 1, $request->getSession()->get( 'specialUserrightsSaveSuccess' ) );
$result = $this->getServiceContainer()->getUserGroupManager()->getUserGroups( $target );
sort( $result );
$this->assertSame(
[ 'bot', 'sysop' ],
$result
);
}
public function testSaveUserGroups_change_expiry() {
$expiry = wfTimestamp( TS_MW, (int)wfTimestamp( TS_UNIX ) + 100 );
$target = $this->getTestUser( [ 'bot' ] )->getUser();
$performer = $this->getTestSysop()->getUser();
$request = new FauxRequest(
[
'saveusergroups' => true,
'conflictcheck-originalgroups' => 'bot',
'wpGroup-bot' => true,
'wpExpiry-bot' => $expiry,
'wpEditToken' => $performer->getEditToken( $target->getName() ),
],
true
);
$this->executeSpecialPage(
$target->getName(),
$request,
'qqx',
$performer
);
$this->assertSame( 1, $request->getSession()->get( 'specialUserrightsSaveSuccess' ) );
$userGroups = $this->getServiceContainer()->getUserGroupManager()->getUserGroupMemberships( $target );
$this->assertCount( 1, $userGroups );
foreach ( $userGroups as $ugm ) {
$this->assertSame( 'bot', $ugm->getGroup() );
$this->assertSame( $expiry, $ugm->getExpiry() );
}
}
private function getExternalDBname(): ?string {
$availableDatabases = array_diff(
$this->getConfVar( MainConfigNames::LocalDatabases ),
[ WikiMap::getCurrentWikiDbDomain()->getDatabase() ]
);
if ( $availableDatabases === [] ) {
return null;
}
// sort to ensure results are deterministic
sort( $availableDatabases );
return $availableDatabases[0];
}
public function testInterwikiRightsChange() {
$externalDBname = $this->getExternalDBname();
if ( $externalDBname === null ) {
$this->markTestSkipped( 'No external database is available' );
}
// FIXME: This should not depend on WikiAdmin user existence
// NOTE: This is here, as in WMF's CI setup, WikiAdmin is the only user
// guaranteed to exist on the other wiki.
$localUser = $this->getServiceContainer()->getUserFactory()->newFromName( 'WikiAdmin' );
$externalUsername = $localUser->getName() . '@' . $externalDBname;
// FIXME: This should benefit from $tablesUsed; until this is possible, purge user_groups on
// the other wiki.
$externalDbw = $this->getServiceContainer()
->getConnectionProvider()
->getPrimaryDatabase( $externalDBname );
$externalDbw->truncateTable( 'user_groups', __METHOD__ );
// ensure using SpecialUserRights with external usernames doesn't throw (T342747, T342322)
$performer = $this->getTestUser( [ 'bureaucrat' ] );
$request = new FauxRequest( [
'saveusergroups' => true,
'conflictcheck-originalgroups' => '',
'wpGroup-sysop' => true,
'wpExpiry-sysop' => 'existing',
'wpEditToken' => $performer->getUser()->getEditToken( $externalUsername ),
], true );
[ $html, ] = $this->executeSpecialPage(
$externalUsername,
$request,
null,
$performer->getAuthority()
);
$this->assertSame( 1, $request->getSession()->get( 'specialUserrightsSaveSuccess' ) );
// ensure logging is done with the right username (T344391)
$this->assertSame(
1,
(int)$this->getDb()->newSelectQueryBuilder()
->select( [ 'cnt' => 'COUNT(*)' ] )
->from( 'logging' )
->where( [
'log_type' => 'rights',
'log_action' => 'rights',
'log_namespace' => NS_USER,
'log_title' => $externalUsername,
] )
->caller( __METHOD__ )
->fetchField()
);
}
}
|
