1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552
|
<?php
namespace MediaWiki\Tests\Storage;
use Article;
use McrUndoAction;
use MediaWiki\Content\WikitextContent;
use MediaWiki\Context\DerivativeContext;
use MediaWiki\Context\IContextSource;
use MediaWiki\Context\RequestContext;
use MediaWiki\EditPage\EditPage;
use MediaWiki\Output\OutputPage;
use MediaWiki\Request\FauxRequest;
use MediaWiki\Revision\RevisionStoreRecord;
use MediaWiki\Revision\SlotRecord;
use MediaWiki\Storage\EditResult;
use MediaWiki\Title\Title;
use MediaWiki\User\User;
use MediaWikiIntegrationTestCase;
use WikiPage;
/**
* Integration tests for undos.
* TODO: This should also test edits with multiple slots.
*
* @covers \McrUndoAction
* @covers \WikiPage
* @covers \MediaWiki\EditPage\EditPage
*
* @group Database
* @group medium
*/
class UndoIntegrationTest extends MediaWikiIntegrationTestCase {
private const PAGE_NAME = 'McrUndoTestPage';
/**
* Creates a new McrUndoAction object for testing.
*
* @param IContextSource $context
* @param Article $article
* @param array $params POST/GET parameters passed to the action on submit
*
* @return McrUndoAction
*/
private function makeNewMcrUndoAction(
IContextSource $context,
Article $article,
array $params
): McrUndoAction {
$request = new FauxRequest( $params );
$request->setVal( 'wpSave', '' );
$context->setRequest( $request );
$outputPage = $this->createMock( OutputPage::class );
$context->setOutput( $outputPage );
$context->setUser( $this->getTestSysop()->getUser() );
$services = $this->getServiceContainer();
$revisionRenderer = $services->getRevisionRenderer();
$revisionLookup = $services->getRevisionLookup();
$readOnlyMode = $services->getReadOnlyMode();
$commentFormatter = $services->getCommentFormatter();
$config = $services->getMainConfig();
return new class(
$article,
$context,
$readOnlyMode,
$revisionLookup,
$revisionRenderer,
$commentFormatter,
$config
) extends McrUndoAction {
public function show() {
// Instead of trying to actually display anything, just initialize the class.
$this->checkCanExecute( $this->getUser() );
}
};
}
/**
* Convenience function for setting up a test page and filling it with edits.
* @param string[] $revisions
*
* @return array
*/
private function setUpPageForTesting( array $revisions ): array {
$this->getExistingTestPage( self::PAGE_NAME );
$revisionIds = [];
foreach ( $revisions as $revisionContent ) {
$revisionIds[] = $this->editPage( self::PAGE_NAME, $revisionContent )
->value['revision-record']->getId();
}
$revisionIds['false'] = false;
return $revisionIds;
}
/**
* @param string $newContent
* @param array $revisionIds
* @param bool $isExactRevert
* @param int|string $oldestRevertedRevIndex
* @param int|string $newestRevertedRevIndex
* @param int|string $originalRevIndex
*/
private function setPageSaveCompleteHook(
string $newContent,
array $revisionIds,
bool $isExactRevert,
$oldestRevertedRevIndex,
$newestRevertedRevIndex,
$originalRevIndex
) {
// set up a temporary hook with asserts
$this->setTemporaryHook(
'PageSaveComplete',
function (
WikiPage $wikiPage,
User $user,
string $summary,
int $flags,
RevisionStoreRecord $revisionRecord,
EditResult $editResult
) use (
$newContent,
$revisionIds,
$isExactRevert,
$oldestRevertedRevIndex,
$newestRevertedRevIndex,
$originalRevIndex
) {
$this->assertTrue(
$editResult->isRevert(),
'EditResult::isRevert()'
);
$this->assertSame(
EditResult::REVERT_UNDO,
$editResult->getRevertMethod(),
'EditResult::getRevertMethod()'
);
$this->assertArrayEquals( [ 'mw-undo' ],
$editResult->getRevertTags(),
false,
false,
'EditResult::getRevertTags()'
);
$this->assertSame(
$isExactRevert,
$editResult->isExactRevert(),
'EditResult::isExactRevert()'
);
$this->assertSame(
$revisionIds[$oldestRevertedRevIndex],
$editResult->getOldestRevertedRevisionId(),
'EditResult::getOldestRevertedRevisionId()'
);
$this->assertSame(
$revisionIds[$newestRevertedRevIndex],
$editResult->getNewestRevertedRevisionId(),
'EditResult::getNewestRevertedRevisionId()'
);
$this->assertSame(
$revisionIds[$originalRevIndex],
$editResult->getOriginalRevisionId(),
'EditResult::getOriginalRevisionId()'
);
$mainContent = $revisionRecord->getContent( SlotRecord::MAIN );
/** @var WikitextContent $mainContent */
$this->assertSame(
$newContent,
$mainContent->getText(),
'RevisionRecord::getContent()'
);
}
);
}
/**
* Provides test cases for well-formed undos.
*
* @return array[]
*/
public static function provideUndos() {
return [
'undoing a single revision' => [
[ '1', '2' ],
'1',
0,
1,
true,
1,
1,
0
],
'undoing multiple revisions' => [
[ '1', '2', '3', '4' ],
'1',
0,
3,
true,
1,
3,
0
],
'undoing an intermittent revision' => [
[
"line 1\n\nline 2\n\nline3",
"line 1\n\nvandalism\n\nline3",
"line 1\n\nvandalism\n\nline3 more content"
],
"line 1\n\nline 2\n\nline3 more content",
0,
1,
false,
1,
1,
'false'
],
'undoing multiple intermittent revisions' => [
[
"line 1\n\nline 2\n\nline3",
"line 1\n\nvandalism\n\nline3",
"line 1\n\nmore vandalism\n\nline3",
"line 1\n\nmore vandalism\n\nline3 content"
],
"line 1\n\nline 2\n\nline3 content",
0,
2,
false,
1,
2,
'false'
]
];
}
/**
* Provides test cases of undos with incomplete parameters.
* This should be handled well by EditPage and WikiPage.
* McrUndoAction just refuses to do anything.
*
* @return array[]
*/
public static function provideIncompleteUndos() {
return [
'undoing a revision without undoafter param' => [
[ '1', '2' ],
'1',
'false',
1,
true,
1,
1,
0
],
'undoing an intermittent revision without undoafter param' => [
[
"line 1\n\nline 2\n\nline3",
"line 1\n\nvandalism\n\nline3",
"line 1\n\nvandalism\n\nline3 more content"
],
"line 1\n\nline 2\n\nline3 more content",
'false',
1,
false,
1,
1,
'false'
]
];
}
/**
* Test how McrUndoAction cooperates with the PageUpdater by looking at values provided
* by the PageSaveComplete hook.
*
* @dataProvider provideUndos
*
* @param string[] $revisions
* @param string $newContent
* @param int|string $undoafterIndex
* @param int|string $undoIndex
* @param bool $isExactRevert
* @param int|string $oldestRevertedRevIndex
* @param int|string $newestRevertedRevIndex
* @param int|string $originalRevIndex
*/
public function testMcrUndoAction(
array $revisions,
string $newContent,
$undoafterIndex,
$undoIndex,
bool $isExactRevert,
$oldestRevertedRevIndex,
$newestRevertedRevIndex,
$originalRevIndex
) {
$this->markTestSkippedIfNoDiff3();
$context = new DerivativeContext( RequestContext::getMain() );
$context->setUser( $this->getTestUser()->getUser() );
$revisionIds = $this->setUpPageForTesting( $revisions );
$article = Article::newFromTitle( Title::newFromText( self::PAGE_NAME ), $context );
$mcrUndoAction = $this->makeNewMcrUndoAction(
$context,
$article,
[
'undoafter' => $revisionIds[$undoafterIndex],
'undo' => $revisionIds[$undoIndex]
]
);
// This should initialize the action properly.
$mcrUndoAction->show();
// Set the hook and submit the request
$this->setPageSaveCompleteHook(
$newContent,
$revisionIds,
$isExactRevert,
$oldestRevertedRevIndex,
$newestRevertedRevIndex,
$originalRevIndex
);
$mcrUndoAction->onSubmit( [] );
}
/**
* Test how WikiPage cooperates with the PageUpdater by looking at values
* provided by the PageSaveComplete hook.
*
* @dataProvider provideUndos
* @dataProvider provideIncompleteUndos
*
* @param string[] $revisions
* @param string $newContent
* @param int|string $undoafterIndex
* @param int|string $undoIndex
* @param bool $isExactRevert
* @param int|string $oldestRevertedRevIndex
* @param int|string $newestRevertedRevIndex
* @param int|string $originalRevIndex
*/
public function testWikiPage(
array $revisions,
string $newContent,
$undoafterIndex,
$undoIndex,
bool $isExactRevert,
$oldestRevertedRevIndex,
$newestRevertedRevIndex,
$originalRevIndex
) {
$revisionIds = $this->setUpPageForTesting( $revisions );
// Set the hook with asserts
$this->setPageSaveCompleteHook(
$newContent,
$revisionIds,
$isExactRevert,
$oldestRevertedRevIndex,
$newestRevertedRevIndex,
$originalRevIndex
);
$wikiPage = $this->getServiceContainer()->getWikiPageFactory()->newFromTitle( Title::newFromText( self::PAGE_NAME ) );
$wikiPage->doUserEditContent(
new WikitextContent( $newContent ),
$this->getTestSysop()->getUser(),
'',
0,
$revisionIds[$undoafterIndex],
[],
$revisionIds[$undoIndex]
);
}
/**
* Test how EditPage and WikiPage work together and with the PageUpdater by looking
* at values provided by the PageSaveComplete hook.
*
* @dataProvider provideUndos
* @dataProvider provideIncompleteUndos
*
* @param string[] $revisions
* @param string $newContent
* @param int|string $undoafterIndex
* @param int|string $undoIndex
* @param bool $isExactRevert
* @param int|string $oldestRevertedRevIndex
* @param int|string $newestRevertedRevIndex
* @param int|string $originalRevIndex
*/
public function testEditPage(
array $revisions,
string $newContent,
$undoafterIndex,
$undoIndex,
bool $isExactRevert,
$oldestRevertedRevIndex,
$newestRevertedRevIndex,
$originalRevIndex
) {
$this->markTestSkippedIfNoDiff3();
$revisionIds = $this->setUpPageForTesting( $revisions );
$context = new DerivativeContext( RequestContext::getMain() );
$context->setUser( $this->getTestUser()->getUser() );
$article = Article::newFromTitle( Title::newFromText( self::PAGE_NAME ), $context );
// Set the hook with asserts
$this->setPageSaveCompleteHook(
$newContent,
$revisionIds,
$isExactRevert,
$oldestRevertedRevIndex,
$newestRevertedRevIndex,
$originalRevIndex
);
$request = new FauxRequest(
[
// We kind of let EditPage cheat here by providing the content of the page
// after the undo, but automatic conflict resolution is not the point of
// this test anyway.
'wpTextbox1' => $newContent,
'wpEditToken' => $this->getTestSysop()->getUser()->getEditToken(),
// These two parameters are the important ones here
'wpUndidRevision' => $revisionIds[$undoIndex],
'wpUndoAfter' => $revisionIds[$undoafterIndex],
'wpStarttime' => wfTimestampNow(),
'wpUnicodeCheck' => EditPage::UNICODE_CHECK,
'model' => CONTENT_MODEL_WIKITEXT,
'format' => CONTENT_FORMAT_WIKITEXT,
],
true
);
$editPage = new EditPage( $article );
$editPage->importFormData( $request );
$editPage->attemptSave( $result );
}
/**
* Test the case where the user undoes some edits, but applies additional changes before
* saving. EditPage should detect that and not mark such an edit as a revert.
*/
public function testDirtyUndo() {
$revisionIds = $this->setUpPageForTesting( [
"line 1\n\nline 2\n\nline3",
"line 1\n\nvandalism\n\nline3",
"line 1\n\nvandalism\n\nline3 more content"
] );
$context = new DerivativeContext( RequestContext::getMain() );
$context->setUser( $this->getTestUser()->getUser() );
$article = Article::newFromTitle( Title::newFromText( self::PAGE_NAME ), $context );
// set up a temporary hook with asserts
$this->setTemporaryHook(
'PageSaveComplete',
function (
WikiPage $wikiPage,
User $user,
string $summary,
int $flags,
RevisionStoreRecord $revisionRecord,
EditResult $editResult
) {
// Just ensuring that the edit was not marked as a revert should be enough
$this->assertFalse(
$editResult->isRevert(),
'EditResult::isRevert()'
);
}
);
$request = new FauxRequest(
[
// We emulate the user applying additional changes on top of the undo.
'wpTextbox1' => "line 1\n\nline 2\n\nline3 more content\n\neven more",
'wpEditToken' => $this->getTestSysop()->getUser()->getEditToken(),
'wpUndidRevision' => $revisionIds[1],
'wpUndoAfter' => $revisionIds[0],
'wpStarttime' => wfTimestampNow(),
'wpUnicodeCheck' => EditPage::UNICODE_CHECK,
'model' => CONTENT_MODEL_WIKITEXT,
'format' => CONTENT_FORMAT_WIKITEXT,
],
true
);
$editPage = new EditPage( $article );
$editPage->importFormData( $request );
$editPage->attemptSave( $result );
}
/**
* Test whether EditPage correctly handles situations where an undo is impossible.
* Ensures T262463 is fixed.
*/
public function testImpossibleUndo() {
$revisionIds = $this->setUpPageForTesting( [
"line 1\n\nline 2\n\nline3",
"line 1\n\nvandalism\n\nline3",
"line 1\n\nvandalism good content\n\nline3 more content"
] );
$context = RequestContext::getMain();
$article = Article::newFromTitle( Title::newFromText( self::PAGE_NAME ), $context );
// set up a temporary hook with asserts
$this->setTemporaryHook(
'PageSaveComplete',
function (
WikiPage $wikiPage,
User $user,
string $summary,
int $flags,
RevisionStoreRecord $revisionRecord,
EditResult $editResult
) {
$this->assertFalse(
$editResult->isRevert(),
'EditResult::isRevert()'
);
$this->assertTrue(
$editResult->isNullEdit(),
'EditResult::isNullEdit()'
);
}
);
$request = new FauxRequest(
[
// We leave the "top" content in the textbox, as the undo should have failed
'wpTextbox1' => "line 1\n\nvandalism good content\n\nline3 more content",
'wpEditToken' => $this->getTestSysop()->getUser()->getEditToken(),
'wpUndidRevision' => $revisionIds[1],
'wpUndoAfter' => $revisionIds[0],
'wpStarttime' => wfTimestampNow(),
'wpUnicodeCheck' => EditPage::UNICODE_CHECK,
'model' => CONTENT_MODEL_WIKITEXT,
'format' => CONTENT_FORMAT_WIKITEXT,
],
true
);
$editPage = new EditPage( $article );
$editPage->importFormData( $request );
$editPage->attemptSave( $result );
}
}
|