1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
|
<?php
use MediaWiki\Page\PageIdentityValue;
use MediaWiki\Tests\Unit\Permissions\MockAuthorityTrait;
use MediaWiki\User\UserIdentityValue;
/**
* @covers \MediaWiki\Watchlist\WatchlistManager
*
* @author DannyS712
* @group Database
*/
class WatchlistManagerTest extends MediaWikiIntegrationTestCase {
use MockAuthorityTrait;
/**
* While this *could* be moved to a unit test, it is specifically kept
* here as an integration test to double check that the actual integration
* between this service and others, and getting this service from the
* service container, works as expected. Please don't move it to
* the unit tests.
*
* @covers \MediaWiki\Watchlist\WatchlistManager::isWatched
* @covers \MediaWiki\Watchlist\WatchlistManager::isTempWatched
* @covers \MediaWiki\Watchlist\WatchlistManager::addWatch
* @covers \MediaWiki\Watchlist\WatchlistManager::addWatchIgnoringRights()
* @covers \MediaWiki\Watchlist\WatchlistManager::removeWatch()
*/
public function testWatchlist() {
$userIdentity = new UserIdentityValue( 100, 'User Name' );
$authority = $this->mockUserAuthorityWithPermissions(
$userIdentity,
[ 'editmywatchlist', 'viewmywatchlist' ]
);
$title = new PageIdentityValue( 100, NS_MAIN, 'Page_db_Key_goesHere', PageIdentityValue::LOCAL );
$services = $this->getServiceContainer();
$watchedItemStore = $services->getWatchedItemStore();
$watchlistManager = $services->getWatchlistManager();
$watchedItemStore->clearUserWatchedItems( $userIdentity );
$this->assertFalse(
$watchlistManager->isWatched( $authority, $title ),
'The article has not been watched yet'
);
$this->assertFalse(
$watchlistManager->isTempWatched( $authority, $title ),
"The article hasn't been temporarily watched"
);
$watchlistManager->addWatch( $authority, $title );
$this->assertTrue( $watchlistManager->isWatched( $authority, $title ), 'The article has been watched' );
$this->assertFalse(
$watchlistManager->isTempWatched( $authority, $title ),
"The article hasn't been temporarily watched"
);
$watchlistManager->removeWatch( $authority, $title );
$this->assertFalse( $watchlistManager->isWatched( $authority, $title ), 'The article has been unwatched' );
$this->assertFalse(
$watchlistManager->isTempWatched( $authority, $title ),
"The article hasn't been temporarily watched"
);
$watchlistManager->addWatch( $authority, $title, '2 weeks' );
$this->assertTrue( $watchlistManager->isWatched( $authority, $title ), 'The article has been watched' );
$this->assertTrue(
$watchlistManager->isTempWatched( $authority, $title ), 'The article has been tempoarily watched'
);
$watchlistManager->removeWatch( $authority, $title );
$this->assertFalse( $watchlistManager->isWatched( $authority, $title ), 'The article has been unwatched' );
$this->assertFalse(
$watchlistManager->isTempWatched( $authority, $title ),
"The article hasn't been temporarily watched"
);
$watchlistManager->addWatchIgnoringRights( $userIdentity, $title );
$this->assertTrue( $watchlistManager->isWatched( $authority, $title ), 'The article has been watched' );
$this->assertFalse(
$watchlistManager->isTempWatched( $authority, $title ),
"The article hasn't been temporarily watched"
);
}
/**
* Can't move to unit tests because if the user is missing rights
* the status is from User::newFatalPermissionDeniedStatus which uses
* MediaWikiServices
*
* @covers \MediaWiki\Watchlist\WatchlistManager::isWatched
* @covers \MediaWiki\Watchlist\WatchlistManager::isWatchedIgnoringRights
* @covers \MediaWiki\Watchlist\WatchlistManager::isTempWatched
* @covers \MediaWiki\Watchlist\WatchlistManager::isTempWatchedIgnoringRights
* @covers \MediaWiki\Watchlist\WatchlistManager::addWatch
* @covers \MediaWiki\Watchlist\WatchlistManager::addWatchIgnoringRights()
* @covers \MediaWiki\Watchlist\WatchlistManager::removeWatch()
*/
public function testWatchlistNoRights() {
$userIdentity = new UserIdentityValue( 100, 'User Name' );
$authority = $this->mockUserAuthorityWithPermissions( $userIdentity, [] );
$title = new PageIdentityValue( 100, NS_MAIN, 'Page_db_Key_goesHere', PageIdentityValue::LOCAL );
$services = $this->getServiceContainer();
$watchedItemStore = $services->getWatchedItemStore();
$watchlistManager = $services->getWatchlistManager();
$watchedItemStore->clearUserWatchedItems( $userIdentity );
$this->assertFalse( $watchlistManager->isWatched( $authority, $title ) );
$this->assertFalse( $watchlistManager->isTempWatched( $authority, $title ) );
$this->assertFalse( $watchlistManager->isWatchedIgnoringRights( $userIdentity, $title ) );
$this->assertFalse( $watchlistManager->isTempWatchedIgnoringRights( $userIdentity, $title ) );
$watchlistManager->addWatch( $authority, $title );
$this->assertFalse( $watchlistManager->isWatched( $authority, $title ) );
$this->assertFalse( $watchlistManager->isTempWatched( $authority, $title ) );
$this->assertFalse( $watchlistManager->isWatchedIgnoringRights( $userIdentity, $title ) );
$this->assertFalse( $watchlistManager->isTempWatchedIgnoringRights( $userIdentity, $title ) );
$watchlistManager->addWatchIgnoringRights( $userIdentity, $title );
$this->assertFalse( $watchlistManager->isWatched( $authority, $title ) );
$this->assertFalse( $watchlistManager->isTempWatched( $authority, $title ) );
$this->assertTrue( $watchlistManager->isWatchedIgnoringRights( $userIdentity, $title ) );
$this->assertFalse( $watchlistManager->isTempWatchedIgnoringRights( $userIdentity, $title ) );
$watchlistManager->addWatchIgnoringRights( $userIdentity, $title, '1 week' );
$this->assertFalse( $watchlistManager->isWatched( $authority, $title ) );
$this->assertFalse( $watchlistManager->isTempWatched( $authority, $title ) );
$this->assertTrue( $watchlistManager->isWatchedIgnoringRights( $userIdentity, $title ) );
$this->assertTrue( $watchlistManager->isTempWatchedIgnoringRights( $userIdentity, $title ) );
$watchlistManager->removeWatch( $authority, $title );
$this->assertFalse( $watchlistManager->isWatched( $authority, $title ) );
$this->assertFalse( $watchlistManager->isTempWatched( $authority, $title ) );
$this->assertTrue( $watchlistManager->isWatchedIgnoringRights( $userIdentity, $title ) );
$this->assertTrue( $watchlistManager->isTempWatchedIgnoringRights( $userIdentity, $title ) );
$watchlistManager->removeWatchIgnoringRights( $userIdentity, $title );
$this->assertFalse( $watchlistManager->isWatched( $authority, $title ) );
$this->assertFalse( $watchlistManager->isTempWatched( $authority, $title ) );
$this->assertFalse( $watchlistManager->isWatchedIgnoringRights( $userIdentity, $title ) );
$this->assertFalse( $watchlistManager->isTempWatchedIgnoringRights( $userIdentity, $title ) );
}
/**
* Can't move to unit tests because if the user is missing rights
* the status is from User::newFatalPermissionDeniedStatus which uses
* MediaWikiServices
*
* @covers \MediaWiki\Watchlist\WatchlistManager::addWatch()
*/
public function testAddWatchUserNotPermittedStatusNotGood() {
$userIdentity = new UserIdentityValue( 100, 'User Name' );
$performer = $this->mockUserAuthorityWithPermissions( $userIdentity, [] );
$title = new PageIdentityValue( 100, NS_MAIN, 'Page_db_Key_goesHere', PageIdentityValue::LOCAL );
$services = $this->getServiceContainer();
$watchedItemStore = $services->getWatchedItemStore();
$watchlistManager = $services->getWatchlistManager();
$watchedItemStore->clearUserWatchedItems( $userIdentity );
$actual = $watchlistManager->addWatch( $performer, $title );
$this->assertStatusNotGood( $actual );
$this->assertFalse( $watchlistManager->isWatchedIgnoringRights( $userIdentity, $title ) );
}
/**
* Can't move to unit tests because if the user is missing rights
* the status is from User::newFatalPermissionDeniedStatus which uses
* MediaWikiServices
*
* @covers \MediaWiki\Watchlist\WatchlistManager::removeWatch()
*/
public function testRemoveWatchWithoutRights() {
$userIdentity = new UserIdentityValue( 100, 'User Name' );
$performer = $this->mockUserAuthorityWithPermissions( $userIdentity, [] );
$title = new PageIdentityValue( 100, NS_MAIN, 'Page_db_Key_goesHere', PageIdentityValue::LOCAL );
$services = $this->getServiceContainer();
$watchlistManager = $services->getWatchlistManager();
$watchlistManager->addWatchIgnoringRights( $userIdentity, $title );
$actual = $watchlistManager->removeWatch( $performer, $title );
$this->assertStatusNotGood( $actual );
$this->assertTrue( $watchlistManager->isWatchedIgnoringRights( $userIdentity, $title ) );
}
}
|
