1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
|
<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*/
namespace MediaWiki\Tests\Unit;
use MediaWiki\HookContainer\HookContainer;
use MediaWiki\Request\ProxyLookup;
use MediaWikiUnitTestCase;
/**
* @author DannyS712
*
* @coversDefaultClass \MediaWiki\Request\ProxyLookup
*/
class ProxyLookupTest extends MediaWikiUnitTestCase {
/**
* @covers ::__construct
*/
public function testConstruct() {
$proxyLookup = new ProxyLookup(
[],
[],
$this->createNoOpMock( HookContainer::class )
);
$this->assertInstanceOf( ProxyLookup::class, $proxyLookup, 'No errors' );
}
public static function provideIsConfiguredProxy() {
// $ip, $expected
yield 'Listed ip #1' => [ '1.1.1.1', true ];
yield 'Listed ip #2' => [ '2.2.2.2', true ];
yield 'In complex list #1' => [ '127.0.0.127', true ];
yield 'In complex list #2' => [ '255.0.0.127', true ];
yield 'Not listed #1' => [ '3.3.3.3', false ];
yield 'Not listed #2' => [ '255.255.255.255', false ];
}
/**
* @covers ::isConfiguredProxy
* @dataProvider provideIsConfiguredProxy
*/
public function testIsConfiguredProxy( string $ip, bool $expected ) {
// Should never be called
$hookContainer = $this->createNoOpMock( HookContainer::class );
// Not an exhaustive test of the functionality of IPSet since that has its own
// tests, just need to make sure it works
$proxyLookup = new ProxyLookup(
[
'1.1.1.1',
'2.2.2.2',
],
[
'127.0.0.0/24',
'255.0.0.0/24',
],
$hookContainer
);
$this->assertSame( $expected, $proxyLookup->isConfiguredProxy( $ip ) );
}
public static function provideIsTrustedProxy() {
// $ip, $expectedForHookCall, $hookResult
yield 'Listed, hook return true' => [ '1.1.1.1', true, true ];
yield 'Listed, hook return false' => [ '1.1.1.1', true, false ];
yield 'Not listed, hook return true' => [ '2.2.2.2', false, true ];
yield 'Not listed, hook return false' => [ '2.2.2.2', false, false ];
}
/**
* @covers ::isTrustedProxy
* @dataProvider provideIsTrustedProxy
*/
public function testIsTrustedProxy(
string $ip,
bool $expectedForHookCall,
bool $hookResult
) {
// Hook should be called with the correct parameters
$hookCalled = false;
$hookCallback = function ( $hookIP, &$trusted ) use ( &$hookCalled, $ip, $expectedForHookCall, $hookResult ) {
$hookCalled = true;
// Make sure called correctly
$this->assertSame( $ip, $hookIP, 'Hook called with the right IP' );
$this->assertSame( $expectedForHookCall, $trusted, 'Hook called with the correct $trusted' );
$trusted = $hookResult;
};
$hookContainer = $this->createHookContainer( [
'IsTrustedProxy' => $hookCallback,
] );
$proxyLookup = new ProxyLookup(
[ '1.1.1.1' ],
[],
$hookContainer
);
$this->assertSame( $hookResult, $proxyLookup->isTrustedProxy( $ip ) );
$this->assertTrue( $hookCalled );
}
}
|
