1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291
|
<?php
namespace MediaWiki\Tests\Rest\Module;
use GuzzleHttp\Psr7\Uri;
use MediaWiki\MainConfigNames;
use MediaWiki\Rest\BasicAccess\StaticBasicAuthorizer;
use MediaWiki\Rest\Module\ExtraRoutesModule;
use MediaWiki\Rest\Module\Module;
use MediaWiki\Rest\Reporter\ErrorReporter;
use MediaWiki\Rest\RequestData;
use MediaWiki\Rest\RequestInterface;
use MediaWiki\Rest\ResponseFactory;
use MediaWiki\Rest\Validator\Validator;
use MediaWiki\Tests\Rest\RestTestTrait;
use MediaWiki\Tests\Unit\DummyServicesTrait;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Log\NullLogger;
use RuntimeException;
use Throwable;
use UDPTransport;
use Wikimedia\Stats\OutputFormats;
use Wikimedia\Stats\StatsCache;
use Wikimedia\Stats\StatsFactory;
use Wikimedia\TestingAccessWrapper;
/**
* @covers \MediaWiki\Rest\Module\ExtraRoutesModule
* @covers \MediaWiki\Rest\Module\MatcherBasedModule
*/
class ExtraRoutesModuleTest extends \MediaWikiUnitTestCase {
use RestTestTrait;
use DummyServicesTrait;
private const CANONICAL_SERVER = 'https://wiki.example.com';
private const INTERNAL_SERVER = 'http://api.local:8080';
/** @var Throwable[] */
private $reportedErrors = [];
/**
* @param RequestInterface $request
* @param string|null $authError
* @param array<int,array> $extraRoutes
*
* @return ExtraRoutesModule
*/
private function createRouteFileModule(
RequestInterface $request,
$authError = null,
$extraRoutes = []
) {
$routeFiles = [
__DIR__ . '/moduleFlatRoutes.json', // old, flat format
];
/** @var MockObject|ErrorReporter $mockErrorReporter */
$mockErrorReporter = $this->createNoOpMock( ErrorReporter::class, [ 'reportError' ] );
$mockErrorReporter->method( 'reportError' )
->willReturnCallback( function ( $e ) {
$this->reportedErrors[] = $e;
} );
$config = [
MainConfigNames::CanonicalServer => self::CANONICAL_SERVER,
MainConfigNames::InternalServer => self::INTERNAL_SERVER,
MainConfigNames::RestPath => '/rest',
];
$auth = new StaticBasicAuthorizer( $authError );
$objectFactory = $this->getDummyObjectFactory();
$authority = $this->mockAnonUltimateAuthority();
$validator = new Validator( $objectFactory, $request, $authority );
$router = $this->newRouter( [
'routeFiles' => [],
'request' => $request,
'config' => $config,
'errorReporter' => $mockErrorReporter,
'basicAuth' => $auth,
'validator' => $validator
] );
$responseFactory = new ResponseFactory( [] );
$responseFactory->setShowExceptionDetails( true );
$module = new ExtraRoutesModule(
$routeFiles,
$extraRoutes,
$router,
$responseFactory,
$auth,
$objectFactory,
$validator,
$mockErrorReporter
);
return $module;
}
private function createMockStatsFactory( string $expectedPattern ): StatsFactory {
$statsCache = new StatsCache();
$emitter = OutputFormats::getNewEmitter(
'mediawiki',
$statsCache,
OutputFormats::getNewFormatter( OutputFormats::DOGSTATSD )
);
$transport = $this->createMock( UDPTransport::class );
$transport->expects( $this->once() )->method( "emit" )
->with( $this->matchesRegularExpression( $expectedPattern ) );
$emitter = $emitter->withTransport( $transport );
return new StatsFactory( $statsCache, $emitter, new NullLogger );
}
public function testWrongMethod() {
$request = new RequestData( [
'uri' => new Uri( '/rest/ModuleTest/hello/dude' ),
'method' => 'TRACE'
] );
$module = $this->createRouteFileModule( $request );
$response = $module->execute( '/ModuleTest/hello/dude', $request );
$this->assertSame( 405, $response->getStatusCode(), (string)$response->getBody() );
$this->assertSame( 'Method Not Allowed', $response->getReasonPhrase() );
$this->assertSame( 'HEAD, GET', $response->getHeaderLine( 'Allow' ) );
}
public function testHeadToGet() {
$request = new RequestData( [
'uri' => new Uri( '/rest/ModuleTest/hello/dude' ),
'method' => 'HEAD'
] );
$module = $this->createRouteFileModule( $request );
$response = $module->execute( '/ModuleTest/hello/dude', $request );
$this->assertSame( 200, $response->getStatusCode(), (string)$response->getBody() );
}
public function testFlatRouteFile() {
$request = new RequestData( [
'uri' => new Uri( '/rest/ModuleTest/hello/dude' ),
'method' => 'HEAD'
] );
$module = $this->createRouteFileModule( $request );
$stats = $this->createMockStatsFactory(
"/^mediawiki\.rest_api_latency_seconds:\d+\.\d+\|ms\|#path:ModuleTest_hello_name,method:HEAD,status:200\nmediawiki\.stats_buffered_total:1\|c$/"
);
$module->setStats( $stats );
$response = $module->execute( '/ModuleTest/hello/two', $request );
$stats->flush();
$this->assertSame( 200, $response->getStatusCode() );
}
public function testNoMatch() {
// The /hello path requires a path parameter.
$request = new RequestData( [ 'uri' => new Uri( '/rest/ModuleTest/hello' ) ] );
$module = $this->createRouteFileModule( $request );
$response = $module->execute( '/ModuleTest/hello', $request );
$this->assertSame( 404, $response->getStatusCode() );
// TODO: add more information to the response body and test for its presence here
}
public function testHttpException() {
$request = new RequestData( [ 'uri' => new Uri( '/rest/ModuleTest/throw' ) ] );
$module = $this->createRouteFileModule( $request );
$stats = $this->createMockStatsFactory(
"/^mediawiki\.rest_api_errors_total:1\|c\|#path:ModuleTest_throw,method:GET,status:555\nmediawiki\.stats_buffered_total:1\|c$/"
);
$module->setStats( $stats );
$response = $module->execute( '/ModuleTest/throw', $request );
$stats->flush();
$this->assertSame( 555, $response->getStatusCode() );
$body = $response->getBody();
$body->rewind();
$data = json_decode( $body->getContents(), true );
$this->assertSame( 'Mock error', $data['message'] );
}
public function testFatalException() {
$request = new RequestData( [ 'uri' => new Uri( '/rest/ModuleTest/fatal' ) ] );
$module = $this->createRouteFileModule( $request );
$response = $module->execute( '/ModuleTest/fatal', $request );
$this->assertSame( 500, $response->getStatusCode() );
$body = $response->getBody();
$body->rewind();
$data = json_decode( $body->getContents(), true );
$this->assertStringContainsString( 'RuntimeException', $data['message'] );
$this->assertNotEmpty( $this->reportedErrors );
$this->assertInstanceOf( RuntimeException::class, $this->reportedErrors[0] );
}
public function testRedirectException() {
$request = new RequestData( [ 'uri' => new Uri( '/rest/ModuleTest/throwRedirect' ) ] );
$module = $this->createRouteFileModule( $request );
$response = $module->execute( '/ModuleTest/throwRedirect', $request );
$this->assertSame( 301, $response->getStatusCode() );
$this->assertSame( 'http://example.com', $response->getHeaderLine( 'Location' ) );
}
public function testResponseException() {
$request = new RequestData( [ 'uri' => new Uri( '/rest/ModuleTest/throwWrapped' ) ] );
$module = $this->createRouteFileModule( $request );
$response = $module->execute( '/ModuleTest/throwWrapped', $request );
$this->assertSame( 200, $response->getStatusCode() );
}
public function testBasicAccess() {
// Using the throwing handler is a way to assert that the handler is not executed
$request = new RequestData( [ 'uri' => new Uri( '/rest/ModuleTest/throw' ) ] );
$module = $this->createRouteFileModule( $request, 'test-error', [] );
$response = $module->execute( '/ModuleTest/throw', $request );
$this->assertSame( 403, $response->getStatusCode() );
$body = $response->getBody();
$body->rewind();
$data = json_decode( $body->getContents(), true );
$this->assertSame( 'test-error', $data['error'] );
}
public function testAdditionalEndpoints() {
$request = new RequestData( [
'uri' => new Uri( '/rest/ModuleTest/hello-again' )
] );
$module = $this->createRouteFileModule(
$request,
null,
[ [
'path' => '/ModuleTest/hello-again',
'class' => 'MediaWiki\\Tests\\Rest\\Handler\\HelloHandler'
] ]
);
$response = $module->execute( '/ModuleTest/hello-again', $request );
$this->assertSame( 200, $response->getStatusCode() );
}
public static function provideGetRouteUrl() {
yield 'empty' => [ '', '', [], [] ];
yield 'simple route' => [ '/foo/bar', '/foo/bar' ];
yield 'simple route with query' =>
[ '/foo/bar', '/foo/bar?x=1&y=2', [ 'x' => '1', 'y' => '2' ] ];
yield 'simple route with strange query chars' =>
[ '/foo+bar', '/foo+bar?x=%23&y=%25&z=%2B', [ 'x' => '#', 'y' => '%', 'z' => '+' ] ];
yield 'route with simple path params' =>
[ '/foo/{test}/baz', '/foo/bar/baz', [], [ 'test' => 'bar' ] ];
yield 'route with strange path params' =>
[ '/foo/{test}/baz', '/foo/b%25%2F%2Bz/baz', [], [ 'test' => 'b%/+z' ] ];
yield 'space in path does not become a plus' =>
[ '/foo/{test}/baz', '/foo/b%20z/baz', [], [ 'test' => 'b z' ] ];
yield 'route with simple path params and query' =>
[ '/foo/{test}/baz', '/foo/bar/baz?x=1', [ 'x' => '1' ], [ 'test' => 'bar' ] ];
}
public function testCacheData() {
$request = new RequestData( [ 'uri' => new Uri( '/rest/route' ) ] );
$module1 = $this->createRouteFileModule( $request );
$module1wrapper = TestingAccessWrapper::newFromObject( $module1 );
$cacheData = $module1->getCacheData();
// Create a second module
$module2 = $this->createRouteFileModule( $request );
$module2wrapper = TestingAccessWrapper::newFromObject( $module2 );
// Destroy module2's ability to load routes
$module2wrapper->routeFiles = [ '/this/does/not/exist' ];
// Make sure the config hash is set and matches.
$module2wrapper->configHash = $module1wrapper->configHash;
// Check that initFromCacheData() succeeds.
$this->assertTrue( $module2->initFromCacheData( $cacheData ) );
// Check that the matcher tree is deep-equal after initFromCacheData().
$this->assertEquals( $module1wrapper->getMatchers(), $module2wrapper->getMatchers() );
// Invalidate the cache data
$cacheData[ Module::CACHE_CONFIG_HASH_KEY ] = 'foobar';
// Check that initFromCacheData() fails.
$this->assertFalse( $module2->initFromCacheData( $cacheData ) );
// Check that the matcher tree is still deep-equal.
$this->assertEquals( $module1wrapper->getMatchers(), $module2wrapper->getMatchers() );
}
}
|