1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
|
<?php
namespace MediaWiki\Tests\Unit\Libs\Rdbms;
use InvalidArgumentException;
use PHPUnit\Framework\TestCase;
use Wikimedia\Rdbms\AndExpressionGroup;
use Wikimedia\Rdbms\Expression;
use Wikimedia\Rdbms\IExpression;
use Wikimedia\Rdbms\LikeMatch;
use Wikimedia\Rdbms\LikeValue;
use Wikimedia\Rdbms\OrExpressionGroup;
/**
* @covers \Wikimedia\Rdbms\Expression
* @covers \Wikimedia\Rdbms\ExpressionGroup
* @covers \Wikimedia\Rdbms\AndExpressionGroup
* @covers \Wikimedia\Rdbms\OrExpressionGroup
* @covers \Wikimedia\Rdbms\LikeMatch
* @covers \Wikimedia\Rdbms\LikeValue
*/
class ExpressionTest extends TestCase {
public static function provideSimple() {
return [
[
'rev_timestamp', '>', '20221025145309',
"rev_timestamp > '20221025145309'"
],
[
'rev_timestamp', '>=', '20221025145309',
"rev_timestamp >= '20221025145309'"
],
[
'rev_timestamp', '<', '20221025145309',
"rev_timestamp < '20221025145309'"
],
[
'rev_timestamp', '<=', '20221025145309',
"rev_timestamp <= '20221025145309'"
],
[
'rev_timestamp', '=', '20221025145309',
"rev_timestamp = '20221025145309'"
],
[
'rev_timestamp', '!=', '20221025145309',
"rev_timestamp != '20221025145309'"
],
[
'revision.rev_timestamp', '!=', '20221025145309',
"revision.rev_timestamp != '20221025145309'"
],
[
'rev_id', '>', 12345,
"rev_id > 12345"
],
[
'rev_id', '>=', 12345,
"rev_id >= 12345"
],
[
'rev_id', '<', 12345,
"rev_id < 12345"
],
[
'rev_id', '<=', 12345,
"rev_id <= 12345"
],
[
'rev_id', '=', 12345,
"rev_id = 12345"
],
[
'rev_id', '=', [ 'x' ],
"rev_id = 'x'"
],
[
'rev_id', '!=', 12345,
"rev_id != 12345"
],
[
'rev_id', '!=', [ 'x' ],
"rev_id != 'x'"
],
[
'rev_id', '=', [ 12345, 456 ],
"rev_id IN (12345,456)"
],
[
'rev_id', '!=', [ 12345, 456 ],
"rev_id NOT IN (12345,456)"
],
[
'rc_old_len', '=', null,
"rc_old_len IS NULL"
],
[
'rc_old_len', '!=', null,
"rc_old_len IS NOT NULL"
],
[
'rev_timestamp', '=', [ '20221025145309', '20230919152602' ],
"rev_timestamp IN ('20221025145309','20230919152602')"
],
[
'rev_timestamp', '!=', [ '20221025145309', '20230919152602' ],
"rev_timestamp NOT IN ('20221025145309','20230919152602')"
],
[
'user_name', IExpression::LIKE, new LikeValue( 'foo', new LikeMatch( '%' ) ),
"user_name LIKE 'foo%' ESCAPE '`'"
],
[
'user_name', IExpression::NOT_LIKE, new LikeValue( new LikeMatch( '%' ), 'foo' ),
"user_name NOT LIKE '%foo' ESCAPE '`'"
],
[
'user_name', IExpression::LIKE, new LikeValue( 'foo' ),
"user_name LIKE 'foo' ESCAPE '`'"
],
[
'user_name', IExpression::LIKE, new LikeValue( new LikeMatch( '_' ), '%_', new LikeMatch( '%' ) ),
"user_name LIKE '_`%`_%' ESCAPE '`'"
],
];
}
/**
* @dataProvider provideSimple
*/
public function testSimple( $field, $op, $value, $sql ) {
$expr = new Expression( $field, $op, $value );
$this->assertSame( $sql, $expr->toSql( new AddQuoterMock() ) );
}
public static function provideSimpleInvalid() {
return [
[ 'rev_timestamp', 'bigger', '12345' ],
[ 'rev_timestamp', 'bigger', 1234 ],
[ 'rev_timestamp', '=', [] ],
[ 'rev_timestamp', '=', [ 1234, null, 456 ] ],
[ 'rev_timestamp', '>', [ 1234, 456 ] ],
[ 'rev_timestamp', '<', [ 1234, 456 ] ],
[ 'rev_timestamp', '>', null ],
[ 'rev_timestamp', '<', null ],
[ 'rev_timestamp', '=<', '12345' ],
'associative array' => [ 'rev_timestamp', '=', [ 'a' => 1234, 'b' => 456 ] ],
'associative array (single)' => [ 'rev_timestamp', '=', [ 'a' => 1234 ] ],
'array with gaps' => [ 'rev_timestamp', '=', array_unique( [ 1234, 1234, 456, 456 ] ) ],
[ 'user_name', IExpression::LIKE, 'foo' ],
[ 'user_name', IExpression::LIKE, [ 'foo' ] ],
[ 'user_name', '=', new LikeValue( 'foo' ) ],
[ 'SELECT user_password from user where user_id = 1', '>', 1234 ],
];
}
/** @dataProvider provideSimpleInvalid */
public function testSimpleInvalid( $field, $op, $value ): void {
$this->expectException( InvalidArgumentException::class );
$expr = new Expression( $field, $op, $value );
$expr->toSql( new AddQuoterMock() );
}
public function testSimpleChain() {
$expr = ( new Expression( 'rev_timestamp', '>', '20221025145309' ) )
->and( 'rev_timestamp', '<', '20230919152602' );
$this->assertSame(
"(rev_timestamp > '20221025145309' AND rev_timestamp < '20230919152602')",
$expr->toSql( new AddQuoterMock() )
);
$expr = ( new Expression( 'rev_timestamp', '>', '20221025145309' ) )
->or( 'rev_timestamp', '<', '20230919152602' );
$this->assertSame(
"(rev_timestamp > '20221025145309' OR rev_timestamp < '20230919152602')",
$expr->toSql( new AddQuoterMock() )
);
$expr = ( new Expression( 'rev_timestamp', '>', '20221025145309' ) )
->and( 'rev_id', '=', [ 1234, 4567 ] );
$this->assertSame(
"(rev_timestamp > '20221025145309' AND rev_id IN (1234,4567))",
$expr->toSql( new AddQuoterMock() )
);
$expr = ( new Expression( 'rev_timestamp', '>', '20221025145309' ) )
->or( 'rev_id', '=', [ 1234, 4567 ] );
$this->assertSame(
"(rev_timestamp > '20221025145309' OR rev_id IN (1234,4567))",
$expr->toSql( new AddQuoterMock() )
);
$expr = ( new Expression( 'rev_timestamp', '>', '20221025145309' ) )
->and( 'rc_old_len', '!=', null );
$this->assertSame(
"(rev_timestamp > '20221025145309' AND rc_old_len IS NOT NULL)",
$expr->toSql( new AddQuoterMock() )
);
$expr = ( new Expression( 'rev_timestamp', '>', '20221025145309' ) )
->or( 'rc_old_len', '!=', null );
$this->assertSame(
"(rev_timestamp > '20221025145309' OR rc_old_len IS NOT NULL)",
$expr->toSql( new AddQuoterMock() )
);
$expr = ( new Expression( 'rev_timestamp', '>', '20221025145309' ) )
->and( 'rc_old_len', '=', null );
$this->assertSame(
"(rev_timestamp > '20221025145309' AND rc_old_len IS NULL)",
$expr->toSql( new AddQuoterMock() )
);
$expr = ( new Expression( 'rev_timestamp', '>', '20221025145309' ) )
->or( 'rc_old_len', '=', null );
$this->assertSame(
"(rev_timestamp > '20221025145309' OR rc_old_len IS NULL)",
$expr->toSql( new AddQuoterMock() )
);
}
public function testComplexChain() {
$expr = ( new Expression( 'rev_timestamp', '>', '20221025145309' ) )
->or( 'rc_old_len', '=', null )
->or( 'rc_new_len', '=', null );
$this->assertSame(
"(rev_timestamp > '20221025145309' OR rc_old_len IS NULL OR rc_new_len IS NULL)",
$expr->toSql( new AddQuoterMock() )
);
$expr2 = ( new Expression( 'rev_id', '=', [ 123, 456 ] ) )
->andExpr( $expr );
$this->assertSame(
"(rev_id IN (123,456) AND " .
"(rev_timestamp > '20221025145309' OR rc_old_len IS NULL OR rc_new_len IS NULL))",
$expr2->toSql( new AddQuoterMock() )
);
$expr3 = ( new Expression( 'rev_actor', '>', 3 ) )
->orExpr( $expr2 );
$this->assertSame(
"(rev_actor > 3 OR (rev_id IN (123,456) AND " .
"(rev_timestamp > '20221025145309' OR rc_old_len IS NULL OR rc_new_len IS NULL)))",
$expr3->toSql( new AddQuoterMock() )
);
$expr4 = ( new AndExpressionGroup( new Expression( 'rev_id', '=', [ 123, 456 ] ) ) )
->andExpr( $expr );
$this->assertSame(
"(rev_id IN (123,456) AND " .
"(rev_timestamp > '20221025145309' OR rc_old_len IS NULL OR rc_new_len IS NULL))",
$expr4->toSql( new AddQuoterMock() )
);
$expr5 = ( new OrExpressionGroup( new Expression( 'rev_id', '=', [ 123, 456 ] ) ) )
->orExpr( $expr2 );
$this->assertSame(
"(rev_id IN (123,456) OR (rev_id IN (123,456) AND " .
"(rev_timestamp > '20221025145309' OR rc_old_len IS NULL OR rc_new_len IS NULL)))",
$expr5->toSql( new AddQuoterMock() )
);
}
}
|
