1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527
|
<?php
namespace MediaWiki\Tests\Parser\Parsoid;
use MediaWiki\Language\Language;
use MediaWiki\Language\LanguageCode;
use MediaWiki\Language\LanguageConverter;
use MediaWiki\Languages\LanguageConverterFactory;
use MediaWiki\Languages\LanguageFactory;
use MediaWiki\Page\PageIdentity;
use MediaWiki\Page\PageIdentityValue;
use MediaWiki\Parser\Parsoid\Config\PageConfig;
use MediaWiki\Parser\Parsoid\Config\PageConfigFactory;
use MediaWiki\Parser\Parsoid\Config\SiteConfig;
use MediaWiki\Parser\Parsoid\LanguageVariantConverter;
use MediaWiki\Title\Title;
use MediaWiki\Title\TitleFactory;
use MediaWikiUnitTestCase;
use PHPUnit\Framework\Constraint\Constraint;
use PHPUnit\Framework\MockObject\MockObject;
use Wikimedia\Bcp47Code\Bcp47Code;
use Wikimedia\Bcp47Code\Bcp47CodeValue;
use Wikimedia\Parsoid\Core\PageBundle;
use Wikimedia\Parsoid\Parsoid;
/**
* @covers \MediaWiki\Parser\Parsoid\LanguageVariantConverter
*/
class LanguageVariantConverterUnitTest extends MediaWikiUnitTestCase {
/** @dataProvider provideSetConfig */
public function testSetConfig( bool $shouldPageConfigFactoryBeUsed ) {
// Decide what should be called and what should not be
$shouldParsoidBeUsed = true;
$isLanguageConversionEnabled = true;
// Set expected language codes
// *These are all MediaWiki-internal codes*
$pageBundleLanguageCode = 'zh';
$titleLanguageCode = 'zh-hans';
$targetLanguageCode = 'zh-hans';
$sourceLanguageCode = null;
// Create mocks
$pageConfigMock = $this->getPageConfigMock();
$pageBundleMock = $this->getPageBundleMock( $pageBundleLanguageCode );
$languageVariantConverter = $this->getLanguageVariantConverter(
$shouldParsoidBeUsed,
$shouldPageConfigFactoryBeUsed,
$isLanguageConversionEnabled,
$pageBundleLanguageCode,
null,
$titleLanguageCode,
$targetLanguageCode,
$sourceLanguageCode
);
if ( !$shouldPageConfigFactoryBeUsed ) {
$languageVariantConverter->setPageConfig( $pageConfigMock );
}
$languageFactoryMock = $this->getLanguageFactoryMock();
$languageVariantConverter->convertPageBundleVariant(
$pageBundleMock,
new Bcp47CodeValue( $targetLanguageCode )
);
}
public static function provideSetConfig() {
yield 'PageConfigFactory should not be used if PageConfig is set' => [ false ];
yield 'PageConfigFactory should be used if PageConfig is not set' => [ true ];
}
/** @dataProvider provideSourceLanguage */
public function testSourceLanguage(
?string $pageBundleLanguageCode,
?string $titleLanguageCode,
?string $contentLanguageOverride,
?string $targetLanguageCode,
?string $sourceLanguageCode,
?string $expectedSourceCode
) {
// Decide what should be called and what should not be
$shouldParsoidBeUsed = true;
$shouldPageConfigFactoryBeUsed = true;
$isLanguageConversionEnabled = true;
// Set expected language codes
$titleLanguageCode ??= 'en';
$targetLanguageCode ??= $titleLanguageCode;
// Create mocks
if ( $pageBundleLanguageCode ) {
$pageBundleMock = $this->getPageBundleMock( $pageBundleLanguageCode );
} else {
$pageBundleMock = $this->getPageBundleMockWithoutLanguage();
}
$languageVariantConverter = $this->getLanguageVariantConverter(
$shouldParsoidBeUsed,
$shouldPageConfigFactoryBeUsed,
$isLanguageConversionEnabled,
$pageBundleLanguageCode,
$contentLanguageOverride,
$titleLanguageCode,
$targetLanguageCode, // expected target language
$expectedSourceCode
);
$targetLanguage = new Bcp47CodeValue( $targetLanguageCode );
$sourceLanguage = $sourceLanguageCode ? new Bcp47CodeValue( $sourceLanguageCode ) : null;
$languageVariantConverter->convertPageBundleVariant( $pageBundleMock, $targetLanguage, $sourceLanguage );
}
public static function provideSourceLanguage() {
yield 'content-language in PageBundle' => [
'sr', // PageBundle content-language
null, // Title PageLanguage
null, // PageLanguage override
'sr-Cyrl', // target
'sr-Cyrl', // explicit source
'sr-Cyrl' // expected source
];
yield 'content-language but no source language' => [
'en', // PageBundle content-language
null, // Title PageLanguage
null, // PageLanguage override
'en', // target
null, // explicit source
null // expected source
];
yield 'content-language is variant' => [
'en-ca', // PageBundle content-language
null, // Title PageLanguage
null, // PageLanguage override
'en', // target
null, // explicit source
'en-ca' // expected source
];
yield 'Source variant is given' => [
null, // PageBundle content-language
null, // Title PageLanguage
null, // PageLanguage override
'en', // target
'en-ca', // explicit source
'en-ca' // expected source
];
yield 'Source variant is a base language' => [
null, // PageBundle content-language
null, // Title PageLanguage
null, // PageLanguage override
'en', // target
'en', // explicit source
null // expected source
];
yield 'Page language override is variant' => [
null, // PageBundle content-language
null, // PageBundle content-language
'en-ca', // PageLanguage override
'en', // target
'en-ca', // explicit source
'en-ca' // expected source
];
}
/** @dataProvider provideSiteConfiguration */
public function testSiteConfiguration(
bool $isLanguageConversionEnabled,
bool $shouldParsoidBeUsed,
bool $shouldPageConfigFactoryBeUsed
) {
// Set expected language codes
$pageBundleLanguageCode = 'zh';
$titleLanguageCode = 'zh-hans';
$targetLanguageCode = 'zh-hans';
$sourceLanguageCode = null;
// Create mocks
$pageBundleMock = $this->getPageBundleMock( $pageBundleLanguageCode );
$languageVariantConverter = $this->getLanguageVariantConverter(
$shouldParsoidBeUsed,
$shouldPageConfigFactoryBeUsed,
$isLanguageConversionEnabled,
$pageBundleLanguageCode,
null,
$titleLanguageCode,
$targetLanguageCode,
$sourceLanguageCode
);
$languageFactoryMock = $this->getLanguageFactoryMock();
$targetLanguage = $languageFactoryMock->getLanguage( $targetLanguageCode );
$languageVariantConverter->convertPageBundleVariant( $pageBundleMock, $targetLanguage );
}
public static function provideSiteConfiguration() {
$isLanguageConversionEnabled = false;
$shouldParsoidBeUsed = false;
$shouldPageConfigFactoryBeUsed = false;
yield 'If language conversion is disabled, parsoid and page config factory should not be used' =>
[ $isLanguageConversionEnabled, $shouldParsoidBeUsed, $shouldPageConfigFactoryBeUsed ];
$isLanguageConversionEnabled = true;
$shouldParsoidBeUsed = true;
$shouldPageConfigFactoryBeUsed = true;
yield 'If language conversion is enabled, parsoid and page config factory should be used' =>
[ $isLanguageConversionEnabled, $shouldParsoidBeUsed, $shouldPageConfigFactoryBeUsed ];
}
/**
* @param bool $shouldParsoidBeUsed
* @param bool $shouldPageConfigFactoryBeUsed
* @param bool $isLanguageConversionEnabled
* @param string|null $pageBundleLanguageCode
* @param string|null $contentLanguageOverride
* @param string $titleLanguageCode
* @param string $targetLanguageCode
* @param string|null $sourceLanguageCode
*
* @return LanguageVariantConverter
*/
private function getLanguageVariantConverter(
bool $shouldParsoidBeUsed,
bool $shouldPageConfigFactoryBeUsed,
bool $isLanguageConversionEnabled,
?string $pageBundleLanguageCode,
?string $contentLanguageOverride,
string $titleLanguageCode,
string $targetLanguageCode,
?string $sourceLanguageCode
): LanguageVariantConverter {
// If Content language is set, use language from there,
// If PageBundle language code is set, use that
// Else, fallback to title page language
$pageLanguageCode = $contentLanguageOverride ?? $pageBundleLanguageCode ?? $titleLanguageCode;
// The page language code should not be a variant
$pageLanguageCode = preg_replace( '/-.*$/', '', $pageLanguageCode );
$shouldSiteConfigBeUsed = true;
$pageIdentityValue = new PageIdentityValue( 1, NS_MAIN, 'hello_world', PageIdentity::LOCAL );
// Create the necessary mocks
$languageFactoryMock = $this->getLanguageFactoryMock();
$pageLanguage = new Bcp47CodeValue( $pageLanguageCode );
$sourceLanguage = $sourceLanguageCode ? new Bcp47CodeValue( $sourceLanguageCode ) : null;
$targetLanguage = new Bcp47CodeValue( $targetLanguageCode );
$pageConfigMock = $this->getPageConfigMock();
$pageConfigFactoryMock = $this->getPageConfigFactoryMock(
$shouldPageConfigFactoryBeUsed,
// Expected arguments to PageConfigFactory mock
[ $pageIdentityValue, null, null, null, $this->constraintEquals( $pageLanguage ) ],
$pageConfigMock
);
$pageBundleMock = $this->getPageBundleMock( $pageBundleLanguageCode );
$siteConfigMock = $this->getSiteConfigMock(
$shouldSiteConfigBeUsed, $pageLanguage, $isLanguageConversionEnabled
);
$titleFactoryMock = $this->getTitleFactoryMock( $pageIdentityValue, $titleLanguageCode );
$parsoidMock = $this->getParsoidMock(
$shouldParsoidBeUsed,
[
$pageConfigMock,
'variant',
$pageBundleMock,
$this->constraintEquals( [
'variant' => [
'source' => $sourceLanguage,
'target' => $targetLanguage,
]
] )
]
);
$languageVariantConverter = new LanguageVariantConverter(
$pageIdentityValue,
$pageConfigFactoryMock,
$parsoidMock,
$siteConfigMock,
$titleFactoryMock,
$this->getLanguageConverterFactoryMock(),
$languageFactoryMock
);
if ( $contentLanguageOverride ) {
$languageVariantConverter->setPageLanguageOverride(
$languageFactoryMock->getLanguage( $contentLanguageOverride )
);
}
return $languageVariantConverter;
}
// Mock methods follow
/**
* @param bool $shouldBeCalled
* @param array $arguments
* @param PageConfig $pageConfig
*
* @return MockObject|PageConfigFactory
*/
private function getPageConfigFactoryMock( bool $shouldBeCalled, array $arguments, PageConfig $pageConfig ) {
$mock = $this->createMock( PageConfigFactory::class );
if ( $shouldBeCalled ) {
$mock->expects( $this->once() )
->method( 'create' )
->with( ...$arguments )
->willReturn( $pageConfig );
} else {
$mock->expects( $this->never() )
->method( 'create' );
}
return $mock;
}
/**
* @param bool $shouldBeCalled
* @param array $arguments
*
* @return MockObject|Parsoid
*/
private function getParsoidMock( bool $shouldBeCalled, array $arguments ) {
$mock = $this->createMock( Parsoid::class );
if ( $shouldBeCalled ) {
$mock->expects( $this->once() )
->method( 'pb2pb' )
->with( ...$arguments );
} else {
$mock->expects( $this->never() )
->method( 'pb2pb' );
}
$mock->method( 'implementsLanguageConversionBcp47' )
->willReturn( true );
return $mock;
}
/**
* Mock constraint helper to compare equality when there are
* Bcp47Code instances involved.
* @param mixed $expected The expected value, with embedded Bcp47Codes
* @return Constraint a PHPUnit equality constrait
*/
private function constraintEquals( $expected ): Constraint {
return $this->callback( static function ( $actual ) use ( $expected ) {
return self::arrayWithCodeEquals( $expected, $actual );
} );
}
/**
* Compare two values for equality, using case-insensitive BCP-47 code
* comparisons for Bcp47Code instances.
* @param mixed $expected
* @param mixed $actual
* @return bool True if the objects should be considered equal, false otherwise.
*/
private static function arrayWithCodeEquals( $expected, $actual ) {
if ( $actual === $expected ) {
return true;
}
if ( is_array( $actual ) && is_array( $expected ) ) {
if ( count( $actual ) !== count( $expected ) ) {
return false;
}
foreach ( $expected as $key => $value ) {
if ( !array_key_exists( $key, $actual ) ) {
return false;
}
if ( !self::arrayWithCodeEquals( $value, $actual[$key] ) ) {
return false;
}
}
return true;
}
if ( $actual instanceof Bcp47Code && $expected instanceof Bcp47Code ) {
# BCP-47 codes are case insensitive.
return strcasecmp( $actual->toBcp47Code(), $expected->toBcp47Code() ) == 0;
}
return false;
}
/**
* @param bool $shouldBeCalled
* @param Bcp47Code $baseLanguage
* @param bool $isLanguageConversionEnabled
*
* @return MockObject|SiteConfig
*/
private function getSiteConfigMock(
bool $shouldBeCalled,
Bcp47Code $baseLanguage,
bool $isLanguageConversionEnabled
) {
$mock = $this->createMock( SiteConfig::class );
if ( $shouldBeCalled ) {
$mock->expects( $this->once() )
->method( 'langConverterEnabledBcp47' )
->with( $this->constraintEquals( $baseLanguage ) )
->willReturn( $isLanguageConversionEnabled );
} else {
$mock->expects( $this->never() )
->method( 'langConverterEnabledBcp47' );
}
return $mock;
}
/**
* @param PageIdentity $pageIdentity
* @param string $languageCode
*
* @return MockObject|TitleFactory
*/
private function getTitleFactoryMock( PageIdentity $pageIdentity, string $languageCode ) {
$languageMock = $this->getLanguageMock( $languageCode );
$titleMock = $this->createMock( Title::class );
$titleMock->method( 'getPageLanguage' )
->willReturn( $languageMock );
$mock = $this->createMock( TitleFactory::class );
$mock->expects( $this->once() )
->method( 'newFromPageIdentity' )
->willReturn( $titleMock )
->with( $pageIdentity );
return $mock;
}
/**
* @return MockObject|LanguageFactory
*/
private function getLanguageFactoryMock() {
$mock = $this->createMock( LanguageFactory::class );
$mock->method( 'getLanguage' )
->willReturnCallback( function ( $code ) {
static $seen = [];
if ( $code instanceof Bcp47Code ) {
$code = LanguageCode::bcp47ToInternal( $code );
}
if ( !isset( $seen[$code] ) ) {
$seen[$code] = $this->getLanguageMock( $code );
}
return $seen[$code];
} );
$mock->method( 'getParentLanguage' )
->willReturnCallback( static function ( $code ) use ( $mock ) {
if ( $code instanceof Bcp47Code ) {
$code = LanguageCode::bcp47ToInternal( $code );
}
$code = preg_replace( '/-.*$/', '', $code );
return $mock->getLanguage( $code );
} );
return $mock;
}
/**
* @return MockObject|PageBundle
*/
private function getPageBundleMockWithoutLanguage() {
return $this->getPageBundleMock( null );
}
/**
* @param string|null $languageCode
*
* @return MockObject|PageBundle
*/
private function getPageBundleMock( ?string $languageCode ) {
$mock = $this->createMock( PageBundle::class );
$mock->headers = [
# T320662: this should probably be a BCP-47 code, not internal
'content-language' => $languageCode
];
$mock->html = 'test message';
return $mock;
}
/**
* @return MockObject|PageConfig
*/
private function getPageConfigMock() {
$mock = $this->createNoOpMock( PageConfig::class, [ 'setVariantBcp47' ] );
return $mock;
}
/**
* @param string $languageCode
*
* @return MockObject|Language
*/
private function getLanguageMock( $languageCode ): Language {
$languageMock = $this->createMock( Language::class );
$languageMock->method( 'getCode' )
->willReturn( $languageCode );
$languageMock->method( 'toBcp47Code' )
->willReturn( LanguageCode::bcp47( $languageCode ) );
return $languageMock;
}
private function getLanguageConverterFactoryMock() {
$languageConverterFactoryMock = $this->createMock( LanguageConverterFactory::class );
$languageConverter = $this->createMock( LanguageConverter::class );
$languageConverter->method( 'convertTo' )
->willReturnCallback( static function ( $text, $code ) {
return $text;
} );
$languageConverter->method( 'hasVariant' )
->willReturnCallback( static function ( $code ) {
return true;
} );
$languageConverterFactoryMock->method( 'getLanguageConverter' )
->willReturn( $languageConverter );
return $languageConverterFactoryMock;
}
}
|