1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
|
/**
* (c) 2013 by Mega Limited, Auckland, New Zealand
*
* This file is part of MEGAcmd.
*
* MEGAcmd is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*
* @copyright Simplified (2-clause) BSD License.
*
* You should have received a copy of the license along with this
* program.
*/
#include <gtest/gtest.h>
#include "TestUtils.h"
#include "Instruments.h"
#include "megacmdcommonutils.h"
#include "comunicationsmanager.h"
namespace StringUtilsTest
{
static void trimming()
{
using megacmd::ltrim;
using megacmd::rtrim;
{
std::string s("123456");
G_SUBTEST << "Left trimming";
ASSERT_STREQ(ltrim(s, '2').c_str(), "123456");
ASSERT_STREQ(ltrim(s, '1').c_str(), "23456");
}
{
std::string s("123456");
G_SUBTEST << "Right trimming";
ASSERT_STREQ(rtrim(s, '2').c_str(), "123456");
ASSERT_STREQ(rtrim(s, '6').c_str(), "12345");
}
}
}
TEST(StringUtilsTest, trimming)
{
StringUtilsTest::trimming();
}
TEST(StringUtilsTest, rtrim)
{
using megacmd::rtrim;
G_SUBTEST << "Basic case";
{
std::string s("123456");
EXPECT_EQ(rtrim(s, '2'), "123456");
EXPECT_EQ(rtrim(s, '6'), "12345");
}
G_SUBTEST << "Empty string";
{
std::string s;
EXPECT_EQ(rtrim(s, ' ').length(), 0);
}
G_SUBTEST << "Only trim character";
{
std::string s(" ");
EXPECT_EQ(rtrim(s, ' ').length(), 0);
}
G_SUBTEST << "Multiple consecutive";
{
std::string s("11223344");
EXPECT_EQ(rtrim(s, '4'), "112233");
}
G_SUBTEST << "Special case with next character check";
{
std::string s("aab");
rtrim(s, 'a');
EXPECT_EQ(s, "aab");
}
G_SUBTEST << "Single character at end";
{
std::string s("abc123");
EXPECT_EQ(rtrim(s, '3'), "abc12");
}
G_SUBTEST << "Unicode characters";
{
std::string s("\xD0\x9C\xD0\x95\xD0\x93\xD0\x90 ");
EXPECT_TRUE(megacmd::isValidUtf8(s));
std::string result = rtrim(s, ' ');
EXPECT_TRUE(megacmd::isValidUtf8(result));
EXPECT_EQ(result, "\xD0\x9C\xD0\x95\xD0\x93\xD0\x90");
}
G_SUBTEST << "Single character string (trim character)";
{
std::string s("X");
EXPECT_EQ(rtrim(s, 'X').length(), 0);
}
G_SUBTEST << "Single character string (not trim character)";
{
std::string s("X");
EXPECT_EQ(rtrim(s, 'Y'), "X");
}
G_SUBTEST << "Special characters";
{
std::string s("test\t\t\t");
EXPECT_EQ(rtrim(s, '\t'), "test");
}
}
TEST(StringUtilsTest, ValidateUtf8)
{
// from: https://www.php.net/manual/en/reference.pcre.pattern.modifiers.php#54805
EXPECT_TRUE(megacmd::isValidUtf8(std::string("a")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xc3\xb1")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xe2\x82\xa1")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xf0\x90\x8c\xbc")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xf4\x80\x80\x80")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xf3\xa1\xa1\xa1")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xc2\x80")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xe0\xa0\x80")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xf0\x90\x80\x80")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xf4\x8f\xbf\xbf")));
EXPECT_TRUE(megacmd::isValidUtf8(std::string("\xed\x9f\xbf")));
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xf8\xa1\xa1\xa1\xa1"))); // 1st byte: 1111 1xxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xfc\xa1\xa1\xa1\xa1\xa1"))); // 1st byte: 1111 1xxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xE0\xA1\xD0"))); // 3rd byte: 11xx xxxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xc3\x28"))); // 2nd byte: 00xx xxxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xa0\xa1"))); // 1st byte: 10xx xxxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xe2\x28\xa1"))); // 2nd byte: 00xx xxxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xe2\x82\x28"))); // 3rd byte: 00xx xxxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xf0\x28\x8c\xbc"))); // 2nd byte: 00xx xxxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xf0\x90\x28\xbc"))); // 3rd byte: 00xx xxxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xf0\x28\x8c\x28"))); // 2nd & 3rd bytes: 00xx xxxx
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xc1\xbf"))); // codepoint less than U+0080
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xe0\x9f\xbf"))); // codepoint less than U+0800
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xf0\x8f\xbf\xbf"))); // codepoint less than U+10000
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xf4\x90\x80\x80"))); // codepoint greater than U+10FFFF
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xf4\x8f\xbf"))); // Length: expected = 4, actual = 3
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xe0\xa0"))); // Length: expected = 3, actual = 2
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xc2"))); // Length: expected = 2, actual = 1
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xed\xa0\x80"))); // surrogate codepoint U+D800
EXPECT_FALSE(megacmd::isValidUtf8(std::string("\xed\xbf\xbf"))); // surrogate codepoint U+DFFF
}
TEST(StringUtilsTest, nonAsciiToStringstream)
{
const char* char_str = u8"\uc548\uc548\ub155\ud558\uc138\uc694\uc138\uacc4";
const wchar_t* wchar_str = L"\uc548\uc548\ub155\ud558\uc138\uc694\uc138\uacc4";
const std::string str = u8"\uc548\uc548\ub155\ud558\uc138\uc694\uc138\uacc4";
const std::wstring wstr = L"\uc548\uc548\ub155\ud558\uc138\uc694\uc138\uacc4";
{
std::ostringstream ostream;
ostream << char_str;
EXPECT_STREQ(ostream.str().c_str(), char_str);
std::wostringstream wostream;
wostream << wchar_str;
EXPECT_STREQ(wostream.str().c_str(), wchar_str);
}
{
std::ostringstream ostream;
ostream << str;
EXPECT_EQ(ostream.str(), str);
std::wostringstream wostream;
wostream << wstr;
EXPECT_EQ(wostream.str(), wstr);
}
#ifdef _WIN32
using namespace megacmd; // otherwise the ostream overload for wstrings won't be visible
// we need it to ensure the static_assert is not triggered
{
std::ostringstream ostream;
ostream << utf16ToUtf8(wchar_str);
EXPECT_STREQ(ostream.str().c_str(), char_str);
std::wostringstream wostream;
wostream << char_str;
EXPECT_STREQ(wostream.str().c_str(), wchar_str);
}
{
std::ostringstream ostream;
ostream << utf16ToUtf8(wstr);
EXPECT_EQ(ostream.str(), str);
std::wostringstream wostream;
wostream << str;
EXPECT_EQ(wostream.str(), wstr);
}
#endif
}
TEST(StringUtilsTest, redactedCmdPetition)
{
using megacmd::CmdPetition;
{
G_SUBTEST << "Redact password";
CmdPetition petition;
petition.setLine("some-command --password=MySecretPassword --some-arg=Something -fv");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("MySecretPassword")));
EXPECT_THAT(redacted, testing::HasSubstr("--password=********"));
EXPECT_THAT(redacted, testing::HasSubstr("--some-arg=Something"));
}
{
G_SUBTEST << "Redact password with single quotes";
CmdPetition petition;
petition.setLine("some-command --password='My Secret Password' --some-arg=Something -fv");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("My Secret Password")));
EXPECT_THAT(redacted, testing::HasSubstr("--password=********"));
EXPECT_THAT(redacted, testing::HasSubstr("--some-arg=Something"));
// Ensure the full password gets redacted, not only the first word
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("Secret Password")));
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("Password")));
}
{
G_SUBTEST << "Redact password with double quotes";
CmdPetition petition;
petition.setLine("some-command --password=\"My Secret Password\" --some-arg=Something -fv");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("My Secret Password")));
EXPECT_THAT(redacted, testing::HasSubstr("--password=********"));
EXPECT_THAT(redacted, testing::HasSubstr("--some-arg=Something"));
// Ensure the full password gets redacted, not only the first word
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("Secret Password")));
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("Password")));
}
{
G_SUBTEST << "Redact auth-key and auth-code";
CmdPetition petition;
petition.setLine("some-command --auth-code=abc123 --some-arg=Something --auth-key=def456");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("abc123")));
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("def456")));
EXPECT_THAT(redacted, testing::HasSubstr("--auth-code=********"));
EXPECT_THAT(redacted, testing::HasSubstr("--auth-key=********"));
EXPECT_THAT(redacted, testing::HasSubstr("--some-arg=Something"));
}
{
G_SUBTEST << "Redact login";
CmdPetition petition;
petition.setLine("login some-email@real-website.com SuperSecret1234!'");
const std::string redacted = petition.getRedactedLine();
EXPECT_EQ(redacted, "login <REDACTED>");
}
{
G_SUBTEST << "Redact login no email";
CmdPetition petition;
petition.setLine("login https://mega.nz/folder/bxomFKwL#3V1dUJFzL98t1GqXX29IXg");
const std::string redacted = petition.getRedactedLine();
EXPECT_EQ(redacted, "login <REDACTED>");
}
{
G_SUBTEST << "Redact login even with auth-code";
CmdPetition petition;
petition.setLine("login --auth-code=1SomeAuthCode1 SomeSuperSecret");
const std::string redacted = petition.getRedactedLine();
EXPECT_EQ(redacted, "login <REDACTED>");
}
{
G_SUBTEST << "Redact passwd";
CmdPetition petition;
petition.setLine("passwd -f NewPassword");
const std::string redacted = petition.getRedactedLine();
EXPECT_EQ(redacted, "passwd <REDACTED>");
}
{
G_SUBTEST << "Redact passwd from shell";
CmdPetition petition;
petition.setLine("Xpasswd -f NewPassword");
const std::string redacted = petition.getRedactedLine();
EXPECT_EQ(redacted, "Xpasswd <REDACTED>");
}
{
G_SUBTEST << "Redact confirm";
CmdPetition petition;
petition.setLine("confirm somelink1234 Password");
const std::string redacted = petition.getRedactedLine();
EXPECT_EQ(redacted, "confirm <REDACTED>");
}
{
G_SUBTEST << "Redact confirmcancel";
CmdPetition petition;
petition.setLine("confirmcancel somelink123 Password");
const std::string redacted = petition.getRedactedLine();
EXPECT_EQ(redacted, "confirmcancel <REDACTED>");
}
{
G_SUBTEST << "Redact folder link";
CmdPetition petition;
petition.setLine("import https://mega.nz/folder/bxomFKwL#3V1dUJFzL98t1GqXX29IXg");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("3V1dUJFzL98t1GqXX29IXg")));
EXPECT_THAT(redacted, testing::HasSubstr("https://mega.nz/folder/bxomFKwL#********"));
}
{
G_SUBTEST << "Redact file link";
CmdPetition petition;
petition.setLine("get https://mega.nz/file/d0w0nyiy#egvjqp5r-anbbdsjg8qrvg");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("egvjqp5r-anbbdsjg8qrvg")));
EXPECT_THAT(redacted, testing::HasSubstr("https://mega.nz/file/d0w0nyiy#********"));
}
{
G_SUBTEST << "Redact old folder link";
CmdPetition petition;
petition.setLine("get https://mega.nz/#F!bxomFKwL#3V1dUJFzL98t1GqXX29IXg");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("3V1dUJFzL98t1GqXX29IXg")));
EXPECT_THAT(redacted, testing::HasSubstr("https://mega.nz/#F!bxomFKwL#********"));
}
{
G_SUBTEST << "Redact old file link";
CmdPetition petition;
petition.setLine("import https://mega.nz/#!d0w0nyiy#egvjqp5r-anbbdsjg8qrvg");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("egvjqp5r-anbbdsjg8qrvg")));
EXPECT_THAT(redacted, testing::HasSubstr("https://mega.nz/#!d0w0nyiy#********"));
}
{
G_SUBTEST << "Redact encrypted link";
CmdPetition petition;
petition.setLine("some-other-command https://mega.nz/#P!egvjqp5r-anbbdsjg8qrvg");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("egvjqp5r-anbbdsjg8qrvg")));
EXPECT_THAT(redacted, testing::HasSubstr("https://mega.nz/#P!********"));
}
{
G_SUBTEST << "DO_NOT_REDACT env variable override";
auto doNotRedactGuard = TestInstrumentsEnvVarGuard("MEGACMD_DO_NOT_REDACT_LINES", "1");
{
CmdPetition petition;
petition.setLine("some-command --password=MySecretPassword --some-arg=Something -fv");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::HasSubstr("--password=MySecretPassword"));
}
{
CmdPetition petition;
petition.setLine("login some-email@real-website.com SuperSecret1234!'");
const std::string redacted = petition.getRedactedLine();
EXPECT_THAT(redacted, testing::HasSubstr("some-email@real-website.com"));
EXPECT_THAT(redacted, testing::HasSubstr("SuperSecret1234!'"));
EXPECT_THAT(redacted, testing::Not(testing::HasSubstr("<REDACTED>")));
}
}
}
|
