File: 0012-cgi-nph-response

package info (click to toggle)
mini-httpd 1.30-13
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 1,564 kB
  • sloc: ansic: 3,634; sh: 156; makefile: 109
file content (27 lines) | stat: -rw-r--r-- 908 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
Description: Fixes bug where NPH script gets additional wrong HTTP 200/OK
Author: Alexandru Mihail, alexandru.mihail2897@gmail.com
Origin: maintainer
Last-Update: 2024-03-08
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/mini_httpd.c
+++ b/mini_httpd.c
@@ -2056,11 +2056,13 @@
 
     if ( ! parse_headers )
 	{
-	/* If we're not parsing headers, write out the default status line
-	** and proceed to the echo phase.
-	*/
-	char http_head[] = "HTTP/1.0 200 OK\015\012";
-	(void) my_write( http_head, sizeof(http_head) );
+	/* Note: CGI RFC (RFC-3875) states that the server must ensure that
+	 * the script output is sent to the client unmodified.
+	 * Before, we were sending a HTTP/1.0 200 OK header here, thus
+	 * violating the NPH Response RFC. This branch executes only on
+	 * SSL and NPH scripts anyway, so we do nothing for now.
+	 * ( #1064656 )
+	 */
 	}
     else
 	{