1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
|
/*
* Copyright © Canonical Ltd.
*
* This program is free software: you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 or 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "application_selector.h"
#include "test_window_manager_tools.h"
#include <mir/scene/session.h>
using namespace miral;
namespace mt = mir::test;
using namespace testing;
struct ApplicationSelectorTest : mt::TestWindowManagerTools
{
ApplicationSelector application_selector;
ApplicationSelectorTest()
: mt::TestWindowManagerTools(),
application_selector(window_manager_tools)
{}
auto create_window() -> Window
{
mir::shell::SurfaceSpecification creation_parameters;
creation_parameters.type = mir_window_type_normal;
creation_parameters.focus_mode = MirFocusMode::mir_focus_mode_focusable;
creation_parameters.set_size({600, 400});
auto window = create_and_select_window(creation_parameters);
// Simulates a new application opening and gaining focus
application_selector.advise_new_window(window_manager_tools.info_for(window));
application_selector.advise_focus_gained(window_manager_tools.info_for(window));
return window;
}
auto create_window_for_app(std::shared_ptr<mir::scene::Session> app) -> Window
{
mir::shell::SurfaceSpecification creation_parameters;
creation_parameters.type = mir_window_type_normal;
creation_parameters.focus_mode = MirFocusMode::mir_focus_mode_focusable;
creation_parameters.set_size({600, 400});
auto window = create_and_select_window_for_session(creation_parameters, app);
// Simulates a new application opening and gaining focus
application_selector.advise_new_window(window_manager_tools.info_for(window));
application_selector.advise_focus_gained(window_manager_tools.info_for(window));
return window;
}
auto create_window_list(int num_windows) -> std::vector<Window>
{
std::vector<Window> window_list;
for (int index = 0; index < num_windows; index++)
{
window_list.push_back(create_window());
}
return window_list;
}
auto create_window_list_on_same_app(int num_windows) -> std::vector<Window>
{
auto session_to_add = std::make_shared<mt::StubStubSession>();
std::vector<Window> window_list;
for (int index = 0; index < num_windows; index++)
{
window_list.push_back(create_window_for_app(session_to_add));
}
return window_list;
}
};
TEST_F(ApplicationSelectorTest, focused_window_is_latest_selected)
{
auto windows = create_window_list(3);
EXPECT_EQ(windows[2], application_selector.get_focused());
}
TEST_F(ApplicationSelectorTest, moving_forward_once_by_app_selects_previously_selected_window)
{
auto windows = create_window_list(3);
auto window = application_selector.next(false);
EXPECT_EQ(window, windows[1]);
}
TEST_F(ApplicationSelectorTest, moving_backward_once_by_app_selects_least_recently_selected_window)
{
auto windows = create_window_list(3);
auto window = application_selector.prev(false);
EXPECT_EQ(window, windows[0]);
}
TEST_F(ApplicationSelectorTest, moving_forward_through_list_once_by_app_arrives_at_original_window)
{
int num_windows = 3;
auto windows = create_window_list(num_windows);
for (int i = 0; i < 3; i++)
application_selector.next(false);
auto window = application_selector.complete();
EXPECT_EQ(window, windows[2]);
}
TEST_F(ApplicationSelectorTest, new_selector_is_not_active)
{
auto windows = create_window_list(3);
EXPECT_FALSE(application_selector.is_active());
}
TEST_F(ApplicationSelectorTest, moving_forward_once_by_app_with_no_windows_results_in_default_window)
{
auto window = application_selector.next(false);
EXPECT_EQ(window, Window());
EXPECT_FALSE(application_selector.is_active());
}
TEST_F(ApplicationSelectorTest, focusing_a_new_window_while_application_selector_is_active_focuses_the_new_window)
{
auto windows = create_window_list(3);
application_selector.prev(false);
auto new_window = create_window();
auto focused = application_selector.get_focused();
EXPECT_EQ(focused, new_window);
}
TEST_F(ApplicationSelectorTest, window_added_while_selection_is_active_get_added_to_end_of_list)
{
auto windows = create_window_list(3);
application_selector.next(false);
auto new_window = create_window();
auto window = application_selector.prev(false);
EXPECT_EQ(window, windows[0]);
}
TEST_F(ApplicationSelectorTest, deleting_selected_window_makes_the_next_window_selected)
{
auto windows = create_window_list(3);
application_selector.next(false); // windows[1] is selected
application_selector.advise_focus_gained(window_manager_tools.info_for(windows[1]));
application_selector.advise_delete_window(window_manager_tools.info_for(windows[1]));
auto window = application_selector.get_focused();
EXPECT_EQ(window, windows[0]);
}
TEST_F(ApplicationSelectorTest, moving_forward_once_within_an_app_when_there_isnt_another_window_results_in_the_currently_selected_window_remaining_the_same)
{
auto windows = create_window_list(3);
auto window = application_selector.next(true);
EXPECT_EQ(window, windows[2]);
}
TEST_F(ApplicationSelectorTest, moving_forward_once_within_an_app_selects_the_next_window)
{
auto windows = create_window_list_on_same_app(3);
auto window = application_selector.next(true);
EXPECT_EQ(window, windows[1]);
}
TEST_F(ApplicationSelectorTest, moving_backward_once_within_an_app_selects_the_previous_window)
{
auto windows = create_window_list_on_same_app(3);
auto window = application_selector.prev(true);
EXPECT_EQ(window, windows[0]);
}
TEST_F(ApplicationSelectorTest, moving_forward_once_within_an_app_selects_the_next_window_when_a_different_app_is_in_the_way)
{
auto app = std::make_shared<mt::StubStubSession>();;
auto first = create_window();
auto second = create_window_for_app(app);
auto third = create_window();
auto fourth = create_window_for_app(app);
auto fifth = create_window();
auto sixth = create_window_for_app(app);
auto window = application_selector.next(true);
EXPECT_EQ(window, fourth);
}
TEST_F(ApplicationSelectorTest, moving_forward_through_all_windows_in_an_app_selects_the_original_window)
{
auto app = std::make_shared<mt::StubStubSession>();;
auto first = create_window();
auto second = create_window_for_app(app);
auto third = create_window();
auto fourth = create_window_for_app(app);
auto fifth = create_window();
auto sixth = create_window_for_app(app);
for (int i = 0; i < 3; i++)
{
auto window = application_selector.next(true);
application_selector.advise_focus_gained(window_manager_tools.info_for(window));
}
auto window = application_selector.complete();
EXPECT_EQ(window, sixth);
}
|
