1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265
|
/*
* Copyright © Canonical Ltd.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 or 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "src/server/input/key_repeat_dispatcher.h"
#include "mir/events/event_private.h"
#include "mir/events/event_builders.h"
#include "mir/time/alarm.h"
#include "mir/time/alarm_factory.h"
#include "mir/input/input_device_observer.h"
#include "mir/input/mir_pointer_config.h"
#include "mir/input/mir_touchpad_config.h"
#include "mir/input/mir_touchscreen_config.h"
#include "mir/input/mir_keyboard_config.h"
#include "mir/input/device.h"
#include "mir/test/fake_shared.h"
#include "mir/test/event_matchers.h"
#include "mir/test/doubles/mock_input_dispatcher.h"
#include "mir/test/doubles/mock_input_device_hub.h"
#include <gtest/gtest.h>
#include <gmock/gmock.h>
#include <xkbcommon/xkbcommon-keysyms.h>
namespace mi = mir::input;
namespace mev = mir::events;
namespace mt = mir::test;
namespace mtd = mt::doubles;
using namespace ::testing;
namespace
{
struct MockAlarm : public mir::time::Alarm
{
MOCK_METHOD0(cancel, bool());
MOCK_CONST_METHOD0(state, mir::time::Alarm::State());
MOCK_METHOD1(reschedule_in, bool(std::chrono::milliseconds));
MOCK_METHOD1(reschedule_for, bool(mir::time::Timestamp));
// destructor cancels the alarm
~MockAlarm()
{
cancel();
}
};
struct MockAlarmFactory : public mir::time::AlarmFactory
{
MOCK_METHOD1(create_alarm_adapter, mir::time::Alarm*(std::function<void()> const&));
std::unique_ptr<mir::time::Alarm> create_alarm(std::function<void()> const& cb)
{
return std::unique_ptr<mir::time::Alarm>(create_alarm_adapter(cb));
}
std::unique_ptr<mir::time::Alarm> create_alarm(std::unique_ptr<mir::LockableCallback>)
{
return nullptr;
}
};
struct StubDevice : public mi::Device
{
MirInputDeviceId device_id;
std::string device_name;
StubDevice(MirInputDeviceId id) : device_id(id) {}
StubDevice(MirInputDeviceId id, std::string device_name) : device_id{id}, device_name{device_name}
{
}
MirInputDeviceId id() const
{
return device_id;
}
mi::DeviceCapabilities capabilities() const {return mi::DeviceCapability::keyboard;}
std::string name() const {return device_name;}
std::string unique_id() const {return {};}
mir::optional_value<MirPointerConfig> pointer_configuration() const {return {};}
void apply_pointer_configuration(MirPointerConfig const&) {;}
mir::optional_value<MirTouchpadConfig> touchpad_configuration() const {return {};}
void apply_touchpad_configuration(MirTouchpadConfig const&) {}
mir::optional_value<MirKeyboardConfig> keyboard_configuration() const {return {};}
void apply_keyboard_configuration(MirKeyboardConfig const&) {}
mir::optional_value<MirTouchscreenConfig> touchscreen_configuration() const {return {};}
void apply_touchscreen_configuration(MirTouchscreenConfig const&) {}
};
struct KeyRepeatDispatcher : public testing::Test
{
KeyRepeatDispatcher(bool on_arale = false)
: dispatcher(mock_next_dispatcher, mock_alarm_factory, true, repeat_time, repeat_delay, on_arale)
{
ON_CALL(hub,add_observer(_)).WillByDefault(SaveArg<0>(&observer));
dispatcher.set_input_device_hub(mt::fake_shared(hub));
}
void simulate_device_removal()
{
StubDevice dev(test_device);
observer->device_removed(mt::fake_shared(dev));
observer->changes_complete();
}
const MirInputDeviceId test_device = 123;
std::shared_ptr<mtd::MockInputDispatcher> mock_next_dispatcher = std::make_shared<mtd::MockInputDispatcher>();
std::shared_ptr<MockAlarmFactory> mock_alarm_factory = std::make_shared<MockAlarmFactory>();
std::chrono::milliseconds const repeat_time{2};
std::chrono::milliseconds const repeat_delay{1};
std::shared_ptr<mi::InputDeviceObserver> observer;
NiceMock<mtd::MockInputDeviceHub> hub;
mi::KeyRepeatDispatcher dispatcher;
mir::EventUPtr a_key_down_event()
{
return mev::make_key_event(
test_device, std::chrono::nanoseconds(0), mir_keyboard_action_down, 0, 0,
mir_input_event_modifier_alt);
}
mir::EventUPtr a_meta_key_down_event()
{
return mev::make_key_event(
test_device, std::chrono::nanoseconds(0),
mir_keyboard_action_down, XKB_KEY_Shift_R, 0, mir_input_event_modifier_alt);
}
mir::EventUPtr a_key_up_event()
{
return mev::make_key_event(
test_device, std::chrono::nanoseconds(0), mir_keyboard_action_up, 0, 0,
mir_input_event_modifier_alt);
}
};
struct KeyRepeatDispatcherOnArale : KeyRepeatDispatcher
{
KeyRepeatDispatcherOnArale() : KeyRepeatDispatcher(true){};
MirInputDeviceId mtk_id = 32;
void add_mtk_tpd()
{
StubDevice dev(mtk_id, "mtk-tpd");
observer->device_added(mt::fake_shared(dev));
observer->changes_complete();
}
mir::EventUPtr mtk_key_down_event()
{
auto const home_button = 53;
return mev::make_key_event(
mtk_id, std::chrono::nanoseconds(0), mir_keyboard_action_down, 0,
home_button, mir_input_event_modifier_none);
}
};
}
TEST_F(KeyRepeatDispatcher, forwards_start_stop)
{
InSequence seq;
EXPECT_CALL(*mock_next_dispatcher, start()).Times(1);
EXPECT_CALL(*mock_next_dispatcher, stop()).Times(1);
dispatcher.start();
dispatcher.stop();
}
TEST_F(KeyRepeatDispatcher, schedules_alarm_to_repeat_key_down)
{
MockAlarm *mock_alarm = new MockAlarm; // deleted by AlarmFactory
std::function<void()> alarm_function;
InSequence seq;
EXPECT_CALL(*mock_alarm_factory, create_alarm_adapter(_)).Times(1).
WillOnce(DoAll(SaveArg<0>(&alarm_function), Return(mock_alarm)));
// Once for initial down and again when invoked
EXPECT_CALL(*mock_alarm, reschedule_in(repeat_time)).Times(1).WillOnce(Return(true));
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyDownEvent())).Times(1);
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyRepeatEvent())).Times(1);
EXPECT_CALL(*mock_alarm, reschedule_in(repeat_delay)).Times(1).WillOnce(Return(true));
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyUpEvent())).Times(1);
// Schedule the repeat
dispatcher.dispatch(a_key_down_event());
// Trigger the repeat
alarm_function();
// Trigger the cancel
dispatcher.dispatch(a_key_up_event());
}
TEST_F(KeyRepeatDispatcher, stops_repeat_on_device_removal)
{
MockAlarm *mock_alarm = new MockAlarm; // deleted by AlarmFactory
std::function<void()> alarm_function;
bool alarm_canceled = false;
InSequence seq;
EXPECT_CALL(*mock_alarm_factory, create_alarm_adapter(_)).Times(1).
WillOnce(DoAll(SaveArg<0>(&alarm_function), Return(mock_alarm)));
// Once for initial down and again when invoked
EXPECT_CALL(*mock_alarm, reschedule_in(repeat_time)).Times(1).WillOnce(Return(true));
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyDownEvent())).Times(1);
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyRepeatEvent())).Times(1);
EXPECT_CALL(*mock_alarm, reschedule_in(repeat_delay)).Times(1).WillOnce(Return(true));
ON_CALL(*mock_alarm, cancel()).WillByDefault(Invoke([&](){alarm_canceled = true; return true;}));
dispatcher.dispatch(a_key_down_event());
alarm_function();
Mock::VerifyAndClearExpectations(mock_alarm); // mock_alarm will be deleted after this
simulate_device_removal();
EXPECT_THAT(alarm_canceled, Eq(true));
}
TEST_F(KeyRepeatDispatcherOnArale, no_repeat_alarm_on_mtk_tpd)
{
EXPECT_CALL(*mock_alarm_factory, create_alarm_adapter(_)).Times(0);
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyDownEvent())).Times(1);
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyRepeatEvent())).Times(0);
add_mtk_tpd();
dispatcher.dispatch(mtk_key_down_event());
}
TEST_F(KeyRepeatDispatcherOnArale, repeat_for_regular_keys)
{
MockAlarm *mock_alarm = new MockAlarm; // deleted by AlarmFactory
std::function<void()> alarm_function;
EXPECT_CALL(*mock_alarm_factory, create_alarm_adapter(_)).Times(1).
WillOnce(DoAll(SaveArg<0>(&alarm_function), Return(mock_alarm)));
// Once for initial down and again when invoked
EXPECT_CALL(*mock_alarm, reschedule_in(repeat_delay)).Times(1).WillOnce(Return(true));
EXPECT_CALL(*mock_alarm, reschedule_in(repeat_time)).Times(1).WillOnce(Return(true));
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyDownEvent())).Times(1);
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyRepeatEvent())).Times(1);
add_mtk_tpd();
dispatcher.dispatch(a_key_down_event());
alarm_function();
}
TEST_F(KeyRepeatDispatcherOnArale, no_repeat_for_meta_keys)
{
ON_CALL(*mock_alarm_factory, create_alarm_adapter(_))
.WillByDefault(Throw(std::logic_error{"Alarm should not be created"}));
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyDownEvent())).Times(1);
EXPECT_CALL(*mock_next_dispatcher, dispatch(mt::KeyRepeatEvent())).Times(0);
add_mtk_tpd();
dispatcher.dispatch(a_meta_key_down_event());
}
|