1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
|
// Copyright (c) Microsoft Corporation. All rights reserved. See License.txt in the project root for license information.
using System.Collections.ObjectModel;
using System.Linq;
using System.Net;
using System.Net.Http;
using System.Web.Http.Controllers;
using System.Web.Http.Hosting;
using System.Web.Http.Routing;
using Moq;
using Xunit;
using Xunit.Extensions;
using Assert = Microsoft.TestCommon.AssertEx;
namespace System.Web.Http.Dispatcher
{
public class DefaultHttpControllerSelectorTest
{
[Fact]
public void Constructor_Throws_NullConfiguration()
{
Assert.ThrowsArgumentNull(
() => new DefaultHttpControllerSelector(configuration: null),
"configuration");
}
[Theory]
[InlineData("controller", "abc")]
[InlineData("Controller", "123")]
[InlineData("ControLler", "123")]
[InlineData("CONTROLLER", "ABC")]
public void GetControllerName_PicksControllerNameFromRouteData(string controllerKeyName, string controllerName)
{
// Arrange
HttpRequestMessage request = new HttpRequestMessage();
IHttpRouteData routeData = GetRouteData();
routeData.Values[controllerKeyName] = controllerName;
request.Properties[HttpPropertyKeys.HttpRouteDataKey] = routeData;
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(new HttpConfiguration());
// Act
string selectedControllerName = selector.GetControllerName(request);
// Assert
Assert.Equal(controllerName, selectedControllerName);
}
[Fact]
public void GetControllerName_PicksNull_NoRouteData()
{
// Arrange
HttpRequestMessage request = new HttpRequestMessage();
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(new HttpConfiguration());
// Act
string selectedControllerName = selector.GetControllerName(request);
// Assert
Assert.Null(selectedControllerName);
}
[Fact]
public void GetControllerName_PicksNull_EmptyRouteData()
{
// Arrange
HttpRequestMessage request = new HttpRequestMessage();
request.Properties[HttpPropertyKeys.HttpRouteDataKey] = GetRouteData();
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(new HttpConfiguration());
// Act
string selectedControllerName = selector.GetControllerName(request);
// Assert
Assert.Null(selectedControllerName);
}
[Fact]
public void DefaultHttpControllerSelector_Uses_IAssemblyResolverAndIHttpControllerTypeResolver()
{
// Arrange
HttpConfiguration configuration = new HttpConfiguration();
Mock<IAssembliesResolver> assemblyResolver = new Mock<IAssembliesResolver>();
Mock<IHttpControllerTypeResolver> controllerTypeResolver = new Mock<IHttpControllerTypeResolver>();
configuration.Services.Replace(typeof(IAssembliesResolver), assemblyResolver.Object);
configuration.Services.Replace(typeof(IHttpControllerTypeResolver), controllerTypeResolver.Object);
controllerTypeResolver.Setup(c => c.GetControllerTypes(assemblyResolver.Object)).Returns(new Collection<Type> { GetMockControllerType("Sample") }).Verifiable();
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(configuration);
HttpRequestMessage request = new HttpRequestMessage();
IHttpRouteData routeData = GetRouteData();
routeData.Values["controller"] = "Sample";
request.Properties[HttpPropertyKeys.HttpRouteDataKey] = routeData;
// Act
selector.SelectController(request);
// Assert
controllerTypeResolver.Verify();
}
[Theory]
[InlineData("Sample")]
[InlineData("SAmple")]
[InlineData("SAMPLE")]
public void SelectController_IsCaseInsensitive(string controllerTypeName)
{
HttpConfiguration configuration = new HttpConfiguration();
Mock<IHttpControllerTypeResolver> controllerTypeResolver = new Mock<IHttpControllerTypeResolver>();
configuration.Services.Replace(typeof(IHttpControllerTypeResolver), controllerTypeResolver.Object);
Type controllerType = GetMockControllerType("Sample");
controllerTypeResolver
.Setup(c => c.GetControllerTypes(It.IsAny<IAssembliesResolver>()))
.Returns(new Collection<Type> { controllerType });
HttpRequestMessage request = new HttpRequestMessage();
IHttpRouteData routeData = GetRouteData();
routeData.Values["controller"] = controllerTypeName;
request.Properties[HttpPropertyKeys.HttpRouteDataKey] = routeData;
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(configuration);
// Act
HttpControllerDescriptor descriptor = selector.SelectController(request);
// Assert
Assert.IsType(typeof(HttpControllerDescriptor), descriptor);
Assert.Equal(controllerType, descriptor.ControllerType);
}
[Fact]
public void SelectController_DoesNotCreateNewInstances_ForSameController()
{
HttpConfiguration configuration = new HttpConfiguration();
Mock<IHttpControllerTypeResolver> controllerTypeResolver = new Mock<IHttpControllerTypeResolver>();
configuration.Services.Replace(typeof(IHttpControllerTypeResolver), controllerTypeResolver.Object);
Type controllerType = GetMockControllerType("Sample");
controllerTypeResolver
.Setup(c => c.GetControllerTypes(It.IsAny<IAssembliesResolver>()))
.Returns(new Collection<Type> { controllerType });
HttpRequestMessage request = new HttpRequestMessage();
IHttpRouteData routeData = GetRouteData();
routeData.Values["controller"] = "Sample";
request.Properties[HttpPropertyKeys.HttpRouteDataKey] = routeData;
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(configuration);
// Act
HttpControllerDescriptor descriptor1 = selector.SelectController(request);
HttpControllerDescriptor descriptor2 = selector.SelectController(request);
// Assert
Assert.ReferenceEquals(descriptor1, descriptor2);
}
[Fact]
public void SelectController_DoesNotCreateNewInstances_ForSameController_DiferentCasedControllerName()
{
HttpConfiguration configuration = new HttpConfiguration();
Mock<IHttpControllerTypeResolver> controllerTypeResolver = new Mock<IHttpControllerTypeResolver>();
configuration.Services.Replace(typeof(IHttpControllerTypeResolver), controllerTypeResolver.Object);
Type controllerType = GetMockControllerType("Sample");
controllerTypeResolver
.Setup(c => c.GetControllerTypes(It.IsAny<IAssembliesResolver>()))
.Returns(new Collection<Type> { controllerType });
HttpRequestMessage request1 = new HttpRequestMessage();
IHttpRouteData routeData1 = GetRouteData();
routeData1.Values["controller"] = "Sample";
request1.Properties[HttpPropertyKeys.HttpRouteDataKey] = routeData1;
HttpRequestMessage request2 = new HttpRequestMessage();
IHttpRouteData routeData2 = GetRouteData();
routeData2.Values["controller"] = "SaMPle";
request2.Properties[HttpPropertyKeys.HttpRouteDataKey] = routeData2;
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(configuration);
// Act
HttpControllerDescriptor descriptor1 = selector.SelectController(request1);
HttpControllerDescriptor descriptor2 = selector.SelectController(request2);
// Assert
Assert.ReferenceEquals(descriptor1, descriptor2);
}
[Fact]
public void SelectController_Throws_NullRequest()
{
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(new HttpConfiguration());
Assert.ThrowsArgumentNull(
() => selector.SelectController(request: null),
"request");
}
[Fact]
public void SelectController_Throws_NotFound_NoControllerInRouteData()
{
HttpConfiguration configuration = new HttpConfiguration();
HttpRequestMessage request = new HttpRequestMessage();
request.Properties[HttpPropertyKeys.HttpRouteDataKey] = GetRouteData();
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(configuration);
// Act
var ex = Assert.Throws<HttpResponseException>(
() => selector.SelectController(request));
// Assert
Assert.Equal(HttpStatusCode.NotFound, ex.Response.StatusCode);
}
[Fact]
public void SelectController_Throws_NotFound_NoRouteData()
{
HttpConfiguration configuration = new HttpConfiguration();
HttpRequestMessage request = new HttpRequestMessage();
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(configuration);
// Act
var ex = Assert.Throws<HttpResponseException>(
() => selector.SelectController(request));
// Assert
Assert.Equal(HttpStatusCode.NotFound, ex.Response.StatusCode);
}
[Fact]
public void SelectController_Throws_NotFound_NoMatchingControllerType()
{
HttpConfiguration configuration = new HttpConfiguration();
Mock<IHttpControllerTypeResolver> controllerTypeResolver = new Mock<IHttpControllerTypeResolver>();
configuration.Services.Replace(typeof(IHttpControllerTypeResolver), controllerTypeResolver.Object);
controllerTypeResolver
.Setup(c => c.GetControllerTypes(It.IsAny<IAssembliesResolver>()))
.Returns(new Collection<Type>());
HttpRequestMessage request = new HttpRequestMessage();
IHttpRouteData routeData1 = GetRouteData();
routeData1.Values["controller"] = "Sample";
request.Properties[HttpPropertyKeys.HttpRouteDataKey] = routeData1;
request.Properties[HttpPropertyKeys.HttpConfigurationKey] = configuration;
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(configuration);
// Act
var ex = Assert.Throws<HttpResponseException>(
() => selector.SelectController(request));
// Assert
Assert.Equal(HttpStatusCode.NotFound, ex.Response.StatusCode);
Assert.Equal("\"No type was found that matches the controller named 'Sample'.\"", ex.Response.Content.ReadAsStringAsync().Result);
}
[Fact]
public void SelectController_Throws_DuplicateController()
{
HttpConfiguration configuration = new HttpConfiguration();
Mock<IHttpControllerTypeResolver> controllerTypeResolver = new Mock<IHttpControllerTypeResolver>();
configuration.Services.Replace(typeof(IHttpControllerTypeResolver), controllerTypeResolver.Object);
controllerTypeResolver
.Setup(c => c.GetControllerTypes(It.IsAny<IAssembliesResolver>()))
.Returns(new Collection<Type> { GetMockControllerType("Sample"), GetMockControllerType("SampLe"), GetMockControllerType("SAmpLE") });
HttpRequestMessage request = new HttpRequestMessage();
IHttpRouteData routeData1 = GetRouteData();
routeData1.Values["controller"] = "Sample";
request.Properties[HttpPropertyKeys.HttpRouteDataKey] = routeData1;
request.Properties[HttpPropertyKeys.HttpConfigurationKey] = configuration;
DefaultHttpControllerSelector selector = new DefaultHttpControllerSelector(configuration);
// Act
var ex = Assert.Throws<HttpResponseException>(
() => selector.SelectController(request));
// Assert
Assert.Equal(HttpStatusCode.InternalServerError, ex.Response.StatusCode);
string response = ex.Response.Content.ReadAsAsync<string>().Result;
Assert.Contains(
"Multiple types were found that match the controller named 'Sample'. This can happen if the route that services this request ('') found multiple controllers defined with the same name but differing namespaces, which is not supported.\r\n\r\nThe request for 'Sample' has found the following matching controllers:",
response);
var duplicateControllers = response.Split(':')[1].Split('\n').Select(str => str.Trim());
Assert.Contains("FullSampleController", duplicateControllers);
Assert.Contains("FullSampLeController", duplicateControllers);
Assert.Contains("FullSAmpLEController", duplicateControllers);
}
private static IHttpRouteData GetRouteData()
{
IHttpRoute mockRoute = new Mock<IHttpRoute>().Object;
HttpRouteData routeData = new HttpRouteData(mockRoute);
return routeData;
}
private static Type GetMockControllerType(string controllerName)
{
Mock<Type> mockType = new Mock<Type>();
mockType.Setup(t => t.Name).Returns(controllerName + "Controller");
mockType.Setup(t => t.FullName).Returns("Full" + controllerName + "Controller");
mockType.Setup(t => t.GetCustomAttributes(typeof(HttpControllerConfigurationAttribute), It.IsAny<bool>()))
.Returns(new HttpControllerConfigurationAttribute[0]);
return mockType.Object;
}
}
}
|
