1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379
|
// Copyright (c) Microsoft Corporation. All rights reserved. See License.txt in the project root for license information.
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using System.Threading.Tasks;
using Moq;
using Xunit;
using Assert = Microsoft.TestCommon.AssertEx;
namespace System.Web.Mvc.Async.Test
{
public class AsyncActionMethodSelectorTest
{
[Fact]
public void AliasedMethodsProperty()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
// Act
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Assert
Assert.Equal(3, selector.AliasedMethods.Length);
List<MethodInfo> sortedAliasedMethods = selector.AliasedMethods.OrderBy(methodInfo => methodInfo.Name).ToList();
Assert.Equal("Bar", sortedAliasedMethods[0].Name);
Assert.Equal("FooRenamed", sortedAliasedMethods[1].Name);
Assert.Equal("Renamed", sortedAliasedMethods[2].Name);
}
[Fact]
public void ControllerTypeProperty()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act & Assert
Assert.Same(controllerType, selector.ControllerType);
}
[Fact]
public void FindAction_DoesNotMatchAsyncMethod()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act
ActionDescriptorCreator creator = selector.FindAction(null, "EventPatternAsync");
// Assert
Assert.Null(creator);
}
[Fact]
public void FindAction_DoesNotMatchCompletedMethod()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act
ActionDescriptorCreator creator = selector.FindAction(null, "EventPatternCompleted");
// Assert
Assert.Null(creator);
}
[Fact]
public void FindAction_ReturnsMatchingMethodIfOneMethodMatches()
{
// Arrange
Type controllerType = typeof(SelectionAttributeController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act
ActionDescriptorCreator creator = selector.FindAction(null, "OneMatch");
ActionDescriptor actionDescriptor = creator("someName", new Mock<ControllerDescriptor>().Object);
// Assert
var castActionDescriptor = Assert.IsType<ReflectedActionDescriptor>(actionDescriptor);
Assert.Equal("OneMatch", castActionDescriptor.MethodInfo.Name);
Assert.Equal(typeof(string), castActionDescriptor.MethodInfo.GetParameters()[0].ParameterType);
}
[Fact]
public void FindAction_ReturnsMethodWithActionSelectionAttributeIfMultipleMethodsMatchRequest()
{
// DevDiv Bugs 212062: If multiple action methods match a request, we should match only the methods with an
// [ActionMethod] attribute since we assume those methods are more specific.
// Arrange
Type controllerType = typeof(SelectionAttributeController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act
ActionDescriptorCreator creator = selector.FindAction(null, "ShouldMatchMethodWithSelectionAttribute");
ActionDescriptor actionDescriptor = creator("someName", new Mock<ControllerDescriptor>().Object);
// Assert
var castActionDescriptor = Assert.IsType<ReflectedActionDescriptor>(actionDescriptor);
Assert.Equal("MethodHasSelectionAttribute1", castActionDescriptor.MethodInfo.Name);
}
[Fact]
public void FindAction_ReturnsNullIfNoMethodMatches()
{
// Arrange
Type controllerType = typeof(SelectionAttributeController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act
ActionDescriptorCreator creator = selector.FindAction(null, "ZeroMatch");
// Assert
Assert.Null(creator);
}
[Fact]
public void FindAction_ThrowsIfMultipleMethodsMatch()
{
// Arrange
Type controllerType = typeof(SelectionAttributeController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act & veriy
Assert.Throws<AmbiguousMatchException>(
delegate { selector.FindAction(null, "TwoMatch"); },
@"The current request for action 'TwoMatch' on controller type 'SelectionAttributeController' is ambiguous between the following action methods:
Void TwoMatch2() on type System.Web.Mvc.Async.Test.AsyncActionMethodSelectorTest+SelectionAttributeController
Void TwoMatch() on type System.Web.Mvc.Async.Test.AsyncActionMethodSelectorTest+SelectionAttributeController");
}
[Fact]
public void FindActionMethod_Asynchronous()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act
ActionDescriptorCreator creator = selector.FindAction(null, "EventPattern");
ActionDescriptor actionDescriptor = creator("someName", new Mock<ControllerDescriptor>().Object);
// Assert
var castActionDescriptor = Assert.IsType<ReflectedAsyncActionDescriptor>(actionDescriptor);
Assert.Equal("EventPatternAsync", castActionDescriptor.AsyncMethodInfo.Name);
Assert.Equal("EventPatternCompleted", castActionDescriptor.CompletedMethodInfo.Name);
}
[Fact]
public void FindActionMethod_Task()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act
ActionDescriptorCreator creator = selector.FindAction(null, "TaskPattern");
ActionDescriptor actionDescriptor = creator("someName", new Mock<ControllerDescriptor>().Object);
// Assert
var castActionDescriptor = Assert.IsType<TaskAsyncActionDescriptor>(actionDescriptor);
Assert.Equal("TaskPattern", castActionDescriptor.TaskMethodInfo.Name);
Assert.Equal(typeof(Task), castActionDescriptor.TaskMethodInfo.ReturnType);
}
[Fact]
public void FindActionMethod_GenericTask()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act
ActionDescriptorCreator creator = selector.FindAction(null, "GenericTaskPattern");
ActionDescriptor actionDescriptor = creator("someName", new Mock<ControllerDescriptor>().Object);
// Assert
var castActionDescriptor = Assert.IsType<TaskAsyncActionDescriptor>(actionDescriptor);
Assert.Equal("GenericTaskPattern", castActionDescriptor.TaskMethodInfo.Name);
Assert.Equal(typeof(Task<string>), castActionDescriptor.TaskMethodInfo.ReturnType);
}
[Fact]
public void FindActionMethod_Asynchronous_ThrowsIfCompletionMethodNotFound()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act & assert
Assert.Throws<InvalidOperationException>(
delegate { ActionDescriptorCreator creator = selector.FindAction(null, "EventPatternWithoutCompletionMethod"); },
@"Could not locate a method named 'EventPatternWithoutCompletionMethodCompleted' on controller type System.Web.Mvc.Async.Test.AsyncActionMethodSelectorTest+MethodLocatorController.");
}
[Fact]
public void FindActionMethod_Asynchronous_ThrowsIfMultipleCompletedMethodsMatched()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Act & assert
Assert.Throws<AmbiguousMatchException>(
delegate { ActionDescriptorCreator creator = selector.FindAction(null, "EventPatternAmbiguous"); },
@"Lookup for method 'EventPatternAmbiguousCompleted' on controller type 'MethodLocatorController' failed because of an ambiguity between the following methods:
Void EventPatternAmbiguousCompleted(Int32) on type System.Web.Mvc.Async.Test.AsyncActionMethodSelectorTest+MethodLocatorController
Void EventPatternAmbiguousCompleted(System.String) on type System.Web.Mvc.Async.Test.AsyncActionMethodSelectorTest+MethodLocatorController");
}
[Fact]
public void NonAliasedMethodsProperty()
{
// Arrange
Type controllerType = typeof(MethodLocatorController);
// Act
AsyncActionMethodSelector selector = new AsyncActionMethodSelector(controllerType);
// Assert
Assert.Equal(6, selector.NonAliasedMethods.Count);
List<MethodInfo> sortedMethods = selector.NonAliasedMethods["foo"].OrderBy(methodInfo => methodInfo.GetParameters().Length).ToList();
Assert.Equal("Foo", sortedMethods[0].Name);
Assert.Empty(sortedMethods[0].GetParameters());
Assert.Equal("Foo", sortedMethods[1].Name);
Assert.Equal(typeof(string), sortedMethods[1].GetParameters()[0].ParameterType);
Assert.Equal(1, selector.NonAliasedMethods["EventPattern"].Count());
Assert.Equal("EventPatternAsync", selector.NonAliasedMethods["EventPattern"].First().Name);
Assert.Equal(1, selector.NonAliasedMethods["EventPatternAmbiguous"].Count());
Assert.Equal("EventPatternAmbiguousAsync", selector.NonAliasedMethods["EventPatternAmbiguous"].First().Name);
Assert.Equal(1, selector.NonAliasedMethods["EventPatternWithoutCompletionMethod"].Count());
Assert.Equal("EventPatternWithoutCompletionMethodAsync", selector.NonAliasedMethods["EventPatternWithoutCompletionMethod"].First().Name);
Assert.Equal(1, selector.NonAliasedMethods["TaskPattern"].Count());
Assert.Equal("TaskPattern", selector.NonAliasedMethods["TaskPattern"].First().Name);
Assert.Equal(1, selector.NonAliasedMethods["GenericTaskPattern"].Count());
Assert.Equal("GenericTaskPattern", selector.NonAliasedMethods["GenericTaskPattern"].First().Name);
}
private class MethodLocatorController : Controller
{
public void Foo()
{
}
public void Foo(string s)
{
}
[ActionName("Foo")]
public void FooRenamed()
{
}
[ActionName("Bar")]
public void Bar()
{
}
[ActionName("PrivateVoid")]
private void PrivateVoid()
{
}
protected void ProtectedVoidAction()
{
}
public static void StaticMethod()
{
}
public void EventPatternAsync()
{
}
public void EventPatternCompleted()
{
}
public void EventPatternWithoutCompletionMethodAsync()
{
}
public void EventPatternAmbiguousAsync()
{
}
public void EventPatternAmbiguousCompleted(int i)
{
}
public void EventPatternAmbiguousCompleted(string s)
{
}
public Task TaskPattern()
{
return Task.Factory.StartNew(() => "foo");
}
public Task<string> GenericTaskPattern()
{
return Task.Factory.StartNew(() => "foo");
}
[ActionName("RenamedCompleted")]
public void Renamed()
{
}
// ensure that methods inheriting from Controller or a base class are not matched
[ActionName("Blah")]
protected override void ExecuteCore()
{
throw new NotImplementedException();
}
public string StringProperty { get; set; }
#pragma warning disable 0067
public event EventHandler<EventArgs> SomeEvent;
#pragma warning restore 0067
}
private class SelectionAttributeController : Controller
{
[Match(false)]
public void OneMatch()
{
}
public void OneMatch(string s)
{
}
public void TwoMatch()
{
}
[ActionName("TwoMatch")]
public void TwoMatch2()
{
}
[Match(true), ActionName("ShouldMatchMethodWithSelectionAttribute")]
public void MethodHasSelectionAttribute1()
{
}
[ActionName("ShouldMatchMethodWithSelectionAttribute")]
public void MethodDoesNotHaveSelectionAttribute1()
{
}
private class MatchAttribute : ActionMethodSelectorAttribute
{
private bool _match;
public MatchAttribute(bool match)
{
_match = match;
}
public override bool IsValidForRequest(ControllerContext controllerContext, MethodInfo methodInfo)
{
return _match;
}
}
}
}
}
|